March 2011 - Wine-Devel - list.winehq.org

Re: olefont - fixed initial cyLogical value in IFont constructor. fixed get_Size to return same value as Window. (try 2)
by Marvin March 5, 2011

March 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9673 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: WineHQ Bug 26271
by Dan Kegel March 4, 2011

March 4, 2011

Dmitry Timoshkov wrote: > Are you going to encourage packagers to include whatever patches > they deem to be "an important feature" for the users, and still claim > that provide an official Wine binary package? There's a middle ground: ship both vanilla and patched wine, and make vanilla the default. I can even imagine distros packaging them up so they can both be installed at the same time. For instance, vanilla wine might be /usr/bin/wine as usual, but one patched for bug 6971 might be /usr/libexec/wine/wine-1.3-hotfix-6971/bin/wine. The patched one would be buried (kind of like gcc's internal files are buried) so they're easy for frontends like winetricks to use when present, but hard for casual users to accidentally use. Bug 6971 is the only one that comes to mind immediately as worth the effort, as it makes many games unplayable ( http://appdb.winehq.org/viewbugs.php?bug_id=6971 ). It occurs to me that fixing or providing a hotfix for this one bug, would get rid of most of PlayOnLinux's incentive to provide their own patched builds of wine. - Dan

1 0

Re: ws2_32: sendmsg on OS/X and BSD returns EMSGSIZE error for size 0
by Alexandre Julliard March 4, 2011

March 4, 2011

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1781,6 +1781,9 @@ static int WS2_send( int fd, struct ws2_async *wsa ) > wsa->iovec[wsa->first_iovec].iov_len -= n; > } > } > + /* BSD and OS/X return EMSGSIZE if hdr.msg_iovlen is 0 */ > + else if ( hdr.msg_iovlen == 0 && errno == EMSGSIZE) > + ret = 0; This should never happen. We should always have at least one iov at that point, the callers should make sure of that. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: wininet(5/6): Obey cache directives and flags regarding caching
by Alexandre Julliard March 4, 2011

March 4, 2011

Juan Lang <juan.lang(a)gmail.com> writes: > From 13fce7b5e1efa74219d334bbce6661bd49a00601 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Wed, 2 Mar 2011 10:41:12 -0800 > Subject: [PATCH 08/19] Obey cache directives and flags regarding caching It fails here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:661: Test failed: expected ReportProgress_CACHEFILENAMEAVAILABLE Also the url.c test hangs forever. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Implement FindNextUrlCacheEntryW
by Alexandre Julliard March 4, 2011

March 4, 2011

Juan Lang <juan.lang(a)gmail.com> writes: > Brought to you by copy and paste. There's no reason to duplicate all that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fixed default cyLogical in IFont constructor
by Marvin March 4, 2011

March 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9650 Your paranoid android. === WNT4WSSP6 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2KPROSP4 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === WXPPROSP3 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2K3R2SESP2 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === WVISTAADM (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2K8SE (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PRO (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PROX64 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PROX64 (64 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0.

1 0

RFC: mmap override patch #2
by Chris Robinson March 3, 2011

March 3, 2011

An updated attempt at the mmap override patch that I previously sent. This version properly uses a signed type for the mmap wrapper (as off_t/off64_t are signed types), fixes a few things with the munmap wrapper relating to truncated and sliced file_views, and implements a mremap wrapper for Linux. There's some debugging stuff left in the mremap wrapper since I have yet to catch anything that uses it, particularly using ERR instead of TRACE and an explicit abort() call so it isn't missed. There's also a %lld formatter in the mmap wrapper that will be fixed later. I'd be interested to hear how well it does or doesn't work, as well as any comments or critiques on the code.

1 0

Please help me with document extraction.
by Max TenEyck Woodbury March 3, 2011

March 3, 2011

As my previous efforts have probably informed you, I am interested in documentation. My initial efforts were _not_ on target and had missed the existing 'c2man.pl' tool. I am in the process of correcting my failure on that. I've picked up Perl in the last couple weeks. An interesting language with lots of adopted features. It's been easy to learn, so I think I will _not_ need help with the language itself, but I will listen to any advice. The c2man.pl code is extensive and sparsely commented. In order to understand what it does, I've made a transcription of it with a more compact style and lots more comments. I check the rewrite against the source code so there should not be any serious errors. There are also a number of what I believe to be defects in the original and places where my comments may be inappropriate or my style may be very objectionable. _This_ is what I need help with. Would someone be willing to review my rewrite? If so, send me e-mail so I can arrange to get a copy of it to you. P.S. to AJ et al. There is a _lot_ of documentation embedded in the wine code, but it is hard to find at the moment. I'd like to see it indexed and this is the program that does the extraction and indexing. Advice on making this new version available and active are in order. Max

4 11

Re: wininet(2/6): Store entries in url cache with valid expiration date
by Alexandre Julliard March 3, 2011

March 3, 2011

Juan Lang <juan.lang(a)gmail.com> writes: > + if (ret) > + { > + ret = FALSE; > + num = strtoulW(ptr, &nextPtr, 10); > + if (nextPtr > ptr && *nextPtr == ':' && num <= 59) > + { > + ptr = nextPtr + 1; > + st.wMinute = (WORD)num; > + ret = TRUE; > + } > + } > + if (ret) > + { > + ret = FALSE; > + num = strtoulW(ptr, &nextPtr, 10); > + if (nextPtr > ptr && isspaceW(*nextPtr) && num <= 59) > + { > + ptr = nextPtr + 1; > + st.wSecond = (WORD)num; > + ret = TRUE; > + } > + } > + if (ret) > + { > + static const WCHAR gmt[]= { 'G','M','T',0 }; > + > + ret = FALSE; > + while (isspaceW(*ptr)) > + ptr++; > + if (!strcmpW(ptr, gmt)) > + ret = TRUE; > + } You may want to consider using 'return', it's quite convenient... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements
by Alexandre Julliard March 3, 2011

March 3, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > + /* FIXME: Implement in more generic and safe way */ > + for(ptr = name; *ptr && isdigitW(*ptr); ptr++) > + i = i*10 + (*ptr-'0'); What's wrong with strtoulW? -- Alexandre Julliard julliard(a)winehq.org

2 2