April 2011 - Wine-Devel - list.winehq.org

Re: Fix to bug 25504 for gnutls based schannel
by Hans Leidekker April 18, 2011

April 18, 2011

On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote: > #ifdef SONAME_LIBGNUTLS > #include <gnutls/gnutls.h> > +#include <gcrypt.h> > +#include <pthread.h> > +#include <errno.h> > +GCRY_THREAD_OPTION_PTHREAD_IMPL; You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.

5 6

Re: [PATCH 02/10] msvcrt: Use callback based printf in cprintf functions family
by Alexandre Julliard April 18, 2011

April 18, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > +printf_arg arg_clbk_valist(void *ctx, int arg_pos, size_t size, __ms_va_list *valist) > +{ > + printf_arg ret; > + > + if(size == sizeof(LONGLONG)) > + ret.get_longlong = va_arg(*valist, LONGLONG); > + else if(size == sizeof(int)) > + ret.get_int = va_arg(*valist, int); > + else { > + ERR("Incorrect size\n"); > + ret.get_int = 0; > + } You can't do that, you need to use the correct type in va_arg. Different types can be passed differently even if they have the same size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] Fix d3dx9_parse_effect_typedef for stuctures.
by Rico Schüller April 18, 2011

April 18, 2011

The patch has the wrong description, I'll fix and resend that. Am 18.04.2011 10:26, schrieb Rico Schüller: > --- > dlls/d3dx9_36/effect.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > >

1 0

Re: Wine: Use the compiler option -Wpointer-arith if available.
by Michael Stefaniuc April 17, 2011

April 17, 2011

On 04/17/2011 01:19 AM, Gerald Pfeifer wrote: > GCC provides an option -Wpointer-arith and describes it as follows: > > Warn about anything that depends on the "size of" a function type > or of `void'. GNU C assigns these types a size of 1, for > convenience in calculations with `void *' pointers and pointers to > functions. > > This does not trigger on my Wine builds, but then we should not invoke Of course it doesn't triggers in Wine as -Wpointer-arith is already enabled. I made heavy use of that when I did my pointer cast killing spree a few years ago. > sizeof(void) or sizeof(some_function). ;-) It should help catch any > such bad future uses of sizeof. > > Gerald > --- > configure.ac | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6047744..0ae6625 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1715,6 +1715,7 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > + WINE_TRY_CFLAGS([-Wpointer-arith]) > WINE_TRY_CFLAGS([-Wstrict-prototypes]) > WINE_TRY_CFLAGS([-Wtype-limits]) > WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) bye michael

2 1

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs
by Gerold Jens Wucherpfennig April 17, 2011

April 17, 2011

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs. I think it's not allowed to do a "winedump <dllname>.lib" But what to do else? Regards Gerold

3 3

Re: crypt32: Fix length-handling of 'decodeBase64Block'
by Marvin April 16, 2011

April 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10497 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

RAS.h
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I want to complete the rasapi32.dll, but the header file RAS.h of wine is incomplete. It hasn't been changed since 1998. >From where may I copy the missing parts? >From the Windows SDK documentation? I think I may not be allowed to directly copy it from Windows' ras.h Best Regards Gerold

2 1

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

2 1

Windres and wine
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

2 1

Re: inetcpl: Update French translation
by Nicolas Le Cam April 15, 2011

April 15, 2011

Hi Frédéric, Le 13 avril 2011 23:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > --- > dlls/inetcpl.cpl/cpl_Fr.rc | 42 > +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 41 insertions(+), 1 deletions(-) > > diff --git a/dlls/inetcpl.cpl/cpl_Fr.rc b/dlls/inetcpl.cpl/cpl_Fr.rc > index 1244ff6..432a8c3 100644 > --- a/dlls/inetcpl.cpl/cpl_Fr.rc > +++ b/dlls/inetcpl.cpl/cpl_Fr.rc > @@ -2,7 +2,7 @@ > * Internet control panel applet > * French language support > * > - * Copyright 2010 Frédéric Delanoy > + * Copyright 2010-2011 Frédéric Delanoy > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -49,6 +49,46 @@ BEGIN > > END > > +/* "Delete browsing history" dialog */ > +IDD_DELETE_HISTORY DIALOG 0, 0, 250, 250 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +FONT 8, "MS Shell Dlg" > +CAPTION "Effacer l'historique de navigation" > +BEGIN > + > + AUTOCHECKBOX "Fichiers internet temporaires\nCopies en cache de > pages web, d'images et de certificats.", > + IDC_DELETE_TEMP_FILES, 10, 8, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Cookies\nFichiers sauvés sur votre ordinateur par des > sites web, qui y stockent des informations comme des préférences utilisateur > et des informations de connexion", > You should use sauvegardés instead of sauvés which doesn't apply to computers. I would also use "qui y stockent des choses comme les préférences utilisateurs et les informations de connexion". It better follows the original text and avoid a repetition. > + IDC_DELETE_COOKIES, 10, 32, 230, 35, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Historique\nListe des sites web accédés.", > + IDC_DELETE_HISTORY, 10, 73, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Données de formulaires\nNoms d'utilisateur et autres > informations entrées dans des formulaires.", > + IDC_DELETE_FORM_DATA, 10, 98, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Mots de passe\nMots de passe entrés dans des > formulaires et sauvegardés.", > + IDC_DELETE_PASSWORDS, 10, 128, 230, 30, BS_TOP | > BS_MULTILINE > + DEFPUSHBUTTON "Annuler", IDCANCEL, 185, 228, 60, 15, WS_GROUP > + PUSHBUTTON "Effacer", IDOK, 120, 228, 60, 15, WS_GROUP > + > +END > + > +/* "Security" propsheet */ > +IDD_SECURITY DIALOG 0, 0, 320, 220 > +STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > +FONT 8, "MS Shell Dlg" > +CAPTION "Security" > +BEGIN > + > + CONTROL "Listview", IDC_SEC_LISTVIEW, "SysListView32", > + LVS_ICON | LVS_ALIGNLEFT | LVS_AUTOARRANGE | LVS_SINGLESEL > | LVS_SHOWSELALWAYS | WS_BORDER | WS_VSCROLL, > + 4, 4, 312, 58 > + LTEXT "", IDC_SEC_ZONE_INFO, 4, 68, 312, 20 > + GROUPBOX "", IDC_SEC_GROUP, 4, 88, 312, 126 > + CONTROL "trackbar", IDC_SEC_TRACKBAR, "msctls_trackbar32", > + TBS_VERT | TBS_AUTOTICKS | TBS_BOTH | TBS_REVERSED, 8, 98, > 32, 100 > + LTEXT "", IDC_SEC_LEVEL, 48, 102, 180, 12 > + LTEXT "", IDC_SEC_LEVEL_INFO, 48, 114, 260, 80 > +END > + > /* "Content" propsheet */ > IDD_CONTENT DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > -- > 1.7.4.3 > > > > -- Nicolas Le Cam

3 2

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig April 15, 2011

April 15, 2011

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

1 0

Re: winedevice: eliminate some globals
by Alexandre Julliard April 15, 2011

April 15, 2011

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate some globals > > The long term goal of this patch is to make the driver loading code > reusable for loading drivers outside winedevice, for use with USB > drivers etc. It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\ err=5 should be 3 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\removeme\ err=5 should be 3 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:944: Test failed: CreateFileA failed on \\?\C:, hFile 0xffffffff, err=2, should be 0 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for \\?\C:\ err=5 should be 3 file.c:1000: Test failed: CreateFileA did not open \\?\C:, last error=2 file.c:1059: Test failed: CreateFileA did not open \\.\C:, last error=2 file.c:1078: Test failed: GetVolumeNameForVolumeMountPointA failed, for C:\, last error=2 file.c:1157: Test failed: GetVolumeNameForVolumeMountPointA not functioning make: *** [file.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Windres and wine
by Gerold Jens Wucherpfennig April 15, 2011

April 15, 2011

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

1 0

Quartz Driver patches (NOT for inclusion in Wine)
by Charles Davis April 15, 2011

April 15, 2011

Hi, A while ago, I started work on my own Quartz Driver. This was before I finished my "Deobjectivizer" tool, so only some of the pure Quartz stuff (no Cocoa) is implemented. My intent after finishing "Deobjectivizer" was to start implementing windowing and other vital pieces of the driver (i.e. the pieces that need Cocoa to work). I know now that CodeWeavers is working on their own version of the Quartz Driver. So, I don't need to continue working on this. That's why I've decided to post all of my Quartz Driver patches here, on the off-chance that CW may wish to use some of them. They are all licensed under the LGPL 2.1, the same license as Wine itself. If they don't want to use any of them, that's OK. I just thought we could get this done faster if we took some of the work that I and others have done. If this is the wrong place to post this, I apologize, and I would really appreciate a pointer in the right direction. Chip

1 0

Try to implement my first stub function - AbortPrinter() - (try 4)
by Loïc Maury April 15, 2011

April 15, 2011

Hello, From what was said from the last comments, I have modified the code and I have added the test patch. What do you think ? Thank you Loïc

2 2

RE: winex11: Retrieve raw mouse events through XInput2 while the cursor is clipped.
by Vitaliy Margolen April 15, 2011

April 15, 2011

It's great to see so much progress in this area! Great gob so far. However this isn't enough. Cursor doesn't have to be clipped to receive mouse event's. As far as dinput goes, it will read mouse events regardless where the pointer is if device is acquired in background mode. Or this isn't the final commit yet? Vitaliy.

2 1

Re: wintrust: add a stub for IsCatalogFile()
by Juan Lang April 14, 2011

April 14, 2011

Hi Austin, it wouldn't be hard to implement this with CryptSIPRetrieveSubjectGuid: if it returns the GUID for .cat files, return TRUE. --Juan

1 0

Re: [PATCH] Allow for RPC_S_NO_CONTEXT_AVAILABLE return status
by Alexandre Julliard April 14, 2011

April 14, 2011

"Ray Hinchliffe (RH)" <ray(a)rh-software.com> writes: > @@ -196,7 +196,8 @@ static RpcPktHdr *handle_bind_error(RpcConnection *conn, RPC_STATUS error) > default: > FIXME("unexpected status value %d\n", error); > /* fall through */ > - case RPC_S_INVALID_BOUND: > + case RPC_S_INVALID_BOUND: > + case RPC_S_NO_CONTEXT_AVAILABLE: > reject_reason = REJECT_REASON_NOT_SPECIFIED; > break; Please explain why this happens and why this is the right error to return. -- Alexandre Julliard julliard(a)winehq.org

1 0

debugging wine itself with GDB
by joedude＠winedev1.nospam.homeip.net April 13, 2011

April 13, 2011

I was taking a look at http://wiki.jswindle.com/index.php/Debugging_Wine to see how to debug wine with gdb, and there was reference to starting up gdb using wine-pthread, but I see no such executable now. I can attach gdb after it starts to run, but then do not get all the symbol information. There is wine-preloader but it seems to want an ELF file as an argument.

2 1

massively "skipped" tests being shown
by Saulius Krasuckas April 13, 2011

April 13, 2011

Hello, there is something wrong with WRT result page/parser [1] (or with TestBot too) since yesterday. All tests' results from TestBot are shown as "skipped by user request", eg. for XP [2]. Results from physical machines are present, currently only one (af-xpsp3-nv) which shows 12 failures. But in the daily summary we see 28 failures for XP. [3] Sounds like a bug or two:) S. [1] http://test.winehq.org/data/ [2] http://test.winehq.org/data/e5c3883c923d345848315a39a090607bdddac936/index_… [3] http://test.winehq.org/data/e5c3883c923d345848315a39a090607bdddac936/

2 1

Re: [PATCH 2/4] inetcpl: Fill the security listview with zones
by Nikolay Sivov April 13, 2011

April 13, 2011

Some minor things regarding listview. On Wed, Apr 13, 2011 at 7:33 AM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > --- > dlls/inetcpl.cpl/security.c | 131 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 131 insertions(+), 0 deletions(-) > > +static void add_zone_to_listview(secdlg_data *sd, DWORD *pindex, DWORD zone) > +{ > + DWORD lv_index = *pindex; > + ZONEATTRIBUTES *za = &sd->zone_attr[lv_index]; > + LVITEMW lvitem; > + HRESULT hr; > + INT iconid = 0; > + HMODULE hdll = NULL; > + WCHAR * ptr; > + HICON icon; > + > + TRACE("item %d (zone %d)\n", lv_index, zone); > + > + sd->zones[lv_index] = zone; > + > + memset(&lvitem, 0, sizeof(LVITEMW)); This reset shouldn't be needed, cause control checks for mask field and doesn't access other fields. > + > + if (ListView_InsertItemW(sd->hlv, &lvitem) >= 0) { > + /* activate first item in the listview */ > + if (! lv_index) { > + lvitem.state = LVIS_FOCUSED | LVIS_SELECTED; > + lvitem.stateMask = LVIS_FOCUSED | LVIS_SELECTED; > + SendMessageW(sd->hlv, LVM_SETITEMSTATE, 0, (LPARAM) &lvitem); > + } > + SendMessageW(sd->hlv, LVM_SETIMAGELIST, LVSIL_NORMAL, (LPARAM)sd->himages); > + You could use macros here too, if you prefer that.

1 0

po: Update US English resource
by Ken Sharp April 13, 2011

April 13, 2011

http://www.winehq.org/pipermail/wine-devel/2011-April/089585.html (I lost the original mail - along with a bunch of others) I'm confused as to what the .po files are for. ise/ize will be correct if the .rc file default is British English. Without updating the .po file for US English I don't see how else this can be updated - unless it is simply the way it was before with LANG_ and SUBLANG_, but then what are the .po files for? I can't find any details in the Wiki and I'm afraid I wasn't around when they were introduced...

1 0

ntdll: Add support for Windows XP 64-bit
by Ken Sharp April 13, 2011

April 13, 2011

Morning all, Could someone far smarter than me please take a look at the attached patch? Windows XP 64-bit runs NT kernel 5.2, whereas 32-bit runs 5.1. Any 64-bit app expecting XP 64-bit will fail (such as IE8 for NT 5.2). The patch lets the installer continue, but I'm not sure if it is enough to be accepted. For example, do I need to "winxp,winxp64", here? http://source.winehq.org/source/dlls/ntdll/version.c?v=wine-1.3.17#L172 TIA, Ken.

1 0

Re: wined3d: Track when the FBO is dirty. (try 3)
by Henri Verbeet April 12, 2011

April 12, 2011

On 7 April 2011 18:51, Adam Martinson <amartinson(a)codeweavers.com> wrote: > - context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + > + if (rt_count == device->adapter->gl_info.limits.buffers && > + rts == device->render_targets && > + depth_stencil == device->depth_stencil) > + { > + if (context->device_fbo != NULL) > + { > + context_apply_device_fbo(context); > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; > + } > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + } That's not very pretty. > @@ -6709,6 +6721,7 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as render target %u.\n", surface, i); > device->render_targets[i] = NULL; > + fbo_dirty = TRUE; > } > } > > @@ -6716,7 +6729,10 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as depth/stencil buffer.\n", surface); > device->depth_stencil = NULL; > + fbo_dirty = TRUE; That code should never execute, hence the ERR.

2 3

Re: [2/2] comctl32/tab: Use dpa to store item data
by Henri Verbeet April 12, 2011

April 12, 2011

On 10 April 2011 07:56, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Use dpa to store item data > This seems to break text on winecfg tabs for me.

3 4

Re: user32: Fix the single menu item activation using a hot key.
by Marvin April 12, 2011

April 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10449 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

__CxxFrameHandler unsupported on wine64?
by Peter Urbanec April 12, 2011

April 12, 2011

I have an application that requires MFC80.DLL. When I install only the MFC80.DLL file from the vcredist package, I end up with the following errors: wine: Call from 0x7fd606a3148b to unimplemented function MSVCR80.dll.__CxxFrameHandler, aborting So, I had a quick look at the wine source and found a comment in dlls/msvcrt/cppexcept.c that says: /* CxxFrameHandler is not supported on non-i386 */ I don't think that this is quite right, given that Microsoft's MFC80.DLL attempts to call __CxxFrameHandler. Is it more likely that wine only provides an i386 implementation? If so, is there any chance that someone may be able to provide x86_64 implementation in the near future? It's way over my head :-( Best regards, Peter Urbanec

2 1

Re: [3/3] wined3d: only acquire a context in buffer::PreLoad if we have to
by Henri Verbeet April 12, 2011

April 12, 2011

You can't just resend this unmodified if you're leaving buffer creation in.

2 1

Re: [PATCH 4/4] d3d9: COM cleanup for the IDirect3DSwapChain9 iface.
by Michael Stefaniuc April 12, 2011

April 12, 2011

Please ignore this patch for now as it conflicts with Henri's patch. bye michael On 04/12/2011 10:23 AM, Michael Stefaniuc wrote: > --- > dlls/d3d9/d3d9_private.h | 7 ++--- > dlls/d3d9/device.c | 8 +++--- > dlls/d3d9/swapchain.c | 61 ++++++++++++++++++++++++++++++---------------- > 3 files changed, 47 insertions(+), 29 deletions(-)

1 0

Re: dbghelp: get rid of a couple unused variables (try 2)
by Eric Pouech April 11, 2011

April 11, 2011

Le 11/04/2011 19:07, Austin English a écrit : IMO, you should keep the variable names in comment so that we know what we're talking about: /* version = */ dwarf2_parse_u2(&ctx); or dwarf2_parse_u2(&ctx); /* version */ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: dbghelp: get rid of a couple unused variables
by Andrew Nguyen April 11, 2011

April 11, 2011

On 04/11/2011 12:41 AM, Austin English wrote: > This ignores the side effects of the dwarf2_parse_u2 function.

2 1

Re: gdi32/dibdrv: The dib debug channel is unused so remove it.
by Huw Davies April 11, 2011

April 11, 2011

On Sun, Apr 10, 2011 at 06:45:51PM +0200, Francois Gouget wrote: > It might get used soon but then it's easy to add back anyway. Very soon in fact - it gets used in the PatBlt patch I just sent ;-)

1 0

Re: d3dx9_36: Make get_parameter_{handle,struct}() static.
by luis.busquets＠ilidium.com April 11, 2011

April 11, 2011

Shouldn't this be inline? > --- > dlls/d3dx9_36/effect.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index 1e3de0c..a03e8a3 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -91,12 +91,12 @@ static void skip_dword_unknown(const char **ptr, > unsigned int count) > } > } > > -struct d3dx_parameter *get_parameter_struct(D3DXHANDLE handle) > +static struct d3dx_parameter *get_parameter_struct(D3DXHANDLE handle) > { > return (struct d3dx_parameter *) handle; > } > > -D3DXHANDLE get_parameter_handle(struct d3dx_parameter *parameter) > +static D3DXHANDLE get_parameter_handle(struct d3dx_parameter *parameter) > { > return (D3DXHANDLE) parameter; > } > -- > 1.7.4.1 > > > >

1 0

Ubuntu's new UI has glitches that affect Wine...
by Dan Kegel April 11, 2011

April 11, 2011

Ubuntu 11.04 beta 1 is out, http://www.ubuntu.com/testing/natty/beta There are aleady about six bug reports about how its new UI interacts with Wine: https://launchpad.net/ubuntu/+bugs?field.searchtext=unity+wine If you're an ubuntu user, please try out Natty Beta, review those bugs, and vote for the ones that affect you. And file more if you find any! - Dan

1 1

Introducing "Deobjectivizer"
by Charles Davis April 11, 2011

April 11, 2011

Hi, I've been working on a secret Clang-based project for a while, and now I'm ready to share it with the world. Introducing the "Deobjectivizer". This is a program that scans framework bundle headers for Objective-C constructs, and generates procedural C wrappers around them, so you can call them from C. It uses Clang's libraries to parse, analyze, and rewrite Objective-C headers into pure C headers, and then generate corresponding source files containing the wrapper implementations. The implementation of this tool is a little hackish at the moment, but it suffices to generate a wrapper around the entire Foundation framework (at least). With this, we don't have to use Objective-C just to use Cocoa anymore. The Mac OS X Quartz driver can go forward now! The QuickTime decoder can use QTKit now instead of the 32-bit only Carbon QuickTime interface, allowing it to work on 64-bit (if and when Wine supports it on Mac). It might even be possible to integrate Win32 screen-savers with Mac OS X using this (the ScreenSaver framework is Objective-C based). I've attached the source so you can play with my newest creation. At the moment, it can only be built on Mac OS X (only one of two platforms, the other being iOS, where a program like this makes sense anyway). Feel free to make changes; the sources are licensed under the same license as Clang itself. We can't incorporate it into Wine directly because it is written in C++ (and maybe because of the license), but we can detect its presence at compile time (in configure) and use it to generate pure C wrappers that Wine can use. Comments welcome. What do you think? Chip

1 0

Re: gdiplus: Make get_font_hfont() static.
by Vincent Povirk April 10, 2011

April 10, 2011

I'm planning to use this from GdipAddPathString. On Sun, Apr 10, 2011 at 11:45 AM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 2 -- > dlls/gdiplus/graphics.c | 2 +- > 2 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 1629ae6..bfa33ef 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -58,8 +58,6 @@ extern void calc_curve_bezier_endp(REAL xend, REAL yend, REAL xadj, REAL yadj, > > extern void free_installed_fonts(void); > > -extern void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont); > - > extern BOOL lengthen_path(GpPath *path, INT len); > > extern GpStatus trace_path(GpGraphics *graphics, GpPath *path); > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 336929f..6a5ef7f 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -1654,7 +1654,7 @@ end: > return stat; > } > > -void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont) > +static void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont) > { > HDC hdc = CreateCompatibleDC(0); > GpPointF pt[3]; > -- > 1.7.4.1 > > > >

1 0

Try to implement my first stub function - AbortPrinter() - (try 3)
by Loïc Maury April 10, 2011

April 10, 2011

Hello, I try always to implement my first stub function - AbortPrinter. The last time, I send into Wine patch mailling list, but the patch was not correct. Now I think the format for the patch is correct (no whitespace, etc…). More over, I have modified the value if(!job->portname) by if(!portname), because after the test "if(!job->portname)", I print trace of portname, but before he was initialized into the "if condition" and can to not enter into this condition. What do you think ? Thank you Loïc

3 3

Fwd: d3dx9_36 [patch 1/3; try 9]: Remove useless includes
by David Adam April 10, 2011

April 10, 2011

Any feedback for the reasons why this patch and the following ones were not commited? Thanks in advance A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/4/6 Subject: d3dx9_36 [patch 1/3; try 9]: Remove useless includes To: wine-patches <wine-patches(a)winehq.org>

1 0

Must multimedia players check the message queue and invoke DispatchMessage?
by Joerg-Cyril.Hoehle＠t-systems.com April 10, 2011

April 10, 2011

Hi, In Bug #3930 http://bugs.winehq.org/show_bug.cgi?id=3930#c41 I conjectured that: 1. Since w2k, winmm hijacks the application's thread to play multimedia content. Wine does this as well with MCI_WAIT, but it should as well affect winmm:playSound, winmm:midi* and winmm:wave*. 2. Consequently, the players must implement a message loop and dispatch regular window messages using DispatchMessageA/W Currently, Wine does not. This IMHO has potential for dead locks. Music and animations can play for a long time and messages ought to be serviced. I'm not familiar with windows messages at all. What do you think about the consequence? Point 1 explains why tests reveal the current thread as the one executing all callbacks but one since w2k. Point 2 should be testable by playing a long piece of video or music and prequeuing or injecting (how?) some windows events. How to test this in a convincing manner? Would the obligation to service messages disappear if the players ran in their own thread (like w9x seems to do)? Thanks for your help, Jörg Höhle

5 8

Project: x86 to ARM binary translator
by Yale Zhang April 9, 2011

April 9, 2011

Fellow developers, I'm thinking of starting a VM project to allow running x86 Windows apps on ARM Android. This will obviously involve binary translation. I've read about QEMU's tiny code generator and think for a usable experience, the intermediate micro-op representation will have to be abandoned, and use a more efficient, though less portable x86 to ARM translator. I also saw some Google SOC project that tried to incorporate LLVM into QEMU, but with disastrous slow down if done naively. I still think it's worth to do so, but lots of care will need to be done to only optimize code that needs it like Sun's HotSpot Java compiler does. Questions: 1. How useful would this be and how much interest? Obviously, this will be a huge project, and I just want to gauge the interest before I jump in. Microsoft will be releasing Windows for ARM soon, so there will be no need to worry about running Office, Matlab, Visual C++, etc on ARM, leaving only legacy applications and games to benefit from binary translation. I'm mostly interested in seeing some 3D games run on my Xoom. 2. What's the best design: whole system VM (qemu) or process VM (qemu & wine)? Process VM: + easier to incorporate 3D acceleration at API level + uses less memory + better performance (e.g. no need for MMU translation when accessing memory) + much better integration with host OS - needs to maintain custom Windows API implementation (Wine) Whole system VM: + simpler, more unified to implement + much better support for apps that are dependent on new, proprietary, obscure Windows libraries, interfaces (moot because Office, Matlab, etc will soon be available for ARM) Given the aims of only running legacy applications and games, it seems a foregone conclusion that Wine's process VM approach is best. Comments? 3. Will Wine ever incorporate binary translation? My proposed design will obviously use Wine's implementation of the Windows API, which is huge. I'm not sure how disruptive of a change binary translation will be to Wine. If Wine does incorporate binary translation, maybe they can change the name to Wine Is Now an Emulator If your're interested in this project, please reply.

6 7

Re: [PATCH 4/5] wined3d: Merge the IWineD3DSwapChain::Destroy() implementations.
by Alexandre Julliard April 8, 2011

April 8, 2011

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > They're mostly the same, except for the GL version also destroying its > contexts, and being a bit more careful about the order in which backbuffers > are destroyed. > --- > dlls/wined3d/swapchain.c | 175 ++++++++++++++++----------------------------- > 1 files changed, 62 insertions(+), 113 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddrawmodes.c && touch ddrawmodes.ok wine: Unhandled page fault on read access to 0x00000f2c at address 0x687550fa (thread 0021), starting debugger... Unhandled exception: page fault on read access to 0x00000f2c in 32-bit code (0x687550fa). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:687550fa ESP:0032f910 EBP:0032f948 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000021 EBX:6884b244 ECX:00110064 EDX:00000000 ESI:00000000 EDI:00000001 Stack dump: 0x0032f910: 00001302 00131ef0 00000000 00000000 0x0032f920: 00000000 00000000 00000000 00110014 0x0032f930: 0000ff00 000000ff 687550db 6884b244 0x0032f940: 00131848 00000001 0032f9a8 6880052b 0x0032f950: 00134d58 00000000 00131ef0 7bc73cfc 0x0032f960: 00000002 00129f28 00000000 000004b0 Backtrace: =>0 0x687550fa context_destroy+0x2a(This=0x134d58, context=(nil)) [/home/julliard/wine/wine/dlls/wined3d/context.c:1615] in wined3d (0x0032f948) 1 0x6880052b IWineD3DBaseSwapChainImpl_Destroy+0x18a(iface=0x131848) [/home/julliard/wine/wine/dlls/wined3d/swapchain.c:65] in wined3d (0x0032f9a8) 2 0x688006a1 IWineD3DBaseSwapChainImpl_Release+0x40(iface=0x131848) [/home/julliard/wine/wine/dlls/wined3d/swapchain.c:125] in wined3d (0x0032f9e8) 3 0x686d25b9 D3D7CB_DestroySwapChain+0x58(swapchain=0x131848) [/home/julliard/wine/wine/dlls/ddraw/ddraw.c:2621] in ddraw (0x0032fa18) 4 0x6875d317 IWineD3DDeviceImpl_UninitGDI+0x66(iface=0x134d58, D3DCB_DestroySwapChain=0x686d2560) [/home/julliard/wine/wine/dlls/wined3d/device.c:2300] in wined3d (0x0032fa78) 5 0x686f8f6e ddraw_surface7_Release+0x1cd(iface=0x129f28) [/home/julliard/wine/wine/dlls/ddraw/surface.c:396] in ddraw (0x0032fad8) 6 0x68689c21 func_ddrawmodes+0x2720() [/home/julliard/wine/wine/dlls/ddraw/tests/ddrawmodes.c:583] in ddraw_test (0x0032fd38) 7 0x686adc9e run_test+0x14d(name="ddrawmodes.c") [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:556] in ddraw_test (0x0032fd88) 8 0x686ae767 main+0x156(argc=0xffffffff, argv=(nil)) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:624] in ddraw_test (0x0032fe48) 9 0x686ae93c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ddraw_test (0x0032fe90) 10 0x7b859a6c call_process_entry+0xb() in kernel32 (0x0032fea8) 11 0x7b85a69f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1086] in kernel32 (0x0032fee8) 12 0x7bc74c78 call_thread_func+0xb() in ntdll (0x0032fef8) 13 0x7bc776b0 call_thread_entry_point+0x6f(entry=0x7b85a640, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffc8) 14 0x7bc4d27a start_process+0x29(kernel_start=0x7b85a640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2606] in ntdll (0x0032ffe8) 15 0x6802996d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x687550fa context_destroy+0x2a [/home/julliard/wine/wine/dlls/wined3d/context.c:1615] in wined3d: cmpl %eax,0xf2c(%esi) 1615 if (context->tid == GetCurrentThreadId() || !context->current) -- Alexandre Julliard julliard(a)winehq.org

2 1

ntdll: Remove more path trailing chars.
by Joerg-Cyril.Hoehle＠t-systems.com April 8, 2011

April 8, 2011

Hi, Juan Lang wrote: >Vincent Pelletier wrote: >> Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any >> sense. >> I saw that it is discouraged (forbidden ?) to depend on OS version in tests, >> so I will avoid that path unless asked to follow it. >You'd want to use "ok(pass || broken(fail /* NT4 */)". No! Juan, while you generally give excellent advice, please think again about that one suggestion. It means tests never fail on native, which renders the test useless. What I've been doing several times is to write a detector and have the tests expect the specific NT/non-NT value. static BOOL TrueButNT = TRUE; Don't query OS version! Instead, the first test that sees the difference in behaviour does this: ok(rc == DO || broken(rc == DONT /* NT */), "bla\n"); TrueButNT = (rc==DONT) ? FALSE : TRUE; All later tests use ok(rc == TrueButNT, "bla2\n"); It even works with todo_wine. Any other means to detect NT *that is relevant for your test* is fine, i.e. don't query the DLL version or use some function outside of your test domain. Typical detectors are different GetLastError() values. I call this "coherence testing". Regards, Jörg Höhle

2 1

Re: wine.inf: Add shell handler for .url files.
by Jacek Caban April 8, 2011

April 8, 2011

Hi Hans, On 4/8/11 9:22 AM, Hans Leidekker wrote: > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index d4a457b..048b5bb 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -161,6 +161,7 @@ HKCR,.lnk,,2,"lnkfile" > HKCR,.msi,,2,"Msi.Package" > HKCR,.msp,,2,"Msi.Patch" > HKCR,.rtf,,2,"rtffile" > +HKCR,.url,,2,"InternetShortcut" > HKCR,.wri,,2,"wrifile" I'm not sure about other changes, but this should go to shdocvw. I have a patch in my queue for that. Jacek

1 0

Re: wine.inf: Add shell handler for .url files.
by Damjan Jovanovic April 8, 2011

April 8, 2011

On Fri, Apr 8, 2011 at 9:22 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=26673 > --- > tools/wine.inf.in | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index d4a457b..048b5bb 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -161,6 +161,7 @@ HKCR,.lnk,,2,"lnkfile" > HKCR,.msi,,2,"Msi.Package" > HKCR,.msp,,2,"Msi.Patch" > HKCR,.rtf,,2,"rtffile" > +HKCR,.url,,2,"InternetShortcut" > HKCR,.wri,,2,"wrifile" > HKCR,chm.file,,2,"Compiled HTML Help File" > HKCR,chm.file\shell\open\command,,2,"%10%\hh.exe %1" > @@ -215,21 +216,25 @@ HKCR,xmlfile\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,xmlfile\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,xmlfile\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,xmlfile\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,ftp,"URL Protocol",2,"" > HKCR,ftp\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,ftp\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,ftp\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,ftp\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,ftp\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,http,"URL Protocol",2,"" > HKCR,http\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,http\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,http\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,http\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,http\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,https,"URL Protocol",2,"" > HKCR,https\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,https\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,https\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,https\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,mailto,"URL Protocol",2,"" > HKCR,mailto\shell\open\command,,2,"%11%\winebrowser %1" > ; FIXME: the following should be done by the dll registration > HKCR,TypeLib\{00020430-0000-0000-C000-000000000046}\1.0\0\win16,,,"stdole.tlb" > -- Aren't most Internet-related file associations created by dlls/mshtml/mshtml.inf instead of tools/wine.inf.in, and should we maybe change that or move your patch there? Damjan

2 1

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.
by Dylan Smith April 7, 2011

April 7, 2011

On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc <mstefani(a)redhat.de>wrote: > The COM methods are already __stdcall. > --- > dlls/riched20/txthost.c | 128 > ++++++++++++++-------------------------------- > 1 files changed, 39 insertions(+), 89 deletions(-) > > COM methods are supposed to use the stdcall calling convention, but the native riched20 and the native headers just defines ITextHost and ITextServices to be a c++ class (i.e. using the thiscall calling convention). Just look at the native TextServ.h header.

4 6

Google Summer of Code project
by Michał Ziętek April 7, 2011

April 7, 2011

Hello, My name is Michal Zietek, I am studying Computer Science at Wroclaw University of Technology. I would like to take part at Google Summer of Code. Lately I saw Jacek Caban presenting Wine at the university and he said there could be a possibility to start in Google Summer of Code and work on Wine. I talked to Jacek about project related to WScript. I am interested in working on this project but I can't find it on the Google Summer of Code website. The only place I found any information is http://www.winehq.org/pipermail/wine-devel/2011-February/088839.html Do you consider putting this project into Google Summer of Code? Best regards, Michal Zietek.

4 3

Re: [2/4] wined3d: Track when the FBO is dirty.
by Henri Verbeet April 7, 2011

April 7, 2011

On 21 March 2011 21:57, Adam Martinson <amartinson(a)codeweavers.com> wrote: > @@ -2102,6 +2121,7 @@ BOOL context_apply_clear_state(struct wined3d_context *context, IWineD3DDeviceIm > if (rt_count < context->gl_info->limits.buffers) > memset(context->blit_targets + rt_count, 0, (context->gl_info->limits.buffers - rt_count) * sizeof(*rts)); > context_apply_fbo_state(context, GL_FRAMEBUFFER, rt_count, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; You can't do that. > @@ -4801,6 +4801,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Clear(IWineD3DDevice *iface, DWORD rect > } > > device_get_draw_rect(device, &draw_rect); > + IWineD3DDeviceImpl_MarkFBODirty(device); What is this for? > +static inline void IWineD3DDeviceImpl_MarkFBODirty(IWineD3DDeviceImpl *This) This doesn't need to be in wined3d_private.h, it's only used from device.c. > + int i; > + for (i = 0; i < This->numContexts; ++i) numContexts is unsigned. What would happen when the current draw fbo entry would get evicted from the cache? Also, while the patch avoids redundant lookups for draws, it doesn't do a lot for clears. Is that intentional because it's not worth it, or is there a different reason for that?

2 4

[PATCH 2/6] winmm: DriverCallback ignores a 0 CALLBACK_WINDOW.
by Joerg-Cyril.Hoehle＠t-systems.com April 7, 2011

April 7, 2011

Hi, any feedback on winmm:DriverCallback patches 2-6? - Although I superseded patch 1/6, the others are unchanged, hence I did not resend them. - I thought about merging patches 2+3+5 into one or two. After all, they all change the one tiny DriverCallback function. E.g. patch 2 fixes the corner case where Wine delivers a spurious message to the thread message queue, while patch 5 generalizes the behaviour that MS mentions (and I tested), i.e. ignore any 0 dwCallback. OTOH, split is split. - It may seem weird to go to some effort to make DriverCallback return the exact same values as native *and* then change all drivers to ignore that value, so the patches may be considered superfluous. Yet we strive to be bug-compatible. Regards, Jörg Höhle

2 1

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking
by Alexandre Julliard April 7, 2011

April 7, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -1617,9 +1617,18 @@ BOOL virtual_handle_stack_fault( void *addr ) > BYTE vprot = view->prot[((const char *)page - (const char *)view->base) >> page_shift]; > if (vprot & VPROT_GUARD) > { > + struct _TEB *teb = NtCurrentTeb(); > VIRTUAL_SetProt( view, page, page_size, vprot & ~VPROT_GUARD ); > - if ((char *)page + page_size == NtCurrentTeb()->Tib.StackLimit) > - NtCurrentTeb()->Tib.StackLimit = page; > + if ((char *)page - page_size == teb->DeallocationStack) > + teb->Tib.StackLimit = page; > + else if ((char*)addr > (char*)teb->Tib.StackLimit + page_size && > + teb->Tib.StackLimit == (char*)teb->DeallocationStack + page_size && > + (view = VIRTUAL_FindView( (char*)teb->Tib.StackLimit, 0))) > + { > + vprot = view->prot[((char*)teb->Tib.StackLimit - (char*)view->base) >> page_shift]; > + VIRTUAL_SetProt( view, teb->Tib.StackLimit, page_size, vprot | VPROT_GUARD); > + teb->Tib.StackLimit = (char*)teb->Tib.StackLimit + page_size; > + } Why do you want to lookup the view again? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: gsoc theming
by Reece Dunn April 7, 2011

April 7, 2011

On 4 April 2011 13:08, Andrew Green <greeniekin(a)gmail.com> wrote: > Hi, > I hate to message you on this email. I have messaged the mailing > lists. Though I became more confused than anything. Can you please keep the discussions on the mailing list? Thanks. > I would like to propose a project where comctl32 is implement > correctly in windows for google summer of code. > As far as i know windows uses SxS to load version 6 of comctl allowing > theming. This is correct -- an application needs to add a manifest file to tell it to load version 6 of the comctl32 DLL in order to get theming support on Windows. > It also uses windows class redirection to hijack controls > from user32 to be themed(I don't know if it somehow uses subclassing). This is how it is implemented in wine. > The confusing thing on the mailing list i was told not to make a > separate version of comctl32. Which is understandable from a code > maintenance point of view. Though contradicts what the gsoc ideas page > says > "control is overridden by a themed drawing version by subclassing. > This is not the way it is implemented on Windows and this causes > drawing issues and other nasty issues." > As someone who is to be a mentor of this section. What is the goal? > and if subclassing is the option, how is this meant to work? There isn't a contradition. AFAICS, the subclassing works -- the subclassed window procedure gets called correctly. The drawing issues can be seen clearly on the button controls -- if the button changes state (enabled <-> disabled, pressed, etc.) then it gets drawn without theming. This is because the button control in Wine does not call WM_PAINT to do the drawing, which the themed button overrides. Therefore, you will need to either: 1/ convince Alexandre through tests that these tests do call WM_PAINT [*] and update the non-themed control accordingly; or 2/ implement the state tracking/logic in the themed button and have it call WM_PAINT [*]. [*] or the correct custom drawing messages. HTH, - Reece

3 2

Re: Wanted: TestBot maintainer
by Деян Стоянов April 7, 2011

April 7, 2011

Hi Greg, I'm system administrator in application development unit of company "Information services" Plc. ( about us on http://www.is-bg.net/site_io/?cat=77 ). I am Vmware Certified Professional of VI3 and so far of VI4, and I have good experience with VMware Infrastructure. Also I have no problem with support various operation systems Windows 98, NT, 2000, XP, Vista, 7. Also I have experience with Linux Debian derivations, as well i manage with success other Linux distributions. I am interested to see how TestBot works, and maintain indefinitely. I spoke with my employer for time to maintain the TestBot, and I have a positive answer. I remain at your disposal, and I expect your response. Best regards Deyan Stoyanov

1 0

Wanted: TestBot maintainer
by Greg Geldorp April 7, 2011

April 7, 2011

Due to personal circumstances I won't be able to maintain the TestBot much longer. I'm looking for a volunteer to take over this responsibility. I can offer the hardware on which the bot runs for another 2 years or so. You'll get full access to the hardware. It helps if you have a bit of experience with VMware vSphere, but that's not absolutely required. Day-to-day operations have been running pretty smooth for the last couple of months, so the demand on your time won't be that great. There's the occasional account request that needs to be approved and that's pretty much it. Every now and then the VMs should be updated using Windows Update. The code itself seems to be reasonably stable. It's all Perl. If you're interested or would like more info, please let me know. Greg.

2 1

Re: configure.ac: add a --without-prelink option
by Vitaliy Margolen April 7, 2011

April 7, 2011

On 04/06/2011 07:53 PM, Austin English wrote: > Prelink is only available on Linux. It's not a reason to disable the warning. Without prelink, or other means to set load addresses of core dlls, compiled Wine won't be compatible with some programs. Mainly copy protection. Vitaliy.

2 1

Re: user32: Add a test for activating a menu consisting from a single menu item using a hot key.
by Marvin April 6, 2011

April 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10366 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Translation commits for wine-1.2.3
by Michael Stefaniuc April 5, 2011

April 5, 2011

Hello Alexandre, attached is the list of translation commits that can be cherry-picked for wine-1.2.3. Notes: - The cherry-picks for cryptui and wineconsole will need a manual conflict resolution as they depend on my janitorial commits. - The Arab and Hebrew translations are filtered out (support for mirroring is only in wine-1.3.x). bye michael

1 0

Re: [PATCH] cmd: Added set /a (try 3, fixed tests and patch formatting) Some tests were written by Jack Kutilek
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10353 Your paranoid android. === W7PROX64 (64 bit) === batch.c:70: Test failed: CreateFile failed

1 0

Re: ntdll: Remove more path trailing chars.
by Nikolay Sivov April 5, 2011

April 5, 2011

On 4/2/2011 10:51, Vincent Pelletier wrote: > Add tests via FindFirstFileA. > Fixes bug 22635. > --- > dlls/kernel32/tests/file.c | 119 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/path.c | 8 +++- > 2 files changed, 126 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c > index 4e8136a..dae8eee 100644 > --- a/dlls/kernel32/tests/file.c > +++ b/dlls/kernel32/tests/file.c > @@ -2164,6 +2164,125 @@ static void test_FindFirstFileA(void) > err = GetLastError(); > ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 ); > ok ( err == ERROR_PATH_NOT_FOUND, "Bad Error number %d\n", err ); > + > + /* try FindFirstFileA on "test-dir" with forbidden chars */ > + CreateDirectoryA("test-dir", NULL); > + _lclose(_lcreat("test-file", 0)); > + > +#define FindFirstFileA_ok(value, caption, todo) { \ > + if(todo) { \ > + todo_wine ok(value, caption);\ > + } else { \ > + ok(value, caption);\ > + } \ > + } > + > +#define test_FindFirstFileA_with(x, y, todo) { \ > + handle = FindFirstFileA(x,&data);\ > + if (y) { \ > + FindFirstFileA_ok( \ > + handle != INVALID_HANDLE_VALUE, \ > + "FindFirstFile on "x" should succeed\n", \ > + todo);\ > + } else { \ > + FindFirstFileA_ok( \ > + handle == INVALID_HANDLE_VALUE, \ > + "FindFirstFile on "x" should fail\n", \ > + todo);\ > + } \ > + if (handle != INVALID_HANDLE_VALUE) \ > + ok( FindClose(handle) == TRUE, "Failed to close handle "x"\n"); \ > + } > + > + /* Disallowed chars being ignored: */ > + test_FindFirstFileA_with("test-dir/.", 1, 0); > + test_FindFirstFileA_with("test-dir\\.", 1, 0); > + test_FindFirstFileA_with("test-dir<.", 1, 0); > + test_FindFirstFileA_with("test-dir< ", 1, 0); > + test_FindFirstFileA_with("test-dir>.", 1, 0); > + test_FindFirstFileA_with("test-dir> ", 1, 0); > + test_FindFirstFileA_with("test-dir\".", 1, 0); > + test_FindFirstFileA_with("test-dir\" ", 1, 0); > + test_FindFirstFileA_with("test-dir/>", 1, 0); > + test_FindFirstFileA_with("test-dir/<", 1, 0); > + test_FindFirstFileA_with("test-dir/\"", 1, 0); > + test_FindFirstFileA_with("test-dir<>", 1, 0); > + test_FindFirstFileA_with("test-dir<<", 1, 0); > + test_FindFirstFileA_with("test-dir<\"", 1, 0); > + test_FindFirstFileA_with("test-dir>>", 1, 0); > + test_FindFirstFileA_with("test-dir><", 1, 0); > + test_FindFirstFileA_with("test-dir>\"", 1, 0); > + test_FindFirstFileA_with("test-dir\">", 1, 0); > + test_FindFirstFileA_with("test-dir\"<", 1, 0); > + test_FindFirstFileA_with("test-dir\"\"", 1, 0); > + test_FindFirstFileA_with("test-dir\\<", 1, 0); > + test_FindFirstFileA_with("test-dir\\>", 1, 0); > + test_FindFirstFileA_with("test-dir\\\"", 1, 0); > + /* But space prevents forward& back slashes from being stripped */ > + test_FindFirstFileA_with("test-dir<", 0, 1); > + test_FindFirstFileA_with("test-dir/ ", 0, 0); > + test_FindFirstFileA_with("test-dir/ .", 0, 0); > + test_FindFirstFileA_with("test-dir/. ", 0, 1); > + test_FindFirstFileA_with("test-dir\\ ", 0, 0); > + test_FindFirstFileA_with("test-dir\\ .", 0, 0); > + test_FindFirstFileA_with("test-dir\\. ", 0, 1); > + test_FindFirstFileA_with("test-dir/. ", 0, 1); > + test_FindFirstFileA_with("test-dir\\. ", 0, 1); > + /* But forward& back slashes are not tolerated on a file */ > + test_FindFirstFileA_with("test-file/>", 0, 1); > + test_FindFirstFileA_with("test-file/<", 0, 1); > + test_FindFirstFileA_with("test-file/\"", 0, 1); > + test_FindFirstFileA_with("test-file<>", 1, 0); > + test_FindFirstFileA_with("test-file<<", 1, 0); > + test_FindFirstFileA_with("test-file<\"", 1, 0); > + test_FindFirstFileA_with("test-file>>", 1, 0); > + test_FindFirstFileA_with("test-file><", 1, 0); > + test_FindFirstFileA_with("test-file>\"", 1, 0); > + test_FindFirstFileA_with("test-file\">", 1, 0); > + test_FindFirstFileA_with("test-file\"<", 1, 0); > + test_FindFirstFileA_with("test-file\"\"", 1, 0); > + test_FindFirstFileA_with("test-file\\<", 0, 1); > + test_FindFirstFileA_with("test-file\\>", 0, 1); > + test_FindFirstFileA_with("test-file\\\"", 0, 1); > + /* Even when many */ > + test_FindFirstFileA_with("test-dir\"\"\"\"\"", 1, 0); > + test_FindFirstFileA_with("test-dir<<<><><>\"\"\"\"<<<>", 1, 0); > + /* But only in the end of path */ > + test_FindFirstFileA_with("test-/>dir", 0, 0); > + test_FindFirstFileA_with("/>test-dir", 0, 0); > + test_FindFirstFileA_with(">test-dir", 0, 0); > + test_FindFirstFileA_with(">>test-dir", 0, 0); > + test_FindFirstFileA_with(">test->dir", 0, 0); > + test_FindFirstFileA_with("><test->dir", 0, 0); > + test_FindFirstFileA_with("<test->dir", 0, 0); > + test_FindFirstFileA_with("<\"test->dir", 0, 0); > + > + /* Slash after ignored chars is not ignored: */ > + test_FindFirstFileA_with("test-dir//", 0, 0); > + test_FindFirstFileA_with("test-dir</", 0, 0); > + test_FindFirstFileA_with("test-dir>/", 0, 0); > + test_FindFirstFileA_with("test-dir\"/", 0, 0); > + test_FindFirstFileA_with("test-dir\\", 0, 0); > + test_FindFirstFileA_with("test-dir\\\\", 0, 0); > + test_FindFirstFileA_with("test-dir\\/", 0, 0); > + test_FindFirstFileA_with("test-dir/\\", 0, 0); > + > + /* Disalowed chars being preserved: */ > + test_FindFirstFileA_with("test-dir/:", 0, 0); > + test_FindFirstFileA_with("test-dir/|", 0, 0); > + > + /* Slashes converted to backslashes */ > + test_FindFirstFileA_with("test-dir/", 0, 0); > + test_FindFirstFileA_with("./test-dir", 1, 0); > + test_FindFirstFileA_with("./test-dir/", 0, 0); > + test_FindFirstFileA_with("test-dir\\", 0, 0); > + test_FindFirstFileA_with(".\\test-dir", 1, 0); > + test_FindFirstFileA_with(".\\test-dir\\", 0, 0); > + > +#undef test_FindFirstFileA_with > +#undef FindFirstFileA_ok > + DeleteFileA("test-file"); > + RemoveDirectoryA("test-dir"); > } Please use table for test data and put your macro body in a loop.

3 3

Re: cmd: Added set /a (try 2)
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10349 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Sorry about the duplicate patches.
by Joel Teichroeb April 5, 2011

April 5, 2011

When trying to submit my first patch I did not do it correctly, and on http://source.winehq.org/patches/ it shows up 5 times. The correct patch is http://www.winehq.org/pipermail/wine-patches/2011-April/100677.html Thanks for your patience. Joel Teichroeb

1 0

Re: gdi32/tests: Start of a framework for writing dib driver tests.
by Huw Davies April 5, 2011

April 5, 2011

On Tue, Apr 05, 2011 at 03:31:23PM +0100, Huw Davies wrote: > > Try2. Using the A_SHA functions to generate the hashes. Although somewhat neater than the first version it doesn't work on nt4/win2k as they don't export these functions. So we're better off using the original. Huw.

1 0

Re: gdi32/tests: Start of a framework for writing dib driver tests.
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10338 Your paranoid android. === WNT4WSSP6 (32 bit dib) === Timeout === W2KPROSP4 (32 bit dib) === Timeout

1 0

Re: mshtml: Properly handle upload streams containing headers
by Alexandre Julliard April 5, 2011

April 5, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > + if(nschannel->post_data_contains_headers) { > + if(data[0] == '\r' && data[1] == '\n') { > + post_data = data+2; > + data_len -= 2; > + }else { > + WCHAR *headers; > + DWORD size; > + > + post_data = memmem(data, data_len, "\r\n\r\n", 4); memmem is not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] cmd: Added set /a
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10334 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x34 position 0 in line 118 (got '4', wanted '3') batch.c:223: Test failed: unexpected char 0x34 position 0 in line 120 (got '4', wanted '11') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 24 (got '0', wanted '2') batch.c:223: Test failed: unexpected char 0x31 position 0 in line 30 (got '12', wanted '2') batch.c:223: Test failed: unexpected char 0x2d position 0 in line 42 (got '-2147483648', wanted '0') batch.c:223: Test failed: unexpected char 0x33 position 0 in line 46 (got '3', wanted '1') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 124 (got '5', wanted '6') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 130 (got '5', wanted '2') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 140 (got '5', wanted '1') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 146 (got '5', wanted '10')

1 0

Re: msi: Fix parsing of an empty property followed by a non-empty property.
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10333 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: Fixes a crypt32 str test. (try 2)
by Juan Lang April 4, 2011

April 4, 2011

Hi Christian, I'd like to see the actual test, preferably incorporated into the test suite. Thanks, --Juan

1 0

Re: [GSoC] Merge winecfg and Control Panel
by Dan Kegel April 4, 2011

April 4, 2011

Winetricks is a simple script that adds a few mssing things to wine, e.g. it's how most people install ms dlls or .net on wine. It also provides a simple commandline way to change a few settings. For instance, winetricks vd=1024x768 sets a 1024x768 virtual desktop... it'd be nice if one could instead do winecfg vd=1024x768 or something like that. See also http://winetricks.org. On Mar 23, 2011 10:36 AM, "Tony Zhang" <niu.tony.c.zhang(a)gmail.com> wrote: Dear Dan, I agree that it would be nice to have a command-line interface for wine settings cause I have run into situations that I have to configure wine before going into X. So is it possible to first group/rearrange winecfg functions into certain libraries and then let the GUI (control panel) and the CLI all interact with the corresponding libraries? About winetricks, I do not know much about it. What exactly do you mean by "winetricks settings"? -- Tony (Chi Zhang) On Wed, Mar 23, 2011 at 9:15 AM, Dan Kegel <dank(a)kegel.com> wrote: > > Also... it would be nice i...

4 4

Re: po: Update US English resource
by Alexandre Julliard April 4, 2011

April 4, 2011

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Just ise/ize changes > From 60f207abd03edf7ffac6f129a8bffd537596d54e Mon Sep 17 00:00:00 2001 > From: Ken Sharp <kennybobs(a)o2.co.uk> > Date: Fri, 1 Apr 2011 23:07:03 +0100 > Subject: po: Update US English resource These need to be changed in the original rc files. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] user32: DefDlgProc on WM_QUIT should repost it and terminate the dialog message loop.
by Marvin April 4, 2011

April 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10328 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/2] user32: Add a test for WM_QUIT handling by DefDlgProc.
by Marvin April 4, 2011

April 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10327 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH 2/2] comdlg32: Add support for customizing control labels in the item dialog.
by Nikolay Sivov April 4, 2011

April 4, 2011

On 4/4/2011 13:01, David Hedberg wrote: > static HRESULT WINAPI IFileDialog2_fnSetOkButtonLabel(IFileDialog2 *iface, LPCWSTR pszText) > { > FileDialogImpl *This = impl_from_IFileDialog2(iface); > - FIXME("stub - %p (%p)\n", This, pszText); > - return E_NOTIMPL; > + TRACE("%p (%p)\n", This, pszText); > + If you trace text parameter pointer value itself is not very interesting. Why not dumping a string?

1 0

Re: (без темы)
by Dmitry Timoshkov April 4, 2011

April 4, 2011

Roman Dadkov <romand(a)etersoft.ru> wrote: > 1) Magic field does not contain the correct information when creating a > storage file in Wine. > 2) Some fields are not filled with zeros when creating a storage file > in Wine. But these fields are filled with zeros when creating a storage > file in Windows. How is this different from the previous attempt? Did you address the comments? -- Dmitry.

1 0

Re: [PATCH] user32/tests: Fixed SetParent test on 64bit Vista
by Dmitry Timoshkov April 4, 2011

April 4, 2011

Austin Lund <austin.lund(a)gmail.com> wrote: > --- a/dlls/user32/tests/msg.c > +++ b/dlls/user32/tests/msg.c > @@ -12681,6 +12681,7 @@ static const struct message WmSetParentSeq_2[] = { > { WM_WINDOWPOSCHANGING, sent|wparam, SWP_HIDEWINDOW|SWP_NOSIZE|SWP_NOMOVE }, > { EVENT_OBJECT_HIDE, winevent_hook|wparam|lparam, 0, 0 }, > { WM_WINDOWPOSCHANGED, sent|wparam, SWP_HIDEWINDOW|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, > + { HCBT_SETFOCUS, hook|optional }, > { WM_NCACTIVATE, sent|wparam, 0 }, > { WM_ACTIVATE, sent|wparam, 0 }, > { WM_ACTIVATEAPP, sent|wparam, 0 }, This does look correct. It's pretty strange that other Windows versions don't send HCBT_SETFOCUS notification before WM_KILLFOCUS (which is right after WM_ACTIVATEAPP in the message sequence). -- Dmitry.

2 2

Summer of Code 2011 ideas
by Charles Davis April 4, 2011

April 4, 2011

Hi, I intend to participate in the Google Summer of Code (again), so I'd like to bounce some ideas off of you guys again. (I don't know why; I'll probably end up doing an extension of last year's project that I did for LLVM. But just in case...) I know that students are supposed to start submitting their proposals tomorrow, but better late than never, I guess. Anyway, here are my ideas (in no particular order): 1. Quartz Driver. I know you guys rejected this last year, but it looks like AJ's been doing some work refactoring the driver interface (at least, the GDI driver interface) lately. I also have some patches to isolate the rest of Wine from winex11. Since the driver itself is so huge, I'll probably end up only doing a piece of it (just enough to run some simple programs like Notepad or Minesweeper). This still depends on my (as yet, unfinished) Deobjectivizer tool so I don't have to code the driver in Objective-C (or resort to Carbon, which Apple seems intent on exorcising from Mac OS X). 2. D3D10 support. Here's an idea that isn't tied to Mac OS X. In Wine, D3D10 support is still in the embryonic stage (i.e. lots of stubs, anything interesting doesn't work quite right). It looks like Henri wants to wait until he finishes exorcising COM from WineD3D to finish implementing D3D10 (probably because COM was too much of a burden for what D3D10 needed from WineD3D, judging from which methods are stubs), so if you want to wait, that's fine. If I do take this on, my goal will probably be to get the game "Civilization V" working (at least, partially) in D3D10 mode, because that's the only D3D10 game I happen to own! (If it already works, and I don't know if it does because I haven't gotten around to installing and testing it, then I'll try to make it work better.) 3. Message-mode pipes. I think we can use the sendmsg(2) and recvmsg(2) syscalls to implement this on top of Unix-domain sockets. Then again, I suspect that this was one of the first things AJ thought of--and he hasn't been able to figure out how to do it yet! I have some experience writing Mac OS X kernel extensions (I wrote the SCSI kexts that Wine on Mac uses), and even a little experience writing Linux modules, so that might help with that. I would like to avoid a kernel module, if possible, though. (It's just one more thing that users have to install to make the system work...) What do you think? Chip

3 4

Re: gdiplus: Simplify logic/control flow in SOFTWARE_GdipFillRegion.
by Vincent Povirk April 3, 2011

April 3, 2011

I don't think this is an improvement. I think it's easier to use a single variable to indicate failure in the code, and to only use that variable when deciding whether to proceed further. This case only works because the GdipAlloc happens to be the only operation that can fail in that block before GdipGetRegionScansI. I worry that someone (probably me) could modify the code so that is no longer the case and fail to notice that the logic needs to be changed ( to check for stat == Ok && scans, rather than just scans). On Sat, Apr 2, 2011 at 3:36 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This doesn't make things tremendously simpler, but does avoid one > unnecessary if / condition. > > If you prefer, I can switch the two arms of the if to retain the > original !scans. > > Gerald > > --- > dlls/gdiplus/graphics.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 4fdfa9c..49f3495 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -3709,16 +3709,15 @@ static GpStatus SOFTWARE_GdipFillRegion(GpGraphics *graphics, GpBrush *brush, > if (stat == Ok && scans_count != 0) > { > scans = GdipAlloc(sizeof(*scans) * scans_count); > - if (!scans) > - stat = OutOfMemory; > - > - if (stat == Ok) > + if (scans) > { > stat = GdipGetRegionScansI(temp_region, scans, &dummy, identity); > > if (stat != Ok) > GdipFree(scans); > } > + else > + stat = OutOfMemory; > } > > GdipDeleteMatrix(identity); > -- > 1.7.4.1 > > >

1 0

Re: scarddlg: New dll stub
by Nikolay Sivov April 3, 2011

April 3, 2011

On 4/3/2011 17:51, Stefan Leichter wrote: > let the installer from bug #26026 finish > > --- > configure.ac | 1 + > dlls/scarddlg/Makefile.in | 6 ++++ > dlls/scarddlg/main.c | 61 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/scarddlg/scarddlg.spec | 5 +++ > 4 files changed, 73 insertions(+), 0 deletions(-) > create mode 100644 dlls/scarddlg/Makefile.in > create mode 100644 dlls/scarddlg/main.c > create mode 100644 dlls/scarddlg/scarddlg.spec > +/*********************************************************************** > + * FMExtensionProcW (acledit.@) > + * > + */ > + > +LONG WINAPI FMExtensionProcW(HWND hWnd, WORD wEvent, LONG lParam) > +{ > + FIXME("%p, %d, 0x%x) stub\n", hWnd, wEvent, lParam); > + return 0; > + > +} What's that for? It's not used.

1 0

Possible issue in dlls/d3dx9_36/surface.c?
by Gerald Pfeifer April 3, 2011

April 3, 2011

Matteo et al, there is some code in dlls/d3dx9_36/surface.c which GCC struggles with (in the sense of warning about it), and so do I, so I am wondering whether you can have a look? Specifically, in point_filter_simple_data we have: DWORD val = 0, pixel; /* extract source color components */ if(srcformat->type == FORMAT_ARGB) { pixel = dword_from_bytes(srcptr, srcformat->bytes_per_pixel); get_relevant_argb_components(&conv_info, pixel, channels); } So, pixel is uninitialized, except when we have FORMAT_ARGB. However, directly below we then have /* recombine the components */ if(destformat->type == FORMAT_ARGB) val = make_argb_color(&conv_info, channels); if(colorkey) { get_relevant_argb_components(&ck_conv_info, pixel, channels); where pixel is passed to get_relevant_argb_components. This is guarded by colorkey, a parameter to this function, so indeed I can see pixel being unused here. (I'd naively propose a patch like the one below; this may not be sufficient though.) Gerald diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c index a3e6e68..cc36818 100644 --- a/dlls/d3dx9_36/surface.c +++ b/dlls/d3dx9_36/surface.c @@ -701,7 +701,7 @@ static void copy_simple_data(CONST BYTE *src, UINT srcpitch, POINT srcsize, DWORD val = 0; for(x = 0;x < minwidth;x++) { - DWORD pixel; + DWORD pixel = 0xFFFFFFFF; /* extract source color components */ if(srcformat->type == FORMAT_ARGB) { @@ -768,7 +768,7 @@ static void point_filter_simple_data(CONST BYTE *src, UINT srcpitch, POINT srcsi for(x = 0;x < destsize.x;x++) { const BYTE *srcptr = bufptr + (x * srcsize.x / destsize.x) * srcformat->bytes_per_pixel; - DWORD val = 0, pixel; + DWORD val = 0, pixel = 0xFFFFFFFF; /* extract source color components */ if(srcformat->type == FORMAT_ARGB) {

2 1

Re: msvcp90: Implement basic_string and cstring versions of basic_string::find.
by Piotr Caban April 2, 2011

April 2, 2011

Hi, On 04/02/11 08:49, Vincent Pelletier wrote: > +size_t __thiscall MSVCP_basic_string_char_find_cstr( > + basic_string_char *this, const char *str, size_t offset) > +{ > + const char *this_str = basic_string_char_const_ptr(this); > + const char *found = strstr(this_str+offset, str); > + if (found) > + return found - this_str; > + return MSVCP_basic_string_char_npos; > +} It's better to implement basic_string<char>::find(const char *str, size_t offset, size_t count) first and then call it in MSVCP_basic_string_char_find_cstr implementation. basic_string may contain nullbytes, your implementation will not work in this case. cstr may contain nullbytes as well when length is specified. Adding some tests similar to following code may be useful: basic_string<char> test = basic_string<char>("aaa"); test += '\0'; test += "bbb"; basic_string<char> test2 = basic_string<char>(test); test2 += '\0'; printf("%d %s\n", test.length(), test.c_str()); printf("%d\n", test.find("bbb", 0)); printf("%d\n", test.find(test, 0)); printf("%d\n", test.find(test.c_str(), 0, test.length())); printf("%d\n", test.find(test2, 0)); printf("%d\n", test.find(test2.c_str(), 0, test2.length())); Cheers, Piotr

1 0

Why do the wintab32 tests load the dll at runtime?
by Francois Gouget April 2, 2011

April 2, 2011

The subject says it all. Why do the wintab32 tests load the dll at runtime instead of simply linking with wintab32.dll? Is it to make it easier to compile it with Visual C++ in case the system does not have wintab32.dll? (already the SDKs don't seem to have wintab.h) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

2 2

Re: ntdll: Remove more path trailing chars.
by Marvin April 2, 2011

April 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10288 Your paranoid android. === WNT4WSSP6 (32 bit file) === file.c:2261: Test failed: FindFirstFile on test-dir// should fail file.c:2262: Test failed: FindFirstFile on test-dir</ should fail file.c:2263: Test failed: FindFirstFile on test-dir>/ should fail file.c:2264: Test failed: FindFirstFile on test-dir"/ should fail file.c:2267: Test failed: FindFirstFile on test-dir\/ should fail file.c:2275: Test failed: FindFirstFile on test-dir/ should fail file.c:2277: Test failed: FindFirstFile on ./test-dir/ should fail

1 0

Re: kernel32: add test for FindFirstFileA with a path ending with "/>"
by Austin English April 2, 2011

April 2, 2011

On Fri, Apr 1, 2011 at 23:14, Vincent Pelletier <plr.vincent(a)gmail.com> wrote: > Fixes bug 22635. > --- > dlls/kernel32/tests/file.c | 119 > ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/path.c | 8 +++- > 2 files changed, 126 insertions(+), 1 deletions(-) Your patch changelog is misleading. You're not just adding tests, but fixing the bug. Either send the tests as a single patch and the fix separately(and removing any todo_wine()'s that it fixes) or change the summary to describe the fix. -- -Austin

2 1

Re: kernel32: add test for FindFirstFileA with a path ending with "/>"
by Marvin April 1, 2011

April 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10286 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msvcp90: Implement basic_string and cstring versions of basic_string::find.
by Marvin April 1, 2011

April 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10285 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

RFC: Standardising the Help menus
by Francois Gouget April 1, 2011

April 1, 2011

I am in the process of reviewing Wine's resource files and more specifically the menus of its applications, and even more specifically the Help menu for now. Currently they are a bit inconsistent and I propose to standardise them by following the GNOME interface guidelines. That is use the following structure: Help Contents F1 About So here is the data I gathered on this eminently critical issue ;-) Windows User Experience Interaction Guidelines ---------------------------------------------- * The section about standard menus say we should use: http://msdn.microsoft.com/en-us/library/aa511502.aspx Help <program name> help F1 <separator> About <program name> * All applications seem to conform to the specification for the 'About' menu (except Sound Recorder which uses 'About' and Disk Management which incorrectly adds an ellipsis). * But for the 'Help' menu there is a lot of inconsistency. In Windows 7 I got: 'View Help': Notepad, Solitaire, Mine Sweeper, Calculator, FreeCell, Internet Backgammon, Spider Solitaire '<program name> Help': Internet Explorer 8 '<program name> Help Topics': Task Manager 'Help Topics': Regedit, Task Scheduler, Disk Management 'Help': Sound Recorder 'Contents': msinfo32 'None' (replaced by a toolbar icon): Explorer, Paint, XPS Viewer, Windows Media Player, Backup and Restore, Sync Center * From the point above I conclude that following the Microsoft Guidelines will not particularly help consistency with other Windows applications, nor help meet the users expectations. * Putting the program name in the menu name means we will have as many strings to translate as there are programs. This is more work for translators and can yield inconsistencies from one program to the next. * Putting the program name in the menu name also feels redundant to me. Does one really expect Regedit to give you the help for Notepad? Similarly one would expect an 'About' menu to be about the current program, although in Wine's case it's more a generic About dialog. Unix Interface Guidelines ------------------------- * The GNOME Human Interface Guidelines specify: http://library.gnome.org/devel/hig-book/2.32/hig-book.html#menu-standard-he… Help Contents F1 About * This allows sharing of the translations across programs. * It would make Wine's applications consistent with the system ones... as long as one uses Gnome. * Because unfortunately this is a case where the KDE User Interface Guidelines differ: http://developer.kde.org/documentation/standards/kde/style/menus/help.html Help <program name> Handbook... F1 What's This? Shift+F1 <separator> About <program name>... About KDE... * Using ellipses as specified for these menus makes absolutely no sense and is inconsistent with their own guidelines regarding them. Fortunately this seems to be a bug in the specification and the applications don't uses ellipses (feel free to report this bug). * Both GNOME and KDE applications follow their guidelines pretty well. (except Gnome's Network Tools app which uses 'Help Ctrl+H' instead of 'Contents F1', maybe another bug to report) * However other applications, specifically FireFox and OpenOffice seem to follow the Windows guidelines. VMware Workstation follows them for the About menu, but follows GNOME's guidelines for the 'Contents' help menu. * So given that we cannot be consistent with all Unix applications I propose to pick the scheme that requires the less work for us, which is GNOME's scheme. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

3 2

Re: [3/3] wined3d: Get rid of context_validate.
by Alexandre Julliard April 1, 2011

April 1, 2011

Matteo Bruni <matteo.mystral(a)gmail.com> writes: > It should not be needed anymore, now the wined3d context is implicitly > validated on GL context activation. The check itself wasn't reliable > because of some threading issues and it also brought a small performance hit. It crashes here (nvidia driver 256.53): ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok visual.c:949: Tests skipped: D3DFMT_P8 textures not supported wine: Unhandled page fault on read access to 0x00000004 at address 0x564def4d (thread 0044), starting debugger... Unhandled exception: page fault on read access to 0x00000004 in 32-bit code (0x564def4d). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:564def4d ESP:0032f110 EBP:7e27f248 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:682e96c0 ECX:00000000 EDX:00000000 ESI:56d8f000 EDI:00000000 Stack dump: 0x0032f110: 56d8f000 00000000 00000004 02000007 0x0032f120: 556be000 02000007 7df05fa0 5572fc1e 0x0032f130: 7e27f270 556be000 56d8f000 02000007 0x0032f140: 00000000 00000014 00000000 7e0db298 0x0032f150: 02000007 02000007 7df05fa0 56d8f000 0x0032f160: 7e27f270 7e0db1a0 7e27f248 5572fdbf Backtrace: =>0 0x564def4d in libnvidia-glcore.so.256.53 (+0xd38f4d) (0x7e27f248) 1 0x00000000 (0x7e106410) 0x564def4d: testl $0xe000000,0x4(%edi) -- Alexandre Julliard julliard(a)winehq.org

1 0

About Wine/Gecko/MSHTML
by Artem S. Tashkinov April 1, 2011

April 1, 2011

Hi, I have no idea to what extent and how Mozilla's Gecko library is being used in Wine (all I know is that it's used in Wine's MSHTML component), but recently a Mozilla developer made a very unsettling announcement: groups dot google dot com/d/topic/mozilla.dev.embedding/c_NMcO-N8wo/discussion I wonder if this announcement has any adverse effects on Wine's future. Best wishes, Artem

2 1

Re: [PATCH] user32/tests: Fixed SetParent test on 64bit Vista
by Marvin April 1, 2011

April 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10257 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0