April 2011 - Wine-Devel - list.winehq.org

Re: wined3d/query: Add support for timestamp queries.
by Stefan Dösinger April 26, 2011

April 26, 2011

I think timestamp queries are supposed to return GPU-side timestamps. Otherwise I don't see the point in adding a complex d3d query around QueryPerformanceFrequency. There's GL_ARB_timer_query which looks like it does what you need.

1 0

Re: wined3d/state: Treat unrecognized D3DZBUFFERTYPEs as WINED3DZB_TRUE.
by Henri Verbeet April 26, 2011

April 26, 2011

Nope.

1 0

Re: wined3d/query: Add support for timestamp queries.
by Henri Verbeet April 26, 2011

April 26, 2011

On 26 April 2011 19:35, Adam Martinson <amartinson(a)codeweavers.com> wrote: > +#include "d3d10.h" I don't think so.

1 0

Re: [PATCH 3/4] dsound: Implement capture buffer based on mmdevapi, try 2
by Andrew Eikum April 26, 2011

April 26, 2011

It would be nice if you used more descriptive variable names. For example: +struct IDirectSoundCaptureBufferImpl +{ + DWORD buf_size; + DWORD pos; What units are these sizes and positions in? Frames? Bytes? Time? What position is being represented here, read, write, or something else? Using more descriptive names helps when understanding and verifying code like this: + pos1 = This->pos; + if (This->playing) + { + pos2 = This->format->nSamplesPerSec / 100; + pos2 *= This->format->nBlockAlign; + pos2 += pos1; + if (!This->looping && pos2 > This->buf_size) + pos2 = 0; + else + pos2 %= This->buf_size; + } + else + pos2 = pos1; + pos2 %= This->buf_size; Are all of these positions in Bytes? I hope so... (Remember this has tripped things up in the past, see bbbf72ddcb). If everything is always in bytes, maybe make a note of that near the variable declarations, and then verify that it's true throughout the code. Also, why is pos1 a separate variable here? These patches are all missing quite a lot of error handling, which really makes me hesitate. Especially on some important calls: + IAudioCaptureClient_GetBuffer(buf->cap_dev, &data, &read, &flags, &pos, 0); + IAudioClient_GetDevicePeriod(This->dev, &default_period, &min_period); + IAudioClient_Start(This->dev); Knowing when these functions fail will help debugging if something goes wrong. Much worse to suddenly crash four function calls later due to invalid default_period value than to just error out appropriately when the error occurs. This doesn't matter a whole lot, but I think it would be more clear to use a separate object here, instead of a separate refcount: struct IDirectSoundCaptureBufferImpl { IDirectSoundCaptureBuffer8 IDirectSoundCaptureBuffer8_iface; - LONG ref; + IDirectSoundNotify IDirectSoundNotify_iface; + LONG ref, notify_ref; If not, at least a comment explaining why two refcounts are needed. Obviously a test would improve it even more, if one doesn't already exist.

1 0

Re: cmd: handle spaces in directory names in del /s
by Alexandre Julliard April 26, 2011

April 26, 2011

Dan Kegel <dank(a)kegel.com> writes: > @@ -771,13 +771,16 @@ BOOL WCMD_delete (WCHAR *command, BOOL expectDir) { > > DIRECTORY_STACK *nextDir; > WCHAR subParm[MAX_PATH]; > + static const WCHAR quoteW[] = { '"', 0 }; > > /* Work out search parameter in sub dir */ > - strcpyW (subParm, thisDir); > + strcpyW (subParm, quoteW); > + strcatW (subParm, thisDir); > strcatW (subParm, fd.cFileName); > strcatW (subParm, slashW); > strcatW (subParm, fname); > strcatW (subParm, ext); > + strcatW (subParm, quoteW); That's ugly. File names should not go through command processing again. -- Alexandre Julliard julliard(a)winehq.org

1 0

requesting review and/or testing for directsound changes
by Maarten Lankhorst April 26, 2011

April 26, 2011

Hi all, with http://repo.or.cz/w/wine/multimedia.git and http://repo.or.cz/w/openal-soft.git you should be able to get the benefits of openal-soft's mixer while continuing to use whatever driver you want for mmdevapi. As a result directsound will only support openal-soft, but multi channel is suddenly supported, as is support for the floating point format. 24-bits and 32-bits int are currently not, but as soon as that capability is added to openal-soft.git wine will have a nice working dsound implementation with support for a lot of things that are missing now. The resampling code will also be a lot better and you should expect a higher quality when resampling is used. The capture changes should work nicely, and I don't expect a problem with that, since it's based on openal. The rendering code is essentially reviving the old dsound-openal, and outputting it to mmdevapi. Note: 24-bits and 32-bits int are unsupported and will most likely cause a crash, disable the #if 1 in get_fmtstr_EXT to prevent lying about support. It was put in place so the wine dsound tests would pass. A dsound.dll.so binary with openal-soft.git statically linked in can be found at: http://www.astro.rug.nl/~lankhorst/dsound.dll.so If you're using pulseaudio, patch your 32-bits alsa-plugins with the attached patch, or silence may occur when using the new mmdevapi drivers. Cheers, Maarten

2 1

Re: dinput/tests: Initial tests for Action Mapping. Added some tests for the creation of a DirectInput8 Interface and a dummy call of EnumDevicesBySemantics.
by Austin English April 26, 2011

April 26, 2011

On Sun, Apr 24, 2011 at 18:12, Lucas Fialho Zawacki <lfzawacki(a)gmail.com> wrote: Howdy Lucas, > + hr = CoCreateInstance(&CLSID_DirectInput8, 0, 1, &IID_IDirectInput8A, (LPVOID*)&pDI); > + if (hr == DIERR_OLDDIRECTINPUTVERSION || > + hr == DIERR_BETADIRECTINPUTVERSION || > + hr == REGDB_E_CLASSNOTREG) > + { > + skip("ActionMapping requires dinput8\n"); > + return; > + } > + ok(SUCCEEDED(hr), "DirectInput8 Create failed: hr=%08x\n", hr); > + if (FAILED(hr)) return; > + > + hr = IDirectInput8_Initialize(pDI,hinst, 0x0800 /* DirectInput8 */ ); > + if (hr == DIERR_OLDDIRECTINPUTVERSION || hr == DIERR_BETADIRECTINPUTVERSION) > + { > + skip("ActionMapping requires dinput8\n"); > + return; > + } You probably should use win_skip here, Wine shouldn't have missing dinput8 support. Cheers, Austin

3 2

Re: d3dx9_36: Fix uninitialized variable warnings.
by Matteo Bruni April 26, 2011

April 26, 2011

2011/4/26 Nicolas Le Cam <niko.lecam(a)gmail.com>: > msdn tells us to use 0 to disable colorkey [1]. Let me know if you > think it isn't the correct things to do. > > [1] http://msdn.microsoft.com/en-us/library/bb172902%28v=vs.85%29.aspx > > -- > Nicolas Le Cam > Argh, this was already spotted by Gerald Pfeifer some time ago and I told him I was going to send a patch, which didn't happen yet... I'm sending it now (I prefer to fix this in a different way), assuming your patch wasn't already committed by AJ.

2 1

Google Summer of Code 2011 is on!
by Austin English April 25, 2011

April 25, 2011

We've got five projects this year: Jay Yang - Implement the Explorer - http://socghop.appspot.com/gsoc/project/google/gsoc2011/yangjay/8001 Lucas Fialho Zawacki - Implementation of DirectInput8 Action Mapping feature - http://socghop.appspot.com/gsoc/project/google/gsoc2011/lfzawacki/8001 Michael Mc Donnell - Implement Missing Mesh Functions in Wine’s D3DX9 - http://socghop.appspot.com/gsoc/project/google/gsoc2011/mmd/9001 Michal Zietek - Implementing WScript API - http://socghop.appspot.com/gsoc/project/google/gsoc2011/misiek/6001 Pluciński Mariusz - Extending gameux.dll by Games Explorer Shell Extension - http://socghop.appspot.com/gsoc/project/google/gsoc2011/vshader/29001 Congrats everyone! Now get coding :-). -- -Austin

2 1

re: VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales
by Dan Kegel April 25, 2011

April 25, 2011

Nikolay wrote: >> Who has authority to approve it? > A patch? Alexandre Julliard, he's the only project maintainer. > Send a patch to wine-patches at winehq.org when you think > it's ready and you'll get some feedback if it's not. Be sure to send it to winetestbot first, and fix any problems it finds; see http://wiki.winehq.org/SubmittingPatches - Dan

2 1

ERROR: Compile wine tests on WINDOWS with MS C/C++
by Gerold Jens Wucherpfennig April 25, 2011

April 25, 2011

Regarding: 5.5.4. Standalone, using the Microsoft C++ Toolkit of http://www.winehq.org/docs/winedev-guide/testing-windows : I tried to compile dlls/rasapi32/test/rasapi.c on Windows and got these error messages: Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.30729.01 for 80x86 Copyright (C) Microsoft Corporation. All rights reserved. rasapi.c .\wine/test.h(66) : error C2143: syntax error : missing '{' before 'const' .\wine/test.h(70) : error C2054: expected '(' to follow 'inline' .\wine/test.h(71) : error C2085: 'winetest_strcmpW' : not in formal parameter li st .\wine/test.h(71) : error C2143: syntax error : missing ';' before '{' -- Gerold

2 1

Re: [PATCH 6/6] mmdevapi/tests: Add tests for IAudioClock
by Alexandre Julliard April 25, 2011

April 25, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > + pcpos = 0; > + hr = IAudioClock_GetPosition(acl, &pos, &pcpos); > + ok(hr == S_OK, "GetPosition failed: %08x\n", hr); > + ok(pos == 0, "GetPosition returned non-zero pos before being started: %lld\n", pos); Please avoid %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] wineoss.drv: Add MMDevAPI driver
by Alexandre Julliard April 25, 2011

April 25, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +{ > + int i, mixer_fd; > + oss_sysinfo sysinfo; > + static int print_once = 0; > + > + TRACE("%d %p %p %p\n", flow, ids, num, def_index); > + > + mixer_fd = open("/dev/mixer", O_RDONLY, 0); > + if(mixer_fd < 0){ > + ERR("OSS /dev/mixer doesn't seem to exist\n"); > + return AUDCLNT_E_SERVICE_NOT_RUNNING; > + } > + > + if(ioctl(mixer_fd, SNDCTL_SYSINFO, &sysinfo) < 0){ > + close(mixer_fd); > + > + if(errno == EINVAL){ > + ERR("OSS version too old, need at least OSSv4\n"); > + return AUDCLNT_E_SERVICE_NOT_RUNNING; You'll need a configure check too, things like the oss_sysinfo type don't exist on OSSv3. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 2)
by Alexandre Julliard April 25, 2011

April 25, 2011

Charles Davis <cdavis(a)mymail.mines.edu> writes: > Try 2: don't depend on the existence of scsi-generic entries in the HAL tree. It's still not listing my /dev/hda CD drive. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().
by Henri Verbeet April 25, 2011

April 25, 2011

2011/4/20 Rico Schüller <kgbricola(a)web.de>: > +inline LPSTR get_partial_string(LPCSTR name, char initial, char final) That should probably be static instead of inline. Also, get_parameter_by_name() looks like it could be split up, and you can probably avoid the copy in get_partial_string().

2 1

Style updates for source.winehq/patches
by Jerome Leclanche April 24, 2011

April 24, 2011

Attached patch to tools.git/patches/patches.css adds the necessary styling for a WineHQ-style patch status page: http://i.imgur.com/5ToSc.png The div class="main" needs to be replaced by the html attached in the other file. I can write a patch for it if it's to be included, but I cannot test it. Is it worth doing? J. Leclanche

1 0

Re: VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales
by Nikolay Sivov April 23, 2011

April 23, 2011

On 4/23/2011 22:46, John Fremlin wrote: > Nikolay Sivov<bunglehead(a)gmail.com> writes: > >> On 4/23/2011 22:22, John Fremlin wrote: >>> Nikolay Sivov<bunglehead(a)gmail.com> writes: >>> >>>> On 4/23/2011 19:00, John Fremlin wrote: >>>>> Europeans write dates generally as dd-mm-yyyy. This makes sense. So does >>>>> yyyy-mm-dd. Native will parse dates written yyyy-mm-dd correctly. Wine for some >>>>> reasons assumes they are yyyy-dd-mm. This is not a date ordering used anywhere >>>>> as far as I know and contradicts the MS behaviour. >>>>> >>>>> I've submitted http://bugs.winehq.org/show_bug.cgi?id=26902 >>>>> >>>>> I've included a patch which fixes the problem and adds a testcase. Is >>>>> there anything I can do to improve the chances that this fairly >>>>> unambiguous fix meets the next release? -- I have some secret and >>>>> cunning plans which are unfortunately predicated on this being fixed. >>>>> @@ -3458,6 +3458,7 @@ static void test_VarDateFromStr(void) >>>>> DFS("02.01.1970"); EXPECT_DBL(25570.0); >>>>> DFS("02.13.1970"); EXPECT_DBL(25612.0); >>>>> DFS("02-13-1970"); EXPECT_DBL(25612.0); >>>>> + DFS("2020-01-11"); EXPECT_DBL(43841.0); >>>> Hi, John. >>>> >>>> This is locale-dependent thing, so it will need at least more tests >>>> for different locales (locales with different default month/day order >>>> I mean). >>> Hi Nikolay, >>> >>> Is there really ever a locale which actually parses ydm under the native >>> implementation? >> Not really, as far as I know. My point was to test with different >> pattern anyway. For example for >> yyyy/mm/dd and dd/mm/yyyy locales. Also this particular test is not >> very descriptive cause >> month and day in it both fit month or day range, so you can't tell how >> it's interpreted. > I don't understand the confusion here? > > The single test extra test is explicitly for a date that can only be > converted either as y-m-d or the imaginary Wine-only y-d-m format. That > should be interpreted in exactly one way, and it is interpreted > incorrectly at the moment. The patch fixes that. Yes, I got it. Wine converts 2020-01-11 string as 1st of November while native treats it as 11th of January. What I meant that test data should be clear about what field is day and what's a month. For your case it could be '2020-01-30' to make 30 invalid value for a month. > If you want extra tests, I'm sure they'd be great, but I think this > pretty unambiguously represents an improvement. About additional tests, what about cases like '2020-20-01' on locales that use 'mm/dd/yyyy' or '2020-01-30' for locales that are 'dd/mm/yyyy'? Even if you're sure patch doesn't break that it's always better to add more tests (maybe some tests for that are in already). > Who has authority to approve it? A patch? Alexandre Julliard, he's the only project maintainer. Send a patch to wine-patches(a)winehq.org when you think it's ready and you'll get some feedback if it's not.

1 0

VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales
by John Fremlin April 23, 2011

April 23, 2011

Europeans write dates generally as dd-mm-yyyy. This makes sense. So does yyyy-mm-dd. Native will parse dates written yyyy-mm-dd correctly. Wine for some reasons assumes they are yyyy-dd-mm. This is not a date ordering used anywhere as far as I know and contradicts the MS behaviour. I've submitted http://bugs.winehq.org/show_bug.cgi?id=26902 I've included a patch which fixes the problem and adds a testcase. Is there anything I can do to improve the chances that this fairly unambiguous fix meets the next release? -- I have some secret and cunning plans which are unfortunately predicated on this being fixed.

2 3

Re: Matching Windows 7 folder locations?
by newsletter [at] Schiermeier-Software April 23, 2011

April 23, 2011

Hello Dan, wdrwo> Windows 7 changed the folders in c:/users/$USERNAME around a bit. not only 'a bit'. There are a lot of changes in the folder structure since Vista: See URL: <http://msdn.microsoft.com/en-us/library/dd378457(v=VS.85).aspx> -- Joerg Schiermeier

1 0

Missing backtrace when debugging a game
by Jerome Leclanche April 23, 2011

April 23, 2011

I'm currently trying to debug http://bugs.winehq.org/show_bug.cgi?id=25977. Even when running "winedbg bin/release/loader.exe", this is what happens: Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00365327). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:00365327 ESP:0033dd20 EBP:000003d9 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:00000000 ECX:0018e268 EDX:00000011 ESI:0018e268 EDI:0016e560 Stack dump: 0x0033dd20: 00000000 0018e268 003670f9 0033dd9c 0x0033dd30: 0033fb68 0002002a 001712b0 00000005 0x0033dd40: 100d2e46 00401920 0002002a 0033e39c 0x0033dd50: 0033ddc8 7edb2ff4 00000000 00000000 0x0033dd60: 00000000 00000000 00000690 0000041a 0x0033dd70: 0000002c 00000000 00000001 ffffffff 000c: sel=0067 base=00000000 limit=00000000 16-bit rw- Backtrace: 0x00365327: movl 0x0(%eax),%ecx Wine-dbg>bt Backtrace: Any advice, or idea why this would happen? Furthermore, is it a bug with winedbg, and worth filing? J. Leclanche

3 2

Matching Windows 7 folder locations?
by Dan Kegel April 23, 2011

April 23, 2011

Windows 7 changed the folders in c:/users/$USERNAME around a bit. My Documents is now just a link to the new folder Documents Application Data is now just a link to the new folder AppData/Roaming Local Settings is now just a link to the new folder AppData/Local How is this going to affect Wine? Well-behaved apps that use CSIDL_PERSONAL to get at "My Documents" or "Documents" will work regardless, but users or badly behaved apps might start expecting the shorter directory names sometime. (I always hated the spaces, anyway.)

3 2

Re: user32: Fix Jittery Mouse movement
by Vitaliy Margolen April 22, 2011

April 22, 2011

On 04/22/2011 02:06 PM, EG Galano wrote: > This fixes jittery mouse movement in Combat Arms. This was introduced > in commit 79c2e55b5a6331d15788f65a929e9e002c2f8b05 > > This is likely the same issue discussed here but I don't have a copy > to test: http://forum.winehq.org/viewtopic.php?t=11759&sid=9d9518057d4c0ef51be8c37d9… > - if (ret && (prev_x != new_x || prev_y != new_y)) USER_Driver->pSetCursorPos( new_x, new_y ); > + if (ret && (prev_x != new_x && prev_y != new_y)) USER_Driver->pSetCursorPos( new_x, new_y ); Obviously this is wrong. Something else is at fault here. Vitaliy.

2 1

Managing word agreements in PO translations?
by Frédéric Delanoy April 22, 2011

April 22, 2011

Hi, In various languages, there are multiple forms/agreements for a pronoun/adjective. In French, for instance masculine and feminine forms exist; in other languages (like German IIRC) there's even a neutral form (other languages may also be more complicated) while agreements in English are limited, e.g. there's only one form for masculine/feminine/plural adjectives. This makes translating short English words problematic. In my case, I've a problem with the following PO entry #: comctl32.rc:44 crypt32.rc:198 progman.rc:78 winecfg.rc:76 msgid "None" According to context, it can be translated (in French) as either "Aucun" or "Aucune" (agreements on the same word). Admitedly, it could be translated with "Aucun(e)" but that seems more like a workaround and feels a bit weird (user shouldn't see partially incorrect/odd translations because of technical issues) OTOH, creating a distinct msgcontext for every agreement in every supported language may be overkill, although the number of affected msgids is limited. What's your opinion on how to handle that, folks? Frédéric Delanoy NB: This obviously posed no problem before the rc->po migration, since it was duplicated in different rc files

2 3

Re: d3d8: Attempting to set a NULL rt is legal in d3d8
by Henri Verbeet April 22, 2011

April 22, 2011

On 22 April 2011 14:25, "Stefan Dösinger" <stefandoesinger(a)gmx.at> wrote: > An unrelated issue I am ignoring for now: > void * __cdecl wined3d_buffer_get_parent(const struct wined3d_buffer *buffer); > > in the .idl file is compiled by Microsoft's midl to > > void *__cdecl wined3d_buffer_get_parent( > struct wined3d_buffer *buffer); > > ie, the const is lost, leading to complaints from msvc that the implementation function doesn't match the declaration. Any idea how to fix it? > Odd. But I think we can ignore it unless there's an easy fix, the IDL file should go away anyway once COM is gone from wined3d. Though maybe widl should match that behaviour.

1 0

Re: [2/2] wined3d: Scale the depthbias factor by the depth buffer's depth
by Henri Verbeet April 22, 2011

April 22, 2011

On 22 April 2011 13:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + scale = 0; I thought you cared about the warnings MSVC generates for this kind of thing. :)

1 0