April 2011 - Wine-Devel - list.winehq.org

Re: Fix to bug 25504 for gnutls based schannel
by Hans Leidekker April 18, 2011

April 18, 2011

On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote: > #ifdef SONAME_LIBGNUTLS > #include <gnutls/gnutls.h> > +#include <gcrypt.h> > +#include <pthread.h> > +#include <errno.h> > +GCRY_THREAD_OPTION_PTHREAD_IMPL; You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.

5 6

Re: [PATCH 02/10] msvcrt: Use callback based printf in cprintf functions family
by Alexandre Julliard April 18, 2011

April 18, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > +printf_arg arg_clbk_valist(void *ctx, int arg_pos, size_t size, __ms_va_list *valist) > +{ > + printf_arg ret; > + > + if(size == sizeof(LONGLONG)) > + ret.get_longlong = va_arg(*valist, LONGLONG); > + else if(size == sizeof(int)) > + ret.get_int = va_arg(*valist, int); > + else { > + ERR("Incorrect size\n"); > + ret.get_int = 0; > + } You can't do that, you need to use the correct type in va_arg. Different types can be passed differently even if they have the same size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] Fix d3dx9_parse_effect_typedef for stuctures.
by Rico Schüller April 18, 2011

April 18, 2011

The patch has the wrong description, I'll fix and resend that. Am 18.04.2011 10:26, schrieb Rico Schüller: > --- > dlls/d3dx9_36/effect.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > >

1 0

Re: Wine: Use the compiler option -Wpointer-arith if available.
by Michael Stefaniuc April 17, 2011

April 17, 2011

On 04/17/2011 01:19 AM, Gerald Pfeifer wrote: > GCC provides an option -Wpointer-arith and describes it as follows: > > Warn about anything that depends on the "size of" a function type > or of `void'. GNU C assigns these types a size of 1, for > convenience in calculations with `void *' pointers and pointers to > functions. > > This does not trigger on my Wine builds, but then we should not invoke Of course it doesn't triggers in Wine as -Wpointer-arith is already enabled. I made heavy use of that when I did my pointer cast killing spree a few years ago. > sizeof(void) or sizeof(some_function). ;-) It should help catch any > such bad future uses of sizeof. > > Gerald > --- > configure.ac | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6047744..0ae6625 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1715,6 +1715,7 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > + WINE_TRY_CFLAGS([-Wpointer-arith]) > WINE_TRY_CFLAGS([-Wstrict-prototypes]) > WINE_TRY_CFLAGS([-Wtype-limits]) > WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) bye michael

2 1

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs
by Gerold Jens Wucherpfennig April 17, 2011

April 17, 2011

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs. I think it's not allowed to do a "winedump <dllname>.lib" But what to do else? Regards Gerold

3 3

Re: crypt32: Fix length-handling of 'decodeBase64Block'
by Marvin April 16, 2011

April 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10497 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

RAS.h
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I want to complete the rasapi32.dll, but the header file RAS.h of wine is incomplete. It hasn't been changed since 1998. >From where may I copy the missing parts? >From the Windows SDK documentation? I think I may not be allowed to directly copy it from Windows' ras.h Best Regards Gerold

2 1

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig April 15, 2011

April 15, 2011

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

2 1

Windres and wine
by Gerold Jens Wucherpfennig April 15, 2011

April 15, 2011

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

2 1

Re: inetcpl: Update French translation
by Nicolas Le Cam April 15, 2011

April 15, 2011

Hi Frédéric, Le 13 avril 2011 23:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > --- > dlls/inetcpl.cpl/cpl_Fr.rc | 42 > +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 41 insertions(+), 1 deletions(-) > > diff --git a/dlls/inetcpl.cpl/cpl_Fr.rc b/dlls/inetcpl.cpl/cpl_Fr.rc > index 1244ff6..432a8c3 100644 > --- a/dlls/inetcpl.cpl/cpl_Fr.rc > +++ b/dlls/inetcpl.cpl/cpl_Fr.rc > @@ -2,7 +2,7 @@ > * Internet control panel applet > * French language support > * > - * Copyright 2010 Frédéric Delanoy > + * Copyright 2010-2011 Frédéric Delanoy > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -49,6 +49,46 @@ BEGIN > > END > > +/* "Delete browsing history" dialog */ > +IDD_DELETE_HISTORY DIALOG 0, 0, 250, 250 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +FONT 8, "MS Shell Dlg" > +CAPTION "Effacer l'historique de navigation" > +BEGIN > + > + AUTOCHECKBOX "Fichiers internet temporaires\nCopies en cache de > pages web, d'images et de certificats.", > + IDC_DELETE_TEMP_FILES, 10, 8, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Cookies\nFichiers sauvés sur votre ordinateur par des > sites web, qui y stockent des informations comme des préférences utilisateur > et des informations de connexion", > You should use sauvegardés instead of sauvés which doesn't apply to computers. I would also use "qui y stockent des choses comme les préférences utilisateurs et les informations de connexion". It better follows the original text and avoid a repetition. > + IDC_DELETE_COOKIES, 10, 32, 230, 35, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Historique\nListe des sites web accédés.", > + IDC_DELETE_HISTORY, 10, 73, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Données de formulaires\nNoms d'utilisateur et autres > informations entrées dans des formulaires.", > + IDC_DELETE_FORM_DATA, 10, 98, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Mots de passe\nMots de passe entrés dans des > formulaires et sauvegardés.", > + IDC_DELETE_PASSWORDS, 10, 128, 230, 30, BS_TOP | > BS_MULTILINE > + DEFPUSHBUTTON "Annuler", IDCANCEL, 185, 228, 60, 15, WS_GROUP > + PUSHBUTTON "Effacer", IDOK, 120, 228, 60, 15, WS_GROUP > + > +END > + > +/* "Security" propsheet */ > +IDD_SECURITY DIALOG 0, 0, 320, 220 > +STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > +FONT 8, "MS Shell Dlg" > +CAPTION "Security" > +BEGIN > + > + CONTROL "Listview", IDC_SEC_LISTVIEW, "SysListView32", > + LVS_ICON | LVS_ALIGNLEFT | LVS_AUTOARRANGE | LVS_SINGLESEL > | LVS_SHOWSELALWAYS | WS_BORDER | WS_VSCROLL, > + 4, 4, 312, 58 > + LTEXT "", IDC_SEC_ZONE_INFO, 4, 68, 312, 20 > + GROUPBOX "", IDC_SEC_GROUP, 4, 88, 312, 126 > + CONTROL "trackbar", IDC_SEC_TRACKBAR, "msctls_trackbar32", > + TBS_VERT | TBS_AUTOTICKS | TBS_BOTH | TBS_REVERSED, 8, 98, > 32, 100 > + LTEXT "", IDC_SEC_LEVEL, 48, 102, 180, 12 > + LTEXT "", IDC_SEC_LEVEL_INFO, 48, 114, 260, 80 > +END > + > /* "Content" propsheet */ > IDD_CONTENT DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > -- > 1.7.4.3 > > > > -- Nicolas Le Cam

3 2

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig April 15, 2011

April 15, 2011

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

1 0

Re: winedevice: eliminate some globals
by Alexandre Julliard April 15, 2011

April 15, 2011

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate some globals > > The long term goal of this patch is to make the driver loading code > reusable for loading drivers outside winedevice, for use with USB > drivers etc. It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\ err=5 should be 3 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\removeme\ err=5 should be 3 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:944: Test failed: CreateFileA failed on \\?\C:, hFile 0xffffffff, err=2, should be 0 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for \\?\C:\ err=5 should be 3 file.c:1000: Test failed: CreateFileA did not open \\?\C:, last error=2 file.c:1059: Test failed: CreateFileA did not open \\.\C:, last error=2 file.c:1078: Test failed: GetVolumeNameForVolumeMountPointA failed, for C:\, last error=2 file.c:1157: Test failed: GetVolumeNameForVolumeMountPointA not functioning make: *** [file.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Windres and wine
by Gerold Jens Wucherpfennig April 15, 2011

April 15, 2011

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

1 0

Quartz Driver patches (NOT for inclusion in Wine)
by Charles Davis April 15, 2011

April 15, 2011

Hi, A while ago, I started work on my own Quartz Driver. This was before I finished my "Deobjectivizer" tool, so only some of the pure Quartz stuff (no Cocoa) is implemented. My intent after finishing "Deobjectivizer" was to start implementing windowing and other vital pieces of the driver (i.e. the pieces that need Cocoa to work). I know now that CodeWeavers is working on their own version of the Quartz Driver. So, I don't need to continue working on this. That's why I've decided to post all of my Quartz Driver patches here, on the off-chance that CW may wish to use some of them. They are all licensed under the LGPL 2.1, the same license as Wine itself. If they don't want to use any of them, that's OK. I just thought we could get this done faster if we took some of the work that I and others have done. If this is the wrong place to post this, I apologize, and I would really appreciate a pointer in the right direction. Chip

1 0

Try to implement my first stub function - AbortPrinter() - (try 4)
by Loïc Maury April 15, 2011

April 15, 2011

Hello, From what was said from the last comments, I have modified the code and I have added the test patch. What do you think ? Thank you Loïc

2 2

RE: winex11: Retrieve raw mouse events through XInput2 while the cursor is clipped.
by Vitaliy Margolen April 15, 2011

April 15, 2011

It's great to see so much progress in this area! Great gob so far. However this isn't enough. Cursor doesn't have to be clipped to receive mouse event's. As far as dinput goes, it will read mouse events regardless where the pointer is if device is acquired in background mode. Or this isn't the final commit yet? Vitaliy.

2 1

Re: wintrust: add a stub for IsCatalogFile()
by Juan Lang April 14, 2011

April 14, 2011

Hi Austin, it wouldn't be hard to implement this with CryptSIPRetrieveSubjectGuid: if it returns the GUID for .cat files, return TRUE. --Juan

1 0

Re: [PATCH] Allow for RPC_S_NO_CONTEXT_AVAILABLE return status
by Alexandre Julliard April 14, 2011

April 14, 2011

"Ray Hinchliffe (RH)" <ray(a)rh-software.com> writes: > @@ -196,7 +196,8 @@ static RpcPktHdr *handle_bind_error(RpcConnection *conn, RPC_STATUS error) > default: > FIXME("unexpected status value %d\n", error); > /* fall through */ > - case RPC_S_INVALID_BOUND: > + case RPC_S_INVALID_BOUND: > + case RPC_S_NO_CONTEXT_AVAILABLE: > reject_reason = REJECT_REASON_NOT_SPECIFIED; > break; Please explain why this happens and why this is the right error to return. -- Alexandre Julliard julliard(a)winehq.org

1 0

debugging wine itself with GDB
by joedude＠winedev1.nospam.homeip.net April 13, 2011

April 13, 2011

I was taking a look at http://wiki.jswindle.com/index.php/Debugging_Wine to see how to debug wine with gdb, and there was reference to starting up gdb using wine-pthread, but I see no such executable now. I can attach gdb after it starts to run, but then do not get all the symbol information. There is wine-preloader but it seems to want an ELF file as an argument.

2 1

massively "skipped" tests being shown
by Saulius Krasuckas April 13, 2011

April 13, 2011

Hello, there is something wrong with WRT result page/parser [1] (or with TestBot too) since yesterday. All tests' results from TestBot are shown as "skipped by user request", eg. for XP [2]. Results from physical machines are present, currently only one (af-xpsp3-nv) which shows 12 failures. But in the daily summary we see 28 failures for XP. [3] Sounds like a bug or two:) S. [1] http://test.winehq.org/data/ [2] http://test.winehq.org/data/e5c3883c923d345848315a39a090607bdddac936/index_… [3] http://test.winehq.org/data/e5c3883c923d345848315a39a090607bdddac936/

2 1

Re: [PATCH 2/4] inetcpl: Fill the security listview with zones
by Nikolay Sivov April 13, 2011

April 13, 2011

Some minor things regarding listview. On Wed, Apr 13, 2011 at 7:33 AM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > --- > dlls/inetcpl.cpl/security.c | 131 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 131 insertions(+), 0 deletions(-) > > +static void add_zone_to_listview(secdlg_data *sd, DWORD *pindex, DWORD zone) > +{ > + DWORD lv_index = *pindex; > + ZONEATTRIBUTES *za = &sd->zone_attr[lv_index]; > + LVITEMW lvitem; > + HRESULT hr; > + INT iconid = 0; > + HMODULE hdll = NULL; > + WCHAR * ptr; > + HICON icon; > + > + TRACE("item %d (zone %d)\n", lv_index, zone); > + > + sd->zones[lv_index] = zone; > + > + memset(&lvitem, 0, sizeof(LVITEMW)); This reset shouldn't be needed, cause control checks for mask field and doesn't access other fields. > + > + if (ListView_InsertItemW(sd->hlv, &lvitem) >= 0) { > + /* activate first item in the listview */ > + if (! lv_index) { > + lvitem.state = LVIS_FOCUSED | LVIS_SELECTED; > + lvitem.stateMask = LVIS_FOCUSED | LVIS_SELECTED; > + SendMessageW(sd->hlv, LVM_SETITEMSTATE, 0, (LPARAM) &lvitem); > + } > + SendMessageW(sd->hlv, LVM_SETIMAGELIST, LVSIL_NORMAL, (LPARAM)sd->himages); > + You could use macros here too, if you prefer that.

1 0

po: Update US English resource
by Ken Sharp April 13, 2011

April 13, 2011

http://www.winehq.org/pipermail/wine-devel/2011-April/089585.html (I lost the original mail - along with a bunch of others) I'm confused as to what the .po files are for. ise/ize will be correct if the .rc file default is British English. Without updating the .po file for US English I don't see how else this can be updated - unless it is simply the way it was before with LANG_ and SUBLANG_, but then what are the .po files for? I can't find any details in the Wiki and I'm afraid I wasn't around when they were introduced...

1 0

ntdll: Add support for Windows XP 64-bit
by Ken Sharp April 12, 2011

April 12, 2011

Morning all, Could someone far smarter than me please take a look at the attached patch? Windows XP 64-bit runs NT kernel 5.2, whereas 32-bit runs 5.1. Any 64-bit app expecting XP 64-bit will fail (such as IE8 for NT 5.2). The patch lets the installer continue, but I'm not sure if it is enough to be accepted. For example, do I need to "winxp,winxp64", here? http://source.winehq.org/source/dlls/ntdll/version.c?v=wine-1.3.17#L172 TIA, Ken.

1 0

Re: wined3d: Track when the FBO is dirty. (try 3)
by Henri Verbeet April 12, 2011

April 12, 2011

On 7 April 2011 18:51, Adam Martinson <amartinson(a)codeweavers.com> wrote: > - context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + > + if (rt_count == device->adapter->gl_info.limits.buffers && > + rts == device->render_targets && > + depth_stencil == device->depth_stencil) > + { > + if (context->device_fbo != NULL) > + { > + context_apply_device_fbo(context); > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; > + } > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + } That's not very pretty. > @@ -6709,6 +6721,7 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as render target %u.\n", surface, i); > device->render_targets[i] = NULL; > + fbo_dirty = TRUE; > } > } > > @@ -6716,7 +6729,10 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as depth/stencil buffer.\n", surface); > device->depth_stencil = NULL; > + fbo_dirty = TRUE; That code should never execute, hence the ERR.

2 3

Re: [2/2] comctl32/tab: Use dpa to store item data
by Henri Verbeet April 12, 2011

April 12, 2011

On 10 April 2011 07:56, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Use dpa to store item data > This seems to break text on winecfg tabs for me.

3 4