April 2011 - Wine-Devel - list.winehq.org

Re: user32: Fix the single menu item activation using a hot key.
by Marvin April 12, 2011

April 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10449 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

__CxxFrameHandler unsupported on wine64?
by Peter Urbanec April 12, 2011

April 12, 2011

I have an application that requires MFC80.DLL. When I install only the MFC80.DLL file from the vcredist package, I end up with the following errors: wine: Call from 0x7fd606a3148b to unimplemented function MSVCR80.dll.__CxxFrameHandler, aborting So, I had a quick look at the wine source and found a comment in dlls/msvcrt/cppexcept.c that says: /* CxxFrameHandler is not supported on non-i386 */ I don't think that this is quite right, given that Microsoft's MFC80.DLL attempts to call __CxxFrameHandler. Is it more likely that wine only provides an i386 implementation? If so, is there any chance that someone may be able to provide x86_64 implementation in the near future? It's way over my head :-( Best regards, Peter Urbanec

2 1

Re: [3/3] wined3d: only acquire a context in buffer::PreLoad if we have to
by Henri Verbeet April 12, 2011

April 12, 2011

You can't just resend this unmodified if you're leaving buffer creation in.

2 1

Re: [PATCH 4/4] d3d9: COM cleanup for the IDirect3DSwapChain9 iface.
by Michael Stefaniuc April 11, 2011

April 11, 2011

Please ignore this patch for now as it conflicts with Henri's patch. bye michael On 04/12/2011 10:23 AM, Michael Stefaniuc wrote: > --- > dlls/d3d9/d3d9_private.h | 7 ++--- > dlls/d3d9/device.c | 8 +++--- > dlls/d3d9/swapchain.c | 61 ++++++++++++++++++++++++++++++---------------- > 3 files changed, 47 insertions(+), 29 deletions(-)

1 0

Re: dbghelp: get rid of a couple unused variables (try 2)
by Eric Pouech April 11, 2011

April 11, 2011

Le 11/04/2011 19:07, Austin English a écrit : IMO, you should keep the variable names in comment so that we know what we're talking about: /* version = */ dwarf2_parse_u2(&ctx); or dwarf2_parse_u2(&ctx); /* version */ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: dbghelp: get rid of a couple unused variables
by Andrew Nguyen April 11, 2011

April 11, 2011

On 04/11/2011 12:41 AM, Austin English wrote: > This ignores the side effects of the dwarf2_parse_u2 function.

2 1

Re: gdi32/dibdrv: The dib debug channel is unused so remove it.
by Huw Davies April 11, 2011

April 11, 2011

On Sun, Apr 10, 2011 at 06:45:51PM +0200, Francois Gouget wrote: > It might get used soon but then it's easy to add back anyway. Very soon in fact - it gets used in the PatBlt patch I just sent ;-)

1 0

Re: d3dx9_36: Make get_parameter_{handle,struct}() static.
by luis.busquets＠ilidium.com April 11, 2011

April 11, 2011

Shouldn't this be inline? > --- > dlls/d3dx9_36/effect.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index 1e3de0c..a03e8a3 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -91,12 +91,12 @@ static void skip_dword_unknown(const char **ptr, > unsigned int count) > } > } > > -struct d3dx_parameter *get_parameter_struct(D3DXHANDLE handle) > +static struct d3dx_parameter *get_parameter_struct(D3DXHANDLE handle) > { > return (struct d3dx_parameter *) handle; > } > > -D3DXHANDLE get_parameter_handle(struct d3dx_parameter *parameter) > +static D3DXHANDLE get_parameter_handle(struct d3dx_parameter *parameter) > { > return (D3DXHANDLE) parameter; > } > -- > 1.7.4.1 > > > >

1 0

Ubuntu's new UI has glitches that affect Wine...
by Dan Kegel April 11, 2011

April 11, 2011

Ubuntu 11.04 beta 1 is out, http://www.ubuntu.com/testing/natty/beta There are aleady about six bug reports about how its new UI interacts with Wine: https://launchpad.net/ubuntu/+bugs?field.searchtext=unity+wine If you're an ubuntu user, please try out Natty Beta, review those bugs, and vote for the ones that affect you. And file more if you find any! - Dan

1 1

Introducing "Deobjectivizer"
by Charles Davis April 10, 2011

April 10, 2011

Hi, I've been working on a secret Clang-based project for a while, and now I'm ready to share it with the world. Introducing the "Deobjectivizer". This is a program that scans framework bundle headers for Objective-C constructs, and generates procedural C wrappers around them, so you can call them from C. It uses Clang's libraries to parse, analyze, and rewrite Objective-C headers into pure C headers, and then generate corresponding source files containing the wrapper implementations. The implementation of this tool is a little hackish at the moment, but it suffices to generate a wrapper around the entire Foundation framework (at least). With this, we don't have to use Objective-C just to use Cocoa anymore. The Mac OS X Quartz driver can go forward now! The QuickTime decoder can use QTKit now instead of the 32-bit only Carbon QuickTime interface, allowing it to work on 64-bit (if and when Wine supports it on Mac). It might even be possible to integrate Win32 screen-savers with Mac OS X using this (the ScreenSaver framework is Objective-C based). I've attached the source so you can play with my newest creation. At the moment, it can only be built on Mac OS X (only one of two platforms, the other being iOS, where a program like this makes sense anyway). Feel free to make changes; the sources are licensed under the same license as Clang itself. We can't incorporate it into Wine directly because it is written in C++ (and maybe because of the license), but we can detect its presence at compile time (in configure) and use it to generate pure C wrappers that Wine can use. Comments welcome. What do you think? Chip

1 0

Re: gdiplus: Make get_font_hfont() static.
by Vincent Povirk April 10, 2011

April 10, 2011

I'm planning to use this from GdipAddPathString. On Sun, Apr 10, 2011 at 11:45 AM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 2 -- > dlls/gdiplus/graphics.c | 2 +- > 2 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 1629ae6..bfa33ef 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -58,8 +58,6 @@ extern void calc_curve_bezier_endp(REAL xend, REAL yend, REAL xadj, REAL yadj, > > extern void free_installed_fonts(void); > > -extern void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont); > - > extern BOOL lengthen_path(GpPath *path, INT len); > > extern GpStatus trace_path(GpGraphics *graphics, GpPath *path); > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 336929f..6a5ef7f 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -1654,7 +1654,7 @@ end: > return stat; > } > > -void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont) > +static void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont) > { > HDC hdc = CreateCompatibleDC(0); > GpPointF pt[3]; > -- > 1.7.4.1 > > > >

1 0

Try to implement my first stub function - AbortPrinter() - (try 3)
by Loïc Maury April 9, 2011

April 9, 2011

Hello, I try always to implement my first stub function - AbortPrinter. The last time, I send into Wine patch mailling list, but the patch was not correct. Now I think the format for the patch is correct (no whitespace, etc…). More over, I have modified the value if(!job->portname) by if(!portname), because after the test "if(!job->portname)", I print trace of portname, but before he was initialized into the "if condition" and can to not enter into this condition. What do you think ? Thank you Loïc

3 3

Fwd: d3dx9_36 [patch 1/3; try 9]: Remove useless includes
by David Adam April 9, 2011

April 9, 2011

Any feedback for the reasons why this patch and the following ones were not commited? Thanks in advance A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/4/6 Subject: d3dx9_36 [patch 1/3; try 9]: Remove useless includes To: wine-patches <wine-patches(a)winehq.org>

1 0

Must multimedia players check the message queue and invoke DispatchMessage?
by Joerg-Cyril.Hoehle＠t-systems.com April 9, 2011

April 9, 2011

Hi, In Bug #3930 http://bugs.winehq.org/show_bug.cgi?id=3930#c41 I conjectured that: 1. Since w2k, winmm hijacks the application's thread to play multimedia content. Wine does this as well with MCI_WAIT, but it should as well affect winmm:playSound, winmm:midi* and winmm:wave*. 2. Consequently, the players must implement a message loop and dispatch regular window messages using DispatchMessageA/W Currently, Wine does not. This IMHO has potential for dead locks. Music and animations can play for a long time and messages ought to be serviced. I'm not familiar with windows messages at all. What do you think about the consequence? Point 1 explains why tests reveal the current thread as the one executing all callbacks but one since w2k. Point 2 should be testable by playing a long piece of video or music and prequeuing or injecting (how?) some windows events. How to test this in a convincing manner? Would the obligation to service messages disappear if the players ran in their own thread (like w9x seems to do)? Thanks for your help, Jörg Höhle

5 8

Project: x86 to ARM binary translator
by Yale Zhang April 9, 2011

April 9, 2011

Fellow developers, I'm thinking of starting a VM project to allow running x86 Windows apps on ARM Android. This will obviously involve binary translation. I've read about QEMU's tiny code generator and think for a usable experience, the intermediate micro-op representation will have to be abandoned, and use a more efficient, though less portable x86 to ARM translator. I also saw some Google SOC project that tried to incorporate LLVM into QEMU, but with disastrous slow down if done naively. I still think it's worth to do so, but lots of care will need to be done to only optimize code that needs it like Sun's HotSpot Java compiler does. Questions: 1. How useful would this be and how much interest? Obviously, this will be a huge project, and I just want to gauge the interest before I jump in. Microsoft will be releasing Windows for ARM soon, so there will be no need to worry about running Office, Matlab, Visual C++, etc on ARM, leaving only legacy applications and games to benefit from binary translation. I'm mostly interested in seeing some 3D games run on my Xoom. 2. What's the best design: whole system VM (qemu) or process VM (qemu & wine)? Process VM: + easier to incorporate 3D acceleration at API level + uses less memory + better performance (e.g. no need for MMU translation when accessing memory) + much better integration with host OS - needs to maintain custom Windows API implementation (Wine) Whole system VM: + simpler, more unified to implement + much better support for apps that are dependent on new, proprietary, obscure Windows libraries, interfaces (moot because Office, Matlab, etc will soon be available for ARM) Given the aims of only running legacy applications and games, it seems a foregone conclusion that Wine's process VM approach is best. Comments? 3. Will Wine ever incorporate binary translation? My proposed design will obviously use Wine's implementation of the Windows API, which is huge. I'm not sure how disruptive of a change binary translation will be to Wine. If Wine does incorporate binary translation, maybe they can change the name to Wine Is Now an Emulator If your're interested in this project, please reply.

6 7

Re: [PATCH 4/5] wined3d: Merge the IWineD3DSwapChain::Destroy() implementations.
by Alexandre Julliard April 8, 2011

April 8, 2011

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > They're mostly the same, except for the GL version also destroying its > contexts, and being a bit more careful about the order in which backbuffers > are destroyed. > --- > dlls/wined3d/swapchain.c | 175 ++++++++++++++++----------------------------- > 1 files changed, 62 insertions(+), 113 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddrawmodes.c && touch ddrawmodes.ok wine: Unhandled page fault on read access to 0x00000f2c at address 0x687550fa (thread 0021), starting debugger... Unhandled exception: page fault on read access to 0x00000f2c in 32-bit code (0x687550fa). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:687550fa ESP:0032f910 EBP:0032f948 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000021 EBX:6884b244 ECX:00110064 EDX:00000000 ESI:00000000 EDI:00000001 Stack dump: 0x0032f910: 00001302 00131ef0 00000000 00000000 0x0032f920: 00000000 00000000 00000000 00110014 0x0032f930: 0000ff00 000000ff 687550db 6884b244 0x0032f940: 00131848 00000001 0032f9a8 6880052b 0x0032f950: 00134d58 00000000 00131ef0 7bc73cfc 0x0032f960: 00000002 00129f28 00000000 000004b0 Backtrace: =>0 0x687550fa context_destroy+0x2a(This=0x134d58, context=(nil)) [/home/julliard/wine/wine/dlls/wined3d/context.c:1615] in wined3d (0x0032f948) 1 0x6880052b IWineD3DBaseSwapChainImpl_Destroy+0x18a(iface=0x131848) [/home/julliard/wine/wine/dlls/wined3d/swapchain.c:65] in wined3d (0x0032f9a8) 2 0x688006a1 IWineD3DBaseSwapChainImpl_Release+0x40(iface=0x131848) [/home/julliard/wine/wine/dlls/wined3d/swapchain.c:125] in wined3d (0x0032f9e8) 3 0x686d25b9 D3D7CB_DestroySwapChain+0x58(swapchain=0x131848) [/home/julliard/wine/wine/dlls/ddraw/ddraw.c:2621] in ddraw (0x0032fa18) 4 0x6875d317 IWineD3DDeviceImpl_UninitGDI+0x66(iface=0x134d58, D3DCB_DestroySwapChain=0x686d2560) [/home/julliard/wine/wine/dlls/wined3d/device.c:2300] in wined3d (0x0032fa78) 5 0x686f8f6e ddraw_surface7_Release+0x1cd(iface=0x129f28) [/home/julliard/wine/wine/dlls/ddraw/surface.c:396] in ddraw (0x0032fad8) 6 0x68689c21 func_ddrawmodes+0x2720() [/home/julliard/wine/wine/dlls/ddraw/tests/ddrawmodes.c:583] in ddraw_test (0x0032fd38) 7 0x686adc9e run_test+0x14d(name="ddrawmodes.c") [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:556] in ddraw_test (0x0032fd88) 8 0x686ae767 main+0x156(argc=0xffffffff, argv=(nil)) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:624] in ddraw_test (0x0032fe48) 9 0x686ae93c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ddraw_test (0x0032fe90) 10 0x7b859a6c call_process_entry+0xb() in kernel32 (0x0032fea8) 11 0x7b85a69f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1086] in kernel32 (0x0032fee8) 12 0x7bc74c78 call_thread_func+0xb() in ntdll (0x0032fef8) 13 0x7bc776b0 call_thread_entry_point+0x6f(entry=0x7b85a640, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffc8) 14 0x7bc4d27a start_process+0x29(kernel_start=0x7b85a640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2606] in ntdll (0x0032ffe8) 15 0x6802996d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x687550fa context_destroy+0x2a [/home/julliard/wine/wine/dlls/wined3d/context.c:1615] in wined3d: cmpl %eax,0xf2c(%esi) 1615 if (context->tid == GetCurrentThreadId() || !context->current) -- Alexandre Julliard julliard(a)winehq.org

2 1

ntdll: Remove more path trailing chars.
by Joerg-Cyril.Hoehle＠t-systems.com April 8, 2011

April 8, 2011

Hi, Juan Lang wrote: >Vincent Pelletier wrote: >> Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any >> sense. >> I saw that it is discouraged (forbidden ?) to depend on OS version in tests, >> so I will avoid that path unless asked to follow it. >You'd want to use "ok(pass || broken(fail /* NT4 */)". No! Juan, while you generally give excellent advice, please think again about that one suggestion. It means tests never fail on native, which renders the test useless. What I've been doing several times is to write a detector and have the tests expect the specific NT/non-NT value. static BOOL TrueButNT = TRUE; Don't query OS version! Instead, the first test that sees the difference in behaviour does this: ok(rc == DO || broken(rc == DONT /* NT */), "bla\n"); TrueButNT = (rc==DONT) ? FALSE : TRUE; All later tests use ok(rc == TrueButNT, "bla2\n"); It even works with todo_wine. Any other means to detect NT *that is relevant for your test* is fine, i.e. don't query the DLL version or use some function outside of your test domain. Typical detectors are different GetLastError() values. I call this "coherence testing". Regards, Jörg Höhle

2 1

Re: wine.inf: Add shell handler for .url files.
by Jacek Caban April 8, 2011

April 8, 2011

Hi Hans, On 4/8/11 9:22 AM, Hans Leidekker wrote: > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index d4a457b..048b5bb 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -161,6 +161,7 @@ HKCR,.lnk,,2,"lnkfile" > HKCR,.msi,,2,"Msi.Package" > HKCR,.msp,,2,"Msi.Patch" > HKCR,.rtf,,2,"rtffile" > +HKCR,.url,,2,"InternetShortcut" > HKCR,.wri,,2,"wrifile" I'm not sure about other changes, but this should go to shdocvw. I have a patch in my queue for that. Jacek

1 0

Re: wine.inf: Add shell handler for .url files.
by Damjan Jovanovic April 8, 2011

April 8, 2011

On Fri, Apr 8, 2011 at 9:22 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=26673 > --- > tools/wine.inf.in | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index d4a457b..048b5bb 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -161,6 +161,7 @@ HKCR,.lnk,,2,"lnkfile" > HKCR,.msi,,2,"Msi.Package" > HKCR,.msp,,2,"Msi.Patch" > HKCR,.rtf,,2,"rtffile" > +HKCR,.url,,2,"InternetShortcut" > HKCR,.wri,,2,"wrifile" > HKCR,chm.file,,2,"Compiled HTML Help File" > HKCR,chm.file\shell\open\command,,2,"%10%\hh.exe %1" > @@ -215,21 +216,25 @@ HKCR,xmlfile\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,xmlfile\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,xmlfile\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,xmlfile\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,ftp,"URL Protocol",2,"" > HKCR,ftp\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,ftp\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,ftp\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,ftp\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,ftp\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,http,"URL Protocol",2,"" > HKCR,http\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,http\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,http\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,http\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,http\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,https,"URL Protocol",2,"" > HKCR,https\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,https\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,https\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,https\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,mailto,"URL Protocol",2,"" > HKCR,mailto\shell\open\command,,2,"%11%\winebrowser %1" > ; FIXME: the following should be done by the dll registration > HKCR,TypeLib\{00020430-0000-0000-C000-000000000046}\1.0\0\win16,,,"stdole.tlb" > -- Aren't most Internet-related file associations created by dlls/mshtml/mshtml.inf instead of tools/wine.inf.in, and should we maybe change that or move your patch there? Damjan

2 1

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.
by Dylan Smith April 7, 2011

April 7, 2011

On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc <mstefani(a)redhat.de>wrote: > The COM methods are already __stdcall. > --- > dlls/riched20/txthost.c | 128 > ++++++++++++++-------------------------------- > 1 files changed, 39 insertions(+), 89 deletions(-) > > COM methods are supposed to use the stdcall calling convention, but the native riched20 and the native headers just defines ITextHost and ITextServices to be a c++ class (i.e. using the thiscall calling convention). Just look at the native TextServ.h header.

4 6

Google Summer of Code project
by Michał Ziętek April 7, 2011

April 7, 2011

Hello, My name is Michal Zietek, I am studying Computer Science at Wroclaw University of Technology. I would like to take part at Google Summer of Code. Lately I saw Jacek Caban presenting Wine at the university and he said there could be a possibility to start in Google Summer of Code and work on Wine. I talked to Jacek about project related to WScript. I am interested in working on this project but I can't find it on the Google Summer of Code website. The only place I found any information is http://www.winehq.org/pipermail/wine-devel/2011-February/088839.html Do you consider putting this project into Google Summer of Code? Best regards, Michal Zietek.

4 3

Re: [2/4] wined3d: Track when the FBO is dirty.
by Henri Verbeet April 7, 2011

April 7, 2011

On 21 March 2011 21:57, Adam Martinson <amartinson(a)codeweavers.com> wrote: > @@ -2102,6 +2121,7 @@ BOOL context_apply_clear_state(struct wined3d_context *context, IWineD3DDeviceIm > if (rt_count < context->gl_info->limits.buffers) > memset(context->blit_targets + rt_count, 0, (context->gl_info->limits.buffers - rt_count) * sizeof(*rts)); > context_apply_fbo_state(context, GL_FRAMEBUFFER, rt_count, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; You can't do that. > @@ -4801,6 +4801,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Clear(IWineD3DDevice *iface, DWORD rect > } > > device_get_draw_rect(device, &draw_rect); > + IWineD3DDeviceImpl_MarkFBODirty(device); What is this for? > +static inline void IWineD3DDeviceImpl_MarkFBODirty(IWineD3DDeviceImpl *This) This doesn't need to be in wined3d_private.h, it's only used from device.c. > + int i; > + for (i = 0; i < This->numContexts; ++i) numContexts is unsigned. What would happen when the current draw fbo entry would get evicted from the cache? Also, while the patch avoids redundant lookups for draws, it doesn't do a lot for clears. Is that intentional because it's not worth it, or is there a different reason for that?

2 4

[PATCH 2/6] winmm: DriverCallback ignores a 0 CALLBACK_WINDOW.
by Joerg-Cyril.Hoehle＠t-systems.com April 7, 2011

April 7, 2011

Hi, any feedback on winmm:DriverCallback patches 2-6? - Although I superseded patch 1/6, the others are unchanged, hence I did not resend them. - I thought about merging patches 2+3+5 into one or two. After all, they all change the one tiny DriverCallback function. E.g. patch 2 fixes the corner case where Wine delivers a spurious message to the thread message queue, while patch 5 generalizes the behaviour that MS mentions (and I tested), i.e. ignore any 0 dwCallback. OTOH, split is split. - It may seem weird to go to some effort to make DriverCallback return the exact same values as native *and* then change all drivers to ignore that value, so the patches may be considered superfluous. Yet we strive to be bug-compatible. Regards, Jörg Höhle

2 1

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking
by Alexandre Julliard April 7, 2011

April 7, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -1617,9 +1617,18 @@ BOOL virtual_handle_stack_fault( void *addr ) > BYTE vprot = view->prot[((const char *)page - (const char *)view->base) >> page_shift]; > if (vprot & VPROT_GUARD) > { > + struct _TEB *teb = NtCurrentTeb(); > VIRTUAL_SetProt( view, page, page_size, vprot & ~VPROT_GUARD ); > - if ((char *)page + page_size == NtCurrentTeb()->Tib.StackLimit) > - NtCurrentTeb()->Tib.StackLimit = page; > + if ((char *)page - page_size == teb->DeallocationStack) > + teb->Tib.StackLimit = page; > + else if ((char*)addr > (char*)teb->Tib.StackLimit + page_size && > + teb->Tib.StackLimit == (char*)teb->DeallocationStack + page_size && > + (view = VIRTUAL_FindView( (char*)teb->Tib.StackLimit, 0))) > + { > + vprot = view->prot[((char*)teb->Tib.StackLimit - (char*)view->base) >> page_shift]; > + VIRTUAL_SetProt( view, teb->Tib.StackLimit, page_size, vprot | VPROT_GUARD); > + teb->Tib.StackLimit = (char*)teb->Tib.StackLimit + page_size; > + } Why do you want to lookup the view again? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: gsoc theming
by Reece Dunn April 7, 2011

April 7, 2011

On 4 April 2011 13:08, Andrew Green <greeniekin(a)gmail.com> wrote: > Hi, > I hate to message you on this email. I have messaged the mailing > lists. Though I became more confused than anything. Can you please keep the discussions on the mailing list? Thanks. > I would like to propose a project where comctl32 is implement > correctly in windows for google summer of code. > As far as i know windows uses SxS to load version 6 of comctl allowing > theming. This is correct -- an application needs to add a manifest file to tell it to load version 6 of the comctl32 DLL in order to get theming support on Windows. > It also uses windows class redirection to hijack controls > from user32 to be themed(I don't know if it somehow uses subclassing). This is how it is implemented in wine. > The confusing thing on the mailing list i was told not to make a > separate version of comctl32. Which is understandable from a code > maintenance point of view. Though contradicts what the gsoc ideas page > says > "control is overridden by a themed drawing version by subclassing. > This is not the way it is implemented on Windows and this causes > drawing issues and other nasty issues." > As someone who is to be a mentor of this section. What is the goal? > and if subclassing is the option, how is this meant to work? There isn't a contradition. AFAICS, the subclassing works -- the subclassed window procedure gets called correctly. The drawing issues can be seen clearly on the button controls -- if the button changes state (enabled <-> disabled, pressed, etc.) then it gets drawn without theming. This is because the button control in Wine does not call WM_PAINT to do the drawing, which the themed button overrides. Therefore, you will need to either: 1/ convince Alexandre through tests that these tests do call WM_PAINT [*] and update the non-themed control accordingly; or 2/ implement the state tracking/logic in the themed button and have it call WM_PAINT [*]. [*] or the correct custom drawing messages. HTH, - Reece

3 2