April 2011 - Wine-Devel - list.winehq.org

Re: Wanted: TestBot maintainer
by Деян Стоянов April 7, 2011

April 7, 2011

Hi Greg, I'm system administrator in application development unit of company "Information services" Plc. ( about us on http://www.is-bg.net/site_io/?cat=77 ). I am Vmware Certified Professional of VI3 and so far of VI4, and I have good experience with VMware Infrastructure. Also I have no problem with support various operation systems Windows 98, NT, 2000, XP, Vista, 7. Also I have experience with Linux Debian derivations, as well i manage with success other Linux distributions. I am interested to see how TestBot works, and maintain indefinitely. I spoke with my employer for time to maintain the TestBot, and I have a positive answer. I remain at your disposal, and I expect your response. Best regards Deyan Stoyanov

1 0

Wanted: TestBot maintainer
by Greg Geldorp April 7, 2011

April 7, 2011

Due to personal circumstances I won't be able to maintain the TestBot much longer. I'm looking for a volunteer to take over this responsibility. I can offer the hardware on which the bot runs for another 2 years or so. You'll get full access to the hardware. It helps if you have a bit of experience with VMware vSphere, but that's not absolutely required. Day-to-day operations have been running pretty smooth for the last couple of months, so the demand on your time won't be that great. There's the occasional account request that needs to be approved and that's pretty much it. Every now and then the VMs should be updated using Windows Update. The code itself seems to be reasonably stable. It's all Perl. If you're interested or would like more info, please let me know. Greg.

2 1

Re: configure.ac: add a --without-prelink option
by Vitaliy Margolen April 7, 2011

April 7, 2011

On 04/06/2011 07:53 PM, Austin English wrote: > Prelink is only available on Linux. It's not a reason to disable the warning. Without prelink, or other means to set load addresses of core dlls, compiled Wine won't be compatible with some programs. Mainly copy protection. Vitaliy.

2 1

Re: user32: Add a test for activating a menu consisting from a single menu item using a hot key.
by Marvin April 6, 2011

April 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10366 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Translation commits for wine-1.2.3
by Michael Stefaniuc April 5, 2011

April 5, 2011

Hello Alexandre, attached is the list of translation commits that can be cherry-picked for wine-1.2.3. Notes: - The cherry-picks for cryptui and wineconsole will need a manual conflict resolution as they depend on my janitorial commits. - The Arab and Hebrew translations are filtered out (support for mirroring is only in wine-1.3.x). bye michael

1 0

Re: [PATCH] cmd: Added set /a (try 3, fixed tests and patch formatting) Some tests were written by Jack Kutilek
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10353 Your paranoid android. === W7PROX64 (64 bit) === batch.c:70: Test failed: CreateFile failed

1 0

Re: ntdll: Remove more path trailing chars.
by Nikolay Sivov April 5, 2011

April 5, 2011

On 4/2/2011 10:51, Vincent Pelletier wrote: > Add tests via FindFirstFileA. > Fixes bug 22635. > --- > dlls/kernel32/tests/file.c | 119 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/path.c | 8 +++- > 2 files changed, 126 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c > index 4e8136a..dae8eee 100644 > --- a/dlls/kernel32/tests/file.c > +++ b/dlls/kernel32/tests/file.c > @@ -2164,6 +2164,125 @@ static void test_FindFirstFileA(void) > err = GetLastError(); > ok ( handle == INVALID_HANDLE_VALUE, "FindFirstFile on %s should Fail\n", buffer2 ); > ok ( err == ERROR_PATH_NOT_FOUND, "Bad Error number %d\n", err ); > + > + /* try FindFirstFileA on "test-dir" with forbidden chars */ > + CreateDirectoryA("test-dir", NULL); > + _lclose(_lcreat("test-file", 0)); > + > +#define FindFirstFileA_ok(value, caption, todo) { \ > + if(todo) { \ > + todo_wine ok(value, caption);\ > + } else { \ > + ok(value, caption);\ > + } \ > + } > + > +#define test_FindFirstFileA_with(x, y, todo) { \ > + handle = FindFirstFileA(x,&data);\ > + if (y) { \ > + FindFirstFileA_ok( \ > + handle != INVALID_HANDLE_VALUE, \ > + "FindFirstFile on "x" should succeed\n", \ > + todo);\ > + } else { \ > + FindFirstFileA_ok( \ > + handle == INVALID_HANDLE_VALUE, \ > + "FindFirstFile on "x" should fail\n", \ > + todo);\ > + } \ > + if (handle != INVALID_HANDLE_VALUE) \ > + ok( FindClose(handle) == TRUE, "Failed to close handle "x"\n"); \ > + } > + > + /* Disallowed chars being ignored: */ > + test_FindFirstFileA_with("test-dir/.", 1, 0); > + test_FindFirstFileA_with("test-dir\\.", 1, 0); > + test_FindFirstFileA_with("test-dir<.", 1, 0); > + test_FindFirstFileA_with("test-dir< ", 1, 0); > + test_FindFirstFileA_with("test-dir>.", 1, 0); > + test_FindFirstFileA_with("test-dir> ", 1, 0); > + test_FindFirstFileA_with("test-dir\".", 1, 0); > + test_FindFirstFileA_with("test-dir\" ", 1, 0); > + test_FindFirstFileA_with("test-dir/>", 1, 0); > + test_FindFirstFileA_with("test-dir/<", 1, 0); > + test_FindFirstFileA_with("test-dir/\"", 1, 0); > + test_FindFirstFileA_with("test-dir<>", 1, 0); > + test_FindFirstFileA_with("test-dir<<", 1, 0); > + test_FindFirstFileA_with("test-dir<\"", 1, 0); > + test_FindFirstFileA_with("test-dir>>", 1, 0); > + test_FindFirstFileA_with("test-dir><", 1, 0); > + test_FindFirstFileA_with("test-dir>\"", 1, 0); > + test_FindFirstFileA_with("test-dir\">", 1, 0); > + test_FindFirstFileA_with("test-dir\"<", 1, 0); > + test_FindFirstFileA_with("test-dir\"\"", 1, 0); > + test_FindFirstFileA_with("test-dir\\<", 1, 0); > + test_FindFirstFileA_with("test-dir\\>", 1, 0); > + test_FindFirstFileA_with("test-dir\\\"", 1, 0); > + /* But space prevents forward& back slashes from being stripped */ > + test_FindFirstFileA_with("test-dir<", 0, 1); > + test_FindFirstFileA_with("test-dir/ ", 0, 0); > + test_FindFirstFileA_with("test-dir/ .", 0, 0); > + test_FindFirstFileA_with("test-dir/. ", 0, 1); > + test_FindFirstFileA_with("test-dir\\ ", 0, 0); > + test_FindFirstFileA_with("test-dir\\ .", 0, 0); > + test_FindFirstFileA_with("test-dir\\. ", 0, 1); > + test_FindFirstFileA_with("test-dir/. ", 0, 1); > + test_FindFirstFileA_with("test-dir\\. ", 0, 1); > + /* But forward& back slashes are not tolerated on a file */ > + test_FindFirstFileA_with("test-file/>", 0, 1); > + test_FindFirstFileA_with("test-file/<", 0, 1); > + test_FindFirstFileA_with("test-file/\"", 0, 1); > + test_FindFirstFileA_with("test-file<>", 1, 0); > + test_FindFirstFileA_with("test-file<<", 1, 0); > + test_FindFirstFileA_with("test-file<\"", 1, 0); > + test_FindFirstFileA_with("test-file>>", 1, 0); > + test_FindFirstFileA_with("test-file><", 1, 0); > + test_FindFirstFileA_with("test-file>\"", 1, 0); > + test_FindFirstFileA_with("test-file\">", 1, 0); > + test_FindFirstFileA_with("test-file\"<", 1, 0); > + test_FindFirstFileA_with("test-file\"\"", 1, 0); > + test_FindFirstFileA_with("test-file\\<", 0, 1); > + test_FindFirstFileA_with("test-file\\>", 0, 1); > + test_FindFirstFileA_with("test-file\\\"", 0, 1); > + /* Even when many */ > + test_FindFirstFileA_with("test-dir\"\"\"\"\"", 1, 0); > + test_FindFirstFileA_with("test-dir<<<><><>\"\"\"\"<<<>", 1, 0); > + /* But only in the end of path */ > + test_FindFirstFileA_with("test-/>dir", 0, 0); > + test_FindFirstFileA_with("/>test-dir", 0, 0); > + test_FindFirstFileA_with(">test-dir", 0, 0); > + test_FindFirstFileA_with(">>test-dir", 0, 0); > + test_FindFirstFileA_with(">test->dir", 0, 0); > + test_FindFirstFileA_with("><test->dir", 0, 0); > + test_FindFirstFileA_with("<test->dir", 0, 0); > + test_FindFirstFileA_with("<\"test->dir", 0, 0); > + > + /* Slash after ignored chars is not ignored: */ > + test_FindFirstFileA_with("test-dir//", 0, 0); > + test_FindFirstFileA_with("test-dir</", 0, 0); > + test_FindFirstFileA_with("test-dir>/", 0, 0); > + test_FindFirstFileA_with("test-dir\"/", 0, 0); > + test_FindFirstFileA_with("test-dir\\", 0, 0); > + test_FindFirstFileA_with("test-dir\\\\", 0, 0); > + test_FindFirstFileA_with("test-dir\\/", 0, 0); > + test_FindFirstFileA_with("test-dir/\\", 0, 0); > + > + /* Disalowed chars being preserved: */ > + test_FindFirstFileA_with("test-dir/:", 0, 0); > + test_FindFirstFileA_with("test-dir/|", 0, 0); > + > + /* Slashes converted to backslashes */ > + test_FindFirstFileA_with("test-dir/", 0, 0); > + test_FindFirstFileA_with("./test-dir", 1, 0); > + test_FindFirstFileA_with("./test-dir/", 0, 0); > + test_FindFirstFileA_with("test-dir\\", 0, 0); > + test_FindFirstFileA_with(".\\test-dir", 1, 0); > + test_FindFirstFileA_with(".\\test-dir\\", 0, 0); > + > +#undef test_FindFirstFileA_with > +#undef FindFirstFileA_ok > + DeleteFileA("test-file"); > + RemoveDirectoryA("test-dir"); > } Please use table for test data and put your macro body in a loop.

3 3

Re: cmd: Added set /a (try 2)
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10349 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Sorry about the duplicate patches.
by Joel Teichroeb April 5, 2011

April 5, 2011

When trying to submit my first patch I did not do it correctly, and on http://source.winehq.org/patches/ it shows up 5 times. The correct patch is http://www.winehq.org/pipermail/wine-patches/2011-April/100677.html Thanks for your patience. Joel Teichroeb

1 0

Re: gdi32/tests: Start of a framework for writing dib driver tests.
by Huw Davies April 5, 2011

April 5, 2011

On Tue, Apr 05, 2011 at 03:31:23PM +0100, Huw Davies wrote: > > Try2. Using the A_SHA functions to generate the hashes. Although somewhat neater than the first version it doesn't work on nt4/win2k as they don't export these functions. So we're better off using the original. Huw.

1 0

Re: gdi32/tests: Start of a framework for writing dib driver tests.
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10338 Your paranoid android. === WNT4WSSP6 (32 bit dib) === Timeout === W2KPROSP4 (32 bit dib) === Timeout

1 0

Re: mshtml: Properly handle upload streams containing headers
by Alexandre Julliard April 5, 2011

April 5, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > + if(nschannel->post_data_contains_headers) { > + if(data[0] == '\r' && data[1] == '\n') { > + post_data = data+2; > + data_len -= 2; > + }else { > + WCHAR *headers; > + DWORD size; > + > + post_data = memmem(data, data_len, "\r\n\r\n", 4); memmem is not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] cmd: Added set /a
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10334 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x34 position 0 in line 118 (got '4', wanted '3') batch.c:223: Test failed: unexpected char 0x34 position 0 in line 120 (got '4', wanted '11') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 24 (got '0', wanted '2') batch.c:223: Test failed: unexpected char 0x31 position 0 in line 30 (got '12', wanted '2') batch.c:223: Test failed: unexpected char 0x2d position 0 in line 42 (got '-2147483648', wanted '0') batch.c:223: Test failed: unexpected char 0x33 position 0 in line 46 (got '3', wanted '1') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 124 (got '5', wanted '6') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 130 (got '5', wanted '2') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 140 (got '5', wanted '1') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 146 (got '5', wanted '10')

1 0

Re: msi: Fix parsing of an empty property followed by a non-empty property.
by Marvin April 5, 2011

April 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10333 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: Fixes a crypt32 str test. (try 2)
by Juan Lang April 4, 2011

April 4, 2011

Hi Christian, I'd like to see the actual test, preferably incorporated into the test suite. Thanks, --Juan

1 0

Re: [GSoC] Merge winecfg and Control Panel
by Dan Kegel April 4, 2011

April 4, 2011

Winetricks is a simple script that adds a few mssing things to wine, e.g. it's how most people install ms dlls or .net on wine. It also provides a simple commandline way to change a few settings. For instance, winetricks vd=1024x768 sets a 1024x768 virtual desktop... it'd be nice if one could instead do winecfg vd=1024x768 or something like that. See also http://winetricks.org. On Mar 23, 2011 10:36 AM, "Tony Zhang" <niu.tony.c.zhang(a)gmail.com> wrote: Dear Dan, I agree that it would be nice to have a command-line interface for wine settings cause I have run into situations that I have to configure wine before going into X. So is it possible to first group/rearrange winecfg functions into certain libraries and then let the GUI (control panel) and the CLI all interact with the corresponding libraries? About winetricks, I do not know much about it. What exactly do you mean by "winetricks settings"? -- Tony (Chi Zhang) On Wed, Mar 23, 2011 at 9:15 AM, Dan Kegel <dank(a)kegel.com> wrote: > > Also... it would be nice i...

4 4

Re: po: Update US English resource
by Alexandre Julliard April 4, 2011

April 4, 2011

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Just ise/ize changes > From 60f207abd03edf7ffac6f129a8bffd537596d54e Mon Sep 17 00:00:00 2001 > From: Ken Sharp <kennybobs(a)o2.co.uk> > Date: Fri, 1 Apr 2011 23:07:03 +0100 > Subject: po: Update US English resource These need to be changed in the original rc files. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] user32: DefDlgProc on WM_QUIT should repost it and terminate the dialog message loop.
by Marvin April 4, 2011

April 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10328 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/2] user32: Add a test for WM_QUIT handling by DefDlgProc.
by Marvin April 4, 2011

April 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10327 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH 2/2] comdlg32: Add support for customizing control labels in the item dialog.
by Nikolay Sivov April 4, 2011

April 4, 2011

On 4/4/2011 13:01, David Hedberg wrote: > static HRESULT WINAPI IFileDialog2_fnSetOkButtonLabel(IFileDialog2 *iface, LPCWSTR pszText) > { > FileDialogImpl *This = impl_from_IFileDialog2(iface); > - FIXME("stub - %p (%p)\n", This, pszText); > - return E_NOTIMPL; > + TRACE("%p (%p)\n", This, pszText); > + If you trace text parameter pointer value itself is not very interesting. Why not dumping a string?

1 0

Re: (без темы)
by Dmitry Timoshkov April 3, 2011

April 3, 2011

Roman Dadkov <romand(a)etersoft.ru> wrote: > 1) Magic field does not contain the correct information when creating a > storage file in Wine. > 2) Some fields are not filled with zeros when creating a storage file > in Wine. But these fields are filled with zeros when creating a storage > file in Windows. How is this different from the previous attempt? Did you address the comments? -- Dmitry.

1 0

Re: [PATCH] user32/tests: Fixed SetParent test on 64bit Vista
by Dmitry Timoshkov April 3, 2011

April 3, 2011

Austin Lund <austin.lund(a)gmail.com> wrote: > --- a/dlls/user32/tests/msg.c > +++ b/dlls/user32/tests/msg.c > @@ -12681,6 +12681,7 @@ static const struct message WmSetParentSeq_2[] = { > { WM_WINDOWPOSCHANGING, sent|wparam, SWP_HIDEWINDOW|SWP_NOSIZE|SWP_NOMOVE }, > { EVENT_OBJECT_HIDE, winevent_hook|wparam|lparam, 0, 0 }, > { WM_WINDOWPOSCHANGED, sent|wparam, SWP_HIDEWINDOW|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, > + { HCBT_SETFOCUS, hook|optional }, > { WM_NCACTIVATE, sent|wparam, 0 }, > { WM_ACTIVATE, sent|wparam, 0 }, > { WM_ACTIVATEAPP, sent|wparam, 0 }, This does look correct. It's pretty strange that other Windows versions don't send HCBT_SETFOCUS notification before WM_KILLFOCUS (which is right after WM_ACTIVATEAPP in the message sequence). -- Dmitry.

2 2

Summer of Code 2011 ideas
by Charles Davis April 3, 2011

April 3, 2011

Hi, I intend to participate in the Google Summer of Code (again), so I'd like to bounce some ideas off of you guys again. (I don't know why; I'll probably end up doing an extension of last year's project that I did for LLVM. But just in case...) I know that students are supposed to start submitting their proposals tomorrow, but better late than never, I guess. Anyway, here are my ideas (in no particular order): 1. Quartz Driver. I know you guys rejected this last year, but it looks like AJ's been doing some work refactoring the driver interface (at least, the GDI driver interface) lately. I also have some patches to isolate the rest of Wine from winex11. Since the driver itself is so huge, I'll probably end up only doing a piece of it (just enough to run some simple programs like Notepad or Minesweeper). This still depends on my (as yet, unfinished) Deobjectivizer tool so I don't have to code the driver in Objective-C (or resort to Carbon, which Apple seems intent on exorcising from Mac OS X). 2. D3D10 support. Here's an idea that isn't tied to Mac OS X. In Wine, D3D10 support is still in the embryonic stage (i.e. lots of stubs, anything interesting doesn't work quite right). It looks like Henri wants to wait until he finishes exorcising COM from WineD3D to finish implementing D3D10 (probably because COM was too much of a burden for what D3D10 needed from WineD3D, judging from which methods are stubs), so if you want to wait, that's fine. If I do take this on, my goal will probably be to get the game "Civilization V" working (at least, partially) in D3D10 mode, because that's the only D3D10 game I happen to own! (If it already works, and I don't know if it does because I haven't gotten around to installing and testing it, then I'll try to make it work better.) 3. Message-mode pipes. I think we can use the sendmsg(2) and recvmsg(2) syscalls to implement this on top of Unix-domain sockets. Then again, I suspect that this was one of the first things AJ thought of--and he hasn't been able to figure out how to do it yet! I have some experience writing Mac OS X kernel extensions (I wrote the SCSI kexts that Wine on Mac uses), and even a little experience writing Linux modules, so that might help with that. I would like to avoid a kernel module, if possible, though. (It's just one more thing that users have to install to make the system work...) What do you think? Chip

3 4

Re: gdiplus: Simplify logic/control flow in SOFTWARE_GdipFillRegion.
by Vincent Povirk April 3, 2011

April 3, 2011

I don't think this is an improvement. I think it's easier to use a single variable to indicate failure in the code, and to only use that variable when deciding whether to proceed further. This case only works because the GdipAlloc happens to be the only operation that can fail in that block before GdipGetRegionScansI. I worry that someone (probably me) could modify the code so that is no longer the case and fail to notice that the logic needs to be changed ( to check for stat == Ok && scans, rather than just scans). On Sat, Apr 2, 2011 at 3:36 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This doesn't make things tremendously simpler, but does avoid one > unnecessary if / condition. > > If you prefer, I can switch the two arms of the if to retain the > original !scans. > > Gerald > > --- > dlls/gdiplus/graphics.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 4fdfa9c..49f3495 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -3709,16 +3709,15 @@ static GpStatus SOFTWARE_GdipFillRegion(GpGraphics *graphics, GpBrush *brush, > if (stat == Ok && scans_count != 0) > { > scans = GdipAlloc(sizeof(*scans) * scans_count); > - if (!scans) > - stat = OutOfMemory; > - > - if (stat == Ok) > + if (scans) > { > stat = GdipGetRegionScansI(temp_region, scans, &dummy, identity); > > if (stat != Ok) > GdipFree(scans); > } > + else > + stat = OutOfMemory; > } > > GdipDeleteMatrix(identity); > -- > 1.7.4.1 > > >

1 0

Re: scarddlg: New dll stub
by Nikolay Sivov April 3, 2011

April 3, 2011

On 4/3/2011 17:51, Stefan Leichter wrote: > let the installer from bug #26026 finish > > --- > configure.ac | 1 + > dlls/scarddlg/Makefile.in | 6 ++++ > dlls/scarddlg/main.c | 61 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/scarddlg/scarddlg.spec | 5 +++ > 4 files changed, 73 insertions(+), 0 deletions(-) > create mode 100644 dlls/scarddlg/Makefile.in > create mode 100644 dlls/scarddlg/main.c > create mode 100644 dlls/scarddlg/scarddlg.spec > +/*********************************************************************** > + * FMExtensionProcW (acledit.@) > + * > + */ > + > +LONG WINAPI FMExtensionProcW(HWND hWnd, WORD wEvent, LONG lParam) > +{ > + FIXME("%p, %d, 0x%x) stub\n", hWnd, wEvent, lParam); > + return 0; > + > +} What's that for? It's not used.

1 0