April 2011 - Wine-Devel - list.winehq.org

Re: Fix to bug 25504 for gnutls based schannel
by Hans Leidekker April 18, 2011

April 18, 2011

On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote: > #ifdef SONAME_LIBGNUTLS > #include <gnutls/gnutls.h> > +#include <gcrypt.h> > +#include <pthread.h> > +#include <errno.h> > +GCRY_THREAD_OPTION_PTHREAD_IMPL; You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.

5 6

Re: [PATCH 02/10] msvcrt: Use callback based printf in cprintf functions family
by Alexandre Julliard April 18, 2011

April 18, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > +printf_arg arg_clbk_valist(void *ctx, int arg_pos, size_t size, __ms_va_list *valist) > +{ > + printf_arg ret; > + > + if(size == sizeof(LONGLONG)) > + ret.get_longlong = va_arg(*valist, LONGLONG); > + else if(size == sizeof(int)) > + ret.get_int = va_arg(*valist, int); > + else { > + ERR("Incorrect size\n"); > + ret.get_int = 0; > + } You can't do that, you need to use the correct type in va_arg. Different types can be passed differently even if they have the same size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] Fix d3dx9_parse_effect_typedef for stuctures.
by Rico Schüller April 18, 2011

April 18, 2011

The patch has the wrong description, I'll fix and resend that. Am 18.04.2011 10:26, schrieb Rico Schüller: > --- > dlls/d3dx9_36/effect.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > >

1 0

Re: Wine: Use the compiler option -Wpointer-arith if available.
by Michael Stefaniuc April 17, 2011

April 17, 2011

On 04/17/2011 01:19 AM, Gerald Pfeifer wrote: > GCC provides an option -Wpointer-arith and describes it as follows: > > Warn about anything that depends on the "size of" a function type > or of `void'. GNU C assigns these types a size of 1, for > convenience in calculations with `void *' pointers and pointers to > functions. > > This does not trigger on my Wine builds, but then we should not invoke Of course it doesn't triggers in Wine as -Wpointer-arith is already enabled. I made heavy use of that when I did my pointer cast killing spree a few years ago. > sizeof(void) or sizeof(some_function). ;-) It should help catch any > such bad future uses of sizeof. > > Gerald > --- > configure.ac | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6047744..0ae6625 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1715,6 +1715,7 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > + WINE_TRY_CFLAGS([-Wpointer-arith]) > WINE_TRY_CFLAGS([-Wstrict-prototypes]) > WINE_TRY_CFLAGS([-Wtype-limits]) > WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) bye michael

2 1

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs
by Gerold Jens Wucherpfennig April 17, 2011

April 17, 2011

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs. I think it's not allowed to do a "winedump <dllname>.lib" But what to do else? Regards Gerold

3 3

Re: crypt32: Fix length-handling of 'decodeBase64Block'
by Marvin April 16, 2011

April 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10497 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

RAS.h
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I want to complete the rasapi32.dll, but the header file RAS.h of wine is incomplete. It hasn't been changed since 1998. >From where may I copy the missing parts? >From the Windows SDK documentation? I think I may not be allowed to directly copy it from Windows' ras.h Best Regards Gerold

2 1

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

2 1

Windres and wine
by Gerold Jens Wucherpfennig April 16, 2011

April 16, 2011

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

2 1

Re: inetcpl: Update French translation
by Nicolas Le Cam April 15, 2011

April 15, 2011

Hi Frédéric, Le 13 avril 2011 23:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > --- > dlls/inetcpl.cpl/cpl_Fr.rc | 42 > +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 41 insertions(+), 1 deletions(-) > > diff --git a/dlls/inetcpl.cpl/cpl_Fr.rc b/dlls/inetcpl.cpl/cpl_Fr.rc > index 1244ff6..432a8c3 100644 > --- a/dlls/inetcpl.cpl/cpl_Fr.rc > +++ b/dlls/inetcpl.cpl/cpl_Fr.rc > @@ -2,7 +2,7 @@ > * Internet control panel applet > * French language support > * > - * Copyright 2010 Frédéric Delanoy > + * Copyright 2010-2011 Frédéric Delanoy > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -49,6 +49,46 @@ BEGIN > > END > > +/* "Delete browsing history" dialog */ > +IDD_DELETE_HISTORY DIALOG 0, 0, 250, 250 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +FONT 8, "MS Shell Dlg" > +CAPTION "Effacer l'historique de navigation" > +BEGIN > + > + AUTOCHECKBOX "Fichiers internet temporaires\nCopies en cache de > pages web, d'images et de certificats.", > + IDC_DELETE_TEMP_FILES, 10, 8, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Cookies\nFichiers sauvés sur votre ordinateur par des > sites web, qui y stockent des informations comme des préférences utilisateur > et des informations de connexion", > You should use sauvegardés instead of sauvés which doesn't apply to computers. I would also use "qui y stockent des choses comme les préférences utilisateurs et les informations de connexion". It better follows the original text and avoid a repetition. > + IDC_DELETE_COOKIES, 10, 32, 230, 35, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Historique\nListe des sites web accédés.", > + IDC_DELETE_HISTORY, 10, 73, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Données de formulaires\nNoms d'utilisateur et autres > informations entrées dans des formulaires.", > + IDC_DELETE_FORM_DATA, 10, 98, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Mots de passe\nMots de passe entrés dans des > formulaires et sauvegardés.", > + IDC_DELETE_PASSWORDS, 10, 128, 230, 30, BS_TOP | > BS_MULTILINE > + DEFPUSHBUTTON "Annuler", IDCANCEL, 185, 228, 60, 15, WS_GROUP > + PUSHBUTTON "Effacer", IDOK, 120, 228, 60, 15, WS_GROUP > + > +END > + > +/* "Security" propsheet */ > +IDD_SECURITY DIALOG 0, 0, 320, 220 > +STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > +FONT 8, "MS Shell Dlg" > +CAPTION "Security" > +BEGIN > + > + CONTROL "Listview", IDC_SEC_LISTVIEW, "SysListView32", > + LVS_ICON | LVS_ALIGNLEFT | LVS_AUTOARRANGE | LVS_SINGLESEL > | LVS_SHOWSELALWAYS | WS_BORDER | WS_VSCROLL, > + 4, 4, 312, 58 > + LTEXT "", IDC_SEC_ZONE_INFO, 4, 68, 312, 20 > + GROUPBOX "", IDC_SEC_GROUP, 4, 88, 312, 126 > + CONTROL "trackbar", IDC_SEC_TRACKBAR, "msctls_trackbar32", > + TBS_VERT | TBS_AUTOTICKS | TBS_BOTH | TBS_REVERSED, 8, 98, > 32, 100 > + LTEXT "", IDC_SEC_LEVEL, 48, 102, 180, 12 > + LTEXT "", IDC_SEC_LEVEL_INFO, 48, 114, 260, 80 > +END > + > /* "Content" propsheet */ > IDD_CONTENT DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > -- > 1.7.4.3 > > > > -- Nicolas Le Cam

3 2