June 2011 - Wine-Devel - list.winehq.org

Re: [2/2] explorer: add a navbar to explorer
by Juan Lang June 3, 2011

June 3, 2011

Hi Jay, +static const WCHAR ForwardButtonName[] = {'F','o','w','a','r','d','\0'}; Misspelled. --Juan

1 0

Re: [1/2] explorer: implement the explorer using IExplorerBrowser
by Juan Lang June 3, 2011

June 3, 2011

Hi Jay, +static void MakeExplorerWindow(IShellFolder* startFolder, HINSTANCE hInstance) I know the general rule of thumb when modifying an existing file is to keep its style, but we also tend to stay away from this style of function naming. It looks too much like the functions could be Win32 API names. Preferred style is the "one true style" of function naming, e.g. make_explorer_window instead. As it happens, explorer.c is the odd man out in programs/explorer, and since it only has 4 functions at the moment, it's probably better to change them than to add more functions with this style. Thanks, --Juan

1 0

Re: [PATCH 1/4] winealsa.drv: Partially implement IAudioSessionManager2
by Joris Huizer June 3, 2011

June 3, 2011

I'm sorry if I'm wrong, but it seems to me in this and following patches, the AudioSessionManager_Release() function is incomplete - I think the dealing with ref == 0 is missing. HTH, Joris

2 1

WineConf 2011 - Minneapolis, MN - October 1,2
by Jeremy White June 3, 2011

June 3, 2011

Hi Folks, We have made arrangements for this year's WineConf to happen in Minneapolis, MN on Saturday October 1 and Sunday October 2. Minneapolis is the little known other city of the Twin Cities across the river from our home town, St. Paul. I've put some preliminary information up on the Wiki: http://wiki.winehq.org/WineConf2011 We thought that this year it would be fun to stay in downtown Minneapolis, as there is quite a bit to do there. Further, at that time of year, the weather has a good chance of being beautiful, so it will hopefully be a great time for all. I checked, and only very rarely has it been below freezing on October 1 <evil grin>. (Seriously, it's usually very nice. Really. Trust me). If you are interested in WineConf, and have contributed to Wine, but are not sure if you can afford the travel costs, please write to me. The Wine Party fund is used mostly to defray travel costs these days and we may be able to help. Note that most further communication will happen on the wineconf(a)winehq.org mailing list; if you're interested, you should subscribe. If you're coming, please hit the RSVP page: http://www.winehq.org/wineconf/rsvp/ Hope to see you in Minneapolis! Cheers, Jeremy

1 0

Re : Re : ddraw: Add tests for Setcooperativelevel
by paulo lesgaz June 3, 2011

June 3, 2011

Any reason it was not commited yet? A+ David ________________________________ De : paulo lesgaz <jeremielapuree(a)yahoo.fr> À : Stefan Dösinger <stefandoesinger(a)gmx.at>; wine-devel(a)winehq.org Envoyé le : Mer 1 juin 2011, 20h 37min 36s Objet : Re : ddraw: Add tests for Setcooperativelevel ________________________________ De : Stefan Dösinger <stefandoesinger(a)gmx.at> À : wine-devel(a)winehq.org Cc : paulo lesgaz <jeremielapuree(a)yahoo.fr> Envoyé le : Mer 1 juin 2011, 15h 11min 25s Objet : Re: ddraw: Add tests for Setcooperativelevel On Wednesday 01 June 2011 08:01:57 paulo lesgaz wrote: >> Hi, >> >> any problem with the patch >> >> http://source.winehq.org/patches/data/74702 >I guess Alexandre was waiting for a reply from me or Henri. > >The tests themselves look ok, but I wonder what your ultimate goal is - is >there a game that has issues with DDSCL_CREATEDEVICEWINDOW? Yes, see bug 25660 My tests prove that DDSCL_CREATEDEVICEWINDOW+DDSCL_EXCLUSIVE+DDSCL_FULLSCREEN is allowed with a NULL window. That is what expected by Half life I demo. Currently, Wine returns DDERR_INVALIDPARAMS. Obviously, there are already tests that prove that DDSCL_EXCLUSIVE+DDSCL_FULLSCREEN fails with a null window. > Also the tests we >have are somewhat unsatisfying, we don't have a single test where >DDSCL_CREATEDEVICEWINDOW is supposed to succeed. Maybe it would be the subject of an another patch? A+ David

1 0

Re:o
by Nick Burns June 3, 2011

June 3, 2011

http://www.sisco.ch/indexz35X.php

1 0

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)
by Dmitry Timoshkov June 3, 2011

June 3, 2011

Adam Martinson <amartinson(a)codeweavers.com> wrote: > + osver.dwOSVersionInfoSize = sizeof(osver); > + GetVersionExW(&osver); > + ... > + if (osver.dwMajorVersion >= 5) Once again, that's wrong way of detecting win9x, or please try to explain better how the patch does what the subject describes, and for which app it's needed. -- Dmitry.

3 5

Re: [PATCH 3/3] msvcrt: Improved tolower_l and toupper_l implementation
by Marvin June 3, 2011

June 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11457 Your paranoid android. === WNT4WSSP6 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0 === W2KPROSP4 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0 === WXPPROSP3 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0 === W2K3R2SESP2 (32 bit string) === string.c:1987: Test failed: ret = fffffff4 string.c:1992: Test failed: ret = ffffffd0

1 0

Re: [4/4] ws2_32: Avoid a crash with an optional pointer in WSAAsyncGetServByName.
by Marvin June 3, 2011

June 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11362 Your paranoid android. === WXPPROSP3 (32 bit sock) === sock.c:501: Test failed: oob_server (218): unexpectedly at the OOB mark: 0 sock.c:511: Test failed: oob_server (218): unexpectedly at the OOB mark: 0

3 3

mmdevapi buffering
by Joerg-Cyril.Hoehle＠t-systems.com June 3, 2011

June 3, 2011

Hi, I have one big concern about MSDN's "Rendering a stream" (shared mode) example w.r.t wrap-around of buffer pointers and how Wine implements it. The example is at http://msdn.microsoft.com/en-us/library/dd316756(v=vs.85).aspx Suppose the write pointer is near the end of the buffer and the app is a little late, so the HW read pointer is not far away. |---------------------------------------------------^read------^write-----| What is GetCurrentPadding going to return? - the tiny write-read portion, says MSDN AFAICT - 0, because there's a new fresh buffer waiting to be filled? MSDN's example then computes avail = GetBufferSize() - GetCurrentPadding(); What is GetBuffer(avail) going to return?!? - If it's a pointer to the above buffer, it can only succeed if avail is tiny, otherwise there's a buffer overflow. However avail, as defined above and in MSDN's example, will be large. Wine tricks around that by returning a dynamic local tmp buffer larger than GetBufferSize (I wonder why a fixed one instead, twice GetBufferSize would not suffice?) Does native behave like that? - E_BUFFER_TOO_LARGE ? The MSDN example would exit. - Could it be a pointer to the beginning of the buffer? - Or it's a pointer to another buffer! That's not compatible with Wine's current local_buffer implementation... Isn't Wine's mmdevapi going to produces glitches? The problematic situation is when avail is small, as the following sleep for half a buffer size in MSDN's example will inevitably produce an xrun. So what actually is the buffer size and how does GetCurrentPadding behave? I don't expect MSDN's example to be fundamentally flawed. IMHO, they designed their API such that it is the typical use case. I believe that multiple buffers (of size GetBufferSize) are involved (much like ALSA's periods) and that GetBuffer switches among them -- exactly like they say about the exclusive mode ping pong. I suppose native's mixer (in shared mode) would mix these possibly incompletely filled buffers and everything is fine there. No need to deal with wrap-around! Why should Wine do something entirely different? Regards, Jörg Höhle

2 2

Re: [1/5] wined3d: Add support for GL_ARB_timer_query.
by Stefan Dösinger June 3, 2011

June 3, 2011

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'd recommend to wait for Henri to return from vacation before applying these Am 02.06.2011 um 19:25 schrieb Adam Martinson: > --- > dlls/wined3d/directx.c | 1 + > dlls/wined3d/wined3d_gl.h | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > > <0002-wined3d-Add-support-for-GL_ARB_timer_query.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJN6KyMAAoJEN0/YqbEcdMw+doP/jwoZxrZSkkgguKyN0MKlpNl BaYc2Yc3uGdNrOLCk78X/Zu1otVVlNZJHR5xIID3ZaK0egjhHRXF7Ljhj36paduN u25lslD4iN1IRHocDm0C0IqmmX5Q8YMrGSf1Xxn19KFaWV7tTHqs5KE4Dz707lct 0R/doxjYyZ4uBiE9FIglnPm2DZsyZoi5RPlYZA2XSD5uC57hD8hdqQPmLGXw+O42 WpjvNsN+hDwghJOEBCyG93rsttU7Zb9CBAQJS/CqYegG0L6cbRAZHebj/kHgWT7M 4TBNlo0rElgcD3/2CXNK1jjDSvAKS1soicnv7ZtlKbbmEHPE4EaQ82giIkqJB2Vv NddGTh9JvINLVq8FBJwRs9CwAMhVjUeGvrI13tnSUSu4QdcMZ9fxlg2SIeslWNrB x34siT+Eo8hOY6ZP6nTbdScSoxkHvOm4T8xeGKgC0l+sdAdAP18sHV1SgwoSLth/ fk68H6j6unL2S5yaQmIwaC+EKLRQkG+/wlsoFltR0iOplsxYKtm7KvYet6UAQNol Pq7Z1d7KLlg7GnsKgcFVVtXXNgEcKaEchuxUzRKkQy46MbQsghJhDW4mr+8vGwNS bFWf2qxHP0D8b/VnK43tsIAoXb5iA92yAlrC0e3ssy2yMdjS3SiFvwOBQsMtqBrD V0X2LrLXsqM1n00U6mPN =1nqX -----END PGP SIGNATURE-----

1 0

winealsa.drv:mmdevapi input validation
by Joerg-Cyril.Hoehle＠t-systems.com June 3, 2011

June 3, 2011

Hi, because of bug #27087, I had a look at the emerging mmdevapi code. Actually, it's the first time I read its documentation on MSDN. Here are a few comments of mine while reading the code. The handling of duration (-> buffer size) in winealsa.drv/mmdevdrv.c:AudioClient_Initialize does not perform enough validation. MSDN explicitly acknowledges that it could be 0. I believe it should be related to ALSA's buffer, or a minimum of something like 2*period_size. Or perhaps even 3*period size. IIRC MSDN also documents a maximum of 2s for renderer and 0.5 for capture. AudioRenderClient_ReleaseBuffer does not check that written_frames is what GetBuffer returned. Use with AUDCLNT_BUFFERFLAGS_SILENT and you'll have memcpy overwrite arbitrary amounts of memory. MSDN says: AUDCLNT_E_INVALID_SIZE I believe Wine should currently include if (AUDCLNT_STREAMFLAGS_EVENTCALLBACK && SHAREMODE_EXCLUSIVE) { FIXME("unsupported") & return E_ } because none of the buffer allocation and parameter checking specific to that mode that MSDN mentions in Initialize is implemented. When it (the ping pong buffer logic) will be implemented, some better logic to trigger SetEvent() will probably be needed, because I'm unsure whether CreateTimerQueueTimer() provides the required stability over time and possibly ignores a laptop's suspend/resume cycle or xruns. In exclusive mode, reception of an event is a guarantee that GetBuffer(GetBufferSize frames) will succeed. I suggest the values returned by AudioClient_GetDevicePeriod be adjusted to match what test.winehq shows. 10ms/3ms makes some sense, 10ms is mentioned a lot in MSDN and blogs. 3ms is small yet has a chance to work without glitch with MSDN's exclusive mode example. I can't remember seeing input validation of broken avgbytes and blockalign in the WAVEFORMAT parameter. I showed some tests some month ago that prove that unlike Wine, winmm is not disturbed by bad values. How does mmdevapi react to them? Regards, Jörg Höhle

2 2

Re: [13/18]usp10/tests: add Gurmukhi shaping test
by Marvin June 2, 2011

June 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11438 Your paranoid android. === WXPPROSP3 (32 bit usp10) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\usp10_test.exe, error 32

1 0

Re: [2/19](resend)usp10: improve Sinhala shaping using Indic rules
by Alexandre Julliard June 2, 2011

June 2, 2011

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -0,0 +1,236 @@ > + > +#include "config.h" > +#include <stdarg.h> > +#include <stdio.h> > +#include <stdlib.h> Please add a license header on new files. > +#define IS_VALID_INDEX (next < cChar) Don't reference local variables directly, pass them to the macro. > +#define OPTIONAL_CHAR(a) if (IS_VALID_INDEX && lex(input[next])==a) {next++;} > +#define OPTIONAL_CHAR_JOINER() if (IS_VALID_INDEX && IS_JOINER(next)) {next++;} > +#define ZERO_OR_MORE(a) while(IS_VALID_INDEX && lex(input[next])==a){next++;} > +#define ZERO_OR_MORE_MANTRA() while (IS_VALID_INDEX && IS_MANTRA(next)){next++;} Same here, and these should be wrapped in do/while(0). -- Alexandre Julliard julliard(a)winehq.org

1 0

ddraw: Add tests for Setcooperativelevel
by paulo lesgaz June 2, 2011

June 2, 2011

Hi, any problem with the patch http://source.winehq.org/patches/data/74702 A+ David

2 3

Re: [1/26](resend)usp10: Add Indic syllable parsing and reordering system
by Alexandre Julliard June 2, 2011

June 2, 2011

Aric Stewart <aric(a)codeweavers.com> writes: > +void Indic_ReorderCharacters( LPWSTR input, int cChar, lexical_function lex, reorder_function reorder_f) > +{ > + int index = 0; > + int next = 0; > + int center; > + > + if (!lex || ! reorder_f) > + { > + ERR("Failure to have required functions\n"); > + return; > + } > + > + debug_output_string(input, cChar, lex); > + while (next != -1) > + { > + ZERO_OR_MORE(lex_Generic); > + index = next; > + next = Indic_process_next_syllable(input, cChar, 0, &center, index, lex); > + if (next != -1) > + { > + reorder_f(input, index, center, next-1, lex); > + index = next; > + } > + else if (index < cChar) > + { > + int i; > + TRACE("Processing failed at %i\n",index); > + for (i = index; i < cChar; i++) > + if (lex(input[i])==lex_Generic) > + { > + TRACE("Restart processing at %i\n",i); > + next = i; > + index = i; > + break; > + } > + } > + } > + TRACE("Processed %i of %i characters\n",index,cChar); > +} Please don't add dead code. This function should be called from somewhere (same for the subsequent patches). -- Alexandre Julliard julliard(a)winehq.org

1 0

A request about the release notes
by Scott Ritchie June 1, 2011

June 1, 2011

When 1.3.19 came out it changed the build requirements for OSS support -- OSS 3 was no longer supported and OSS 4 dev libraries were required at build time. This was the changelog: New sound driver architecture for MMDevAPI. Better support for relative mouse events in DInput. Debugger support for the ARM platform. Various improvements in D3DX9. More MSVC runtime functions. Various bug fixes. At least two distros broke their OSS support as a result, since the standard "update wine version but use same packaging" didn't return a complete Wine anymore. In my case I only noticed when a bug report came in and I manually looked at the package build log. This sort of thing would be much less likely to happen if such a build dependency change were noted in the release notes, such as a "OSS 3 no longer supported" bullet point. Thanks, Scott Ritchie

1 0

Re: wined3d: Set container of swapchain surfaces to WINED3D_CONTAINER_NONE in swapchain_init() error path.
by Stefan Dösinger June 1, 2011

June 1, 2011

On Wednesday 01 June 2011 01:38:24 Piotr Pawłow wrote: > Since commit fadfdf21c055caf833a137ffc269c2073dc87fd6 surface refcounts are > forwarded to the container. We need to break this forwarding in > swapchain_init() error path, otherwise the swapchain refcount goes down to > zero and swapchain_cleanup() gets called on an invalid, partly initialized > swapchain. This patch looks OK

1 0

Re: Added unbound sampler test for pixel shaders.
by Alexandre Julliard June 1, 2011

June 1, 2011

Sean Sube <ssube(a)codeweavers.com> writes: > --- > dlls/d3d9/tests/visual.c | 80 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 80 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:8909: Tests skipped: D3DFMT_G16R16 textures not supported as render targets. visual.c:7503: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:12112: Test failed: Color is 0xffffffff. make[1]: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: d3d9: Increment the reference count of the IDirect3D9 instance when creating a device.
by Andrew Nguyen June 1, 2011

June 1, 2011

The Pathologic demo in bug 21552 expects that the reference count of a IDirect3D9 instance is incremented after a successful call to CreateDevice with the instance. Does my proposed fix for d3d8 and d3d9 manage the reference count of the device parent appropriately? In particular, I'm concerned about the slightly cumbersome acquisition of the pointer to the parent instance within the Release call for the Direct3D device interface. Is the overall location of the AddRef/Release calls correct, and should I be doing something differently when the device tries to decrement the parent reference count?

2 1

Re: infosoft/tests: COM cleanup in infosoft.c.
by Marvin June 1, 2011

June 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11350 Your paranoid android. === WVISTAADM (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W2K8SE (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W7PRO (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W7PROX64 (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W7PROX64 (64 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed

2 1

Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.
by Stefan Dösinger June 1, 2011

June 1, 2011

Does the enum_device_entry structure have to be in ddraw_private.h? I think you can just declare it in ddraw.c because it is used only there. At some point we'll want to get rid of the ddraw device type strings and call wined3d_get_adapter_identifier - but that needs more work and some more tests. Am 31.05.2011 um 12:50 schrieb Andrew Nguyen: > --- > dlls/ddraw/ddraw.c | 43 +++++++++++++------ > dlls/ddraw/ddraw_private.h | 8 ++++ > dlls/ddraw/tests/d3d.c | 98 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 136 insertions(+), 13 deletions(-) > > > <0004-ddraw-Extend-the-lifetime-of-the-EnumDevices-strings-b.txt>

2 2