June 2011 - Wine-Devel - list.winehq.org

Ge (Greg) van Geldorp
by Paul Vriens June 29, 2011

June 29, 2011

Hi, The sad news reached me two days ago that Ge (Greg) van Geldorp passed away. Please find below the mail from his brother. I've briefly talked to Jeremy and Alexandre about this loss and the idea came up to have something on the winehq frontpage for a while. Jeremey also mentioned to mark Greg's life and contributions to Wine at Wineconf this year. Alexandre mentioned potentially hosting the winetestbot at codeweavers in the future. Both the frontpage remembrance and the potential hosting somewhere else has been discussed by me and Arno and will not be an issue. Cheers, Paul. -------- Original Message -------- Subject: RE: Ge van Geldorp Date: Thu, 9 Jun 2011 23:05:46 +0200 From: Erven Gé van Geldorp <erven.van.geldorp(a)gmail.com> To: 'Paul Vriens' <paul.vriens.wine(a)gmail.com> Hi all, My name is Arno van Geldorp. I'm the brother of Gé (Greg) van Geldorp. I'm very sorry that I have to inform you that Greg has passed away almost 3 weeks ago. 2 Months earlier he was diagnosed with cancer in a very aggressive form. I know he made his contribution to the Wine project. And that one of them is the WineTestBot. His passing away went so fast that he didn't have the time to inform me all about it. What he did ask me is to make sure that the server where the WineTestBot is running on will be hosted for at least 2 more years. So we will take care of that. But I don't know if anyone took over the administration off the server. If anyone took over the administration from Greg could you please contact me at erven.van.geldorp at gmail.com Kind regards, Arno van Geldorp

9 10

Re: [1/2] include: Add declarations related to D3DXFLOAT16.
by Dylan Smith June 29, 2011

June 29, 2011

On Wed, Jun 29, 2011 at 11:16 AM, Misha Koshelev <misha680(a)gmail.com> wrote: > Submitted by original author as requested by Alexandre. Necessary for > further patches by Dylan Smith to fix bug 25769. > Attached are the further patches he is referring to, which are based on his patch series.

1 0

Re: [1/2] oleaut32: COM Cleanup ICreateTypeLib2Imp (resend)
by Michael Stefaniuc June 29, 2011

June 29, 2011

Hello Alistair, sorry that I missed the first time. And Alexandre should have marked it as PENDING (good idea but current implementation is rejected). Alistair Leslie-Hughes wrote: > Changelog: > oleaut32: COM Cleanup ICreateTypeLib2Imp > > > Best Regards > Alistair Leslie-Hughes > >From 4e5e70b84cc4a254e5e3bdfeb788282a20a3dd50 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Mon, 27 Jun 2011 22:24:09 +1000 > Subject: [PATCH] COM Cleanup ICreateTypeLib2Imp > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/oleaut32/typelib2.c | 75 ++++++++++++++++++++++++--------------------- > 1 files changed, 40 insertions(+), 35 deletions(-) > > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index e9c7613..5740ddd 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -1476,7 +1481,7 @@ static HRESULT ctl2_find_typeinfo_from_offset( > > for (typeinfo = This->typeinfos; typeinfo; typeinfo = typeinfo->next_typeinfo) { > if (typeinfo->typeinfo == typeinfodata) { > - *ppTinfo = (ITypeInfo *)&typeinfo->lpVtblTypeInfo2; > + *ppTinfo = (ITypeInfo *)&typeinfo->ITypeInfo2_iface.lpVtbl; Please don't cast a vtable to an iface, cast the iface instead: + *ppTinfo = (ITypeInfo *)&typeinfo->ITypeInfo2_iface > ITypeInfo2_AddRef(*ppTinfo); > return S_OK; > } > @@ -1573,7 +1578,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnQueryInterface( > *ppvObject = This; > } else if (IsEqualIID(riid, &IID_ITypeInfo) || > IsEqualIID(riid, &IID_ITypeInfo2)) { > - *ppvObject = &This->lpVtblTypeInfo2; > + *ppvObject = &This->ITypeInfo2_iface.lpVtbl; No need to go here down to the vtable: + *ppvObject = &This->ITypeInfo2_iface It's the exact same thing but shorter. > } > > if(*ppvObject) > @@ -1697,7 +1702,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeFlags(ICreateTypeInfo2 *iface, U > iter->next_typeinfo = This->dual; > } > } else > - iface = (ICreateTypeInfo2*)&This->dual->lpVtbl; > + iface = (ICreateTypeInfo2*)&This->dual->ICreateTypeInfo2_iface.lpVtbl; There's no need for a cast here as you already have the right thing: + iface = &This->dual->ICreateTypeInfo2_iface; > } > > if (uTypeFlags & (TYPEFLAG_FDISPATCHABLE|TYPEFLAG_FDUAL)) { You missed a few changes: @@ -3153,7 +3158,7 @@ { ICreateTypeInfo2Impl *This = impl_from_ITypeInfo2(iface); - return ICreateTypeInfo2_QueryInterface((ICreateTypeInfo2 *)This, riid, ppv); + return ICreateTypeInfo2_QueryInterface(&This->ICreateTypeInfo2_iface, riid, ppv); } There are more of those "(ICreateTypeInfo2 *)This" ==> "&This->ICreateTypeInfo2_iface" changes. Check for all (ICreateTypeInfo2 *), there should be none left. > @@ -3388,7 +3393,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeOfImplType( > } > > if(This->typekind == TKIND_DISPATCH) > - return ITypeInfo2_GetRefTypeOfImplType((ITypeInfo2*)&This->dual->lpVtblTypeInfo2, > + return ITypeInfo2_GetRefTypeOfImplType((ITypeInfo2*)&This->dual->ITypeInfo2_iface.lpVtbl, No need for the cast: + return ITypeInfo2_GetRefTypeOfImplType(&This->dual->ITypeInfo2_iface, > index, pRefType); > } > > @@ -3599,7 +3604,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeInfo( > return E_INVALIDARG; > > if(hRefType==-2 && This->dual) { > - *ppTInfo = (ITypeInfo*)&This->dual->lpVtblTypeInfo2; > + *ppTInfo = (ITypeInfo*)&This->dual->ITypeInfo2_iface.lpVtbl; Just cast the iface: + *ppTInfo = (ITypeInfo*)&This->dual->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } > @@ -3635,7 +3640,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeInfo( > > for(iter=This->typelib->typeinfos; iter; iter=iter->next_typeinfo) { > if(This->typelib->typelib_typeinfo_offsets[i] == (hRefType&(~0x3))) { > - *ppTInfo = (ITypeInfo*)&iter->lpVtblTypeInfo2; > + *ppTInfo = (ITypeInfo*)&iter->ITypeInfo2_iface.lpVtbl; Same here: + *ppTInfo = (ITypeInfo*)&iter->ITypeInfo2_iface; > > ITypeLib_AddRef(*ppTInfo); > return S_OK; > @@ -4948,7 +4953,7 @@ static HRESULT WINAPI ITypeLib2_fnGetDocumentation( > if(!iter) > return TYPE_E_ELEMENTNOTFOUND; > > - return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->lpVtblTypeInfo2, > + return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->ITypeInfo2_iface.lpVtbl, And here: + return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->ITypeInfo2_iface, > -1, pBstrName, pBstrDocString, pdwHelpContext, pBstrHelpFile); > } > thanks bye michael

1 0

Re: [PATCH] comctl32: Fixed strncpy (Coverity)
by Michael Stefaniuc June 28, 2011

June 28, 2011

Hello Marcus, On 06/28/2011 09:15 AM, Marcus Meissner wrote: > This is a 2 CHAR buffer, and we copy in 1 CHAR and \0. So just do that > via strcpy() and dont confuse the static checker. > > CID 1194 > > Ciao, Marcus > --- > dlls/comctl32/tests/treeview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c > index 324473d..faa9553 100644 > --- a/dlls/comctl32/tests/treeview.c > +++ b/dlls/comctl32/tests/treeview.c > @@ -1225,7 +1225,7 @@ static void test_itemedit(void) > r = TreeView_SelectItem(hTree, NULL); > expect(TRUE, r); > /* alter text */ > - strncpy(buff, "x", sizeof(buff)/sizeof(CHAR)); > + strcpy(buff, "x"); > r = SendMessage(edit, WM_SETTEXT, 0, (LPARAM)buff); What about r = SendMessage(edit, WM_SETTEXT, 0, (LPARAM)"x"); No strcpy involved. > expect(TRUE, r); > r = SendMessage(hTree, WM_COMMAND, MAKEWPARAM(0, EN_KILLFOCUS), (LPARAM)edit); bye michael

3 2

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)
by Alexandre Julliard June 28, 2011

June 28, 2011

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, dwFlags); > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = IDirectInputDevice8WImpl_SetActionMap(&This->IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + _copy_diactionformatWtoA(lpdiaf, &diafW); Do you really need to copy it back? It looks like an input parameter. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3dx9/tests: Fix comparison that expects NAN, since NAN != NAN.
by Alexandre Julliard June 28, 2011

June 28, 2011

Dylan Smith <dylan.ah.smith(a)gmail.com> writes: > @@ -4834,7 +4834,7 @@ static void test_create_skin_info(void) > for (i = 0; i < num_influences; i++) { > ok(exp_vertices[i] == vertices[i], > "influence[%d]: expected vertex %u, got %u\n", i, exp_vertices[i], vertices[i]); > - ok(exp_weights[i] == weights[i], > + ok((isnan(exp_weights[i]) && isnan(weights[i])) || exp_weights[i] == weights[i], I put this in for now to fix the tests, but isnan() isn't really portable, we should try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [2/2] gdiplus: Implement GdipMeasureDriverString.
by Alexandre Julliard June 27, 2011

June 27, 2011

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > From 520906b62d02cb9c886404caa03d1fcb634f574b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Mon, 27 Jun 2011 13:24:39 -0500 > Subject: [PATCH 2/3] gdiplus: Implement GdipMeasureDriverString. It doesn't work here: ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so graphics.c && touch graphics.ok graphics.c:3110: Test failed: Expected 7.00, got 8.00 make: *** [graphics.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32: return an error in SO_CONNECT_TIME stub
by Dmitry Timoshkov June 27, 2011

June 27, 2011

Austin English <austinenglish(a)gmail.com> wrote: > @@ -2554,7 +2554,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > } > *(DWORD*)optval = pretendtime++; > *optlen = sizeof(DWORD); > - return ret; > + return SOCKET_ERROR; > } Filling out optval and optlen but returning SOCKET_ERROR doesn't make sense. Probably Eye-Fi doesn't change the return value. What kind of socket both of the applications do pass? -- Dmitry.

2 1

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Michael Stefaniuc June 27, 2011

June 27, 2011

Hello Alistair, Alistair Leslie-Hughes wrote: > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > > dlls/oleaut32/typelib2.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index e9c7613..459547f 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -3067,8 +3067,13 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetHelpStringContext( > ICreateTypeInfo2* iface, /* [I] The typeinfo on which to set the help string context. */ > ULONG dwHelpStringContext) /* [I] The help string context. */ > { > - FIXME("(%p,%d), stub!\n", iface, dwHelpStringContext); > - return E_OUTOFMEMORY; > + ICreateTypeInfo2Impl *This = (ICreateTypeInfo2Impl *)iface; please do not add any more of those cast but add a impl_from_ICreateTypeInfo2() helper as per the COM guidline at http://wiki.winehq.org/COMGuideline. Bonus points for doing the COM cleanup too ;) thanks bye michael

1 0

Re: [docs] winedev: A hint for patch separation
by Jerome Leclanche June 27, 2011

June 27, 2011

That sounds like we want people to avoid testing wine. How about "Patches must not break building Wine nor its testsuite. Adding dead code should also be avoided."? </bikeshed> J. Leclanche 2011/6/26 André Hentschel <nerv(a)dawncrow.de>: > --- > en/winedev-coding.sgml | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/en/winedev-coding.sgml b/en/winedev-coding.sgml > index eacf6d8..8b0f0d9 100644 > --- a/en/winedev-coding.sgml > +++ b/en/winedev-coding.sgml > @@ -207,6 +207,10 @@ code > is your friend! > </para> > <para> > + Every patch must not break building and testing Wine and > + adding dead code should be avoided. > + </para> > + <para> > Save yourself some embarrassment and run your patched code > against more than just your current test example. Experience > will tell you how much effort to apply here. If there are > -- > > Best Regards, André Hentschel > > >

2 1

Re: [PATCH 9/9] server+user32: Added GetRawInputData implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11988 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 8/9] server+user32: Added GetRawInputBuffer implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11987 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 7/9] server+user32: Added RegisterRawInputDevices implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11986 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 6/9] server+user32: Added GetRegisteredRawInputDevices implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11985 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Vincas Miliūnas June 26, 2011

June 26, 2011

On 06/22/2011 06:41 PM, André Hentschel wrote: > ... Done - http://source.winehq.org/patches/data/75767

1 0

Re: [PATCH 5/9] server+user32: Added GetRawInputDeviceInfoA implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11984 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 4/9] server+user32: Added GetRawInputDeviceInfoW implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11983 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 3/9] server+user32: Added GetRawInputDeviceList implementation (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11982 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/9] user32/tests: Added client-side raw input function tests (try 8)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11981 Your paranoid android. === W7PROX64 (32 bit input) === No test summary line found === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by André Hentschel June 26, 2011

June 26, 2011

Am 22.06.2011 06:26, schrieb Vincas Miliūnas: > + if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && > + pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices) You should avoid such a construct, move the check to test_functions that actually need these functions. e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer i didn't looked very close, but if the tests depend on each other there should be a comment. the rest of that patch looks fine to me -- Best Regards, André Hentschel

2 1

[mshtml] Crash in World of Warcrash launcher
by Vincent Pelletier June 26, 2011

June 26, 2011

Hi. Runing the latest WoW Launcher, I get the following traceback: Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7d399990 ESP:0032e404 EBP:0032e474 EFLAGS:00010213( R- -- I -A- -C) EAX:00000001 EBX:7d3f22bc ECX:ffffffff EDX:00000000 ESI:00000000 EDI:0281f518 Stack dump: 0x0032e404: 0032e474 00000000 038f3338 0032e430 0x0032e414: 6a00410b 038f3338 00000000 0032e450 0x0032e424: 038f3368 038f3338 00000000 0032e470 0x0032e434: 0281f518 cbc0cbd8 0281f518 0032e480 0x0032e444: 6a617b40 0281f518 6ab94f64 0032e490 0x0032e454: 038f3338 0000000f 0000000e 7ef7bee5 Backtrace: =>0 0x7d399990 doc_insert_script+0x30(window=0x2738378, nsscript=(nil)) [/home/vincent/git/wine/dlls/mshtml/script.c:757] in mshtml (0x0032e474) 1 0x7d36ec96 run_insert_script+0xb5(doc=0x7d36e63e, script_iface=0x3849830, parser_iface=0x38f3368) [/home/vincent/git/wine/dlls/mshtml/mutation.c:338] in mshtml (0x03849830) 2 0x0032e550 (0x0384a9e8) 3 0x00000002 (0x7d3f0a28) 4 0x7d36e7d0 in mshtml (+0x6e7cf) (0x7d36fbc0) 5 0x00000010 (0xb94cec83) 0x7d399990 doc_insert_script+0x30 [/home/vincent/git/wine/dlls/mshtml/script.c:757] in mshtml: movl 0x0(%esi), %eax 757 nsres = nsIDOMHTMLScriptElement_GetType(nsscript, &val_str); Bisecting find this commit: dc96c688d397eb4ef1392ee6a98f3eb6b176dc56 is the first bad commit commit dc96c688d397eb4ef1392ee6a98f3eb6b176dc56 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 15 13:45:46 2011 +0100 mshtml: Notify parser about script evaluation. :040000 040000 56e26373e5d368d9c991936e12bbf6572b51a1c8 b047f9b40a63e482b477254952737e9e9cd4aded M dlls I don't know if it's a regression in wine by itself, or if WoW Launcher just happens to trigger the failure now (I haven't ran it in some months). -- Vincent Pelletier

2 1

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Vincas Miliūnas June 26, 2011

June 26, 2011

On 06/22/2011 06:26 PM, André Hentschel wrote: > Am 22/06/2011 06:26, schrieb Vincas Miliūnas: >> + if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && >> + pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices) > > You should avoid such a construct, move the check to test_functions that actually need these functions. > e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer > i didn't looked very close, but if the tests depend on each other there should be a comment. > the rest of that patch looks fine to me Done - http://source.winehq.org/patches/data/75756

2 1

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11980 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] jscript/tests: Fix copy & paste typos
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 7)
by Marvin June 26, 2011

June 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11978 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0