June 2011 - Wine-Devel - list.winehq.org

Behavior of SHChangeNotify
by Jay Yang June 25, 2011

June 25, 2011

To try to implement copy-paste for shell folders, I used SHFileOperation for the actual copy. SHFileOperation calls SHChangeNotify to notify listeners about changes to the file system. But I noticed that the shell view would not update correctly if it was at 'C:\' but it would if it was at '/home/user_name/.wine/drive_c/'. In the end I traced this to the fact that in the first case the shell view calls SHChangeNotifyRegister with a pidl of the form <Desktop|My Computer|C:> while SHFileOperation is using SHChangeNotify to send a notification to those listeners registered on pidls of the form <Desktop|/|home|user_name|.wine|drive_c>. This makes it such that the shell view doesn't always get the notifications it expects. I can think of a couple of ways to fix this. 1. Have SHChangeNotifyRegister normalize all file system pidls to ones rooted in the unixfs. 2. Have the shell view register on a unixfs pidl. I would like to know if either of these is a good solution, or if there are better solutions. I can also write a quick test to demonstrate the problem if necessary. -- Jay Yang

2 2

usability study: "30 days with Ubuntu" author had trouble with wine
by Dan Kegel June 25, 2011

June 25, 2011

http://www.pcworld.com/businesscenter/article/231065/ubuntu_linux_day_23_wo… First problem - ubuntu's package manager is unclear: "I opened up my handy-dandy Ubuntu Software Center and typed Wine in the search field, and...WTF? There are 14 matching items that show up. Many of them are variations on 'Microsoft Windows Compatibility Layer'. One has '(meta package)' at the end, another has '(dummy package)'. They each have a little sub-title like 'wine', or 'wine-gecko', or 'wine1.3-gecko'. Why isn't there just a single app clearly called 'Wine'? I didn't really have any clue which of these various software packages is the real Wine, but the one at the top--the 'meta package'--had the most ratings and ranked highly at 4.5 stars, so I decided to give that one a shot." Second problem - he expected to run a program called Wine, found wineconfig, did something with it, and then got back on track: "Once it completed installing, I went to the Applications lens on the Unity bar and typed in Wine. It claims I have three apps installed that fit that description: Configure Wine, Uninstall Wine Software, and Winetricks. I was hoping to actually run Wine, but given these three options it seems that Configure Wine is the logical first choice. I clicked Configure Wine and the Wine Configuration console popped up (go figure). At the bottom of the Applications tab, it specific which version of Windows to emulate...I mean be compatible with. It defaults to Windows XP, but I changed it to Windows 7... OK. Now, I am ready to run some Windows software, right?" Third problem: he expected Office 2010 to install and run Fourth problem: he couldn't even run the installer: " I opened up the folder from my Windows drive where I store downloaded software, right-clicked my Microsoft Office 2010 installation executable and clicked 'Open With Wine Windows Program Loader', and...got an error message. Something to the effect that this software is not marked as executable. Windows logoRunning Windows software in Wine proved convoluted and elusive.I checked with Google, and found a helpful walk-through from Psychocats.net called Using Wine on Ubuntu. Apparently, the fact that the software is an EXE is not obvious enough, so I have to first right-click the file, go into the Properties, and click a checkbox designating the file as executable. Seems convoluted. The problem is, every time I click the checkbox my check disappears. It won't let me make my file executable. I tried looking for more help on Google to no avail. I tried a couple other executable installation files, but couldn't mark those as executable either. I assume it is a permissions thing--like I need to somehow access the file permissions with root privileges in order to be able to make those changes. That is just a theory, though. So, no Windows software running for me just yet." Ouch, ouch, ouch.

4 4

Re: urlmon: Use CoInternetParseIUri instead of IUri::GetPath in file protocol handler implementation
by Marvin June 25, 2011

June 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11968 Your paranoid android. === WVISTAADM (32 bit protocol) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

shouldn't the 1.3 dependencies include binfmt-support and lib32nss
by Susan Cragin June 24, 2011

June 24, 2011

Just wondering. apt-get build-dep wine1.3 does not load binfmt-support and lib32nss... Installation of natspeak requires them. The installation script tries to grab them but failed for me.

2 1

Ars Technica article
by Brian Vincent June 24, 2011

June 24, 2011

Here's some light reading for your weekend enjoyment. I found this on Ars Technica and thought it was a pretty good summary of some stuff from Microsoft's past and a pretty good guess at how some future technology pieces fit together. http://arstechnica.com/microsoft/news/2011/06/windows-8-for-software-develo… -Brian

1 0

How to do single-step debugging while testing?
by Michael Mc Donnell June 24, 2011

June 24, 2011

Hi I'm trying to figure out how to single step through the code. I've looked at the winedbg and gdb information on winehq, but still can't figure out what to do. I normally run tests by issuing: $ ../../../tools/runtest name_of_test Is there a way to run the test in a debugger, so that I can single step through the functions that the test calls? Thanks, Michael Mc Donnell

3 7

re: [1/3] cmd/tests: Use plain strings instead of char arrays for keywords
by Dan Kegel June 24, 2011

June 24, 2011

Frédéric Delanoy wrote: - static const char escaped_space[] = {'@','s','p','a','c','e','@','\0'}; + static const char *escaped_space = "@space@"; I'm not sure it's worth the effort, since eventually we want cmd to use unicode internally, at which point we'll have to go back to using arrays.

2 2

Re: Dylan Smith : d3dx9/tests: Added tests for D3DXCreateSkinInfo.
by Michael Stefaniuc June 24, 2011

June 24, 2011

Hello Dylan, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 01ff07e2e1d2e77575ddbd88a705ef12ea6f9073 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=01ff07e2e1d2e77575ddbd88a… > > Author: Dylan Smith <dylan.ah.smith(a)gmail.com> > Date: Wed Jun 22 14:24:41 2011 -0400 > > d3dx9/tests: Added tests for D3DXCreateSkinInfo. > > --- > > dlls/d3dx9_36/tests/mesh.c | 229 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 229 insertions(+), 0 deletions(-) > > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=01ff07e2e1d2e77575ddb… this commit breaks compilation on my old RHEL5 box: dlls/d3dx9_36/tests/mesh.c:4813: error: ‘FP_NAN’ undeclared (first use in this function) bye michael

4 7

re: Dylan Smith : d3dx9/tests: Added tests for D3DXCreateSkinInfo.
by Dan Kegel June 24, 2011

June 24, 2011

Dylan wrote: - exp_weights[1] = FP_NAN; + exp_weights[1] = 0.0f / 0.0f; It's a bit strange to see 0 being replaced with infinity. What is your intent in that line? FP_NAN probably isn't what you think it is. On Fri, Jun 24, 2011 at 9:44 AM, Stefan Dösinger <stefandoesinger at gmx.at> wrote: > I'd appreciate a portable solution for generating NaN and Inf values as well, > I have the same problem with wined3d in visual studio. libxml2 has a nifty function trio_nan() which wraps all the portable ways of doing it. See e.g. http://www.opensource.apple.com/source/libxml2/libxml2-4/libxml2/trionan.c - Dan

1 0

Re: [PATCH 04/13] winmm: Clean up waveform.c's style
by Paul Vriens June 24, 2011

June 24, 2011

On 06/23/2011 08:12 PM, Andrew Eikum wrote: > + if(dwFlags& WAVE_FORMAT_QUERY) > + TRACE("WAVE_FORMAT_QUERY requested!\n"); How is removing the spaces for all these if/else statements an improvement? It's also not consistent with the rest of the winmm code. -- Cheers, Paul.

1 0

Disablin xinput2 for now?
by Marcus Meissner June 23, 2011

June 23, 2011

Hi, There seem to be regressions in xinput2 support, http://bugs.winehq.org/show_bug.cgi?id=27028 As this might be a X.org issue, should we packagers turn off xinput2 support for the time being? Ciao, Marcus

4 6

Re: [PATCH 3/4] shell32: Add IKnownFolder::SetPath() implementation
by Mariusz Pluciński June 23, 2011

June 23, 2011

Please, ignore this single patch. This function should be implemented in other way (using redirection feature, the thing I am working on but did not submit yet). W dniu 23.06.2011 18:50, Mariusz Pluciński pisze: > --- > dlls/shell32/shellpath.c | 32 ++++++++++++++++++++++++++++++-- > dlls/shell32/tests/shellpath.c | 3 +-- > 2 files changed, 31 insertions(+), 4 deletions(-) > > -- Best regards Mariusz Pluciński

1 0

Re: [2/6] Make ComboBoxEx send CBEN_ENDEDIT when selecting from the dropdown list
by Nikolay Sivov June 23, 2011

June 23, 2011

On Thu, Jun 23, 2011 at 6:57 PM, Jay Yang <jkelleyy(a)gmail.com> wrote: > >> Could you please add a test for that? It's possible to explicitly send >> WM_COMMAND I guess. This could be done as a next patch if you're sure >> it works right. But in general it should come with a fix. > Hi Nikolay, > > Do you have a suggestion on how to simulate selecting an element from the dropdown list? Should I just send a CBN_DROPDOWN message followed by a CBN_CLOSEUP to the ComboBoxEx? > Yes, this could work I think. Sometimes it's a pain to get a reliable test for controls that are made from another ones, because interaction between them differs or creation order differs between native a wine's. If it's not worth it, it's ok to add simple separate test application to reproduce that, link it with a patch or as another message to wine-devel. Just to have more information about what this patch fixes.

1 0

Re: [4/5] user32: Test that QS_HOTKEY is properly set and cleared.
by Marvin June 23, 2011

June 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11926 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [2/6] Make ComboBoxEx send CBEN_ENDEDIT when selecting from the dropdown list
by Nikolay Sivov June 23, 2011

June 23, 2011

On Thu, Jun 23, 2011 at 6:31 PM, Jay Yang <jkelleyy(a)gmail.com> wrote: > Windows send a CBEN_ENDEDIT when selecting from the dropdown menu, and for wine to send that message, the WCBE_ACTEDIT flag needs to be set when the dropdown is created. > --- > dlls/comctl32/comboex.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > Hey, Jay. Could you please add a test for that? It's possible to explicitly send WM_COMMAND I guess. This could be done as a next patch if you're sure it works right. But in general it should come with a fix.

1 0

GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell June 23, 2011

June 23, 2011

Sorry I made a mistake. On Thu, Jun 23, 2011 at 11:07 AM, Michael Mc Donnell <michael(a)mcdonnell.dk> wrote: > Yes that's the basics of it. It does some other funny things too. For > example it re-orders the indices, so if you have > > 0--1 6 3 > | / / | | \ > | / / | | \ > 2 8--7 5--4 > > That corresponds to: > > index buffer = [ 0,1, 2, 6, 7,8, 3, 4,5] > adjacency = [-1,1,-1, 2,-1,0, -1,-1,1] > point rep = [ 0,1, 2, 1, 4,7, 1, 7,2] Index 5 is not replaced by 7 because the lowest index is always used. So it should have been the other way around: point rep = [ 0,1, 2, 1, 4,5, 1, 5,2] > If the indices had not been re-ordered then the point representation > would have been > [0,1,2, 1,7,2, 1,4,7]. And similarly [0,1,2, 1,5,2, 1,4,5]. I'll put this example into the test.

1 0

Re: [PATCH 03/10] urlmon: Reimplement CreateURLMonikerEx on top of IUri APIs
by Alexandre Julliard June 23, 2011

June 23, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/umon.c | 115 > ++++++++++++++++++++++++++++------------------------ > 1 files changed, 62 insertions(+), 53 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so job.c && touch job.ok job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:386: Test failed: BITS jobs timed out job.c:388: Test failed: IBackgroundCopyJob_Complete job.c:329: Test failed: CreateFile job.c:333: Test failed: ReadFile job.c:338: Test failed: Files differ in length job.c:339: Test failed: Files differ in contents job.c:329: Test failed: CreateFile job.c:333: Test failed: ReadFile job.c:338: Test failed: Files differ in length job.c:339: Test failed: Files differ in contents make: *** [job.ok] Error 39 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] d3dx9_36/tests: Added tests for constant table samplers (Try 2)
by Marvin June 22, 2011

June 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] msvcp90: Added locale class stub
by Alexandre Julliard June 22, 2011

June 22, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > +/* ?name(a)locale@std@@QBE?AV?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@2(a)XZ */ > +/* ?name(a)locale@std@@QEBA?AV?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@2(a)XZ */ > +DEFINE_THISCALL_WRAPPER(locale_name, 8) > +void __thiscall locale_name(THIS_AND_RET(const locale *this, basic_string_char *ret)) > +{ > + FIXME("(%p %p) stub\n", this, ret); > +} You should declare it correctly for the non-i386 case, the return pointer is a calling convention detail that the compiler should take care of. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] shell32: Add IKnownFolderManager::RegisterFolder implementation (resend)
by Marvin June 22, 2011

June 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11886 Your paranoid android. === WVISTAADM (32 bit shellpath) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

[1/2] d3dx9/test: Add UpdateSemantics test. (try 3)
by Michael Mc Donnell June 22, 2011

June 22, 2011

Hi Alexandre My UpdateSemantics patches haven't been applied yet. Stefan Dösinger and Dylan Smith think they look ok. Is there something that looks wrong with them to you, or have you just not have the time to look at them yet? Thanks, Michael Mc Donnell

1 0

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)
by Marvin June 21, 2011

June 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11882 Your paranoid android. === W7PROX64 (64 bit input) === No test summary line found

1 0

Re: [2/3] wined3d: Fix context_apply_draw_buffers() with backbuffer ORM.
by Henri Verbeet June 21, 2011

June 21, 2011

On 21 June 2011 23:49, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Here I modified surface_get_gl_buffer() to fix backbuffer ORM, an > alternative approach would be to modify > context_apply_[blit|clear|draw]_state() in a similar fashion instead. > Yeah, I think I'd prefer the alternative. We handle onscreen and offscreen surfaces separately for the FBO cases as well, and conceptually I'd prefer ORM checks to be in the context code if anywhere.

1 0

bug policy for "app X needs msvcp90.dll" type bugs
by Dan Kegel June 21, 2011

June 21, 2011

(From the "keeping AF happy" and "metabugs are evil" departments.) Anyone watching wine-bugs already knows this, but just in case: As AF suggested in http://bugs.winehq.org/show_bug.cgi?id=24745#c11 bugs about apps needing msvcr90 or the like should identify the particular function in the bug subject line, if possible. There are still some bugs that simply say "app X needs native msvcr90". When the particular function that bothered them is fixed, and the app is verified to get further, that bug's subject line should be updated to identify the function that was fixed, and the bug should be marked as fixed. If the game still doesn't run because of some other function, a new bug should be filed.

1 0

Re: [PATCH 2/2] jscript: Correctly throw an exception if instanceof expression is not used on function
by Marvin June 21, 2011

June 21, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11874 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0