June 2011 - Wine-Devel - list.winehq.org

Re: [3/6] server: Implement RegisterHotKey/UnregisterHotKey.
by Octavian Voicu June 13, 2011

June 13, 2011

Hello, Shouldn't you also increment SERVER_PROTOCOL_VERSION in include/wine/server_protocol.h? Octavian

2 2

Re: [6/6] user32: Test that QS_HOTKEY is properly set and cleared.
by Marvin June 13, 2011

June 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11709 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [3/6] server: Implement RegisterHotKey/UnregisterHotKey.
by Marvin June 13, 2011

June 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11708 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [2/6] user32: Add a test to find the queue containing hotkey messages.
by Marvin June 13, 2011

June 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11707 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/6] user32: Ignore painting messages in the hotkey test using a wndproc.
by Marvin June 13, 2011

June 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11706 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

re: cmd: add support for todo_wine constructions in testing infrastructure
by Dan Kegel June 13, 2011

June 13, 2011

I agree @todo_space@ should go; it's never used, so it's dead code now. Tempting to say that removing it should be a separate patch, rather than combining that with adding a new feature. Since all the @keywords@ are poorly documented, I'm glad to see an unused one go. Your generic @todo_wine@ keyword seems useful. The current code is a bit ugly. If you're going to add a nice is_todo_wine_line() helper, it might make sense to do a cleanup patch that cleans up the @keyword@ recognition in general first. (Why the verbose array declaration instead of a "constant"? etc.) I see you're making every line of the .exp file count as a test. That seems ok. There's a fair bit of code duplication; I wonder if you could avoid that by refactoring things a bit. To avoid adding dead code, it might be nice to see a test that actually uses your new keyword. - Dan

2 4

Re: comctl32/tests: Added first TaskDialog test.
by Nikolay Sivov June 13, 2011

June 13, 2011

On Sun, Jun 12, 2011 at 9:32 AM, Patrick Gauthier <webmaster(a)korosoft.net> wrote: > This patch relies on my previous patch that sets the ordinals right. > > Given that these functions would only be available on COMCTL32 v6.x, > Vista+, I added a win_skip if the APIs are not present. However unless > the test EXE has a manifest on Windows I think it might never find them. > Hey, Patrick. Look at tests/listview.c for example to see how I load version 6 with activation context API. It doesn't work for some reason for XP SP3 (a glitch I don't understand), but works fine for everything else. All you need is v6util.h. Without version 6 activation this test is useless to run in auto mode, it will never find TaskDialog entry points. Thanks for your interest.

3 5

Re: wineboot: Add a command line option to suppress the GUI window.
by Alexandre Julliard June 13, 2011

June 13, 2011

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > programs/wineboot/wineboot.c | 15 +++++++++------ > 1 files changed, 9 insertions(+), 6 deletions(-) That's not going to do anything useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Handle SC_SCREENSAVE in DefWindowProc. (try 2)
by Alexandre Julliard June 13, 2011

June 13, 2011

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > @@ -1606,6 +1607,12 @@ LRESULT NC_HandleSysCommand( HWND hwnd, WPARAM wParam, LPARAM lParam ) > FreeLibrary( hmodule ); > } > } > + else > + { > + const char *argv[3] = { "xdg-screensaver", "activate", NULL }; > + spawnvp( _P_NOWAIT, argv[0], argv ); > + } This should be consolidated with the support in explorer, and probably moved to the graphics driver. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] shell32/tests: verify known folders available in system
by Alexandre Julliard June 13, 2011

June 13, 2011

Mariusz Pluciński <vshader(a)gmail.com> writes: > + StringFromGUID2(folderid, sGuid, sizeof(sGuid)/sizeof(sGuid[0])); > + hr = IKnownFolderManager_GetFolder(mgr, folderid, &folder); > + ok(hr==S_OK, "cannot get folder (id: %s, hr: 0x%08x)\n", wine_dbgstr_w(sGuid), hr); > + > +#define CHECK_KNOWN_FOLDER(id, csidl) \ > + check_single_known_folder(__LINE__, mgr, folderid, &id, csidl, # id, # csidl); > + > + CHECK_KNOWN_FOLDER(FOLDERID_AddNewPrograms, NO_CSIDL) > + CHECK_KNOWN_FOLDER(FOLDERID_AdminTools, CSIDL_ADMINTOOLS) > + CHECK_KNOWN_FOLDER(FOLDERID_AppUpdates, NO_CSIDL) ... This should be a loop over an array. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/8] dxdiag: Introduce the file output infrastructure.
by Alexandre Julliard June 13, 2011

June 13, 2011

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > programs/dxdiag/Makefile.in | 3 +- > programs/dxdiag/main.c | 39 +++++++++++++++++++++++++++--- > programs/dxdiag/output.c | 54 +++++++++++++++++++++++++++++++++++++++++++ > programs/dxdiag/output.h | 49 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 140 insertions(+), 5 deletions(-) Please don't add so many new files. A single header for the whole program would do, and a couple of source files should be enough considering the amount of code you have. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: add support for todo_wine constructions in testing infrastructure
by Jacek Caban June 13, 2011

June 13, 2011

Hi Frédéric, On 06/12/11 23:01, Frédéric Delanoy wrote: > - > + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl); > + There is no need to add such logic directly to test_output, this can be returned from comare_line. Jacek

2 2

Re: d3dx9: Implement GetImageInfoFromResource(A/W) for bitmaps.
by Vincent Povirk June 12, 2011

June 12, 2011

You should probably call D3DXGetImageInfoFromFileInMemory for the real work. On Sun, Jun 12, 2011 at 10:32 PM, Charles Welton <charleswfb(a)gmail.com> wrote: > The code works except it doesn't try to detect the bitmap format. > Kindly ask for review and how to properly implement this. Should > GetDIBits be used? > > -- > Charles Welton > > > >

2 1

Re: comctl32/tests: Added first TaskDialog test. (try 2)
by Marvin June 12, 2011

June 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11662 Your paranoid android. === WXPPROSP3 (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W2K3R2SESP2 (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W7PRO (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W7PROX64 (32 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded! === W7PROX64 (64 bit taskdlg) === taskdlg.c:43: Test failed: COMCTL32.DLL is not loaded!

1 0

About building test suite for Windows
by Patrick Gauthier June 12, 2011

June 12, 2011

Hi, As I was writing my task dialog test I ran into a few problems trying to test on Windows... First, I tried building it using make crosstest but I keep getting this: $ gmake crosstest crosstest is not supported (mingw not installed?) gmake: *** [crosstest] Error 1 I am on FreeBSD 8.2-RELEASE (i386), I have the following mingw ports installed (using pkg_add) mingw32-bin-msvcrt-r3.18.a3.14 mingw32-binutils-2.21,1 mingw32-directx-20020518 mingw32-gcc-4.5.0_1,1 mingw32-pdcurses-3.4 mingw32-pthreads-2.8.0 I deleted config.status (there was no config.cache) and re-ran ./configure, it fails to detect mingw, so I gave up on that. I then tried building them on Windows directly instead (using Visual Studio 2008 with Windows SDK v7.0) as describred there: http://www.winehq.org/docs/winedev-guide/testing-windows However, trying to compile comctl32_tests using the WINE headers would complain about EXCEPTION_EXECUTE_HANDLER being undefined. On the other hand, compiling with the MSVC headers would complain about TVIS_FOCUSED not being present. According to this: http://support.microsoft.com/kb/166471 it has been deprecated and removed from MS headers a long time ago. Eventually I would like to just be able to make crosstest so that I can stay in one dev environments and not two, so if anybody could help me about why isn't mingw32 detected, I would like it. Thanks. - Patrick

5 5

Re: winealsa.drv/midi.c: Adds the midi MTC Quarter Frame messages support.
by BACRI Stephane June 12, 2011

June 12, 2011

Hi all. Was there something incorrect in this patch I submitted in may, or in the way I submitted it? Perhaps should I have mentioned that it had been tested in several ways with hardware & software. Regards. Stéphane.

2 3

Re: [PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity)
by Henri Verbeet June 11, 2011

June 11, 2011

On 11 June 2011 17:26, Marcus Meissner <marcus(a)jet.franken.de> wrote: > if (state <= HIGHEST_TRANSFORMSTATE) > + { > mat = &device->updateStateBlock->state.transforms[state]; > + } > else > + { > FIXME("Unhandled transform state %#x.\n", state); > + return WINED3D_OK; > + } > This works, so I'm not too bothered either way, but I think the following looks slightly nicer: if (state > HIGHEST_TRANSFORMSTATE) { WARN("Invalid transform state %#x.\n", state); return WINED3D_OK; } mat = &device->updateStateBlock->state.transforms[state]; multiply_matrix(&temp, mat, matrix);

1 0

Re: [PATCH 1/4] Check for null pointers before strcmp. (LLVM/Clang)
by Juan Lang June 11, 2011

June 11, 2011

Hi Lauri, ok(pdst != NULL, "inet_ntoa failed %s\n", dst); - ok(!strcmp(pdst, addr0_Str),"Address %s != %s\n", pdst, addr0_Str); + ok(pdst && !strcmp(pdst, addr0_Str),"Address %s != %s\n", pdst, addr0_Str); This change doesn't accomplish anything. In the first place, the previous ok which you did not change already ensures pdst is not NULL. While it's true that this ok could fail, leading to a following crash in the tests, the fact that the tests pass indicates this isn't happening. Second, the ok output message also dereferences pdst by printing it, so in the case that it is NULL, you haven't fixed anything. Really, I suggest you just ignore this warning, it's not worth the extra baggage. --Juan

3 3

Re: [PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity)
by Stefan Dösinger June 11, 2011

June 11, 2011

On Saturday 11 June 2011 11:17:58 Marcus Meissner wrote: > else > + { > FIXME("Unhandled transform state %#x.\n", state); > + return WINED3DERR_INVALIDCALL; > + } Please return WINED3D_OK, like wined3d_device_set_sampler_state and other setters. Native doesn't do this kind of consistency checking, so apps will get D3D_OK returned if they pass an out of range state(unless the setter segfaults).

1 0

Re: [PATCH] user32: initialize all of msg (Coverity)
by Marvin June 11, 2011

June 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11625 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH 4/4] Make sure to use a return value. (LLVM/Clang)
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11621 Your paranoid android. === WNT4WSSP6 (32 bit sock) === sock.c:524: Test failed: oob_server (82): received less data than expected: 2024 of 2040 === WXPPROSP3 (32 bit sock) === sock.c:524: Test failed: oob_server (70c): received less data than expected: 2024 of 2040 === W2K3R2SESP2 (32 bit sock) === sock.c:524: Test failed: oob_server (b90): received less data than expected: 2024 of 2040 === WVISTAADM (32 bit sock) === sock.c:524: Test failed: oob_server (948): received less data than expected: 2024 of 2040 === W2K8SE (32 bit sock) === sock.c:524: Test failed: oob_server (bb0): received less data than expected: 2024 of 2040 === W7PRO (32 bit sock) === sock.c:524: Test failed: oob_server (2fc): received less data than expected: 2024 of 2040 === W7PROX64 (32 bit sock) === sock.c:524: Test failed: oob_server (440): received less data than expected: 2024 of 2040 === W7PROX64 (64 bit sock) === sock.c:524: Test failed: oob_server (3ec): received less data than expected: 2024 of 2040

1 0

testbot flakiness?
by Dan Kegel June 10, 2011

June 10, 2011

https://testbot.winehq.org/JobDetails.pl?Key=11509 shows failures and crashes, but the nearly identical https://testbot.winehq.org/JobDetails.pl?Key=11510 does not. (The latter one just adds a call to GetProcessMemoryInfo() in the xyz() logging function.) And the failure shown by the first patch has a last error on creating the batch file of 8, ERROR_NOT_ENOUGH_MEMORY, which is suspicious. Not quite sure what's going on there.

2 2

Re: [1/2] d3dx9/test: Add UpdateSemantics test. (try 2)
by Dylan Smith June 10, 2011

June 10, 2011

> +static void test_update_semantics(void) > +{ > ... > + int offset = 12; sizeof(D3DXVECTOR3) might be clearer.

2 1

Re: [2/2] d3dx9: Implement UpdateSemantics mesh method. (try 2)
by Dylan Smith June 10, 2011

June 10, 2011

Your patches have dos line endings (i.e. "\r\n") which causes git apply to fail, although the patch command only gives a warning. @@ -208,6 +221,12 @@ static DWORD WINAPI > ID3DXMeshImpl_GetNumBytesPerVertex(ID3DXMesh *iface) > TRACE("iface (%p)\n", This); > + if (!This->vertex_declaration) > + { > + WARN("Can't get number of bytes per vertex of an invalid vertex > declaration.\n"); > + return E_FAIL; > + } GetNumBytesPerVertex returns a DWORD not an HRESULT, so I wouldn't expect E_FAIL to ever be returned? Unusual behaviour like this should be covered by a test. + /* An application can pass an invalid declaration to UpdateSemantics > and > + * still expect D3D_OK (see tests). If the declaration is invalid, > then > + * subsequent calls to GetDeclaration, GetNumBytesPerVertex, and > DrawSubset, > + * which use the declaration, will fail. > + */ D3DXCreateMesh fails when the declaration contains a non-zero Stream value. I would expect UpdateSemantics to be as strict as D3DXCreateMesh, otherwise a test could validate the different behaviour. You tested a declaration with larger fields, but not with the vertex size being smaller or greater. (E.g. Try removing the last field, or appending a field.) I did some testing and couldn't get GetDeclaration or GetNumBytesPerVertex to fail on windows. DrawSubset did seem to fail after UpdateSemantics is called with a declaration that causes CreateVertexDeclaration to fail. This suggests that the native implementation probably just stores the D3DVERTEXELEMENT9 array and calls CreateVertexDeclaration on DrawSubset. You can probably cache the created vertex declaration and release it on UpdateSemantics for performance.

2 1

Re: cmd: Ensure mkdir returns an error for pre-existing directories
by Marvin June 10, 2011

June 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11601 Your paranoid android. === WVISTAADM (32 bit) === batch: unhandled exception c0000005 at 77496FCF === W2K8SE (32 bit) === batch: unhandled exception c0000005 at 778A8915 === W7PRO (32 bit) === batch.c:70: Test failed: CreateFile failed batch: unhandled exception c0000005 at 772D3067 === W7PROX64 (32 bit) === batch.c:96: Test failed: CreateProcess failed: 1450 === W7PROX64 (64 bit) === Timeout

1 0