June 2011 - Wine-Devel - list.winehq.org

Re: [1/26](resend)usp10: Add Indic syllable parsing and reordering system
by Alexandre Julliard June 2, 2011

June 2, 2011

Aric Stewart <aric(a)codeweavers.com> writes: > +void Indic_ReorderCharacters( LPWSTR input, int cChar, lexical_function lex, reorder_function reorder_f) > +{ > + int index = 0; > + int next = 0; > + int center; > + > + if (!lex || ! reorder_f) > + { > + ERR("Failure to have required functions\n"); > + return; > + } > + > + debug_output_string(input, cChar, lex); > + while (next != -1) > + { > + ZERO_OR_MORE(lex_Generic); > + index = next; > + next = Indic_process_next_syllable(input, cChar, 0, &center, index, lex); > + if (next != -1) > + { > + reorder_f(input, index, center, next-1, lex); > + index = next; > + } > + else if (index < cChar) > + { > + int i; > + TRACE("Processing failed at %i\n",index); > + for (i = index; i < cChar; i++) > + if (lex(input[i])==lex_Generic) > + { > + TRACE("Restart processing at %i\n",i); > + next = i; > + index = i; > + break; > + } > + } > + } > + TRACE("Processed %i of %i characters\n",index,cChar); > +} Please don't add dead code. This function should be called from somewhere (same for the subsequent patches). -- Alexandre Julliard julliard(a)winehq.org

1 0

A request about the release notes
by Scott Ritchie June 1, 2011

June 1, 2011

When 1.3.19 came out it changed the build requirements for OSS support -- OSS 3 was no longer supported and OSS 4 dev libraries were required at build time. This was the changelog: New sound driver architecture for MMDevAPI. Better support for relative mouse events in DInput. Debugger support for the ARM platform. Various improvements in D3DX9. More MSVC runtime functions. Various bug fixes. At least two distros broke their OSS support as a result, since the standard "update wine version but use same packaging" didn't return a complete Wine anymore. In my case I only noticed when a bug report came in and I manually looked at the package build log. This sort of thing would be much less likely to happen if such a build dependency change were noted in the release notes, such as a "OSS 3 no longer supported" bullet point. Thanks, Scott Ritchie

1 0

Re: wined3d: Set container of swapchain surfaces to WINED3D_CONTAINER_NONE in swapchain_init() error path.
by Stefan Dösinger June 1, 2011

June 1, 2011

On Wednesday 01 June 2011 01:38:24 Piotr Pawłow wrote: > Since commit fadfdf21c055caf833a137ffc269c2073dc87fd6 surface refcounts are > forwarded to the container. We need to break this forwarding in > swapchain_init() error path, otherwise the swapchain refcount goes down to > zero and swapchain_cleanup() gets called on an invalid, partly initialized > swapchain. This patch looks OK

1 0

Re: Added unbound sampler test for pixel shaders.
by Alexandre Julliard June 1, 2011

June 1, 2011

Sean Sube <ssube(a)codeweavers.com> writes: > --- > dlls/d3d9/tests/visual.c | 80 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 80 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:8909: Tests skipped: D3DFMT_G16R16 textures not supported as render targets. visual.c:7503: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:12112: Test failed: Color is 0xffffffff. make[1]: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: d3d9: Increment the reference count of the IDirect3D9 instance when creating a device.
by Andrew Nguyen June 1, 2011

June 1, 2011

The Pathologic demo in bug 21552 expects that the reference count of a IDirect3D9 instance is incremented after a successful call to CreateDevice with the instance. Does my proposed fix for d3d8 and d3d9 manage the reference count of the device parent appropriately? In particular, I'm concerned about the slightly cumbersome acquisition of the pointer to the parent instance within the Release call for the Direct3D device interface. Is the overall location of the AddRef/Release calls correct, and should I be doing something differently when the device tries to decrement the parent reference count?

2 1

Re: infosoft/tests: COM cleanup in infosoft.c.
by Marvin June 1, 2011

June 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11350 Your paranoid android. === WVISTAADM (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W2K8SE (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W7PRO (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W7PROX64 (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === W7PROX64 (64 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed

2 1

Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.
by Stefan Dösinger June 1, 2011

June 1, 2011

Does the enum_device_entry structure have to be in ddraw_private.h? I think you can just declare it in ddraw.c because it is used only there. At some point we'll want to get rid of the ddraw device type strings and call wined3d_get_adapter_identifier - but that needs more work and some more tests. Am 31.05.2011 um 12:50 schrieb Andrew Nguyen: > --- > dlls/ddraw/ddraw.c | 43 +++++++++++++------ > dlls/ddraw/ddraw_private.h | 8 ++++ > dlls/ddraw/tests/d3d.c | 98 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 136 insertions(+), 13 deletions(-) > > > <0004-ddraw-Extend-the-lifetime-of-the-EnumDevices-strings-b.txt>

2 2