June 2011 - Wine-Devel - list.winehq.org

Re: [3/8] msi: Handle escaped double quotes in command line parsing.
by Marvin June 30, 2011

June 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12111 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === W7PRO (32 bit install) === Timeout

1 0

RectInRegion Question
by Alistair Leslie-Hughes June 30, 2011

June 30, 2011

Hi, When looping Region rects in function RectInRegion, we have the condition if(pCurRect->top >= rc.bottom) break; Should this break actually be a continue, like the other conditions? Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 3/3] d3dx9/tests: Implemented Draw and DrawTransform tests for ID3DXLine.
by Marvin June 30, 2011

June 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12105 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [2/2] d3dx9_36: Implement and add tests for D3DXFloat16To32Array.
by Matteo Bruni June 29, 2011

June 29, 2011

2011/6/29 Misha Koshelev <misha680(a)gmail.com>: > --- ... > + else return sgn * powf(2, -14.0f) * ((float)m / 1024.0f); ... > + return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); I think you don't need the explicit casts here, the values should be automatically promoted to floats as the other operand is a float as well.

1 0

Bad_Pool_Header
by Keith Muir June 29, 2011

June 29, 2011

Hi, Been trying to run wine tests from http://test.winehq.org/data/ but every time I try this for about the last half dozen versions I get a blue screen and bad pool header any suggestions? I try to support the project by doing test runs and updating the appdb. Regards, Keith

2 1

Ge (Greg) van Geldorp
by Paul Vriens June 29, 2011

June 29, 2011

Hi, The sad news reached me two days ago that Ge (Greg) van Geldorp passed away. Please find below the mail from his brother. I've briefly talked to Jeremy and Alexandre about this loss and the idea came up to have something on the winehq frontpage for a while. Jeremey also mentioned to mark Greg's life and contributions to Wine at Wineconf this year. Alexandre mentioned potentially hosting the winetestbot at codeweavers in the future. Both the frontpage remembrance and the potential hosting somewhere else has been discussed by me and Arno and will not be an issue. Cheers, Paul. -------- Original Message -------- Subject: RE: Ge van Geldorp Date: Thu, 9 Jun 2011 23:05:46 +0200 From: Erven Gé van Geldorp <erven.van.geldorp(a)gmail.com> To: 'Paul Vriens' <paul.vriens.wine(a)gmail.com> Hi all, My name is Arno van Geldorp. I'm the brother of Gé (Greg) van Geldorp. I'm very sorry that I have to inform you that Greg has passed away almost 3 weeks ago. 2 Months earlier he was diagnosed with cancer in a very aggressive form. I know he made his contribution to the Wine project. And that one of them is the WineTestBot. His passing away went so fast that he didn't have the time to inform me all about it. What he did ask me is to make sure that the server where the WineTestBot is running on will be hosted for at least 2 more years. So we will take care of that. But I don't know if anyone took over the administration off the server. If anyone took over the administration from Greg could you please contact me at erven.van.geldorp at gmail.com Kind regards, Arno van Geldorp

9 10

Re: [1/2] include: Add declarations related to D3DXFLOAT16.
by Dylan Smith June 29, 2011

June 29, 2011

On Wed, Jun 29, 2011 at 11:16 AM, Misha Koshelev <misha680(a)gmail.com> wrote: > Submitted by original author as requested by Alexandre. Necessary for > further patches by Dylan Smith to fix bug 25769. > Attached are the further patches he is referring to, which are based on his patch series.

1 0

Re: [1/2] oleaut32: COM Cleanup ICreateTypeLib2Imp (resend)
by Michael Stefaniuc June 29, 2011

June 29, 2011

Hello Alistair, sorry that I missed the first time. And Alexandre should have marked it as PENDING (good idea but current implementation is rejected). Alistair Leslie-Hughes wrote: > Changelog: > oleaut32: COM Cleanup ICreateTypeLib2Imp > > > Best Regards > Alistair Leslie-Hughes > >From 4e5e70b84cc4a254e5e3bdfeb788282a20a3dd50 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Mon, 27 Jun 2011 22:24:09 +1000 > Subject: [PATCH] COM Cleanup ICreateTypeLib2Imp > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/oleaut32/typelib2.c | 75 ++++++++++++++++++++++++--------------------- > 1 files changed, 40 insertions(+), 35 deletions(-) > > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index e9c7613..5740ddd 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -1476,7 +1481,7 @@ static HRESULT ctl2_find_typeinfo_from_offset( > > for (typeinfo = This->typeinfos; typeinfo; typeinfo = typeinfo->next_typeinfo) { > if (typeinfo->typeinfo == typeinfodata) { > - *ppTinfo = (ITypeInfo *)&typeinfo->lpVtblTypeInfo2; > + *ppTinfo = (ITypeInfo *)&typeinfo->ITypeInfo2_iface.lpVtbl; Please don't cast a vtable to an iface, cast the iface instead: + *ppTinfo = (ITypeInfo *)&typeinfo->ITypeInfo2_iface > ITypeInfo2_AddRef(*ppTinfo); > return S_OK; > } > @@ -1573,7 +1578,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnQueryInterface( > *ppvObject = This; > } else if (IsEqualIID(riid, &IID_ITypeInfo) || > IsEqualIID(riid, &IID_ITypeInfo2)) { > - *ppvObject = &This->lpVtblTypeInfo2; > + *ppvObject = &This->ITypeInfo2_iface.lpVtbl; No need to go here down to the vtable: + *ppvObject = &This->ITypeInfo2_iface It's the exact same thing but shorter. > } > > if(*ppvObject) > @@ -1697,7 +1702,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnSetTypeFlags(ICreateTypeInfo2 *iface, U > iter->next_typeinfo = This->dual; > } > } else > - iface = (ICreateTypeInfo2*)&This->dual->lpVtbl; > + iface = (ICreateTypeInfo2*)&This->dual->ICreateTypeInfo2_iface.lpVtbl; There's no need for a cast here as you already have the right thing: + iface = &This->dual->ICreateTypeInfo2_iface; > } > > if (uTypeFlags & (TYPEFLAG_FDISPATCHABLE|TYPEFLAG_FDUAL)) { You missed a few changes: @@ -3153,7 +3158,7 @@ { ICreateTypeInfo2Impl *This = impl_from_ITypeInfo2(iface); - return ICreateTypeInfo2_QueryInterface((ICreateTypeInfo2 *)This, riid, ppv); + return ICreateTypeInfo2_QueryInterface(&This->ICreateTypeInfo2_iface, riid, ppv); } There are more of those "(ICreateTypeInfo2 *)This" ==> "&This->ICreateTypeInfo2_iface" changes. Check for all (ICreateTypeInfo2 *), there should be none left. > @@ -3388,7 +3393,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeOfImplType( > } > > if(This->typekind == TKIND_DISPATCH) > - return ITypeInfo2_GetRefTypeOfImplType((ITypeInfo2*)&This->dual->lpVtblTypeInfo2, > + return ITypeInfo2_GetRefTypeOfImplType((ITypeInfo2*)&This->dual->ITypeInfo2_iface.lpVtbl, No need for the cast: + return ITypeInfo2_GetRefTypeOfImplType(&This->dual->ITypeInfo2_iface, > index, pRefType); > } > > @@ -3599,7 +3604,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeInfo( > return E_INVALIDARG; > > if(hRefType==-2 && This->dual) { > - *ppTInfo = (ITypeInfo*)&This->dual->lpVtblTypeInfo2; > + *ppTInfo = (ITypeInfo*)&This->dual->ITypeInfo2_iface.lpVtbl; Just cast the iface: + *ppTInfo = (ITypeInfo*)&This->dual->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } > @@ -3635,7 +3640,7 @@ static HRESULT WINAPI ITypeInfo2_fnGetRefTypeInfo( > > for(iter=This->typelib->typeinfos; iter; iter=iter->next_typeinfo) { > if(This->typelib->typelib_typeinfo_offsets[i] == (hRefType&(~0x3))) { > - *ppTInfo = (ITypeInfo*)&iter->lpVtblTypeInfo2; > + *ppTInfo = (ITypeInfo*)&iter->ITypeInfo2_iface.lpVtbl; Same here: + *ppTInfo = (ITypeInfo*)&iter->ITypeInfo2_iface; > > ITypeLib_AddRef(*ppTInfo); > return S_OK; > @@ -4948,7 +4953,7 @@ static HRESULT WINAPI ITypeLib2_fnGetDocumentation( > if(!iter) > return TYPE_E_ELEMENTNOTFOUND; > > - return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->lpVtblTypeInfo2, > + return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->ITypeInfo2_iface.lpVtbl, And here: + return ITypeInfo_GetDocumentation((ITypeInfo*)&iter->ITypeInfo2_iface, > -1, pBstrName, pBstrDocString, pdwHelpContext, pBstrHelpFile); > } > thanks bye michael

1 0

Re: [PATCH] comctl32: Fixed strncpy (Coverity)
by Michael Stefaniuc June 28, 2011

June 28, 2011

Hello Marcus, On 06/28/2011 09:15 AM, Marcus Meissner wrote: > This is a 2 CHAR buffer, and we copy in 1 CHAR and \0. So just do that > via strcpy() and dont confuse the static checker. > > CID 1194 > > Ciao, Marcus > --- > dlls/comctl32/tests/treeview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c > index 324473d..faa9553 100644 > --- a/dlls/comctl32/tests/treeview.c > +++ b/dlls/comctl32/tests/treeview.c > @@ -1225,7 +1225,7 @@ static void test_itemedit(void) > r = TreeView_SelectItem(hTree, NULL); > expect(TRUE, r); > /* alter text */ > - strncpy(buff, "x", sizeof(buff)/sizeof(CHAR)); > + strcpy(buff, "x"); > r = SendMessage(edit, WM_SETTEXT, 0, (LPARAM)buff); What about r = SendMessage(edit, WM_SETTEXT, 0, (LPARAM)"x"); No strcpy involved. > expect(TRUE, r); > r = SendMessage(hTree, WM_COMMAND, MAKEWPARAM(0, EN_KILLFOCUS), (LPARAM)edit); bye michael

3 2

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)
by Alexandre Julliard June 28, 2011

June 28, 2011

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, dwFlags); > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = IDirectInputDevice8WImpl_SetActionMap(&This->IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + _copy_diactionformatWtoA(lpdiaf, &diafW); Do you really need to copy it back? It looks like an input parameter. -- Alexandre Julliard julliard(a)winehq.org

2 2