July 2011 - Wine-Devel - list.winehq.org

Re: netapi32: add msvcrt to importlibs
by Alexandre Julliard July 21, 2011

July 21, 2011

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > hi, this fixes bug http://bugs.winehq.org/show_bug.cgi?id=27827 > > Creo Elements expects msvcrt to be loaded, and fails to start. > > Dependancywalker on windows shows netapi32 loads the msvcrt. I guess > when more netapi32 functions will be implemented in future this will > become a "real" necessary dependency It won't help if it's not used, and you'd need to use msvcrt headers too. I don't think it's the right place to fix this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Experimental website for tracking translation issues
by Francois Gouget July 21, 2011

July 21, 2011

I have started running a script that can check for translation issues in PO files against Wine's PO files. The issues it checks for include: * Mismatched printf format specifiers. * Mismatched trailing ellipsis. * Other mismatched trailing punctuation like full stop, question mark, space, etc. * Mismatched line feeds, trailing or not. * Spaces followed by line feeds. * Untranslated strings. Obviously some of these result in false positives. For instance 'Document' is written exactly the same in English and in French so to the script it will look like it was not translated. If you send me the corresponding error lines I'll make sure they are ignored by putting them in an 'ignore' file. So here's the web site: http://fgouget.free.fr/wine-po/ A typical report looks like this: L71: msgid or msgstr does not end in '[.]{3}' L75: msgid or msgstr does not end in '[.]{3}' You'd typically have the report and the corresponding PO file (here pl.po) open side by side, and jump to the PO lines mentionned in the report to investigate each of them. These are two ellipsis issues by the way. As you can see it's quite primitive. That's both because I'm not much of a web developer guy and because I'm still unsure how much interest there is in this. Also there's an open-source tool that does the same type of checks and more, though it seems to lack a way to handle false positives. It's pofilter from the translate-toolkit package. This tool is integrated with Pootle (the online PO file editor), so maybe this will do all we need once we put our PO files online for translation. In the meantime if any translator is interested in seeing what potential issues lie in their PO files... I'd particularly appreciate help with cleaning up the ellipsis, trailing spaces and untranslated string issues. See wine-patches for a handful of patches I'm sending based on the initial reports. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

3 7

Re: po: French translation tweaks and fixes.
by Frédéric Delanoy July 20, 2011

July 20, 2011

2011/7/20 Francois Gouget <fgouget(a)free.fr>: > --- > po/fr.po | 108 ++++++++++++++++++++++++++++++++------------------------------ > 1 files changed, 56 insertions(+), 52 deletions(-) @@ -6857,7 +6859,7 @@ msgstr "Corbeille" #: shlwapi.rc:27 msgid "%ld bytes" -msgstr "%ld bytes" +msgstr "%ld octets" #: shlwapi.rc:28 msgid " hr" Bytes and octets are different things; octets have exactly 8 bits while bytes can have more (or less) -"Start est fourni sans AUCUNE GARANTIE ; pour les détails lancez avec " +"Start est fourni sans AUCUNE GARANTIE ; pour plus de détails lancez le avec\n" Should be "lancez-le" #: winefile.rc:101 msgid "root fs" -msgstr "root fs" +msgstr "fs racine" Maybe "sdf racine" for "système de fichiers"? Frédéric

3 3

[PATCH 4/4] winmm: Fix check for DCB_NULL callback type
by Joerg-Cyril.Hoehle＠t-systems.com July 20, 2011

July 20, 2011

Andrew Eikum wrote: >- if(info->flags & DCB_NULL) >+ if((info->flags & DCB_TYPEMASK) == DCB_NULL) Instead of add ing a special case, I suggest to simplify the code: always call DriverCallback and declare void WINMM_NotifyClient. You currently ignore its return value anyway. Using void is consistent with an ealier notification patch of mine around April this year. Michael, wouldn't it be possible to add a function to the static checkers to be able to detect static functions whose return is systematically ignored and rewrit these and their callers to use void? I came across another occurence of that pattern no later than yesterday (mcimidi IIRC). Regards, Jörg Höhle

2 1

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.
by Alexandre Julliard July 20, 2011

July 20, 2011

Grazvydas Ignotas <notasas(a)gmail.com> writes: > @@ -2004,6 +2004,8 @@ NTSTATUS WINAPI NtQueryDirectoryFile( HANDLE handle, HANDLE event, > fstat( fd, &st ); > curdir.dev = st.st_dev; > curdir.ino = st.st_ino; > + if (lseek( fd, 0, SEEK_CUR ) == 0) > + restart_scan = TRUE; That won't work if we already returned '.' and '..'. -- Alexandre Julliard julliard(a)winehq.org

4 10

Re: comctl32: Improve the stub of TaskDialogIndirect to display a simple message box pending a full implementation
by Reece Dunn July 20, 2011

July 20, 2011

On 20 July 2011 15:39, Jeff Latimer <lats(a)yless4u.com.au> wrote: > This should allow more apps to run. My mail import has blown up and I > may have messed up the format of the patch. The patch is line wrapped -- you need to send the patch as an attachment in a form that gets recognised as an octet stream (using the .patch extension should do this). > + if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON | > TDCBF_NO_BUTTON | TDCBF_CANCEL_BUTTON)) > + uType &= MB_YESNOCANCEL; > + else > + if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON | > TDCBF_NO_BUTTON)) > + uType &= MB_YESNO; This will not work as intended -- (a & (b | c)) will evaluate true if a contains either b or c, equivalent to ((a & b) || (a & c)). You need to use ((a & b) == b) instead. - Reece

1 0

Re: po: Remove English strings from the Polish translation.
by Jacek Caban July 20, 2011

July 20, 2011

Hi Francois, On 07/20/11 16:14, Francois Gouget wrote: > --- > po/pl.po | 88 +++++++++++++++++++++++++++++++------------------------------- > 1 files changed, 44 insertions(+), 44 deletions(-) > Separator, diagram and folder are the right Polish translations (that happen to be identical to English). Others should, obviously, be removed. Jacek

2 2

Re: [PATCH 1/5] quartz: Rather than assert, continue when IAsyncReader::WaitForNext is flushing and break when it actually times out.
by Alexandre Julliard July 20, 2011

July 20, 2011

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -479,13 +488,27 @@ static void PullPin_Thread_Process(PullPin *This) > else > { > /* FIXME: This is not well handled yet! */ > - ERR("Processing error: %x\n", hr); > if (hr == VFW_E_TIMEOUT) > { > - assert(!pSample); > + struct timeval tve; > + > + /* > + * Calculate the time elapsed in IAsyncReader::WaitForNext > + * in order to determine whether a timeout actually occurred > + * or whether the pin is flushing. > + */ > + timersub(&tv2, &tv1, &tve); > + if (!timercmp(&tve, &tvw, <) && pSample != NULL) > + { > + ERR("Non-NULL sample returned with VFW_E_TIMEOUT.\n"); > + break; > + } That's really ugly. Surely there's a better way to do this than measuring the elapsed time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 10/10] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 19, 2011

July 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12606 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: d3dx9_36: Use SUCCEEDED instead of !FAILED.
by Matteo Bruni July 19, 2011

July 19, 2011

2011/7/19 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > dlls/d3dx9_36/mesh.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c > index 94a291f..d8f72c4 100644 > --- a/dlls/d3dx9_36/mesh.c > +++ b/dlls/d3dx9_36/mesh.c > @@ -3376,7 +3376,7 @@ HRESULT WINAPI D3DXLoadMeshFromXResource(HMODULE module, > if (!resinfo) return D3DXERR_INVALIDDATA; > > hr = load_resource_into_memory(module, resinfo, &buffer, &size); > - if (!FAILED(hr)) return D3DXERR_INVALIDDATA; > + if (SUCCEEDED(hr)) return D3DXERR_INVALIDDATA; > > return D3DXLoadMeshFromXInMemory(buffer, size, options, device, adjacency, > materials, effect_instances, num_materials, mesh); > -- > 1.7.6 > > > Isn't that supposed to be "if (FAILED(hr))" ? If I'm not mistaken, now it is returning failure when the resource is correctly loaded... Thumbs up for Michael's scripts finding real bugs ;)

2 1

Re: use Lithuanian letter in my name
by Frédéric Delanoy July 19, 2011

July 19, 2011

On Mon, Jul 18, 2011 at 23:53, Nerijus Baliunas <nerijus(a)users.sourceforge.net> wrote: > --- > AUTHORS | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Maybe you should ensure that the name you commit your patches with (foo in 'foo <email>') is correctly spelled as well. I believe the authors list is generated from wine git's patch authors Frédéric

3 2

Re: [PATCH 2/5] d3dx9_36: Improved constant table handle support (try 3)
by Alexandre Julliard July 18, 2011

July 18, 2011

Travis Athougies <iammisc(a)gmail.com> writes: > +static ctab_constant *is_valid_constant(ID3DXConstantTableImpl *This, D3DXHANDLE parameter) > +{ > + UINT i; > + > + for (i = 0; i < This->desc.Constants; i++) > + if ((ctab_constant *)parameter == &This->constants[i]) > + return (ctab_constant *)parameter; This doesn't look like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 1

Rejected or commited?
by wylda＠volny.cz July 18, 2011

July 18, 2011

Hi, I just noticed that patch 76524 is "Rejected". But there is the same patch commited as 48d03555a7a6931ee8ba0952ccb92c70925c6bed. Duno, if some other patch should not be merged instead. Regards, W. -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.cz si zajisté vyberete.

2 1

Re: jscript: Properly handle aggregation attempt
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12575 Your paranoid android. === W2KPROSP4 (32 bit jscript) === jscript.c:615: Test failed: CoCreateInstance failed: 80070057, expected CLASS_E_NOAGGREGATION

1 0

Re: [PATCH 3/3] vbscript: Added creation tests
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12573 Your paranoid android. === WNT4WSSP6 (32 bit vbscript) === vbscript.c:38: Test failed: CoCreateInstance failed: 80040154 vbscript: unhandled exception c0000005 at 004012F2

1 0

Re: mshtml: Added IHTMLStyle::pageBreakAfter property implementation
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12568 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null) === WVISTAADM (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null) === W2K8SE (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null)

1 0

Re: [PATCH 02/10] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Alexandre Julliard July 18, 2011

July 18, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -774,6 +775,28 @@ static void test_query_object(void) > pNtClose( handle ); > } > > +static void test_type_mismatch(void) > +{ > + HANDLE h; > + NTSTATUS res; > + OBJECT_ATTRIBUTES attr; > + > + attr.Length = sizeof(attr); > + attr.RootDirectory = 0; > + attr.ObjectName = NULL; > + attr.Attributes = 0; > + attr.SecurityDescriptor = NULL; > + attr.SecurityQualityOfService = NULL; > + Please avoid messing up the indentation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] dsound/tests: Add tests to check notifications after duplicate.
by Alexandre Julliard July 18, 2011

July 18, 2011

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/dsound/tests/dsound.c | 178 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 178 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound.c && touch dsound.ok dsound.c:1066: Test succeeded inside todo block: expected 1. got 1 make[1]: *** [dsound.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] user32: handle %I... formats in user32.wsprintf* (try 2)
by Alexandre Julliard July 18, 2011

July 18, 2011

Dan Kegel <dank(a)kegel.com> writes: > + i64 = 0x100000000LL; Don't use LL constants. > @@ -257,14 +282,25 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, > case WPR_SIGNED: > len = sprintf( number, "%d", arg->int_view ); > break; > + case WPR_SIGNED64: > + len = sprintf( number, "%lld", arg->int64_view ); > + break; Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/11] wscript: fixed running script from outside its directory (resend)
by Alexandre Julliard July 18, 2011

July 18, 2011

Michał Ziętek <smierc.w.wenecji(a)gmail.com> writes: > @@ -347,7 +347,7 @@ int WINAPI wWinMain(HINSTANCE hInst, HINSTANCE hPrevInst, LPWSTR cmdline, int cm > return 1; > } > > - ext = strchrW(filename, '.'); > + ext = strrchrW(filename, '.'); That's not much better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Implment IHTMLDocument2 elementFromPoint
by Jacek Caban July 18, 2011

July 18, 2011

Hi Alistair, On 07/18/11 06:29, Alistair Leslie-Hughes wrote: > Hi, > Fixmes http://bugs.winehq.org/show_bug.cgi?id=27682 > > > Changelog: > mshtml: Implment IHTMLDocument2 elementFromPoint > First of all, tests please. + nsIDOMElement *nselem = NULL; + nsresult nsres; + HRESULT hres; + HTMLDOMNode *node; You use tabs in the whole patch. + nsIDOMNSDocument *pNSDoc; Please don't add such variable names. Jacek

1 0

Re: mshtml: Handle the failure case in get_nsstyle_attr.
by Jacek Caban July 18, 2011

July 18, 2011

Hi Gerald, On 07/15/11 22:49, Gerald Pfeifer wrote: > --- > dlls/mshtml/htmlstyle.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index cd1f6b5..3e76e61 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -468,6 +468,8 @@ HRESULT get_nsstyle_attr(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, BSTR > > nsAString_GetData(&str_value, &value); > hres = nsstyle_to_bstr(value, flags, p); > + if( FAILED(hres) ) > + return hres; > nsAString_Finish(&str_value); Good catch, but you add a leak here. Jacek

1 0

Re: [PATCH 10/10] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12563 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: ole32: Remove dead code.
by Nikolay Sivov July 18, 2011

July 18, 2011

On Mon, Jul 18, 2011 at 9:43 AM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > > MSHLFLAGS_NORMAL == 0. > --- > dlls/ole32/compobj_private.h | 4 +--- > dlls/ole32/stubmanager.c | 19 ++----------------- > 2 files changed, 3 insertions(+), 20 deletions(-) > > Maybe it should be like 'flags == MSHLFLAGS_NORMAL' ?

1 0

Re: [PATCH 12/12] ntdll/tests: add some todo_wines to the new pipe test
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12529 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/12] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12528 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 03/12] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12527 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 02/12] kernel32/tests: make sure the pipe is opened in an nonalertable mode
by Marvin July 16, 2011

July 16, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12526 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: Glitch-free iTunes?
by Dan Kegel July 16, 2011

July 16, 2011

Keith wrote: > http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… > Can you make a goal of supporting iTunes with no glitches? ... > Just this one app could be huge for Linux on the desktop. The main problem is driver support, I think (mainly usb, but probably also cd-r). There is some work on usb support going on; see http://wiki.winehq.org/USB I haven't tried that myself. (Has anyone tried this with iTunes yet?) According to $ winedump -j import ~/".wine/drive_c/Program Files/Common Files/Apple/Mobile Device Support/Drivers/usbaapl.sys" | grep offset offset 00009250 ntoskrnl.exe offset 00009264 HAL.dll offset 00009278 WMILIB.SYS offset 0000928c USBD.SYS support for wmilib.sys might need to be added for this app. And I suspect the pcworld guy was using an outdated version of wine (given the problems he reported with the package manager ui). Otherwise, current iTunes seems to be working reasonably well in current wine. I just downloaded and installed iTunes 10.3.1 with wine-1.3.23. I did have to set win7 mode, and I do have to click through one dialog saying it won't be able to burn cd's, but I can use the iTunes store to search for movies and play their trailers nicely; I can listen to internet radio or a local .mp3 for 5-10 minutes with no hint of trouble. So: yeah, we know it's an important app. But it's hard. Feel free to help out. - Dan

8 9

Re: [PATCH 02/12] kernel32/tests: make sure the pipe is opened in nonalertable mode
by Alexandre Julliard July 15, 2011

July 15, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/kernel32/tests/pipe.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so pipe.c && touch pipe.ok pipe.c:484: Test failed: ConnectNamedPipe pipe.c:494: Test failed: ReadFile pipe.c:497: Test failed: WriteFile pipe.c:503: Test failed: DisconnectNamedPipe Segmentation fault (core dumped) make: *** [pipe.ok] Error 139 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/2] cmd/tests: Add tests for recursive rmdir
by Marvin July 15, 2011

July 15, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12505 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc1def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel nonzero, bad', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def(a)or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good(a)or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7

2 1

Re: [PATCH 10/11] wscript: implemented Host_get_Interactive
by Jacek Caban July 15, 2011

July 15, 2011

Hi Michał, On 07/15/11 03:22, Michał Ziętek wrote: > --- > programs/wscript/host.c | 7 +++++-- > programs/wscript/main.c | 26 +++++++++++++++++++++++++- > programs/wscript/wscript.h | 2 ++ > 3 files changed, 32 insertions(+), 3 deletions(-) > +static const WCHAR* get_arg_beginning(const WCHAR* arg) +{ + const WCHAR *beg = arg; + while(*beg == '/' || *beg == '-') { + ++beg; + } + return beg; +} This won't do what you want it to. Jacek

1 0

Re: shell32: Fix cast in RecycleBinMenu_InvokeCommand
by Alexandre Julliard July 14, 2011

July 14, 2011

Jay Yang <jkelleyy(a)gmail.com> writes: > @@ -240,7 +240,7 @@ static HRESULT WINAPI RecycleBinMenu_InvokeCommand(IContextMenu2 *iface, > LPCSTR verb = pici->lpVerb; > if(!HIWORD(verb)) > { > - switch((UINT)verb) > + switch((UINT_PTR)verb) Actually the HIWORD() is more problematic. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32: Make ISFHelper_fnCopyItems actually copy the items (try 2)
by Alexandre Julliard July 14, 2011

July 14, 2011

Jay Yang <jkelleyy(a)gmail.com> writes: > Removed an unused variable. Still failing ("ret may be used uninitialized"). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] d3dx9_36: Added support for structs and arrays to ID3DXConstantTable (Try 2)
by Matteo Bruni July 14, 2011

July 14, 2011

2011/7/14 Travis Athougies <iammisc(a)gmail.com>: > Needed for Assassin's Creed Brotherhood and Dead Space 2. > > Changes from last patch: > - New way of distinguishing handles from strings > - Support for parent constants in ID3DXConstantTable::GetConstantByName and ID3DXConstantTable::GetConstant > - Implemented ID3DXContantTable::GetConstantElement > You should split the reworking of D3DXHANDLEs into a separate patch. GetConstantElement could be on its own patch too, probably.

1 0

Bad flag check
by Francois Gouget July 14, 2011

July 14, 2011

One of my scripts noticed that the following code does not make sense in dlls/winmm/waveform.c: static DWORD WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, DWORD_PTR param2) { if(info->flags & DCB_NULL) return MMSYSERR_NOERROR; That's because DCB_NULL is 0 so this condition is always false. What was the intent? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service

2 1

Fwd: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell July 14, 2011

July 14, 2011

Hi Stefan sorry for the duplicate email. I forgot to also send it to wine-devel. On Fri, Jun 17, 2011 at 12:02 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Thursday 16 June 2011 10:49:19 Michael Mc Donnell wrote: >> I've added the test you outlined. It shows you're correct that >> GetDeclaration only writes up to D3DDECL_END(). I've changed the >> implementation so that it caches the number of elements and only >> writes up to D3DDECL_END(). > Looks good to me. Great! >> You're right it could potentially read undefined memory depending on >> the compiler semantics. I think the safest thing is just to read up to >> D3DDECL_END() in the passed in declaration, then it will never read >> undefined memory (except if the programmer makes a mistake). > Looks good, but please write a WARN message in every case where you return an > error to the application. We believe that we handled the error condition > correctly, so there's no need for a FIXME, but the broken app behavior may > have been triggered by some other problem in Wine, so the message is more > important than a simple TRACE. Ok I've added WARN message for every case where it returns an error to the application. I've also reworded the WARN where it uses an invalid declaration but still must return D3D_OK.

4 36

Visual Studio project to compile the d3d code
by Stefan Dösinger July 14, 2011

July 14, 2011

Hi, After two people told me they might have use for my Visual Studio setup to compile wined3d I finally got around to put it on my git server. You can download it with GIT_SSL_NO_VERIFY=1 git clone https://84.112.174.163/~git/wined3d_vs What is this good for? My aims were to have Microsoft-Style debug symbols to use various Windows development tools. The also aim was to to work without Mingw, Msys or any other Unix tool besides git, mostly because mingw+msys is a pain. It performs an out-of-tree build of ddraw, d3d8, d3d9, the tests, wined3d and a few dependencies. Just put the files next to the wine sources, the project essentially loads the source files from ../wine/*. I also have d3dx9_36.dll in the project, but it doesn't link at the moment because d3dcompiler.dll is missing and some math functions. The testlist.c files for the tests cannot be autogenerated yet. The main issue is that this project is a stripped-down reimplementation of the wine build system. The source files and library exports are hardcoded, so if they change the msvc project needs manual adjustments. It would be much nicer to use the msvcmaker script for that, but I wasn't aware of this script when I started this. No additional software besides Visual Studio 2010 is needed, except for d3dx9_36 which needs the DirectX SDK. I just noticed that the d3d8 tests hardcode a path to the SDK sdk too, that is a bug that I can fix. I tried to compile the tests and d3d client libs with the MS headers to test our header compatibility but ran into some difficulties. The generated binaries also have no dependencies except the msvc2010 C runtime(msvcr100.dll) One word about licensing: I didn't find any obstacles that prevent personal use of MSVC Express, but please double-check the EULAs. Redistribution of Microsoft code is a problem however. The project setup doesn't deliberately include any MS code in the binaries, but it is possible that some functions from the C runtime is inlined, so to stay on the safe side I don't redistribute any binaries built from Visual Studio. There are a bunch of warnings left in the code. I fixed the warnings in wined3d.dll, d3d8.dll, d3d9.dll and the d3d8 tests, or silenced some warnings that I considered too pedantic or hard to fix. ddraw.dll, the ddraw tests and d3dx9 and the d3d9 tests have a number of legitimate warnings left. Stefan

2 5

Re: [PATCH 03/12] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 14, 2011

July 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12469 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout === W2K3R2SESP2 (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c000000d pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === WVISTAADM (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === W2K8SE (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === W7PRO (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 pipe.c:378: Test failed: IOAPC ran too early

1 0

Re: [PATCH 12/12] ntdll/tests: add some todo_wines to the new pipe test
by Marvin July 14, 2011

July 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12472 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/12] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Marvin July 14, 2011

July 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12471 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

New API functions for loading external dlls
by Saulius Krasuckas July 13, 2011

July 13, 2011

It seems MS announced three new functions yesterday: SetDefaultDllDirectories AddDllDirectory RemoveDllDirectory These are "to help developers correctly and securely load external libraries". [1] I remember some talk about SetDllDirectory() in the past [2], so now it's interesting how these two ways would coexist. Plus, could the new way help to simplify loading Gecko / XPCOM [3] by a chance? Probably not:) S. [1] http://support.microsoft.com/KB/2533623 [2] http://www.winehq.org/pipermail/wine-patches/2005-August/019625.html [3] http://source.winehq.org/source/dlls/mshtml/nsembed.c?v=wine-1.1.8#L144

1 0

Re: [PATCH 02/12] wscript: added helper function for tests
by Juan Lang July 12, 2011

July 12, 2011

Hi Michal, please combine this with patch 3, it doesn't make sense on its own. --Juan

1 0

Re: d3dx9_36: Provide a replacement for signbit() if it is missing.
by Alexandre Julliard July 12, 2011

July 12, 2011

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -292,6 +292,10 @@ ssize_t pwrite( int fd, const void *buf, size_t count, off_t offset ); > int readlink( const char *path, char *buf, size_t size ); > #endif /* HAVE_READLINK */ > > +#ifndef HAVE_SIGNBIT > +#define signbit(x) (copysign(1, (x)) < 0) > +#endif /* !defined(HAVE_SIGNBIT) */ This isn't quite correct for floats, and it's not much more portable. I'd suggest to fix the code instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke
by Nikolay Sivov July 12, 2011

July 12, 2011

On Tue, Jul 12, 2011 at 1:19 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke > + case DISPID_PICT_RENDER: + if (wFlags & DISPATCH_METHOD) + { + TRACE("DISPID_PICT_RENDER %d %d %d %d %d %d %d %d %d %d\n", + V_VT(&pDispParams->rgvarg[0]), V_VT(&pDispParams->rgvarg[1]), + V_VT(&pDispParams->rgvarg[2]), V_VT(&pDispParams->rgvarg[3]), + V_VT(&pDispParams->rgvarg[4]), V_VT(&pDispParams->rgvarg[5]), + V_VT(&pDispParams->rgvarg[6]), V_VT(&pDispParams->rgvarg[7]), + V_VT(&pDispParams->rgvarg[8]), V_VT(&pDispParams->rgvarg[9])); + + return IPicture_Render(&This->IPicture_iface, (HDC)V_I4(&pDispParams->rgvarg[9]), + V_I4(&pDispParams->rgvarg[8]), V_I4(&pDispParams->rgvarg[7]), + V_I4(&pDispParams->rgvarg[6]), V_I4(&pDispParams->rgvarg[5]), + V_I4(&pDispParams->rgvarg[4]), V_I4(&pDispParams->rgvarg[3]), + V_I4(&pDispParams->rgvarg[2]), V_I4(&pDispParams->rgvarg[1]), + (LPCRECT)&V_I4(&pDispParams->rgvarg[0])); + } + break; Correct me if I'm wrong, isn't it supposed to coerce arguments here? > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

RE: oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke
by wylda＠volny.cz July 12, 2011

July 12, 2011

Hi, isn't there a white space issue? (trailing) Regards, W.

1 0

Re: [PATCH 4/9 (try5)] winmm: Implement waveIn* on top of MMDevAPI
by Alexandre Julliard July 12, 2011

July 12, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/winmm/waveform.c | 622 > +++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 574 insertions(+), 48 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so capture.c && touch capture.ok wine: Unhandled page fault on write access to 0x00000018 at address 0x68e9a0ab (thread 0009), starting debugger... Unhandled exception: page fault on write access to 0x00000018 in 32-bit code (0x68e9a0ab). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68e9a0ab ESP:0032fc2c EBP:0032fc68 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:68ec468c ECX:00110064 EDX:00000000 ESI:0012c0f8 EDI:00128df0 Stack dump: 0x0032fc2c: 686a71ec 00128df0 00129c80 6869e7f0 0x0032fc3c: 686a71ec 00128df0 6869e7f0 0032fc68 0x0032fc4c: 00000000 00000001 6869ef24 0032fc78 0x0032fc5c: 686a71ec 00128df0 6869e7f0 0032fcc8 0x0032fc6c: 686864c1 00128df0 6869ef24 00000000 0x0032fc7c: 6869dbd5 00000002 00000000 00000000 Backtrace: =>0 0x68e9a0ab IDirectSoundCaptureImpl_Release+0xdb(iface=0x128df0) [/home/julliard/wine/wine/dlls/dsound/capture.c:1027] in dsound (0x0032fc68) 1 0x686864c1 IDirectSoundCapture_test+0x350(dsco=0x128df0, initialized=0, lpGuid=(nil)) [/home/julliard/wine/wine/dlls/dsound/tests/capture.c:175] in dsound_test (0x0032fcc8) 2 0x686881b1 func_capture+0x220() [/home/julliard/wine/wine/dlls/dsound/tests/capture.c:207] in dsound_test (0x0032fd38) 3 0x6869da3e run_test+0x14d(name="capture.c") [/home/julliard/wine/wine/dlls/dsound/tests/../../../include/wine/test.h:556] in dsound_test (0x0032fd88) 4 0x6869e507 main+0x156(argc=0xffffffff, argv=(nil)) [/home/julliard/wine/wine/dlls/dsound/tests/../../../include/wine/test.h:624] in dsound_test (0x0032fe48) 5 0x6869e6dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in dsound_test (0x0032fe90) 6 0x7b85ac4c call_process_entry+0xb() in kernel32 (0x0032fea8) 7 0x7b85bc4f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1087] in kernel32 (0x0032fee8) 8 0x7bc73908 call_thread_func+0xb() in ntdll (0x0032fef8) 9 0x7bc7706e call_thread_entry_point+0x6d(entry=0x7b85bbf0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffc8) 10 0x7bc4c16e start_process+0x1d(kernel_start=0x7b85bbf0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 11 0x6802996d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x68e9a0ab IDirectSoundCaptureImpl_Release+0xdb [/home/julliard/wine/wine/dlls/dsound/capture.c:1027] in dsound: movl $0x0,0x18(%eax) 1027 device->lock.DebugInfo->Spare[0] = 0; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dinput: BuildActionMap and SetActionMap stubs for generic joystick
by Michael Stefaniuc July 12, 2011

July 12, 2011

Hello Lucas, for the future please stop adding the LPJUNK for COM interfaces, e.g. LPDIRECTINPUTDEVICE8W, use IDirectInputDevice8W* instead. In addition to the normal issues with the LPJUNK it hides the fact that this are interfaces making it hard to review that the COM rules aren't violated. It also complicates my COM cleanup script to the point that I've started to automatically replace PJUNK and LPJUNK with IJunk*. thanks bye michael Lucas Fialho Zawacki wrote: > --- > dlls/dinput/joystick.c | 60 +++++++++++++++++++++++++++++++++++++ > dlls/dinput/joystick_linux.c | 8 ++-- > dlls/dinput/joystick_linuxinput.c | 8 ++-- > dlls/dinput/joystick_osx.c | 8 ++-- > dlls/dinput/joystick_private.h | 6 ++++ > 5 files changed, 78 insertions(+), 12 deletions(-) > > diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c > index 1be6f31..68dcc6a 100644 > --- a/dlls/dinput/joystick.c > +++ b/dlls/dinput/joystick.c > @@ -426,6 +426,66 @@ HRESULT WINAPI JoystickAGenericImpl_GetDeviceState(LPDIRECTINPUTDEVICE8A iface, > return JoystickWGenericImpl_GetDeviceState(IDirectInputDevice8W_from_impl(This), len, ptr); > } > > + > +HRESULT WINAPI JoystickWGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8W iface, > + LPDIACTIONFORMATW lpdiaf, > + LPCWSTR lpszUserName, > + DWORD dwFlags) > +{ > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > + > + return DI_NOEFFECT; > +} > + > +HRESULT WINAPI JoystickAGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8A iface, > + LPDIACTIONFORMATA lpdiaf, > + LPCSTR lpszUserName, > + DWORD dwFlags) > +{ > + JoystickGenericImpl *This = impl_from_IDirectInputDevice8A(iface); > + DIACTIONFORMATW diafW; > + HRESULT hr; > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = JoystickWGenericImpl_BuildActionMap(&This->base.IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + _copy_diactionformatWtoA(lpdiaf, &diafW); > + HeapFree(GetProcessHeap(), 0, diafW.rgoAction); > + > + return hr; > +} > + > +HRESULT WINAPI JoystickWGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface, > + LPDIACTIONFORMATW lpdiaf, > + LPCWSTR lpszUserName, > + DWORD dwFlags) > +{ > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > + > + return DI_NOEFFECT; > +} > + > +HRESULT WINAPI JoystickAGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface, > + LPDIACTIONFORMATA lpdiaf, > + LPCSTR lpszUserName, > + DWORD dwFlags) > +{ > + JoystickGenericImpl *This = impl_from_IDirectInputDevice8A(iface); > + DIACTIONFORMATW diafW; > + HRESULT hr; > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = JoystickWGenericImpl_SetActionMap(&This->base.IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + HeapFree(GetProcessHeap(), 0, diafW.rgoAction); > + > + return hr; > +} > + > /* > * This maps the read value (from the input event) to a value in the > * 'wanted' range. > diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c > index 5541522..3ad592d 100644 > --- a/dlls/dinput/joystick_linux.c > +++ b/dlls/dinput/joystick_linux.c > @@ -682,8 +682,8 @@ static const IDirectInputDevice8AVtbl JoystickAvt = > IDirectInputDevice2AImpl_SendDeviceData, > IDirectInputDevice7AImpl_EnumEffectsInFile, > IDirectInputDevice7AImpl_WriteEffectToFile, > - IDirectInputDevice8AImpl_BuildActionMap, > - IDirectInputDevice8AImpl_SetActionMap, > + JoystickAGenericImpl_BuildActionMap, > + JoystickAGenericImpl_SetActionMap, > IDirectInputDevice8AImpl_GetImageInfo > }; > > @@ -718,8 +718,8 @@ static const IDirectInputDevice8WVtbl JoystickWvt = > IDirectInputDevice2WImpl_SendDeviceData, > IDirectInputDevice7WImpl_EnumEffectsInFile, > IDirectInputDevice7WImpl_WriteEffectToFile, > - IDirectInputDevice8WImpl_BuildActionMap, > - IDirectInputDevice8WImpl_SetActionMap, > + JoystickWGenericImpl_BuildActionMap, > + JoystickWGenericImpl_SetActionMap, > IDirectInputDevice8WImpl_GetImageInfo > }; > > diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c > index c11edc7..afdee1e 100644 > --- a/dlls/dinput/joystick_linuxinput.c > +++ b/dlls/dinput/joystick_linuxinput.c > @@ -1417,8 +1417,8 @@ static const IDirectInputDevice8AVtbl JoystickAvt = > IDirectInputDevice2AImpl_SendDeviceData, > IDirectInputDevice7AImpl_EnumEffectsInFile, > IDirectInputDevice7AImpl_WriteEffectToFile, > - IDirectInputDevice8AImpl_BuildActionMap, > - IDirectInputDevice8AImpl_SetActionMap, > + JoystickAGenericImpl_BuildActionMap, > + JoystickAGenericImpl_SetActionMap, > IDirectInputDevice8AImpl_GetImageInfo > }; > > @@ -1453,8 +1453,8 @@ static const IDirectInputDevice8WVtbl JoystickWvt = > IDirectInputDevice2WImpl_SendDeviceData, > IDirectInputDevice7WImpl_EnumEffectsInFile, > IDirectInputDevice7WImpl_WriteEffectToFile, > - IDirectInputDevice8WImpl_BuildActionMap, > - IDirectInputDevice8WImpl_SetActionMap, > + JoystickWGenericImpl_BuildActionMap, > + JoystickWGenericImpl_SetActionMap, > IDirectInputDevice8WImpl_GetImageInfo > }; > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 439c8ad..756a682 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -972,8 +972,8 @@ static const IDirectInputDevice8AVtbl JoystickAvt = > IDirectInputDevice2AImpl_SendDeviceData, > IDirectInputDevice7AImpl_EnumEffectsInFile, > IDirectInputDevice7AImpl_WriteEffectToFile, > - IDirectInputDevice8AImpl_BuildActionMap, > - IDirectInputDevice8AImpl_SetActionMap, > + JoystickAGenericImpl_BuildActionMap, > + JoystickAGenericImpl_SetActionMap, > IDirectInputDevice8AImpl_GetImageInfo > }; > > @@ -1008,8 +1008,8 @@ static const IDirectInputDevice8WVtbl JoystickWvt = > IDirectInputDevice2WImpl_SendDeviceData, > IDirectInputDevice7WImpl_EnumEffectsInFile, > IDirectInputDevice7WImpl_WriteEffectToFile, > - IDirectInputDevice8WImpl_BuildActionMap, > - IDirectInputDevice8WImpl_SetActionMap, > + JoystickWGenericImpl_BuildActionMap, > + JoystickWGenericImpl_SetActionMap, > IDirectInputDevice8WImpl_GetImageInfo > }; > > diff --git a/dlls/dinput/joystick_private.h b/dlls/dinput/joystick_private.h > index a332e24..71d91f1 100644 > --- a/dlls/dinput/joystick_private.h > +++ b/dlls/dinput/joystick_private.h > @@ -86,4 +86,10 @@ HRESULT WINAPI JoystickWGenericImpl_Poll(LPDIRECTINPUTDEVICE8W iface) DECLSPEC_H > HRESULT WINAPI JoystickAGenericImpl_GetDeviceState(LPDIRECTINPUTDEVICE8A iface, DWORD len, LPVOID ptr) DECLSPEC_HIDDEN; > HRESULT WINAPI JoystickWGenericImpl_GetDeviceState(LPDIRECTINPUTDEVICE8W iface, DWORD len, LPVOID ptr) DECLSPEC_HIDDEN; > > +HRESULT WINAPI JoystickAGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8A iface, LPDIACTIONFORMATA lpdiaf, LPCSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > +HRESULT WINAPI JoystickWGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, LPCWSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > + > +HRESULT WINAPI JoystickAGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface, LPDIACTIONFORMATA lpdiaf, LPCSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > +HRESULT WINAPI JoystickWGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, LPCWSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > + > #endif /* __WINE_DLLS_DINPUT_JOYSTICK_PRIVATE_H */

1 0

Re: [PATCH] libv4l: Fixed videodev.h header moving away from glibc to libv4l-devel
by Alexandre Julliard July 12, 2011

July 12, 2011

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > As seen in openSUSE 12.1 development, <linux/videodev.h> is no longer, ioctls > come from the libv4l compat library. We should probably switch to version 2 instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Raw Input Patch Update 16
by Vincas Miliūnas July 12, 2011

July 12, 2011

This time submitting the full implementation to wine-devel and only the first patch to wine-patches. Changelog of the full implementation: * Rewritten test assertion messages to just state the reason of failure * Improved WM_INPUT posting, so it would be reflected using the GetQueueStatus function * Added proper GetRawInputBuffer implementation, that requires selecting and removing messages from the message queue, but that's how it works * Added releasing of allocated resources for raw input when destroying a process * Fixed DefRawInputProc to return -1 in case of an error instead of an error code. Also improved function's tests * Added tests and made RegisterRawInputDevices atomic, so there would be no changes if one of submitted registrations fails * Added tests to check for the correct GetQueueStatus(QS_RAWINPUT) status * Added tests to check for empty input queue before sending input using GetInputState * Tests of GetRegisteredRawInputDevices and RegisterRawInputDevices need to be paired and have both as a dependency, so split their tests into 4 parts to make smaller blocks of code * Moved raw input server request handlers to the bottom of the source file, like in the other files * Applied aligned formatting for groups of assignment statements * Other minor refactorings Zipped version - http://dl.dropbox.com/u/6901628/try16.zip Also I need to note the lack of applications that make extensive use of the raw input API. There are just a few games and they are convenient with just the mouse movement data.

2 1

Re: cmd/tests: Add test for parameter detection
by Marvin July 11, 2011

July 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12408 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter')

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Vitaliy Margolen July 11, 2011

July 11, 2011

On 07/08/2011 12:01 PM, Lucas Fialho Zawacki wrote: > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); You can use strcpyW instead. Or even lstrcpynW to guard against buffer overflow. > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) You need to modify ascii version of SetActionMap as well. Vitaliy.

1 0

build error in dlls/d3dx9_36/tests/math.c
by Marcus Meissner July 11, 2011

July 11, 2011

Hi, I get on dlls/d3dx9_36/tests/math.c: (Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev <misha680(a)gmail.com>) gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme nt -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -DLDAP_DEPRECATED=1 -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot ector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o mesh.o mesh.c math.c: In function 'test_D3DXFloat_Array': math.c:2251: error: 'INFINITY' undeclared (first use in this function) math.c:2251: error: (Each undeclared identifier is reported only once math.c:2251: error: for each function it appears in.) math.c:2253: error: 'NAN' undeclared (first use in this function) make[1]: *** [math.o] Error 1 NAN and INFINITY variables are ISO C 99 features and would need #define _ISOC99_SOURCE at the beginning of the source. Would such a patch be accepted? Or perhaps add 0.0/0.0 1.0/0.0 or similar constructs? Ciao, Marcus

4 3

Re: xlive preliminary implementation
by Damjan Jovanovic July 11, 2011

July 11, 2011

On Sat, Jul 9, 2011 at 10:24 AM, Giovanni Ongaro <giovanni.nicola(a)ticino.com> wrote: > Hi, i am a compuer scientist in the age of 46, > i have written a partial porting of xliveless to the wine git tree > adding the xlive dll. > > Right now it is in this state: > > Section 8 runs but does not save > > FUEL runs but does not save > > Red faction Guerrilla starts but i do not know if it saves > > Bulletstorm seems to save ok > > Batman Arkham Asylum runs and saves ok > > Street fighter 4 gives error after starting launcher > > Alarm for cobra 11 the syndicate does not start > > Fallout 3 runs and saves ok > > > > Your changes to dlls/xlive were not included in your patch, you probably forgot to do "git add dlls/xlive" first: --- configure | 777 ++++++++++++++++++++++++++++------------------------------ configure.ac | 1 + 2 files changed, 375 insertions(+), 403 deletions(-) Also you don't need to send changes to configure, only configure.ac. Otherwise thank you for your contribution. Damjan Jovanovic

1 0

Re: xmllite: Implement CreateXmlWriter
by Octavian Voicu July 11, 2011

July 11, 2011

On Sun, Jul 10, 2011 at 1:17 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Subject: [PATCH] Implement CreateXmlWriter ... > +/* > + * XMLLite IXmlReader tests > + * ... > +typedef struct _xmlreader > +{ > + IXmlWriter IXmlWriter_iface; > + LONG ref; > +} xmlwriter; Looks like you have some copy-paste errors (IXmlReader and _xmlreader). Cheers, Octavian

1 0

Some notes from wineconf about the 1.4 release -- are we on track?
by Scott Ritchie July 10, 2011

July 10, 2011

According to Alexandre... 1.4 will be out "sometime in 2011" At the time of wineconf we already had several new features: animated cursors, 64-bit Gecko, native cursor themes, AcceptEx support, mono packages Goals for the 1.4 release: Successful 64-bit make test Successful 32-bit make test ;) RTL support Transparency/compositing XInput2 USB support Audio redesign DIB Engine There were also these suggestions: Addons or plugins of some sort - eg a theme for GTK-grabbing Dosbox integration - possibly using Windows versions as add-on - get rid of Winedos code Plus, of course, the general goal of making more applications work :) It seems like we're making serious progress. Have any of these stalled or become less important? Has any new big feature not listed above been done that's worth listing? Is "sometime in 2011" still the best guess for 1.4's release? Thanks, Scott Ritchie

3 2

Re: d3dx9_36: Use cross-platform versions of infinity and NaN.
by Marvin July 9, 2011

July 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12221 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K3R2SESP2 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === WVISTAADM (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K8SE (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PRO (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PROX64 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18.

3 4

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 9, 2011

July 9, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -198,21 +1771,25 @@ UINT WINAPI waveOutGetErrorTextA(UINT uError, LPSTR lpText, UINT uSize) > */ > UINT WINAPI waveOutGetErrorTextW(UINT uError, LPWSTR lpText, UINT uSize) > { > - UINT ret = MMSYSERR_BADERRNUM; > - > - if (lpText == NULL) ret = MMSYSERR_INVALPARAM; > - else if (uSize == 0) ret = MMSYSERR_NOERROR; > - else if ( > - /* test has been removed because MMSYSERR_BASE is 0, and gcc did emit > - * a warning for the test was always true */ > - (/*uError >= MMSYSERR_BASE && */ uError <= MMSYSERR_LASTERROR) || > - (uError >= WAVERR_BASE && uError <= WAVERR_LASTERROR)) { > - if (LoadStringW(hWinMM32Instance, > - uError, lpText, uSize) > 0) { > - ret = MMSYSERR_NOERROR; > - } > - } > - return ret; > + TRACE("(%u, %p, %u)\n", uError, lpText, uSize); > + > + if(!WINMM_StartDevicesThread()) > + return MMSYSERR_ERROR; > + > + if(!lpText) > + return MMSYSERR_INVALPARAM; > + > + if(uSize == 0) > + return MMSYSERR_NOERROR; > + > + if(uError > MMSYSERR_LASTERROR || uError < WAVERR_BASE || > + uError > WAVERR_LASTERROR) > + return MMSYSERR_BADERRNUM; This doesn't do what you want (and that sort of change could easily be a separate patch). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/10] user32/tests: Added DefRawInputProc tests (try 15)
by Alexandre Julliard July 9, 2011

July 9, 2011

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> writes: > + ret = pDefRawInputProc(&input, 0, sizeof(RAWINPUTHEADER)); > + ok(ret == S_OK, "Given (&input, 0, sizeof), " > + "DefRawInputProc should acknowledge that no data was provided\n"); > +} That's not really testing anything. Also please avoid that sort of error message, describing the input is useless, it's just noise that is going to bitrot. A simple "DefRawInputProc returned %x" would be a lot more useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Lucas Zawacki July 8, 2011

July 8, 2011

I realized this patch and the next are wrong and don't work, despite the tests passing. No need to bother reading them. 2011/7/8 Lucas Fialho Zawacki <lfzawacki(a)gmail.com>: > --- > dlls/dinput/device.c | 22 ++++++++++++++++++++++ > dlls/dinput/device_private.h | 1 + > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5d81227..99c854c 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -953,6 +953,16 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, > TRACE("buffersize = %d\n", pd->dwData); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPDIPROPSTRING ps = (LPDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + if (strlenW(This->owner) == 0) return S_FALSE; > + > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); > + break; > + } > case (DWORD_PTR) DIPROP_VIDPID: > FIXME("DIPROP_VIDPID not implemented\n"); > return DIERR_UNSUPPORTED; > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) > { > + IDirectInputDeviceImpl *This = impl_from_IDirectInputDevice8W(iface); > DIPROPDWORD dp; > + DWORD username_size = MAX_PATH; > + WCHAR username[MAX_PATH]; > > FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > > + /* NULL username defaults to the logged user */ > + if (lpszUserName == NULL) > + { > + GetUserNameW(username, &username_size); > + lpszUserName = username; > + } > + > + memcpy(This->owner, lpszUserName, strlenW(lpszUserName)*sizeof(WCHAR)); > + > if (lpdiaf->dwBufferSize > 0) > { > dp.diph.dwSize = sizeof(DIPROPDWORD); > diff --git a/dlls/dinput/device_private.h b/dlls/dinput/device_private.h > index 503698a..6df8d93 100644 > --- a/dlls/dinput/device_private.h > +++ b/dlls/dinput/device_private.h > @@ -81,6 +81,7 @@ struct IDirectInputDeviceImpl > /* Action mapping */ > int num_actions; /* number of actions mapped */ > ActionMap *action_map; /* array of mappings */ > + WCHAR owner[MAX_PATH]; /* username of the device's owner */ > }; > > extern BOOL get_app_key(HKEY*, HKEY*) DECLSPEC_HIDDEN; > -- > 1.7.0.4 >

1 0

re: wined3d: Introduce quirk for proper RGBA16 support.
by Dan Kegel July 8, 2011

July 8, 2011

It seems to work... but in Mass Effect 2 Demo with the patch, the initial cinematics (where Shepard is trying to put out the fire, and you're prompted to answer "There's no time to argue", are very jerky, and CPU usage is very high. I didn't have that problem without the patch.

1 1

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 8, 2011

July 8, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static inline HWAVE WINMM_MakeHWAVE(UINT mmdevice, BOOL is_out, UINT device) > +{ > + return (HWAVE)((1 << 15) | ((!!is_out) << 14) | (mmdevice << 8) | device); > +} > + > +static inline void WINMM_DecomposeHWAVE(HWAVE hwave, UINT *mmdevice_index, > + BOOL *is_out, UINT *device_index, UINT *junk) > +{ > + *device_index = ((UINT)hwave & 0xFF); > + *mmdevice_index = ((UINT)hwave >> 8) & 0x3F; > + *is_out = ((UINT)hwave >> 14) & 0x1; > + *junk = (UINT)hwave >> 15; > +} This (and the same thing in various other places) will cause pointer conversion warnings on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix SETUPDI_OpenDrvKey
by Alexandre Julliard July 8, 2011

July 8, 2011

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > @@ -3728,8 +3728,13 @@ static HKEY SETUPDI_OpenDrvKey(struct DeviceInfo *devInfo, REGSAM samDesired) > WCHAR devId[10]; > > sprintfW(devId, fmt, devInfo->devId); > - RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > - RegCloseKey(classKey); > + l = RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > + if (!l) { > + RegCloseKey(classKey); > + } else { > + SetLastError(ERROR_KEY_DOES_NOT_EXIST); > + return INVALID_HANDLE_VALUE; > + } You are leaking the key now. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin (try 2)
by Alexandre Julliard July 8, 2011

July 8, 2011

Jay Yang <jkelleyy(a)gmail.com> writes: > +static void test_query_recyclebin(void) > +{ > + SHQUERYRBINFO info1={sizeof(info1),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; > + SHQUERYRBINFO info2={sizeof(info2),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; You can't use LL constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bug #2082
by Charles Welton July 8, 2011

July 8, 2011

This is one of the longest standing bugs which don't get much love from developers. Today I took some time with traces and wrote a test case which fails against git: http://bugs.winehq.org/attachment.cgi?id=35469 What is happening? When there's a child window to the ddraw window over it(the ddraw window), wined3d doesn't draw over the child. Windows, however, doesn't care about children and draws over them. Note that the DC is the same for both(according to traces). Not only that, the child window have different positions when in fullscreen or virtual desktop. As for the fix, I have yet to find the culprit dll(s) for this. Unfortunately I don't have the experience with wine's code and would like suggestions as to where to begin. -- Charles Welton

2 1

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)
by Juan Lang July 8, 2011

July 8, 2011

Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan

3 3

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin July 7, 2011

July 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin July 7, 2011

July 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin
by Marvin July 7, 2011

July 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12300 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu July 7, 2011

July 7, 2011

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -132,21 +132,21 @@ static void test_fileops( void ) > rewind(file); > for (i = 0, c = EOF; i < sizeof(outbuffer); i++) Isn't c = EOF in for initialization also a dead assignment? Octavian

2 1

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu July 7, 2011

July 7, 2011

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > c = outbuffer[sizeof(outbuffer) - 1]; > ok(ungetc(c, file) == c, "ungetc did not return its input for bufmode=%x\n", bufmodes[bufmode]); > ok(!feof(file), "feof after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > - ok((c = fgetc(file)) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > + ok(fgetc(file) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > ok(c == outbuffer[sizeof(outbuffer) - 1], > "getc did not return ungetc'd data for bufmode=%x\n", bufmodes[bufmode]); Also, this change doesn't look like it's removing a dead assignment, but it does make the test ok(c == outbuffer[sizeof(outbuffer) - 1], ...) always succeed. Octavian

2 1

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.
by Juan Lang July 7, 2011

July 7, 2011

Hi Jacek, > These are functions that I missed when revieweing Gecko headers. I will > probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much simpler that way. Right now, we have: current Wine + current gecko = crash By changing the calling convention in Wine, we have: Wine <= 1.3.23 + current gecko = crash Wine 1.3.24-?? + current gecko = no crash Wine ?? + current gecko = crash Wine ?? + new gecko = no crash Wine <= 1.3.23 + new gecko = crash By doing a new gecko release, we have: any Wine + current gecko = crash any Wine + new gecko = no crash --Juan

2 3

Re: [PATCH 1/2] kernel32: Fixes various 'profile' functions (profile.c). (try 3)
by Alexandre Julliard July 7, 2011

July 7, 2011

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > kernel32: Fixes various 'profile' functions. > Try 2: Formatting change. > Try 3: Splitted tests/profile.c patch You can't split it that way. What you need is to split each separate fix together with its own test fix. Also please use a subject message that describes what you are fixing, not just "fixes various functions". -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Nikolay Sivov July 7, 2011

July 7, 2011

On Thu, Jul 7, 2011 at 2:09 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > + ICreateTypeInfo2Impl *This = impl_from_ICreateTypeInfo2(iface); + + TRACE("(%p,%d), stub!\n", iface, dwHelpStringContext); It's not a stub anymore. + + This->typelib->typelib_header.helpcontext = dwHelpStringContext; Could you please get rid of this ugly naming here and use something like 'context' for variable. + + return S_OK; } > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: msxml3: Don't format xml output if we should be preserving whitespace.
by Marvin July 6, 2011

July 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12283 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WXPPROSP3 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WVISTAADM (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K8SE (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W7PRO (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root>

1 0

Re: kernel32: Fixes various 'profile' functions.
by André Hentschel July 6, 2011

July 6, 2011

spotted with a quick look on it: Am 06.07.2011 18:54, schrieb Christian Inci: > kernel32: Fixes various 'profile' functions. > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index a2bd5b5..da7661c 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -316,6 +316,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > PROFILESECTION **next_section; > PROFILEKEY *key, *prev_key, **next_key; > DWORD dwFileSize; > + BOOL no_section = TRUE; > > TRACE("%p\n", hFile); > > @@ -440,6 +441,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > next_section = &section->next; > next_key = &section->key; > prev_key = NULL; > + no_section = FALSE; formatting! > @@ -1179,6 +1183,7 @@ INT WINAPI GetPrivateProfileStringA( LPCSTR section, LPCSTR entry, > ret = len - 1; > } > buffer[ret] = 0; > + buffer[ret+1] = 0; > } really? -- Best Regards, André Hentschel

1 0

Re: ws2_32: Remove dead assignment (Clang)
by Marcus Meissner July 6, 2011

July 6, 2011

On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 4fc65ab..91aab01 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5874,7 +5874,7 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > { > case CF_ACCEPT: > if (addr && addrlen) > - addr = memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); > + memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); This is wrong. Keep the addrlen check. Ciao, Marcus

1 1

Re: shell32: Remove dead assignments (Clang)
by Nikolay Sivov July 6, 2011

July 6, 2011

2011/7/6 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shell32/shelllink.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c > index 07fe7aa..fff0e79 100644 > --- a/dlls/shell32/shelllink.c > +++ b/dlls/shell32/shelllink.c > @@ -1189,29 +1189,29 @@ static HRESULT WINAPI IPersistStream_fnSave( > Stream_WriteLocationInfo( stm, This->sPath, &This->volume ); > > if( This->sDescription ) > - r = Stream_WriteString( stm, This->sDescription ); > + Stream_WriteString( stm, This->sDescription ); > This is questionable. If you write to a provided stream it's ok for it to fail write operation, this needs a test. Method return value should probably reflect write failure.

1 0

Re: [PATCH] ntdll/tests: Added tests for ObjectTypeInformation class in NtQueryObject
by Vitaliy Margolen July 6, 2011

July 6, 2011

On 07/05/2011 07:20 PM, Austin Lund wrote: > + todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) + sizeof(WCHAR), "unexpected len %u\n", len ); What is that magic number "88"? If it's a size of some structure - then please use it explicitly. Vitaliy.

1 0

Re: [1/10] dinput: Implement IDirectInput::RunControlPanel.
by Vitaliy Margolen July 6, 2011

July 6, 2011

On 07/05/2011 06:18 AM, Andrew Nguyen wrote: > --- > dlls/dinput/dinput_main.c | 15 ++++++++- > dlls/dinput/tests/Makefile.in | 1 + > dlls/dinput/tests/dinput.c | 69 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 84 insertions(+), 1 deletions(-) > create mode 100644 dlls/dinput/tests/dinput.c Patches look good to me. Vitaliy.

1 0

Re: [PATCH 1/5] d3dx9_36: Implement D3DXHANDLE more robustly
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 23:45, Travis Athougies <iammisc(a)gmail.com> wrote: > Fixes bug 26583. > > Allows deadspace 2 to run without native dlls. This contains no useful information about what issue this is supposed to fix, unless you expect people to actually debug it themselves first. And I even went through the trouble to lookup the bug. > +static WORD new_handle_with_desc_and_name(ID3DXConstantTableImpl* This, D3DXCONSTANT_DESC* desc, LPCSTR name, LPCSTR full_name) > +{ > + ++This->handle_count; > + if (This->handles) > + This->handles = HeapReAlloc(GetProcessHeap(), 0, This->handles, sizeof(ctab_handle) * This->handle_count); > + else > + This->handles = HeapAlloc(GetProcessHeap(), 0, sizeof(ctab_handle) * This->handle_count); > + > + This->handles[This->handle_count - 1].desc = *desc; > + This->handles[This->handle_count - 1].desc.Name = strdup(name); > + This->handles[This->handle_count - 1].full_name = strdup(full_name); > + > + return This->handle_count; > +} That's just terrible.

1 0

Re: d3dx9_36: Push down the scope of two variables. (RESEND)
by Alexandre Julliard July 5, 2011

July 5, 2011

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This does not fix a bug or add a feature, but it makes the coder easier > to follow. Narrower scope tends to be a good thing for variables, both > for human readers and compilers (though modern ones should not need the > hint). Not necessarily, that's a matter of taste (IOW, not something you should "fix" in other people's code). -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH 1/2] d3dx9/line: Implement Begin and End methods. (try 2)
by Charles Welton July 5, 2011

July 5, 2011

Is there a reason why this patch and it's brother weren't merged in yet? This has been sitting for a few days and no comments about it yet. On 06/29/2011 07:08 PM, Charles Welton wrote: > Since the last patch spent some time without comments and wasn't > commited, I'm resending. > > Try 2 because of TRACE calls and whitespace fixes. > > --- > dlls/d3dx9_36/line.c | 73 > +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 69 insertions(+), 4 deletions(-) > > -- Charles Welton

2 1

Re: [4/9] msxml3: Implement IXMLDOMNodeList::QueryInterface(IEnumVARIANT).
by Nikolay Sivov July 5, 2011

July 5, 2011

On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > --- > dlls/msxml3/nodelist.c | 33 ++++++++++++++++++++++++++++++++- > dlls/msxml3/selection.c | 34 ++++++++++++++++++++++++++++++++-- > 2 files changed, 64 insertions(+), 3 deletions(-) > > + else if ( IsEqualGUID( riid, &IID_IEnumVARIANT ) ) + { + if (!This->enumv && + (This->enumv = create_nodelist_enum(&This->IXMLDOMNodeList_iface))) + IXMLDOMNodeList_Release(iface); /* create_nodelist_enum() adds a ref, and we don't here. */ + + if (!This->enumv) + { + *ppvObject = NULL; + return E_OUTOFMEMORY; + } + + IEnumVARIANT_AddRef(This->enumv); + *ppvObject = This->enumv; + return S_OK; + } Shouldn't this->enumv be protected somehow to work with multiple threads? I know that so called FreeThreaded* thing is only reported to be supported, but still. Maybe something like pointer exchange call will work.

2 1

Re: [PATCH] wscript: implemented Host_get_BuildVersion
by Paul Vriens July 5, 2011

July 5, 2011

On 07/04/2011 11:28 PM, Michał Ziętek wrote: > +ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = " + typeof(WScript.BuldVersion)); Patch is already committed but there is a typo here 'BuldVersion' instead of 'BuildVersion'. -- Cheers, Paul.

1 0

Re: winedevice: eliminate the driver_name global variable
by Alexandre Julliard July 5, 2011

July 5, 2011

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate the driver_name global variable > > This is part of general refactoring to make the driver loading code reusable. Have you fixed it since last time or is it the same patch? Either way it's still crashing. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 5, 2011

July 5, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static MMRESULT WINMM_SendDeviceThreadMessage(UINT msg, WPARAM wp) > +{ > + DWORD wait; > + MMRESULT res; > + > + EnterCriticalSection(&g_devthread_lock); > + > + if(!PostThreadMessageW(g_devthread_id, msg, wp, (DWORD_PTR)&res)){ > + ERR("PostThreadMessage failed: %d\n", GetLastError()); > + LeaveCriticalSection(&g_devthread_lock); > + return MMSYSERR_ERROR; > + } > + > + wait = WaitForSingleObject(g_devthread_evt, INFINITE); > + > + LeaveCriticalSection(&g_devthread_lock); If you are going to wait for a reply it would be better to create a HWND_MESSAGE window and do a SendMessage to it, then you get all the synchronization for free. -- Alexandre Julliard julliard(a)winehq.org

1 0

Glitch-free iTunes?
by Keith Curtis July 5, 2011

July 5, 2011

Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last I checked. I don't think iTunes has ever properly worked in WINE. It seems like Apple keep revising it and so the current WINE never works with the current iTunes. Can you make a goal of supporting iTunes with no glitches? I know many of you are volunteers, but it is globally efficient if the installation number plays into the priority of the bugs. Just this one app could be huge for Linux on the desktop. Warm regards, -Keith

9 12

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + if ((!texture && old_texture_type != GL_NONE) || (texture && texture->target != old_texture_type)) > + { Actually, just thought of this now, but I'm not sure you can do this like that. The way you're using old_texture_type it's context state, not device state.

1 0

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + TRACE("Dummy 2D texture %d given name %d.\n", i, device->dummyTextureName[i]); This is pretty minor, but those are unsigned.

1 0

Re: gdi32: Make GdiTransparentBlt clipping aware (try2)
by Alexandre Julliard July 5, 2011

July 5, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -392,6 +394,15 @@ BOOL WINAPI GdiTransparentBlt( HDC hdcDest, int xDest, int yDest, int widthDest, > hdcWork = CreateCompatibleDC(hdcDest); > bmpWork = CreateCompatibleBitmap(hdcDest, widthDest, heightDest); > oldWork = SelectObject(hdcWork, bmpWork); > + use_clip_rect = GetClipBox(hdcDest, &clip_rect); > + if(use_clip_rect) { > + clip_rect.left -= xDest; > + clip_rect.top -= yDest; > + clip_rect.right -= xDest; > + clip_rect.bottom -= yDest; > + IntersectClipRect(hdcWork, clip_rect.left, clip_rect.top, clip_rect.right, clip_rect.bottom); > + } You need to handle logical coordinates mapping. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wined3d: Don't apply and invalidate the framebuffer when clearing the device's fb (try 2)
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 10:27, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - /* TODO: This is not necessary if the framebuffer is the device's current framebuffer */ > - context_invalidate_state(context, STATE_FRAMEBUFFER, device->StateTable); But you do need to invalidate if it isn't.

1 0

Re: propkeydef.h: Fixed DEFINE_PROPERTYKEY define
by Alexandre Julliard July 5, 2011

July 5, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -33,18 +33,16 @@ > #ifdef INITGUID > #ifdef __cplusplus > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - EXTERN_C const PROPERTYKEY name = \ > + EXTERN_C const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - const PROPERTYKEY name = \ > + const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #endif > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY > + EXTERN_C const PROPERTYKEY name Do you really want to remove DECLSPEC_HIDDEN? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Misha Koshelev : d3dx9_36: Implement and add tests for D3DXFloat16To32Array .
by Michael Stefaniuc July 5, 2011

July 5, 2011

Hello Misha, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: a6b40624dbc457ba7b0b4b307b1eb88617c67197 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6b40624dbc457ba7b0b4b307… > > Author: Misha Koshelev <misha680(a)gmail.com> > Date: Wed Jun 29 11:16:29 2011 -0400 > > d3dx9_36: Implement and add tests for D3DXFloat16To32Array. > > --- > > dlls/d3dx9_36/d3dx9_36.spec | 2 +- > dlls/d3dx9_36/math.c | 32 +++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 93 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c > index 5ad1924..aa3f135 100644 > --- a/dlls/d3dx9_36/tests/math.c > +++ b/dlls/d3dx9_36/tests/math.c > @@ -2215,6 +2216,64 @@ static void test_D3DXVec_Array(void) ... > + { NAN, 0x7fff, 0x7fff, 131008.0f, 131008.0f }, > + { -NAN, 0xffff, 0xffff, -131008.0f, -131008.0f }, this breaks compilation on systems that don't have NAN. bye michael

1 0

Re: oleaut32: use the locale settings for digit group sizes
by Marvin July 5, 2011

July 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12210 Your paranoid android. === WNT4WSSP6 (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === WVISTAADM (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W2K8SE (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W7PRO (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789'

1 0

Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
by André Hentschel July 4, 2011

July 4, 2011

Am 04.07.2011 16:29, schrieb Vincas Miliūnas: > Changelog: Hi, even if you have 10 patches, maybe first try to get the tests in. Divide and Conquer! That's at least a bit less mess on wine-patches for now, and is easier for you and AJ i guess. -- Best Regards, André Hentschel

1 0

Re: [PATCH 10/10] server+user32: Added RIDEV_NOLEGACY raw input device flag implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12189 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 09/10] server+user32: Added GetRawInputData implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12188 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 08/10] user32: Added GetRawInputBuffer implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12187 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 07/10] server+user32: Added RegisterRawInputDevices implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12186 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0