July 2011 - Wine-Devel - list.winehq.org

Re: kernel32: Fixes various 'profile' functions.
by André Hentschel July 6, 2011

July 6, 2011

spotted with a quick look on it: Am 06.07.2011 18:54, schrieb Christian Inci: > kernel32: Fixes various 'profile' functions. > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index a2bd5b5..da7661c 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -316,6 +316,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > PROFILESECTION **next_section; > PROFILEKEY *key, *prev_key, **next_key; > DWORD dwFileSize; > + BOOL no_section = TRUE; > > TRACE("%p\n", hFile); > > @@ -440,6 +441,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > next_section = &section->next; > next_key = &section->key; > prev_key = NULL; > + no_section = FALSE; formatting! > @@ -1179,6 +1183,7 @@ INT WINAPI GetPrivateProfileStringA( LPCSTR section, LPCSTR entry, > ret = len - 1; > } > buffer[ret] = 0; > + buffer[ret+1] = 0; > } really? -- Best Regards, André Hentschel

1 0

Re: ws2_32: Remove dead assignment (Clang)
by Marcus Meissner July 6, 2011

July 6, 2011

On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 4fc65ab..91aab01 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5874,7 +5874,7 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > { > case CF_ACCEPT: > if (addr && addrlen) > - addr = memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); > + memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); This is wrong. Keep the addrlen check. Ciao, Marcus

1 1

Re: shell32: Remove dead assignments (Clang)
by Nikolay Sivov July 6, 2011

July 6, 2011

2011/7/6 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shell32/shelllink.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c > index 07fe7aa..fff0e79 100644 > --- a/dlls/shell32/shelllink.c > +++ b/dlls/shell32/shelllink.c > @@ -1189,29 +1189,29 @@ static HRESULT WINAPI IPersistStream_fnSave( > Stream_WriteLocationInfo( stm, This->sPath, &This->volume ); > > if( This->sDescription ) > - r = Stream_WriteString( stm, This->sDescription ); > + Stream_WriteString( stm, This->sDescription ); > This is questionable. If you write to a provided stream it's ok for it to fail write operation, this needs a test. Method return value should probably reflect write failure.

1 0

Re: [PATCH] ntdll/tests: Added tests for ObjectTypeInformation class in NtQueryObject
by Vitaliy Margolen July 5, 2011

July 5, 2011

On 07/05/2011 07:20 PM, Austin Lund wrote: > + todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) + sizeof(WCHAR), "unexpected len %u\n", len ); What is that magic number "88"? If it's a size of some structure - then please use it explicitly. Vitaliy.

1 0

Re: [1/10] dinput: Implement IDirectInput::RunControlPanel.
by Vitaliy Margolen July 5, 2011

July 5, 2011

On 07/05/2011 06:18 AM, Andrew Nguyen wrote: > --- > dlls/dinput/dinput_main.c | 15 ++++++++- > dlls/dinput/tests/Makefile.in | 1 + > dlls/dinput/tests/dinput.c | 69 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 84 insertions(+), 1 deletions(-) > create mode 100644 dlls/dinput/tests/dinput.c Patches look good to me. Vitaliy.

1 0

Re: [PATCH 1/5] d3dx9_36: Implement D3DXHANDLE more robustly
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 23:45, Travis Athougies <iammisc(a)gmail.com> wrote: > Fixes bug 26583. > > Allows deadspace 2 to run without native dlls. This contains no useful information about what issue this is supposed to fix, unless you expect people to actually debug it themselves first. And I even went through the trouble to lookup the bug. > +static WORD new_handle_with_desc_and_name(ID3DXConstantTableImpl* This, D3DXCONSTANT_DESC* desc, LPCSTR name, LPCSTR full_name) > +{ > + ++This->handle_count; > + if (This->handles) > + This->handles = HeapReAlloc(GetProcessHeap(), 0, This->handles, sizeof(ctab_handle) * This->handle_count); > + else > + This->handles = HeapAlloc(GetProcessHeap(), 0, sizeof(ctab_handle) * This->handle_count); > + > + This->handles[This->handle_count - 1].desc = *desc; > + This->handles[This->handle_count - 1].desc.Name = strdup(name); > + This->handles[This->handle_count - 1].full_name = strdup(full_name); > + > + return This->handle_count; > +} That's just terrible.

1 0

Re: d3dx9_36: Push down the scope of two variables. (RESEND)
by Alexandre Julliard July 5, 2011

July 5, 2011

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This does not fix a bug or add a feature, but it makes the coder easier > to follow. Narrower scope tends to be a good thing for variables, both > for human readers and compilers (though modern ones should not need the > hint). Not necessarily, that's a matter of taste (IOW, not something you should "fix" in other people's code). -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH 1/2] d3dx9/line: Implement Begin and End methods. (try 2)
by Charles Welton July 5, 2011

July 5, 2011

Is there a reason why this patch and it's brother weren't merged in yet? This has been sitting for a few days and no comments about it yet. On 06/29/2011 07:08 PM, Charles Welton wrote: > Since the last patch spent some time without comments and wasn't > commited, I'm resending. > > Try 2 because of TRACE calls and whitespace fixes. > > --- > dlls/d3dx9_36/line.c | 73 > +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 69 insertions(+), 4 deletions(-) > > -- Charles Welton

2 1

Re: [4/9] msxml3: Implement IXMLDOMNodeList::QueryInterface(IEnumVARIANT).
by Nikolay Sivov July 5, 2011

July 5, 2011

On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > --- > dlls/msxml3/nodelist.c | 33 ++++++++++++++++++++++++++++++++- > dlls/msxml3/selection.c | 34 ++++++++++++++++++++++++++++++++-- > 2 files changed, 64 insertions(+), 3 deletions(-) > > + else if ( IsEqualGUID( riid, &IID_IEnumVARIANT ) ) + { + if (!This->enumv && + (This->enumv = create_nodelist_enum(&This->IXMLDOMNodeList_iface))) + IXMLDOMNodeList_Release(iface); /* create_nodelist_enum() adds a ref, and we don't here. */ + + if (!This->enumv) + { + *ppvObject = NULL; + return E_OUTOFMEMORY; + } + + IEnumVARIANT_AddRef(This->enumv); + *ppvObject = This->enumv; + return S_OK; + } Shouldn't this->enumv be protected somehow to work with multiple threads? I know that so called FreeThreaded* thing is only reported to be supported, but still. Maybe something like pointer exchange call will work.

2 1

Re: [PATCH] wscript: implemented Host_get_BuildVersion
by Paul Vriens July 5, 2011

July 5, 2011

On 07/04/2011 11:28 PM, Michał Ziętek wrote: > +ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = " + typeof(WScript.BuldVersion)); Patch is already committed but there is a typo here 'BuldVersion' instead of 'BuildVersion'. -- Cheers, Paul.

1 0

Re: winedevice: eliminate the driver_name global variable
by Alexandre Julliard July 5, 2011

July 5, 2011

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate the driver_name global variable > > This is part of general refactoring to make the driver loading code reusable. Have you fixed it since last time or is it the same patch? Either way it's still crashing. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 5, 2011

July 5, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static MMRESULT WINMM_SendDeviceThreadMessage(UINT msg, WPARAM wp) > +{ > + DWORD wait; > + MMRESULT res; > + > + EnterCriticalSection(&g_devthread_lock); > + > + if(!PostThreadMessageW(g_devthread_id, msg, wp, (DWORD_PTR)&res)){ > + ERR("PostThreadMessage failed: %d\n", GetLastError()); > + LeaveCriticalSection(&g_devthread_lock); > + return MMSYSERR_ERROR; > + } > + > + wait = WaitForSingleObject(g_devthread_evt, INFINITE); > + > + LeaveCriticalSection(&g_devthread_lock); If you are going to wait for a reply it would be better to create a HWND_MESSAGE window and do a SendMessage to it, then you get all the synchronization for free. -- Alexandre Julliard julliard(a)winehq.org

1 0

Glitch-free iTunes?
by Keith Curtis July 5, 2011

July 5, 2011

Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last I checked. I don't think iTunes has ever properly worked in WINE. It seems like Apple keep revising it and so the current WINE never works with the current iTunes. Can you make a goal of supporting iTunes with no glitches? I know many of you are volunteers, but it is globally efficient if the installation number plays into the priority of the bugs. Just this one app could be huge for Linux on the desktop. Warm regards, -Keith

9 12

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + if ((!texture && old_texture_type != GL_NONE) || (texture && texture->target != old_texture_type)) > + { Actually, just thought of this now, but I'm not sure you can do this like that. The way you're using old_texture_type it's context state, not device state.

1 0

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + TRACE("Dummy 2D texture %d given name %d.\n", i, device->dummyTextureName[i]); This is pretty minor, but those are unsigned.

1 0

Re: gdi32: Make GdiTransparentBlt clipping aware (try2)
by Alexandre Julliard July 5, 2011

July 5, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -392,6 +394,15 @@ BOOL WINAPI GdiTransparentBlt( HDC hdcDest, int xDest, int yDest, int widthDest, > hdcWork = CreateCompatibleDC(hdcDest); > bmpWork = CreateCompatibleBitmap(hdcDest, widthDest, heightDest); > oldWork = SelectObject(hdcWork, bmpWork); > + use_clip_rect = GetClipBox(hdcDest, &clip_rect); > + if(use_clip_rect) { > + clip_rect.left -= xDest; > + clip_rect.top -= yDest; > + clip_rect.right -= xDest; > + clip_rect.bottom -= yDest; > + IntersectClipRect(hdcWork, clip_rect.left, clip_rect.top, clip_rect.right, clip_rect.bottom); > + } You need to handle logical coordinates mapping. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wined3d: Don't apply and invalidate the framebuffer when clearing the device's fb (try 2)
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 10:27, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - /* TODO: This is not necessary if the framebuffer is the device's current framebuffer */ > - context_invalidate_state(context, STATE_FRAMEBUFFER, device->StateTable); But you do need to invalidate if it isn't.

1 0

Re: propkeydef.h: Fixed DEFINE_PROPERTYKEY define
by Alexandre Julliard July 5, 2011

July 5, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -33,18 +33,16 @@ > #ifdef INITGUID > #ifdef __cplusplus > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - EXTERN_C const PROPERTYKEY name = \ > + EXTERN_C const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - const PROPERTYKEY name = \ > + const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #endif > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY > + EXTERN_C const PROPERTYKEY name Do you really want to remove DECLSPEC_HIDDEN? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Misha Koshelev : d3dx9_36: Implement and add tests for D3DXFloat16To32Array .
by Michael Stefaniuc July 5, 2011

July 5, 2011

Hello Misha, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: a6b40624dbc457ba7b0b4b307b1eb88617c67197 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6b40624dbc457ba7b0b4b307… > > Author: Misha Koshelev <misha680(a)gmail.com> > Date: Wed Jun 29 11:16:29 2011 -0400 > > d3dx9_36: Implement and add tests for D3DXFloat16To32Array. > > --- > > dlls/d3dx9_36/d3dx9_36.spec | 2 +- > dlls/d3dx9_36/math.c | 32 +++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 93 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c > index 5ad1924..aa3f135 100644 > --- a/dlls/d3dx9_36/tests/math.c > +++ b/dlls/d3dx9_36/tests/math.c > @@ -2215,6 +2216,64 @@ static void test_D3DXVec_Array(void) ... > + { NAN, 0x7fff, 0x7fff, 131008.0f, 131008.0f }, > + { -NAN, 0xffff, 0xffff, -131008.0f, -131008.0f }, this breaks compilation on systems that don't have NAN. bye michael

1 0

Re: oleaut32: use the locale settings for digit group sizes
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12210 Your paranoid android. === WNT4WSSP6 (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === WVISTAADM (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W2K8SE (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W7PRO (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789'

1 0

Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
by André Hentschel July 4, 2011

July 4, 2011

Am 04.07.2011 16:29, schrieb Vincas Miliūnas: > Changelog: Hi, even if you have 10 patches, maybe first try to get the tests in. Divide and Conquer! That's at least a bit less mess on wine-patches for now, and is easier for you and AJ i guess. -- Best Regards, André Hentschel

1 0

Re: [PATCH 10/10] server+user32: Added RIDEV_NOLEGACY raw input device flag implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12189 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 09/10] server+user32: Added GetRawInputData implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12188 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 08/10] user32: Added GetRawInputBuffer implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12187 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 07/10] server+user32: Added RegisterRawInputDevices implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12186 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0