July 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 06/10] server+user32: Added GetRegisteredRawInputDevices implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12185 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 05/10] user32: Added GetRawInputDeviceInfoA implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12184 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 04/10] server+user32: Added GetRawInputDeviceInfoW implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12183 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 03/10] server+user32: Added GetRawInputDeviceList implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12182 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12181 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Random crashes while running (cmd) test runner
by Frédéric Delanoy July 4, 2011

July 4, 2011

Hi folks, I'm in the process of writing a couple of cmd tests (on top of master, not of my currently pending patches), and I at times have problems where none of the tests is actually performed, but the test suite still returns without any error indication, e.g. batch.c:306: running TEST_BUILTINS.CMD test... batch: 7 tests executed (0 marked as todo, 0 failures), 0 skipped. which many more tests should be performed After checking with "winedbg --gdb" it gets a SIGSEGV I tried to reproduce with a mimimal output file and expected file, and get weird results. Say you have the following files: test_builtins.cmd @echo off echo should fail <empty line> and test_builtins.cmd.exp dir <empty line> When I run make testclean && make test in programs/cmd/tests, I get the following (first line of .exp file executed somehow...) batch.c:215: Test failed: unexpected char 0x73 position 0 in line 1 (got 'should fail', wanted 'dir') batch.c:227: Test failed: too long output, got additional Volume Serial Number is 0000-0000 Directory of Z:\path\to\wine\programs\cmd\tests 2/07/2011 20:56 <DIR> . 2/07/2011 14:34 <DIR> .. 2/07/2011 2:34 11,074 batch.c <...> batch: 14 tests executed (0 marked as todo, 2 failures), 0 skipped. If I run "/wine winedbg --gdb programs/cmd/tests/cmd.exe_test.exe.so" and run (c)ont, I get a SIGSEGV: Program received signal SIGSEGV, Segmentation fault. 0x7bc481f2 in HEAP_MakeInUseBlockFree (subheap=0x110014, pArena=0x1106a8) at heap.c:640 640 size += (pFree->size & ARENA_SIZE_MASK) + sizeof(ARENA_FREE); Full backtrace: #0 0x7bc481f2 in HEAP_MakeInUseBlockFree (subheap=0x110014, pArena=0x1106a8) at heap.c:640 #1 0x7bc4b7f5 in RtlFreeHeap (heap=0x110000, flags=2, ptr=0x1106b0) at heap.c:1757 #2 0x7bc6ed27 in RtlFreeUnicodeString (str=0x33f8fc) at rtlstr.c:319 #3 0x7b83f06c in CreateFileW (filename=0x7ffd8c00, access=1073741824, sharing=0, sa=0x0, creation=2, attributes=128, template=0x0) at file.c:1421 #4 0x7b83f14a in CreateFileA (filename=0x7effd262 "test.cmd", access=1073741824, sharing=0, sa=0x0, creation=2, attributes=128, template=0x0) at file.c:1443 #5 0x7effaf5a in run_cmd (cmd_data=0x110688 "@echo off\necho should fail\n\n\ndirb", cmd_size=34) at batch.c:68 #6 0x7effb9f4 in run_test (cmd_data=0x7efff52c "@echo off\necho should fail\n\n\ndir\n\n", cmd_size=28, exp_data=0x7efff548 "\ndir\n\n", exp_size=6) at batch.c:239 #7 0x7effbe46 in test_enum_proc (module=0x7eff0000, type=0x7effd4ab "TESTCMD", name=0x110668 "TEST_BUILTINS.CMD", param=0) at batch.c:317 #8 0x7b86d748 in EnumResourceNamesA (hmod=0x7eff0000, type=0x7effd4ab "TESTCMD", lpfun=0x7effbd43 <test_enum_proc>, lparam=0) at resource.c:345 #9 0x7effc008 in func_batch () at batch.c:353 #10 0x7effcc92 in run_test (name=0x7effd745 "batch") at ../../../include/wine/test.h:556 #11 0x7effd057 in main (argc=1, argv=0x1103e0) at ../../../include/wine/test.h:616 #12 0x7effd136 in __wine_spec_exe_entry (peb=0x7ffdf000) at exe_entry.c:36 #13 0x7b860008 in call_process_entry () at process.c:1035 #14 0x7b86014f in start_process (peb=0x7ffdf000) at process.c:1087 #15 0x7bc7f22c in call_thread_func () at signal_i386.c:2473 #16 0x7bc7f26a in call_thread_entry_point (entry=0x7b86000a <start_process>, arg=0x7ffdf000) at signal_i386.c:2499 #17 0x7bc542cf in start_process (kernel_start=0x7b86000a) at loader.c:2612 #18 0xf7609b95 in wine_call_on_stack () at port.c:60 #19 0xf7609b73 in wine_switch_to_stack (func=0x7bc542a9 <start_process>, arg=0x7b86000a, stack=0x340000) at port.c:59 Backtrace stopped: previous frame inner to this frame (corrupt stack?) Does anyone know what's going wrong exactly? Frédéric Note: wine-1.3.23-164-ge18c15d compiled with "-O0 -g" on Natty x86_64

4 6

Re: [1/6] wined3d: rename the rt mask generation functions (try 2)
by Stefan Dösinger July 4, 2011

July 4, 2011

Hi Alexandre, Please don't apply those patches yet, I just noticed that they cause some issues with backbuffer offscreen rendering. Thanks, Stefan On Saturday 02 July 2011 11:57:22 Stefan Dösinger wrote: > This patch is unmodified, patch 2 moves the bulk of the new code into > context.c rather than state.c to reduce the number of functions exported in > wined3d_private.h

1 0

Re: uuid: Add CLSID_DestinationList
by Jacek Caban July 4, 2011

July 4, 2011

Hi André, On 07/03/11 13:35, André Hentschel wrote: > --- > dlls/uuid/uuid.c | 1 + > include/shobjidl.idl | 2 ++ > 2 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index d4ad2ae..0ad0425 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -123,6 +123,7 @@ DEFINE_GUID(CLSID_TF_CategoryMgr, 0xA4B544A1,0x438D,0x4B41,0x93,0x25,0x8 > DEFINE_GUID(CLSID_TF_LangBarMgr, 0xebb08c45,0x6c4a,0x4fdc,0xae,0x53,0x4e,0xb8,0xc4,0xc7,0xdb,0x8e); > DEFINE_GUID(CLSID_TF_DisplayAttributeMgr, 0x3ce74de4,0x53d3,0x4d74,0x8b,0x83,0x43,0x1b,0x38,0x28,0xba,0x53); > DEFINE_GUID(CLSID_TaskbarList, 0x56fdf344,0xfd6d,0x11d0,0x95,0x8a,0x00,0x60,0x97,0xc9,0xa0,0x90); > +DEFINE_GUID(CLSID_DestinationList, 0x77f10cf0,0x3db5,0x4966,0xb5,0x20,0xb7,0xc5,0x4f,0xd3,0x5e,0xd6); > DEFINE_GUID(GUID_TFCAT_TIP_KEYBOARD, 0x34745c63,0xb2f0,0x4784,0x8b,0x67,0x5e,0x12,0xc8,0x70,0x1a,0x31); > DEFINE_GUID(GUID_TFCAT_TIP_SPEECH, 0xB5A73CD1,0x8355,0x426B,0xA1,0x61,0x25,0x98,0x08,0xF2,0x6B,0x14); > DEFINE_GUID(GUID_TFCAT_TIP_HANDWRITING, 0x246ecb87,0xc2f2,0x4abe,0x90,0x5b,0xc8,0xb3,0x8a,0xdd,0x2c,0x43); > diff --git a/include/shobjidl.idl b/include/shobjidl.idl > index 1b4d385..8b6b735 100644 > --- a/include/shobjidl.idl > +++ b/include/shobjidl.idl > @@ -3293,6 +3293,8 @@ interface ICustomDestinationList : IUnknown > HRESULT AbortList(); > } > > +cpp_quote("EXTERN_C const CLSID CLSID_DestinationList;") > + > /***************************************************************************** > * ShellObjects typelibrary > */ This should be declared as coclass in shobjidl.idl, it's part of my recent patch. Jacek

1 0

Re: [PATCH] advapi32: Set *lpSize properly in GetUserNameA (try2)
by Marcus Meissner July 4, 2011

July 4, 2011

On Sat, Jul 02, 2011 at 11:49:44AM +0300, Alex Stanev wrote: > > --- > dlls/advapi32/advapi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/advapi32/advapi.c b/dlls/advapi32/advapi.c > index e135fa5..7025a21 100644 > --- a/dlls/advapi32/advapi.c > +++ b/dlls/advapi32/advapi.c > @@ -65,7 +65,7 @@ GetUserNameA( LPSTR lpszName, LPDWORD lpSize ) > > ret = GetUserNameW( buffer, &sizeW ); > if (ret) > - WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); > + *lpSize = WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); > else > *lpSize = sizeW; For completeness, the else part also needs to convert the wide character cound in "sizeW" to the A character cound in *lpSize. Not sure how though. Ciao, Marcus

1 0

WyldBOT 1 & 2 updated
by wylda＠volny.cz July 3, 2011

July 3, 2011

Hi, 6 months passed so i updated images for these two machines (Description + Windows update + nvidia drivers in case of WyldBOT1). And this new nVidia v275.33 driver brings new failures in dlls/ddraw/tests/visual.c: visual.c:1503: Test failed: Got color 000000d8, expected 00000080 or near visual.c:1625: Test failed: Got color 00b000cf, expected 008000ff or near visual.c:1745: Test failed: Got color 00d80000, expected 00800000 or near The above is diff of the following links: Old nVidia driver v260.99: http://test.winehq.org/data/5758d748971d300f77b05ab245d870696c44132c/xp_Wyl… New nVidia driver v275.33: http://test.winehq.org/data/5758d748971d300f77b05ab245d870696c44132c/xp_Wyl… Regards, W.

1 0

Re: [6/6] wined3d: Don't apply and invalidate the framebuffer when clearing the device's fb
by Henri Verbeet July 3, 2011

July 3, 2011

On 2 July 2011 11:59, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (isStateDirty(context, STATE_FRAMEBUFFER) || fb != &device->fb) This is probably never an issue in practice, but you're ignoring rt_count here.

1 0

Traces with threading
by Erich Hoover July 3, 2011

July 3, 2011

Rather than rooting around for a while I figured I should ask first, is there a quick and easy way to get all TRACE/FIXME commands to output the thread id? I'm trying to track down an issue where one of a pair of threads locks up and it'd be really nice to quickly identify which one is doing what. Erich Hoover ehoover(a)mines.edu

2 2

Re: Updated Clang static analysis results / Valgrind update
by Vincas Miliūnas July 3, 2011

July 3, 2011

> On Sun, Jul 3, 2011 at 04:15, Austin English <austinenglish at gmail.com <http://www.winehq.org/mailman/listinfo/wine-devel>> wrote: > >/ Web space usage was getting a bit high, so I've uploaded a tarball to > />/ a file download service: > />/ http://www.sendspace.com/file/5hot36 > />/ > />/ austin at aw21 <http://www.winehq.org/mailman/listinfo/wine-devel> ~ $ sha1sum scan-build-2011-07-02.tar.bz2 > />/ ac3cb3920ef97641fff1f5376f8136cef01f15bf scan-build-2011-07-02.tar.bz2 > / > FWIW, you could use xz instead of bzip2 to further reduce the download > size (54 MiB) > I got the size down to 46 MiB using default settings, and 25 MiB using > max compression (xz -9) > > Frédéric I have heard about he xz compressor, so I was interested on how 7zip and xz perform maxed-out: 7z a -t7z -m0=lzma -mx=9 -mfb=255 -md=256m -ms=on scan-build-2011-07-02-1.7z scan-build-2011-07-02-1 11.87MiB - 12445530 scan-build-2011-07-02-1.7z xz -zkc -Fxz -9e -M5GB --lzma2='dict=256Mi,nice=273,mf=bt4' scan-build-2011-07-02-1.tar > scan-build-2011-07-02-1.xz 12.14MiB - 12726004 scan-build-2011-07-02-1.xz I didn't measure time, but it wasn't very long; xz took longer, because it doesn't support multithreading. Both required 3.5GB of memory at the peek.

2 2

Re: kernel32/tests: remove a few CloseHandle calls on a HMODULE that don't make any sense
by Marvin July 3, 2011

July 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12163 Your paranoid android. === WNT4WSSP6 (32 bit module) === module.c:356: Test failed: Expected ERROR_FILE_NOT_FOUND, got 1006

2 1

Re: Random crashes while running (cmd) test runner [update backtrace]
by Frédéric Delanoy July 3, 2011

July 3, 2011

#0 0x7bc481f2 in HEAP_MakeInUseBlockFree (subheap=0x110014, pArena=0x1106a8) at heap.c:640 #1 0x7bc4b7f5 in RtlFreeHeap (heap=0x110000, flags=2, ptr=0x1106b0) at heap.c:1757 #2 0x7bc38b12 in read_directory_stat (fd=13, io=0x33dbd0, buffer=0x1116c8, length=8192, single_entry=0 '\000', mask=0x1116ac, restart_scan=1 '\001', class=FileBothDirectoryInformation) at directory.c:1936 #3 0x7bc38f3b in NtQueryDirectoryFile (handle=0x24, event=0x0, apc_routine=0, apc_context=0x0, io=0x33dbd0, buffer=0x1116c8, length=8192, info_class=FileBothDirectoryInformation, single_entry=0 '\000', mask=0x1116ac, restart_scan=1 '\001') at directory.c:2012 #4 0x7b8400aa in FindFirstFileExW (filename=0x33dccc, level=FindExInfoStandard, data=0x33e4cc, search_op=FindExSearchNameMatch, filter=0x0, flags=0) at file.c:1864 #5 0x7b840a69 in FindFirstFileW (lpFileName=0x33dccc, lpFindData=0x33e4cc) at file.c:2083 #6 0x7b859ba6 in GetLongPathNameW (shortpath=0x33ee68, longpath=0x33e780, longlen=260) at path.c:362 #7 0x7b861765 in create_startup_info (filename=0x33ee68, cmdline=0x111348, cur_dir=0x0, env=0x0, flags=0, startup=0x33f928, info_size=0x33ea40) at process.c:1595 #8 0x7b86256c in create_process (hFile=0x20, filename=0x33ee68, cmd_line=0x111348, env=0x0, cur_dir=0x0, psa=0x0, tsa=0x0, inherit=1, flags=0, startup=0x33f928, info=0x33fa3c, unixdir=0x111540 "/home/fred/.wine-tmp/dosdevices/z:/home/fred/sources/wine-git", binary_info=0x33f070, exec_only=0) at process.c:1926 #9 0x7b8638b0 in create_process_impl (app_name=0x33f1a8, cmd_line=0x111348, process_attr=0x0, thread_attr=0x0, inherit=1, flags=0, env=0x0, cur_dir=0x0, startup_info=0x33f928, info=0x33fa3c) at process.c:2274 #10 0x7b864175 in CreateProcessW (app_name=0x33f1a8, cmd_line=0x111348, process_attr=0x0, thread_attr=0x0, inherit=1, flags=0, env=0x0, cur_dir=0x0, startup_info=0x33f928, info=0x33fa3c) at process.c:2388 #11 0x7b862f95 in create_cmd_process (filename=0x33f628, cmd_line=0x111328, env=0x0, cur_dir=0x0, psa=0x0, tsa=0x0, inherit=1, flags=0, startup=0x33f928, info=0x33fa3c) at process.c:2100 #12 0x7b863c71 in create_process_impl (app_name=0x0, cmd_line=0x111328, process_attr=0x0, thread_attr=0x0, inherit=1, flags=0, env=0x0, cur_dir=0x0, startup_info=0x33f928, info=0x33fa3c) at process.c:2305 #13 0x7b864068 in CreateProcessA (app_name=0x0, cmd_line=0x33fa73 "test.cmd", process_attr=0x0, thread_attr=0x0, inherit=1, flags=0, env=0x0, cur_dir=0x0, startup_info=0x33f9f8, info=0x33fa3c) at process.c:2368 #14 0x7effb19e in run_cmd (cmd_data=0x110688 "@echo off\necho should fail\n\ndir\n\022", cmd_size=33) at batch.c:95 #15 0x7effb9f4 in run_test (cmd_data=0x7efff52c "@echo off\necho should fail\n\ndir\n\n", cmd_size=28, exp_data=0x7efff548 "dir\n\n", exp_size=5) at batch.c:239 #16 0x7effbe46 in test_enum_proc (module=0x7eff0000, type=0x7effd4ab "TESTCMD", name=0x110668 "TEST_BUILTINS.CMD", param=0) at batch.c:317 #17 0x7b86d748 in EnumResourceNamesA (hmod=0x7eff0000, type=0x7effd4ab "TESTCMD", lpfun=0x7effbd43 <test_enum_proc>, lparam=0) at resource.c:345 #18 0x7effc008 in func_batch () at batch.c:353 #19 0x7effcc92 in run_test (name=0x7effd745 "batch") at ../../../include/wine/test.h:556 #20 0x7effd057 in main (argc=1, argv=0x1103e0) at ../../../include/wine/test.h:616 #21 0x7effd136 in __wine_spec_exe_entry (peb=0x7ffdf000) at exe_entry.c:36 #22 0x7b860008 in call_process_entry () at process.c:1035 #23 0x7b86014f in start_process (peb=0x7ffdf000) at process.c:1087 #24 0x7bc7f22c in call_thread_func () at signal_i386.c:2473 #25 0x7bc7f26a in call_thread_entry_point (entry=0x7b86000a <start_process>, arg=0x7ffdf000) at signal_i386.c:2499 #26 0x7bc542cf in start_process (kernel_start=0x7b86000a) at loader.c:2612 #27 0xf75c0b95 in wine_call_on_stack () at port.c:60 #28 0xf75c0b73 in wine_switch_to_stack (func=0x7bc542a9 <start_process>, arg=0x7b86000a, stack=0x340000) at port.c:59

1 0

Re: user32: check for the file signature before load a cursor/icon from it (try2)
by Nikolay Sivov July 2, 2011

July 2, 2011

On Sat, Jul 2, 2011 at 4:29 PM, Vitaly Perov <vitperov(a)etersoft.ru> wrote: > It fix crash in the russian accounting application "CheckXML+" > > -- > Best regards, > Vitaly Perov > This patch needs a test I think.

1 0

wine bug 27600
by wylda＠volny.cz July 2, 2011

July 2, 2011

Hi Vincas, i wanted to give bug 27600 a try. So on top of wine-1.3.23-50-g2497a91 i applied patches: 1. 75818 2. 75819 3. 75831 4. 75830 5. 75829 6. 75820 7. 75821 8. 75822 9. 75823 but i end up with failure during the buildup: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-stric t-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogi cal-op -g -O0 -o input.o input.c input.c: In function ‘GetRawInputDeviceList’: input.c:495: error: ‘union generic_request’ has no member named ‘get_raw_input_device_list_request’ input.c:495: error: ‘union generic_reply’ has no member named ‘get_raw_input_device_list_reply’ Regards, W. -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz

5 24

copy/paste bug in imm32: Test and fix ImmIsUIMessageA/W?
by wylda＠volny.cz July 1, 2011

July 1, 2011

Hi, i guess you know my programming skill, so be nice to me if total nonsence: if ( ... || ... + (msg == WM_IME_SELECT) || + (msg == WM_IME_SELECT) || ... seem to redundant. It happens it two places. Regards, W.

1 0

Re: [2/6] wined3d: Move FBO application into a state handler
by Henri Verbeet July 1, 2011

July 1, 2011

On 1 July 2011 18:49, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I put the code that used to be in context_apply_draw_state into state.c > because the FBO stuff is now a state handler. The alternative would be to keep > it in context.c and just export one function - that means we don't need the rt > mask functions in wined3d_private.h > That's probably nicer.

2 1

Re: [PATCH] advapi32: Set *lpSize properly in GetUserNameA (resend)
by Alexandre Julliard July 1, 2011

July 1, 2011

Alex Stanev <alex(a)stanev.org> writes: > - ret = GetUserNameW( buffer, &sizeW ); > + ret = GetUserNameW( buffer, lpSize ); > if (ret) > - WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); > - else > - *lpSize = sizeW; > + *lpSize = WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); This is wrong, you can't use the W result as the A buffer size. -- Alexandre Julliard julliard(a)winehq.org

1 0

try to open *.doc files with explorer.exe
by Vitaly Perov July 1, 2011

July 1, 2011

Windows can open *.doc files with command $explorer example.doc Several applications (for example russian accounting application "1C") use this command. Wine can't do it. I have prepared a patch to fix this bug. It works, but it seems a little bit hacky now. Please, help me to implement it correctly. -- Best regards, Vitaly Perov

1 0