July 2011 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Updated Clang static analysis results / Valgrind update
by Austin English Dec. 5, 2011

Dec. 5, 2011

Web space usage was getting a bit high, so I've uploaded a tarball to a file download service: http://www.sendspace.com/file/5hot36 austin(a)aw21 ~ $ sha1sum scan-build-2011-07-02.tar.bz2 ac3cb3920ef97641fff1f5376f8136cef01f15bf scan-build-2011-07-02.tar.bz2 to use, just extract and open in your favorite browser: $ firefox index.html this was run against Clang from svn: clang version 3.0 (trunk 134320) Please send me any false positives that you'd like me to report upstream. Cheers, Austin P.S. For those of you wanting Valgrind results, I'm currently hitting a nasty Valgrind bug, waiting on upstream to fix: https://bugs.kde.org/show_bug.cgi?id=275673 (Thanks to Andrew N for finding the faulty commit)

4 7

Re: [patch] Support NULL puLen in VerQueryValue
by Andrew Nguyen Oct. 15, 2011

Oct. 15, 2011

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQueryValue with NULL puLen.

3 2

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell Aug. 25, 2011

Aug. 25, 2011

Dear Wine developers, I would like implement some of the missing mesh functions in Wine's D3DX9 for Google Summer of Code 2011. I would like to implement the following functions: - CloneMesh - CloneMeshFVF - ConvertPointRepsToAdjacency - ConvertAdjacencyToPointReps - GenerateAdjacency They seem to be suitable in size to implement during a summer, and I have a good idea of how to implement them. I expect to first implement tests and then implement the functions. I am a masters student at the Technical University of Denmark nearing the end of my studies, and I have specialized in 3D computer graphics, studying both real-time and physically based techniques, as well as how to use existing 3D modeling tools to create animations. The mesh functions should be fairly straight forward for me to implement as I have recently taken an advanced course on geometry processing which involved a lot of mesh manipulation. I have, furthermore, already tests (for a shell32 function) in the wine test suite so I have some knowledge of Wine development. Roderick Coldenbrander is listed as a possible mentor for "Direct3D - Implement missing D3D9_xx DLLs" on the wiki. Are you still interested, or would someone else like to be a mentor? Regards, Michael Mc Donnell

9 50

gsoc mentor summit
by Stefan Dösinger Aug. 24, 2011

Aug. 24, 2011

Hi, The gsoc mentor summit organizing is getting started. Do any fellow mentors want to travel there? http://gsoc-wiki.osuosl.org/index.php/2011 Stefan PS: I vaguely remember that we once had a separate mailing list for gsoc stuff like that, but I can't find it, only Dan Kegel's old wine-gsoc-2007 list.

4 6

Listed package maintainers
by Ben Klein Aug. 17, 2011

Aug. 17, 2011

Hello everyone, For those of you who remember all the trouble I've had with my health, I'm on the mend now. I'm adjusting to some new medication that's doing wonders, and also adjusting to the new lifestyle they allow me to lead. I've just had a look at http://www.winehq.org/download, as I'm well out-of-date with Wine, and I see Maurilio and I are still listed as being the maintainers for the Debian packages, even though Kai Wasserbäch has taken over that duty (and thank you Kai for doing so!) I also notice the pages have been renamed (so instead of deb = ubuntu, ubuntu and debian are named correctly and unambiguously). I would like to voice my approval as former maintainer of the Debian packages, as token as that may seem at this stage. Kind regards, Ben

3 4

Wine Gecko 1.3-beta1
by Jacek Caban Aug. 14, 2011

Aug. 14, 2011

Hi all, I've just uploaded a new Wine Gecko beta package. It's a bit earlier than we usually updated the package, but it's part of the plan. The last release was the most successful ever - we've successfully avoided regressions and fixed existing bugs. The fact that we had long (over month) beta period and that the release was made based on stable Firefox release helped a lot IMO. We can improve stability of Gecko package by releasing more often, meaning less changes are included in each single release. We can do this thanks to Mozilla rapid release cycles, that gives us a chance to release Wine Gecko based on the very recent code base, stabilized by Mozilla every six weeks. Six weeks releases are, however, more than we can handle and more than we need, so my current plan is to release every two Firerox version (that is every 12 weeks), with no pressure. Back to current release, it's mostly an update of code base to keep on track with Gecko changes. Builds are available, as usually, on sourceforge [1]. To test it, you also need the attached patch to Wine. Any help with testing is appreciated. Everything that uses MSHTML in any way is worth testing. Informations for packages interested in building the package themselves: My builds are done with GCC 4.5.3, but any GCC newer than 4.5.1 should be good. There was a fix to Mozilla code needed for GCC 4.6.* builds that I've included in the source, so GCC 4.6 32-bit builds should be fine. If you want to use it for 64-bit builds, please test it carefully as I wasn't able to test them (linking GCC 4.6 builds consumes awfully lot of memory, so it failed for me). Cheers, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.3-beta1/

1 1

Re: wined3d: Only update the sampler map when needed
by Henri Verbeet Aug. 11, 2011

Aug. 11, 2011

On 26 July 2011 22:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (state < gl_info->limits.fragment_samplers) > + if (state < gl_info->limits.combined_samplers) This looks like it should be a separate change. > + device->fixed_function_usage_map = 0xff; This looks questionable, it will cause unused textures to be loaded.

2 1

bugzilla: merge OS X/Windows OS versions
by Austin English Aug. 8, 2011

Aug. 8, 2011

This was mentioned a while back, though I can't find the reference on wine-devel, perhaps it was in #winehackers... Anyway, would anyone be opposed to merging the Mac OS X versions (and possibly the Windows versions) in the OS field in Bugzilla? We don't differentiate any other OS, and for Windows, there are very few bugs filed anyway (mostly against the test suite or building on cygwin). So, instead of: Windows 3.1 Windows 95 Windows 98 Windows ME Windows 2000 Windows NT Windows XP Windows Vista Mac OS X 10.2 Mac OS X 10.3 Mac OS X 10.4 Mac OS X 10.5 Mac OS X 10.6 We'd have: Windows (All versions) Mac OS X I meant to do this a while ago, but forgot, and http://bugs.winehq.org/show_bug.cgi?id=27930 reminded me -- -Austin

2 2

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

re: GSoC: dinput8 Action Mapping
by Dan Kegel Aug. 2, 2011

Aug. 2, 2011

Lucas asked: > Should I correct the tabs and align the > parameters in the function prototype when I implement them? If you do a significant rewrite of a function, or are implementing it for the first time, I think it's ok to use more standard code style in your new code, or to update the style of adjacent old code (like a prototype) related to your change.

7 28

NtQuerySystemInformation needs a little bit more flesh for SystemProcessorPerformanceInformation
by Paul Vriens Aug. 1, 2011

Aug. 1, 2011

Hi, I was trying out the latest SysInternals Process Explorer and it struck me that the overall CPU % stayed at 0. Adding some values to the sppi structure fixed this but I'm just wondering what values to use: sppi[cpus-1].Reserved1[0].QuadPart = (ULONGLONG)remainder[0] * 10000000 / clk_tck; This Reserved1[0] is the DPC Time but I'm wondering what values from /proc/stat to use here (remainder[0] is I/O wait). We could always make up something of course but being accurate would be nicer. -- Cheers, Paul.

2 2

Re: ddraw: Do not increase wined3d texture refcount in IDirect3DDevice7_GetTexture.
by Stefan Dösinger July 31, 2011

July 31, 2011

On Friday 29 July 2011 17:17:45 Ričardas Barkauskas wrote: > This makes it behave like similar place in d3d8. The subject is confusing, otherwise it looks OK.

1 0

Winhelp crash in assertion(0) if .hlp file is not found
by Bruno Jesus July 31, 2011

July 31, 2011

Hello, I've been in the list for a long time as a reader and after years I finally managed to get a development computer and restarted playing with current wine git. There are about 15 bugs on bugzilla but none of them are related to this. I'm trying the list first before opening a bug. It's quite simple to reproduce, although I'm not sure if I can attach the hlp file here since it's from windows. The crash happens because the help file needs another help file. There is a button on the screen called Glossary that needs a file called glossary.hlp. If this file does not exist wine asks me to point it, if I answer No or yes and then cancel file selection wine crashes on an assert. The following lines are displayed on the console: fixme:winhelp:WINHELP_GetWindowInfo Couldn't find window info for glossary winhelp.c:270: WINHELP_GetWindowInfo: Assertion `0' failed. wine: Assertion failed at address 0xb78f0424 (thread 003b), starting debugger... The following lines are from file winhelp.c, around line 270. ... if (strcmp(name, "main") != 0) { WINE_FIXME("Couldn't find window info for %s\n", name); assert(0); return NULL; } ... The function WINHELP_OpenHelpWindow does not resist WINHELP_GetWindowInfo returning NULL. That was why the assert(0) was added inside it to abort the program execution (as far as I see). There are 3 calls like this (one on winhelp.c and the others on macro.c): ... WINHELP_OpenHelpWindow(HLPFILE_PageByHash, hlpfile, lHash, WINHELP_GetWindowInfo(hlpfile, wndname), show); ... My approach to fix this is quite simple: instead of splitting the above lines on different places and add a check for each of them the easier way is to simply make OpenHelpWindow resist null pointers and do not open anything because the user was already warned and asked for the nonexistent file. The proposed solution (if I may call adding one "if" a solution) is attached. If anyone has the problematic hlp file that was the cause to add the assert(0) please send me. Looks like the assert is there since wine 1.0 according to http://source.winehq.org/source/programs/winhlp32/winhelp.c?v=wine-1.0 Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

2 4

Re: [PATCH 1/5] mshtml: Added semi-stub implementation of IHTMLWindow2::status property
by Marvin July 31, 2011

July 31, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13084 Your paranoid android. === WVISTAADM (32 bit dom) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: mshtml: Added semi-stub implementation of IHTMLWindow2::status property
by Jacek Caban July 31, 2011

July 31, 2011

Please ignore this one. I will send proper version with other mshtml patches. Thanks, Jacek

1 0

Re: [1/2] cmd/tests: Add FOR /D tests (try 2)
by Octavian Voicu July 30, 2011

July 30, 2011

2011/7/29 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > +rem for /d %%i in (ba*) do echo %%i>> tmp > +rem sort < tmp > +rem del tmp I believe you can also use this syntax [put for instruction in parentheses, add | sort at the end]: (for ... ...) | sort Btw, it's a horrible hack, but until you'll have a wine sort you can test with (for ... ...) | Z:\usr\bin\sort :) Octavian

2 2

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)
by Paul Vriens July 29, 2011

July 29, 2011

On 07/29/2011 01:29 AM, Octavian Voicu wrote: > + else > + win_skip("Not on WOW64, skipping test.\n"); Why a win_skip()? Isn't a normal skip() more appropriate? -- Cheers, Paul.

2 1

Re: [PATCH 8/9] wscript: implemented Host_get_Application (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13007 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 7/9] wscript: implemented Host_put_Interactive (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13006 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 6/9] wscript: implemented Host_get_Interactive (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13005 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 5/9] wscript: implemented Arguments2_get_length (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13004 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 4/9] wscript: implemented Arguments2_Count (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13003 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 2/9] wscript: added arguments.c; implemented Host_get_Arguments (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13001 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 1/2] winmm: Trivial code simplifications and fixes.
by Henri Verbeet July 29, 2011

July 29, 2011

On 29 July 2011 09:46, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > these fixes all trivial errors I mentioned recently but one, plus a few ones I discovered since then. > These need to be separate patches, of course. I'd also encourage everyone to just use git send-email for sending patches.

2 2

Re: patch for dlls/gdi32/dib.c: fixes crash
by Octavian Voicu July 29, 2011

July 29, 2011

On Wed, Jul 27, 2011 at 6:44 PM, Wolfgang Walter <wine(a)stwm.de> wrote: > - char src_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > - BITMAPINFO *src_info = (BITMAPINFO *)src_bmibuf; > - char dst_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > - BITMAPINFO *dst_info = (BITMAPINFO *)dst_bmibuf; There's another instance of that in GetDIBits. Allocating 2KB+ (2 x 1064 bytes) of data on the stack is not very reasonable I guess. Octavian

3 3

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches
by Alexandre Julliard July 29, 2011

July 29, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, > > if (wait_handle) > { > - NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > - status = io->u.Status; > + status = NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > + if (status == STATUS_USER_APC) > + { > + async->interrupted = TRUE; > + status = STATUS_CANCELLED; /* not really, the ioctl completes and event and the handle > + itself get signaled */ > + } This looks wrong. You can't claim it was cancelled if it's still running. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/7] cmd/tests: Add FOR /D tests
by Alexandre Julliard July 29, 2011

July 29, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > programs/cmd/tests/test_builtins.cmd | 6 ++++++ > programs/cmd/tests/test_builtins.cmd.exp | 11 +++++++++++ > 2 files changed, 17 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok batch.c:239: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 225 (got 'baz', wanted 'baz') make: *** [batch.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

ancient email messages being sent, or at least archived, again?
by Dan Kegel July 29, 2011

July 29, 2011

What's with messages like http://www.winehq.org/pipermail/wine-bugs/2011-July/285020.html ?

2 1

Re: Nvidia GeForce GTX560 Ti detection fix
by Henri Verbeet July 28, 2011

July 28, 2011

On 28 July 2011 22:46, <gwen(a)derpymail.com> wrote: > This patch fixes the problem that a GeForce GTX560 Ti GPU is not being > detected in current build. (http://bugs.winehq.org/show_bug.cgi?id=27924) > The change itself looks reasonable enough, though I don't have the hardware to verify the strings. Please use git to generate patches though, and include proper author information. See also http://wiki.winehq.org/SubmittingPatches.

1 0

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2)
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12984 Your paranoid android. === WVISTAADM (32 bit shlfolder) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Don't treat a button as a dialog (valgrind)
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12982 Your paranoid android. === WNT4WSSP6 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2KPROSP4 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === WXPPROSP3 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2K3R2SESP2 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === WVISTAADM (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2K8SE (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PRO (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PROX64 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PROX64 (64 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON

1 0

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths.
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android. === WNT4WSSP6 (32 bit shlfolder) === Timeout === W2KPROSP4 (32 bit shlfolder) === Timeout

1 0

Re: ieframe: Moved ie.c tests to ieframe
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12968 Your paranoid android. === WNT4WSSP6 (32 bit ie) === ie.c:62: Test failed: Could not create InternetExplorer instance: 80040154 ie: unhandled exception c0000005 at 004012F2

2 1

Re: ieframe: Moved ie.c tests to ieframe
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12967 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Bug status transitions ~ bug 27908
by wylda＠volny.cz July 28, 2011

July 28, 2011

Hi, there is bug 27908, which i closed as invalid, because user did not used latest fixed version. AJ says: If there was a bug then it's FIXED. Based on that, even if the user has a crash in 1.0.1 and opens _now_ a bug and one day later says "it is FIXED in 1.3.25", then it should be marked as FIXED. Because i noticed before, that this is handled differently, i'm writing here about above rule, which unify that. Regards, W. -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.cz si zajisté vyberete.

3 2

Re: [PATCH 7/8] wscript: implemented Host_get_Application (resend)
by Marvin July 27, 2011

July 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12934 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 6/8] wscript: implemented Host_put_Interactive (resend)
by Marvin July 27, 2011

July 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12933 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 5/8] wscript: implemented Host_get_Interactive (resend)
by Marvin July 27, 2011

July 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12932 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 4/8] wscript: implemented Arguments2_get_length (resend)
by Marvin July 27, 2011

July 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12931 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 3/8] wscript: implemented Arguments2_Count (resend)
by Marvin July 27, 2011

July 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12930 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 1/8] wscript: added arguments.c; implemented Host_get_Arguments (try 2)
by Marvin July 27, 2011

July 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12928 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Wine and ALSA hw:0, plug:hw, "default" devices, what's the target?
by Joerg-Cyril.Hoehle＠t-systems.com July 27, 2011

July 27, 2011

Hi, I've never seen a documentation of what Wine expects from the ALSA/OSS/CoreAudio device. - A bare bones "hw:0" device with all its restrictions, e.g. stereo 16bit only? As Wine provides no mixer, this would disallow playing multiple sounds concurrently (bug #NN) on most current sound cards. Some people seem to setup Wine via the registry to use that. - "plug:hw" which can convert 8bit mono to 16bit stereo and provides resampling? (I forgot about the difference with "plughw") - The "dmix" device, which only supports a single rate (typically 48000, see /usr/share/alsa/alsa.conf:defaults.pcm.dmix.rate), accepts only 32bit int(!) samples and restricts #channels like hw:0? This allows to open multiple devices. - The "plug:dmix" device, which chains a resampler and converter with dmix so that it can accept any PCM format? - "pulse", which like "plug:dmix" accepts any PCM format? - "default", which presumably maps to either plug:dmix or pulse so as to accept any PCM format and open multiple devices? It seems obvious Wine needs something as flexible as "pulse" or "plug:dmix" (pure "dmix" won't fit because Wine and apps don't cope well with the 32 bits samples requirement). Does mmdevapi change the equation, happy with dmix instead of plug:dmix as long as both rates are the same? Given that, can't Wine delegate more to the OS? It seems quite stupid to e.g. write a resampler for Wine when ALSA and MacOS' Coreaudio already include one. (On MacOS, couldn't mmdevapi map more to MacOS' audio filter chains?) What's the point of Winealsa's mmdevapi code iterating through ALSA's hw:N devices? IMHO only CoreAudio EXCLUSIVE mode can make use of them. It's a no-no for SHAREDMODE. Or is the plan to be really happy with exclusive access to hw:0 (preventing non Wine apps from doing audio!?!) and implement in Wine's mmdevapi a true mixer as well as a high quality resampler for SHAREDMODE with RATEADJUST and WINMM needs? Who can shed some light? Regards, Jörg Höhle

1 0