July 2011 - Wine-Devel - list.winehq.org

Re: cmd/tests: Add test for parameter detection
by Marvin July 11, 2011

July 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12408 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter')

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Vitaliy Margolen July 11, 2011

July 11, 2011

On 07/08/2011 12:01 PM, Lucas Fialho Zawacki wrote: > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); You can use strcpyW instead. Or even lstrcpynW to guard against buffer overflow. > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) You need to modify ascii version of SetActionMap as well. Vitaliy.

1 0

build error in dlls/d3dx9_36/tests/math.c
by Marcus Meissner July 11, 2011

July 11, 2011

Hi, I get on dlls/d3dx9_36/tests/math.c: (Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev <misha680(a)gmail.com>) gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme nt -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -DLDAP_DEPRECATED=1 -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot ector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o mesh.o mesh.c math.c: In function 'test_D3DXFloat_Array': math.c:2251: error: 'INFINITY' undeclared (first use in this function) math.c:2251: error: (Each undeclared identifier is reported only once math.c:2251: error: for each function it appears in.) math.c:2253: error: 'NAN' undeclared (first use in this function) make[1]: *** [math.o] Error 1 NAN and INFINITY variables are ISO C 99 features and would need #define _ISOC99_SOURCE at the beginning of the source. Would such a patch be accepted? Or perhaps add 0.0/0.0 1.0/0.0 or similar constructs? Ciao, Marcus

4 3

Re: xlive preliminary implementation
by Damjan Jovanovic July 10, 2011

July 10, 2011

On Sat, Jul 9, 2011 at 10:24 AM, Giovanni Ongaro <giovanni.nicola(a)ticino.com> wrote: > Hi, i am a compuer scientist in the age of 46, > i have written a partial porting of xliveless to the wine git tree > adding the xlive dll. > > Right now it is in this state: > > Section 8 runs but does not save > > FUEL runs but does not save > > Red faction Guerrilla starts but i do not know if it saves > > Bulletstorm seems to save ok > > Batman Arkham Asylum runs and saves ok > > Street fighter 4 gives error after starting launcher > > Alarm for cobra 11 the syndicate does not start > > Fallout 3 runs and saves ok > > > > Your changes to dlls/xlive were not included in your patch, you probably forgot to do "git add dlls/xlive" first: --- configure | 777 ++++++++++++++++++++++++++++------------------------------ configure.ac | 1 + 2 files changed, 375 insertions(+), 403 deletions(-) Also you don't need to send changes to configure, only configure.ac. Otherwise thank you for your contribution. Damjan Jovanovic

1 0

Re: xmllite: Implement CreateXmlWriter
by Octavian Voicu July 10, 2011

July 10, 2011

On Sun, Jul 10, 2011 at 1:17 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Subject: [PATCH] Implement CreateXmlWriter ... > +/* > + * XMLLite IXmlReader tests > + * ... > +typedef struct _xmlreader > +{ > + IXmlWriter IXmlWriter_iface; > + LONG ref; > +} xmlwriter; Looks like you have some copy-paste errors (IXmlReader and _xmlreader). Cheers, Octavian

1 0

Some notes from wineconf about the 1.4 release -- are we on track?
by Scott Ritchie July 10, 2011

July 10, 2011

According to Alexandre... 1.4 will be out "sometime in 2011" At the time of wineconf we already had several new features: animated cursors, 64-bit Gecko, native cursor themes, AcceptEx support, mono packages Goals for the 1.4 release: Successful 64-bit make test Successful 32-bit make test ;) RTL support Transparency/compositing XInput2 USB support Audio redesign DIB Engine There were also these suggestions: Addons or plugins of some sort - eg a theme for GTK-grabbing Dosbox integration - possibly using Windows versions as add-on - get rid of Winedos code Plus, of course, the general goal of making more applications work :) It seems like we're making serious progress. Have any of these stalled or become less important? Has any new big feature not listed above been done that's worth listing? Is "sometime in 2011" still the best guess for 1.4's release? Thanks, Scott Ritchie

3 2

Re: d3dx9_36: Use cross-platform versions of infinity and NaN.
by Marvin July 9, 2011

July 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12221 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K3R2SESP2 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === WVISTAADM (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K8SE (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PRO (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PROX64 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18.

3 4

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 9, 2011

July 9, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -198,21 +1771,25 @@ UINT WINAPI waveOutGetErrorTextA(UINT uError, LPSTR lpText, UINT uSize) > */ > UINT WINAPI waveOutGetErrorTextW(UINT uError, LPWSTR lpText, UINT uSize) > { > - UINT ret = MMSYSERR_BADERRNUM; > - > - if (lpText == NULL) ret = MMSYSERR_INVALPARAM; > - else if (uSize == 0) ret = MMSYSERR_NOERROR; > - else if ( > - /* test has been removed because MMSYSERR_BASE is 0, and gcc did emit > - * a warning for the test was always true */ > - (/*uError >= MMSYSERR_BASE && */ uError <= MMSYSERR_LASTERROR) || > - (uError >= WAVERR_BASE && uError <= WAVERR_LASTERROR)) { > - if (LoadStringW(hWinMM32Instance, > - uError, lpText, uSize) > 0) { > - ret = MMSYSERR_NOERROR; > - } > - } > - return ret; > + TRACE("(%u, %p, %u)\n", uError, lpText, uSize); > + > + if(!WINMM_StartDevicesThread()) > + return MMSYSERR_ERROR; > + > + if(!lpText) > + return MMSYSERR_INVALPARAM; > + > + if(uSize == 0) > + return MMSYSERR_NOERROR; > + > + if(uError > MMSYSERR_LASTERROR || uError < WAVERR_BASE || > + uError > WAVERR_LASTERROR) > + return MMSYSERR_BADERRNUM; This doesn't do what you want (and that sort of change could easily be a separate patch). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/10] user32/tests: Added DefRawInputProc tests (try 15)
by Alexandre Julliard July 9, 2011

July 9, 2011

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> writes: > + ret = pDefRawInputProc(&input, 0, sizeof(RAWINPUTHEADER)); > + ok(ret == S_OK, "Given (&input, 0, sizeof), " > + "DefRawInputProc should acknowledge that no data was provided\n"); > +} That's not really testing anything. Also please avoid that sort of error message, describing the input is useless, it's just noise that is going to bitrot. A simple "DefRawInputProc returned %x" would be a lot more useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Lucas Zawacki July 8, 2011

July 8, 2011

I realized this patch and the next are wrong and don't work, despite the tests passing. No need to bother reading them. 2011/7/8 Lucas Fialho Zawacki <lfzawacki(a)gmail.com>: > --- > dlls/dinput/device.c | 22 ++++++++++++++++++++++ > dlls/dinput/device_private.h | 1 + > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5d81227..99c854c 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -953,6 +953,16 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, > TRACE("buffersize = %d\n", pd->dwData); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPDIPROPSTRING ps = (LPDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + if (strlenW(This->owner) == 0) return S_FALSE; > + > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); > + break; > + } > case (DWORD_PTR) DIPROP_VIDPID: > FIXME("DIPROP_VIDPID not implemented\n"); > return DIERR_UNSUPPORTED; > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) > { > + IDirectInputDeviceImpl *This = impl_from_IDirectInputDevice8W(iface); > DIPROPDWORD dp; > + DWORD username_size = MAX_PATH; > + WCHAR username[MAX_PATH]; > > FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > > + /* NULL username defaults to the logged user */ > + if (lpszUserName == NULL) > + { > + GetUserNameW(username, &username_size); > + lpszUserName = username; > + } > + > + memcpy(This->owner, lpszUserName, strlenW(lpszUserName)*sizeof(WCHAR)); > + > if (lpdiaf->dwBufferSize > 0) > { > dp.diph.dwSize = sizeof(DIPROPDWORD); > diff --git a/dlls/dinput/device_private.h b/dlls/dinput/device_private.h > index 503698a..6df8d93 100644 > --- a/dlls/dinput/device_private.h > +++ b/dlls/dinput/device_private.h > @@ -81,6 +81,7 @@ struct IDirectInputDeviceImpl > /* Action mapping */ > int num_actions; /* number of actions mapped */ > ActionMap *action_map; /* array of mappings */ > + WCHAR owner[MAX_PATH]; /* username of the device's owner */ > }; > > extern BOOL get_app_key(HKEY*, HKEY*) DECLSPEC_HIDDEN; > -- > 1.7.0.4 >

1 0

re: wined3d: Introduce quirk for proper RGBA16 support.
by Dan Kegel July 8, 2011

July 8, 2011

It seems to work... but in Mass Effect 2 Demo with the patch, the initial cinematics (where Shepard is trying to put out the fire, and you're prompted to answer "There's no time to argue", are very jerky, and CPU usage is very high. I didn't have that problem without the patch.

1 1

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 8, 2011

July 8, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static inline HWAVE WINMM_MakeHWAVE(UINT mmdevice, BOOL is_out, UINT device) > +{ > + return (HWAVE)((1 << 15) | ((!!is_out) << 14) | (mmdevice << 8) | device); > +} > + > +static inline void WINMM_DecomposeHWAVE(HWAVE hwave, UINT *mmdevice_index, > + BOOL *is_out, UINT *device_index, UINT *junk) > +{ > + *device_index = ((UINT)hwave & 0xFF); > + *mmdevice_index = ((UINT)hwave >> 8) & 0x3F; > + *is_out = ((UINT)hwave >> 14) & 0x1; > + *junk = (UINT)hwave >> 15; > +} This (and the same thing in various other places) will cause pointer conversion warnings on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix SETUPDI_OpenDrvKey
by Alexandre Julliard July 8, 2011

July 8, 2011

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > @@ -3728,8 +3728,13 @@ static HKEY SETUPDI_OpenDrvKey(struct DeviceInfo *devInfo, REGSAM samDesired) > WCHAR devId[10]; > > sprintfW(devId, fmt, devInfo->devId); > - RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > - RegCloseKey(classKey); > + l = RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > + if (!l) { > + RegCloseKey(classKey); > + } else { > + SetLastError(ERROR_KEY_DOES_NOT_EXIST); > + return INVALID_HANDLE_VALUE; > + } You are leaking the key now. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin (try 2)
by Alexandre Julliard July 8, 2011

July 8, 2011

Jay Yang <jkelleyy(a)gmail.com> writes: > +static void test_query_recyclebin(void) > +{ > + SHQUERYRBINFO info1={sizeof(info1),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; > + SHQUERYRBINFO info2={sizeof(info2),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; You can't use LL constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bug #2082
by Charles Welton July 7, 2011

July 7, 2011

This is one of the longest standing bugs which don't get much love from developers. Today I took some time with traces and wrote a test case which fails against git: http://bugs.winehq.org/attachment.cgi?id=35469 What is happening? When there's a child window to the ddraw window over it(the ddraw window), wined3d doesn't draw over the child. Windows, however, doesn't care about children and draws over them. Note that the DC is the same for both(according to traces). Not only that, the child window have different positions when in fullscreen or virtual desktop. As for the fix, I have yet to find the culprit dll(s) for this. Unfortunately I don't have the experience with wine's code and would like suggestions as to where to begin. -- Charles Welton

2 1

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)
by Juan Lang July 7, 2011

July 7, 2011

Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan

3 3

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin July 7, 2011

July 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin July 7, 2011

July 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin
by Marvin July 7, 2011

July 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12300 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu July 7, 2011

July 7, 2011

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -132,21 +132,21 @@ static void test_fileops( void ) > rewind(file); > for (i = 0, c = EOF; i < sizeof(outbuffer); i++) Isn't c = EOF in for initialization also a dead assignment? Octavian

2 1

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu July 7, 2011

July 7, 2011

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > c = outbuffer[sizeof(outbuffer) - 1]; > ok(ungetc(c, file) == c, "ungetc did not return its input for bufmode=%x\n", bufmodes[bufmode]); > ok(!feof(file), "feof after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > - ok((c = fgetc(file)) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > + ok(fgetc(file) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > ok(c == outbuffer[sizeof(outbuffer) - 1], > "getc did not return ungetc'd data for bufmode=%x\n", bufmodes[bufmode]); Also, this change doesn't look like it's removing a dead assignment, but it does make the test ok(c == outbuffer[sizeof(outbuffer) - 1], ...) always succeed. Octavian

2 1

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.
by Juan Lang July 7, 2011

July 7, 2011

Hi Jacek, > These are functions that I missed when revieweing Gecko headers. I will > probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much simpler that way. Right now, we have: current Wine + current gecko = crash By changing the calling convention in Wine, we have: Wine <= 1.3.23 + current gecko = crash Wine 1.3.24-?? + current gecko = no crash Wine ?? + current gecko = crash Wine ?? + new gecko = no crash Wine <= 1.3.23 + new gecko = crash By doing a new gecko release, we have: any Wine + current gecko = crash any Wine + new gecko = no crash --Juan

2 3

Re: [PATCH 1/2] kernel32: Fixes various 'profile' functions (profile.c). (try 3)
by Alexandre Julliard July 7, 2011

July 7, 2011

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > kernel32: Fixes various 'profile' functions. > Try 2: Formatting change. > Try 3: Splitted tests/profile.c patch You can't split it that way. What you need is to split each separate fix together with its own test fix. Also please use a subject message that describes what you are fixing, not just "fixes various functions". -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Nikolay Sivov July 7, 2011

July 7, 2011

On Thu, Jul 7, 2011 at 2:09 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > + ICreateTypeInfo2Impl *This = impl_from_ICreateTypeInfo2(iface); + + TRACE("(%p,%d), stub!\n", iface, dwHelpStringContext); It's not a stub anymore. + + This->typelib->typelib_header.helpcontext = dwHelpStringContext; Could you please get rid of this ugly naming here and use something like 'context' for variable. + + return S_OK; } > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: msxml3: Don't format xml output if we should be preserving whitespace.
by Marvin July 6, 2011

July 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12283 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WXPPROSP3 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WVISTAADM (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K8SE (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W7PRO (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root>

1 0

Re: kernel32: Fixes various 'profile' functions.
by André Hentschel July 6, 2011

July 6, 2011

spotted with a quick look on it: Am 06.07.2011 18:54, schrieb Christian Inci: > kernel32: Fixes various 'profile' functions. > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index a2bd5b5..da7661c 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -316,6 +316,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > PROFILESECTION **next_section; > PROFILEKEY *key, *prev_key, **next_key; > DWORD dwFileSize; > + BOOL no_section = TRUE; > > TRACE("%p\n", hFile); > > @@ -440,6 +441,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > next_section = &section->next; > next_key = &section->key; > prev_key = NULL; > + no_section = FALSE; formatting! > @@ -1179,6 +1183,7 @@ INT WINAPI GetPrivateProfileStringA( LPCSTR section, LPCSTR entry, > ret = len - 1; > } > buffer[ret] = 0; > + buffer[ret+1] = 0; > } really? -- Best Regards, André Hentschel

1 0

Re: ws2_32: Remove dead assignment (Clang)
by Marcus Meissner July 6, 2011

July 6, 2011

On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 4fc65ab..91aab01 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5874,7 +5874,7 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > { > case CF_ACCEPT: > if (addr && addrlen) > - addr = memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); > + memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); This is wrong. Keep the addrlen check. Ciao, Marcus

1 1

Re: shell32: Remove dead assignments (Clang)
by Nikolay Sivov July 6, 2011

July 6, 2011

2011/7/6 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shell32/shelllink.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c > index 07fe7aa..fff0e79 100644 > --- a/dlls/shell32/shelllink.c > +++ b/dlls/shell32/shelllink.c > @@ -1189,29 +1189,29 @@ static HRESULT WINAPI IPersistStream_fnSave( > Stream_WriteLocationInfo( stm, This->sPath, &This->volume ); > > if( This->sDescription ) > - r = Stream_WriteString( stm, This->sDescription ); > + Stream_WriteString( stm, This->sDescription ); > This is questionable. If you write to a provided stream it's ok for it to fail write operation, this needs a test. Method return value should probably reflect write failure.

1 0

Re: [PATCH] ntdll/tests: Added tests for ObjectTypeInformation class in NtQueryObject
by Vitaliy Margolen July 5, 2011

July 5, 2011

On 07/05/2011 07:20 PM, Austin Lund wrote: > + todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) + sizeof(WCHAR), "unexpected len %u\n", len ); What is that magic number "88"? If it's a size of some structure - then please use it explicitly. Vitaliy.

1 0

Re: [1/10] dinput: Implement IDirectInput::RunControlPanel.
by Vitaliy Margolen July 5, 2011

July 5, 2011

On 07/05/2011 06:18 AM, Andrew Nguyen wrote: > --- > dlls/dinput/dinput_main.c | 15 ++++++++- > dlls/dinput/tests/Makefile.in | 1 + > dlls/dinput/tests/dinput.c | 69 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 84 insertions(+), 1 deletions(-) > create mode 100644 dlls/dinput/tests/dinput.c Patches look good to me. Vitaliy.

1 0

Re: [PATCH 1/5] d3dx9_36: Implement D3DXHANDLE more robustly
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 23:45, Travis Athougies <iammisc(a)gmail.com> wrote: > Fixes bug 26583. > > Allows deadspace 2 to run without native dlls. This contains no useful information about what issue this is supposed to fix, unless you expect people to actually debug it themselves first. And I even went through the trouble to lookup the bug. > +static WORD new_handle_with_desc_and_name(ID3DXConstantTableImpl* This, D3DXCONSTANT_DESC* desc, LPCSTR name, LPCSTR full_name) > +{ > + ++This->handle_count; > + if (This->handles) > + This->handles = HeapReAlloc(GetProcessHeap(), 0, This->handles, sizeof(ctab_handle) * This->handle_count); > + else > + This->handles = HeapAlloc(GetProcessHeap(), 0, sizeof(ctab_handle) * This->handle_count); > + > + This->handles[This->handle_count - 1].desc = *desc; > + This->handles[This->handle_count - 1].desc.Name = strdup(name); > + This->handles[This->handle_count - 1].full_name = strdup(full_name); > + > + return This->handle_count; > +} That's just terrible.

1 0

Re: d3dx9_36: Push down the scope of two variables. (RESEND)
by Alexandre Julliard July 5, 2011

July 5, 2011

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This does not fix a bug or add a feature, but it makes the coder easier > to follow. Narrower scope tends to be a good thing for variables, both > for human readers and compilers (though modern ones should not need the > hint). Not necessarily, that's a matter of taste (IOW, not something you should "fix" in other people's code). -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH 1/2] d3dx9/line: Implement Begin and End methods. (try 2)
by Charles Welton July 5, 2011

July 5, 2011

Is there a reason why this patch and it's brother weren't merged in yet? This has been sitting for a few days and no comments about it yet. On 06/29/2011 07:08 PM, Charles Welton wrote: > Since the last patch spent some time without comments and wasn't > commited, I'm resending. > > Try 2 because of TRACE calls and whitespace fixes. > > --- > dlls/d3dx9_36/line.c | 73 > +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 69 insertions(+), 4 deletions(-) > > -- Charles Welton

2 1

Re: [4/9] msxml3: Implement IXMLDOMNodeList::QueryInterface(IEnumVARIANT).
by Nikolay Sivov July 5, 2011

July 5, 2011

On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > --- > dlls/msxml3/nodelist.c | 33 ++++++++++++++++++++++++++++++++- > dlls/msxml3/selection.c | 34 ++++++++++++++++++++++++++++++++-- > 2 files changed, 64 insertions(+), 3 deletions(-) > > + else if ( IsEqualGUID( riid, &IID_IEnumVARIANT ) ) + { + if (!This->enumv && + (This->enumv = create_nodelist_enum(&This->IXMLDOMNodeList_iface))) + IXMLDOMNodeList_Release(iface); /* create_nodelist_enum() adds a ref, and we don't here. */ + + if (!This->enumv) + { + *ppvObject = NULL; + return E_OUTOFMEMORY; + } + + IEnumVARIANT_AddRef(This->enumv); + *ppvObject = This->enumv; + return S_OK; + } Shouldn't this->enumv be protected somehow to work with multiple threads? I know that so called FreeThreaded* thing is only reported to be supported, but still. Maybe something like pointer exchange call will work.

2 1

Re: [PATCH] wscript: implemented Host_get_BuildVersion
by Paul Vriens July 5, 2011

July 5, 2011

On 07/04/2011 11:28 PM, Michał Ziętek wrote: > +ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = " + typeof(WScript.BuldVersion)); Patch is already committed but there is a typo here 'BuldVersion' instead of 'BuildVersion'. -- Cheers, Paul.

1 0

Re: winedevice: eliminate the driver_name global variable
by Alexandre Julliard July 5, 2011

July 5, 2011

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate the driver_name global variable > > This is part of general refactoring to make the driver loading code reusable. Have you fixed it since last time or is it the same patch? Either way it's still crashing. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard July 5, 2011

July 5, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static MMRESULT WINMM_SendDeviceThreadMessage(UINT msg, WPARAM wp) > +{ > + DWORD wait; > + MMRESULT res; > + > + EnterCriticalSection(&g_devthread_lock); > + > + if(!PostThreadMessageW(g_devthread_id, msg, wp, (DWORD_PTR)&res)){ > + ERR("PostThreadMessage failed: %d\n", GetLastError()); > + LeaveCriticalSection(&g_devthread_lock); > + return MMSYSERR_ERROR; > + } > + > + wait = WaitForSingleObject(g_devthread_evt, INFINITE); > + > + LeaveCriticalSection(&g_devthread_lock); If you are going to wait for a reply it would be better to create a HWND_MESSAGE window and do a SendMessage to it, then you get all the synchronization for free. -- Alexandre Julliard julliard(a)winehq.org

1 0

Glitch-free iTunes?
by Keith Curtis July 5, 2011

July 5, 2011

Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last I checked. I don't think iTunes has ever properly worked in WINE. It seems like Apple keep revising it and so the current WINE never works with the current iTunes. Can you make a goal of supporting iTunes with no glitches? I know many of you are volunteers, but it is globally efficient if the installation number plays into the priority of the bugs. Just this one app could be huge for Linux on the desktop. Warm regards, -Keith

9 12

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + if ((!texture && old_texture_type != GL_NONE) || (texture && texture->target != old_texture_type)) > + { Actually, just thought of this now, but I'm not sure you can do this like that. The way you're using old_texture_type it's context state, not device state.

1 0

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet July 5, 2011

July 5, 2011

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + TRACE("Dummy 2D texture %d given name %d.\n", i, device->dummyTextureName[i]); This is pretty minor, but those are unsigned.

1 0

Re: gdi32: Make GdiTransparentBlt clipping aware (try2)
by Alexandre Julliard July 5, 2011

July 5, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -392,6 +394,15 @@ BOOL WINAPI GdiTransparentBlt( HDC hdcDest, int xDest, int yDest, int widthDest, > hdcWork = CreateCompatibleDC(hdcDest); > bmpWork = CreateCompatibleBitmap(hdcDest, widthDest, heightDest); > oldWork = SelectObject(hdcWork, bmpWork); > + use_clip_rect = GetClipBox(hdcDest, &clip_rect); > + if(use_clip_rect) { > + clip_rect.left -= xDest; > + clip_rect.top -= yDest; > + clip_rect.right -= xDest; > + clip_rect.bottom -= yDest; > + IntersectClipRect(hdcWork, clip_rect.left, clip_rect.top, clip_rect.right, clip_rect.bottom); > + } You need to handle logical coordinates mapping. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wined3d: Don't apply and invalidate the framebuffer when clearing the device's fb (try 2)
by Henri Verbeet July 5, 2011

July 5, 2011

On 5 July 2011 10:27, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - /* TODO: This is not necessary if the framebuffer is the device's current framebuffer */ > - context_invalidate_state(context, STATE_FRAMEBUFFER, device->StateTable); But you do need to invalidate if it isn't.

1 0

Re: propkeydef.h: Fixed DEFINE_PROPERTYKEY define
by Alexandre Julliard July 5, 2011

July 5, 2011

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -33,18 +33,16 @@ > #ifdef INITGUID > #ifdef __cplusplus > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - EXTERN_C const PROPERTYKEY name = \ > + EXTERN_C const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - const PROPERTYKEY name = \ > + const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #endif > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY > + EXTERN_C const PROPERTYKEY name Do you really want to remove DECLSPEC_HIDDEN? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Misha Koshelev : d3dx9_36: Implement and add tests for D3DXFloat16To32Array .
by Michael Stefaniuc July 5, 2011

July 5, 2011

Hello Misha, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: a6b40624dbc457ba7b0b4b307b1eb88617c67197 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6b40624dbc457ba7b0b4b307… > > Author: Misha Koshelev <misha680(a)gmail.com> > Date: Wed Jun 29 11:16:29 2011 -0400 > > d3dx9_36: Implement and add tests for D3DXFloat16To32Array. > > --- > > dlls/d3dx9_36/d3dx9_36.spec | 2 +- > dlls/d3dx9_36/math.c | 32 +++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 93 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c > index 5ad1924..aa3f135 100644 > --- a/dlls/d3dx9_36/tests/math.c > +++ b/dlls/d3dx9_36/tests/math.c > @@ -2215,6 +2216,64 @@ static void test_D3DXVec_Array(void) ... > + { NAN, 0x7fff, 0x7fff, 131008.0f, 131008.0f }, > + { -NAN, 0xffff, 0xffff, -131008.0f, -131008.0f }, this breaks compilation on systems that don't have NAN. bye michael

1 0

Re: oleaut32: use the locale settings for digit group sizes
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12210 Your paranoid android. === WNT4WSSP6 (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === WVISTAADM (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W2K8SE (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W7PRO (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789'

1 0

Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
by André Hentschel July 4, 2011

July 4, 2011

Am 04.07.2011 16:29, schrieb Vincas Miliūnas: > Changelog: Hi, even if you have 10 patches, maybe first try to get the tests in. Divide and Conquer! That's at least a bit less mess on wine-patches for now, and is easier for you and AJ i guess. -- Best Regards, André Hentschel

1 0

Re: [PATCH 10/10] server+user32: Added RIDEV_NOLEGACY raw input device flag implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12189 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 09/10] server+user32: Added GetRawInputData implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12188 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 08/10] user32: Added GetRawInputBuffer implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12187 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0

Re: [PATCH 07/10] server+user32: Added RegisterRawInputDevices implementation (try 12)
by Marvin July 4, 2011

July 4, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12186 Your paranoid android. === WVISTAADM (32 bit input) === Timeout === W2K8SE (32 bit input) === Timeout

1 0