July 2011 - Wine-Devel - list.winehq.org

Re: netapi32: add msvcrt to importlibs
by Alexandre Julliard July 21, 2011

July 21, 2011

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > hi, this fixes bug http://bugs.winehq.org/show_bug.cgi?id=27827 > > Creo Elements expects msvcrt to be loaded, and fails to start. > > Dependancywalker on windows shows netapi32 loads the msvcrt. I guess > when more netapi32 functions will be implemented in future this will > become a "real" necessary dependency It won't help if it's not used, and you'd need to use msvcrt headers too. I don't think it's the right place to fix this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Experimental website for tracking translation issues
by Francois Gouget July 21, 2011

July 21, 2011

I have started running a script that can check for translation issues in PO files against Wine's PO files. The issues it checks for include: * Mismatched printf format specifiers. * Mismatched trailing ellipsis. * Other mismatched trailing punctuation like full stop, question mark, space, etc. * Mismatched line feeds, trailing or not. * Spaces followed by line feeds. * Untranslated strings. Obviously some of these result in false positives. For instance 'Document' is written exactly the same in English and in French so to the script it will look like it was not translated. If you send me the corresponding error lines I'll make sure they are ignored by putting them in an 'ignore' file. So here's the web site: http://fgouget.free.fr/wine-po/ A typical report looks like this: L71: msgid or msgstr does not end in '[.]{3}' L75: msgid or msgstr does not end in '[.]{3}' You'd typically have the report and the corresponding PO file (here pl.po) open side by side, and jump to the PO lines mentionned in the report to investigate each of them. These are two ellipsis issues by the way. As you can see it's quite primitive. That's both because I'm not much of a web developer guy and because I'm still unsure how much interest there is in this. Also there's an open-source tool that does the same type of checks and more, though it seems to lack a way to handle false positives. It's pofilter from the translate-toolkit package. This tool is integrated with Pootle (the online PO file editor), so maybe this will do all we need once we put our PO files online for translation. In the meantime if any translator is interested in seeing what potential issues lie in their PO files... I'd particularly appreciate help with cleaning up the ellipsis, trailing spaces and untranslated string issues. See wine-patches for a handful of patches I'm sending based on the initial reports. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

3 7

Re: po: French translation tweaks and fixes.
by Frédéric Delanoy July 20, 2011

July 20, 2011

2011/7/20 Francois Gouget <fgouget(a)free.fr>: > --- > po/fr.po | 108 ++++++++++++++++++++++++++++++++------------------------------ > 1 files changed, 56 insertions(+), 52 deletions(-) @@ -6857,7 +6859,7 @@ msgstr "Corbeille" #: shlwapi.rc:27 msgid "%ld bytes" -msgstr "%ld bytes" +msgstr "%ld octets" #: shlwapi.rc:28 msgid " hr" Bytes and octets are different things; octets have exactly 8 bits while bytes can have more (or less) -"Start est fourni sans AUCUNE GARANTIE ; pour les détails lancez avec " +"Start est fourni sans AUCUNE GARANTIE ; pour plus de détails lancez le avec\n" Should be "lancez-le" #: winefile.rc:101 msgid "root fs" -msgstr "root fs" +msgstr "fs racine" Maybe "sdf racine" for "système de fichiers"? Frédéric

3 3

[PATCH 4/4] winmm: Fix check for DCB_NULL callback type
by Joerg-Cyril.Hoehle＠t-systems.com July 20, 2011

July 20, 2011

Andrew Eikum wrote: >- if(info->flags & DCB_NULL) >+ if((info->flags & DCB_TYPEMASK) == DCB_NULL) Instead of add ing a special case, I suggest to simplify the code: always call DriverCallback and declare void WINMM_NotifyClient. You currently ignore its return value anyway. Using void is consistent with an ealier notification patch of mine around April this year. Michael, wouldn't it be possible to add a function to the static checkers to be able to detect static functions whose return is systematically ignored and rewrit these and their callers to use void? I came across another occurence of that pattern no later than yesterday (mcimidi IIRC). Regards, Jörg Höhle

2 1

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.
by Alexandre Julliard July 20, 2011

July 20, 2011

Grazvydas Ignotas <notasas(a)gmail.com> writes: > @@ -2004,6 +2004,8 @@ NTSTATUS WINAPI NtQueryDirectoryFile( HANDLE handle, HANDLE event, > fstat( fd, &st ); > curdir.dev = st.st_dev; > curdir.ino = st.st_ino; > + if (lseek( fd, 0, SEEK_CUR ) == 0) > + restart_scan = TRUE; That won't work if we already returned '.' and '..'. -- Alexandre Julliard julliard(a)winehq.org

4 10

Re: comctl32: Improve the stub of TaskDialogIndirect to display a simple message box pending a full implementation
by Reece Dunn July 20, 2011

July 20, 2011

On 20 July 2011 15:39, Jeff Latimer <lats(a)yless4u.com.au> wrote: > This should allow more apps to run. My mail import has blown up and I > may have messed up the format of the patch. The patch is line wrapped -- you need to send the patch as an attachment in a form that gets recognised as an octet stream (using the .patch extension should do this). > + if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON | > TDCBF_NO_BUTTON | TDCBF_CANCEL_BUTTON)) > + uType &= MB_YESNOCANCEL; > + else > + if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON | > TDCBF_NO_BUTTON)) > + uType &= MB_YESNO; This will not work as intended -- (a & (b | c)) will evaluate true if a contains either b or c, equivalent to ((a & b) || (a & c)). You need to use ((a & b) == b) instead. - Reece

1 0

Re: po: Remove English strings from the Polish translation.
by Jacek Caban July 20, 2011

July 20, 2011

Hi Francois, On 07/20/11 16:14, Francois Gouget wrote: > --- > po/pl.po | 88 +++++++++++++++++++++++++++++++------------------------------- > 1 files changed, 44 insertions(+), 44 deletions(-) > Separator, diagram and folder are the right Polish translations (that happen to be identical to English). Others should, obviously, be removed. Jacek

2 2

Re: [PATCH 1/5] quartz: Rather than assert, continue when IAsyncReader::WaitForNext is flushing and break when it actually times out.
by Alexandre Julliard July 20, 2011

July 20, 2011

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -479,13 +488,27 @@ static void PullPin_Thread_Process(PullPin *This) > else > { > /* FIXME: This is not well handled yet! */ > - ERR("Processing error: %x\n", hr); > if (hr == VFW_E_TIMEOUT) > { > - assert(!pSample); > + struct timeval tve; > + > + /* > + * Calculate the time elapsed in IAsyncReader::WaitForNext > + * in order to determine whether a timeout actually occurred > + * or whether the pin is flushing. > + */ > + timersub(&tv2, &tv1, &tve); > + if (!timercmp(&tve, &tvw, <) && pSample != NULL) > + { > + ERR("Non-NULL sample returned with VFW_E_TIMEOUT.\n"); > + break; > + } That's really ugly. Surely there's a better way to do this than measuring the elapsed time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 10/10] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin July 19, 2011

July 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12606 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: d3dx9_36: Use SUCCEEDED instead of !FAILED.
by Matteo Bruni July 19, 2011

July 19, 2011

2011/7/19 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > dlls/d3dx9_36/mesh.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c > index 94a291f..d8f72c4 100644 > --- a/dlls/d3dx9_36/mesh.c > +++ b/dlls/d3dx9_36/mesh.c > @@ -3376,7 +3376,7 @@ HRESULT WINAPI D3DXLoadMeshFromXResource(HMODULE module, > if (!resinfo) return D3DXERR_INVALIDDATA; > > hr = load_resource_into_memory(module, resinfo, &buffer, &size); > - if (!FAILED(hr)) return D3DXERR_INVALIDDATA; > + if (SUCCEEDED(hr)) return D3DXERR_INVALIDDATA; > > return D3DXLoadMeshFromXInMemory(buffer, size, options, device, adjacency, > materials, effect_instances, num_materials, mesh); > -- > 1.7.6 > > > Isn't that supposed to be "if (FAILED(hr))" ? If I'm not mistaken, now it is returning failure when the resource is correctly loaded... Thumbs up for Michael's scripts finding real bugs ;)

2 1