July 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 2/9] wscript: added arguments.c; implemented Host_get_Arguments (resend)
by Marvin July 29, 2011

July 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13001 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 1/2] winmm: Trivial code simplifications and fixes.
by Henri Verbeet July 29, 2011

July 29, 2011

On 29 July 2011 09:46, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > these fixes all trivial errors I mentioned recently but one, plus a few ones I discovered since then. > These need to be separate patches, of course. I'd also encourage everyone to just use git send-email for sending patches.

2 2

Re: patch for dlls/gdi32/dib.c: fixes crash
by Octavian Voicu July 29, 2011

July 29, 2011

On Wed, Jul 27, 2011 at 6:44 PM, Wolfgang Walter <wine(a)stwm.de> wrote: > - char src_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > - BITMAPINFO *src_info = (BITMAPINFO *)src_bmibuf; > - char dst_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > - BITMAPINFO *dst_info = (BITMAPINFO *)dst_bmibuf; There's another instance of that in GetDIBits. Allocating 2KB+ (2 x 1064 bytes) of data on the stack is not very reasonable I guess. Octavian

3 3

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches
by Alexandre Julliard July 29, 2011

July 29, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, > > if (wait_handle) > { > - NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > - status = io->u.Status; > + status = NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > + if (status == STATUS_USER_APC) > + { > + async->interrupted = TRUE; > + status = STATUS_CANCELLED; /* not really, the ioctl completes and event and the handle > + itself get signaled */ > + } This looks wrong. You can't claim it was cancelled if it's still running. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/7] cmd/tests: Add FOR /D tests
by Alexandre Julliard July 29, 2011

July 29, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > programs/cmd/tests/test_builtins.cmd | 6 ++++++ > programs/cmd/tests/test_builtins.cmd.exp | 11 +++++++++++ > 2 files changed, 17 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok batch.c:239: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 225 (got 'baz', wanted 'baz') make: *** [batch.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

ancient email messages being sent, or at least archived, again?
by Dan Kegel July 29, 2011

July 29, 2011

What's with messages like http://www.winehq.org/pipermail/wine-bugs/2011-July/285020.html ?

2 1

Re: Nvidia GeForce GTX560 Ti detection fix
by Henri Verbeet July 28, 2011

July 28, 2011

On 28 July 2011 22:46, <gwen(a)derpymail.com> wrote: > This patch fixes the problem that a GeForce GTX560 Ti GPU is not being > detected in current build. (http://bugs.winehq.org/show_bug.cgi?id=27924) > The change itself looks reasonable enough, though I don't have the hardware to verify the strings. Please use git to generate patches though, and include proper author information. See also http://wiki.winehq.org/SubmittingPatches.

1 0

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2)
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12984 Your paranoid android. === WVISTAADM (32 bit shlfolder) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Don't treat a button as a dialog (valgrind)
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12982 Your paranoid android. === WNT4WSSP6 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2KPROSP4 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === WXPPROSP3 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2K3R2SESP2 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === WVISTAADM (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2K8SE (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PRO (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PROX64 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PROX64 (64 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON

1 0

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths.
by Marvin July 28, 2011

July 28, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android. === WNT4WSSP6 (32 bit shlfolder) === Timeout === W2KPROSP4 (32 bit shlfolder) === Timeout

1 0