August 2011 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Updated Clang static analysis results / Valgrind update
by Austin English Dec. 5, 2011

Dec. 5, 2011

Web space usage was getting a bit high, so I've uploaded a tarball to a file download service: http://www.sendspace.com/file/5hot36 austin(a)aw21 ~ $ sha1sum scan-build-2011-07-02.tar.bz2 ac3cb3920ef97641fff1f5376f8136cef01f15bf scan-build-2011-07-02.tar.bz2 to use, just extract and open in your favorite browser: $ firefox index.html this was run against Clang from svn: clang version 3.0 (trunk 134320) Please send me any false positives that you'd like me to report upstream. Cheers, Austin P.S. For those of you wanting Valgrind results, I'm currently hitting a nasty Valgrind bug, waiting on upstream to fix: https://bugs.kde.org/show_bug.cgi?id=275673 (Thanks to Andrew N for finding the faulty commit)

4 7

Re: [patch] Support NULL puLen in VerQueryValue
by Andrew Nguyen Oct. 15, 2011

Oct. 15, 2011

On 01/03/2011 09:25 PM, Rafael Ávila de Espíndola wrote: > I couldn't find any documentation saying that this must be supported, > but running google code search on VerQueryValue.*NULL found some uses. > > Cheers, > Rafael > > > > You should write some tests to examine the behavior of VerQueryValue with NULL puLen.

3 2

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

re: Where is the best place to report a fscanf bug found under wine-1.3.27?
by Dan Kegel Sept. 18, 2011

Sept. 18, 2011

> Today I discovered .. that the scanf family of functions was > introducing float (32-bit floating-point) noise into double (64-bit > floating-point) results. I see it here, too: $ sudo apt-get install mingw32 $ i586-mingw32msvc-gcc test_fscanf.c $ echo "1.1e+01 1.1e+00 1.1e-01 1.1e-02 1.1e-03 1.1e-04" | ~/wine-git/wine a.exe 1.10000000000000000e+001 1.10000000000000009e+000 1.10000001639127737e-001 1.10000003278255491e-002 1.10000004917383261e-003 1.10000006556511075e-004 You can work around it with 'winetricks vcrun6', after which the test program outputs: 1.10000000000000000e+001 1.10000000000000010e+000 1.10000000000000000e-001 1.09999999999999990e-002 1.10000000000000010e-003 1.10000000000000000e-004 So the problem is in wine's msvcrt.dll. You could narrow it down further by printing out the raw byte strings for the numbers and then sprinking that printout through the path from when scanf is called to where printf returns. (Or, I suppose, step through it with a debugger instead.) But the best place to report the bug is http://bugs.winehq.org - Dan

2 2

re: Severe startup latencies for Windows applications run under wine
by Dan Kegel Sept. 17, 2011

Sept. 17, 2011

Try oprofile instead. ( A really old intro is at http://www.winehq.org/wwn/249#oprofile%20&%20Wine )

4 4

buildbot status
by Dan Kegel Sept. 7, 2011

Sept. 7, 2011

- stability problems The buildbot cluster is not ready for prime time yet. My ubuntu 11.04-based slaves tend to lock up within a day with either an OOM failure, an X livelock, or something else. So I brought an ubuntu 10.04.3 slave online and moved the buildmaster off onto its own machine; let's see what breaks next. - Slave speed Here is the complete build-and-test time (and the build time alone) for four CPUs: 54 (48) celeron @ 2.80 GHz (headless, so it's not running all tests) 17 (10) E8400 @ 3.00GHz 14 (6) Q9300 @ 2.50GHz 12 (4) i7 920 @ 2.67GHz I will probably stick with slaves that are core 2 duo or better, so patches can get fast feedback.

5 15

Re: kernel32: Fix writing to a pipe in WriteConsoleW().
by Eric Pouech Sept. 2, 2011

Sept. 2, 2011

Le 03/08/2011 18:07, Francois Gouget a écrit : > WriteFile() checks if the handle corresponds to the console and if it > does invokes WriteConsoleA(). This barely escaped an infinite loop but > messed up the string encoding as CP_UNIXCP is usually different from > CP_ACP. > --- > > I noticed this issue while testing the net.exe tool. After making it > use WineConsole() I was getting the following outputs: > > $ wine net stop > Spécifie le service à arrêter. > $ ./wine net stop | cat > Sp├®cifie le service ├á arr├¬ter. > > It turns out that it's because we only get through the WineConsoleW() -> > WriteFile() -> WriteConsoleA() loop in the second case. could you elaborate a bit more. in case of wine ... | cat, the standard output should be a pipe not a console so writeconsoleW is supposed to fail so it would make more sense to simply let WriteConsoleW fail when is_console_handle(hConsoleOutput) is FALSE ? (similar functions as WriteConsoleA, ReadConsoleA/W should be protected the same way) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 4

Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab
by Dan Kegel Sept. 1, 2011

Sept. 1, 2011

On Wed, Aug 31, 2011 at 1:10 PM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/161 > BUILD FAILED: failed git Something's fishy; looking at http://marc.info/?l=wine-patches&m=131134541100364&w=2 I see that the July 22nd version seems to have interesting strings, but the August 31st version has all question marks when it comes to non-ascii text. What happened between the two? http://source.winehq.org/patches/data/78217, which is where I pulled the patch from, also has the question marks.

2 2

Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
by Stefan Dösinger Sept. 1, 2011

Sept. 1, 2011

On Tuesday 30 August 2011 20:12:31 Henri Verbeet wrote: > This imlicitly gets rid of the "auto" option as well, since there's no way > to explicitly specify it. This will no doubt cause its share of > regressions, but I prefer actually fixing those bugs to running into the > surface implementation switching code every time I try to fix something in > ddraw. This will break 2D-only apps in situations where OpenGL is not available. It would be a good idea to use SURFACE_GDI automatically in those situations. (I'm not sure if ddraw without GL works at all right now, we have no systems that run the tests with this setup) It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with me, it's not like those apps are working at the moment, and I guess the switching breaks more than it fixes.

2 3

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > +static INT_PTR CALLBACK ConfigureDevicesDlgProc(HWND dialog, UINT uMsg, WPARAM wParam, LPARAM lParam) > +{ > + static LPDIACTIONFORMATW lpdiaf; > + static DIDevicesData devices_data; > + static ConfigureDevicesData *conf_data; > + > + switch(uMsg) > + { > + case WM_INITDIALOG: > + /* Initialize action format and enumerate devices */ > + conf_data = (ConfigureDevicesData*) lParam; > + lpdiaf = conf_data->params->lprgFormats; It doesn't make sense to pass the info as WM_INITDIALG parameter if it's going to be stored in global variables anyway. A better way would be to store this in the window info. -- Alexandre Julliard julliard(a)winehq.org

4 3

WineHQ Maintenance.
by Jeremy Newman Sept. 1, 2011

Sept. 1, 2011

We will be performing upgrades and maintenance to the WineHQ.org server starting at 1800 CDT on Wednesday August 31st. This process will take the server off-line for about an hour. The Websites (www,appdb,forums), and Mailing lists, and Git will be off-line during this period. -Newman

1 1

Re: fake patch #2 just to test error emails
by buildbot＠kegel.com Aug. 31, 2011

Aug. 31, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/166 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: cmd/tests: Add README doc file
by Alexandre Julliard Aug. 31, 2011

Aug. 31, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > programs/cmd/tests/README | 120 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 120 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/README That sort of thing should be on the wiki. READMEs in the source are never maintained properly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: 78214: Subject: winusb: add new stub dll (resend)
by Dan Kegel Aug. 31, 2011

Aug. 31, 2011

On Wed, Aug 31, 2011 at 1:00 PM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/158 > BUILD FAILED: failed git > > > For more info about this message, see http://wiki.winehq.org/BuildBot The error was fatal: corrupt patch at line 32 Your email program may have removed whitespace from the patch. Try attaching the patch instead of including it inline.

1 0

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
by Frédéric Delanoy Aug. 31, 2011

Aug. 31, 2011

On Tue, Aug 30, 2011 at 00:34, Martin Wilck <mwilck(a)arcor.de> wrote: > This patch adds some tests for command line parsing and treatment > of quotes and special characters in the command line and in program > names and parameters. The .exp file was created using Win XP. > Follow-up patches will fix the marked TODOs. > --- > programs/cmd/tests/rsrc.rc | 6 + > programs/cmd/tests/test_parsing.cmd | 158 +++++++++++++++++++++++++++++++ > programs/cmd/tests/test_parsing.cmd.exp | 77 +++++++++++++++ > 3 files changed, 241 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/test_parsing.cmd > create mode 100644 programs/cmd/tests/test_parsing.cmd.exp Some of those tests are already present in the test_builtins.cmd* (e.g. the spacing tests) You should probably integrated your tests in there: that makes it easier to spot regressions and helps prevent tests duplication Also, see http://www.winehq.org/pipermail/wine-devel/2011-August/091817.html Frédéric Delanoy

2 6

d3dx9_36/tests: Fix printing a NULL string
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 31, 2011

Aug. 31, 2011

André Hentschel suggested: >Should stop the crash on Solaris and maybe others >- trace("parent_data = (%p) -> %s\n", parent_data, (char *)parent_data); >+ trace("parent_data (%p) -> %s\n", parent_data, parent_data ? (char *)parent_data : "(null)"); This is sooo backwards. You don't want to try and find all places where (null) may be printed. I remember seeing (null) in logs here and there, so you're telling us that turning on Wine logs in Solaris can randomly crash Wine because it crashes on printf("%s", NULL)? I'm very surprised. I thought Solaris was one of the first machines - decades ago - where I observed "(null)" for NULL. (Or is that really glibc only?) Regards, Jörg Höhle

5 6

Re: [PATCH 2/5] ddraw: Get rid of the surface implementation switching code.
by Alexandre Julliard Aug. 31, 2011

Aug. 31, 2011

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Despite what the comment says, switching the implementation of an already > created surface isn't so straightforward. > --- > dlls/ddraw/ddraw.c | 179 +-------------------------------------------- > dlls/ddraw/surface.c | 25 ------- > dlls/wined3d/swapchain.c | 4 +- > include/wine/wined3d.h | 1 - > 4 files changed, 6 insertions(+), 203 deletions(-) This one is causing crashes on 64-bit: ../../../../wine/tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so ../../../../wine/dlls/d3d8/tests/buffer.c && touch buffer.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x2b631b0deede (thread 0021), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 64-bit code (0x00002b631b0deede). Register dump: rip:00002b631b0deede rsp:000000000023f3a0 rbp:000000000023f45a eflags:00010246 ( R- -- I Z- -P- ) rax:0000000000000001 rbx:0000000000000000 rcx:0000000000000018 rdx:000000000023f459 rsi:000000000023f45a rdi:0000000000000000 r8:000000000023f45c r9:000000000023f45b r10:000000000023f45c r11:000000000023f330 r12:000000000023f459 r13:0000000000000000 r14:000000000003b5e0 r15:00002b631b0f00e0 Stack dump: 0x000000000023f3a0: 0000000000000000 0000000000000094 0x000000000023f3b0: 0000000000032ed0 0000000000000094 0x000000000023f3c0: 0000000000032ed0 000000000003e9f0 0x000000000023f3d0: 0000000000000000 00002b631b0307df 0x000000000023f3e0: ffffffffffffffff ffffff00ffffffff 0x000000000023f3f0: 0000000000202020 0000000020000000 0x000000000023f400: 0000000000000000 00000000ffffff00 0x000000000023f410: 0000000000000254 0000000000000000 0x000000000023f420: 0000000000000000 0000000000000000 0x000000000023f430: 0000000000000000 0000000000000000 0x000000000023f440: 0000000000000000 0000000000000000 0x000000000023f450: 5b5b5b5b5b5b5b5b 0808080018000020 Backtrace: =>0 0x00002b631b0deede getDepthStencilBits+0x2e(format=(nil), depthSize="", stencilSize="") [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/utils.c:2598] in wined3d (0x000000000023f45a) 1 0x00002b631b0307df context_choose_pixel_format+0xfe(device=0x3e9f0, hdc=0x254, color_format=0x3b5e0, ds_format=(nil), auxBuffers=0, findCompatible=0) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/context.c:1139] in wined3d (0x0000000000032ed0) 2 0x00002b631b034b79 context_create+0xc8(swapchain=0x58b80, target=0x358f0, ds_format=(nil)) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/context.c:1350] in wined3d (0x0000000000032ed0) 3 0x00002b631b0d297b swapchain_get_context+0x7a(swapchain=0x58b80) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/swapchain.c:1179] in wined3d (0x00000000000358f0) 4 0x00002b631b03a155 context_acquire+0x314(device=0x3e9f0, target=0x358f0) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/context.c:2455] in wined3d (0x00000000000358f0) 5 0x00002b631b047858 wined3d_device_init_3d+0x497(device=0x3e9f0, present_parameters=0x23f810) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/device.c:1335] in wined3d (0x0000000000032ed0) 6 0x00002b631add142a device_init+0x1b9(device=0x36710, parent=0x2f380, wined3d=0x32eb0, adapter=<is not available>, device_type=<is not available>, focus_window=(nil), flags=0x40, parameters=0x23fae0) [/home/julliard/wine/build/obj-elf64/dlls/d3d8/../../../wine/dlls/d3d8/device.c:3112] in d3d8 (0x000000000023fae0) 7 0x00002b631add194b IDirect3D8Impl_CreateDevice+0x10a(iface=0x2f380, adapter=0, device_type=D3DDEVTYPE_HAL, focus_window=(nil), flags=0x40, parameters=0x23fae0, device=0x23fb38) [/home/julliard/wine/build/obj-elf64/dlls/d3d8/../../../wine/dlls/d3d8/directx.c:371] in d3d8 (0x0000000000036710) 8 0x00002b6316db08d7 func_buffer+0x196() [/home/julliard/wine/build/obj-elf64/dlls/d3d8/tests/../../../../wine/dlls/d3d8/tests/buffer.c:61] in d3d8_test (0x000000000023fb38) 9 0x00002b6316dd06c7 run_test+0x126(name="../../../../wine/dlls/d3d8/tests/buffer.c") [/home/julliard/wine/build/obj-elf64/dlls/d3d8/tests/../../../../wine/include/wine/test.h:556] in d3d8_test (0x00002b6316dd95d7) 10 0x00002b6316dd11f6 main+0x115(argc=<is not available>, argv=0x106f0) [/home/julliard/wine/build/obj-elf64/dlls/d3d8/tests/../../../../wine/include/wine/test.h:624] in d3d8_test (0x00000000000106f0) 11 0x00002b6316dd13fe __wine_spec_exe_entry+0xcd(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x00002b630ed8a908) 12 0x000000007b87217f start_process+0xbe(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1056] in kernel32 (0x00002b6316dd1330) 13 0x00002b630f5e5f7b call_thread_func+0x6a(entry=0x7b8720c0, arg=0x7fffffbef000, frame=0x23f459) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3189] in ntdll (0x00007fffafa61d40) 14 0x00002b630f5df856 call_thread_entry_point+0x29() in ntdll (0x00007fffafa61d40) 15 0x00002b630f5b0b66 start_process+0x15(kernel_start=0x23fec8) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2612] in ntdll (0x00007fffafa61d40) 16 0x00002b630ea64213 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fffafa61d40) 17 0x00002b630ea64269 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 18 0x00002b630f5b673e LdrInitializeThunk+0x3dd(kernel_start=0x7b8720c0, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2668] in ntdll (0x00007fffffbef000) 19 0x000000007b8788d2 __wine_kernel_init+0x921() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1257] in kernel32 (0x00007fffafa62fd0) 20 0x00002b630f5b7174 __wine_process_init+0x253() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2877] in ntdll (0x00007fffafa6321c) 21 0x00002b630ea621ef wine_init+0x29e(argc=<is not available>, argv=0x7fffafa637a8, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fffafa632b0) 22 0x000000007bf00de1 main+0x70(argc=0x3, argv=0x7fffafa637a8) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:228] in <wine-loader> (0x0000000000000003) 23 0x00002b630efedead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fffafa63798) [/home/aurel32/eglibc/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 24 0x000000007bf00ca9 _start+0x28() in <wine-loader> (0x0000000000000000) 0x00002b631b0deede getDepthStencilBits+0x2e [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/utils.c:2598] in wined3d: movl (%rbx),%edi 2598 switch (format->id) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] msi: reorder tables to optimize condition evaluation
by Dan Kegel Aug. 31, 2011

Aug. 31, 2011

On Wed, Aug 31, 2011 at 3:10 AM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/136 > BUILD FAILED: failed shell_3 > > > For more info about this message, see http://wiki.winehq.org/BuildBot This breaks loading of wine's gecko here: ../../../tools/runtest -q -P wine -M ieframe.dll -T ../../.. -p ieframe_test.exe.so webbrowser.c && touch webbrowser.ok wine: Unhandled page fault on write access to 0xa06291fc at address 0x407537e9 (thread 002c), starting debugger... Backtrace: =>0 WHERE_execute+0x17a(view=0x11fe58, record=(nil)) [dlls/msi/where.c:821] 1 SELECT_execute+0x9d(view=0x138408, record=(nil)) [dlls/msi/select.c:181] 2 MSI_ViewExecute+0xb4(query=0x11fce0, rec=(nil)) [dlls/msi/msiquery.c:457] 3 get_product_code+0x55(db=0x12e6f0) [dlls/msi/package.c:1393] 4 get_local_package+0x58(filename="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi", localfile="??") [dlls/msi/package.c:1477] 5 MSI_OpenPackageW+0x1f8(szPackage="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi", pPackage=0x33fb14) [dlls/msi/package.c:1546] 6 MsiInstallProductW+0xb3(szPackagePath="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi", szCommandLine=0x0(nil)) [dlls/msi/msi.c:245] 7 install_file+0x24(file_name="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi") [dlls/appwiz.cpl/addons.c:164] 8 install_from_unix_file+0x22b(file_name="/usr/share/wine/gecko/wine_gecko-1.3-x86.msi") [dlls/appwiz.cpl/addons.c:207] 9 install_from_default_dir+0x11f() [dlls/appwiz.cpl/addons.c:276] 10 install_wine_gecko+0x2f() [dlls/appwiz.cpl/addons.c:490] 11 start_params+0x3f(params="install_gecko") [dlls/appwiz.cpl/appwiz.c:978] 12 CPlApplet+0x61(hwndCPL=0x6002e, message=0xa, lParam1=0, lParam2=0x12dbce) [dlls/appwiz.cpl/appwiz.c:1013] 13 Control_DoLaunch+0x524(panel=0x33fd50, hWnd=0x6002e, wszCmd="appwiz.cpl install_gecko") [dlls/shell32/control.c:820] in shell32 (0x0033fd20) 14 Control_RunDLLW+0xde(hWnd=0x6002e, hInst=(nil), cmd="appwiz.cpl install_gecko", nCmdShow=0x5) [dlls/shell32/control.c:846] in shell32 (0x0033fd80) 15 launch+0x35(what="appwiz.cpl install_gecko") [programs/control/control.c:55] 16 wWinMain+0x182(hInst=0x684c0000, hPrev=(nil), lpszCmdLine="appwiz.cpl install_gecko", nCmdShow=0x1) [programs/control/control.c:85] 17 wmain+0x10c(argc=0x3, argv=0x110380) [dlls/winecrt0/exe_wmain.c:50] 0x407537e9 WHERE_execute+0x17a [dlls/msi/where.c:821] in msi: movl %edx,0x0(%eax) 821 tables[i++] = table;

1 0