August 2011 - Wine-Devel - list.winehq.org

winelib an fpc
by Reinier Napoles Martinez Aug. 29, 2011

Aug. 29, 2011

best regards I would like to know if it is possible to use the wine libraries with freepascal compiler. kylix had a modified version of the wine libraries and I believe that it was possible to invoke them from pascal. I've tried several ways but all I get is "segment fault". sorry for my English. Thanks. program test01; {$MODE Delphi} uses types; Type BOOL = LongBool; function GetCursorPos(var lpPoint: TPoint): BOOL; stdcall; external 'libuser32.so' name 'GetCursorPos'; var a:Tpoint; begin WriteLn('Calling wine function'); GetCursorPos(a); WriteLn('End Calling wine function'); WriteLn(a.x); end. program test02; {$Mode Delphi} uses sysutils,types; Type BOOL = LongBool; TGetCursorPos=Function(var lpPoint: TPoint): BOOL;cdecl; Function dlopen(name: pchar;mode: longint):pointer;cdecl;external 'dl'; Function dlsym(lib: pointer; name: pchar):pointer;cdecl;external 'dl'; Function dlclose(lib: pointer):longint;cdecl;external 'dl'; var lib : pointer; GetCursorPos:TGetCursorPos; a:Tpoint; begin lib:=dlopen('/usr/lib/wine/user32.dll.so',1); if lib <> nil then @GetCursorPos:=dlsym(lib,'GetCursorPos') else begin WriteLn('library not loaded'); exit; end; if Assigned(GetCursorPos) then begin WriteLn('Calling GetCursorPos'); Try GetCursorPos(a); Except on E : Exception do WriteLn(E.Message); end; WriteLn('X:',a.x,' Y:',a.Y); end else begin WriteLn('function not loaded'); exit; end; dlclose(lib); end. -- ********************************************************************* En la tierra hace falta personas que trabajen más y critiquen menos, que construyan más y destruyan menos, que prometan menos y resuelvan más que esperen recibir menos y dar más que digan mejor ahora que mañana. Che ********************************************************************* -- ********************************************************************* En la tierra hace falta personas que trabajen más y critiquen menos, que construyan más y destruyan menos, que prometan menos y resuelvan más que esperen recibir menos y dar más que digan mejor ahora que mañana. Che *********************************************************************

2 1

Re: [5/5] ddraw: Add a test for DDSD_ZBUFFERBITDEPTH and DDSD_PIXELFORMAT
by Marvin Aug. 29, 2011

Aug. 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13811 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WXPPROSP3 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WVISTAADM (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K8SE (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PRO (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (64 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091.

1 0

Re: [4/5] ddraw: Set dwZBufferBitDepth in old z buffers
by Marvin Aug. 29, 2011

Aug. 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13810 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WXPPROSP3 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WVISTAADM (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K8SE (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PRO (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (64 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091.

1 0

Re: winspool.drv/tests: Fix tracing a NULL string
by Marvin Aug. 29, 2011

Aug. 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13819 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [3/5] ddraw: Convert dwZBufferBitDepth into a DDPIXELFORMAT
by Marvin Aug. 29, 2011

Aug. 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13809 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WXPPROSP3 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WVISTAADM (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K8SE (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PRO (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (64 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091.

1 0

Re: [2/2] net: Add support for enumerating the running services with 'net start'.
by Frédéric Delanoy Aug. 29, 2011

Aug. 29, 2011

On Fri, Aug 26, 2011 at 17:41, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > Quite useful to see what services are actually running. > > programs/net/net.c | 55 ++++++++++++++++++++++++++++++++++++++++++++- > programs/net/net.rc | 4 ++- > programs/net/resources.h | 2 + > 3 files changed, 58 insertions(+), 3 deletions(-) > > diff --git a/programs/net/net.c b/programs/net/net.c > index 249c14d..ed26b43 100644 > + STRING_RUNNING, " %s\n" This one is not particularly translatable.

2 1

Re: Hebrew: update
by Yaron Shahrabani Aug. 29, 2011

Aug. 29, 2011

On Tue, Aug 23, 2011 at 12:43 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > Did you really mean not to CC wine-devel? Right sorry... > > > On Tue, 23 Aug 2011, Yaron Shahrabani wrote: > > > On Mon, Aug 22, 2011 at 3:25 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > > > > > > #: crypt32.rc:182 > > > > msgid "KeyID=" > > > > -msgstr "" > > > > +msgstr "KeyID=" > > > > > > I think you should really translate 'KeyID' In French it was translated > > > to 'ID de clé'. So assuming there is a Hebrew word for 'key' then this > > > would not remain as is. > > This appears in a certificate, it is much more useful to the user than > > the Hebrew tern (מזהה מפתח)... > > It's in a resource file which usually means the author (Juan Lang in > this case) expects it to be translated. If it's not meant to be > translated then it should either be removed from the resource file or > marked as not needing translation (I have a patch for that, maybe I'll > send it tomorrow). I'm not translating so things will be translated, I also have to make sure that the user experience is somewhat natural and pleasing, translating this string is mostly confusing. > > > > > > > -"\t/i {package|productcode} [property]\n" > > > > -"\t/package {package|productcode} [property]\n" > > > > +"\t/i {package|product_code} [property]\n" > > > > +"\t/package {package|product_code} [property]\n" > > > > > > Ideally you should translate the user-replaceable strings like 'package' > > > and 'productcode'. But option names such as '/package' should remain as > > > is of course. > > Since we have certain RTL issues with the Linux kernel (Hebrew is > > displayed in reverse) we discourage the translators to translate > > strings that would probably appear there > > > > > > > > > > msgid "DirectX Diagnostic Tool" > > > > -msgstr "" > > > > +msgstr "DirectX Diagnostic Tool" > > > > > > This is sort of a product name os it's always a bit dicey. Still, > > > wouldn't it be better if 'Diagnostic Tool' was translated? At > > > non-English speakers would understand what the purpose of the tool it. > > Wasn't quite sure if it appears in a console or GUI, can you tell? > > It is displayed in a message box (so GUI). Great, I will fix this in my next commit, for now it is perfectly fine... > > > > Since we have certain RTL issues with the Linux kernel (Hebrew is > > displayed in reverse) we discourage the translators to translate > > strings that would probably appear there > > How does the Linux kernel get involved? Using Wine on the Linux console > would be quite unusual. Usually it is run in a Gnome terminal, and Xterm > or some other GUI equivalent. Don't these do their own handling of text > independently from the Linux kernel? Most terminal emulators doesn't support RTL besides MLTerm. Wineconsole does not support Hebrew or Arabic script out of the box, there are several fonts that should be installed in order to enable that, AFAIK Arabic displayed in the right order but the letters are not joined, I can check that and get back to you. > > > [...] > > > > -msgstr "%s : File Not Found\n" > > > > +msgstr "%s: File Not Found\n" > > > [...a lot more...] > > > > > > These are not translated and do not have their place in a PO file. They > > > will prevent future translators working on this file from knowing what > > > has been translated. > > > > They better not work on this... I need this to remain untranslated > > until the Hebrew bugs in the Linux kernel will be fixed. > > In that case you should add translator comments indicating that the > string should remain untranslated for the time being. A translator > comment is a '#' followed by a space, but adding a second space so it > lines up with the others makes it nicer. For instance: > > # DO NOT TRANSLATE: needs RTL fixes to the Linux kernel > #: cmd.rc:280 > msgid "%s: File Not Found\n" > msgstr "" > > > The translator comments will be preserved through the updates. I'm translating using Virtaal, meaning I can't add comments while translating and I guess other translators as well, I look at comments but sometimes when I have many strings to translate I don't have much time to stop and read each and every one of them, it takes a lot of my (precious) time so for the sake of efficiency I let myself ignore some of them, so do other Hebrew translators, But most of us do understand that if a string is copied as-is it shouldn't be translated (Sort of convention if you like). It may seem odd but Hebrew, although a private case of Arabic is still not handled the best way it should in computing, there are still many nasty bugs so we do our best to give the Hebrew user the best experience but its still not perfect as we want it to be and we value the efforts of the developers that do help us but we understand if they have no interest and it is fine by us besides I realize there are much more important things to develop so we just leave it aside and deal with what we can deal with our given tools. Kind regards, Yaron Shahrabani. > > > > > > -- > Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ > Linux: Because rebooting is for adding new hardware

5 17

re: [3/3] (resend) usp10: draw selected glyphs in ScriptStringOut
by Dan Kegel Aug. 29, 2011

Aug. 29, 2011

Hi Aric, did you forget to include Makefile.in changes with your patch? It failed to build here: http://buildbot.kegel.com/builders/runtests/builds/70 ccache gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -o spy.o spy.c usp10.o: In function `SS_ItemOut': /home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/usp10/usp10.c:1061: undefined reference to `GetSysColor' /home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/usp10/usp10.c:1065: undefined reference to `GetSysColor' /usr/bin/ld: usp10.dll.so: hidden symbol `GetSysColor' isn't defined /usr/bin/ld: final link failed: Nonrepresentable section on output collect2: ld returned 1 exit status winegcc: ccache failed make[1]: Leaving directory `/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/usp10' make[1]: *** [usp10.dll.so] Error 2

1 0

re: kernel32: Improve GetVolumeInformation filesystem flags I set flags value according to my tests which may differ from a windows version to another.
by Dan Kegel Aug. 29, 2011

Aug. 29, 2011

Fails to build here, since it depends on the patch "include/winnet.h: Add more GetVolumeInformation system flags", but you didn't mark them as being part of a series. See "Subject Line" in http://wiki.winehq.org/SubmittingPatches volume.c: In function ‘GetVolumeInformationW’: volume.c:672: error: ‘FILE_SUPPORTS_REPARSE_POINTS’ undeclared (first use in this function) volume.c:672: error: (Each undeclared identifier is reported only once volume.c:672: error: for each function it appears in.) volume.c:672: error: ‘FILE_SUPPORTS_SPARSE_FILES’ undeclared (first use in this function) volume.c:672: error: ‘FILE_VOLUME_QUOTAS’ undeclared (first use in this function) make[1]: *** [volume.o] Error 1 You probably also want to use shorter subject lines, and move more of the patch description into the body of your message.

3 4

Documenting WineTest best practices
by Francois Gouget Aug. 29, 2011

Aug. 29, 2011

I have done a major refresh of the Wiki's conformance tests page. http://wiki.winehq.org/ConformanceTests One aspect I would like to document there is the best practices mostly for people running WineTest unattended on their computer. For instance I recently learned that one should really make sure that ntlm_auth works otherwise there will be failures. There are other things for which I don't have the answer however. In particular: * On Windows XP the firewall will ask whether to block network access to some tests. How should this be dealt with. Since WineTest is being run unattended clicking 'ok' does not work. * Similarly on Vista and Windows 7 UAC comes into play. I believe it mostly causes some tests to be skipped. So again, are there recommandations around this? * Are we interested in tests being run as an administrator or a regular user? Both? I also came across the MakeTestFailures page and it seems pretty out of date. Is maintaining a list of failing tests (still) really useful? http://wiki.winehq.org/MakeTestFailures -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

1 1

The state of IDirectSoundBuffer
by Michael Stefaniuc Aug. 29, 2011

Aug. 29, 2011

Hello guys, my tests: - http://source.winehq.org/patches/data/78080 - http://winetestbot.winehq.org/JobDetails.pl?Key=13790 - http://winetestbot.winehq.org/JobDetails.pl?Key=13791 - http://winetestbot.winehq.org/JobDetails.pl?Key=13792 - http://winetestbot.winehq.org/JobDetails.pl?Key=13793 show that native dsound has only one IDirectSoundBuffer implementation. That shouldn't matter as per the COM rules that is an implementation detail but there are broken apps out there (http://bugs.winehq.org/show_bug.cgi?id=28207) that rely on that fact. Not sure how many of the crashes due to dsound http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&namedcmd=dsound can be traced to that as PrimaryBufferImpl and IDirectSoundBufferImpl had (before my dsound changes) only the first three fields in common. Well PrimaryBufferImpl has only three fields as it stores its info in its parent object aka the device (this is a very common "design" in our dsound). Keeping the two objects/implementations in sync is brittle and will litter the code. Thus my goal is to merge PrimaryBufferImpl into IDirectSoundBufferImpl. My plan of battle is (to keep the patches small and limit the scope of the regressions I'll introduce during this): - Make the primary buffer use struct IDirectSoundBufferImpl. - Move fields that belong to the primary buffer out of struct DirectSoundDevice. The structs DirectSoundDevice and IDirectSoundBufferImpl share quite a few fields. - For methods that have the same implementation I'll use the IDirectSoundBufferImpl_<Method> - Methods that differ considerably between primary and secondary buffer I'll make IDirectSoundBufferImpl_<Method> just a wrapper that calls out into the respective implementation, something along the lines of: if(is_primary) return primarybuffer_<method>(...); else return secondarybuffer_<method>(...); - Once all methods are converted I'll switch the primary buffer to use the same vtbl. - Profit! Comments? bye michael

2 1

Re: crytpui/tests: Add tests for CryptUIDlgSelectCertificateA.
by Marvin Aug. 29, 2011

Aug. 29, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13801 Your paranoid android. === W7PROX64 (64 bit cryptui) === cryptui.c:806: Test failed: expected ERROR_SUCCESS, got 80070057 cryptui.c:840: Test failed: expected ERROR_SUCCESS, got 80070057 cryptui.c:846: Test failed: CryptUIDlgSelectCertificate failed: 80070057 cryptui.c:857: Test failed: CryptUIDlgSelectCertificate failed: 80070057 cryptui.c:869: Test failed: CryptUIDlgSelectCertificate failed: 80070057 cryptui.c:871: Test failed: display callback was not called cryptui.c:873: Test failed: the dialog box did not display certificate cryptui.c:879: Test failed: CryptUIDlgSelectCertificate failed: 80070057 cryptui.c:881: Test failed: display callback was not called cryptui.c:891: Test failed: CryptUIDlgSelectCertificate failed: 80070057 cryptui.c:899: Test failed: CryptUIDlgSelectCertificate failed: 80070057 cryptui.c:901: Test failed: TabCtrl_SetCurSel returned -559038737

1 0

re: kernel32: Add UDF support Based on Steven Wallace work. Should fix the wine side of bug #26273
by Dan Kegel Aug. 29, 2011

Aug. 29, 2011

Fails tests here? ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok fixme:volume:DefineDosDeviceW (0x00000000,L"a:",L"Z:\\home\\dank\\wineslave.dir\\sandbox\\slave\\runtests\\build\\dlls\\kernel32\\tests") DDD_RAW_TARGET_PATH flag not set, not supported yet volume.c:105: Tests skipped: can't test removing fake drive fixme:volume:GetVolumeNameForVolumeMountPointW Mounted Folders are not yet supported volume.c:359: Test failed: GetVolumeInformationA root failed, last error 66 volume.c:401: Test failed: GetVolumeInformationA with \ failed, last error 66 volume.c:423: Test failed: GetVolumeInformationA failed, last error 66 volume.c:434: Test failed: GetVolumeInformationA failed, last error 66 volume.c:445: Test failed: GetVolumeInformationA failed, root=C:\, last error=66 volume.c:451: Test failed: GetVolumeInformationA did fail, root=\\?\C:\, last error=66 volume.c:458: Test failed: GetVolumeInformationA did fail, root=\\.\C:\, last error=66 volume.c:486: Test failed: GetVolumeInformationA failed, root=\\?\Volume{00000000-0000-0000-0000-000000000043}\, last error=66 fixme:mountmgr:harddisk_ioctl returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS Command exited with non-zero status 8 0.02user 0.04system 0:00.09elapsed 80%CPU (0avgtext+0avgdata 22992maxresident)k 0inputs+0outputs (0major+5625minor)pagefaults 0swaps make[1]: *** [volume.ok] Error 8

2 1

Cmd tests timeout and splitting tests
by Octavian Voicu Aug. 29, 2011

Aug. 29, 2011

Hello, I've noticed a lot of timeouts for cmd tests lately, which is not so surprising with all the new incoming tests. I think test_builtins.cmd should be split in a few files, which would then be run separately. An added benefit is that it would permit putting tests that affect other tests in separate files. In order to fix the timeout problem it's not enough to split the tests in different files. Each file has to be run on its own from winetest. I see following solutions: 1) Hack winetest and increase timeout just for cmd.exe batch tests. 2) Allow individual tests to receive a parameter. Downside is that make_ctests needs to be changed a bit (to recognize filenames given as "test.c:param"), and a manual rule for running MAKECTESTS needs to be added to the Makefile of those tests, which would list all the tests + values for the params. 3) Add a new source file for each .cmd file. All the batch running meat would still be in batch.c, with main test function non-static. A header file with prototypes and a macro for defining a test would be included in subsequent tests. I would go for number 3, I think it's the cleanest solution (although it would add a few more source files). Any comments on that? Octavian

3 3

Re: [PATCH] explorer: Try ShellExecute if the parameter isn't a directory (try 2)
by Jay Yang Aug. 29, 2011

Aug. 29, 2011

On 08/29/2011 04:08 AM, Jay Yang wrote: > Changes from last time: > Fixed a build issue. > > --- > programs/explorer/Makefile.in | 2 +- > programs/explorer/explorer.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletions(-) > > sorry, thunderbird seems to have sent to old file

1 0

re: Cmd tests timeout and splitting tests
by Dan Kegel Aug. 28, 2011

Aug. 28, 2011

Hi Octavian, the intention was to just add new TESTCMD resources into rsrc.rc when test_builtins.cmd got too big.... but I never thought the tests would be so slow, splitting them by adding new rsrc.rc entries wouldn't help a timeout problem. I'd go for solution #3, too, but it's troubling that test names would be duplicated in the Makefile.in and in rsrc.rc. An awful thought just occurred to me: we could make test_builtins.cmd itself take a parameter saying which subtest to run. That would avoid needing to modify rsrc.rc, but you'd still need to figure out how to iterate through the tests. - Dan

1 0

re: rpcrt4:properly unmarshall EMUM16 discriminant
by Dan Kegel Aug. 28, 2011

Aug. 28, 2011

Didn't apply here: $ git apply text fatal: corrupt patch at line 15 Looks like your email program word-wrapped both this and your other patch. Try attaching the patches instead.

3 5

re: [po]updated korean resource
by Dan Kegel Aug. 28, 2011

Aug. 28, 2011

Patch failed to apply here: patching file po//ko.po Hunk #1 succeeded at 775 (offset -4 lines). Hunk #2 succeeded at 783 (offset -4 lines). Hunk #3 succeeded at 798 (offset -4 lines). Hunk #4 FAILED at 8714. Hunk #5 FAILED at 8809. Hunk #6 succeeded at 8812 (offset -23 lines). Hunk #7 FAILED at 8968. Hunk #8 succeeded at 10220 (offset -25 lines). 3 out of 8 hunks FAILED -- saving rejects to file po//ko.po.rej Also, please send plain text email next time (but still with the patch as an attachment).

2 3

re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 2)
by Dan Kegel Aug. 28, 2011

Aug. 28, 2011

Hi Christian, your patch causes test failures in programs/cmd/tests here: ... batch.c:301: Test failed: unexpected char 0x41 position 0 in line 545 (got 'ATTRIB - Displays or changes file attributes.', wanted 'not-r.test not found after delete, good') batch.c:295: Test failed: unexpected end of line 546 (got '', wanted 'r.test found before delete, good') - Dan

1 0

Re: services: Remove an unused variable.
by Frédéric Delanoy Aug. 27, 2011

Aug. 27, 2011

On Fri, Aug 26, 2011 at 17:35, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > Totally independent from my other (futur) services patches. > > programs/services/services.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/programs/services/services.c b/programs/services/services.c > index 35edbba..ff824bc 100644 > --- a/programs/services/services.c > +++ b/programs/services/services.c > @@ -289,12 +289,11 @@ static void scmdatabase_autostart_services(struct scmdatabase *db) > size = i; > for (i = 0; i < size; i++) > { > - DWORD err; > const WCHAR *argv[2]; > service = services_list[i]; > argv[0] = service->name; > argv[1] = NULL; > - err = service_start(service, 1, argv); > + service_start(service, 1, argv); > /* FIXME: do something if the service failed to start */ > release_service(service); > } Wouldn't it be better to do something with err rather than muting (as the comment suggests)?

2 2

Re: [6/6] cmd/tests: Add tests for mixed echo modes
by Marvin Aug. 26, 2011

Aug. 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13762 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x66 position 0 in line 141 (got 'foo ', wanted 'foo7(a)space@@or_broken(a)foo@space@') batch.c:301: Test failed: unexpected char 0x66 position 0 in line 142 (got 'foo ', wanted 'foo9(a)space@@or_broken(a)foo@space@')

1 0

Re: [5/6] cmd/tests: Add tests for redirections within IF statements
by Marvin Aug. 26, 2011

Aug. 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13761 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x66 position 0 in line 126 (got 'foo ', wanted 'foo7(a)space@@or_broken(a)foo@space@') batch.c:301: Test failed: unexpected char 0x66 position 0 in line 127 (got 'foo ', wanted 'foo9(a)space@@or_broken(a)foo@space@')

1 0

Re: [3/6] cmd: Fix redirection handle parsing
by Marvin Aug. 26, 2011

Aug. 26, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13760 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x66 position 0 in line 126 (got 'foo ', wanted 'foo7(a)space@@or_broken(a)foo@space@') batch.c:301: Test failed: unexpected char 0x66 position 0 in line 127 (got 'foo ', wanted 'foo9(a)space@@or_broken(a)foo@space@')

1 0

Testing edge cases and undocumented behavior
by Scott Ritchie Aug. 26, 2011

Aug. 26, 2011

There was a bit of a philosophical discussion on #winehackers about the merits of creating tests for functions that might be testing undefined or unimportant behavior. Windows behaves one way, we behave another, the tests measure this delta, but it's unknown if this will actually improve a real world application. There's always regression potential with any code change, however on balance adding more (fixed) tests should on average reduce that risk. Are the tests themselves evidence that a change is needed? More broadly, should we resist any change without a particular (real-world) application in hand that needs it? Or should we err on the side of testable behavior, because somewhere out there a Windows developer may have written an app the same way the test author did? Thanks, Scott Ritchie

3 4

Testing edge cases and undocumented behavior
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 26, 2011

Aug. 26, 2011

Vincent Povirk wrote: >A test that passes on Windows and fails on Wine is not sufficient to >motivate a change to Wine. I wished Wine had "wine_dont" beside "todo_wine". Exact same behaviour, it justs reads differently. 2 examples: mmdevapi has a bug where after Initialize(SHARED, unsupported_format) is returned with an error, Initialize(SHARED, supported_format) fails with ALREADY_INITIALIZED, yet the device is unusable. I've written tests to detect this, because I want to know if MS fixes that in w8, but I don't advise Wine to mimic that behavior now. if (mode == SHARED && ...) wine_dont ok(hr == E_ALREADY_INITIALIZED, "Initialize #2 returned %08u\n", hr); else ok(hr == S_OK, "Initialize #2 returned %08u\n", hr); Should MS fix the apparent bug, remove the 3 topmost lines. The MIDI player MCISEQ.DLL was obviously rewritten for NT: my tests reveal numerous differences in the details. Most visible: the MCI_RESUME command was dropped. In w9x, an app could implement: if (window_msg == lost_focus) mciSendCommand("Pause all"); if (window_msg == got_focus) mciSendCommand("Resume all"); and it would continue playing A/V where it left off. Since NT/XP, it'll loose music after its window is activated again. Wine's MCI supports the Resume command, presumably because it was written in 1999. I've put some todo_wine in the MCI tests that should read wine_dont instead of todo_wine because I don't want somebody to come by and "fix" the deviation from XP by dropping the Resume command. Regards, Jörg Höhle

2 1