August 2011 - Wine-Devel - list.winehq.org

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13562 Your paranoid android. === W2KPROSP4 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === WXPPROSP3 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W2K3R2SESP2 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === WVISTAADM (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W2K8SE (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W7PRO (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W7PROX64 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format

1 0

mshtml: Use the last colon in proxy url as port separator
by Juan Lang Aug. 22, 2011

Aug. 22, 2011

Hi André, > http://domain\user:password(a)server.com:8080 makes it visible that it's intended to get the last colon What about http://domain\user:password(a)server.com? password isn't the port number. --Juan

4 7

The sad state of audio GetPosition
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 22, 2011

Aug. 22, 2011

Hi, the good news first: I've some code which seems to return the "position of the sample that is currently playing through the speakers" that MSDN requires GetPosition to return. It passes my mmdevapi rendering tests when used with ALSA's dmix and hw:0 devices. The new WinMM over mmdevapi depends on GetPosition for its buffer management. Hence a correct GetPosition seems essential for Wine. The bad news: I've logs which unambiguously prove that at least in Ubuntu Lucid (2010), PulseAudio yields values of snd_pcm_avail_update and snd_pcm_delay that are completely inadequate to compute what GetPosition should return. I'll write more about that in the ALSA or PA mailing list. Before doing that, I'd like to sample the behaviour of my rendering tests on a few machines. You'll find the executable at http://testbot.winehq.org/JobDetails.pl?Key=13489 I'm interested in results from: - Linux, esp. with something newer than Ubuntu Lucid, or different sound cards. - Native, because testbot shows some failures and I'd like to see results from real machines, not vmware. Beware: - Ignore the test failures about IsFormatSupported/Initialize. I'm misusing ok() for reporting. - Please send the complete log, not the short form with failures only, because the test now loops twice: once for SHARED mode, once for EXCLUSIVE. Without the complete log, it's not possible to tell from the line number only which mode is in use. - The test may crash in Wine, after my loop, in test_session, because sometimes Initialize fails and the test doesn't catch that. Testbot shows failures such as: render.c:1034: Test failed: Position 56880 too far after 1070ms render.c:1035: Test failed: Position delta 5712 not regular I've yet to analyse testbot's logs in detail. - "Position delta" means that after 100ms, one expects the speaker position to advance by ~4800 (or 48000) positions. How come it can be 5712? - "Position too far" means that after 1000ms of playing, the speaker position cannot be larger than FramesPerSecond (modulo Frequency). How can it be 56880 when I expect 48000? (modulo some period increments) Regards, Jörg Höhle

3 12

Re: [2/2] dinput8/tests: Tests for DIPROP_USERNAME property
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13553 Your paranoid android. === W7PROX64 (64 bit device) === device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"winetest", got=L"\0488W" device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"winetest", got=L"\0488W" device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"Ninja Brian", got=L"\0488W" device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"Ninja Brian", got=L"\0488W"

1 0

Re: [1/2] dinput8/tests: Moved EnumDevicesBySemantics specific tests to dinput.c and added a couple more
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13552 Your paranoid android. === W7PROX64 (64 bit dinput) === dinput.c:550: Test failed: This user should own no devices owned=2

1 0

Re: wine-devel Digest, Vol 73, Issue 58
by Michael Ost Aug. 22, 2011

Aug. 22, 2011

Louis, I wonder if the patch referred to here is relevant for the device detection we need for the ilok...? I'm kinda shooting in the dark, without much background, but the message jumped out at me. - mo On 08/22/2011 08:06 AM, wine-devel-request(a)winehq.org wrote: > Message: 3 > Date: Mon, 22 Aug 2011 14:34:59 +0200 (CEST) > From: Francois Gouget<fgouget(a)free.fr> > Subject: Re: [PATCH] mountmgr: Support the dbus service udisks for > dynamic devices :-) [try 5] > To: wine-devel(a)winehq.org > Cc: Detlef Riekenberg<wine.dev(a)web.de>, wine-patches(a)winehq.org > Message-ID:<alpine.DEB.2.02.1108221431200.19831(a)amboise.dolphin> > Content-Type: text/plain; charset="iso-8859-15" > > On Tue, 16 Aug 2011, Detlef Riekenberg wrote: > [...] >> Recent distributions depend on udisks, so the libhal development package >> should be uninstalled or disabled when building Wine (--without-hal). > > I don't understand this recommendation to build with '--without-hal'. > > It should be possible to build a Wine binary that will run on both old > HAL-based Linux distributions and the new usdisks-based ones. Such a > binary would need to be built with both HAL and udisks support. Are you > saying your patch makes that is impossible?

1 1

Re: mmdevapi: After GetBuffer, refuse Reset, but Start/Stop is ok.
by Andrew Eikum Aug. 22, 2011

Aug. 22, 2011

On Mon, Aug 22, 2011 at 10:56:29AM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > My tests also show that a GetBuffer/ReleaseBuffer pair is left > undisturbed by Stop/Start in between. Fortunately, this > has no effect on the current code (but it shows that Stop must > not change This->held_frames or the write_pos). > Could you add tests to render.c showing this? Andrew

2 1

Re: ntdll: While requesting TokenGroups calculate required user buffer size in server (try2)
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > + SERVER_START_REQ( get_token_groups ) > { > - need_more_memory = FALSE; > + TOKEN_GROUPS *groups = tokeninfo; > + void *buffer; > > - SERVER_START_REQ( get_token_groups ) > - { > - TOKEN_GROUPS *groups = tokeninfo; > + /* reply buffer is always shorter than output one */ > + buffer = tokeninfolength ? RtlAllocateHeap(GetProcessHeap(), 0, tokeninfolength) : NULL; Please avoid complex operation like heap allocations inside a server request block. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools/wine.inf: Add registry key HKLM, %CurrentVersionNT%, "ProductName"
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > Hi, this fixes http://bugs.winehq.org/show_bug.cgi?id=28065 This would need to be updated when the version is changed in winecfg. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Hebrew: update
by Francois Gouget Aug. 22, 2011

Aug. 22, 2011

> #: crypt32.rc:182 > msgid "KeyID=" > -msgstr "" > +msgstr "KeyID=" I think you should really translate 'KeyID' In French it was translated to 'ID de clé'. So assuming there is a Hebrew word for 'key' then this would not remain as is. > -"\t/i {package|productcode} [property]\n" > -"\t/package {package|productcode} [property]\n" > +"\t/i {package|product_code} [property]\n" > +"\t/package {package|product_code} [property]\n" Ideally you should translate the user-replaceable strings like 'package' and 'productcode'. But option names such as '/package' should remain as is of course. > msgid "DirectX Diagnostic Tool" > -msgstr "" > +msgstr "DirectX Diagnostic Tool" This is sort of a product name os it's always a bit dicey. Still, wouldn't it be better if 'Diagnostic Tool' was translated? At non-English speakers would understand what the purpose of the tool it. > "/Unix Use a Unix filename and start the file like windows explorer.\n" > "/ProgIDOpen Open a document using the following progID.\n" > "/L Show end-user license.\n" > +"/? Display this help and exit.\n" > "\n" > "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" > "Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n" Nothing is translated here. This whole msgstr should be removed. > msgid "RENAME <filename> renames a file.\n" > -msgstr "RENAME <filename> renames a file\n" > +msgstr "RENAME <filename> renames a file.\n" [...] > msgid "VER displays the version of cmd you are running.\n" > -msgstr "VER displays the version of cmd you are running\n" > +msgstr "VER displays the version of cmd you are running.\n" [...] > msgstr "" > +"ENDLOCAL ends localization of environment changes in a batch file\n" > +"which were introduced by a preceding SETLOCAL.\n" [...] > -msgstr "%s : File Not Found\n" > +msgstr "%s: File Not Found\n" [...a lot more...] These are not translated and do not have their place in a PO file. They will prevent future translators working on this file from knowing what has been translated. These totally prevent the patch from going in as is. Please fix it and resubmit. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: [1/3] wined3d: Constant load optimisations
by Henri Verbeet Aug. 22, 2011

Aug. 22, 2011

On 20 August 2011 18:46, Norbert Lataille <nlataill(a)gmail.com> wrote: > Performance gains (for parts 1/2/3) on WoW: > http://norbert.lataille.free.fr/constants.html > Results for 3dmark06, X3: http://norbert.lataille.free.fr/perf.html > (line: Constants). > Do you have those in a reasonable format as well?

3 5

Re: [PATCH] mountmgr: Support the dbus service udisks for dynamic devices :-) [try 5]
by Francois Gouget Aug. 22, 2011

Aug. 22, 2011

On Tue, 16 Aug 2011, Detlef Riekenberg wrote: [...] > Recent distributions depend on udisks, so the libhal development package > should be uninstalled or disabled when building Wine (--without-hal). I don't understand this recommendation to build with '--without-hal'. It should be possible to build a Wine binary that will run on both old HAL-based Linux distributions and the new usdisks-based ones. Such a binary would need to be built with both HAL and udisks support. Are you saying your patch makes that is impossible? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Vote Electronique: Les gens qui votent ne décident rien. Ceux qui comptent les votes décident de tout.

1 0

Re: [3/3]usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13546 Your paranoid android. === W2KPROSP4 (32 bit usp10) === usp10.c:1931: Test failed: ScriptCPtoX trailing: iCP=8 should return piX=0 not 0

1 0

Re: server: correctly map mutex acces rights
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13534 Your paranoid android. === W7PROX64 (64 bit sync) === sync.c:160: Test failed: WaitForSingleObject succeeded sync.c:177: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5

1 0

Re: [PATCH 9/9] wscript: add textstream.c; implement Host_get_StdOut
by Octavian Voicu Aug. 22, 2011

Aug. 22, 2011

On Mon, Aug 22, 2011 at 1:54 PM, Michał Ziętek wrote: > +static HRESULT WINAPI TextStream_QueryInterface(ITextStream *iface, REFIID riid, void **ppv) > +{ > + WINE_TRACE("(%s %p)\n", wine_dbgstr_guid(riid), ppv); > + > + if(IsEqualGUID(&IID_IUnknown, riid) > + || IsEqualGUID(&IID_IDispatch, riid) > + || IsEqualGUID(&IID_IArguments2, riid)) { Hello, There's a copy-paste typo here. Cheers, Octavian

1 0

Re: [PATCH 5/5] shell32: Implement a default property sheet for file system objects
by Nikolay Sivov Aug. 22, 2011

Aug. 22, 2011

On 8/21/2011 19:21, Jay Yang wrote: > + LoadStringA(shell32_hInstance,IDS_PROPSHEET_VARIOUS, > + various_str,sizeof(various_str)); > + LoadStringW(shell32_hInstance,IDS_PROPSHEET_COUNT_FORMAT, > + count_format,sizeof(count_format)/sizeof(WCHAR)); Why -A call here? > + WCHAR count_str[64]; Again some magic. > +static INT_PTR DefaultPropSheet_OnNotify(HWND hwndDlg,WPARAM wParam, NMHDR *header) > +{ > + switch(header->code) > + { > + case PSN_APPLY: > + { > + UINT index; > + PROPSHEETPAGEW *page; > + DefaultPropSheet *propsheet; > + WCHAR name[MAX_PATH]; > + UINT readonly_state, hidden_state; > + UINT i; > + index = SendMessageW(GetParent(hwndDlg),PSM_HWNDTOINDEX,(WPARAM)hwndDlg,0); > + page = (PROPSHEETPAGEW*)SendMessageW(GetParent(hwndDlg),PSM_INDEXTOPAGE,index,0); > + propsheet = (DefaultPropSheet*)page->lParam; > + > + /*set name*/ > + if(propsheet->cidl==1) > + { > + BOOL is_folder; > + LPCITEMIDLIST pidl_child; > + LPITEMIDLIST pidl,pidl_new,pidl_child_new,temp; > + IShellFolder *folder; > + WCHAR old_name[MAX_PATH]; > + GetDlgItemTextW(hwndDlg,IDC_PROPSHEET_NAME,name,sizeof(name)/sizeof(WCHAR)); > + pidl = ILCombine(propsheet->folder_pidl,propsheet->apidl[0]); > + is_folder = _ILIsFolder(pidl); > + temp = ILClone(pidl); > + ILRemoveLastID(temp); > + SHBindToParent(pidl,&IID_IShellFolder,(void**)&folder,&pidl_child); > + ILGetDisplayNameExW(folder, pidl_child, old_name,SHGDN_NORMAL); > + if(strcmpW(old_name,name)!=0) > + { > + if(SUCCEEDED(IShellFolder_SetNameOf(folder,hwndDlg,pidl_child,name,SHGDN_NORMAL,&pidl_child_new))) > + { > + pidl_new = ILCombine(temp,pidl_child_new); > + SHChangeNotify(is_folder ? SHCNE_RENAMEFOLDER : SHCNE_RENAMEITEM,SHCNF_IDLIST,pidl,pidl_new); > + ILFree(pidl_child_new); > + ILFree(pidl_new); > + } > + } > + ILFree(temp); > + ILFree(pidl); > + IShellFolder_Release(folder); > + } > + /*set readonly/hidden*/ > + readonly_state = IsDlgButtonChecked(hwndDlg,IDC_PROPSHEET_READONLY); > + hidden_state = IsDlgButtonChecked(hwndDlg,IDC_PROPSHEET_HIDDEN); > + for(i=0;i<propsheet->cidl;i++) > + { > + LPITEMIDLIST pidl; > + WCHAR path[MAX_PATH]; > + DWORD attributes; > + pidl = ILCombine(propsheet->folder_pidl,propsheet->apidl[0]); > + SHGetPathFromIDListW(pidl,path); > + ILFree(pidl); > + attributes = GetFileAttributesW(path); > + switch(readonly_state) > + { > + case BST_CHECKED: > + attributes |= FILE_ATTRIBUTE_READONLY; > + break; > + case BST_UNCHECKED: > + attributes&= ~FILE_ATTRIBUTE_READONLY; > + break; > + } > + switch(hidden_state) > + { > + case BST_CHECKED: > + attributes |= FILE_ATTRIBUTE_HIDDEN; > + break; > + case BST_UNCHECKED: > + attributes&= ~FILE_ATTRIBUTE_HIDDEN; > + break; > + } > + SetFileAttributesW(path,attributes); > + } > + break; > + } > + case PSN_RESET: > + { > + UINT index; > + PROPSHEETPAGEW *page; > + DefaultPropSheet *propsheet; > + index = SendMessageW(GetParent(hwndDlg),PSM_HWNDTOINDEX,(WPARAM)hwndDlg,0); > + page = (PROPSHEETPAGEW*)SendMessageW(GetParent(hwndDlg),PSM_INDEXTOPAGE,index,0); > + propsheet = ((DefaultPropSheet*)page->lParam); > + IShellPropSheetExt_Release(&propsheet->IShellPropSheetExt_iface); > + } Missed 'break' probably? > + default: > + return FALSE; > + } > + return TRUE; > +}

1 0

Re: [PATCH 3/5] shell32: Implement SHOpenPropSheet
by Nikolay Sivov Aug. 22, 2011

Aug. 22, 2011

On 8/21/2011 19:20, Jay Yang wrote: > --- > dlls/shell32/shell32.spec | 3 ++ > dlls/shell32/shellord.c | 88 +++++++++++++++++++++++++++++++++++++++++++++ > include/shlobj.h | 4 ++ > 3 files changed, 95 insertions(+), 0 deletions(-) It's not clear for me why you placed this in shellord.c, it's supposed to contain exported by ordinal calls only, as I understand it. If Julliard approves new file for propsheets then you should place this in it. IMO it's ok to place all of this in shlmenu.c for example. > +BOOL WINAPI SHOpenPropSheetA(LPCSTR pszCaption, HKEY *ahkey, UINT ckeys, const CLSID *pclsidDef, IDataObject *pdtobj, IShellBrowser *psb, LPCSTR pStartPage) > +{ > + BOOL ret; > + LPWSTR wszCaption,wszStartPage; > + UINT length; > + length = MultiByteToWideChar(CP_ACP, 0, pszCaption, -1, NULL, 0); > + wszCaption = HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*length); > + length = MultiByteToWideChar(CP_ACP, 0, pszCaption, -1, wszCaption, length); > + length = MultiByteToWideChar(CP_ACP, 0, pStartPage, -1, NULL, 0); > + wszStartPage = HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*length); > + length = MultiByteToWideChar(CP_ACP, 0, pStartPage, -1, wszStartPage, length); > + ret = SHOpenPropSheetW(wszCaption,ahkey,ckeys,pclsidDef,pdtobj,psb,wszStartPage); > + HeapFree(GetProcessHeap(),0,wszCaption); > + HeapFree(GetProcessHeap(),0,wszStartPage); > + return ret; > +} Hmm, actually there's HEAP_strdupAtoW() for that (you need to make in non-static though). > + ZeroMemory(&psh, sizeof(PROPSHEETHEADERW)); > + psh.dwSize = sizeof (PROPSHEETHEADERW); > + psh.hwndParent = NULL; > + psh.dwFlags = PSH_PROPTITLE; > + if(pStartPage) > + { > + psh.dwFlags |= PSH_USEPSTARTPAGE; > + psh.u2.pStartPage = pStartPage; > + } Please don't mix tabs with spaces, use 4 spaces everywhere. > + if(pszCaption) > + psh.pszCaption = pszCaption; > + else > + psh.pszCaption = empty_str; Is it really needed? I mean pszCaption == NULL is not the same as empty string in this context? > + IShellPropSheetExt *def_ext; > + IShellExtInit *init_iface; > + PROPSHEETHEADERW psh; > + HPROPSHEETPAGE pages[99]; It's not clear again where this size comes from, just enough for anyone? Also I think it's better to reduce scope as much as possible, def_ext doesn't need to be global for example.

1 0

Re: [PATCH 2/5] shell32: Use SHCreateDefaultContextMenu to create context menus (try 2)
by Nikolay Sivov Aug. 22, 2011

Aug. 22, 2011

On 8/21/2011 19:20, Jay Yang wrote: > Changes from last time: > > Factored out the code to find the registry keys for the extensions. > > --- > dlls/shell32/classes.c | 47 +++++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32_main.h | 1 + > dlls/shell32/shfldr.h | 9 +++++++ > dlls/shell32/shfldr_desktop.c | 8 ++---- > dlls/shell32/shfldr_fs.c | 7 +---- > dlls/shell32/shfldr_mycomp.c | 4 +-- > dlls/shell32/shfldr_unixfs.c | 11 ++++++--- > dlls/shell32/shlmenu.c | 40 ++++++++++++++++++++++++++++++++++ > dlls/shell32/shlview.c | 44 +++++++++++++++++++++++++------------- > 9 files changed, 139 insertions(+), 32 deletions(-) > +HRESULT SHELL_CreateItemContextMenu(HWND hwnd, IShellFolder *folder, > + LPITEMIDLIST folder_pidl, > + LPCITEMIDLIST *apidl, UINT cidl, > + REFIID riid, void **ppv) > +{ > + DEFCONTEXTMENU menu_info = {hwnd,NULL,folder_pidl,folder,cidl,apidl,NULL,0,NULL}; > + UINT cKeys = 0; > + HKEY aKeys[16] = {NULL}; Where size of 16 comes from? > + UINT i; > + HRESULT hres; > + cKeys = HCR_GetExtensionsKeysForPidl(apidl[0],aKeys); > + menu_info.cKeys=cKeys; > + menu_info.aKeys=aKeys; > + hres = SHCreateDefaultContextMenu(&menu_info,riid,ppv); > + for(i=0;i<cKeys;i++) > + if(aKeys[i]) > + RegCloseKey(aKeys[i]); RegCloseKey already check for NULL handle. > + hr = IShellFolder_CreateViewObject(This->pSFParent,This->hWndParent,&IID_IContextMenu,(void**)&pCM); > + if(FAILED(hr)){ > + LPITEMIDLIST folder_pidl; > + IPersistFolder2 *persist; > + IShellFolder_QueryInterface(This->pSFParent,&IID_IPersistFolder2,(void**)&persist); > + IPersistFolder2_GetCurFolder(persist,&folder_pidl); > + IPersistFolder2_Release(persist); > + hr= SHELL_CreateBackgroundContextMenu(This->hWndParent,This->pSFParent, > + folder_pidl,&IID_IContextMenu, > + (void**)&pCM); > + ILFree(folder_pidl); > + } I'm not sure about that, but it looks like it deserves some check for 'persist' pointer. Or better a return value being S_OK (from query).

1 0

Re: [PATCH 1/5] shell32: Implement loading of context menu shell extensions (try 3)
by Nikolay Sivov Aug. 22, 2011

Aug. 22, 2011

On 8/21/2011 19:20, Jay Yang wrote: > The first two patches in the sequence relate to context menus and the last three to property sheets, > but some of the changes in the last three depend on a function I created in the second patch so I've > sent them as a sequence. > > Changes from last time (for this file): > cleaned up the code. > > --- > dlls/shell32/shlmenu.c | 170 ++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 166 insertions(+), 4 deletions(-) > + HKEY *new_keys=NULL; > > + new_keys = HeapAlloc(GetProcessHeap(),0,sizeof(HKEY)*cKeys); No need to initialize that explicitly. > + ULONG status = RegOpenKeyExW(aKeys[i],cmenu_handler_key,0,KEY_READ,&new_key); > + if(status==ERROR_SUCCESS) This call return LSTATUS which is signed LONG. A common way to test return value is to use (!RegOpen*()). > + CLSID *clsid_table=NULL; ... > + clsid_table = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(CLSID)*handler_count); Same here, no need to NULL it. > + static const CLSID zero_clsid = {0}; > + CLSID *curr_clsid = clsid_table+j; > + if(IsEqualCLSID(curr_clsid,&zero_clsid)) There's CLSID_NULL for that. > + TRACE("Loading shell extension with clsid %s\n",shdebugstr_guid(&id)); I'm not sure shdebugstr_guid() is supposed to know shell extension names. > + if(new_keys[i]) > + RegCloseKey(new_keys[i]); This null check is redundant.

1 0

re: [2/3] wined3d: Constant load optimisations
by Dan Kegel Aug. 22, 2011

Aug. 22, 2011

Hi Norbert, patch 2/3 has a couple failures here: http://buildbot.kegel.com/builders/runtests/builds/104 ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok ... visual.c:4991: Test failed: quad 1 has color 00000000, expected 0x00bfbf80 visual.c:4998: Test failed: quad 3 has color 00000000, expected 0x00bfbf80 visual.c:5143: Test failed: quad 4 has color 00000000, expected 0x00bfbf80 patch 3/3 has lots of failures here: http://buildbot.kegel.com/builders/runtests/builds/105 ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok fixme:win:EnumDisplayDevicesW ((null),0,0x32f5ac,0x00000000), stub! fixme:d3d_draw:drawPrimitive Using software emulation because manual fog coordinates are provided visual.c:739: Test failed: RCP test returned color 0x00ffffff, expected 0x00808080. visual.c:769: Test failed: RSQ test returned color 0x00ffffff, expected 0x00b4b4b4. ... visual.c:4991: Test failed: quad 1 has color 00000000, expected 0x00bfbf80 visual.c:4998: Test failed: quad 3 has color 00000000, expected 0x00bfbf80 visual.c:5143: Test failed: quad 4 has color 00000000, expected 0x00bfbf80 ... Here's my system description: os: Ubuntu 11.04, 2.6.38-10-generic-pae, pulseaudio 0.9.22-24-g67d18, Advanced Linux Sound Architecture Driver Version 1.0.23. ram: 4020 MB cpu: Intel(R) Core(TM)2 Quad CPU Q9300 @ 2.50GHz gpu: GeForce 8500 GT/PCI/SSE2 3.3.0 NVIDIA 270.41.06

2 5

buildbot status
by Dan Kegel Aug. 22, 2011

Aug. 22, 2011

The bot found a real problem again in someone's patch today. Mail is not yet automated, so I let the author know by hand. Because several people asked whether they could run headless slaves, I added headless support; now if DISPLAY is not set, the bot won't try to run any tests known to fail with DISPLAY unset. We'll probably group the headless servers differently, and use them for specialized tests (e.g. builds with different compilers). Because someone expressed interest in running on Debian Squeeze, I tried running the demo on that OS, and cleaned up a couple issues that turned up. readme-wine.txt now suggests starting the master before the slave, to avoid a spurious error message. The master fell over this morning, not sure why. So its max uptime so far is something like three days. - Dan

1 0

Re: wined3d: invalidate streamsrc, vdecl and indexbuffer after strided draws
by Henri Verbeet Aug. 21, 2011

Aug. 21, 2011

On 21 August 2011 23:25, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + * provided strided data has ovwritten pretty much the entire vertex and Typo. > + * and index stream related states */ Missing punctuation.

2 1

re: [2/3] ntdll: While requesting TokenGroups calculate required user buffer size in server
by Dan Kegel Aug. 21, 2011

Aug. 21, 2011

Doesn't build here: reply->user_len = FIELD_OFFSET( TOKEN_GROUPS, Groups[group_count] ) + sid_size); token.c: In function ‘req_get_token_groups’: token.c:1319:87: error: expected ‘;’ before ‘)’ token token.c:1319:87: error: expected statement before ‘)’ token http://buildbot.kegel.com/builders/runtests/builds/110

2 2

Re: wined3d: Add WINED3D_BUFFER_HASDESC at index buffer creation
by Henri Verbeet Aug. 21, 2011

Aug. 21, 2011

On 20 August 2011 18:46, Norbert Lataille <nlataill(a)gmail.com> wrote: > Patch is forcing WINED3D_BUFFER_HASDESC flag at Index Buffer creation time, I doubt this works properly, unloads will drop it again.

2 1

re: [PATCH 01/10] cmd: Use CSTR_* instead of hardcoded values as result of CompareStringW
by Dan Kegel Aug. 21, 2011

Aug. 21, 2011

Hi Frédéric, your patch series seems to have failed the cmd tests: batch.c:259: Test failed: unexpected char 0x53 position 0 in line 301 (got 'Syntax error', wanted '1') batch.c:259: Test failed: unexpected char 0x31 position 0 in line 302 (got '1', wanted '3') batch.c:259: Test failed: unexpected char 0x33 position 0 in line 303 (got '3', wanted '5') See http://buildbot.kegel.com/builders/runtests/builds/86 I'll change the buildbot so it tests each subset of a patch series, and pinpoint the one that broke things. Incidentally, that 'Syntax error' probably should go to stderr; and since the cmd tests ignore stderr, that might fix your failure.

3 16