August 2011 - Wine-Devel - list.winehq.org

Re: [7/7] msi/tests: Clean up local packages.
by Marvin Aug. 23, 2011

Aug. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13576 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5997: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [6/7] msi: Remove icons when the product is uninstalled.
by Marvin Aug. 23, 2011

Aug. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13575 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 2/4] shell32: Register standard known folders on initialization.
by Alexandre Julliard Aug. 23, 2011

Aug. 23, 2011

Mariusz Pluciński <vshader(a)gmail.com> writes: > + for(i=0; i < sizeof(CSIDL_Data)/sizeof(CSIDL_Data[0]); ++i) > + { > + if(!CSIDL_Data[i].szValueName) > + { > + FIXME("known folder %d has no value name, ignoring\n", i); > + continue; > + } > + > + /* FIXME: remove this check after fixing all known folders definitions */ > + if(is_knownfolder_registered(CSIDL_Data[i].id)) > + { > + FIXME("known folder %d already registered, ignoring\n", i); > + continue; > + } It's pretty annoying to see these fixmes on every prefix update. You don't need them anyway, what needs to be done is clear from the code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] GNU/kFreeBSD detection
by Alexandre Julliard Aug. 23, 2011

Aug. 23, 2011

Robert Millan <rmh(a)debian.org> writes: > diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h > index 05adf31..cf389fb 100644 > --- a/tools/winebuild/build.h > +++ b/tools/winebuild/build.h > @@ -148,6 +148,7 @@ enum target_platform > PLATFORM_UNSPECIFIED, > PLATFORM_APPLE, > PLATFORM_FREEBSD, > + PLATFORM_GNUKFREEBSD, > PLATFORM_SOLARIS, > PLATFORM_WINDOWS > }; If it doesn't need a different behavior there's no need for a new platform, just use PLATFORM_FREEBSD. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: mshtml: Use wininet to get and parse the proxy (try 2)
by André Hentschel Aug. 23, 2011

Aug. 23, 2011

please ignore also that one. APPINFO_QueryOption needs to be fixed first Am 20.08.2011 17:19, schrieb André Hentschel: > > fixed the leak > --- > dlls/mshtml/nsembed.c | 62 +++++++++++++++++++++++------------------------- > 1 files changed, 30 insertions(+), 32 deletions(-) > > diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c > index 2bebf8b..c2581e6 100644 > --- a/dlls/mshtml/nsembed.c > +++ b/dlls/mshtml/nsembed.c > @@ -27,6 +27,7 @@ > #include "winbase.h" > #include "winuser.h" > #include "winreg.h" > +#include "wininet.h" > #include "ole2.h" > #include "shlobj.h" > > @@ -488,51 +489,48 @@ static void set_lang(nsIPrefBranch *pref) > > static void set_proxy(nsIPrefBranch *pref) > { > - char proxy[512]; > - char * proxy_port; > - int proxy_port_num; > - DWORD enabled = 0, res, size, type; > - HKEY hkey; > + CHAR hostname[INTERNET_MAX_HOST_NAME_LENGTH]; > + URL_COMPONENTSA UrlComponents; > + INTERNET_PROXY_INFOA *pi; > + DWORD size; > > - static const WCHAR proxy_keyW[] = > - {'S','o','f','t','w','a','r','e', > - '\\','M','i','c','r','o','s','o','f','t', > - '\\','W','i','n','d','o','w','s', > - '\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n', > - '\\','I','n','t','e','r','n','e','t',' ','S','e','t','t','i','n','g','s',0}; > + InternetQueryOptionA(NULL, INTERNET_OPTION_PROXY, NULL, &size); > + if (!size) return; > > - res = RegOpenKeyW(HKEY_CURRENT_USER, proxy_keyW, &hkey); > - if(res != ERROR_SUCCESS) > - return; > + pi = heap_alloc(size); > + if (!pi) return; > > - size = sizeof(enabled); > - res = RegQueryValueExA(hkey, "ProxyEnable", 0, &type, (LPBYTE)&enabled, &size); > - if(res != ERROR_SUCCESS || type != REG_DWORD || enabled == 0) > + if(!InternetQueryOptionA(NULL, INTERNET_OPTION_PROXY, pi, &size)) > { > - RegCloseKey(hkey); > + heap_free(pi); > return; > } > > - size = sizeof(proxy); > - res = RegQueryValueExA(hkey, "ProxyServer", 0, &type, (LPBYTE)proxy, &size); > - RegCloseKey(hkey); > - if(res != ERROR_SUCCESS || type != REG_SZ) > - return; > + if (pi->dwAccessType != INTERNET_OPEN_TYPE_PROXY) return; > > - proxy_port = strchr(proxy, ':'); > - if (!proxy_port) > + memset( &UrlComponents, 0, sizeof(UrlComponents)); > + UrlComponents.dwStructSize = sizeof(UrlComponents); > + UrlComponents.lpszHostName = hostname; > + UrlComponents.dwHostNameLength = INTERNET_MAX_HOST_NAME_LENGTH; > + if(!InternetCrackUrlA(pi->lpszProxy, 0, 0, &UrlComponents)) > + { > + heap_free(pi); > return; > + } > + > + if(UrlComponents.nPort == INTERNET_INVALID_PORT_NUMBER) > + UrlComponents.nPort = INTERNET_DEFAULT_HTTP_PORT; > > - *proxy_port = 0; > - proxy_port_num = atoi(proxy_port + 1); > - TRACE("Setting proxy to %s, port %d\n", debugstr_a(proxy), proxy_port_num); > + TRACE("Setting proxy to %s, port %d\n", UrlComponents.lpszHostName, UrlComponents.nPort); > > - set_string_pref(pref, "network.proxy.http", proxy); > - set_string_pref(pref, "network.proxy.ssl", proxy); > + set_string_pref(pref, "network.proxy.http", UrlComponents.lpszHostName); > + set_string_pref(pref, "network.proxy.ssl", UrlComponents.lpszHostName); > > set_int_pref(pref, "network.proxy.type", 1); > - set_int_pref(pref, "network.proxy.http_port", proxy_port_num); > - set_int_pref(pref, "network.proxy.ssl_port", proxy_port_num); > + set_int_pref(pref, "network.proxy.http_port", UrlComponents.nPort); > + set_int_pref(pref, "network.proxy.ssl_port", UrlComponents.nPort); > + > + heap_free(pi); > } > > static void set_preferences(void) -- Best Regards, André Hentschel

2 1

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13562 Your paranoid android. === W2KPROSP4 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === WXPPROSP3 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W2K3R2SESP2 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === WVISTAADM (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W2K8SE (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W7PRO (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format === W7PROX64 (32 bit d3d) === d3d.c:4444: Test failed: IDirect3D7_EnumZBufferFormats failed, hr 0x88760154. d3d.c:4445: Test failed: Expected at least one supported Z Buffer format

1 0

mshtml: Use the last colon in proxy url as port separator
by Juan Lang Aug. 22, 2011

Aug. 22, 2011

Hi André, > http://domain\user:password(a)server.com:8080 makes it visible that it's intended to get the last colon What about http://domain\user:password(a)server.com? password isn't the port number. --Juan

4 7

The sad state of audio GetPosition
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 22, 2011

Aug. 22, 2011

Hi, the good news first: I've some code which seems to return the "position of the sample that is currently playing through the speakers" that MSDN requires GetPosition to return. It passes my mmdevapi rendering tests when used with ALSA's dmix and hw:0 devices. The new WinMM over mmdevapi depends on GetPosition for its buffer management. Hence a correct GetPosition seems essential for Wine. The bad news: I've logs which unambiguously prove that at least in Ubuntu Lucid (2010), PulseAudio yields values of snd_pcm_avail_update and snd_pcm_delay that are completely inadequate to compute what GetPosition should return. I'll write more about that in the ALSA or PA mailing list. Before doing that, I'd like to sample the behaviour of my rendering tests on a few machines. You'll find the executable at http://testbot.winehq.org/JobDetails.pl?Key=13489 I'm interested in results from: - Linux, esp. with something newer than Ubuntu Lucid, or different sound cards. - Native, because testbot shows some failures and I'd like to see results from real machines, not vmware. Beware: - Ignore the test failures about IsFormatSupported/Initialize. I'm misusing ok() for reporting. - Please send the complete log, not the short form with failures only, because the test now loops twice: once for SHARED mode, once for EXCLUSIVE. Without the complete log, it's not possible to tell from the line number only which mode is in use. - The test may crash in Wine, after my loop, in test_session, because sometimes Initialize fails and the test doesn't catch that. Testbot shows failures such as: render.c:1034: Test failed: Position 56880 too far after 1070ms render.c:1035: Test failed: Position delta 5712 not regular I've yet to analyse testbot's logs in detail. - "Position delta" means that after 100ms, one expects the speaker position to advance by ~4800 (or 48000) positions. How come it can be 5712? - "Position too far" means that after 1000ms of playing, the speaker position cannot be larger than FramesPerSecond (modulo Frequency). How can it be 56880 when I expect 48000? (modulo some period increments) Regards, Jörg Höhle

3 12

Re: [2/2] dinput8/tests: Tests for DIPROP_USERNAME property
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13553 Your paranoid android. === W7PROX64 (64 bit device) === device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"winetest", got=L"\0488W" device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"winetest", got=L"\0488W" device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"Ninja Brian", got=L"\0488W" device.c:193: Test failed: GetProperty failed hr=80070057 device.c:194: Test failed: Username not set correctly expected=L"Ninja Brian", got=L"\0488W"

1 0

Re: [1/2] dinput8/tests: Moved EnumDevicesBySemantics specific tests to dinput.c and added a couple more
by Marvin Aug. 22, 2011

Aug. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13552 Your paranoid android. === W7PROX64 (64 bit dinput) === dinput.c:550: Test failed: This user should own no devices owned=2

1 0