August 2011 - Wine-Devel - list.winehq.org

w9x testbot state?
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 8, 2011

Aug. 8, 2011

Hi, what happened to the w9x test bots? I'd like them to run some kernel32 tests. Testbot says "offline". Thank you for your help, Jörg Höhle

8 15

re: make "bisected" a keyword in bugzilla?
by Dan Kegel Aug. 8, 2011

Aug. 8, 2011

I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday.

11 15

mmdevapi: playing silence is introducing delays
by Joerg-Cyril.Hoehle＠t-systems.com Aug. 8, 2011

Aug. 8, 2011

Hi, Andrew Eikum replied: >> - Questionable use of BUFFERFLAGS_SILENT in WOD_PushData. When no data >> is available now, the buffer is flooded with silence, hence data >> submitted shortly afterwards will be delayed by as much (PulseAudio >> will accumulate 2 seconds of buffer data...), not by a minimal amount. >Are you sure? BUFFERFLAGS_SILENT shouldn't silence the whole buffer, >just insert avail_frames worth of silence, which is what was intended. >We should only accumulate 2 seconds if there is a 2 second underrun from >WinMM's client. That seems like sane behavior to me. I opened issue #27937 which is related. This may surprise people, but I argue that winmm and mmdevapi (in rendering mode) have *no* notion of underrun. Therefore there's nothing like "insert avail_frames of silence, which was intended" there. - Send no data to winmm, and it will play nothing (silence). Send data again and it will start immediately (modulo HW period size). The API doesn't even tell you that a HW underrun occurred. You notice it indirectly when all your wave headers are returned... - mmdevapi in SHARED MODE implements a mixer. Send it no data and it will mix that with all other currently playing sounds, possibly optimizing the case when no app sends any sound. Start sending data again and I *bet* it'll start immediately (modulo 10ms as the native mixer seems to operate in chunks that size). GetCurrentPadding of zero is an indirect indicator that an underrun likely happened (some data may still be buffered with USB devices...) This is radically different from ALSA! Stop sending data for 10 seconds, and you need to either - restart or - quickly send 11 seconds worth of data, of which the first 10 will be ignored by ALSA!! Watch avail_update grow and snd_pcm_delay decrease towards minus infinity (modulo 32bit) while this happens... -- I wonder if that alone can explain a few issues in bugzilla where no sound is heard -- You can even pump the late data in chunks much larger than buffer size! e.g. 10MB Alternatively use snd_pcm_forward. It is only after you filed the gap that subsequent data will be fed to the speakers again and you are returned to normal mode where you can't write more than buffer_size and avail_update < buffer_size. OTOH, mmdevapi capture mode has that glitch flag. But I wasn't talking about capture here. All in all, I think ALSA's behaviour is good for sync'ing audio with video but otherwise quite surprising. That's why I argue that playing silence in mmdevapi is introducing delays that don't exist with native. Regards, Jörg Höhle

1 3

Re: [PATCH 8/8] ddraw: Avoid double increases of wined3d references.
by Henri Verbeet Aug. 8, 2011

Aug. 8, 2011

2011/8/8 Ričardas Barkauskas <rbarkauskas(a)codeweavers.com>: > > While normaly this shouldn't even happen, it is distracting when it does. You can't change ddraw_surface_add_iface() without also changing surface creation. IIRC the surface is created with references to both the surface and the texture. I guess keeping a reference to just one of them would work because of the little shared refcount dance wined3d surfaces do, but I think I'd prefer to keep that a detail of the wined3d implementation. However, do note that ddraw_surface_release_iface() only releases one of them. I think that may be wrong.

1 0

Re: [PATCH 7/8] ddraw: Fix SetTexture reference count behaviour.
by Stefan Dösinger Aug. 8, 2011

Aug. 8, 2011

On Monday 08 August 2011 00:26:38 Ričardas Barkauskas wrote: > + hr = wined3d_device_get_texture(This->wined3d_device, stage, &wined3d_texture); This will cause problems when the application is recording a stateblock. In this case set_texture will apply the texture in the update stateblock and get_texture will return the value from the main stateblock. I feel kinda sorry for you, but I am afraid fixing this properly will require a lot of work, starting with testing d3d7 stateblock behavior wrt refcounting. In the worst case fixing this might require re-implementing some of the stateblock logic in ddraw. Also make sure to test SetRenderTarget. In d3d8/9 the render target is not recorded in the stateblock, so there's no issue. d3d7 may be different. Unfortunately we have zero stateblock tests for d3d7. There's also SetCurrentViewport that addrefs, but IDirect3DDevice3 doesn't support stateblocks, so it is not an issue. The really crappy thing, and that's where my sorry feeling comes from, is that I haven't seen any application yet that uses d3d7's stateblocks. But I'm afraid if we want to stop the fix one app, regress another app problem we have with ddraw we'll have to do this properly and not hope no app ever runs into this.

2 1

Re: [PATCH 6/8] ddraw: Do not create implicit depth buffer.
by Henri Verbeet Aug. 8, 2011

Aug. 8, 2011

2011/8/8 Ričardas Barkauskas <rbarkauskas(a)codeweavers.com>: > - localParameters.EnableAutoDepthStencil = TRUE; > + localParameters.EnableAutoDepthStencil = FALSE; > localParameters.AutoDepthStencilFormat = WINED3DFMT_D16_UNORM; As Stefan mentioned on IRC, you should probably set the format to 0 / WINED3DFMT_UNKNOWN. I wouldn't be opposed to zeroing localParameters and only initializing fields that should be non-zero either though. That would get rid of about half of the fields. > + assert(FALSE); > return D3D_OK; > } Asserts don't do much on non-debug builds, so you probably want to at least return something like E_NOTIMPL. An ERR would probably be more descriptive than assert(FALSE), but it's probably mostly just personal preference.

1 0

Re: [PATCH 3/8] ddraw: Don't allow setting palette on non root surfaces.
by Henri Verbeet Aug. 8, 2011

Aug. 8, 2011

2011/8/8 Ričardas Barkauskas <rbarkauskas(a)codeweavers.com>: > We could also do this in wined3d, though I'm not sure if that would be much of an advantage. Also, does this imply that other miplevels should look at the base level to get their palette? I don't think we currently do this. How does this work for cube textures?

1 0

Re: Bug #27975 and one small change
by Vincent Povirk Aug. 8, 2011

Aug. 8, 2011

Changes must be in patch form. See http://wiki.winehq.org/SubmittingPatches 2011/8/7 Adam Stachowicz <saibamenppl(a)gmail.com>: > Welcome. > > This is full file of dlls\inetcpl.cpl\cpl_Pl.rc: > > /* > * Internet control panel applet > * > * Copyright 2010 Łukasz Wojniłowicz > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > * License as published by the Free Software Foundation; either > * version 2.1 of the License, or (at your option) any later version. > * > * This library is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; if not, write to the Free Software > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > * > */ > > #include "inetcpl.h" > > LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > > /* "General" propsheet */ > IDD_GENERAL DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > FONT 8, "MS Shell Dlg" > CAPTION "Ogólne" > BEGIN > > GROUPBOX " Strona domowa ", IDC_STATIC, 4, 4, 312, 52 > LTEXT "Możesz wybrać adres strony, która będzie twoją stroną > domową.", > IDC_STATIC, 58, 10, 252, 10 > EDITTEXT IDC_HOME_EDIT, 58, 22, 252, 12, WS_VISIBLE | ES_AUTOHSCROLL > PUSHBUTTON "Użyj &bieżącej", IDC_HOME_CURRENT, 58, 36, 80, 14 > PUSHBUTTON "Użyj d&omyślnej", IDC_HOME_DEFAULT, 144, 36, 80, 14 > PUSHBUTTON "Użyj pu&stej", IDC_HOME_BLANK, 230, 36, 80, 14 > GROUPBOX " Historia przeglądania ", IDC_STATIC, 4, 60, 312, 46 > LTEXT "Możesz usunąć przechowywane strony, ciasteczka i inne > dane.", > IDC_STATIC, 58, 72, 252, 10 > PUSHBUTTON "&Usuń pliki...", IDC_HISTORY_DELETE, 144, 86, 80, 14 > PUSHBUTTON "Ustawie&nia...", IDC_HISTORY_SETTINGS, 230, 86, 80, 14 > > END > > /* "Delete browsing history" dialog */ > IDD_DELETE_HISTORY DIALOG 0, 0, 250, 250 > STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > FONT 8, "MS Shell Dlg" > CAPTION "Usuwanie historii przeglądania" > BEGIN > > AUTOCHECKBOX "Tymczasowe pliki internetowe\nKopie stron sieci Web, > obrazów i certyfikatów.", > IDC_DELETE_TEMP_FILES, 10, 8, 230, 30, BS_TOP | > BS_MULTILINE > AUTOCHECKBOX "Pliki cookies\nPliki przechowywane na komputerze przez > witryny sieci Web w celu zapisania preferencji takich jak informacje > logowania.", > IDC_DELETE_COOKIES, 10, 38, 230, 30, BS_TOP | > BS_MULTILINE > AUTOCHECKBOX "Historia\nLista odwiedzonych witryn sieci Web.", > IDC_DELETE_HISTORY, 10, 68, 230, 30, BS_TOP | > BS_MULTILINE > AUTOCHECKBOX "Dane formularzy\nZapisane informacje, które zostały > wpisane w formularzach.", > IDC_DELETE_FORM_DATA, 10, 98, 230, 30, BS_TOP | > BS_MULTILINE > AUTOCHECKBOX "Hasła\nHasła uzupełniane automatycznie po zalogowaniu > się do wcześniej odwiedzonej witryny Web.", > IDC_DELETE_PASSWORDS, 10, 128, 230, 30, BS_TOP | > BS_MULTILINE > DEFPUSHBUTTON "Anuluj", IDCANCEL, 185, 230, 60, 15, WS_GROUP > PUSHBUTTON "Usuń", IDOK, 120, 230, 60, 15, WS_GROUP > > END > > /* "Security" propsheet */ > IDD_SECURITY DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > FONT 8, "MS Shell Dlg" > CAPTION "Bezpieczeństwo" > BEGIN > > CONTROL "Listview", IDC_SEC_LISTVIEW, "SysListView32", > LVS_ICON | LVS_ALIGNLEFT | LVS_AUTOARRANGE | LVS_SINGLESEL | > LVS_SHOWSELALWAYS | WS_BORDER | WS_VSCROLL, > 4, 4, 312, 58 > LTEXT "", IDC_SEC_ZONE_INFO, 4, 68, 312, 20 > GROUPBOX "", IDC_SEC_GROUP, 4, 88, 312, 126 > CONTROL "trackbar", IDC_SEC_TRACKBAR, "msctls_trackbar32", > TBS_VERT | TBS_AUTOTICKS | TBS_BOTH | TBS_REVERSED, 8, 98, > 32, 100 > LTEXT "", IDC_SEC_LEVEL, 48, 102, 180, 12 > LTEXT "", IDC_SEC_LEVEL_INFO, 48, 114, 260, 80 > END > > /* "Content" propsheet */ > IDD_CONTENT DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > FONT 8, "MS Shell Dlg" > CAPTION "Zawartość" > BEGIN > > GROUPBOX " Certyfikaty ", IDC_STATIC, 4, 4, 312, 50 > LTEXT "Certyfikaty są używane do twojej osobistej identyfikacji > oraz do identyfikacji wydawców i urzędów certyfikujących.", > IDC_STATIC, 58, 14, 252, 18 > PUSHBUTTON "Certyfikaty...", IDC_CERT, 146, 34, 80, 14 > PUSHBUTTON "Wydawcy...", IDC_CERT_PUBLISHER, 230, 34, 80, 14 > > END > > > This fixes bug http://bugs.winehq.org/show_bug.cgi?id=27975 > > And this small change in dlls\comdlg32\cdlg_Pl.rc: > > Line 112: > RADIOBUTTON "W po&ziomie", rad4, 50, 115, 40, 12 > > change this to: > > RADIOBUTTON "W po&ziomie", rad4, 50, 115, 48, 12 > > > Greetings. > > Adam "Saibamen" Stachowicz > ReactOS Forum Moderator and Polish translator > > > >

1 0

Re: [1/2] user32/tests: Test what happens to a WM_QUIT posted to a window that gets destroyed.
by Marvin Aug. 7, 2011

Aug. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13344 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

2 1

Printing fixme's once (was: Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9)
by Dan Kegel Aug. 7, 2011

Aug. 7, 2011

Stefan wrote: > I think there was once a discussion about a FIXME_ONCE macro that took care of this. not sure what happened with that idea. Judging by http://source.winehq.org/git/wine.git/commitdiff/45ead7fe85e7107de91bd79a8c…, Alexandre's preferred idiom is static BOOL fixme_once; ... if(!fixme_once++) FIXME("Report bug to Aunt Tilly\n"); It occurs to me that #define WINE_ONCE(s) { static int once; if (!once++) s; } might suffice; you could then write WINE_ONCE(FIXME("Report bug to Aunt Tilly\n")); The previous attempt was more complicated: http://marc.info/?l=wine-devel&m=129396741411607&w=2 - Dan

2 1