September 2011 - Wine-Devel

Re: [1/2] shell32/tests: Fix path comparison
by Marvin Sept. 6, 2011

Sept. 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14016 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:193: Test failed: WaitForSingleObject(hProcess) returned 258

1 0

Re: [2/2] shdoclc & user32 & wineconsole & wordpad: Specify a message context for cut and paste
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > MENUITEM "Select &All", IDM_SELECTALL > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE > MENUITEM SEPARATOR > MENUITEM "Create Shor&tcut", IDM_CREATESHORTCUT > MENUITEM "Add to &Favorites...", IDM_ADDFAVORITES > @@ -73,10 +73,10 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as Back&ground", IDM_SETWALLPAPER > MENUITEM "Set as &Desktop Item...", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > - MENUITEM "Cu&t", IDM_CUT > + MENUITEM "#msgctxt#Shell#Cu&t", IDM_CUT > MENUITEM "&Copy", IDM_COPY > MENUITEM "Copy Shor&tcut", IDM_COPYSHORTCUT > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE That's not a very useful context. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy Sept. 6, 2011

Sept. 6, 2011

On Tue, Sep 6, 2011 at 09:35, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > It's just a resend. The patch is unmodified, just rebased on latest git. > > try4: > - add missing NULL ending character to help_option string > > try3: > - fix /? option. This fixes cmd tests regression > > try2: > - keep attrib infos for help command > - update po files > > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. I've got test failures with your patch ("make test" in programs/cmd/tests) First error: batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591 (got 'r.test not found before delete, bad', wanted 'r.test found before delete, good') Also, beware that testbot won't test your patch on windowses since it doesn't change any file in tests/ directory (you might want to submit it manually with, say, a small change in test_builtins.cmd and/or test_builtins.exp) See http://wiki.winehq.org/CmdConformanceTests (recently written) if you need help with the keywords, etc. Frédéric

2 2

Fwd: [ANNOUNCE] Git User's Survey 2011
by Andrew Eikum Sept. 6, 2011

Sept. 6, 2011

It's that time of year again. I thought I'd forward this on to wine-devel since we're all Git users here. ----- Forwarded message from Jakub Narebski <jnareb(a)gmail.com> ----- Date: Mon, 5 Sep 2011 02:43:20 +0200 From: Jakub Narebski <jnareb(a)gmail.com> To: git(a)vger.kernel.org Subject: [ANNOUNCE] Git User's Survey 2011 User-Agent: KMail/1.9.3 Hello all, We would like to ask you a few questions about your use of the Git version control system. This survey is mainly to understand who is using Git, how and why. The results will be published to the Git wiki on the GitSurvey2011 page (https://git.wiki.kernel.org/index.php/GitSurvey2011) and discussed on the git mailing list. The survey would be open from 5 September till 3 October 2011. Please devote a few minutes of your time to fill this simple questionnaire, it will help a lot the git community to understand your needs, what you like of Git, and of course what you don't like of it. The survey can be found here: http://tinyurl.com/GitSurvey2011 https://www.survs.com/survey/VCAGZA8CT5 There is also alternate version which does not require cookies, but it doesn't allow one to go back to response and edit it. https://www.survs.com/survey/MRRGT8OEFV P.S. At request I can open a separate channel in survey, with a separate survey URL, so that responses from particular site or organization could be separated out. Please send me a email with name of channel, and I will return with a separate survey URL to use. -- Git Development Community -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----- End forwarded message -----

1 0

script to run all good tests / all flaky tests / etc.
by Dan Kegel Sept. 6, 2011

Sept. 6, 2011

The buildbot does three things to get fast, reliable test runs: - it runs a 'safe' set of tests in the background, without DISPLAY set, in a different wineprefix; this saves three minutes - it has a blacklist of known flaky or broken tests, listing how it's broken and linking to the bug report - it kills wineserver after the run (since some tests leave processes around) I hoisted these out of the buildbot config and into a separate script, http://code.google.com/p/winezeug/source/browse/trunk/buildbot/dotests.sh As a bonus, you can ask it to run all the flaky tests instead of all the good ones, which might be useful if you're trolling for test bugs to fix. Here's the current blacklist from that script: # Blacklist format # test condition [bug] # Tests may appear multiple times in the list. # Supported conditions: # FLAKY - fails sometimes # CRASHY - crashes sometimes # SYS - always fails on some systems, not on others # HEAP - fails or crashes if warn+heap # NOTTY - test fails if output redirected # BAD64 - always fails on 64 bits cat > /tmp/blacklist.txt <<_EOF_ dlls/kernel32/tests/heap.ok HEAP dlls/dsound/tests/ds3d8.ok SYS 8668 dlls/dsound/tests/ds3d.ok SYS 8668 dlls/dsound/tests/dsound8.ok SYS 8668 dlls/dsound/tests/dsound.ok SYS 8668 dlls/user32/tests/input.ok SYS 12053 dlls/user32/tests/msg.ok SYS 12053 dlls/user32/tests/win.ok SYS 12053 dlls/oleaut32/tests/tmarshal.ok BAD64 26768 dlls/ieframe/tests/ie.ok BAD64 26768 dlls/ws2_32/tests/sock.ok CRASHY 28012 dlls/wininet/tests/urlcache.ok FLAKY 28038 dlls/winmm/tests/wave.ok SYS 28048 dlls/winmm/tests/mci.ok SYS 28071 dlls/urlmon/tests/url.ok FLAKY 28108 dlls/winmm/tests/capture.ok SYS 28109 dlls/shell32/tests/shlfolder.ok SYS 28216 dlls/kernel32/tests/process.ok NOTTY 28220 dlls/d3dx9_36/tests/shader.ok HEAP 28255 dlls/kernel32/tests/pipe.ok HEAP 28257 programs/cmd/tests/batch.ok HEAP 28258 dlls/dsound/tests/ds3d8.ok HEAP 28260 dlls/dsound/tests/ds3d.ok HEAP 28260 dlls/mshtml/tests/style.ok HEAP 28262 dlls/winhttp/tests/winhttp.ok SYS 28267 programs/wscript/tests/run.ok BAD64 28285 dlls/msctf/tests/inputprocessor.ok FLAKY 28288 _EOF_

2 2

Re: uxtheme: Return error on invalid parameters
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > uxtheme: Return error on invalid parameters Get/SetPropW already check the handle, don't add redundant checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros. (try 2)
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -59,57 +59,87 @@ typedef BOOL (CALLBACK *LPFNADDPROPSHEETPAGES)(LPVOID, LPFNADDPROPSHEETPAGE, LPA > /* > * Property sheet support (structures) > */ > +#ifndef _WIN32 > +typedef const VOID* PROPSHEETPAGE_RESOURCE; > +#elif defined(UNICODE) > +typedef LPCDLGTEMPLATEW PROPSHEETPAGE_RESOURCE; > +#else > +typedef LPCDLGTEMPLATEA PROPSHEETPAGE_RESOURCE; > +#endif That one should be disallowed too. And testing _WIN32 isn't useful in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [The Official Wine Wiki] Update of "ConformanceTests"
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 6, 2011

Sept. 6, 2011

François Gouget asked: >> + * Depending on OSX settings, the firewall will ask whether to >> allow incoming network access for tests involving server sockets. >Does it cause test failures? Sorry, I've not tracked it down. Either I click "agree" fast enough (they occur towards the end of the ~20 minutes winetest.exe run) and the tests proceed, or presumably the test exe is killed after a timeout. I tend to "babysit" test execution for that reason (and because I only went online for the purpose of test execution, bug #20219). >Does one have to disable the firewall? I configured the Mac too long ago to remember. Presumably it's a matter of restrictive configuration, otherwise other users would have raised the topic already. Regards, Jörg Höhle

1 0

Re: [2/2] ntdll: Allow reading from a VPROT_WRITECOPY protected memory
by Dmitry Timoshkov Sept. 6, 2011

Sept. 6, 2011

André Hentschel wrote: > As per tests in kernel32:loader it seems linux&co allows reads on PROT_WRITE areas, but solaris doesn't and crashes. > This fixes this issue. > - if (vprot & VPROT_WRITECOPY) prot |= PROT_WRITE; > + if (vprot & VPROT_WRITECOPY) prot |= PROT_READ | PROT_WRITE; Do you mean that the recently added test for resource section access mapping crashes on Solaris? If yes, then the fix should be done in different place. -- Dmitry.

2 3

Re: comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros.
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

Francois Gouget <fgouget(a)free.fr> writes: > @@ -213,6 +247,27 @@ DECL_WINELIB_TYPE_AW(PROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPCPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPFNPSPCALLBACK) > +#ifdef UNICODE > +typedef PROPSHEETPAGEW_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEW_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEW_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEW_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEW_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEW_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEW_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERW_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERW_V2_SIZE > +#else > +typedef PROPSHEETPAGEA_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEA_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEA_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEA_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEA_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEA_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEA_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERA_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERA_V2_SIZE > +#endif Please use the appropriate Winelib macros to define A/W mappings. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: Property sheets must be able to redraw themselves even if no page is selected.
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13992 Your paranoid android. === WVISTAADM (32 bit propsheet) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Undocumented registry settings
by Vitaliy Margolen Sept. 5, 2011

Sept. 5, 2011

Henri, Would you mind documenting recently added registry entries to wined3d on Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find description of "AlwaysOffscreen". Vitaliy.

2 2

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)
by Henri Verbeet Sept. 5, 2011

Sept. 5, 2011

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + keys = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(WCHAR*)); > + vals = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(LARGE_INTEGER)); ... > + keys = HeapReAlloc(GetProcessHeap(), 0, keys, > + capacity * sizeof(WCHAR*)); > + vals = HeapReAlloc(GetProcessHeap(), 0, vals, > + capacity * sizeof(LARGE_INTEGER)); Memory allocations can fail. You also never free these, but I suppose that happens implicitly on process termination.

2 1

Re: msxml3: Correct MSXML Object Safety tests (try 2)
by Alexandre Julliard Sept. 5, 2011

Sept. 5, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Add the enabled test as well. > > Changelog: > msxml3: Correct Object Safety tests It doesn't work here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok domdoc.c:4706: Test failed: expected INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA got 2 domdoc.c:7532: Test failed: expected INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA got 2 make[1]: *** [domdoc.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32/tests: Test for correct storage creation.
by Vincent Povirk Sept. 5, 2011

Sept. 5, 2011

You might just want to try reopening the file and checking its CLSID, instead of directly checking the contents. That should make it more obvious that something is seriously wrong. With the direct checks, it's hard to figure out what the test actually means. Anyway, this should be easy to fix. We just need to keep track of whether the file has ever had a header, instead of assuming the header is valid if the file is large enough to have one.

1 0

Re: [1/2] programs: Add a stub implementation of regasm.exe.
by Vincent Povirk Sept. 5, 2011

Sept. 5, 2011

On Windows, this is a .NET assembly. We should probably do it the same way.

1 0

Re: [dsound] InstanceId holds a pointer, so it needs to be as wide as a pointer.
by Michael Stefaniuc Sept. 5, 2011

Sept. 5, 2011

Hello Dan, Dan Kegel wrote: > Not that we do anything with it... still the correct fix would be to rewrite the driver to use a more modern header version than DirectX 5. I guess that's part of Andrew's dsound rewrite. bye michael

1 0

re: configure.ac: add -Werror to default compiler options
by Dan Kegel Sept. 5, 2011

Sept. 5, 2011

(Reviving http://www.winehq.org/pipermail/wine-devel/2008-September/069266.html ) After http://www.winehq.org/pipermail/wine-patches/2011-August/106150.html and http://www.winehq.org/pipermail/wine-patches/2011-August/106151.html, configuring with -Wall -Werror gives the right results, judging by a quick diff of config.h and config.status. (sys/asoundlib.h is not detected, but that's ok, it's marked as obsolete, and wine uses alsa/asoundlib.h instead.) This takes care of Maarten's concerns from the earlier thread. Then building yields only a tiny handful of errors: dllfunc.c: In function ‘AMovieDllRegisterServer2’: dllfunc.c:180: warning: dereferencing type-punned pointer will break strict-aliasing rules qualitycontrol.c: In function ‘QualityControlImpl_Notify’: qualitycontrol.c:70: warning: dereferencing type-punned pointer will break strict-aliasing rules transform.c: In function ‘TransformFilterImpl_QueryInterface’: transform.c:248: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../include/winternl.h: In function ‘get_vm86_teb_info’: ../../include/winternl.h:2660: warning: dereferencing type-punned pointer will break strict-aliasing rules ... register.c: In function ‘create_registrar’: register.c:66: warning: dereferencing type-punned pointer will break strict-aliasing rules Those are potential, if unlikely, bugs; we ought to either fix them or add -fno-strict-aliasing to CFLAGS for the seven or so affected .c files. At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. - Dan

7 9

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc
by Jacek Caban Sept. 5, 2011

Sept. 5, 2011

Hi Thomas, AFAICS secur_url wasn't allocated with CoTaskMemAlloc until this patch. Why are you changing it? Jacek

2 1

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)
by Eric Pouech Sept. 5, 2011

Sept. 5, 2011

this won't work if a .bat file calls another .bat file the cache must be stored inside the context structure... A+ -- Eric Pouech

1 0

Re: [1/5] ddraw: Add some NULL pointer tests
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13949 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

2 1

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().
by Stefan Dösinger Sept. 5, 2011

Sept. 5, 2011

On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: > These are no longer needed since present can handle these now. I think we can remove the entire special case and just do a blit. This hack is related to the ddraw windowed backbuffer hack you removed a while ago, except that the back->front blit is used by a handful of fullscreen apps too.

2 3

Re: [2/4] msi/tests: Fix a number of test messages.
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13969 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [2/3] winhttp/tests: Initialize a variant with a known value.
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13968 Your paranoid android. === W7PRO (32 bit winhttp) === winhttp.c:1971: Test failed: failed to send request 12152 winhttp.c:1977: Test failed: got 12019

1 0

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)
by Octavian Voicu Sept. 5, 2011

Sept. 5, 2011

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + static WCHAR string[MAX_PATH]; Why make this static? It's only a temporary buffer and it's only used once, when building the cache. Octavian

2 1