September 2011 - Wine-Devel

Re: [1/5] ddraw: Simplify Z format parsing a bit, remove ERRs
by Henri Verbeet Sept. 1, 2011

Sept. 1, 2011

On 1 September 2011 11:01, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > case 32: > if(DDPixelFormat->u2.dwStencilBitDepth == 8) > return WINED3DFMT_D24_UNORM_S8_UINT; > - else > + else if (DDPixelFormat->u2.dwStencilBitDepth == 4) > return WINED3DFMT_S4X4_UINT_D24_UNORM; I'm not sure if this is intentional or not, but you fallthrough to the default case here. If that's intentional, a /* Fallthrough */ or similar comment wouldn't hurt. On the other hand, you do explicitly handle it in the no-stencil case.

2 1

Re: [1/7] cmd: Add support for LSS comparison operator in if statements
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > + else if ((s = StrStrIW (p, lssW))) { > + s += 3; > + a = StrToIntW(condition); > + b = StrToIntW(WCMD_parameter (s, 0, NULL)); I don't think you want to use strstr for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix a few pointer cast warnings.
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Jerome Leclanche <adys.wh(a)gmail.com> writes: > From c8a7535beebb152641330d3d1410d17345522867 Mon Sep 17 00:00:00 2001 > From: Jerome Leclanche <adys(a)azura> > Date: Thu, 1 Sep 2011 12:51:26 +0100 > Subject: [PATCH] setupapi: Fix a few pointer cast warnings. That's just hiding the pointer truncation bug. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab
by Dan Kegel Sept. 1, 2011

Sept. 1, 2011

On Wed, Aug 31, 2011 at 1:10 PM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/161 > BUILD FAILED: failed git Something's fishy; looking at http://marc.info/?l=wine-patches&m=131134541100364&w=2 I see that the July 22nd version seems to have interesting strings, but the August 31st version has all question marks when it comes to non-ascii text. What happened between the two? http://source.winehq.org/patches/data/78217, which is where I pulled the patch from, also has the question marks.

2 2

Re: services: Issue a fixme when a service fails to start.
by Octavian Voicu Sept. 1, 2011

Sept. 1, 2011

On Thu, Sep 1, 2011 at 4:02 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > @@ -295,7 +295,8 @@ static void scmdatabase_autostart_services(struct scmdatabase *db) > argv[0] = service->name; > argv[1] = NULL; > err = service_start(service, 1, argv); > - /* FIXME: do something if the service failed to start */ > + if (err != ERROR_SUCCESS) > + WINE_FIXME("do something if the service failed to start %d\n", err); Why not print something more informative? This looks nice and also tells you which service did not start: WINE_FIXME("Auto-start service %s failed to start: %d\n", wine_dbgstr_w(service->name), err); Octavian

1 0

Re: file
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
by Stefan Dösinger Sept. 1, 2011

Sept. 1, 2011

On Tuesday 30 August 2011 20:12:31 Henri Verbeet wrote: > This imlicitly gets rid of the "auto" option as well, since there's no way > to explicitly specify it. This will no doubt cause its share of > regressions, but I prefer actually fixing those bugs to running into the > surface implementation switching code every time I try to fix something in > ddraw. This will break 2D-only apps in situations where OpenGL is not available. It would be a good idea to use SURFACE_GDI automatically in those situations. (I'm not sure if ddraw without GL works at all right now, we have no systems that run the tests with this setup) It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with me, it's not like those apps are working at the moment, and I guess the switching breaks more than it fixes.

2 3

winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol.
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 1, 2011

Sept. 1, 2011

Hi, I've one idea left about what may have caused the 2 apply failures. The patches are in my git queue just above wine-1.3.27 and the unrelated Valgrind hacks, so in theory, they should work. However the patches depend on each other, but since I reused the subject line of patches originally submitted with several days spacing between them, I forgot to add [PATCH 1/N] this week. The order is: 0001-winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol. 0002-mmdevapi: Do not mix frames and bytes. (in git now, but should not interfere) 0003-mmdevapi: Use UINT32 for a number of frames and UINT64 to sum them. Perhaps you tried out UINT32 first? Please try Get/Release first. My apology for the trouble, Jörg Höhle

1 0

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > +static INT_PTR CALLBACK ConfigureDevicesDlgProc(HWND dialog, UINT uMsg, WPARAM wParam, LPARAM lParam) > +{ > + static LPDIACTIONFORMATW lpdiaf; > + static DIDevicesData devices_data; > + static ConfigureDevicesData *conf_data; > + > + switch(uMsg) > + { > + case WM_INITDIALOG: > + /* Initialize action format and enumerate devices */ > + conf_data = (ConfigureDevicesData*) lParam; > + lpdiaf = conf_data->params->lprgFormats; It doesn't make sense to pass the info as WM_INITDIALG parameter if it's going to be stored in global variables anyway. A better way would be to store this in the window info. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: 78223: Subject: configure: fix configure failures under -Werror -Wall
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/168 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78222: Subject: configure: AC_C_CONST is obsolete
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/167 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

WineHQ Maintenance.
by Jeremy Newman Sept. 1, 2011

Sept. 1, 2011

We will be performing upgrades and maintenance to the WineHQ.org server starting at 1800 CDT on Wednesday August 31st. This process will take the server off-line for about an hour. The Websites (www,appdb,forums), and Mailing lists, and Git will be off-line during this period. -Newman

1 1