September 2011 - Wine-Devel

Complaint about mmdevapi (COM?) logging
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 27, 2011

Sept. 27, 2011

Hi, I'm not satisfied with the current winmm+mmdevapi logging. I suspect that COM logging of other components is similarly bad. Consider the following snippet. It looks like a +relay log, not showing what I want to see. 0022:trace:winmm:waveOutWrite (0xc000, 0x21f140, 32) 0020:trace:winmm:WOD_PushData (0xc000) 0020:trace:alsa:AudioClient_GetBufferSize (0x48f7700)->(0x4b0e9c4) 0020:trace:alsa:AudioClient_GetCurrentPadding (0x48f7700)->(0x4b0e9c8) 0020:trace:alsa:AudioClock_GetFrequency (0x48f7700)->(0x4b0e930) 0020:trace:alsa:AudioClock_GetPosition (0x48f7700)->(0x4b0e928, (nil)) 0020:trace:alsa:AudioClient_GetCurrentPadding (0x48f7700)->(0x4b0e8b4) 0020:trace:alsa:AudioRenderClient_GetBuffer (0x48f7700)->(256, 0x4b0e9c0) 0020:trace:alsa:AudioClient_GetCurrentPadding (0x48f7700)->(0x4b0e938) 0020:trace:alsa:AudioRenderClient_ReleaseBuffer (0x48f7700)->(256, 0) 0020:trace:winmm:WOD_PushData (0xc000) I don't want those %p pointers, I want values. - What's the position? - What's the low-level driver's padding? - What's the mmdevapi padding? - How many samples did waveOutWrite() supply? - Where's any log line from the intermittent mmdevapi periodic timer callback? + The current log is easily compressible :-) The only concrete data is from GetBuffer/ReleaseBuffer: 256 frames, so GetCurrentPadding probably returned GetBuffersize (whose value I derive from the call to Initialize, not shown here) minus 256. The bad news is that you derive more from what you *don't* see in the log than what's written therein. This costs time and effort. E.g. GetBuffer wasn't called means buffer was full -- wait, perhaps there was no more queued data? Help! Why do I believe that logging of other COM dlls may be similarly bad? The anti-pattern is to have a TRACE at function entry! I'd rather move that down a few lines, after basic checking of parameters. At that time you can TRACE some meaningful values instead of pointers. Then you may even decide to put the TRACE at the end of the function, e.g. for GetCurrentPadding that makes a lot of sense, without the added cost of two TRACE lines. Basically, there's little value in an early TRACE because only in rare case will you want to know that the call may have been aborted by E_INVALIDARG or AUDCLNT_E_NOT_INITIALIZED -- not to mention that those return values are almost never logged, not even with +relay. Actually, the useful amount of logging is a function of code maturity. Initially, you're happy with logging every API call. Once you've tested that the basic input checks work exactly like in native, you want to see more from the inside. IOW, initial stubs contain nothing but TRACE. When you fill the function body, it is an error to leave the TRACE at the top, it should move down to the heart of the function where the interesting stuff happens. Regards, Jörg Höhle

2 1

Re: mscoree: Add ICorDebug interface support (try 2)
by Alexandre Julliard Sept. 27, 2011

Sept. 27, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +#include "initguid.h" > +/* We need to undefine the MACRO CreateProcess since the ICorDebug interface > + has a function with this name. (Stops a compile issue). > + */ > +#undef CreateProcess > +#include "cordebug.h" This should go in the header. Check how other idl files are doing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 79358: mscoree: Add ICorDebug interface support
by Dan Kegel Sept. 27, 2011

Sept. 27, 2011

build failed here - did you forget a file? ../../tools/makedep -C. -S../.. -T../.. assembly.c config.c cordebug.c corruntimehost.c metadata.c metahost.c mscoree_main.c debugging.c: No such file or directory make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/mscoree/tests' make: *** [dlls/mscoree/tests/__depend__] Error 2 On Tue, Sep 27, 2011 at 4:20 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/109 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_2 > > Errors: > make[1]: *** [depend] Error 1 > make: *** [dlls/mscoree/tests/__depend__] Error 2 > >

1 0

Re: mscoree: Add ICorDebug interface support (try 2)
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14582 Your paranoid android. === W2K3R2SESP2 (32 bit debugging) === debugging.c:82: Test failed: CreateDebuggingInterfaceFromVersion returned 80070057

1 0

Re: mscoree: Add ICorDebug interface support
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14581 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msi/tests: Properly preserve pending file renames.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14578 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: wininet: Ignore the accept types array in HttpOpenRequestA if there are invalid pointers.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14577 Your paranoid android. === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12002

1 0

Re: shell32: Add definitions for the IEnumACString interface.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14562 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:250: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154 === W2KPROSP4 (32 bit autocomplete) === autocomplete.c:256: Test failed: obj->lpVtbl->QueryInterface(obj, &IID_IEnumACString, (LPVOID*)&unk) failed: 80004002

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14554 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:249: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14548 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154 === WNT4WSSP6 (32 bit referenceclock) === referenceclock.c:97: Test failed: Unable to create reference clock from system clock 80040154

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14540 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541 === W2KPROSP4 (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541 === W2K8SE (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541

1 0

Re: msi/tests: Avoid #if 0 to make sure code still compiles.
by Marvin Sept. 27, 2011

Sept. 27, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14533 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5998: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 6/9 (try2)] winecfg: Replace DirectSound settings with Driver Diagnostics
by Alexandre Julliard Sept. 26, 2011

Sept. 26, 2011

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -84,10 +84,11 @@ END > > STRINGTABLE > BEGIN > - IDS_ACCEL_FULL "Full" > - IDS_ACCEL_STANDARD "Standard" > - IDS_ACCEL_BASIC "Basic" > - IDS_ACCEL_EMULATION "Emulation" > + IDS_AUDIO_REG_SETTING "Registry driver setting: %s" > + IDS_AUDIO_REG_DEFAULT "(Default)" > + IDS_AUDIO_REG_DISABLED "(Disabled)" > + IDS_AUDIO_DRIVER "Selected driver: %s" > + IDS_AUDIO_DRIVER_NONE "(None)" Showing the detected driver is a good thing, but we shouldn't need to display the registry setting. The assumption is that users shouldn't have to worry about this. If it's important enough to show in winecfg then it has to be editable in winecfg too. -- Alexandre Julliard julliard(a)winehq.org

1 0

using (or not) blocking mode with OSS4
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 26, 2011

Sept. 26, 2011

Hi, I've had a glance at the OSS4 mmdevapi logs attached to bug #28056. Among others, it appears that every renderer iteration takes way too much time. One possible explanation is that OSS write() takes a lot of time to return, presumably in an attempt to write more than what's possible without blocking. If you look at AudioRenderClient_ReleaseBuffer and oss_write_data, you'll see that it writes as much as it has, without querying GETOSPACE. So it can block. open() is called without O_NONBLOCK, so write() will block when given too much data. I don't know yet whether O_NONBLOCK should be used. It's not what the OSS people recommend. One can argue that NONBLOCK is superfluous when write is limited via GETOSPACE. http://manuals.opensound.com/developer/open.html http://manuals.opensound.com/developer/audio_timing.html http://manuals.opensound.com/developer/SNDCTL_DSP_NONBLOCK.html What do you think about using (or not) blocking mode with OSS? W.r.t. ALSA, I'm considering keeping non-blocking mode but switch from a periodic timer to poll(ALSA_fd, period_timeout). Given a lot of data, poll would return after the timeout, but when underrun is close, this should allow to wake up closer to when data is actually needed. Regards, Jörg Höhle

2 1

re: po: Mark translations with mismatched printf format directives as fuzzy.
by Dan Kegel Sept. 26, 2011

Sept. 26, 2011

Patch fails to apply here? error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 25, 2011 at 5:35 PM Subject: Re: 79310: po: Mark translations with mismatched printf format directives as fuzzy. To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/84 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed git Errors: error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply

4 5

Before you leave for wineconf...
by Dan Kegel Sept. 26, 2011

Sept. 26, 2011

... could you run http://kegel.com/wine/loop-fail.sh.txt overnight on the hardware you plan to bring, and email me the results? It creates a log file loop-fails.log which lists each test failure and how many loops it took to get there. Thanks!

2 2

Re: [1/2] kernel32: Add a test for VirtualProtect.
by Alexandre Julliard Sept. 26, 2011

Sept. 26, 2011

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +static void test_VirtualProtect(void) > +{ > + static const struct test_data > + { > + DWORD prot_set, prot_get; > + } td[] = > + { > + { PAGE_NOACCESS, PAGE_NOACCESS }, > + { PAGE_READONLY, PAGE_READONLY }, > + { PAGE_READWRITE, PAGE_READWRITE }, > + { PAGE_WRITECOPY, 0 }, > + { PAGE_EXECUTE, PAGE_EXECUTE }, > + { PAGE_EXECUTE_READ, PAGE_EXECUTE_READ }, > + { PAGE_EXECUTE_READWRITE, PAGE_EXECUTE_READWRITE }, > + { PAGE_EXECUTE_WRITECOPY, 0 } You should also test various invalid combinations. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH 7/9] dsound: Reimplement rendering devices on mmdevapi
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 26, 2011

Sept. 26, 2011

Hi, I agree that dsound -> winmm -> mmdevapi is an abomination. However, this all goes too fast for me. We don't have a fool-proof mmdevapi yet (neither ALSA, nor OSS, nor CoreAudio). We don't have a bug-free winmm->mmdevapi yet. Since June, I've done nothing than analyse code and fix bugs to help The Wine project in my free time. My wife has already signaled that she's not pleased. I've installed zero SW for the children since that time. Well, my choice, but I'm growing tired. It appears that I've a biased view on the current audio situation because I see all the bugs. The user experience does not seem that bad, from what a few users told me. Currently, having dsound -> winmm -> mmdevapi may not be satisfying, but it helps to find hairy bugs fast (more apps use dsound than winmm). After the initial winmm transition, I did not even look at dsound or winmm bugs because there's no point in doing so when they depend on a mmdevapi which is not yet robust enough. So I concentrated on mmdevapi. It's only recently that I've started to look at winmm now that I believe to know well most remaining ALSA and CoreAudio mmdevapi bugs. I'm solely starting on OSS bugs. I believe users are happy to still have dsound HW acceleration in ALSA since 1.3.25 to compare it with the new HW emulation behaviour via mmdevapi. Is a 1.4 release target this year the reason for pushing out code fast? Regards, Jörg Höhle

2 1

Warning report for wine-1.3.29-5-gf04f0b3
by Jerome Leclanche Sept. 26, 2011

Sept. 26, 2011

Operating System Linux azura 3.0.0-10-generic #16-Ubuntu SMP Fri Sep 2 18:32:04 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux Configuration (32-bit) '--prefix=/usr' '--libdir=/usr/lib32' '--enable-tests' '--disable-win64' '--with-wine64=/home/adys/src/wine/build64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Configuration (64-bit) '--prefix=/usr' '--libdir=/usr/lib' '--enable-tests' '--enable-win64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' -- J. Leclanche

1 0

Quick Question
by Peter Wilson Sept. 26, 2011

Sept. 26, 2011

Hi, Quick question, might be silly, but is there a version of Wine that can be installed on windows or linux to create apps for Mac? I just want to keep my mac clean and try run things in a dev environment, and apple are always so polite to make visualization a pain… Thank you very much for you help, Kind Regards, Peter Wilson

2 1

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing
by Frédéric Delanoy Sept. 25, 2011

Sept. 25, 2011

This patch fails; see http://source.winehq.org/patches/ and http://source.winehq.org/patches/data/79288.testfail Got a lot of errors on NT4, and 1 on other systems batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@' You might want to use @todo_wine@ as documented on http://wiki.winehq.org/CmdConformanceTests Patches generating at least 1 error on one of testbot's systems (NT included) have 0% chance of being committed (see http://wiki.winehq.org/SubmittingPatches) [I know NT4 is sometimes $#!+... be thankful win9x is not a prerequisite anymore... ;) ] Frédéric PS: "resend" is used for unchanged patches (or only rebased); in other cases you should use "try N"

1 1

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin Sept. 25, 2011

Sept. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14502 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

re: gdi32: Add traces for the gamma functions
by Dan Kegel Sept. 25, 2011

Sept. 25, 2011

Looks like you forgot something: cc1: warnings being treated as errors dc.c: In function ‘GetDeviceGammaRamp’: dc.c:1289: error: too few arguments for format dc.c: In function ‘SetDeviceGammaRamp’: dc.c:1307: error: too few arguments for format make[1]: *** [dc.o] Error 1 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 25, 2011 at 12:10 PM Subject: Re: 79299: gdi32: Add traces for the gamma functions To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/69 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/gdi32] Error 2

2 1

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
by Marvin Sept. 25, 2011

Sept. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14499 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0(a)space@@or_broken(a)3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 4/5] cmd: fix handling of special characters in command line
by Marvin Sept. 25, 2011

Sept. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14498 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0(a)space@@or_broken(a)3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0