September 2011 - Wine-Devel

Re: [PATCH 3/5] cmd: improve parsing of quotes in command line
by Marvin Sept. 25, 2011

Sept. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14497 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0(a)space@@or_broken(a)3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv
by Martin Wilck Sept. 25, 2011

Sept. 25, 2011

Hi Dan, (re-cc'ing wine-devel) > Running it through the buildbot now... seems ok on first two tries, so > you may have accidentally fixed the problem. I'll resubmit to wine-patches shortly, probably tonight. >> > I ran the stuff through the bot, 0 errors everywhere except on NT (NT >> > fails totally, do I really need to investigate that?). > Yes, you may need to skip these tests on nt. > >> > I don't have a i7 machine, > It's probably just mine that gets lucky. Some tests > fail better on some machines than others. > Did you test with WINEDEBUG=warn+heap ? No, I didn't. I thought you wree telling me that that made your problem go away, so I didn't bother. I can do that of course if it helps. >> but I tested on a Westmere EX server I have access to, no >> problems with the conformance test. I also did some valgrind runs on >> that machine, but I have little experience in reading valgrind output. > > Did you follow http://wiki.winehq.org/Wine_and_Valgrind ? > Feel free to ask questions. Yes, I did. I am seeing no regressions (read: additional warnings and/or errors) between the trunk and my patched version. > A few notes: > + if (!in_quotes && (*p == ' ' || *p == '\t')) { > > Could you use isspaceW() ? I suppose not in the case statement below, > but you check this in several places, and the function might be clearer > (if it's correct)? Honestly, I didn't consider it. I tried to change as little as possible of the existing code. > Is there duplication between WCMD_parameter and WCMD_parse > that could be gotten rid of productively? Yes, there is, as I noted in an early posting on this subject. Indeed the two functions have essentially the same purpose. However I don't feel bold enough to try fixing that as long as my current stuff isn't accepted. Originally, all that I wanted to fix was 'echo "Hi"'. I have gone quite a few steps ahead from there with my current patch set. When I see this getting merged I'll consider further fixes, but I won't be able to follow up *much* further. Best regards Martin

2 1

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by Marvin Sept. 25, 2011

Sept. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14496 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0(a)space@@or_broken(a)3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing
by Marvin Sept. 25, 2011

Sept. 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14495 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0(a)space@@or_broken(a)3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 51 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@')

1 0

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins Sept. 24, 2011

Sept. 24, 2011

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

Re: loop fails
by Dan Kegel Sept. 24, 2011

Sept. 24, 2011

2011/9/24 André Hentschel <nerv(a)dawncrow.de>: > Hey Dan, > sadly i'm not going to be at wineconf this year, but i thought the results might help anyway. maybe i'm participating per IRC and it's my desktop computer anyway, so we'll see. > the script didn't end cleanly, there was a heap related crash that made it hang so i'm not sure about it. > > ended in the urlmon test: > > Backtrace: > =>0 0x7bc48485 RtlAllocateHeap+0xb5(heap=0x110000, flags=0x2, size=0x6000) [/home/dawncrow/dev/wine/132/dlls/ntdll/../../../include/wine/list.h:99] in ntdll (0x0032e328) > 1 0x696866b7 MSVCRT_malloc+0x36(size=0x6000) [/home/dawncrow/dev/wine/132/dlls/msvcrt/../../../dlls/msvcrt/heap.c:312] in msvcrt (0x0032e348) > 2 0x702d1962 in mozjs (+0x151961) (0x02326318) > 3 0x00000000 (0x010c6740) oooh. So it only took six loops to crash in urlmon, eh? (For the record, the script ran both dlls/urlmon/tests/protocol.ok and dlls/urlmon/tests/url.ok, don't know which one crashed.) Can you install debug gecko, e.g. by running http://kegel.com/wine/dgecko.sh.txt ( which just does the steps on http://wiki.winehq.org/Gecko ) and re-run? Also, out of six loops, you got the following test failures: 6 dlls/dsound/tests/ds3d.ok 6 dlls/dsound/tests/ds3d8.ok 6 dlls/wininet/tests/urlcache.ok 6 dlls/dsound/tests/dsound.ok 6 dlls/dsound/tests/dsound8.ok 5 dlls/winhttp/tests/winhttp.ok 5 dlls/vbscript/tests/run.ok 5 dlls/mshtml/tests/style.ok 5 dlls/mshtml/tests/htmldoc.ok 5 dlls/gdi32/tests/bitmap.ok 2 dlls/ws2_32/tests/sock.ok 1 dlls/user32/tests/msg.ok The urlcache one may go away if you clear out ~/.wine. The msg one probably would go away if you had the blessed window manager (does anyone know what the procedure there is these days?) The others seem interesting. If you were attending wineconf, I would have asked you to hit the appropriate developers up for help resolving them. Maybe you still can via email or irc... I'm looking forward to seeing loop-fail results from other folks. - Dan

2 1

Re: hhctrl.ocx: Don't show unimplemented buttons.
by Erich Hoover Sept. 24, 2011

Sept. 24, 2011

> + case IDTB_NOTES: > + case IDTB_CONTENTS: > + case IDTB_INDEX: > + case IDTB_SEARCH: > + case IDTB_HISTORY: > + case IDTB_FAVORITES: > + /* These are officially unimplemented as of the Windows 7 SDK */ > + break; Could you point me to a link on this behavior? I'm pretty sure that many of these buttons send a signal that applications can hook into and override the default (do-nothing) behavior. Erich Hoover ehoover(a)mines.edu

3 2

Re: [1/4] ddraw/tests: Use sizeof instead of a magic number
by Stefan Dösinger Sept. 24, 2011

Sept. 24, 2011

Am 24.09.2011 um 12:48 schrieb Stefan Dösinger: > <PGP.txt> WTF? What did my Mail client do here???

1 0

Congratulations! DIB engine 421
by Keith Sept. 24, 2011

Sept. 24, 2011

Hi, Amazing I'm a long time follower of the project and to see a DIB engine implemented is a huge milestone given all the trials and tribulations leading up to it. Honestly never thought it would happen everyone needs to give themselves a pat on the back today :-) Regards, Keith

1 0

Re: dpnet: fill the DPN_SP_CAPS structure in IDirectPlay8Peer_GetSPCaps with some sane values + tests
by Marvin Sept. 23, 2011

Sept. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14486 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)
by Andrew Talbot Sept. 23, 2011

Sept. 23, 2011

Marcus Meissner wrote: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. > > CID 5033, 5034 > > Ciao, Marcus > --- > dlls/comdlg32/itemdlg.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c > index bc309c9..d9756c0 100644 > --- a/dlls/comdlg32/itemdlg.c > +++ b/dlls/comdlg32/itemdlg.c > @@ -1106,6 +1106,8 @@ static SIZE update_layout(FileDialogImpl *This) > SIZE ret; > > GetClientRect(This->dlg_hwnd, &dialog_rc); > + memset (&toolbar_rc, 0, sizeof(toolbar_rc)); > + memset (&filename_rc, 0, sizeof(filename_rc)); > > missing_width = max(0, 320 - dialog_rc.right); > missing_height = max(0, 200 - dialog_rc.bottom); Hi Marcus, Instead of using memset(), would it not be better to initialise the RECTs to zero when declaring them, as follows? RECT toolbar_rc = { 0 }; RECT filename_rc = { 0 }; -- Andy.

1 0

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)
by Alexandre Julliard Sept. 23, 2011

Sept. 23, 2011

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. It's not clear that 0 is much better. If there's really a possibility for these things to be missing the layout should take that into account. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)
by Bruno Jesus Sept. 23, 2011

Sept. 23, 2011

On Fri, Sep 23, 2011 at 07:50, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Note: the 2 failing tests on test-bot that this patch will produce, are not real failures as winnt and win2000 will not run the test because of missing dpnet > > try 3: rewrote patch in a more straightforward way > > this makes previously sent tests pass, and fixes crash in bug http://bugs.winehq.org/show_bug.cgi?id=28008 Use the broken macro to skip or expect a different return from the tests that crash in NT and add a comment there. Example: http://source.winehq.org/source/dlls/ole32/tests/usrmarshal.c#L103 Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)
by Marvin Sept. 23, 2011

Sept. 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14466 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: mshtml: Add IHTMLCurrentStyle2/3/4 support
by Alexandre Julliard Sept. 23, 2011

Sept. 23, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/mshtml/Makefile.in b/dlls/mshtml/Makefile.in > index 3933645..62a2d6f 100644 > --- a/dlls/mshtml/Makefile.in > +++ b/dlls/mshtml/Makefile.in > @@ -14,6 +14,7 @@ C_SRCS = \ > htmlbody.c \ > htmlcomment.c \ > htmlcurstyle.c \ > + htmlcurstyle2.c \ Please add this to the existing file. There are already way too many source files in this dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: Highlighting Fall-throughs
by Andrew Talbot Sept. 23, 2011

Sept. 23, 2011

Hi All, I am thinking of marking any unmarked places in switch statements where fall-through occurs. However, simply to do so would be to ignore the question of whether each fall-through is intentional or an oversight. I therefore propose to mark each new point with two comments (maybe separate, maybe combined): one to state that fall-through occurs and the other to point out that the validity of this particular fall-through has not yet been checked, maybe something like: select(x) { case 1: foo(); break; case 2: bar(); /* fall through */ /* unaudited */ default: baz(); } Is this all good, or is there a better way? Thanks, -- Andy.

3 4

Re: comctl32: Fix going to today with multiple calenders
by Nikolay Sivov Sept. 22, 2011

Sept. 22, 2011

On 9/23/2011 00:03, André Hentschel wrote: > --- > dlls/comctl32/monthcal.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index 5f8a36c..b330871 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam) > if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD, > menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL)) > { > - infoPtr->calendars[0].month = infoPtr->todaysDate; > - infoPtr->minSel = infoPtr->todaysDate; > - infoPtr->maxSel = infoPtr->todaysDate; > + MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate); > InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); > } > This is wrong, it lacks notification calls and you have unneeded invalidate call left. Also similar case remains to be fixed. Actually I planned to work on this tomorrow, including some other issues I just spotted.

2 2

Fwd: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation
by Dan Kegel Sept. 22, 2011

Sept. 22, 2011

Didn't build here, did you forget to add dependency on ole32? ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -Wno-unused-but-set-variable -Wno-unused-but-set-parameter -o vwin32.o vwin32.c global.o: In function `create_object': /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:74: undefined reference to `CLSIDFromProgID' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:92: undefined reference to `CoGetClassObject' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:114: undefined reference to `CoTaskMemFree' collect2: ld returned 1 exit status winegcc: ccache failed make[1]: *** [vbscript.dll.so] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Thu, Sep 22, 2011 at 8:01 AM Subject: Re: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/26 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/vbscript] Error 2

2 1

IPv6 issue on TestBot?
by Francois Gouget Sept. 22, 2011

Sept. 22, 2011

Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( This makes accessing it from my desktop very annoying. $ time wget -4 --quiet http://testbot.winehq.org/ real 0m2.150s user 0m0.000s sys 0m0.000s $ time wget -6 --quiet http://testbot.winehq.org/ ... still stuck after 6+ minutes $ telnet -6 testbot.winehq.org Trying 2001:888:2000:38:1000::2... ... same thing According to http://test-ipv6.com/ my desktop is configured just fine and I only have trouble with the TestBot. Could this be a firewall problem? (testbot exposing an IPv6 address but the firewall dropping any IPv6 packets) In the mean time I'm going to use my laptop which is still IPv4 only :-/ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

6 11

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Jacek Caban Sept. 22, 2011

Sept. 22, 2011

> === WNT4WSSP6 (32 bit createobj) === > createobj.c:734: Test failed: CoCreateInstance failed: 80040154 > createobj: unhandled exception c0000005 at 00402A21 These tests fail because testbot runs them regardless that vbscript.dll is not present on the machine. Jacek

1 0

Tests failing on OSX
by Stefan Dösinger Sept. 22, 2011

Sept. 22, 2011

Hi, I'm attempting to set up a OSX testbot and I'm currently trying to get as many tests to work as possible. The following is a list of tests that fail currently. I'm hoping for comments if anybody knows more about them: (This is a 2006-era iMac, OSX 10.6, using the stock X server) > dinput8/device.c device.c:87: Test failed: We're not able to inject input into Windows dinput8 with events Fails sometimes, succeeds sometimes. > gdi32/dc > user32/monitor No Xvidmode support, so Get/SetDeviceGammaRamp fail. There's a win_skip for that already. Should we change it to skip(), or ignore it until we have a quartz driver? User32/monitor also fails because it can't change the display mode. > kernel32/change > ntdll/change > ntdll/directory Lots of test failures. I'm not sure what those tests do tbh > ntdll/exception "Test failed: Execution of data memory succeeded." Do I have to do anything special to enable NX support on OSX? > mmdevapi/capture Various Set*Volume calls fail > tests/shlexec Random failure: "shlexec.c:1023: test failed: Expected success (33), got failure (11), lpFile: C:\users\pts\Temp\wtb6bf.tmp\test file.shlexec" > urlmon/url > winmm/mci Test failed: mci resume waited Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) > ddraw/visual > d3d8/visual > d3d9/visual I'll investigate those. I bet they are GPU dependent. > ws2_32/sock A mixture of test failures and unexpected successes. > ddraw/d3d The window message test can't cope with the resolution change failure. I'll fix it. Using a virtual desktop works around the problem > ddraw/dsurface Crashes sometimes during cleanup in fbo-related GL calls. > d3dx9_36/math > d3dx9_36/texture I just sent patches for those. There was an issue with NaN sign bits and some GPU limitations the tests didn't account for.

5 13

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Marvin Sept. 22, 2011

Sept. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14455 Your paranoid android. === WNT4WSSP6 (32 bit createobj) === createobj.c:734: Test failed: CoCreateInstance failed: 80040154 createobj: unhandled exception c0000005 at 00402A21

1 0

Re: [PATCH 07/13] vbscript: Added exit for statement support
by Marvin Sept. 22, 2011

Sept. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14454 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/13] vbscript: Added for..in statement tests
by Marvin Sept. 22, 2011

Sept. 22, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14453 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

crypt32(1/2): Test CertCreateCertificateContext, and fix an error code in a failure case
by Juan Lang Sept. 22, 2011

Sept. 22, 2011

--Juan

1 0