September 2011 - Wine-Devel

Re: [PATCH 5/9] cmd/tests: fix TODOs in test output (quotes)
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14398 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2

1 0

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14397 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2

1 0

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14396 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@')

1 0

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())
by Frédéric Delanoy Sept. 19, 2011

Sept. 19, 2011

On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck(a)arcor.de> wrote: > Fix output after "cmd: use GetCommandline() rather than argv" patch. > This also fixes the test case where Wine would hang. Having path P1 fixing issue and P2 changing .cmd/.exp is wrong. Testsuite has to pass after every patch committed. The normal procedure is: P1 (add tests); P2 (add fixes + update results) In cases it's not possible, you may merge the two patches in a single patch

1 0

Something's rotten in git today...
by Dan Kegel Sept. 19, 2011

Sept. 19, 2011

It might be just me, but I've seen five very strange test failures today out of about 30 build/test runs. Has anybody else noticed problems? Here they are, most recent first: ==== http://buildbot.kegel.com/builders/runtests-default/builds/72 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c && touch service.ok err:rpc:I_RpcGetBuffer no binding err:rpc:I_RpcGetBuffer no binding service.c:152: Test failed: Expected success, got error 1060 err:rpc:I_RpcGetBuffer no binding service.c:176: Test failed: Expected ERROR_SERVICE_DOES_NOT_EXIST, got 123 ... ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\removeme\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:946: Test failed: CreateFileA failed on \\?\C:, hFile 0xffffffffffffffff, err=2, should be 0 ... ==== http://buildbot.kegel.com/builders/runtests-default/builds/70 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist make: *** [action.ok] Error 1 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:5393: Test failed: Directory not created ... make: *** [install.ok] Error 8 ==== http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/68 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c && touch service.ok ... service.c:2084: Test failed: Winetest Sleep Service: QueryServiceStatusEx() failed le=1727 service.c:2085: Test failed: Winetest Sleep Service: should be stopped state=ff service.c:2092: Test failed: Winetest Sleep Service: the second try should yield the same error: 1728 != 1727 service.c:2098: Test failed: Winetest Sleep Service: 1727 != ERROR_SERVICE_NOT_ACTIVE service.c:2099: Test failed: Winetest Sleep Service: should be stopped state=deadbeef service.c:2188: Test failed: 1728 != ERROR_SERVICE_REQUEST_TIMEOUT service.c:2223: Test failed: Expected success, got error 6 ... make: *** [service.ok] Error 20 ==== http://buildbot.kegel.com/builders/runtests-default/builds/67 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist

6 8

Re: Old imagehlp patches
by Juan Lang Sept. 19, 2011

Sept. 19, 2011

Hi Thomas, wrong mailing list. You wanted wine-devel instead (now cc'ed.) > I don't know about wine development, but are these patches still likely to > work? What would need to happen for them to be merged in? To your first question, try them and see! To your second question, a lot. They're much too large to be merged at a single go, they lack tests, and they should be sent by their original author. I wouldn't hold your breath expecting these patches to go in as-is: if they weren't good enough in 2004-5, they're not any better now. You'd want someone who has an active interest in this area to have a go at them, I believe, unless you can convince the original author to take them up again. --Juan

3 2

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)
by Nikolay Sivov Sept. 19, 2011

Sept. 19, 2011

On 9/19/2011 17:32, Francois Gouget wrote: > --- > > Don't return from inside the block this time. > > dlls/comctl32/imagelist.c | 13 ++++++++++++- > dlls/comctl32/tests/imagelist.c | 17 +++++++++++++++-- > 2 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c > index ec62370..83b8b44 100644 > --- a/dlls/comctl32/imagelist.c > +++ b/dlls/comctl32/imagelist.c > @@ -54,6 +54,7 @@ > #include "commoncontrols.h" > #include "imagelist.h" > #include "wine/debug.h" > +#include "wine/exception.h" > > WINE_DEFAULT_DEBUG_CHANNEL(imagelist); > > @@ -3587,7 +3588,17 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > - return himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > + BOOL valid; > + __TRY > + { > + valid = himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > + } > + __EXCEPT_PAGE_FAULT > + { > + valid = FALSE; > + } > + __ENDTRY > + return valid; > } Maybe use IsBadReadPtr() with sizeof(void*) is better? You need only vtable pointer to be accessible.

3 3

re: mscoree: Add .Net debugging interfaces
by Dan Kegel Sept. 19, 2011

Sept. 19, 2011

Doesn't apply here: $ wget http://source.winehq.org/patches/data/79041 $ git reset --hard origin $ patch -p1 < 79041 patching file include/Makefile.in patching file include/cordebug.idl patch: **** malformed patch at line 998: -- $ git reset --hard origin $ git apply 79041 79041:99: trailing whitespace. interface ICorDebugValueBreakpoint; fatal: corrupt patch at line 999

1 0

Ole16 to Ole32 mapping
by Bruno Jesus Sept. 19, 2011

Sept. 19, 2011

Hi, I would like some advice about Ole function redirection. The winsock16 dll maps some operations to ws2_32 dll, I thought I could do the same with Ole16disp to Oleaut32. For example the function SAFEARRAYALLOCDESCRIPTOR in Ole16disp have a similar counterpart named SafeArrayAllocDescriptor in Oleaut32. There are dozens of functions like this if you look in the spec files of these dlls. I added oleaut32 to the imports and started mapping by making one line functions, for example SAFEARRAYALLOCDESCRIPTOR simply return calling SafeArrayAllocDescriptor from Ole32. Is it ok to do it like this? I implemented SafeArrayAlloc[Descriptor/Data] and SafeArrayDestroy[Descriptor/Data] and they seem to be working, then I started implementing some of the others and testing with the application winverbs from bug #28113. Is there any msdn documentation like to these old functions? I would like to compare the function parameters in some cases. Thanks in advance, Bruno -- universe* god::bigbang (void); //and then it all began...

3 2

Re: [po]updated korean resource(2011-09-19)
by Francois Gouget Sept. 19, 2011

Sept. 19, 2011

msgstr "" +"Wine is free software; you can redistribute it and/or modify it under the " +"terms of the GNU Lesser General Public License as published by the Free " +"Software Foundation; either version 2.1 of the License, or (at your option) " +"any later version.\n" +"\n" +"Wine is distributed in the hope that it will be useful, but WITHOUT ANY " +"WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS " +"FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for " +"more details.\n" +"\n" +"You should have received a copy of the GNU Lesser General Public License " +"along with Wine; if not, write to the Free Software Foundation, Inc., 51 " +"Franklin St, Fifth Floor, Boston, MA 02110-1301, USA." This is not a translation so I don't think it should be put in the PO file[1]. Copying the English string is not needed by Wine and it will only make it less likely that a proper translation is provided later. [1] Also Korean is not an RTL language so the 'Hebrew' exception does not apply<g>. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

1 0

Re: [PATCH 16/17] vbscript: Added interp_me implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14384 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 14/17] vbscript: Added support for SCRIPTITEM_ISVISIBLE named items
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14383 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/17] vbscript: Added error object stub implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14382 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/17] vbscript: Added is expression implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14380 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: vbscript: Make vbdisp_get_id() static.
by Jacek Caban Sept. 19, 2011

Sept. 19, 2011

Hi Francois, On 09/18/11 19:37, Francois Gouget wrote: > --- > dlls/vbscript/vbdisp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c > index 14fb8b0..db1c864 100644 > --- a/dlls/vbscript/vbdisp.c > +++ b/dlls/vbscript/vbdisp.c > @@ -52,7 +52,7 @@ static BOOL get_func_id(vbdisp_t *This, const WCHAR *name, vbdisp_invoke_type_t > return FALSE; > } > > -HRESULT vbdisp_get_id(vbdisp_t *This, BSTR name, vbdisp_invoke_type_t invoke_type, BOOL search_private, DISPID *id) > +static HRESULT vbdisp_get_id(vbdisp_t *This, BSTR name, vbdisp_invoke_type_t invoke_type, BOOL search_private, DISPID *id) > { > unsigned i; Good catch, but my recent patch series needs it being non-static. Jacek

1 0

Re: [PATCH 05/17] vbscript: Added interp_lteq implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14379 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 04/17] vbscript: Added interp_lt implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14378 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 03/17] vbscript: Added interp_gt implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14377 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/17] vbscript: Added interp_gteq implementation
by Marvin Sept. 19, 2011

Sept. 19, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14376 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: comctl32: Don't crash when getting a bad image list handle.
by Alexandre Julliard Sept. 19, 2011

Sept. 19, 2011

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -3587,7 +3588,15 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > - return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > + __TRY > + { > + return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > + } > + __EXCEPT_PAGE_FAULT > + { > + return FALSE; > + } > + __ENDTRY You can't return from a __TRY block. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.
by Jacek Caban Sept. 18, 2011

Sept. 18, 2011

On 09/16/11 15:25, Francois Gouget wrote: > --- > > This fixes this test on the WNT4WSSP6 testbot machine. > It also helps on my NT4 VM but one would not notice because there's no > ieframes dll so WineTest does not even try to run this test! > > dlls/ieframe/tests/webbrowser.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index a36c134..0506be6 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -212,7 +212,10 @@ static HRESULT _create_WebBrowser(unsigned line, IUnknown **unk) > > hres = CoCreateInstance(&CLSID_WebBrowser, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > &IID_IUnknown, (void**)unk); > - ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: %08x\n", hres); > + if (hres == REGDB_E_CLASSNOTREG) > + win_skip_(__FILE__,line)("WebBrowser is not supported\n"); > + else > + ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: %08x\n", hres); > return hres; > } The failure is valid here, it's the testbot that is not smart enough. The tested DLL is not present on WINNT, so the test should be skipped automatically, like winetest does. Jacek

2 3

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3)
by Marvin Sept. 18, 2011

Sept. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14371 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

re: msxml3: Fix printing NULL strings
by Dan Kegel Sept. 18, 2011

Sept. 18, 2011

Hi Francois, your patch has a signedness problem which makes -Werror unhappy. (We could disable signedness warnings, but since we don't currently have any, it's nice to keep them out of the tree...) Here's the log from the buildbot: $ ccache gcc -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o element.o element.c cc1: warnings being treated as errors element.c: In function ‘variant_from_dt’: element.c:666: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘element_get_dt’: element.c:732: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘domelem_put_nodeTypedValue’: element.c:789: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘domelem_put_dataType’: element.c:937: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/msxml3' make[1]: *** [element.o] Error 1 make: *** [dlls/msxml3] Error 2

2 1

Re: quartz/tests: Skip some tests if not allowed to register filters.
by Marvin Sept. 18, 2011

Sept. 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14367 Your paranoid android. === WNT4WSSP6 (32 bit filtermapper) === filtermapper.c:93: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:230: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:344: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:402: Test failed: CoCreateInstance failed with 80040154

2 1

Re: shell32: Don't dereference NULL pointers when tracing.
by Octavian Voicu Sept. 18, 2011

Sept. 18, 2011

On Sun, Sep 18, 2011 at 8:37 PM, Francois Gouget <fgouget(a)free.fr> wrote: > + TRACE("-- vmode %#x, flags %#x", view_params->pfs->ViewMode, view_params->pfs->fFlags); > + if (view_params->prcView) > + TRACE(", left %d, top %d, right %d, bottom %d", view_params->prcView->left, > + view_params->prcView->top, view_params->prcView->right, view_params->prcView->bottom); > + TRACE("\n"); I think it would look much nicer with wine_dbgstr_rect and it can handle NULL pointers. Octavian

1 0