September 2011 - Wine-Devel

[RFC] Re: [PATCH 1/2]rpcrt4/tests: Add some commented tests for widl
by Jérôme Gardou Sept. 14, 2011

Sept. 14, 2011

Hello. I've seen that this patch is in "pending" state, and I would like to know what is the problem with it. Also, if commenting the tests isn't a policy you want to enforce (that I would understand), I'm ready to skip them on wine, but how to? Those tests were made with midl from Visual Studio 10, with or without /Os option, and ran smoothly. http://www.winehq.org/pipermail/wine-patches/2011-August/106200.html Regards. Jérôme. Le 06/09/2011 00:50, Jérôme Gardou a écrit : > Also, the added function which seems to be useless permits to detect > the problem that the next patch fixes. > Enable -Oif, and the test of server.c line 947 (after patch > application) will fail. > --- > dlls/rpcrt4/tests/server.c | 46 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 1 + > 2 files changed, 47 insertions(+), 0 deletions(-) > > > > >

2 1

quartz: Fix converting between the media time and REFTIME
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 14, 2011

Sept. 14, 2011

Hi, I've never tried to understand quartz, but I'd like to know whether quartz expects particular behaviour from the underlying winmm or mmdevapi time/position/length functions. For instance, quartz says its clocks are monotically increasing, whereas no such requirement is documented (or at least known to me) for the audio stream positions. This may seem obvious, but then I came across some mailing list where people reported a sudden backward change in stream position when pluggin/unplugging earphones or the like. Is quartz very decoupled from the underlying audio information? Who stops the clock (if at all) while the stream is paused? BTW, in theory I have the tools to easily test quartz, using my interactive MCI shell http://bugs.winehq.org/show_bug.cgi?id=20232#c10 However every time I tried, I found mciqtz too underpowered to be able to reasonably use it. :-( Using the MCI to use mciqtz (which in turn uses quartz.dll) goes as follows: wine wintest.exe mcishell open foo.wav alias w type mpegvideo status w length play w from 0 notify wait close w # lots of other commands are available open foo.avi alias a type mpegvideo window a state show status a length play a from 0 close a Omit the "type mpegvideo" and mciwave or mciavi will be used instead of mciqtz32.dll Regards, Jörg Höhle

3 2

re: [PATCH 11/21] vbscript: Added function parser implementation
by Dan Kegel Sept. 14, 2011

Sept. 14, 2011

Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a q9300 (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). On Wed, Sep 14, 2011 at 7:17 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/35 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > vbscript.c:443: Test failed: expected OnEnterScript > vbscript.c:444: Test failed: expected OnLeaveScript > make: *** [vbscript.ok] Error 2 > >

2 2

Re: [PATCH 1/3] server: certain access flags are illegal for OpenMutex
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14233 Your paranoid android. === WNT4WSSP6 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2KPROSP4 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === WXPPROSP3 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2K3R2SESP2 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === WVISTAADM (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2K8SE (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PRO (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PROX64 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PROX64 (64 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5

1 0

Re: [PATCH 06/21] vbscript: Added function arguments compiler implementation
by Octavian Voicu Sept. 14, 2011

Sept. 14, 2011

On Wed, Sep 14, 2011 at 1:56 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- a/dlls/vbscript/compile.c > +++ b/dlls/vbscript/compile.c > @@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx, function_decl_t *decl, functi > func->code_ctx = ctx->code; > func->type = decl->type; > > + func->arg_cnt = 0; > if(decl->args) { ... > + }else { > + decl->args = NULL; I think you want to set func->args to NULL at the last line. Cheers, Octavian

2 1

Re: [PATCH 19/21] vbscript: Added interp_xor implementation
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14230 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 10/21] vbscript: Added support for sub local variables
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14224 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 09/21] vbscript: Added exit sub statement implementation
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14223 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 08/21] vbscript: Added sub argument tests
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14222 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/21] vbscript: Added function compiler implementation
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14220 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

2 1

Re: [PATCH 05/21] vbscript: Added function invocation supprot to do_icall
by Marvin Sept. 14, 2011

Sept. 14, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14221 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: pdh/tests: Some tests require that the user interface be in English.
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14215 Your paranoid android. === W2KPROSP4 (32 bit pdh) === pdh.c:150: Test failed: PdhAddCounterA failed 0xc0000bc4 pdh.c:197: Test failed: PdhAddCounterW failed 0xc0000bc4

1 0

Re: ieframe/tests: Some tests require that the user interface be in English.
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14214 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3138: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2455: Test failed: expected GetOverridesKeyPath webbrowser.c:2459: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2460: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2069: Test failed: put_Resizable failed: 80004001 webbrowser.c:2070: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2074: Test failed: put_Resizable failed: 80004001 webbrowser.c:2075: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2455: Test failed: expected GetOverridesKeyPath webbrowser.c:2459: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2460: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:394: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2069: Test failed: put_Resizable failed: 80004001 webbrowser.c:2070: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2074: Test failed: put_Resizable failed: 80004001 webbrowser.c:2075: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2455: Test failed: expected GetOverridesKeyPath webbrowser.c:2459: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2460: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:447: Test failed: unexpected nCmdID 29 webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:2605: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2725: Test failed: expected TranslateUrl webbrowser.c:2726: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2727: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2733: Test failed: ReadyState = 1, expected 4 webbrowser.c:2557: Test failed: ReadyState = 1, expected 4 webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:793: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:800: Test failed: ReadyState = 1, expected 4 webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:595: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:599: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:603: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1495: Test failed: unexpected call GetOptionKeyPath webbrowser.c:343: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:447: Test failed: unexpected nCmdID 26 webbrowser.c:447: Test failed: unexpected nCmdID 29 webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:878: Test failed: ReadyState = 1, expected 4 webbrowser.c:1506: Test failed: unexpected call GetDropTarget webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:2605: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3098: Test failed: doc != doc2 webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:595: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:599: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:603: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1495: Test failed: unexpected call GetOptionKeyPath webbrowser.c:343: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:447: Test failed: unexpected nCmdID 26 webbrowser.c:447: Test failed: unexpected nCmdID 29 webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:1506: Test failed: unexpected call GetDropTarget webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:2598: Test failed: expected TranslateUrl webbrowser.c:2605: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2818: Test failed: expected RequestUIActivate webbrowser.c:2910: Test failed: Got 0x80004002 webbrowser.c:3105: Test failed: doc != doc2 webbrowser.c:3005: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

1 0

Re: shlwapi/tests: Some tests require that the user interface be in English.
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14213 Your paranoid android. === W2KPROSP4 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === WXPPROSP3 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === W2K3R2SESP2 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === W7PROX64 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === W7PROX64 (64 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB

1 0

Re: [1/3] msxml3: Add xmlparser interfaces
by Francois Gouget Sept. 13, 2011

Sept. 13, 2011

On Wed, 7 Sep 2011, Alistair Leslie-Hughes wrote: > > Changelog: > msxml3: Add xmlparser interfaces This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl which is a bit strange because I cannot find this type in the Windows SDK. But in the Windows 7 SDK there is an XmlError enumeration type in xmllite.h that looks similar but subtly different. These two enumaration types share some error codes, in particular XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the Windows 7 SDK. So what's going on? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

3 5

Re: [2/3] dinput: Prevent apps from hiding mouse cursor in the ConfigureDevices dialog.
by Alexandre Julliard Sept. 13, 2011

Sept. 13, 2011

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > @@ -377,6 +377,12 @@ static INT_PTR CALLBACK ConfigureDevicesDlgProc(HWND dialog, UINT uMsg, WPARAM w > break; > } > > + case WM_ACTIVATE: > + /* Prevent mouse cursor from disappearing inside the dialog */ > + ShowCursor(1); > + > + break; That will screw up the cursor show count, you can receive multiple WM_ACTIVATE. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cmd: Use NUL/0 instead of 0x00
by Alexandre Julliard Sept. 13, 2011

Sept. 13, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -374,7 +374,7 @@ void WCMD_HandleTildaModifiers(WCHAR **start, const WCHAR *forVariable, > points to the variable just after the modifiers. Process modifiers > in a specific order, remembering there could be duplicates */ > modifierLen = lastModifier - firstModifier; > - finaloutput[0] = 0x00; > + finaloutput[0] = '\0'; It's mostly a matter of taste, but I don't think '\0' is better than 0x00, it's just another complicated way of writing 0. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] shell32: Handle the directory parameter in ShellExecute functions (try 2 resend)
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14201 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\TEMP\wt1.tmp\newfolder\tmp\newfolder\tm', got 'C:\TEMP\wt1.tmp\newfolder\shell32_test.exe' === W2KPROSP4 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WXPPROSP3 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === W2K3R2SESP2 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WVISTAADM (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt7926.tmp\newfolder\etest\AppData\Local\Temp\wt7926.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt7926.tmp\newfolder\shell32_test.exe' === W2K8SE (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt4D32.tmp\newfolder\etest\AppData\Local\Temp\wt4D32.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt4D32.tmp\newfolder\shell32_test.exe' === W7PRO (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt70C.tmp\newfolder\etest\AppData\Local\Temp\wt70C.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt70C.tmp\newfolder\shell32_test.exe' === W7PROX64 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt11E4.tmp\newfolder\etest\AppData\Local\Temp\wt11E4.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt11E4.tmp\newfolder\shell32_test.exe' === W7PROX64 (64 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt329B.tmp\newfolder\etest\AppData\Local\Temp\wt329B.tmp\newfolder\etest\AppData\Loca', got 'C:\Users\winetest\AppData\Local\Temp\wt329B.tmp\newfolder\shell32_test64.exe'

1 0

Re: [1/2] shell32/tests: Fix path comparison (try 2)
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14200 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\TEMP\wt1.tmp\newfolder\tmp\newfolder\tm', got 'C:\TEMP\wt1.tmp\newfolder\shell32_test.exe' === W2KPROSP4 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WXPPROSP3 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === W2K3R2SESP2 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WVISTAADM (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtE6E8.tmp\newfolder\etest\AppData\Local\Temp\wtE6E8.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wtE6E8.tmp\newfolder\shell32_test.exe' === W2K8SE (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt7849.tmp\newfolder\etest\AppData\Local\Temp\wt7849.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt7849.tmp\newfolder\shell32_test.exe' === W7PRO (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt6624.tmp\newfolder\etest\AppData\Local\Temp\wt6624.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt6624.tmp\newfolder\shell32_test.exe' === W7PROX64 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt2944.tmp\newfolder\etest\AppData\Local\Temp\wt2944.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt2944.tmp\newfolder\shell32_test.exe' === W7PROX64 (64 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt188.tmp\newfolder\etest\AppData\Local\Temp\wt188.tmp\newfolder\etest\AppData\Loca', got 'C:\Users\winetest\AppData\Local\Temp\wt188.tmp\newfolder\shell32_test64.exe'

1 0

audio: when is a "Resource temporarily unavailable"?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 13, 2011

Sept. 13, 2011

Hi, Bug #28056 involving FreeBSD and OSS exhibits: warn:oss:AudioRenderClient_ReleaseBuffer write failed: 35 (Resource temporarily unavailable) My own notes from times as old as wine-1.1.8 show the same error with ALSA: err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Resource temporarily unavailable The symbolic errno constant is EAGAIN=EWOULDBLOCK. Does anybody have a suspicion when/why this happens? - is audio simply not reliable? - is Wine not correctly driving audio output? - ...? FWIW, my test experiments outside Wine recently produced EWOULDBLOCK once despite non-blocking mode in ALSA, when attempting to write a small number of frames, less than period_size. Is this failure really temporary or would it be safer to close or reset the audio device given such an error value? What's your experience? Thank you, Jörg Höhle

2 1

re: [2/2] msxml3: Support creating IXMLParser Interface
by Dan Kegel Sept. 13, 2011

Sept. 13, 2011

test fails here? xmlparser.c:41: Test failed: IXMLParser is not available (0x80040154) make: *** [xmlparser.ok] Error 1 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 13, 2011 at 7:45 AM Subject: Re: 78800: Subject: [2/2] msxml3: Support creating IXMLParser Interface To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/77 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 Errors: xmlparser.c:41: Test failed: IXMLParser is not available (0x80040154) make: *** [xmlparser.ok] Error 1

1 0

Re: [PATCH 03/22] vbscript: Added object member assignment tests
by Octavian Voicu Sept. 13, 2011

Sept. 13, 2011

On Tue, Sep 13, 2011 at 12:36 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: +const char *debugstr_variant(const VARIANT *v) +{ ... + case VT_I2: + return wine_dbg_sprintf("{VT_I4: %d}", V_I2(v)); Should be "{VT_I2: %d}". Octavian

1 0

Re: [PATCH 22/22] vbscript: Added interp_exp implementation
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14188 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 20/22] vbscript: Added interp_div implementation
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14186 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 17/22] vbscript: Added interp_idiv implementation
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14185 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 15/22] vbscript: Added interp_mod implementation
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14184 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/22] vbscript: Added if statement tests
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14183 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/22] vbscript: Added support for variable assignment statements
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14182 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/22] vbscript: Added variable value expression support
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14181 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 05/22] vbscript: Added dim statement compiler implementation
by Marvin Sept. 13, 2011

Sept. 13, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14180 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

RFC: Translating Wine's dialogs with PO files
by Francois Gouget Sept. 12, 2011

Sept. 12, 2011

This is the next step in making full use of the PO files for translating Wine. But how to get there is unclear, hence this RFC. The issue with dialogs is that in RC files all the dialog and control sizes are hardcoded. For instance in the line below '208, 6, 56, 14' represent the x-left, y-top, width and height of the button: DEFPUSHBUTTON "Save As", IDOK, 208, 6, 56, 14, BS_DEFPUSHBUTTON | WS_GROUP | WS_TABSTOP The problem is that once translated to French, for instance, the label becomes 'Enregistrer sous' which is much longer and may require enlarging the button. But RC files do not contain the information needed to do that automatically. For instance they don't specify enlarging this button requires enlarging the 'Cancel' and 'Help' buttons below too. So how do we solve this problem? Option 1 - Automatically layout the dialogs at compile time ----------------------------------------------------------- Gtk applications solve this problem by storing all the information needed to automatically layout dialogs in an XML file. The size and location of all the controls is then computed at runtime, after the dialog has been translated. We could do something similar, it would go something like this: * Use some format that lets us store all the layout information as the primary definition for Wine's dialogs. * At compile time translate the dialogs. * For each translation, layout the dialog and generate an RC file containing the computed control coordinates and sizes. * Then compile the RC files as usual. (alternatively the last two steps could be merged) Questions: * Which format should we use to define the layout? - Glade is the format used by Gtk. However it seems pretty Gtk centric and the set of controls/properties it supports may not match the Windows ones. It's possible to add libraries of custom widgets so that may be a solution. http://en.wikipedia.org/wiki/Glade_Interface_Designer - It looks like Microsoft added support for auto-layout in WPF (Windows Presentation Foundation) for .Net applications. This information can be stored in XAML XML files. http://msdn.microsoft.com/en-us/library/ms750441.aspx https://github.com/yadyn/WPF-Task-Dialog/blob/master/TaskDialog/CommandLink… Does anyone know how this works? Is it something we would need to implement in Wine anyway? Does some project already have support for it? Mono maybe? - For completeness I'll also mention that WxWidget also has a cross-platform layout engine. http://docs.wxwidgets.org/2.9.2/overview_xrc.html However as far as I know, none of them has tools that can generate RC files. * How can we do the layout? - Can we reuse a third-party layout engine? Like the one used for Glade files? - Wouldn't that introduce troublesome build dependencies? - Would it be ok if these dependencies are needed only when in maintainer mode? (In maintainer mode a change to a PO file could trigger an update to the corresponding RC files which would then be committed with the PO file change.) - Should we instead implement it all by ourselves? * How can we mesure the size that strings will take at run time? We probably have all the code we need in Wine. But can we use it are compile time? Will the computed layout depend on the fonts that are installed on the system where Wine is compiled? This is particularly important for languages with non-latin characters such as Japanese, Hebrew or Telugu. Pros: * We would not have to manually layout dialogs ever again. Yay! * We might be able to reuse the graphical dialog design tools of the system we adopt, like Glade or possibly some .Net tools. * There would be no risk of the translation and layout getting out of sync. * We would no longer need one RC file per language, thus eliminating the risk that they become out of sync (e.g. adding a given window style to some but not all languages). Cons: * Just integrating support for the layout engine and generating RC files seems like a lot of work. * Potential for additional build-time third-party dependencies for the layout engine. * Would require rewritting all our dialogs so they have all the needed layout information. That is definitely a lot of work. Option 2 - Add layout information to RC files --------------------------------------------- The idea here is the same as for option 1 except that we would add the layout information as comments in the existing RC files. As a very rough exemple it could look something like this: #layout# start box(orientation = vertical, padding = 8) #layout# start button(expand = true, fill = true) DEFPUSHBUTTON "Save As", IDOK, 208, 6, 56, 14, BS_DEFPUSHBUTTON | WS_GROUP | WS_TABSTOP #layout# end button ... #layout# end box Pros: * Same as for option 1. Cons: * We would be inventing our own syntax. * Not as clean as option 1. * The comments would risk becoming out of sync with the dialogs (e.g. if a developper adds a button but not the comment specifying how it is to be layed out). wrc might be able to check that things are consistent though. * It would be as much work as option 1. * We would have no chance of leveraging an existing layout engine. Option 3 - Use per-language RC files to store hardcoded dialog layouts ---------------------------------------------------------------------- This solution would reuse the existing per-language RC files but would refresh their labels using the PO files. Here is how it would work: * Every control of a given dialog would need to have a unique id. This should only be an issue for static labels which currently tend to all have -1 as their id. So we would first have to reassign them different ids like -1, -2, -3 or stc1, stc2, stc3, etc. * For each control that has a label in a language-specific RC file, look for the corresponding '<dialog-id>+<control-id>' combination in the English RC file. If no match is found that's an error. * Take corresponding English label and use the PO file to translate it. * Use the translated label instead of the, potentially outdated, one that was in the language-specific RC file. * This could be done by wrc when generating a .res file. This way any PO file change would immediately be reflected in the build. Alternatively this could be a maintainer-only task that updates the language-specific RC files whenever a PO file patch is committed. We could even do both so the labels in the language-specific RC files don't become too out of date. * If a given dialog is missing from a language-specific RC file, we would do as if the English dialog data was present instead and proceed as described above. Pros: * The current RC files would not need extensive modifications. * In fact we could progressively simplify them by removing all the translated dialogs that don't change the layout. * This solution feels like it should be easier to put in place than an automatic layout one. Cons: * We would still need to manually layout or verify the layout of every single dialog for every single language :-( * The translators would have no idea that there is a dialog whose layout may need to be changed as a result of their changes to the PO file. Developpers would similarly be hard pressed to make the connection and would likely lack the motivation to update the dialog layouts. So the dialog layouts would likely continue to be rarely updated and possibly incorrect. Exactly like today. * For every dialog with a customized dialog the translations would be stored both in the language-specific RC file and in the PO file. This could be confusing. Option 4 - Put the sizes in special PO files -------------------------------------------- This would really be a very ugly hack. Like option 2 it requires that every control of a given dialog have a unique id. Then for each of them we would create PO file entries of the form: msgctxt "<rc-filename>:<dialog-id>:<control-id>" msgid "<x>:<y>:<width>:<height>" msgstr "" We then put all these 'messages' in a sizes-<lang>.po file. Whenever a control needs to be resized a 'translation' would be provided in the relevant sizes-<lang>.po file. We would only keep the English RC file and when compiling the resources for a given language wrc would check whether the sizes-<lang>.po file contains a translation of the size data for the current control. Pros: * Maybe the easiest solution to put in place. Cons: * Totally ugly. * Probably awful to work with to change the layout of a dialog. * All the drawbacks of Option 2. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

3 4

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
by Frédéric Delanoy Sept. 12, 2011

Sept. 12, 2011

2011/9/9 Eric Pouech <eric.pouech(a)orange.fr>: > WineDbg> set ! symbol_picker scoped > will do what you want > unfortunately, there's no way to store it as a default command (you can > always use --command or --file on command line to help) > A+ Speaking of --command and --file options, they aren't documented either. I'm willing to update winedev guide, but I'd like more info first. I found that --file accepts the set of commands to execute (but winedbg exits afterwards), but what does --command do? Is there a way to specify initial commands to execute, then stay *inside* winedbg after the last command of the file is issued? Frédéric

2 2

re: [5/5] ddraw: Use a Z format suported by the driver in the visual test
by Dan Kegel Sept. 12, 2011

Sept. 12, 2011

Fails to compile on gcc-2.95 here: visual.c: In function `enum_z_fmt': visual.c:61: request for member `u1' in something not a structure or union visual.c:61: request for member `u1' in something not a structure or union make[1]: *** [visual.o] Error 1 make: *** [dlls/ddraw/tests] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 1:56 PM Subject: Re: 78663: Subject: [5/5] ddraw: Use a Z format suported by the driver in the visual test To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-gcc295 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-gcc295/builds/31 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

1 1

Re: attrib: Add quotes to fix the usage message indentation.
by Alexandre Julliard Sept. 12, 2011

Sept. 12, 2011

Francois Gouget <fgouget(a)free.fr> writes: > --- > > Start-of-line spaces are ignored in RC files. That syntax is not supported by RC, so it's best avoided. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)
by Alexandre Julliard Sept. 12, 2011

Sept. 12, 2011

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > changes from try1: remove erraneous HeapFree That's not much better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Support for alternate data streams in NtCreateFile?
by Frédéric Delanoy Sept. 12, 2011

Sept. 12, 2011

Hi, What is the support status of (NTFS) names streams in wine? I only see include/winnt.h:4788:#define FILE_NAMED_STREAMS 0x00040000 but it doesn't seem to be used anywhere else in the code. (there's probably no possible translation in most filesystems) NtCreateFile (hence cmd) currently happily creates files/directories with colons in them, while it probably shouldn't for most FS. I'm asking this because ':' is normally disallowed in file/dirnames (http://msdn.microsoft.com/en-us/library/aa365247(v=VS.85).aspx) and was trying to add tests in ntdll/tests/file.c, except when named streams are supported by the underlying FS. Should I test the flags returned from GetVolumeInformation, and add tests for both named-stream-allowed and non-named-stream allowed FSs? Or should I assume that named streams won't ever be implemented and assume colons are disallowed, without checking the FILE_NAMED_STREAMS flag? Frédéric

2 1

Re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames
by Alexandre Julliard Sept. 12, 2011

Sept. 12, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -162,6 +162,7 @@ static void create_file_test(void) > '\\','f','a','i','l','i','n','g',0}; > static const WCHAR questionmarkInvalidNameW[] = {'a','f','i','l','e','?',0}; > static const WCHAR pipeInvalidNameW[] = {'a','|','b',0}; > + static const WCHAR colonInvalidNameW[] = {':','c',0}; That's not a good test file name... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 17/21] vbscript: Added '<>' expression implementation
by Marvin Sept. 12, 2011

Sept. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14158 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 16/21] vbscript: Added interp_sub implementation
by Marvin Sept. 12, 2011

Sept. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14157 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 15/21] vbscript: Added interp_add implementation
by Marvin Sept. 12, 2011

Sept. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14156 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/21] vbscript: Added interp_neg implementation
by Marvin Sept. 12, 2011

Sept. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14155 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 08/21] vbscript: Added hex literal implementation
by Marvin Sept. 12, 2011

Sept. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14153 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/21] vbscript: Added interpreter support for numeric literals
by Marvin Sept. 12, 2011

Sept. 12, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14152 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Marking test cases as flaky?
by Dan Kegel Sept. 12, 2011

Sept. 12, 2011

Hi folks, I've been running "make test" a lot lately, and occasionally (it happened five times today), a test will fail out of the blue, in one out of twenty or a hundred runs. It would be bad form for buildbot to reject a patch because of a spurious test failure, so I've been making a list of tests that fail, adding to it each time I run into a test that fails occasionally, and skipping the tests on that list during "make test". This is all fine... but one of the tests that fails occasionally is ddraw/visual.ok (see http://bugs.winehq.org/show_bug.cgi?id=28301 ). It really doesn't feel right to skip that entirely just because a few particular pixel comparisons fail sometimes. Plan A would be to fix the tests to not be flaky, but that's hard, and the buildbot needs a quick solution. Plan B might be to conditionally compile the flaky tests away, e.g.: --- a/dlls/ddraw/tests/visual.c +++ b/dlls/ddraw/tests/visual.c @@ -1490,6 +1490,7 @@ static void D3D1_TextureMapBlendTest(void) ok(hr == D3D_OK, "IDirect3DDevice3_EndScene failed, hr = %08x\n", hr); } +#ifndef WINE_SKIP_FLAKY_TEST_SEE_BUG_28301 color = D3D1_getPixelColor(DirectDraw1, Surface1, 5, 5); red = (color & 0x00ff0000) >> 16; green = (color & 0x0000ff00) >> 8; @@ -1513,6 +1514,7 @@ static void D3D1_TextureMapBlendTest(void) green = (color & 0x0000ff00) >> 8; blue = (color & 0x000000ff); ok(red == 0 && green == 0 && blue == 0xff, "Got color %08x, expected 000000ff or near\n", color); +#endif Then my blacklist would mostly be a bunch of -D definitions in CFLAGS, one per flaky test. Or we could use a single define for all flaky tests. I may try that privately, to increase buildbot's test coverage. Would something like that be useful for other people, or should I just stick with private patches? - Dan

4 8

Re: [PATCH] cmd: Add help info for xcopy
by Frédéric Delanoy Sept. 12, 2011

Sept. 12, 2011

On Fri, Sep 9, 2011 at 09:16, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > > --- a/programs/cmd/builtins.c > +++ b/programs/cmd/builtins.c > @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'}; > static const WCHAR nullW[] = {'\0'}; > > const WCHAR externals[][10] = { > - {'A','T','T','R','I','B','\0'} > + {'A','T','T','R','I','B','\0'}, > + {'X','C','O','P','Y','\0'} Patch is OK, but for consistency, shouldn't the externals be put at the start of wcmdmain.c, just after the inbuilt[][]10]? This way, you could see directly which command is built-in, and which is external. Frédéric

3 3

Re: notepad: Die if we get an unknown encoding name in load_encoding_name().
by Octavian Voicu Sept. 11, 2011

Sept. 11, 2011

On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget <fgouget(a)free.fr> wrote: > - assert(0 && "bad encoding in load_encoding_name"); > + assert("bad encoding in load_encoding_name"); Hello, assert() is a debug macro which generates some code such that, during runtime: if the argument is non-zero, nothing happens; if the argument is zero, a message like "Assertion `X' failed" is printed (where X is exactly the expression that was given as an argument to assert, string-ified). assert(X) is something like: "I assert that at this point in the code, X holds; if you get there and X doesn't hold, tell me and abort the program". So assert(0 && "msg") will always trigger an assertion failure and tell you something like "Assertion `0 && "msg"' failed" then exit, which is good. If you change it to assert("msg"), condition will always be true so assertion will never be triggered. Octavian

2 1

re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames
by Dan Kegel Sept. 11, 2011

Sept. 11, 2011

Hi Frédéric, fails a test here: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok fixme:cryptnet:CryptGetObjectUrl unimplemented for 0 cryptnet.c:444: Test failed: Expected ERROR_FILE_NOT_FOUND or ERROR_PATH_NOT_FOUND, got 123 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 3:14 PM Subject: Re: 78678: Subject: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default-x86_64 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/44 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)
by Alexandre Julliard Sept. 11, 2011

Sept. 11, 2011

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I sent basically this in February without any feedback, and it still > applies. It's still wrong, the parameter is used inside the #ifdef. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)
by Marvin Sept. 11, 2011

Sept. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14145 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: shell32/tests: Make test explicit about return pointer
by Marvin Sept. 11, 2011

Sept. 11, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0