September 2011 - Wine-Devel

re: msi: Properly check for a specified flag combination
by Dan Kegel Sept. 10, 2011

Sept. 10, 2011

Test failed here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... err:msi:env_parse_flags Invalid flags: 00000007 err:msi:ITERATE_Actions Execution halted, action L"RemoveEnvironmentStrings" returned 1627 err:msi:env_parse_flags Invalid flags: 00000007 action.c:5588: Test failed: Expected ERROR_SUCCESS, got 1627 action.c:5594: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5597: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5609: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 fixme:ntdll:NtQueryInformationToken QueryInformationToken( ..., TokenElevationType, ...) semi-stub action.c:5666: Test failed: key not created action.c:5670: Test failed: key not created action.c:5674: Test failed: key not created ... Command exited with non-zero status 7 4.04user 0.50system 0:05.03elapsed 90%CPU (0avgtext+0avgdata 51216maxresident)k 0inputs+7360outputs (0major+17117minor)pagefaults 0swaps make: *** [action.ok] Error 7 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sat, Sep 10, 2011 at 12:33 PM Subject: Re: 78647: Subject: msi: Properly check for a specified flag combination To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/15 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: urlmon/tests: Removed a test that causes random failures on some machines
by Marvin Sept. 10, 2011

Sept. 10, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14120 Your paranoid android. === WVISTAADM (32 bit sec_mgr) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

urlmon:sec_mgr failure on XP
by Francois Gouget Sept. 10, 2011

Sept. 10, 2011

This test now fails on my Widnows XP VMs that have IE >= 7 with 'All zones reset to default level': http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-… sec_mgr.c:1695: Test failed: Expected zone 3, but got 1 for 'file/testing/test.test' The patch that introduces the failures is 98d5dfb8 which was committed on the 5th. I did some experiments and I can get this test to pass if I do: * Go to the Internet Properties control panel * Security tab * Select 'Local intranet' * Click on the 'Sites' button * Deselect 'Automatically detect intranet network' * Deselect 'Include all local (intranet) sites not listed in other zones' * Click on 'OK' I also checked on Windows 7 and by default it has the first checkbox checked but the second one unchecked. Disabling 'Automatically detect intranet network' and enabling 'Include all local sites...' to match Windows XP causes the test to fail on Windows 7 too. Finally, on XP even if I deselect all the 'Include XXX' checkboxes but select the 'Automatically detect intranet network' one the test fails while with the same configuration it passes on Windows 7. So I think this reflects a difference in the way the intranet detection works. So I'm hoping that you can fix the test. The easiest fix would be to remove the 'file/testing/test.test' check. An alternative would be to check what the settings are and adjust the expected result or skip the test. But it seems like this would be much more complex. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

2 1

speeding up builds with ext4 and ccache tuning
by Dan Kegel Sept. 10, 2011

Sept. 10, 2011

Here's a little brain dump about speeding up builds. I ran into two problems today: - disk slowness On a machine where builds were slow, the iozone benchmark showed I/O was half or two thirds as fast as a better machine. The slow system turned out to be ext3, whereas the fast ones were ext4. (It's also using gcc-2.95.3 for wine, whereas the others are using the system compiler.) Adding a 7200rpm disk with an ext4 filesystem, and putting both wine-git and ~/.ccache on it, sped up ./configure so that it matched the faster system... but builds were only sped up by 20%. Nice, but not sufficient. - ccache too strict? ccache helps hugely on most of my systems without any tuning, but wasn't working well on my slow system. After looking at ccache's statistics and log file for a while, I came across the CCACHE_SLOPPINESS environment variable; setting that to maximum sloppiness got the cache hit rate sky-high, and build times dropped by a factor of 2, making the slower box suddenly competitive with the faster system. The sloppy setting is probably inappropriate for general use, but ok for regression testing. Those two tweaks get the buildbot cycle time for the headless subset of tests with gcc-2.95 on my e7300 down under nine minutes, yay.

1 1

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.
by Francois Gouget Sept. 10, 2011

Sept. 10, 2011

I'm actually not entirely happy with this patch. Wine actually hardcodes the fallback fonts to Liberation Serif and Tahoma. So we could instead check that if on Wine and the Windows fonts are not installed then we get the fallback fonts. It's a bit what the test was trying to do with Microsoft Sans Serif except that I also take exception with the todo_wine since the fix is not to change Wine but to install the missing font. Changing the test as I described would let us detect when Microsoft decides to ship other fonts instead of these. We would also issue an error if neither font was found, such as on FreeBSD 8.1 for instance as it is a hint that we should find some other/additional fallback font. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

4 4

The msctf:inputprocessor test is not reliable
by Francois Gouget Sept. 10, 2011

Sept. 10, 2011

This test is not reliable on my Debian desktop. http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/linux_… inputprocessor.c:2117: Test failed: OnSetFocus expected current focus 0x12b070 got 0x12b0d0 inputprocessor.c:538: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:549: Test failed: Sink reports wrong previous focus If I run it in a loop it fails about once every twelve times: i=0;while ../../../tools/runtest inputprocessor.c && [ $i -lt 100 ];do i=`expr $i + 1`; echo $i; done Introducing a single Sleep(50) as shown below makes it totally reliable here. ShowWindow(wnd3,SW_SHOWNORMAL); SetFocus(wnd3); + Sleep(50); processPendingMessages(); test_CurrentFocus = FOCUS_SAVE; test_PrevFocus = FOCUS_SAVE; test_OnSetFocus = SINK_SAVE; SetFocus(wnd1); processPendingMessages(); sink_check_saved(&test_OnSetFocus,dm2,dm1,"OnSetFocus"); /* ^^^ Line that fails! */ That seems pretty hacky though. I suspect this is all because processPendingMessages() will exit if there's no pending message right after we call SetFocus() without giving enough time for the asynchronous X event to arrive. But I'm surprised that a single Sleep() fixes the issue, especially where it's placed. Also I don't know anything about msctf so I'm unsure how ThreadMgrEventSink_OnSetFocus() figures in all this. So should I just submit a patch to add that Sleep()? Or would it be better to change processPendingMessages() to look more like user32/tests/msg.c's flush_events() function although it looks like it's overkill for now? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
by Frédéric Delanoy Sept. 10, 2011

Sept. 10, 2011

2011/9/9 Eric Pouech <eric.pouech(a)orange.fr>: > WineDbg> set ! symbol_picker scoped > will do what you want > unfortunately, there's no way to store it as a default command (you can > always use --command or --file on command line to help) Thanks for that quick response! Is there some doc on the internal commands, besides the code? http://www.winehq.org/docs/winedev-guide/dbg-config may be a bit out of date Frédéric

2 1

resource_check_usage Unhandled usage flags 0x8
by Luis C. Busquets Pérez Sept. 9, 2011

Sept. 9, 2011

I do not from which exact version of wine, whenever I run Civilization IV bryond the sword, losts of fixmes appear with the message fixme:d3d:resource_check_usage Unhandled usage flags 0x8. Since those fixmes did not appear before I wonder if this is a bug. I do not understand how it is that the function resource_check_usage uses a flag that before it wasn't, was it? Can anybody clarify the usage of the flag 0x8 and if this is a bug?

2 1

Re: 78632: Subject: po: Update Japanese translation.
by Dan Kegel Sept. 9, 2011

Sept. 9, 2011

Hi Akihiro, your patch does not apply here, perhaps it's slightly out of date? patching file po/ja.po Hunk #22 FAILED at 8231. Hunk #23 succeeded at 8271 (offset 1 line). Hunk #24 succeeded at 8347 with fuzz 2 (offset 1 line). Hunk #25 succeeded at 8540 (offset 1 line). Hunk #26 succeeded at 8549 (offset 1 line). Hunk #27 succeeded at 8566 (offset 1 line). Hunk #28 succeeded at 8581 (offset 1 line). Hunk #29 succeeded at 8647 (offset 1 line). Hunk #30 succeeded at 8791 (offset 1 line). Hunk #31 succeeded at 8888 (offset 1 line). Hunk #32 succeeded at 8912 (offset 1 line). Hunk #33 succeeded at 9004 (offset 1 line). Hunk #34 succeeded at 9045 (offset 1 line). Hunk #35 succeeded at 9872 (offset 1 line). Hunk #36 succeeded at 10329 (offset 1 line). Hunk #37 succeeded at 10490 (offset 1 line). Hunk #38 succeeded at 10733 (offset 1 line). Hunk #39 succeeded at 10758 (offset 1 line). Hunk #40 succeeded at 11246 (offset 1 line). Hunk #41 succeeded at 11260 (offset 1 line). Hunk #42 succeeded at 11381 (offset 1 line). Hunk #43 succeeded at 11415 (offset 1 line). 1 out of 43 hunks FAILED -- saving rejects to file po/ja.po.rej dank(a)pantry:~/wine-git$ git reset --hard origin HEAD is now at cb55d2a crypt32/tests: Remove dead assignment (clang). dank(a)pantry:~/wine-git$ git apply 78632 error: patch failed: po/ja.po:8198 error: po/ja.po: patch does not apply 2011/9/9 <buildbot(a)kegel.com>: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > The Buildbot has detected a failed build on builder runtests-default-x86_64 while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/0 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed git > > > For more info about this message, see http://wiki.winehq.org/BuildBot > > >

1 0

Re: [2/2] dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > + info = HeapAlloc(GetProcessHeap(), 0, req_size); > + > + info->pwszName = (LPWSTR)(info + 1); > + > + if(!pguidServiceProvider) > + { > + lstrcpyW(info->pwszName, dp_providerW); > + info->guid = CLSID_DP8SP_TCPIP; > + } > + else > + { > + lstrcpyW(info->pwszName, dp_adapterW); > + info->guid = adapter_guid; > + } > + > + *pSPInfoBuffer = *info; > + *pcReturned = 1; > + > + HeapFree(GetProcessHeap(), 0, info); This doesn't make sense, you are returning freed data. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14103 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: [1/2] dpnet: return success in IDirectPlay8PeerImpl_Initialize
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14102 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: [PATCH 14/14] vbscript: Added null literal support
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14101 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/14] vbsctipy: Added empty literal support
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14100 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 09/14] vbscript: Added interp_equal implementation
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14098 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/14] vbscript: Added interp_not implementation
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14097 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 01/14] vbscript: Added support for |f a, b, c| call statement
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14094 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

2 1

Re: [PATCH 03/14] vbscript: Added support for parentheses in expressions
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14096 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/14] vbscript: Added parser/compiler support for |option explicit|
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14095 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: winebuild: Create stubs for ARM
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

André Hentschel <nerv(a)dawncrow.de> writes: > this improves the testresults, as some tests expect to get stubs through GetProcAddress but never use them. These tests should be fixed (or the functions implemented), it shouldn't be necessary to generate stubs for Winelib. -- Alexandre Julliard julliard(a)winehq.org

1 0

What is the PulseAudio underrun bug?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 9, 2011

Sept. 9, 2011

Hi, As I see that the PA team is preparing release candidates for 1.0, I wonder whether the Wine team communicated them the issues we face. Browsing open tickets http://pulseaudio.org/report/1 I found nothing obvious. The PA bug, as I face it in Ubuntu Lucid, is not something that happens randomly after N minutes or hours. It is *immediately* detectable. Symptoms: 1. winecfg audio test hangs. But Wine is a complex program, so I wrote a trivial one as follows: - set generic hw_params - prefill snd_pcm_write with e.g. 100ms of data; - start ALSA or use hw_params_set_start_threshold; - print out snd_pcm_state, snd_pcm_avail_update and snd_pcm_delay in a loop. 2. avail_update and avail_delay will freeze approx. at the time underrun would have happened with plug:dmix or plughw:0. In particular, delay will not decrease below < 0. By contrast, dmix or hw would see avail_update grow continuously, far above buffer_size, while delay decreases towards minus infinity -- regardless of whether XRUN state was entered or still RUNNING playing silence. 3. Optionally, XRUN mode is never entered, PA claims to be RUNNING. (XRUN is not a necessity, depending on hw_params_set_silence_*) >From there on, more snd_pcm_write(N frames) will not be heard, and avail_update() and delay() will solely bump to reflect that N frames have been queued, and remain frozen. snd_pcm_reset() won't help. snd_pcm_drain() will surprisingly play the buffered audio. Note that in non-blocking mode, this function will return -11 with "dmix" or "hw" ALSA devices, so here again PA differs from others. It looks like PA's front end (claiming to be running) has lost sync with its backend (which apparently stopped). 4. I don't know why and when, but the damage is not always limited to this one process. Sometimes the PA server will need to be restarted (pactl exit) otherwise no more sound will play for more than a click's time. It obviously corrupted its data structures. Andrew Eikum found out that activating the handle_underrun configuration in the newest alsa plugin package (released 2011-01-31!) allows to work around the bug. However when I read the comment to the patch, http://git.alsa-project.org/?p=alsa-plugins.git;a=commit;h=c20d516e22962012… I've the impression that using handle_underrun is backwards and is *not* the recommended way to use PulseAudio. IOW, PA without handle_underrun is subject to the underrun bug and that is abnormal behaviour. Or was it? Does the brandnew PA RC exhibit sane behaviour? Which is the "need handle_underrun" ticket in PA's bug tracker? http://pulseaudio.org/report/1 Where on Ubuntu's launchpad? What do they now about the issue? Regards, Jörg Höhle

2 1

user32: Avoid drawing the caret out of the window
by Bruno Jesus Sept. 9, 2011

Sept. 9, 2011

Please, ignore this patch. It's overkill to check the bounding box during every caret timer callback. I have found a better approach to this by checking inside SetCaretPos/ShowCaret. That's because the caret doesn't move by itself so it's useless to check everytime. Thanks, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

What is the PulseAudio underrun bug?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 9, 2011

Sept. 9, 2011

Hi again, Something that I still have trouble understanding is: Why did I find out only 2 weeks ago that Ubuntu Lucid is affected? Perhaps because I'm mostly using Intrepid which works better as far as the dreaded Intel Xorg screen flicker, suspend/resume and audio are concerned. Why do the Wine users only observe random drop outs after some time? Why does it look like the new mmdevapi code accentuated the problem (does it?)? Perhaps because most apps use dsound and dsound does efforts to send a continuous stream of data to the audio device, without underruns. Likewise, MCIWAVE/MCIAVI/winmm:PlaySound send data in a tight loop. Perhaps because the current GetPosition in both mmdevapi and winmm is not trustworthy and may cause underruns when a sound ends? Perhaps because "underrun at end" is almost designed into winmm? (unless you end with waveOutReset) Also, there may be more than underruns which is broken in PA. Underruns do not explain why I sometimes need to restart the PA server, as mentioned in my prior point 4. Do underruns really happen on my xGHz machine? On my Ubuntu Lucid system, the dreaded Intel XOrg screen flicker is enough to cause some apps running at that time to lose audio. Moving from one virtual desktop or screen to another may cause paging. That's no proof, but underruns may happen more often than one would like. Apps must robustly handle them. Regards, Jörg Höhle

1 0

Re: winspool.drv: Correct test for Device Capabilities
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14060 Your paranoid android. === WINEBUILD (build) === Can't determine base name

3 2

Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
by Frédéric Delanoy Sept. 9, 2011

Sept. 9, 2011

While debugging with winedbg, I sometimes stumble upon situations like those (especially for widely used names) Many symbols with name 'foo', choose the one you want (<cr> to abort): [1]: 0x1234567 foo in libwhatever.so.1 [2]: Local variable (in a register) of foo => 2 This can be cumbersome, e.g. when you don't want to see foo val in libc.so. Is it somehow possible to auto-select the "local value"? Frédéric

1 0

Re: [2/8] msi/test: Mark some test results as broken.
by Marvin Sept. 9, 2011

Sept. 9, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14087 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6000: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: cmd: GOTO is a no-op and doesn't output anything in interactive mode
by Frédéric Delanoy Sept. 9, 2011

Sept. 9, 2011

2011/9/9 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > programs/cmd/builtins.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > This patch depends on my other non-yet-commited goto patch (Avoid rereading batch file for every call/goto executed) Shouldn't probably have sent it yet. Sorry for the inconvenience. Frédéric

1 0

crypt32: Test/correct CertGetNameString with NULL pvTypePara
by Juan Lang Sept. 8, 2011

Sept. 8, 2011

Fix for bug 23287. --Juan

1 0

[PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 8, 2011

Sept. 8, 2011

Andrew Eikum asked: >It would be nice to have tests for this, >Are these part of the tests you're >planning on submitting after you get the fixes in? That is part of my tests, the latest testbot job is https://testbot.winehq.org/JobDetails.pl?Key=14067 You can see that I still need to compute position estimates based on the high performance timer as Sleep() is not accurate enough. >and a fix for coreaudio if needed. Likewise for patch 2/2. The Mac never returns S_FALSE, so there was nothing to change. I've yet another patch about IsFormatSupported in my queue, but it needs more testing. For instance, I've not yet tested inconsistent formats (bad blockalign) or non PCM formats (e.g. A-law, ADPCM). In short, it looks like IsFormatSupported simply suggests GetMixFormat() in shared mode, but would it suggest linear PCM when given A-law? Regards, Jörg Höhle

1 0

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Octavian Voicu Sept. 8, 2011

Sept. 8, 2011

--- a/dlls/winealsa.drv/mmdevdrv.c+++ b/dlls/winealsa.drv/mmdevdrv.c> @@ -1310,17 +1313,14 @@ exit: > LeaveCriticalSection(&This->lock); > HeapFree(GetProcessHeap(), 0, formats); > > - if(hr == S_OK || !out){ > - CoTaskMemFree(closest); > - if(out) > - *out = NULL; > - }else if(closest){ > + if(hr == S_FALSE && out) { > closest->nBlockAlign = > closest->nChannels * closest->wBitsPerSample / 8; > closest->nAvgBytesPerSec = > closest->nBlockAlign * closest->nSamplesPerSec; > *out = closest; > - } > + } else > + CoTaskMemFree(closest); You are dereferencing 'closest' without checking if it's non-NULL. It can be NULL if control jumps to the 'exit' label for several cases. This only applies to winealsa; for wineoss there are no gotos. Octavian

1 1

gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.
by Francois Gouget Sept. 8, 2011

Sept. 8, 2011

In Wine, accept their fallbacks if the native fonts are not installed. --- This is an alternative patch which is more strict as it only allows the hardcoded fallbacks, and only if running in Wine. diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c index 323461a..9c261d9 100644 --- a/dlls/gdiplus/tests/font.c +++ b/dlls/gdiplus/tests/font.c @@ -34,6 +34,7 @@ static const WCHAR MicrosoftSansSerif[] = {'M','i','c','r','o','s','o','f','t',' static const WCHAR TimesNewRoman[] = {'T','i','m','e','s',' ','N','e','w',' ','R','o','m','a','n','\0'}; static const WCHAR CourierNew[] = {'C','o','u','r','i','e','r',' ','N','e','w','\0'}; static const WCHAR Tahoma[] = {'T','a','h','o','m','a',0}; +static const WCHAR LiberationSerif[] = {'L','i','b','e','r','a','t','i','o','n',' ','S','e','r','i','f',0}; static void test_createfont(void) { @@ -289,42 +290,52 @@ static void test_getgenerics (void) GpStatus stat; GpFontFamily* family; WCHAR familyName[LF_FACESIZE]; + int has_native; ZeroMemory(familyName, sizeof(familyName)/sizeof(WCHAR)); + stat = GdipCreateFontFamilyFromName(MicrosoftSansSerif, NULL, &family); + has_native = (stat != FontFamilyNotFound); + if (!has_native) + skip("Microsoft Sans Serif is missing\n"); stat = GdipGetGenericFontFamilySansSerif (&family); - if (stat == FontFamilyNotFound) + expect (Ok, stat); + if (stat != FontFamilyNotFound) { - skip("Microsoft Sans Serif not installed\n"); - goto serif; + stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); + expect (Ok, stat); + /* Wine uses Tahoma as a fallback if Microsoft Sans Serif is missing */ + ok (lstrcmpiW(familyName, MicrosoftSansSerif) == 0 || + (strcmp(winetest_platform, "wine") == 0 && !has_native && + lstrcmpiW(familyName, Tahoma) == 0), + "Expected Microsoft Sans Serif or a fallback, got %s\n", wine_dbgstr_w(familyName)); + stat = GdipDeleteFontFamily (family); + expect (Ok, stat); } - expect (Ok, stat); - stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); - expect (Ok, stat); - if (!lstrcmpiW(familyName, Tahoma)) - todo_wine ok ((lstrcmpiW(familyName, MicrosoftSansSerif) == 0), - "Expected Microsoft Sans Serif, got Tahoma\n"); - else - ok ((lstrcmpiW(familyName, MicrosoftSansSerif) == 0), - "Expected Microsoft Sans Serif, got %s\n", wine_dbgstr_w(familyName)); - stat = GdipDeleteFontFamily (family); - expect (Ok, stat); -serif: + /* First check that Times New Roman is installed because if not + * Wine substitutes another serif font. + */ + stat = GdipCreateFontFamilyFromName(TimesNewRoman, NULL, &family); + has_native = (stat != FontFamilyNotFound); + if (!has_native) + skip("Times New Roman is missing\n"); stat = GdipGetGenericFontFamilySerif (&family); - if (stat == FontFamilyNotFound) + expect (Ok, stat); + if (stat != FontFamilyNotFound) { - skip("Times New Roman not installed\n"); - goto monospace; + stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); + expect (Ok, stat); + /* Wine uses Liberation Serif as a fallback if Times New Roman + * is missing + */ + ok (lstrcmpiW(familyName, TimesNewRoman) == 0 || + (strcmp(winetest_platform, "wine") == 0 && !has_native && + lstrcmpiW(familyName, LiberationSerif) == 0), + "Expected Times New Roman or a fallback, got %s\n", wine_dbgstr_w(familyName)); + stat = GdipDeleteFontFamily (family); + expect (Ok, stat); } - expect (Ok, stat); - stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); - expect (Ok, stat); - ok (lstrcmpiW(familyName, TimesNewRoman) == 0, - "Expected Times New Roman, got %s\n", wine_dbgstr_w(familyName)); - stat = GdipDeleteFontFamily (family); - expect (Ok, stat); -monospace: stat = GdipGetGenericFontFamilyMonospace (&family); if (stat == FontFamilyNotFound) { -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

1 0

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Andrew Eikum Sept. 8, 2011

Sept. 8, 2011

It would be nice to have tests for this, and a fix for coreaudio if needed. Likewise for patch 2/2. Are these part of the tests you're planning on submitting after you get the fixes in? Andrew On Thu, Sep 08, 2011 at 04:09:37PM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > Wine is currently leaking memory because of this bug. > My tests show that S_FALSE indicates a format suggestion, > otherwise the out pointer is NULL. > I think MSDN says that, but it's not particularly clear. > > Regards, > Jörg Höhle >

1 0

Re: dinput: Remove an unused debug channel.
by Lucas Zawacki Sept. 8, 2011

Sept. 8, 2011

err.. I know there's no debugging going on right now, but I'm planning on submiting a couple more patches to this file and I'll print some debug info then. 2011/9/8 Francois Gouget <fgouget(a)free.fr>: > --- > dlls/dinput/config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/config.c b/dlls/dinput/config.c > index 1c6da6c..aedaa0e 100644 > --- a/dlls/dinput/config.c > +++ b/dlls/dinput/config.c > @@ -16,14 +16,12 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > -#include "wine/debug.h" > #include "wine/unicode.h" > #include "objbase.h" > #include "dinput_private.h" > #include "device_private.h" > #include "resource.h" > > -WINE_DEFAULT_DEBUG_CHANNEL(dinput); > > typedef struct { > int nobjects; > -- > 1.7.5.4 > > > >

1 0

Re: cmd/tests: Add tests for combined CALLs/GOTOs
by Marvin Sept. 8, 2011

Sept. 8, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14056 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: comctl32: Fix the wizard and property sheet dialog styles.
by Marvin Sept. 7, 2011

Sept. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14049 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] msxml3: Register XML Parser interfaces (try 2)
by Nikolay Sivov Sept. 7, 2011

Sept. 7, 2011

On Wed, Sep 7, 2011 at 2:04 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > msxml3: Register XML Parser interfaces > Do you really need this? I think existing coclasses are registered with .idl in /msxml3. Maybe just add new .idl in it?

3 2

Re: ntdll: check for string and stringlength in _wcslwr and _wcsupr
by Octavian Voicu Sept. 7, 2011

Sept. 7, 2011

2011/9/7 André Hentschel <nerv(a)dawncrow.de>: > + if (!str || !*str) return NULL; > return strlwrW( str ); >+ if (!str || !*str) return NULL; > return struprW( str ); It seems strange to return NULL when called with an empty, non-NULL string. Maybe it should be `return str' instead (so it covers both the NULL and empty cases sensibly), though strlwrW/struprW seems to be able to cope with zero-length strings as the NULL char is mapped to NULL. Octavian

1 0

Re: ntdll: check for string and stringlength in _wcslwr and _wcsupr
by Nikolay Sivov Sept. 7, 2011

Sept. 7, 2011

2011/9/7 André Hentschel <nerv(a)dawncrow.de>: > Fixes http://bugs.winehq.org/show_bug.cgi?id=28303 (str="") > --- > dlls/ntdll/wcstring.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/ntdll/wcstring.c b/dlls/ntdll/wcstring.c > index 7f0035d..d75f10e 100644 > --- a/dlls/ntdll/wcstring.c > +++ b/dlls/ntdll/wcstring.c > @@ -47,6 +47,7 @@ INT __cdecl NTDLL__wcsicmp( LPCWSTR str1, LPCWSTR str2 ) > */ > LPWSTR __cdecl NTDLL__wcslwr( LPWSTR str ) > { > + if (!str || !*str) return NULL; > return strlwrW( str ); > } > > @@ -65,6 +66,7 @@ INT __cdecl NTDLL__wcsnicmp( LPCWSTR str1, LPCWSTR str2, INT n ) > */ > LPWSTR __cdecl NTDLL__wcsupr( LPWSTR str ) > { > + if (!str || !*str) return NULL; > return struprW( str ); > } > Please add tests for that.

1 0

Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)
by Nikolay Sivov Sept. 7, 2011

Sept. 7, 2011

On Wed, Sep 7, 2011 at 2:05 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Use a skip if we cannot create the control. > > Changelog: > msxml3: Support creating IXMLParser Interface > > > Best Regards > Alistair Leslie-Hughes > > (not related to patch contents) First time I saw this on a list I thought - god dammit, another parser interface. But looking at methods list it's probably a first candidate to be independent from libxml2 without any loss in functionality or big overhead like XPath or XSL things. We'll see. Is it mentioned as obsolete by any chance? Seems to be a kind of low level parser.

3 3

Re: ntdll: Fix two buffer overflow conditions in RtlDosPathNameToNtPathName_U.
by Vitaliy Margolen Sept. 7, 2011

Sept. 7, 2011

On 09/06/2011 06:23 AM, Octavian Voicu wrote: > First one is an off-by-one error: RtlGetFullPathName_U, on success, returns > the number of bytes written, without counting the terminating NULL. The > allocated size for ntpath->Buffer didn't account for that NULL byte, so > for UNC paths the NULL byte would be overflown. > > Second one is caused by an USHORT overflow in ntpath->MaximumLength. > Calling the function with a path longer than 65535-8 bytes would allocate > a much shorter buffer and lead to a buffer overflow. > > -- > Steps to reproduce second issue are described here: > http://packetstormsecurity.org/files/view/76170/wine-overflow.txt > > Funny fact: Windows had the same USHORT overflow bug: > http://www.securityfocus.com/archive/1/323508 > --- > dlls/ntdll/path.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/dlls/ntdll/path.c b/dlls/ntdll/path.c > index 3207720..6138fa8 100644 > --- a/dlls/ntdll/path.c > +++ b/dlls/ntdll/path.c > @@ -383,8 +383,14 @@ BOOLEAN WINAPI RtlDosPathNameToNtPathName_U(PCWSTR dos_path, > if (!(ptr = RtlAllocateHeap(GetProcessHeap(), 0, sz))) return FALSE; > sz = RtlGetFullPathName_U(dos_path, sz, ptr, file_part); > } > + sz += (1 /* NUL */ + 4 /* unc\ */ + 4 /* \??\ */) * sizeof(WCHAR); > + if (sz> MAXWORD) > + { > + if (ptr != local) RtlFreeHeap(GetProcessHeap(), 0, ptr); > + return FALSE; > + } > > - ntpath->MaximumLength = sz + (4 /* unc\ */ + 4 /* \??\ */) * sizeof(WCHAR); > + ntpath->MaximumLength = sz; > ntpath->Buffer = RtlAllocateHeap(GetProcessHeap(), 0, ntpath->MaximumLength); > if (!ntpath->Buffer) > { The fix is not entirely correct. UNICODE_STRING does not have to have a terminating \0 character. The code should not use str* functions on not zero-terminated strings. Vitaliy

2 2

Re: winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol (resend)
by Alexandre Julliard Sept. 7, 2011

Sept. 7, 2011

Joerg-Cyril.Hoehle(a)t-systems.com writes: > Hi, > > [unmodified & sent alone. There's no apply failure in testbot.] > > With this patch, MacOS will be the first to correctly implement the allowed ordering of Get and ReleaseBuffer according to my rendering tests (see bug #27937). > > [...capture mode] >>I believe that ReleaseBuffer(0) always returns S_OK, like in the render case. > Verified indeed. But I've not finalized capture code yet (I'm not > familiar with capture, so it takes more time). > > Because my patch changes the type of getbuf_last, I had to slightly modify AudioCaptureClient already: > @@ -1781,7 +1797,7 @@ static HRESULT WINAPI AudioCaptureClient_GetBuffer(IAudioCaptureClient *iface, > *flags = 0; > This->written_frames += *frames; > This->inbuf_frames -= *frames; > - This->getbuf_last = TRUE; > + This->getbuf_last = 1; This fake patch fragment in the message confuses git apply. Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] cmd: Remove attrib from builtins list
by Frédéric Delanoy Sept. 7, 2011

Sept. 7, 2011

On Wed, Sep 7, 2011 at 09:09, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > This series remove attrib from the builtins list. Only the brief description in the global help is kept. > An externals list of commands shipped with cmd.exe is created so when the help builtins is called, the > requested help is obtained by invoking the command with the /? option as for native cmd.exe. > --- > programs/cmd/cmd.rc | 1 - > programs/cmd/wcmd.h | 91 +++++++++++++++++++++++------------------------ > programs/cmd/wcmdmain.c | 1 - > 3 files changed, 45 insertions(+), 48 deletions(-) You should probably commit the po changes as well, as is usually done

3 4

Re: [PATCH 2/2] cmd: Launch the command with the /? option for external commands shipped with cmd.exe
by Frédéric Delanoy Sept. 7, 2011

Sept. 7, 2011

On Wed, Sep 7, 2011 at 09:10, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + WCHAR space_slashdot_ask[] = {' ', '/','?','\0'}; space_slash_questionmark would probably be a more appropriate name

1 0

Re: winecfg: Specify a context for the 'Letter' paper size. (try 2)
by Octavian Voicu Sept. 7, 2011

Sept. 7, 2011

On Wed, Sep 7, 2011 at 11:27 AM, Francois Gouget <fgouget(a)free.fr> wrote: > Actually, paper size is the more common term. ... > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc ... > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper size#Letter" While paper size is probably the most commonly used meaning within Wine, it seems pretty obvious to me that in this context "Letter" means "letter of the alphabet", because it refers to the letter that is used for mapping drives in winecfg (A, B, ... Z). Octavian

1 0

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy Sept. 7, 2011

Sept. 7, 2011

"help attrib" from within cmd, and "wine attrib /?" give different results. That should probably be aligned, for better integration, if possible. Frédéric.

2 1

Re: [3/3] msxml3: Support creating IXMLParser Interface
by Marvin Sept. 7, 2011

Sept. 7, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14026 Your paranoid android. === WNT4WSSP6 (32 bit xmlparser) === xmlparser.c:39: Test failed: failed to create IXMLParser

1 0

buildbot status
by Dan Kegel Sept. 7, 2011

Sept. 7, 2011

- stability problems The buildbot cluster is not ready for prime time yet. My ubuntu 11.04-based slaves tend to lock up within a day with either an OOM failure, an X livelock, or something else. So I brought an ubuntu 10.04.3 slave online and moved the buildmaster off onto its own machine; let's see what breaks next. - Slave speed Here is the complete build-and-test time (and the build time alone) for four CPUs: 54 (48) celeron @ 2.80 GHz (headless, so it's not running all tests) 17 (10) E8400 @ 3.00GHz 14 (6) Q9300 @ 2.50GHz 12 (4) i7 920 @ 2.67GHz I will probably stick with slaves that are core 2 duo or better, so patches can get fast feedback.

5 15

Re: winecfg: Specify a context for the 'Letter' paper format.
by André Hentschel Sept. 6, 2011

Sept. 6, 2011

Am 07.09.2011 00:48, schrieb Francois Gouget: > It's likely that letter does not always translate the same way for the paper format and the alphabet characters. > --- > > This is more to provide context for the translator than to avoid > conflicts. > > programs/winecfg/winecfg.rc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/winecfg.rc b/programs/winecfg/winecfg.rc > index 5689e7c..26cf504 100644 > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc > @@ -77,7 +77,7 @@ BEGIN > IDS_DRIVE_LETTERS_EXCEEDED "You cannot add any more drives.\n\nEach drive must have a letter, from A to Z, so you cannot have more than 26." > IDS_SYSTEM_DRIVE_LABEL "System drive" > IDS_CONFIRM_DELETE_C "Are you sure you want to delete drive C?\n\nMost Windows applications expect drive C to exist, and will die messily if it doesn't. If you proceed remember to recreate it!" > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper format#Letter" > IDS_COL_DRIVEMAPPING "Drive Mapping" > IDS_NO_DRIVE_C "You don't have a drive C. This is not so great.\n\nRemember to click 'Add' in the Drives tab to create one!\n" > END Isn't it the wrong context name? #msgctxt#Driveletter# would be better -- Best Regards, André Hentschel

1 0

re: dnsapi: Use internal name_skip function
by Dan Kegel Sept. 6, 2011

Sept. 6, 2011

Hi André, your patch failed to build on an ubuntu 10.04 system here: ccache gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o name.o name.c In file included from ns_parse.c:39: ../../include/winbase.h:1583: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../../include/winbase.h:1584: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [ns_parse.o] Error 1 Inserting #include <stdarg.h> before including winbase.h makes the compiler happy. - Dan ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 6, 2011 at 3:41 PM Subject: Re: 78446: Subject: dnsapi: Use internal name_skip function To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/13 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

2 1

Testbot 64 bit mingw?
by Stefan Dösinger Sept. 6, 2011

Sept. 6, 2011

Hi, The ddrawmodes test has a problem on W7PROX64 when running as a 64 bit binary. The test times out, and debugging showed that it freezes in crash_callbackA, in dlls/ddraw/tests/ddrawmodes.c. The function is supposed to crash, DirectDrawEnumerateA catches the exception and returns DDERR_INVALIDPARAMS. The line in question is: *(volatile char*)0 = 2; I can reproduce the freeze on my local system with the binaries built by the testbot. I cannot reproduce them with my own 64 bit binaries, or with the ones from http://test.winehq.org/builds. Thus I suspect that a problem with mingw is preventing the test from working. The 32 bit build works fine, even on a 64 bit Windows system. The mingw version I'm using on my local system: $ x86_64-pc-linux-gnu-gcc --version x86_64-pc-linux-gnu-gcc (Gentoo 4.5.2 p1.1, pie-0.4.5) 4.5.2 Stefan

1 0