September 2011 - Wine-Devel

Re: [1/2] shell32/tests: Fix path comparison
by Marvin Sept. 6, 2011

Sept. 6, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14016 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:193: Test failed: WaitForSingleObject(hProcess) returned 258

1 0

Re: [2/2] shdoclc & user32 & wineconsole & wordpad: Specify a message context for cut and paste
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > MENUITEM "Select &All", IDM_SELECTALL > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE > MENUITEM SEPARATOR > MENUITEM "Create Shor&tcut", IDM_CREATESHORTCUT > MENUITEM "Add to &Favorites...", IDM_ADDFAVORITES > @@ -73,10 +73,10 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as Back&ground", IDM_SETWALLPAPER > MENUITEM "Set as &Desktop Item...", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > - MENUITEM "Cu&t", IDM_CUT > + MENUITEM "#msgctxt#Shell#Cu&t", IDM_CUT > MENUITEM "&Copy", IDM_COPY > MENUITEM "Copy Shor&tcut", IDM_COPYSHORTCUT > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE That's not a very useful context. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy Sept. 6, 2011

Sept. 6, 2011

On Tue, Sep 6, 2011 at 09:35, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > It's just a resend. The patch is unmodified, just rebased on latest git. > > try4: > - add missing NULL ending character to help_option string > > try3: > - fix /? option. This fixes cmd tests regression > > try2: > - keep attrib infos for help command > - update po files > > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. I've got test failures with your patch ("make test" in programs/cmd/tests) First error: batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591 (got 'r.test not found before delete, bad', wanted 'r.test found before delete, good') Also, beware that testbot won't test your patch on windowses since it doesn't change any file in tests/ directory (you might want to submit it manually with, say, a small change in test_builtins.cmd and/or test_builtins.exp) See http://wiki.winehq.org/CmdConformanceTests (recently written) if you need help with the keywords, etc. Frédéric

2 2

Fwd: [ANNOUNCE] Git User's Survey 2011
by Andrew Eikum Sept. 6, 2011

Sept. 6, 2011

It's that time of year again. I thought I'd forward this on to wine-devel since we're all Git users here. ----- Forwarded message from Jakub Narebski <jnareb(a)gmail.com> ----- Date: Mon, 5 Sep 2011 02:43:20 +0200 From: Jakub Narebski <jnareb(a)gmail.com> To: git(a)vger.kernel.org Subject: [ANNOUNCE] Git User's Survey 2011 User-Agent: KMail/1.9.3 Hello all, We would like to ask you a few questions about your use of the Git version control system. This survey is mainly to understand who is using Git, how and why. The results will be published to the Git wiki on the GitSurvey2011 page (https://git.wiki.kernel.org/index.php/GitSurvey2011) and discussed on the git mailing list. The survey would be open from 5 September till 3 October 2011. Please devote a few minutes of your time to fill this simple questionnaire, it will help a lot the git community to understand your needs, what you like of Git, and of course what you don't like of it. The survey can be found here: http://tinyurl.com/GitSurvey2011 https://www.survs.com/survey/VCAGZA8CT5 There is also alternate version which does not require cookies, but it doesn't allow one to go back to response and edit it. https://www.survs.com/survey/MRRGT8OEFV P.S. At request I can open a separate channel in survey, with a separate survey URL, so that responses from particular site or organization could be separated out. Please send me a email with name of channel, and I will return with a separate survey URL to use. -- Git Development Community -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----- End forwarded message -----

1 0

script to run all good tests / all flaky tests / etc.
by Dan Kegel Sept. 6, 2011

Sept. 6, 2011

The buildbot does three things to get fast, reliable test runs: - it runs a 'safe' set of tests in the background, without DISPLAY set, in a different wineprefix; this saves three minutes - it has a blacklist of known flaky or broken tests, listing how it's broken and linking to the bug report - it kills wineserver after the run (since some tests leave processes around) I hoisted these out of the buildbot config and into a separate script, http://code.google.com/p/winezeug/source/browse/trunk/buildbot/dotests.sh As a bonus, you can ask it to run all the flaky tests instead of all the good ones, which might be useful if you're trolling for test bugs to fix. Here's the current blacklist from that script: # Blacklist format # test condition [bug] # Tests may appear multiple times in the list. # Supported conditions: # FLAKY - fails sometimes # CRASHY - crashes sometimes # SYS - always fails on some systems, not on others # HEAP - fails or crashes if warn+heap # NOTTY - test fails if output redirected # BAD64 - always fails on 64 bits cat > /tmp/blacklist.txt <<_EOF_ dlls/kernel32/tests/heap.ok HEAP dlls/dsound/tests/ds3d8.ok SYS 8668 dlls/dsound/tests/ds3d.ok SYS 8668 dlls/dsound/tests/dsound8.ok SYS 8668 dlls/dsound/tests/dsound.ok SYS 8668 dlls/user32/tests/input.ok SYS 12053 dlls/user32/tests/msg.ok SYS 12053 dlls/user32/tests/win.ok SYS 12053 dlls/oleaut32/tests/tmarshal.ok BAD64 26768 dlls/ieframe/tests/ie.ok BAD64 26768 dlls/ws2_32/tests/sock.ok CRASHY 28012 dlls/wininet/tests/urlcache.ok FLAKY 28038 dlls/winmm/tests/wave.ok SYS 28048 dlls/winmm/tests/mci.ok SYS 28071 dlls/urlmon/tests/url.ok FLAKY 28108 dlls/winmm/tests/capture.ok SYS 28109 dlls/shell32/tests/shlfolder.ok SYS 28216 dlls/kernel32/tests/process.ok NOTTY 28220 dlls/d3dx9_36/tests/shader.ok HEAP 28255 dlls/kernel32/tests/pipe.ok HEAP 28257 programs/cmd/tests/batch.ok HEAP 28258 dlls/dsound/tests/ds3d8.ok HEAP 28260 dlls/dsound/tests/ds3d.ok HEAP 28260 dlls/mshtml/tests/style.ok HEAP 28262 dlls/winhttp/tests/winhttp.ok SYS 28267 programs/wscript/tests/run.ok BAD64 28285 dlls/msctf/tests/inputprocessor.ok FLAKY 28288 _EOF_

2 2

Re: uxtheme: Return error on invalid parameters
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > uxtheme: Return error on invalid parameters Get/SetPropW already check the handle, don't add redundant checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros. (try 2)
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -59,57 +59,87 @@ typedef BOOL (CALLBACK *LPFNADDPROPSHEETPAGES)(LPVOID, LPFNADDPROPSHEETPAGE, LPA > /* > * Property sheet support (structures) > */ > +#ifndef _WIN32 > +typedef const VOID* PROPSHEETPAGE_RESOURCE; > +#elif defined(UNICODE) > +typedef LPCDLGTEMPLATEW PROPSHEETPAGE_RESOURCE; > +#else > +typedef LPCDLGTEMPLATEA PROPSHEETPAGE_RESOURCE; > +#endif That one should be disallowed too. And testing _WIN32 isn't useful in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [The Official Wine Wiki] Update of "ConformanceTests"
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 6, 2011

Sept. 6, 2011

François Gouget asked: >> + * Depending on OSX settings, the firewall will ask whether to >> allow incoming network access for tests involving server sockets. >Does it cause test failures? Sorry, I've not tracked it down. Either I click "agree" fast enough (they occur towards the end of the ~20 minutes winetest.exe run) and the tests proceed, or presumably the test exe is killed after a timeout. I tend to "babysit" test execution for that reason (and because I only went online for the purpose of test execution, bug #20219). >Does one have to disable the firewall? I configured the Mac too long ago to remember. Presumably it's a matter of restrictive configuration, otherwise other users would have raised the topic already. Regards, Jörg Höhle

1 0

Re: [2/2] ntdll: Allow reading from a VPROT_WRITECOPY protected memory
by Dmitry Timoshkov Sept. 6, 2011

Sept. 6, 2011

André Hentschel wrote: > As per tests in kernel32:loader it seems linux&co allows reads on PROT_WRITE areas, but solaris doesn't and crashes. > This fixes this issue. > - if (vprot & VPROT_WRITECOPY) prot |= PROT_WRITE; > + if (vprot & VPROT_WRITECOPY) prot |= PROT_READ | PROT_WRITE; Do you mean that the recently added test for resource section access mapping crashes on Solaris? If yes, then the fix should be done in different place. -- Dmitry.

2 3

Re: comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros.
by Alexandre Julliard Sept. 6, 2011

Sept. 6, 2011

Francois Gouget <fgouget(a)free.fr> writes: > @@ -213,6 +247,27 @@ DECL_WINELIB_TYPE_AW(PROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPCPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPFNPSPCALLBACK) > +#ifdef UNICODE > +typedef PROPSHEETPAGEW_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEW_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEW_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEW_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEW_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEW_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEW_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERW_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERW_V2_SIZE > +#else > +typedef PROPSHEETPAGEA_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEA_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEA_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEA_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEA_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEA_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEA_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERA_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERA_V2_SIZE > +#endif Please use the appropriate Winelib macros to define A/W mappings. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: Property sheets must be able to redraw themselves even if no page is selected.
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13992 Your paranoid android. === WVISTAADM (32 bit propsheet) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Undocumented registry settings
by Vitaliy Margolen Sept. 5, 2011

Sept. 5, 2011

Henri, Would you mind documenting recently added registry entries to wined3d on Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find description of "AlwaysOffscreen". Vitaliy.

2 2

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)
by Henri Verbeet Sept. 5, 2011

Sept. 5, 2011

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + keys = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(WCHAR*)); > + vals = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(LARGE_INTEGER)); ... > + keys = HeapReAlloc(GetProcessHeap(), 0, keys, > + capacity * sizeof(WCHAR*)); > + vals = HeapReAlloc(GetProcessHeap(), 0, vals, > + capacity * sizeof(LARGE_INTEGER)); Memory allocations can fail. You also never free these, but I suppose that happens implicitly on process termination.

2 1

Re: msxml3: Correct MSXML Object Safety tests (try 2)
by Alexandre Julliard Sept. 5, 2011

Sept. 5, 2011

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Add the enabled test as well. > > Changelog: > msxml3: Correct Object Safety tests It doesn't work here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok domdoc.c:4706: Test failed: expected INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA got 2 domdoc.c:7532: Test failed: expected INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA got 2 make[1]: *** [domdoc.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32/tests: Test for correct storage creation.
by Vincent Povirk Sept. 5, 2011

Sept. 5, 2011

You might just want to try reopening the file and checking its CLSID, instead of directly checking the contents. That should make it more obvious that something is seriously wrong. With the direct checks, it's hard to figure out what the test actually means. Anyway, this should be easy to fix. We just need to keep track of whether the file has ever had a header, instead of assuming the header is valid if the file is large enough to have one.

1 0

Re: [1/2] programs: Add a stub implementation of regasm.exe.
by Vincent Povirk Sept. 5, 2011

Sept. 5, 2011

On Windows, this is a .NET assembly. We should probably do it the same way.

1 0

Re: [dsound] InstanceId holds a pointer, so it needs to be as wide as a pointer.
by Michael Stefaniuc Sept. 5, 2011

Sept. 5, 2011

Hello Dan, Dan Kegel wrote: > Not that we do anything with it... still the correct fix would be to rewrite the driver to use a more modern header version than DirectX 5. I guess that's part of Andrew's dsound rewrite. bye michael

1 0

re: configure.ac: add -Werror to default compiler options
by Dan Kegel Sept. 5, 2011

Sept. 5, 2011

(Reviving http://www.winehq.org/pipermail/wine-devel/2008-September/069266.html ) After http://www.winehq.org/pipermail/wine-patches/2011-August/106150.html and http://www.winehq.org/pipermail/wine-patches/2011-August/106151.html, configuring with -Wall -Werror gives the right results, judging by a quick diff of config.h and config.status. (sys/asoundlib.h is not detected, but that's ok, it's marked as obsolete, and wine uses alsa/asoundlib.h instead.) This takes care of Maarten's concerns from the earlier thread. Then building yields only a tiny handful of errors: dllfunc.c: In function ‘AMovieDllRegisterServer2’: dllfunc.c:180: warning: dereferencing type-punned pointer will break strict-aliasing rules qualitycontrol.c: In function ‘QualityControlImpl_Notify’: qualitycontrol.c:70: warning: dereferencing type-punned pointer will break strict-aliasing rules transform.c: In function ‘TransformFilterImpl_QueryInterface’: transform.c:248: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../include/winternl.h: In function ‘get_vm86_teb_info’: ../../include/winternl.h:2660: warning: dereferencing type-punned pointer will break strict-aliasing rules ... register.c: In function ‘create_registrar’: register.c:66: warning: dereferencing type-punned pointer will break strict-aliasing rules Those are potential, if unlikely, bugs; we ought to either fix them or add -fno-strict-aliasing to CFLAGS for the seven or so affected .c files. At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. - Dan

7 9

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc
by Jacek Caban Sept. 5, 2011

Sept. 5, 2011

Hi Thomas, AFAICS secur_url wasn't allocated with CoTaskMemAlloc until this patch. Why are you changing it? Jacek

2 1

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)
by Eric Pouech Sept. 5, 2011

Sept. 5, 2011

this won't work if a .bat file calls another .bat file the cache must be stored inside the context structure... A+ -- Eric Pouech

1 0

Re: [1/5] ddraw: Add some NULL pointer tests
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13949 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

2 1

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().
by Stefan Dösinger Sept. 5, 2011

Sept. 5, 2011

On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: > These are no longer needed since present can handle these now. I think we can remove the entire special case and just do a blit. This hack is related to the ddraw windowed backbuffer hack you removed a while ago, except that the back->front blit is used by a handful of fullscreen apps too.

2 3

Re: [2/4] msi/tests: Fix a number of test messages.
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13969 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [2/3] winhttp/tests: Initialize a variant with a known value.
by Marvin Sept. 5, 2011

Sept. 5, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13968 Your paranoid android. === W7PRO (32 bit winhttp) === winhttp.c:1971: Test failed: failed to send request 12152 winhttp.c:1977: Test failed: got 12019

1 0

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)
by Octavian Voicu Sept. 5, 2011

Sept. 5, 2011

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + static WCHAR string[MAX_PATH]; Why make this static? It's only a temporary buffer and it's only used once, when building the cache. Octavian

2 1

Re: cmd: Avoid unneeded local variable in WCMD_goto
by Frédéric Delanoy Sept. 4, 2011

Sept. 4, 2011

2011/9/4 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > programs/cmd/builtins.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) Please ignore this patch. The changes it brings are incorporated in another patch ("cmd: Avoid rereading batch file for every call/goto executed") Frédéric

1 0

WINEDEBUG=warn+heap make test crashes in dsound?
by Dan Kegel Sept. 4, 2011

Sept. 4, 2011

Hi Michael, is this up your alley? You've been looking at dsound recently, iirc. - Dan export WINEDEBUG=warn+heap ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so ds3d.c && touch ds3d.ok ALSA lib pcm_pulse.c:1008:(_snd_pcm_pulse_open) Unknown field handle_underrun ... ds3d.c:467: Test failed: buffer size changed after SetFormat() - previous size was 88200, current size is 22052 fixme:dsound3d:IDirectSound3DListenerImpl_QueryInterface Unknown IID {31efac30-515c-11d0-a9aa-00aa0061be93} wine: Unhandled page fault on read access to 0xfeef021a at address 0x68d6775f (thread 002c), starting debugger... Backtrace: =>0 0x68d6775f IDirectSound3DListenerImpl_Release+0xe9(iface=0x1d5170) [/home/dank/wine-git/dlls/dsound/sound3d.c:791] in dsound (0x0033f768) 1 0x684bce32 test_primary_3d_with_listener+0x677(lpGuid=(nil)) [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1228] in dsound_test (0x0033f868) 2 0x684bd181 dsenum_callback+0x183(lpGuid=(nil), lpcstrDescription="Primary Sound Driver", lpcstrModule="", lpContext=0x0(nil)) [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1283] in dsound_test (0x0033f8a8) 3 0x68d558e4 a_to_w_callback+0xe0(guid=(nil), descW="Primary Sound Driver", modW="", data=0x33fc80) [/home/dank/wine-git/dlls/dsound/dsound_main.c:291] in dsound (0x0033f938) 4 0x68d55c3b DirectSoundEnumerateW+0x2ab(lpDSEnumCallback=0x68d55803, lpContext=0x33fc80) [/home/dank/wine-git/dlls/dsound/dsound_main.c:370] in dsound (0x0033fc68) 5 0x68d55985 DirectSoundEnumerateA+0x88(lpDSEnumCallback=0x684bcffd, lpContext=0x0(nil)) [/home/dank/wine-git/dlls/dsound/dsound_main.c:321] in dsound (0x0033fc98) 6 0x684bd50d ds3d_tests+0x2a() [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1307] in dsound_test (0x0033fcc8) 7 0x684bd5cd func_ds3d+0x7b() [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1326] in dsound_test (0x0033fcf8) 8 0x684d04d3 run_test+0x9e(name="ds3d.c") [/home/dank/wine-git/dlls/dsound/tests/../../../include/wine/test.h:556] in dsound_test (0x0033fd58)

2 1

RFC - The ProductName registry entry
by Bruno Jesus Sept. 4, 2011

Sept. 4, 2011

Louis Lenders sent the following url patch to fix bug #28065, it was rejected because it fixes the product name so even if you set other version inside winecfg the registry entry will still say "Windows XP". http://www.winehq.org/pipermail/wine-patches/2011-August/105414.html I have made a small change to winecfg to make it save the correct ProductName based on the selected OS and would like comments. If I ever send my patch to git Louis Lenders patch will need to get in too because we would need a default ProductName setting in registry and his patch was correct because the default wine OS is XP, am I right? The patch is quite simple and it tries to never let 2 ProductName exist in different windows versions. Thanks in advance, Bruno

1 0

bug in OLEPictureImpl_Load (and possibly other stream readers)
by Michael Blumenkrantz Sept. 4, 2011

Sept. 4, 2011

Hi, I have been working with Bernhard Loos (jhgf) for the past couple days to track down the source of http://bugs.winehq.org/show_bug.cgi?id=28235, and today I am happy to report that I have finally located it!. Attached are two files: olefail.cpp - the source olefail.txt - actually olefail.exe renamed to evade mailing list filters :) This is a tiny demo app, most of which is copied right out of MSDN, which showcases the problem. To break it down: *On Windows, OLEPictureImpl_Load will read exactly 2 bytes for the header to attempt to determine the length in the case that the stat() member function of the stream interface is broken. This is acknowledged in a large block comment at olepicture.c:1339. Wine then ignores this fact and reads 8 bytes. This is just the tip of the bug, however! *The major bug is that after this, at olepicture.c:1412, wine decides to attempt to read a buffer of unknown size and content UNTIL THE END OF THE BUFFER. While this may work for reading a string, when reading a binary buffer you MUST know the size. I'm sure we all know this :) *Unless the stream reader interface is fairly smart at this point and returns 0 bytes read (which seems unlikely if the stat() mechanism is broken), wine is guaranteed to crash. The solution here is to remove the broken "try until you die" method of attempting to read more than 2 bytes of the unknown buffer. Instead, simply return an error as Windows does and move on.

1 0

Re: [PATCH 1/2] d3dx9: Do not allocate ctab memory, reuse the shader blob.
by Rico Schüller Sept. 3, 2011

Sept. 3, 2011

Please do not apply, it breaks some else which doesn't have a test, yet. Am 03.09.2011 09:32, schrieb Rico Schüller: > --- > dlls/d3dx9_36/shader.c | 11 +--------- > dlls/d3dx9_36/tests/shader.c | 43 > ++++++++++++++++++++++++++++++++--------- > 2 files changed, 34 insertions(+), 20 deletions(-) > > > >

1 0

Re: [PATCH 1/2] d3dx9: Do not allocate ctab memory, reuse the shader blob.
by Marvin Sept. 3, 2011

Sept. 3, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13934 Your paranoid android. === WVISTAADM (32 bit shader) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

[patch] Fake display interface
by Jari Vetoniemi Sept. 2, 2011

Sept. 2, 2011

Hello, I personally hate when applications decide to change my screen resolution without asking me, or some applications just won't run inside window. So I did fake display interface for the winex11.drv. It allows you to send any display resolution and frequency to the application, but it does not change resolution. It's small and simple patch, and won't probably ever be included into the mainline wine. However I'll post it here as it might be useful for some. To enable, create string key UseFakeDisp with value Y in H_C_U/Software/Wine/X11 Driver Default fake resolution is 800x600 60HZ, you can change default with registry keys FakeDispHeight, FakeDispWidth, FakeDispFreq You can also use env variable WINE_FAKEDISP=WIDTHxHEIGHT_FREQ (eg. WINE_FAKEDISP=1024x768_60) Might improve it later to use the same syntax for default resolution and allow multiple fake resolutions to be defined with ; separator. This is also useful for dual head setups where you may want to run game or application fullscreen on other monitor while still keeping the other alive. There is also interesting side effect: While some applications throw error or won't run on resolutions they don't support, some applications that don't support them still run with the resolution specified. Eg. I can run Ys games with 1440x900 resolution where they normally would not run, and they look great. Cheers.

2 1

Re: [PATCH] server: if a debugger is attached to a process, the DEBUG_ONLY_THIS_PROCESS should get set
by Alexandre Julliard Sept. 2, 2011

Sept. 2, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -825,6 +825,9 @@ int set_process_debug_flag( struct process *process, int flag ) > { > char data = (flag != 0); > > + process->create_flags = (process->create_flags & ~(DEBUG_PROCESS | DEBUG_ONLY_THIS_PROCESS)) > + | flag; > + I don't think this belongs in set_process_debug_flag, that's a different flag. Also I don't see what DEBUG_PROCESS is here for. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/201 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

3 3

re: po: Fix some typography issues in the Czech translation.
by Dan Kegel Sept. 2, 2011

Sept. 2, 2011

This patch found a bug in my scripts - it failed to grep the patch for sender and subject - but it looks like there might be something wrong with the patch itself, it doesn't apply here. Buildbot said: Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git and here's what I get when I do it by hand: $ wget http://source.winehq.org/patches/data/78249 $ git apply 78249 typocz.patch:31: trailing whitespace. msgstr "Ověřte prosím, že název souboru byl zadán správně" typocz.patch:40: trailing whitespace. "Chcete ho vytvořit?" typocz.patch:49: trailing whitespace. "Chcete ho přepsat novým?" typocz.patch:54: trailing whitespace. msgstr "Nedovolený(é) znak(y) v cestě k souboru" typocz.patch:63: trailing whitespace. "Chcete ho přepsat novým?" error: patch failed: po/cs.po:210 error: po/cs.po: patch does not apply

3 4

Re: 78262: Subject: [2/6] dinput: Added enumerated devices to ConfigureDevices dialog (try 3)
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/208 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

3 2

Re: regedit: Remove the printing code
by Frédéric Delanoy Sept. 2, 2011

Sept. 2, 2011

2011/9/1 André Hentschel <nerv(a)dawncrow.de>: > It does nothing (except confusing) > beside that i doubt someone wants to print registry hives That's not a reason IMHO. What should be done is fix the printing so it works like on windows (or put an error box: "not yet implemented", or similar)

1 0

Re: [PATCH 10/10] mshtml: Added more IHTMLElement_{put, get}_onclick tests
by Marvin Sept. 2, 2011

Sept. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13915 Your paranoid android. === W2K3R2SESP2 (32 bit events) === Timeout === W2K8SE (32 bit events) === Timeout

1 0

Re: [PATCH 6/6] jscript/tests: Added decodeURI tests
by Marvin Sept. 2, 2011

Sept. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13910 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/6] jscript: Throw exception on error in JSGlobal_encodeURIComponent
by Marvin Sept. 2, 2011

Sept. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13909 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)
by Marvin Sept. 2, 2011

Sept. 2, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13889 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead

4 4

Re: regedit: Remove the printing code
by Jerome Leclanche Sept. 2, 2011

Sept. 2, 2011

To be fair, that feature is available on Windows. 2011/9/1 André Hentschel <nerv(a)dawncrow.de>: > It does nothing (except confusing) > beside that i doubt someone wants to print registry hives > > --- > programs/regedit/En.rc | 1 - > programs/regedit/framewnd.c | 77 ------------------------------------------- > programs/regedit/regedit.rc | 3 -- > programs/regedit/resource.h | 3 -- > 4 files changed, 0 insertions(+), 84 deletions(-) > > diff --git a/programs/regedit/En.rc b/programs/regedit/En.rc > index 35411d2..512f528 100644 > --- a/programs/regedit/En.rc > +++ b/programs/regedit/En.rc > @@ -162,7 +162,6 @@ END > IDC_REGEDIT ACCELERATORS > { > "^F", ID_EDIT_FIND > - "^P", ID_REGISTRY_PRINT > VK_DELETE, ID_EDIT_DELETE, VIRTKEY > VK_F1, ID_HELP_HELPTOPICS, VIRTKEY > VK_F2, ID_EDIT_RENAME, VIRTKEY > diff --git a/programs/regedit/framewnd.c b/programs/regedit/framewnd.c > index 0cdedec..0f8b485 100644 > --- a/programs/regedit/framewnd.c > +++ b/programs/regedit/framewnd.c > @@ -392,71 +392,6 @@ static BOOL ExportRegistryFile(HWND hWnd) > return TRUE; > } > > -static BOOL PrintRegistryHive(HWND hWnd, LPCWSTR path) > -{ > -#if 1 > - PRINTDLGW pd; > - > - ZeroMemory(&pd, sizeof(PRINTDLGW)); > - pd.lStructSize = sizeof(PRINTDLGW); > - pd.hwndOwner = hWnd; > - pd.hDevMode = NULL; /* Don't forget to free or store hDevMode*/ > - pd.hDevNames = NULL; /* Don't forget to free or store hDevNames*/ > - pd.Flags = PD_USEDEVMODECOPIESANDCOLLATE | PD_RETURNDC; > - pd.nCopies = 1; > - pd.nFromPage = 0xFFFF; > - pd.nToPage = 0xFFFF; > - pd.nMinPage = 1; > - pd.nMaxPage = 0xFFFF; > - if (PrintDlgW(&pd)) { > - /* GDI calls to render output. */ > - DeleteDC(pd.hDC); /* Delete DC when done.*/ > - } > -#else > - HRESULT hResult; > - PRINTDLGEXW pd; > - > - hResult = PrintDlgExW(&pd); > - if (hResult == S_OK) { > - switch (pd.dwResultAction) { > - case PD_RESULT_APPLY: > - /*The user clicked the Apply button and later clicked the Cancel button. This indicates that the user wants to apply the changes made in the property sheet, but does not yet want to print. The PRINTDLGEX structure contains the information specified by the user at the time the Apply button was clicked. */ > - break; > - case PD_RESULT_CANCEL: > - /*The user clicked the Cancel button. The information in the PRINTDLGEX structure is unchanged. */ > - break; > - case PD_RESULT_PRINT: > - /*The user clicked the Print button. The PRINTDLGEX structure contains the information specified by the user. */ > - break; > - default: > - break; > - } > - } else { > - switch (hResult) { > - case E_OUTOFMEMORY: > - /*Insufficient memory. */ > - break; > - case E_INVALIDARG: > - /* One or more arguments are invalid. */ > - break; > - case E_POINTER: > - /*Invalid pointer. */ > - break; > - case E_HANDLE: > - /*Invalid handle. */ > - break; > - case E_FAIL: > - /*Unspecified error. */ > - break; > - default: > - break; > - } > - return FALSE; > - } > -#endif > - return TRUE; > -} > - > static BOOL CopyKeyName(HWND hWnd, LPCWSTR keyName) > { > BOOL result; > @@ -677,12 +612,6 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) > case ID_REGISTRY_EXPORTREGISTRYFILE: > ExportRegistryFile(hWnd); > break; > - case ID_REGISTRY_PRINT: > - { > - const WCHAR empty = 0; > - PrintRegistryHive(hWnd, &empty); > - break; > - } > case ID_EDIT_DELETE: > { > HWND hWndDelete = GetFocus(); > @@ -831,12 +760,6 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) > HeapFree(GetProcessHeap(), 0, keyPath); > } > break; > - case ID_REGISTRY_PRINTERSETUP: > - /*PRINTDLG pd;*/ > - /*PrintDlg(&pd);*/ > - /*PAGESETUPDLG psd;*/ > - /*PageSetupDlg(&psd);*/ > - break; > case ID_REGISTRY_OPENLOCAL: > break; > case ID_REGISTRY_EXIT: > diff --git a/programs/regedit/regedit.rc b/programs/regedit/regedit.rc > index 8d3b333..a5a1ad3 100644 > --- a/programs/regedit/regedit.rc > +++ b/programs/regedit/regedit.rc > @@ -33,8 +33,6 @@ BEGIN > MENUITEM "&Import Registry File...", ID_REGISTRY_IMPORTREGISTRYFILE > MENUITEM "&Export Registry File...", ID_REGISTRY_EXPORTREGISTRYFILE > MENUITEM SEPARATOR > - MENUITEM "&Print...\tCtrl+P", ID_REGISTRY_PRINT > - MENUITEM SEPARATOR > MENUITEM "E&xit", ID_REGISTRY_EXIT > END > POPUP "&Edit" > @@ -150,7 +148,6 @@ BEGIN > ID_REGISTRY_IMPORTREGISTRYFILE "Imports a text file into the registry" > ID_REGISTRY_EXPORTREGISTRYFILE > "Exports all or part of the registry to a text file" > - ID_REGISTRY_PRINT "Prints all or part of the registry" > /* ID_HELP_HELPTOPICS "Opens registry editor help" */ > ID_HELP_ABOUT "Displays program information, version number and copyright" > END > diff --git a/programs/regedit/resource.h b/programs/regedit/resource.h > index 020765e..1d5934e 100644 > --- a/programs/regedit/resource.h > +++ b/programs/regedit/resource.h > @@ -77,7 +77,6 @@ > #define ID_EDIT_NEW_DWORDVALUE 32788 > #define ID_REGISTRY_IMPORTREGISTRYFILE 32789 > #define ID_REGISTRY_EXPORTREGISTRYFILE 32790 > -#define ID_REGISTRY_PRINT 32793 > #define ID_HELP_HELPTOPICS 32794 > #define ID_HELP_ABOUT 32795 > #define ID_WINDOW_CASCADE 32797 > @@ -113,8 +112,6 @@ > #define ID_REGISTRY_RESTORE 32829 > #define ID_REGISTRY_SAVEKEY 32830 > #define ID_REGISTRY_SELECTCOMPUTER 32831 > -#define ID_REGISTRY_PRINTSUBTREE 32832 > -#define ID_REGISTRY_PRINTERSETUP 32833 > #define ID_REGISTRY_SAVESUBTREEAS 32834 > #define IDS_LICENSE 32835 > #define IDS_ERROR 32836 > -- > > Best Regards, André Hentschel > > >

1 0

Re: kernel32: Fix writing to a pipe in WriteConsoleW().
by Eric Pouech Sept. 2, 2011

Sept. 2, 2011

Le 03/08/2011 18:07, Francois Gouget a écrit : > WriteFile() checks if the handle corresponds to the console and if it > does invokes WriteConsoleA(). This barely escaped an infinite loop but > messed up the string encoding as CP_UNIXCP is usually different from > CP_ACP. > --- > > I noticed this issue while testing the net.exe tool. After making it > use WineConsole() I was getting the following outputs: > > $ wine net stop > Spécifie le service à arrêter. > $ ./wine net stop | cat > Sp├®cifie le service ├á arr├¬ter. > > It turns out that it's because we only get through the WineConsoleW() -> > WriteFile() -> WriteConsoleA() loop in the second case. could you elaborate a bit more. in case of wine ... | cat, the standard output should be a pipe not a console so writeconsoleW is supposed to fail so it would make more sense to simply let WriteConsoleW fail when is_console_handle(hConsoleOutput) is FALSE ? (similar functions as WriteConsoleA, ReadConsoleA/W should be protected the same way) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 4

Re: Separate list for bots
by Dan Kegel Sept. 2, 2011

Sept. 2, 2011

Sorry for the mail storm, I've disabled mail again. (I out running errands all afternoon/evening, or I probably would have done that sooner.) As it happens, there is already a nearly unused mailing list for wine test results; I'll send results there from now on, at least until we work out more of the kinks. http://www.winehq.org/mailman/listinfo/wine-tests-results In this case, Henri had a proposed fix; maybe if Alexandre had committed it, the storm of error messages would have ceased. It's funny; I can't reproduce that crash manually, only through the buildbot. But I do see the tail overwrite clearly with warn+heap; perhaps it's time to add a bot that flags new warn+heap errors. - Dan

1 0

Re: 78291: Subject: urlmon/tests: Print out the wrong mime
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/235 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78287: Subject: po: Update German translation
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/231 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78286: Subject: Polish translation for release 1.3.27
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/230 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78285: Subject: [PATCH] po: Update Japanese translation.
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/229 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78284: Subject: user32: Fix support for CB_SETDROPPEDWIDTH in combobox
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/228 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78283: Subject: [PATCH] po: Update Japanese translation.
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/227 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0