September 2011 - Wine-Devel

Separate list for bots
by Peter Urbanec Sept. 2, 2011

Sept. 2, 2011

wine-devel has been seeing more and more robot generated messages. Would it make sense to create wine-bots list for buildbot, testbot and friends? Automated messages could go to author, wine-bots with Reply-To: and Followup-To: pointing at wine-devel That way wine-devel could be returned to humans again. :-)

2 1

Re: 78278: Subject: [po]updated korean resource
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/223 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78276: Subject: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/219 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78273: Subject: [PATCH 1/5] cmd/tests: add more tests for command line parsing
by buildbot＠kegel.com Sept. 2, 2011

Sept. 2, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/218 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78272: Subject: widl: duplicate type in case of argument with range attribute
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/217 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78271: Subject: rpcrt4:properly unmarshall EMUM16 discriminant
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/216 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78270: Subject: widl: duplicate type in case of argument with range attribute
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/215 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78269: Subject: Polish translation for release 1.3.27
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/214 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78268: Subject: view: Install it inside Wine
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/213 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [1/6] dinput: Added ConfigureDevices dialog (try 3)
by Octavian Voicu Sept. 1, 2011

Sept. 1, 2011

On Thu, Sep 1, 2011 at 9:34 PM, Lucas Fialho Zawacki <lfzawacki(a)gmail.com> wrote: > +STRINGTABLE > +BEGIN > + IDS_ACTIONCOLUMN "Action" > + IDS_OBJECTCOLUMN "Object" > +END I think you should only keep the string table in dinput.rc. The dialog(s) should go in En.rc so they can be localized, like it's done in winecfg [1]. You probably should also add this to both .rc files: LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT Octavian [1] http://source.winehq.org/git/wine.git/tree/HEAD:/programs/winecfg

1 0

Re: 78267: Subject: [6/6] dinput: Working CANCEL and RESET buttons in ConfigureDevices dialog (try 3)
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/212 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: documentation: Remove ChangeLog.*.
by Octavian Voicu Sept. 1, 2011

Sept. 1, 2011

On Wed, Aug 31, 2011 at 3:25 PM, Octavian Voicu wrote: > They are not used anymore. Last change was with the release of wine 1.0. > Sent as attachment because of the huge lines. Alexandre, This patch was sent before I got your reply on wine-devel, so you can ignore it. Probably was in the moderation queue because it is totally huge... Octavian

1 0

Re: 78264: Subject: [5/6] dinput: Added possibility to change the action mapping in the ConfigureDevices dialog (try 3)
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/211 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78265: Subject: [3/6] dinput: Added object/action enumeration to ConfigureDevices dialog (try 3)
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/209 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78261: Subject: [1/6] dinput: Added ConfigureDevices dialog (try 3)
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/207 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78266: Subject: regedit: Remove the printing code
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/206 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78260: Subject: [PATCH 5/5] wined3d: Make the device parameter to wined3d_device_get_clip_plane() const.
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/205 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl
by Marvin Sept. 1, 2011

Sept. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13899 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead

1 0

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
by Marvin Sept. 1, 2011

Sept. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13898 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@

1 0

Re: 78259: Subject: [PATCH 4/5] wined3d: Make the device parameter to wined3d_device_get_light_enable() const.
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/204 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [PATCH 4/5] cmd: fix handling of special characters
by Marvin Sept. 1, 2011

Sept. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13897 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@

1 0

Re: [PATCH 3/5] cmd: improve treatment of quotes in command line
by Marvin Sept. 1, 2011

Sept. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13896 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@

1 0

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by Marvin Sept. 1, 2011

Sept. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13895 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@

1 0

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
by Marvin Sept. 1, 2011

Sept. 1, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13894 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@

1 0

Re: 78258: Subject: [PATCH 3/5] wined3d: Get rid of some redundant else statements in IWineD3DSurfaceImpl_BltOverride().
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/203 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [1/5] ddraw: Simplify Z format parsing a bit, remove ERRs
by Henri Verbeet Sept. 1, 2011

Sept. 1, 2011

On 1 September 2011 11:01, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > case 32: > if(DDPixelFormat->u2.dwStencilBitDepth == 8) > return WINED3DFMT_D24_UNORM_S8_UINT; > - else > + else if (DDPixelFormat->u2.dwStencilBitDepth == 4) > return WINED3DFMT_S4X4_UINT_D24_UNORM; I'm not sure if this is intentional or not, but you fallthrough to the default case here. If that's intentional, a /* Fallthrough */ or similar comment wouldn't hurt. On the other hand, you do explicitly handle it in the no-stencil case.

2 1

Re: [1/7] cmd: Add support for LSS comparison operator in if statements
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > + else if ((s = StrStrIW (p, lssW))) { > + s += 3; > + a = StrToIntW(condition); > + b = StrToIntW(WCMD_parameter (s, 0, NULL)); I don't think you want to use strstr for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix a few pointer cast warnings.
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Jerome Leclanche <adys.wh(a)gmail.com> writes: > From c8a7535beebb152641330d3d1410d17345522867 Mon Sep 17 00:00:00 2001 > From: Jerome Leclanche <adys(a)azura> > Date: Thu, 1 Sep 2011 12:51:26 +0100 > Subject: [PATCH] setupapi: Fix a few pointer cast warnings. That's just hiding the pointer truncation bug. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab
by Dan Kegel Sept. 1, 2011

Sept. 1, 2011

On Wed, Aug 31, 2011 at 1:10 PM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/161 > BUILD FAILED: failed git Something's fishy; looking at http://marc.info/?l=wine-patches&m=131134541100364&w=2 I see that the July 22nd version seems to have interesting strings, but the August 31st version has all question marks when it comes to non-ascii text. What happened between the two? http://source.winehq.org/patches/data/78217, which is where I pulled the patch from, also has the question marks.

2 2

Re: services: Issue a fixme when a service fails to start.
by Octavian Voicu Sept. 1, 2011

Sept. 1, 2011

On Thu, Sep 1, 2011 at 4:02 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > @@ -295,7 +295,8 @@ static void scmdatabase_autostart_services(struct scmdatabase *db) > argv[0] = service->name; > argv[1] = NULL; > err = service_start(service, 1, argv); > - /* FIXME: do something if the service failed to start */ > + if (err != ERROR_SUCCESS) > + WINE_FIXME("do something if the service failed to start %d\n", err); Why not print something more informative? This looks nice and also tells you which service did not start: WINE_FIXME("Auto-start service %s failed to start: %d\n", wine_dbgstr_w(service->name), err); Octavian

1 0

Re: file
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
by Stefan Dösinger Sept. 1, 2011

Sept. 1, 2011

On Tuesday 30 August 2011 20:12:31 Henri Verbeet wrote: > This imlicitly gets rid of the "auto" option as well, since there's no way > to explicitly specify it. This will no doubt cause its share of > regressions, but I prefer actually fixing those bugs to running into the > surface implementation switching code every time I try to fix something in > ddraw. This will break 2D-only apps in situations where OpenGL is not available. It would be a good idea to use SURFACE_GDI automatically in those situations. (I'm not sure if ddraw without GL works at all right now, we have no systems that run the tests with this setup) It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with me, it's not like those apps are working at the moment, and I guess the switching breaks more than it fixes.

2 3

winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol.
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 1, 2011

Sept. 1, 2011

Hi, I've one idea left about what may have caused the 2 apply failures. The patches are in my git queue just above wine-1.3.27 and the unrelated Valgrind hacks, so in theory, they should work. However the patches depend on each other, but since I reused the subject line of patches originally submitted with several days spacing between them, I forgot to add [PATCH 1/N] this week. The order is: 0001-winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol. 0002-mmdevapi: Do not mix frames and bytes. (in git now, but should not interfere) 0003-mmdevapi: Use UINT32 for a number of frames and UINT64 to sum them. Perhaps you tried out UINT32 first? Please try Get/Release first. My apology for the trouble, Jörg Höhle

1 0

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog
by Alexandre Julliard Sept. 1, 2011

Sept. 1, 2011

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > +static INT_PTR CALLBACK ConfigureDevicesDlgProc(HWND dialog, UINT uMsg, WPARAM wParam, LPARAM lParam) > +{ > + static LPDIACTIONFORMATW lpdiaf; > + static DIDevicesData devices_data; > + static ConfigureDevicesData *conf_data; > + > + switch(uMsg) > + { > + case WM_INITDIALOG: > + /* Initialize action format and enumerate devices */ > + conf_data = (ConfigureDevicesData*) lParam; > + lpdiaf = conf_data->params->lprgFormats; It doesn't make sense to pass the info as WM_INITDIALG parameter if it's going to be stored in global variables anyway. A better way would be to store this in the window info. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: 78223: Subject: configure: fix configure failures under -Werror -Wall
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/168 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78222: Subject: configure: AC_C_CONST is obsolete
by buildbot＠kegel.com Sept. 1, 2011

Sept. 1, 2011

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/167 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

WineHQ Maintenance.
by Jeremy Newman Sept. 1, 2011

Sept. 1, 2011

We will be performing upgrades and maintenance to the WineHQ.org server starting at 1800 CDT on Wednesday August 31st. This process will take the server off-line for about an hour. The Websites (www,appdb,forums), and Mailing lists, and Git will be off-line during this period. -Newman

1 1