September 2011 - Wine-Devel

Re: [PATCH 1/3] shell32: Don't call SendMessage inside critical section
by Alexandre Julliard Sept. 20, 2011

Sept. 20, 2011

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -355,24 +351,34 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID > if( !notify ) > continue; > > - ptr->pidlSignaled = ILClone(Pidls[0]); > + item = SHAlloc(sizeof(struct notification_recipients)); > + if(!item) { > + ERR("out of memory\n"); > + continue; > + } This one is never freed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] shell32: Be safe against removal of entries in SHChangeNotify
by Piotr Caban Sept. 20, 2011

Sept. 20, 2011

Hi, On 09/19/11 20:52, André Hentschel wrote: > @@ -325,7 +325,7 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID > EnterCriticalSection(&SHELL32_ChangenotifyCS); > > /* loop through the list */ > - LIST_FOR_EACH_ENTRY( ptr,&notifications, NOTIFICATIONLIST, entry ) > + LIST_FOR_EACH_ENTRY_SAFE( ptr, next,&notifications, NOTIFICATIONLIST, entry ) The function should not call SendMessage inside critical section. Cheers, Piotr

1 0

Re: [PATCH 4/5] vbscript: Added more tests
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14413 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] vbscript: Added support for short if statements
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14412 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] vbscript: Added support for rem statement-like comments
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14411 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] vbscript: Added support for ':' as statement separator
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14410 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 1/3 try2] wshom.ocx: Added WshShell class factory implementation
by Marvin Sept. 20, 2011

Sept. 20, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14406 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0