September 2011 - Wine-Devel

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.
by Marvin Sept. 30, 2011

Sept. 30, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14640 Your paranoid android. === WNT4WSSP6 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 === W2KPROSP4 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 === WXPPROSP3 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737

1 0

Re: gdiplus: Include an alpha channel in HBITMAPs created from Bitmaps.
by Vincent Povirk Sept. 29, 2011

Sept. 29, 2011

Don't commit this. Seems I forgot about top-down vs. bottom-up dibs. On Thu, Sep 29, 2011 at 12:03 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: > For bug 55549. >

1 0

Status for the ID3DXEffect interface
by Rico Schüller Sept. 29, 2011

Sept. 29, 2011

Hi, I'd like to say a word for the effect interface in d3dx9_xx.dll, what's already done and what's on the todo list. The parser for binary effects works pretty much. It should nearly parse the effect files completely, but it should fail on effect files which contain functions (if anyone has a binary effect with a function, I'd be interested in it). It is also possible to Get/Set some values, but not yet all, because there are some tricky cases which I haven't figured out completely yet (an example is GetVector() on an D3DXPT_INT). I'm currently working on the correct applying for the states and making some progress with that. But it seems to me that there are a lot of special cases in that. Todo: - Apply the states - Handle parameter blocks - State savings: State saving and restoring in Begin/End is needed. - ASCII effects: The effect could be supplied as byte code or as ASCII text. - ID3DXEffectPool: The support for effect pools is needed. I'm not sure if it might be useful to post an example of a commented binary effect file to make the format "visible" without reading the code. At least it could help when writing the ASCII effect parser. Cheers Rico

1 0

[PATCH 0/5] CMD command line parsing (try 5)
by Martin Wilck Sept. 29, 2011

Sept. 29, 2011

Contrary to what I said before, here is another attempt for my CMD patch series. Thanks to Frederic for reviewing this again, I made the suggested changes. Martin Wilck (5): cmd/tests: add tests for command line parsing cmd: use GetCommandline() rather than argv cmd: improve parsing of quotes in command line cmd: fix handling of special characters in command line cmd: fix parameter parsing of quotes and special chars programs/cmd/batch.c | 83 ++++++--- programs/cmd/tests/rsrc.rc | 6 + programs/cmd/tests/test_builtins.cmd.exp | 8 +- programs/cmd/tests/test_cmdline.cmd | 158 +++++++++++++++++ programs/cmd/tests/test_cmdline.cmd.exp | 77 +++++++++ programs/cmd/wcmdmain.c | 276 ++++++++++++------------------ 6 files changed, 407 insertions(+), 201 deletions(-) create mode 100644 programs/cmd/tests/test_cmdline.cmd create mode 100644 programs/cmd/tests/test_cmdline.cmd.exp -- 1.7.3.4

1 0

[PATCH 0/5] (4th attempt) CMD command line parsing
by Martin Wilck Sept. 29, 2011

Sept. 29, 2011

This is my 4th attempt at fixing the cmd command line treatment. All patches pass the cmd tests with 0 errors both under wine and on the Test Bot, including NT. Whitespace issues are fixed, too. Apart from that, the code is the same as before. The size of my patches has been criticized - only patch 2/5 is really big, but it has to be that way to pass the tests. This will also be my last attempt to get this merged. If the patches don't get applied this time, I hope that the cmd Gurus (Frederic or Dan) will take up the bits they like and get them in over time. If there are any technical issues or bugs in my code, I'll of course take care (please email me privately, as I'm not monitoring wine-devel). A private side note: I estimate that I have spent at least 10x more effort and time to get the tests right and the patches submission-ready than I spent on fixing the actual Wine code. I believe this project needs to think over its policies. I fully understand that a project this big needs to take a lot of care to maintain qualitiy standards. But the way this is currently working is discouraging and frustrating for casual contributors like myself. Martin Wilck (5): cmd/tests: add tests for command line parsing cmd: use GetCommandline() rather than argv cmd: improve parsing of quotes in command line cmd: fix handling of special characters in command line cmd: fix parameter parsing of quotes and special chars programs/cmd/batch.c | 82 ++++++--- programs/cmd/tests/rsrc.rc | 6 + programs/cmd/tests/test_builtins.cmd.exp | 8 +- programs/cmd/tests/test_cmdline.cmd | 158 +++++++++++++++++ programs/cmd/tests/test_cmdline.cmd.exp | 77 +++++++++ programs/cmd/wcmdmain.c | 276 ++++++++++++------------------ 6 files changed, 406 insertions(+), 201 deletions(-) create mode 100755 programs/cmd/tests/test_cmdline.cmd create mode 100755 programs/cmd/tests/test_cmdline.cmd.exp -- 1.7.3.4

4 6

Re: [PATCH] winex11: Make MapColor fall back to GetNearestIndex
by Alex Henrie Sept. 29, 2011

Sept. 29, 2011

2011/9/29 David Kiefer <hevanen(a)googlemail.com>: > A possible solution is to have MapColor call GetNearestIndex as a last > resort instead. This both fixes the problem and results in acceptable > performance. Thanks for the tip. I've submitted a new patch which uses this solution instead, and it works better. 2011/9/29 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > I'm not really sure how useful it is to try to optimize parts of the > X11 code now that the DIB engine is progressing nicely. Once the DIB > engine is done this code will disappear anyway. No need for horrible > X11 hacks to offload any DIB rendering and converting the X11 result > back into a DIB. You're right: the DIB engine would be much better. What needs to be done to get the DIB engine to work with Age of Empires II? -Alex

1 0

Re: [PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior
by David Kiefer Sept. 29, 2011

Sept. 29, 2011

While this patch indeed fixes bug 2666, it also kills performance, at least with Age of Empires II. The frame rate in the menu for me is about one frame every three seconds and about 1 fps in-game. With the patch, the work previously done by X11DRV_DIB_MapColor is now done by X11DRV_DIB_GetNearestIndex. Unlike GetNearestIndex, MapColor avoids traversing the entire palette most of the time by reusing the previous index in the destination bitmap if the color has not changed. However, MapColor only checks for exact matches and returns the first palette entry if none was found, effectively causing bug 2666. A possible solution is to have MapColor call GetNearestIndex as a last resort instead. This both fixes the problem and results in acceptable performance. David

2 1

Odd audio regression (interaction between two commits)
by Erich Hoover Sept. 29, 2011

Sept. 29, 2011

A: 64b14c0ecdd13530a92ff636c451523a99253a0b (quartz: Start DirectSound renderer as soon as possible.) B: e786998daff4ad49521a4c9c39c172ddcdcad82a (dsound: Reimplement rendering devices on mmdevapi.) I've been working with the audio in Fallout 3 and Fallout New Vegas for some time and I noticed a regression recently where the audio stopped working properly after the main menu (commit B). This triggered a memory of a similar experience I had where commit A caused the same behavior, but it only did so for PulseAudio users. So, on a hunch, I reverted commit A on the latest git and found that the audio went back to normal again. I'm not entirely sure what commit A could do to cause this problem, and I know you guys are busy with the audio changes, so if someone could point me in the right direction then I will try and track this issue down. Thanks! Erich Hoover ehoover(a)mines.edu

1 0

winecfg: Remove driver selection from Audio tab.
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 29, 2011

Sept. 29, 2011

Hi, I'm not satisfied with the removal of the audio tree from winecfg. Beside allowing to switch or disable drivers, one key feature was to allow inspecting the devices that winmm found on this system. For instance, I've not yet had time to report a bug that since wine-1.3.25, one such entry shows an empty name IIRC. It allowed users to easily check whether e.g. Timidity was recognized or whether "MIDI through" was the only output. It allowed users to easily tell whether their 5:1 sound card was recognized beside the default device. Bugzilla shows 350 entries about winecfg & audio. It had a use. What are users supposed to do now? Regards, Jörg Höhle

9 18

Favorite bug: deadlock preventing backtraces?
by Joerg-Cyril.Hoehle＠t-systems.com Sept. 29, 2011

Sept. 29, 2011

Dan Kegel wrote: >Sadly, no backtrace follows I've not had midi.ok crash on me, but now that you mention it, I've had occasional crashes of random reasons in various apps yet got no backtrace. I seem to remember that there have been times where backtraces would be produced more reliably. So perhaps 1/2 a suggestion would be to try how an older version behaves. It shouldn't matter with midi. But which older version to choose? Regards, Jörg Höhle

1 0