January 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Rethinking WineConf
by Jeremy White July 26, 2012

July 26, 2012

Hi All, This past Wine conference, while great fun as always, was not as well attended as Wine conferences in the past. So I would like to stir up trouble by suggesting we rethink WineConf. For those that have not attended, the Wine conference has been a mostly annual affair since 2002. It is open to all, but is advertised as being aimed at Wine developers. About 35 people attend each year. It's been in Minnesota about every 3rd year, and is otherwise 'normally' somewhere in Europe. I see the primary goal as creating human bonds between otherwise anonymous people (aka going to the pub). It's a bonus if it also spurs resolution to tricky issues, or motivates people to get more done. So I'd like to ask folks to brain storm with me. How could Wineconf be different? If you've never been, what would encourage you to come? If you've been to a technical conference recently that you thought was well done, what did they do well? Anything we could emulate? Any other ideas, or suggestions? Cheers, Jeremy

17 25

Re: kernel32: Add LCMapStringEx implementation and test it reusing tests from LCMapStringW
by Dmitry Timoshkov Feb. 5, 2012

Feb. 5, 2012

André Hentschel <nerv(a)dawncrow.de> wrote: > +/* Locale name special values */ > +#define LOCALE_NAME_INVARIANT L"" > +#define LOCALE_NAME_MAX_LENGTH 85 > +#define LOCALE_NAME_SYSTEM_DEFAULT L"!sys-default-locale" > +#define LOCALE_NAME_USER_DEFAULT NULL Have a look how unicode constants are defined in other header files, the above version can't work in Wine. Also just duplicating LCMapString tests is not a very good idea, it would be better to find a way to share the test data. -- Dmitry.

2 2

Profiing windows apps
by Ralph Little Feb. 2, 2012

Feb. 2, 2012

Hi, I'm looking at bug #9672 again in the The Sims. The app crashes early on during initialisation in DirectDraw. The problem occurs after CreateSurface returns an error, since it would appear that the DDSURFACEDESC passed into the call is foobar. This would lead me to conclude that something on the lead up to that call is precipitating that rogue call. I have a legal Windows XP and I wish to trace the calls leading up to this point with real Windows/DirectX to compare with what is happening to Wine so that I can assess what is upsetting the application, since I can't see anything in the Wine trace prior to that that looks suspicious. Does anyone have any experience with tracing apps in real Windows in the context of Wine development? Should I use a profiler or is there a simpler method? Cheers, Ralph

3 5

Re: dinput: Support INFINITE as number of effect iterations (try 2)
by Vitaliy Margolen Feb. 1, 2012

Feb. 1, 2012

On 01/28/2012 05:56 PM, Marcel Hasler wrote: > According to the DirectX reference, IDirectInputEffect::Start accepts > INFINITE (aka -1) for the number of iterations. However, passing -1 to > Linux via input_event results in no effect being played at all. This > patch sets the number of iterations to the maximum signed value > allowed if INFINITE is passed. > > This fixes bug 29712. > > This patch supersedes patch 83233. It does the same thing but adds a > comment and should be easier to understand. In general looks good. Would be nice to point out that linux/input.h says that any durations should not exceed 0x7fff as a maximum value. Please don't make code "easier to read" by adding needless if / else. Your first patch was fine. Vitaliy.

2 5

Re: [PATCH 2/3] winecoreaudio: Implement the lock-free callback design.
by Andrew Eikum Feb. 1, 2012

Feb. 1, 2012

On Mon, Jan 30, 2012 at 11:37:17AM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Fixes bug #29657 > While I like the idea of this patch and how you implemented it, I wonder if it's appropriate for code freeze. The main problem in that bug is that the CA driver can deadlock, or release memory out of order. When working on this patch, were you able to identify specifically where the contention is? The idea of the InTransition state was to handle the lock release in mid-call. Can we add a check for that state in the callbacks to solve this problem less intrusively? The first patch seems fine. Andrew

4 6

Updated clang-static-analyzer results (just in time for 1.4 ;))
by Austin English Feb. 1, 2012

Feb. 1, 2012

Enjoy: http://www.mediafire.com/?aiomfk1cr9bc61y Using: wine-1.4-rc1-34-g01947e0 LLVM commit 683d1e1d449e6e790ff4c0b6340a4bbf144ff919 / git-svn-id: http://llvm.org/svn/llvm-project/llvm/trunk(a)149340 91177308-0d34-0410-b5e6-96231b3b80d8 austin(a)aw21 ~ $ sha1sum scan-build-2012-01-30-1.tar.bz2 8b3b2573c3595c805431b2ab40c6958805f37497 scan-build-2012-01-30-1.tar.bz2 -- -Austin

2 2

Re: quartz: If the MediaSeeking is not implemented all the way up the passthru chain fall back to the filtergraph's clock to find position.
by Alexandre Julliard Jan. 31, 2012

Jan. 31, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > Resolves bug Bug 25606 > --- > dlls/quartz/filtergraph.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so filtergraph.c && touch filtergraph.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x690fff17 (thread 0066), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x690fff17). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:690fff17 ESP:0032fc70 EBP:0032fcd8 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:69195fa4 ECX:0032fcb8 EDX:0012cc0c ESI:0032fd28 EDI:0012c878 Stack dump: 0x0032fc70: 0032fd28 69195fa4 0032fcd8 690fb648 0x0032fc80: 0012c878 0000000d 00000000 00000000 0x0032fc90: 0032fd34 0032fd3c 00000000 6877a314 0x0032fca0: 6877418e 0012c7c0 80004001 6877a314 0x0032fcb0: 6877418e 0032fd28 00000000 00000000 0x0032fcc0: 00000001 6877428a 690fb58b 6877a314 Backtrace: =>0 0x690fff17 MediaSeeking_GetCurrentPosition+0x137(iface=0x12c7c8, pCurrent=0x32fd28) [/home/julliard/wine/wine/dlls/quartz/filtergraph.c:2460] in quartz (0x0032fcd8) 1 0x6876ddea func_filtergraph+0x3a9() [/home/julliard/wine/wine/dlls/quartz/tests/filtergraph.c:284] in quartz_test (0x0032fd58) 2 0x68767392 main+0x3a1(argc=0, argv=(nil)) [/home/julliard/wine/wine/dlls/quartz/tests/../../../include/wine/test.h:556] in quartz_test (0x0032fe28) 3 0x68773865 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x0032fe70) 4 0x6848cc4c call_process_entry+0xb() in kernel32 (0x0032fe88) 5 0x6848ddcf start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1083] in kernel32 (0x0032fec8) 6 0x6837a0b0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 7 0x6837cd9d call_thread_func+0x7c(entry=0x6848dd70, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 8 0x6837a08e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 9 0x6835219e start_process+0x1d(kernel_start=0x6848dd70) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 10 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x690fff17 MediaSeeking_GetCurrentPosition+0x137 [/home/julliard/wine/wine/dlls/quartz/filtergraph.c:2460] in quartz: movl 0x0(%eax),%edx 2460 IReferenceClock_GetTime(This->refClock, &time); -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: crypt32: Only accept trailing NULLs in a certificate common name.
by Erich E. Hoover Jan. 31, 2012

Jan. 31, 2012

On Tue, Jan 31, 2012 at 10:23 AM, Erich E. Hoover <ehoover(a)mines.edu> wrote: > On Tue, Jan 31, 2012 at 10:04 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> Sorry I didn't spot this earlier. Without this, someone who registers >> a certificate common name with an embedded NULL, like >> "codeweavers.com\0.badguy", could fool crypt32 into accepting it for a >> domain it isn't registered to, codeweavers.com in my example. > > It looks like you've just changed it to allow more than one NULL at > the end... It seems to me that the matching code already handles the > case of an embedded NULL, since it goes through the allowed_len > characters and manually checks each byte (rather than using a routine > like strcmp() which stops at NULLs). Please forgive the "Reply to all" fail. Erich Hoover ehoover(a)mines.edu

2 3

Warning report for wine-1.4-rc1
by Jerome Leclanche Jan. 31, 2012

Jan. 31, 2012

Some new warnings. Inlining it instead of attaching it this time, I hope that's ok. ========== 32-bit ========== ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o newstruc.o ../../../tools/wrc/newstruc.c ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o po.o ../../../tools/wrc/po.c ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but not used [-Wunused-function] ========== 64-bit ========== ccache gcc -msse4 -O3 -Wall -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o newstruc.o ../../../tools/wrc/newstruc.c ccache gcc -msse4 -O3 -Wall -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o po.o ../../../tools/wrc/po.c ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but not used [-Wunused-function] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/dbghelp -I. -I../../../include -I../../include -D__WINESRC__ -D_IMAGEHLP_SOURCE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o cpu_x86_64.o ../../../dlls/dbghelp/cpu_x86_64.c ../../../dlls/dbghelp/cpu_x86_64.c: In function ‘is_inside_epilog’: ../../../dlls/dbghelp/cpu_x86_64.c:341:14: warning: variable ‘rex’ set but not used [-Wunused-but-set-variable] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/ntdll -I. -I../../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o signal_x86_64.o ../../../dlls/ntdll/signal_x86_64.c ../../../dlls/ntdll/signal_x86_64.c: In function ‘is_inside_epilog’: ../../../dlls/ntdll/signal_x86_64.c:2632:14: warning: variable ‘rex’ set but not used [-Wunused-but-set-variable] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/oleaut32 -I. -I../../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -DENTRY_PREFIX=OLEAUTPS_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -DPROXY_CLSID=CLSID_PSFactoryBuffer -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o safearray.o ../../../dlls/oleaut32/safearray.c ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/oleaut32 -I. -I../../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -DENTRY_PREFIX=OLEAUTPS_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -DPROXY_CLSID=CLSID_PSFactoryBuffer -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o tmarshal.o ../../../dlls/oleaut32/tmarshal.c ../../../dlls/oleaut32/tmarshal.c:426:3: warning: #warning You need to implement stubless proxies for your architecture [-Wcpp] ../../../dlls/oleaut32/tmarshal.c: In function ‘serialize_param’: ../../../dlls/oleaut32/tmarshal.c:717:279: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:793:73: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:794:56: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:800:50: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:802:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:802:41: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:807:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:809:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:809:41: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:895:92: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c: In function ‘deserialize_param’: ../../../dlls/oleaut32/tmarshal.c:1076:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1079:78: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:1086:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1181:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1189:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c: In function ‘init_proxy_entry_point’: ../../../dlls/oleaut32/tmarshal.c:1699:17: warning: unused variable ‘xasm’ [-Wunused-variable] ../../../dlls/oleaut32/tmarshal.c: At top level: ../../../dlls/oleaut32/tmarshal.c:1317:1: warning: ‘xCall’ defined but not used [-Wunused-function] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/setupapi -I. -I../../../include -I../../include -D__WINESRC__ -D_SETUPAPI_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o devinst.o ../../../dlls/setupapi/devinst.c ../../../dlls/setupapi/devinst.c: In function ‘SETUPDI_AllocateDeviceInfo’: ../../../dlls/setupapi/devinst.c:470:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘SETUPDI_FreeDeviceInfo’: ../../../dlls/setupapi/devinst.c:527:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘SetupDiGetDeviceRegistryPropertyA’: ../../../dlls/setupapi/devinst.c:3106:278: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘SetupDiGetDeviceRegistryPropertyW’: ../../../dlls/setupapi/devinst.c:3167:278: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_IDA’: ../../../dlls/setupapi/devinst.c:3940:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_IDW’: ../../../dlls/setupapi/devinst.c:3958:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c:3970:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_ID_Size’: ../../../dlls/setupapi/devinst.c:3982:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c:3993:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/winmm -I. -I../../../include -I../../include -D__WINESRC__ -D_WINMM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o winmm.o ../../../dlls/winmm/winmm.c ../../../dlls/winmm/winmm.c: In function ‘MMSYSTEM_GetMidiStream’: ../../../dlls/winmm/winmm.c:975:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/winmm/winmm.c: In function ‘MMSYSTEM_MidiStream_MessageHandler’: ../../../dlls/winmm/winmm.c:1092:43: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/winmm/winmm.c: In function ‘midiStreamOpen’: ../../../dlls/winmm/winmm.c:1304:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] -- ccache gcc -msse4 -O3 -Wall -c -I../../../programs/winedbg -I. -I../../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o be_x86_64.o ../../../programs/winedbg/be_x86_64.c ../../../programs/winedbg/be_x86_64.c: In function ‘be_x86_64_is_func_call’: ../../../programs/winedbg/be_x86_64.c:346:11: warning: variable ‘segment’ set but not used [-Wunused-but-set-variable] ========== system ========== Operating System Linux azura 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:28:43 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux Configuration (32-bit) '--prefix=/usr' '--libdir=/usr/lib32' '--disable-tests' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Configuration (64-bit) '--prefix=/usr' '--libdir=/usr/lib' '--enable-tests' '--enable-win64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Warning report for wine-1.4-rc1 generated on Tue Jan 31 12:38:27 GMT 2012 J. Leclanche

2 2

Re: [PATCH 3/4] ddraw/tests: Add an IDirect3DTexture2::Load color key test
by Marvin Jan. 31, 2012

Jan. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16746 Your paranoid android. === W7PROX64 (64 bit ddraw4) === ddraw4.c:1247: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. ddraw4.c:1249: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. Timeout === TEST64_W7SP1 (64 bit ddraw4) === ddraw4.c:1247: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. ddraw4.c:1249: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. Timeout

1 0

Re: [PATCH 2/4] ddraw/tests: Add an IDirect3DTexture::Load color key test
by Marvin Jan. 31, 2012

Jan. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16745 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:1117: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1129: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1131: Test failed: Got unexpected hr 0x887600d7. ddraw2.c:1140: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1143: Test failed: dwColorSpaceLowValue is 0xff. ddraw2.c:1144: Test failed: dwColorSpaceHighValue is 0xff. ddraw2.c:1152: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1155: Test failed: dwColorSpaceLowValue is 0xff. ddraw2.c:1156: Test failed: dwColorSpaceHighValue is 0xff. === W7PROX64 (64 bit ddraw2) === ddraw2.c:1111: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. ddraw2.c:1113: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. Timeout === TEST64_W7SP1 (64 bit ddraw2) === ddraw2.c:1111: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. ddraw2.c:1113: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. Timeout

1 0

Re: [PATCH 2/2] urlmon: Properly handle relative URIs with specified host in combine_uri
by Marvin Jan. 31, 2012

Jan. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16738 Your paranoid android. === W7PROX64 (64 bit uri) === uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1]. uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1].

2 1

Re: configure.ac: remove an extraneous semicolon (Clang)
by Ken Thomases Jan. 31, 2012

Jan. 31, 2012

On Jan 30, 2012, at 10:09 PM, Austin English wrote: > @@ -1723,7 +1723,7 @@ then > saved_CFLAGS="$CFLAGS" > CFLAGS="$CFLAGS -Wlogical-op -Werror" > AC_CACHE_CHECK([for broken string.h that generates warnings with -Wlogical-op], ac_cv_c_logicalop_noisy, > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n);}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes])) > + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n)}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes])) > CFLAGS="$saved_CFLAGS" > if test "$ac_cv_c_logicalop_noisy" = "no" > then That doesn't look extraneous to me. Also, static analysis of the configure test programs seems like it would produce tons of noise. Those are often not sane programs by normal standards. Regards, Ken

2 1

Best way to overlay a filesystem for a Wine app?
by Scott Ritchie Jan. 30, 2012

Jan. 30, 2012

Suppose someone wants to distribute a Windows application as a traditional package, such as via the Ubuntu Software Center App Store. Ubuntu requires these commercial packages: 1) Install into a unique namespace in /opt (icons/.desktop excepted) 2) Store their user configuration in ~/.packagename or ~/.config/packagename I have already packaged a super-simple Wine application this way. This was a single binary file that could be run from anywhere - all I had to do was copy it into its own /opt folder and make a .desktop file that declared a unique WINEPREFIX for it. More complicated Windows applications, however, won't be doable with this basic approach. Specifically, Windows applications might: 1) Be distributed as installer files 2) Have self-updating mechanisms 3) Expect their own folder to be user-writable One ugly not-quite-solution would be to just have the package put the installer in opt, provide a link to it, and expect the user to install like he would a downloaded application (and then use a different .desktop file to actually run the program). Slightly better is to just copy an entire /opt prefix template into user space on first run, and then let it go on its own way after that. An app which didn't self-update, however, would then be unable to benefit from an updated version of the system package. A more complete solution would have a prefix in the user space, but files inside it would actually be those residing in /opt. A system of symlinks might work, but if a package update introduced new files those would not be available without complicated scripting to add the links. To me, this sounds an awful lot like an overlay file system. Would unionfs-fuse be the correct solution here? The .desktop file that sets the Wine prefix and also launches the app could mount the FUSE filesystem, and the user-space Wine prefix's files could take priority over those in /opt. Stuff like user-modding and update/repair systems could work properly in that context as well. Or have I missed something? Thanks, Scott Ritchie

4 5

winecoreaudio.drv: Improve underrun handling
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 30, 2012

Jan. 30, 2012

Andrew, The good news is that your underrun patch prevents mmdevapi from writing less and less frames in mmdevapi/tests/render:test_worst_case http://test.winehq.org/data/f0cfa7cf46d7c832fb84555529d1a1b7c49c46c0/mac_jc… >render.c:1631: Released 86436=98x882 -0 frames at 44100 worth 1960ms in 2035ms >render.c:1631: Released 71442=81x882 -0 frames at 44100 worth 1620ms in 2037ms >render.c:1631: Released 56448=64x882 -0 frames at 44100 worth 1280ms in 2039ms That is abnormal behavior. + sc = AudioQueueEnqueueBufferWithParameters(This->aqueue, + This->public_buffer, 0, NULL, 0, 0, 0, NULL, &req_time, &start_time); I advise against setting req_time. This can only fragilize the system. What if req_time is miscomputed or there's a delay? NULL=ASAP is exactly what we want. We don't want ALSA/dmix behavior, where it'll silently skip over late frames in order to catch up (dunno if MacOSX does this but in my eyes that doesn't matter). If you need to memorize a time, I believe it's best stored in our AQBuffer struct. >if(list_count(...) == 0) I once wrote a patch to turn such a pattern into if(list_empty(...)) Regards, Jörg

2 3

Re: winealsa: snd_card_get_name uses strdup (Valgrind). (2nd)
by Alexandre Julliard Jan. 30, 2012

Jan. 30, 2012

Joerg-Cyril.Hoehle(a)t-systems.com writes: > Perhaps that way, the relationship is obvious. > > Please choose whether to apply the original patch #82900 or this one. > It used instead "if(!err)" i.e. the 0 return code that ALSA documents. The previous one was better, but you need to get rid of that cast. -- Alexandre Julliard julliard(a)winehq.org

1 0

mmdevapi: Correctly convert UINT32 to INT64
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 30, 2012

Jan. 30, 2012

Andrew, thank you very much for finding a bug in my code. I'll have to meditate signed/unsigned conversions for the next months. Perhaps it's my lack of familiarity with the MS-Windows API that had me not find a signed equivalent of UINT32. Indeed there's none in windef.h. So I choose 'long'. But now I see basestd.h defines LONG32. INT64 is not appropriate. getbuf_last should be of the same size than the other frame holding types. I once wrote a patch to turn all #frame holding entities from UINT64 into 32. Please rewrite the patch to use the LONG32 type, then you'll need no surprising cast. If the loss of 1 bit worries you, the solution IMHO is not to go to INT64 rather than prevent a duration that large in Initialize. In shared mode, there's no 2s limit. My tests opened a 10s buffer. I've not tested anything larger. LONG32 leaves enough room for 10000 seconds at 200000fps. Regards, Jörg Höhle

3 3

comctl32: fix MSVC build in imagelist.c
by carlo.bramix＠libero.it Jan. 30, 2012

Jan. 30, 2012

If I can say my opinion, I disagree on the usage of HeapAlloc/HeapFree for that known amount of memory. Instead, for granting compatibility with MSVC, I would continue to use a structure in stack memory by simply using _alloca() and something like this: LPBITMAPINFO bmi = (LPBITMAPINFO) _alloca(FIELD_OFFSET(BITMAPINFO, bmiColors[256])); or this: LPBITMAPINFO bmi = (LPBITMAPINFO) _alloca(sizeof(BITMAPINFO)+sizeof(RGBQUAD)*256); and leaving all other lines of code unchanged. Sincerely, Carlo Bramini. > Thomas Faber <thfabba at gmx.de> writes: > >> This removes the use of a Variable-Length Array in ImageList_CreateImage >> and replaces it with HeapAlloc/HeapFree, as it is done in several >> other functions in this file. >> Alas, FIELD_OFFSET is "not const enough" for ANSI C. > >Using sizeof instead would be preferable. > >-- >Alexandre Julliard >julliard at winehq.org >

1 0