January 2012 - Wine-Devel - list.winehq.org

Re: [2/2] scrrun: Register Scripting interfaces
by Nikolay Sivov Jan. 26, 2012

Jan. 26, 2012

On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Register Scripting interfaces Some of this are already used in wshom.ocx, I'm not sure which one should take precedence and implement that. Probably it changed in recent Windows versions?

3 6

fwd: winealsa: snd_card_get_name uses strdup (Valgrind).
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 26, 2012

Jan. 26, 2012

Hi, Andrew Eikum updated ALSA's documentation http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=226a34ac09e5d9c0… Now that free() is documented, the pending patch #82900 should be applied. Regards, Jörg Höhle

1 0

Re: shell32: Use simple helper for case insensitive strstr()
by Alexandre Julliard Jan. 26, 2012

Jan. 26, 2012

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix for http://bugs.winehq.org/show_bug.cgi?id=28087 You shouldn't need anything of the kind. If StrStrIW doesn't work right it should be fixed (plus of course there's no reason to even use strstr() here at all). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: po: Remove extraneous full stops from the Japanese translation.
by Akihiro Sagawa Jan. 25, 2012

Jan. 25, 2012

Hi Francois, On Tue, 24 Jan 2012 00:28:02 +0100 (CET), Francois Gouget wrote: > This is essentially the kernel32 error messages. > > po/ja.po | 1587 +++++++++++++++++++++++++++++++------------------------------- > 1 files changed, 792 insertions(+), 795 deletions(-) IMHO, the error message should be well-formed sentences. I confused a lot while translating because some messages are not sentence style. For such a reason, I translated the message into Japanese sentence. So full-stops are reasonable. Additionally, in Windows, a sentence with periods or full-stops is used for the error message. So a Japanese Wine user might feel something wrong with the message if I translate without full-stops. Best regards, Akihiro Sagawa

3 4

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game
by Henri Verbeet Jan. 25, 2012

Jan. 25, 2012

On 22 January 2012 19:44, Detlef Riekenberg <wine.dev(a)web.de> wrote: > - if (usage & ~handled) > + static DWORD reported_once; > + > + if (usage & ~(handled | reported_once)) > + { > + reported_once |= (usage & ~handled); > FIXME("Unhandled usage flags %#x.\n", usage & ~handled); > + } I don't think so.

6 7

Re: ieframe: Fixed a typo in IDocObjectService::FireNavigateComplete2
by Marvin Jan. 25, 2012

Jan. 25, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16644 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3245: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2116: Test failed: put_Resizable failed: 80004001 webbrowser.c:2117: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2121: Test failed: put_Resizable failed: 80004001 webbrowser.c:2122: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:407: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2116: Test failed: put_Resizable failed: 80004001 webbrowser.c:2117: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2121: Test failed: put_Resizable failed: 80004001 webbrowser.c:2122: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2792: Test failed: expected TranslateUrl webbrowser.c:2793: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2795: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2801: Test failed: ReadyState = 1, expected 4 webbrowser.c:2611: Test failed: ReadyState = 1, expected 4 webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:832: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:839: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:788: Test failed: ReadyState = 1, expected 4 webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3188: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2658: Test failed: expected TranslateUrl webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3195: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2658: Test failed: expected TranslateUrl webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2792: Test failed: expected TranslateUrl webbrowser.c:2793: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2801: Test failed: ReadyState = 1, expected 4 webbrowser.c:2611: Test failed: ReadyState = 1, expected 4 webbrowser.c:832: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:839: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:788: Test failed: ReadyState = 1, expected 4 webbrowser.c:1547: Test failed: unexpected call GetDropTarget Timeout

1 0

Resource accelerators discrepancies
by Frédéric Delanoy Jan. 25, 2012

Jan. 25, 2012

Hi Alexandre, After your addition of accelerators to po file for winefile (among others) [fe021a44 winefile: Add message contexts for accelerators that can be translated], there seems to be some discrepancies: #: winefile.rc:202 msgctxt "accelerator Fullscreen" msgid "^S" vs #: winefile.rc:70 msgid "F&ull Screen\tCtrl+Shift+S" and #: winefile.rc:201 winemine.rc:99 msgctxt "accelerator Exit" msgid "X" vs #: winefile.rc:38 winemine.rc:46 msgid "E&xit\tAlt+X" winefile.rc contains: - "X", ID_FILE_EXIT, VIRTKEY, ALT - "S", ID_VIEW_FULLSCREEN, VIRTKEY, SHIFT, CONTROL + "#msgctxt#accelerator Exit#X", ID_FILE_EXIT, ALT + "#msgctxt#accelerator Fullscreen#^S", ID_VIEW_FULLSCREEN, SHIFT So, - is there a way/shouldn't the "label\tshortcut" menu entries be automated somehow? E.g. so the accelerator is automatically extracted - is only the Control modifier shown in msgids? E.g. "X" while the shortcut is Alt-X. That's a bit inconsistent IMHO Frédéric

2 1

Re: setupapi: add a stub for SetupAddToDiskSpaceListA/W
by Dmitry Timoshkov Jan. 25, 2012

Jan. 25, 2012

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI SetupAddToDiskSpaceListA(HDSKSPC DiskSpace, PCSTR TargetFilespec, > + LONGLONG FileSize, UINT Operation, > + PVOID Reserved1, UINT Reserved2) I think it's been mentioned numerous times already about usage hungarian or capitalzed variable names in Wine code. -- Dmitry.

1 0

In-process wine server (a.k.a., "Dirty Speed Hack")
by Daniel Santos Jan. 25, 2012

Jan. 25, 2012

Here's my hack after some cleanup, refinements and further experimentation (mostly discovering what doesn't work). It's still in the early stages. So I had this idea about 3 years ago and when playing Star Wars Battlefront (1 and 2) and having such long load times that I couldn't alleviate much by addressing the bottlenecks (the app spams GetForegroundWindow and PeekMessageA while loading, hitting them each 22k times a second), I finally decided to give this hack a stab. So in summary, loading new maps was taking 75 seconds under wine, where they only take 10 to 15 seconds on windows (well, on my laptop, which is slower than my desktop). With this hack, they are down to 8 seconds under wine, roughly 10x faster. This hack builds a libwineserver.so that the primary application (i.e., the one you first launch) will spawn a thread and run the wine server in the same process, if you've set the environment variable DIRTYNASTYSPEEDHACK. Then, calls to the wineserver are made directly. Subsequent programs in the same WINEPREFIX will interact with your process using the traditional pipes. I don't have the build working the way it should, it currently only builds the libwineserver.so when it builds the server (i.e., not built when you configure with --with-wine-tools). I'm not strong in autotools, so if anybody cares to add this, I would appreciate it :) Obviously, the trade off for this speed increase is that the stability of your wine server (and thus, all apps running under that instance) are based upon the stability of your program. So with this enabled, your program can crash the wine instance. Also, while it addresses the slow loading issues in Star Wars Battlefront II, it behaves very oddly in regards to sound buffers being played correctly and HID input (if I move the mouse slowly downwards, it will actually move slowly up). These problems go away when I debug it (I presume because the debugger is slowing the program back down). I'm going to try this out on a few other apps that run slow under wine (like Finale 2010). Daniel

2 2

Re: comdlg32: Correctly handle filters with invalid extensions in Save As dialogs
by Marvin Jan. 24, 2012

Jan. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16639 Your paranoid android. === WVISTAADM (32 bit filedlg) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 2/5] ddraw/tests: Port the depth blit test to ddraw7 (try 2)
by Henri Verbeet Jan. 24, 2012

Jan. 24, 2012

On 22 January 2012 16:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void get_depth_stencil(IDirect3DDevice7 *device, IDirectDrawSurface7 **ds) > +{ > + IDirectDrawSurface7 *rt; > + DDSCAPS2 caps = {DDSCAPS_ZBUFFER, 0, 0, 0}; > + HRESULT hr; > + > + hr = IDirect3DDevice7_GetRenderTarget(device, &rt); > + ok(SUCCEEDED(hr), "Failed to get the render target, hr %#x.\n", hr); > + hr = IDirectDrawSurface7_GetAttachedSurface(rt, &caps, ds); > + ok(SUCCEEDED(hr) || hr == DDERR_NOTFOUND, "Failed to get the z buffer, hr %#x.\n", hr); > + IDirectDrawSurface7_Release(rt); > +} This should probably just return the surface. > + hr = IDirect3D7_QueryInterface(d3d, &IID_IDirectDraw7, (void **) &ddraw); Extra space. > + ok(SUCCEEDED(hr), "Failed to set the z cuntion, hr %#x.\n", hr); Typo. > + memset(&fx, 0, sizeof(fx)); > + fx.dwSize = sizeof(fx); > + fx.dwFillDepth = 0; That probably needs an U5(). I tend to forget half of them as well though.

3 2

Re: po: Fix the accelerator key specifications in the French translation.
by Frédéric Delanoy Jan. 24, 2012

Jan. 24, 2012

2012/1/24 Francois Gouget <fgouget(a)free.fr>: > --- > po/fr.po | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) -msgstr "&Effacer\tDel" +msgstr "&Effacer\tSuppr" -msgstr "P&lein écran\tCtrl+Shift+S" +msgstr "P&lein écran\tCtrl+Maj+S" Don't know about other non-France originating French keyboards, but here (Belgium) on most keyboards, Del and Shift keys are physical present on all keyboards (as are Home, PgDown, ...). I'm not sure if that's worth a custom fr_BE.po file, though. BTW, it is currently possible for a language sublang (e.g. XY_ab of language XY) to *only* include differences from the main XY po file? Frédéric

2 2

Re: po: Fix the accelerator key specifications in the Finnish translation.
by Francois Gouget Jan. 24, 2012

Jan. 24, 2012

On Tue, 24 Jan 2012, Lauri Kenttä wrote: > Hello, > > You may skip any further clean-up on Finnish for now, if you wish. We're > working on a full Finnish translation, which will hopefully be ready in time > for Wine 1.4. Thanks! I'll leave all to you. Don't hesitate to let me know about false positives in Wine-PO's reports or if it's wrong for some reason. http://fgouget.free.fr/wine-po/ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

1 0

Re: [PATCH] include: Handle rmxftmpl.x when needed by d3dx9 without the need to make all includes.
by Alexandre Julliard Jan. 24, 2012

Jan. 24, 2012

Rico Schüller <kgbricola(a)web.de> writes: > @@ -110,6 +110,9 @@ filter: dummy > .po.mo: > $(MSGFMT) -o $@ $< > > +.x.h: > + $(MAKEXFTMPL) -i D3DRM_XTEMPLATES -s D3DRM_XTEMPLATE_BYTES -o $@ $< It doesn't make sense to have a generic rule since the template names are file specific. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: fix spec file parameters/don't trace non-const strings
by Alexandre Julliard Jan. 24, 2012

Jan. 24, 2012

Austin English <austinenglish(a)gmail.com> writes: > Addresses Dmitry's feedback from > http://www.winehq.org/pipermail/wine-devel/2012-January/093886.html I see no reason to believe that these are output parameters. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: iphlpapi: sync spec file to Windows 7 (1/2)
by Alexandre Julliard Jan. 24, 2012

Jan. 24, 2012

Austin English <austinenglish(a)gmail.com> writes: > From the keeping Focht happy/thanking him for debugging my bugs department :) New stubs should be commented out until there is evidence that some application is using them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: ActiveX objects might not support IServiceProvider Interface (try 2)
by Marvin Jan. 24, 2012

Jan. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16634 Your paranoid android. === W2KPROSP4 (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === WXPPROSP3 (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === W2K3R2SESP2 (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === WVISTAADM (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === W2K8SE (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === W7PRO (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === W7PROX64 (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === TEST64_W7SP1 (32 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === W7PROX64 (64 bit activex) === activex.c:163: Test failed: pUnkSite != NULL === TEST64_W7SP1 (64 bit activex) === activex.c:163: Test failed: pUnkSite != NULL

1 0

In-process wineserver
by Daniel Santos Jan. 24, 2012

Jan. 24, 2012

I've updated my in-process wineserver hack, cleaned it up a bit more and fixed a few problems. So, at least in Star Wars Battlefront II, the sound and HID problems are fixed (the "select" server call must be made via the pipe). I presume there are other server calls with similar properties. Also, the wineserver now exits properly and cleans up it's instance when the main process terminates. Changed the enabling enviroment variable to "WINESPEEDHACK". So what would it take for this to be integrated into wine as an optional feature?

3 3

re: wine cross-compilation and SONAME*
by Dan Kegel Jan. 23, 2012

Jan. 23, 2012

How about the xldd script attached at http://comments.gmane.org/gmane.comp.gcc.cross-compiling/12202 ?

1 0

Re: [po]updated korean resource(2012-1-22)
by Francois Gouget Jan. 23, 2012

Jan. 23, 2012

Hi, Thanks a lot for the translation update. > -#, fuzzy > msgid "&Width:" > msgstr "너비(&W) :" [...] > -#, fuzzy > msgid "&Height:" > msgstr "높이(&H) :" [...] How come these (there is a whole series) have a space before the colon? That does not seem to be the case in other translations with a trailing colon (and may be why these ended up as fuzzy). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: include/ddk: ntddcdvd.h structure naming, packing fixes
by Alexandre Julliard Jan. 23, 2012

Jan. 23, 2012

Dan Kegel <dank(a)kegel.com> writes: > @@ -61,7 +63,7 @@ typedef struct _DVD_COPY_PROTECT_KEY { > } s; > LARGE_INTEGER TitleOffset; > } Parameters; > - UCHAR KeyData[1]; > + UCHAR KeyData[0]; That's not portable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] shell32: Don't translate the shell folder paths.
by Alexandre Julliard Jan. 23, 2012

Jan. 23, 2012

Francois Gouget <fgouget(a)free.fr> writes: > Some are not meant to be translated anyway (e.g. 'Program Files') and others only partially (e.g. 'Program Files\Common Files'). For rest the path forward is to only translate them in the GUI using desktop.ini files. > The execptions are the folders that we usually symlink to an actual host folder as we cannot use a desktop.ini file in these cases. > --- > > Hopefully this faithfully implements what was suggested in: > http://www.winehq.org/pipermail/wine-devel/2012-January/093847.html > > Let me know if I misunderstood the original intent. It's fine, but I'm not sure we should remove the string resources. We are going to need at least some of these strings again when we implement desktop.ini, so if we remove them we are going to lose translations that will be needed later on. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: ActiveX objects might not support IServiceProvider Interface (try 2)
by Jacek Caban Jan. 23, 2012

Jan. 23, 2012

On 01/23/12 10:45, Alistair Leslie-Hughes wrote: > Hi, > Corrected Failed Tests. > > Changelog: > jscript: ActiveX objects might not support IServiceProvider > Interface > ax_site = create_ax_site(ctx); + IObjectWithSite_SetSite(obj_site, ax_site); if(ax_site) { - hres = IObjectWithSite_SetSite(obj_site, ax_site); IUnknown_Release(ax_site); } IObjectWithSite_Release(obj_site); - if(!ax_site || FAILED(hres)) { - IUnknown_Release(obj); - return NULL; - } Lack of host IServiceProvider is not the only reason for create_ax_site to fail. Please handle error cases correctly. CHECK_EXPECT(SetSite); - ok(pUnkSite != NULL, "pUnkSite == NULL\n"); - hres = IUnknown_QueryInterface(pUnkSite, &IID_IServiceProvider, (void**)&sp); - ok(hres == S_OK, "Could not get IServiceProvider iface: %08x\n", hres); - IServiceProvider_Release(sp); + if(AllowIServiceProvider) + { + ok(pUnkSite != NULL, "pUnkSite == NULL\n"); + + hres = IUnknown_QueryInterface(pUnkSite, &IID_IServiceProvider, (void**)&sp); + ok(hres == S_OK, "Could not get IServiceProvider iface: %08x\n", hres); + IServiceProvider_Release(sp); + } return SetSite_hres; We need a test to see what's passed to SetSite in this case, not just skip all tests. Jacek

1 0

Re: jscript: ActiveX objects might not support IServiceProvider Interface
by Marvin Jan. 23, 2012

Jan. 23, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16611 Your paranoid android. === W2KPROSP4 (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === WXPPROSP3 (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === W2K3R2SESP2 (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === WVISTAADM (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === W2K8SE (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === W7PRO (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === W7PROX64 (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === TEST64_W7SP1 (32 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === W7PROX64 (64 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite === TEST64_W7SP1 (64 bit activex) === activex.c:822: Test failed: ParseScriptText failed: 800a01ad activex.c:823: Test failed: expected Host_QS_SecMgr activex.c:824: Test failed: expected ProcessUrlAction activex.c:825: Test failed: expected CreateInstance activex.c:826: Test failed: expected QueryCustomPolicy activex.c:827: Test failed: expected QI_IObjectWithSite activex.c:828: Test failed: expected reportSuccess activex.c:837: Test failed: InvokeEx failed: 80020009 activex.c:838: Test failed: expected ProcessUrlAction activex.c:839: Test failed: expected CreateInstance activex.c:840: Test failed: expected QueryCustomPolicy activex.c:841: Test failed: expected QI_IObjectWithSite activex.c:842: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:849: Test failed: InvokeEx failed: 80020009 activex.c:850: Test failed: expected ProcessUrlAction activex.c:851: Test failed: expected CreateInstance activex.c:852: Test failed: expected QueryCustomPolicy activex.c:853: Test failed: expected QI_IObjectWithSite activex.c:854: Test failed: expected reportSuccess activex.c:532: Test failed: unexpected call activex.c:532: Test failed: unexpected call activex.c:868: Test failed: InvokeEx failed: 80020009 activex.c:869: Test failed: expected Host_QS_SecMgr activex.c:870: Test failed: expected ProcessUrlAction activex.c:871: Test failed: expected CreateInstance activex.c:872: Test failed: expected QueryCustomPolicy activex.c:873: Test failed: expected QI_IObjectWithSite activex.c:874: Test failed: expected reportSuccess activex.c:886: Test failed: expected Host_QS_SecMgr activex.c:896: Test failed: expected Host_QS_SecMgr activex.c:897: Test failed: expected ProcessUrlAction activex.c:907: Test failed: expected Host_QS_SecMgr activex.c:908: Test failed: expected ProcessUrlAction activex.c:919: Test failed: expected Host_QS_SecMgr activex.c:920: Test failed: expected ProcessUrlAction activex.c:921: Test failed: expected CreateInstance activex.c:933: Test failed: expected Host_QS_SecMgr activex.c:934: Test failed: expected ProcessUrlAction activex.c:935: Test failed: expected CreateInstance activex.c:936: Test failed: expected QueryCustomPolicy activex.c:949: Test failed: ParseScriptText failed: 800a01ad activex.c:950: Test failed: expected Host_QS_SecMgr activex.c:951: Test failed: expected ProcessUrlAction activex.c:952: Test failed: expected CreateInstance activex.c:953: Test failed: expected QueryCustomPolicy activex.c:954: Test failed: expected QI_IObjectWithSite activex.c:955: Test failed: expected reportSuccess activex.c:967: Test failed: expected Host_QS_SecMgr activex.c:968: Test failed: expected ProcessUrlAction activex.c:969: Test failed: expected CreateInstance activex.c:970: Test failed: expected QueryCustomPolicy activex.c:978: Test failed: expected ProcessUrlAction activex.c:979: Test failed: expected CreateInstance activex.c:980: Test failed: expected QueryCustomPolicy activex.c:989: Test failed: expected ProcessUrlAction activex.c:990: Test failed: expected CreateInstance activex.c:991: Test failed: expected QueryCustomPolicy activex.c:1017: Test failed: ParseScriptText failed: 800a01ad activex.c:1018: Test failed: expected Host_QS_SecMgr activex.c:1019: Test failed: expected ProcessUrlAction activex.c:1020: Test failed: expected CreateInstance activex.c:1021: Test failed: expected QueryCustomPolicy activex.c:1022: Test failed: expected QI_IObjectWithSite activex.c:1023: Test failed: expected SetSite activex.c:1024: Test failed: expected reportSuccess activex.c:1033: Test failed: expected ProcessUrlAction activex.c:1034: Test failed: expected CreateInstance activex.c:1035: Test failed: expected QueryCustomPolicy activex.c:1036: Test failed: expected QI_IObjectWithSite activex.c:1037: Test failed: expected SetSite

1 0

Re: winegstreamer: set bmiHeader.biSizeImage in the transform filter
by Dmitry Timoshkov Jan. 23, 2012

Jan. 23, 2012

Aric Stewart <aric(a)codeweavers.com> wrote: > + vih->bmiHeader.biSizeImage = width * height * 3; > + if ((LONG)height < 0) > + vih->bmiHeader.biSizeImage = -1 * vih->bmiHeader.biSizeImage; Using correct types from the start (instead of introducing ugly and wrong workarounds) should help. -- Dmitry.

1 0

wine cross-compilation and SONAME*
by Grazvydas Ignotas Jan. 22, 2012

Jan. 22, 2012

Hi, cross-compiling wine to arm-linux fails with: ../../../wine/dlls/winex11.drv/x11drv_main.c: In function ‘process_attach’: ../../../wine/dlls/winex11.drv/x11drv_main.c:527: error: ‘SONAME_LIBX11’ undeclared (first use in this function) This is because WINE_CHECK_SONAME in configure tries to run ldd on a compiled test executable which fails, since host ldd knows nothing about ARM, and all SONAME_* entries end up missing in ocnfig.h . Running configure with LDD='/usr/bin/strings' helps, would it make sense for configure to use something like strings instead of ldd when cross-compiling? -- Gražvydas

1 0

Re: [PATCH 2/3] ddraw/tests: Port the depth blit test to d3d7
by Henri Verbeet Jan. 22, 2012

Jan. 22, 2012

On 21 January 2012 21:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I've also ported this to d3d1. Windows is behaving in the same way, but > the test isn't working on Wine yet due to some blit-unrelated > issue, so I'm not sending the d3d1 test yet. > --- > dlls/ddraw/tests/visual.c | 166 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 166 insertions(+), 0 deletions(-) New ddraw tests should of course use the new ddraw test infrastructure. We should move the existing tests over as well at some point (and clean them up in the process...), but that can wait a bit.

2 1

"Sound" keyword on bugzilla
by Jerome Leclanche Jan. 22, 2012

Jan. 22, 2012

Hi, Joerg and I exchanged a couple of emails where I proposed a "sound" keyword on bugzilla. Reasoning: there are multiple sound components, and most of the time, the correct component is unknown (or could even be caused by non-sound components). Thoughts? J. Leclanche

8 24

Invitation to connect on LinkedIn
by Mark Lu Jan. 21, 2012

Jan. 21, 2012

LinkedIn ------------ I'd like to add you to my professional network on LinkedIn. - Mark Mark Lu Software Engineer at Famo.us San Francisco Bay Area Confirm that you know Mark Lu: https://www.linkedin.com/e/-e2qz00-gxobhdv9-6t/isd/5602759993/HrqbmUDG/?hs=… -- You are receiving Invitation to Connect emails. Click to unsubscribe: http://www.linkedin.com/e/-e2qz00-gxobhdv9-6t/qmvMTRNX8e7GRhbvVrqMlEBXQ4T3A… (c) 2011 LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA.

1 0

Re: (try 5)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate
by Dmitry Timoshkov Jan. 21, 2012

Jan. 21, 2012

Aric Stewart <aric(a)codeweavers.com> wrote: > + TRACE("found scan=%04x keyc=%u keysym=%04lu modified_string=%s\n", > + scanCode, keyc, keys, debugstr_an(name,idx-name)); Please keep printing a keysym in hex, printing it in decimal (especially with leading zeros) is not useful. Also add a space in the debugstr_an() construct. -- Dmitry.

1 0

Re: comdlg32: Correctly handle filters with multiple file extensions in Save As dialogs (try 3)
by Marvin Jan. 20, 2012

Jan. 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16587 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

resolving dead-locks using InterlockedPushEntrySList on MacOS #29657
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 20, 2012

Jan. 20, 2012

Hi, Let's assume for the discussion that Winecoreaudio/mmdevdrv.c: ca_in_buffer_cb(...) { OSSpinLockLock(&This->lock); list_add_tail(&This->avail_buffers, &buf->entry); This->inbuf_frames += buffer->mAudioDataByteSize / This->fmt->nBlockAlign; OSSpinLockUnlock(&This->lock); } really is causing deadlocks and leads to bogus code like releasing locks mid-function to call other functions that may take the lock too: OSSpinLockUnlock(&This->lock); sc = AudioQueueFlush(This->aqueue); sc = AudioQueuePause(This->aqueue); OSSpinLockLock(&This->lock); -- alas allowing any other thread to enter mmdevdrv in between. (I'll have to perform more checks this week-end). For reference, see bug #29657. I thought about using lock-free data structures: a) MacOS lock-free FIFO b) MS' InterlockedPushEntrySList c) other schemes a) MacOS' lock-free FIFO: MacOS OSAtomicFifoEnqueue is only available with Lion, which rules it out. http://developer.apple.com/library/mac/#documentation/DriversKernelHardware… b) MS' InterlockedPushEntrySList: That is implemented in dlls/ntdll/rtl.c However, I presumably can't call that from within the MacOS callback, because the cross-library call might get logged by +relay, and that's a no-no within the native callback (RunLoop) execution context. Work-around: copy&paste that function into winecoreaudio I don't like that much but do you have a better idea? c) other schemes: Assuming list elements are returned in the order we sent them out, we don't need to enqueue them and instead could set a bit or use InterlockedIncrement (like the MCI does with winmm headers). Is there any other suggestion that comes to mind? IMHO, ca_in_buffer_cb doesn't need a transaction around enqueue+inbuf. Enqueue and inbuf+= could be performed separately, inbuf+= could even be deferred to GetCurrentPadding, leaving one single operation left to do within the MacOS callback. Regards, Jörg Höhle

1 0

Re: [PATCH] ieframe: Added HTTP navigation and GoBack tests
by Marvin Jan. 20, 2012

Jan. 20, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16580 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3134: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3227: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2484: Test failed: expected GetOverridesKeyPath webbrowser.c:2488: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2489: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2098: Test failed: put_Resizable failed: 80004001 webbrowser.c:2099: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2103: Test failed: put_Resizable failed: 80004001 webbrowser.c:2104: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2484: Test failed: expected GetOverridesKeyPath webbrowser.c:2488: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2489: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:407: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2098: Test failed: put_Resizable failed: 80004001 webbrowser.c:2099: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2103: Test failed: put_Resizable failed: 80004001 webbrowser.c:2104: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2484: Test failed: expected GetOverridesKeyPath webbrowser.c:2488: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2489: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2774: Test failed: expected TranslateUrl webbrowser.c:2775: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2777: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2783: Test failed: ReadyState = 1, expected 4 webbrowser.c:2593: Test failed: ReadyState = 1, expected 4 webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:812: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:819: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:901: Test failed: ReadyState = 1, expected 4 webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3170: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2640: Test failed: expected TranslateUrl webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3177: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2640: Test failed: expected TranslateUrl webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2774: Test failed: expected TranslateUrl webbrowser.c:2775: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2783: Test failed: ReadyState = 1, expected 4 webbrowser.c:2593: Test failed: ReadyState = 1, expected 4 webbrowser.c:812: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:819: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:901: Test failed: ReadyState = 1, expected 4 webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2593: Test failed: ReadyState = 1, expected 4 webbrowser.c:796: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:812: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1518: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 16 webbrowser.c:466: Test failed: unexpected nCmdID 15 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:901: Test failed: ReadyState = 1, expected 4 webbrowser.c:1529: Test failed: unexpected call GetDropTarget webbrowser.c:968: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2647: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2888: Test failed: expected RequestUIActivate webbrowser.c:2980: Test failed: Got 0x80004002 webbrowser.c:3075: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040CDE2

2 1

re: PVS-Studio run against ReactOS: (at least) one bug in wine git
by Dan Kegel Jan. 20, 2012

Jan. 20, 2012

Hey, cool! I added that to http://wiki.winehq.org/StaticAnalysis I figured I'd try running PVS-Studio on the Wine sources in Wine, but it runs in the Visual Studio context, and I can't even load the wine project successfully under warn+heap; see http://bugs.winehq.org/show_bug.cgi?id=29509 (It'd be awesome if we could build wine with visual studio 2005, not only to use it with PVS-Studio, but just for the sake of self-hosting.)

2 2

Re: (try 4)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate
by Dmitry Timoshkov Jan. 20, 2012

Jan. 20, 2012

Aric Stewart <aric(a)codeweavers.com> wrote: > The problem is that there is no XK keycode for just Shift, Control or > Menu so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result > the string XKeysymToString returns is a string with a _L or _R at the > end, even if the "don't care" bit is set. > > try4: Formatting changes suggested by Dmitry Timoshkov How abot the casts? And spacing is still not consitent. -- Dmitry.

2 4

Getting Wine's PO files on Launchpad
by Francois Gouget Jan. 20, 2012

Jan. 20, 2012

Launchpad has a PO file translation website. This makes it easier for non-developpers to contribute and review translations. https://translations.launchpad.net/ So what would it take to get Wine's PO files on Launchpad? * Launchpad tracks who translated what string and if we choose the 'Closed' permissions model only approved translators can update the translations. So that means we should be able to get patches with full attribution. https://help.launchpad.net/Translations/YourProject/PermissionPolicies * Launchpad would need to pull updated PO files from Wine regularly. Ideally that would be automatic and happen daily (both to account for translations happening outside Launchpad and to take changes in the resource files into account quickly). https://help.launchpad.net/Translations/YourProject/ImportingTranslations * Conversely Launchpad should submit patches back to Wine. Ideally that would be automated as much as possible but I'm fuzzy on the details here (especially on how to preserve attribution). As for the periodicity, maybe the best would be weekly or just before Alexandre makes a release. https://help.launchpad.net/Translations/YourProject/Exports https://help.launchpad.net/Translations/YourProject/PartialPOExport -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

8 10

Major mmdevapi and winmm audio bugs
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 20, 2012

Jan. 20, 2012

Hi, Again, the list is quite different from what I posted last month, partly because of a shift in focus. The good news is: judging from bugzilla, audio seems to work much better since 1.3.36/37. #29294 no sound with ALSA loopback #28781 loopback to Jack It is not acceptable for winealsa to solely know "default" and "hw:x,y". The user can define and use any other name in the asound.conf files. The old winealsa obeyed registry settings to override the card name(s). IMHO, winealsa MUST provide such an override. It is not acceptable to replace "default" in dlls/winealsa.drv/mmdevdrv.c and recompile. Furthermore, it was trivial with old winecfg to disable sound in a compatible manner (= answers to API functions like from a native box without sound). What to do now? WINEDEBUG=mmdevapi= is not compatible. W.r.t. configuration, what is the now recommended way for users to self-diagnose MIDI issues? In the ancient winecfg audio tab, Wine would list their MIDI devices in device order, as I explained in http://wiki.winehq.org/MIDI Now users don't know what Wine chooses. #8054 asked in 2007 already for an option to select the default MIDI device via winecfg (achievable via MIDIMap registry entry) #29299 need to play leading/trailing silence for ALSA block-oriented devices That takes various forms and can cause any affected app to hang. #28273 handle "worst case little prefill/underrun" scenario well #28039 MacOS GetPosition #29657 MacOS memory management and dead-lock #29585 OSS needs to be updated to be on par with ALSA refinements #29305 one winmm device seems to stomp over the data of another one #28388 Avoid SuspendThread, should be easy for me to fix, given time There are issues not associated with a bug entry: - Add run-time consistency checks in renderer and abort audio stream (GetBuffer) upon trouble instead of hanging. - perhaps use AUDCLNT_E_DEVICE_INVALIDATED when we see PA restarted and have our DSound and winmm deal with that return code (Would that help #29369?) - Mixer/Card recognition of some ALSA devices - Check OSS4 with and without vmix #28056 #28790 - Investigate OSS4 underrun behaviour - Check WHDR_BEGIN/ENDLOOP code and write tests (I know at least one bug involving waveOutBreakLoop) - DSound still bears traces of its former dependency on winmm blocks, not adequate with mmdevapi - semantics of DSound GetPosition Winealsa's initial scanning of devices and the enumeration tests do not produce reliable results because some high-level ALSA devices like to cling to the underlying one for a couple of seconds. Hence, accessing "default" (routed to pulse) may block "hw:0" for ~3 seconds. Of course there are more bugs than this. Regards, Jörg Höhle

2 1

Re: (try 3)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate
by Dmitry Timoshkov Jan. 20, 2012

Jan. 20, 2012

Aric Stewart <aric(a)codeweavers.com> wrote: > + char* idx = strrchr(name,'_'); > + if (idx) > + { > + if (strcasecmp(idx,"_r")==0 || strcasecmp(idx,"_l")==0) > + { > + INT rc = 0; > + TRACE("found scan=%04x keyc=%u keysym=%04x modified_string=%s\n", > + scanCode, keyc, (int)keys, debugstr_an(name,idx-name)); > + if (lpBuffer && nSize) > + { > + rc = MultiByteToWideChar(CP_UNIXCP, 0, name, idx-name, lpBuffer, nSize); Using consistent spacing and avoiding not necessary casts would improve the readability a bit. -- Dmitry.

1 0

Re: mmcndmgr: Implement IMMCVersionInfo
by Alistair Leslie-Hughes Jan. 20, 2012

Jan. 20, 2012

Ignore this. On 20/01/2012 9:32 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mmcndmgr: Implement IMMCVersionInfo > > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: kernel32: add stubs for GetConsoleCommandHistoryLengthA/W
by Dmitry Timoshkov Jan. 20, 2012

Jan. 20, 2012

Austin English <austinenglish(a)gmail.com> wrote: > +DWORD WINAPI GetConsoleCommandHistoryLengthA(LPSTR unknown) > +{ > + FIXME(": (%s) stub!\n", unknown); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return 0; > +} > + > +/* Undocumented, called by native doskey.exe */ > +/* FIXME: Should use CONSOLE_GetHistory() above for full implementation */ > +DWORD WINAPI GetConsoleCommandHistoryLengthW(LPWSTR unknown) > +{ > + FIXME(": (%s) stub!\n", wine_dbgstr_w(unknown)); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return 0; > +} It's a common rule that contents of non-const (string) parameters (which are probably the output ones) should not be printed in traces, and their type in the .spec files can't be (w)str. Same belongs to your other patches. -- Dmitry.

1 0

Re: richedit: v1.0 richedit uses CR and LF for enter
by Juan Lang Jan. 19, 2012

Jan. 19, 2012

Hi Jason, + ME_InsertTextFromCursor(editor, 0, &endlv10[0], 2, style); you want to use endlv10 instead, i.e.: + ME_InsertTextFromCursor(editor, 0, endlv10, 2, style); --Juan

3 6

Re: [2/2] mshtml: Forward SID_SContainerDispatch from a script host
by Jacek Caban Jan. 19, 2012

Jan. 19, 2012

Hi Nikolay, On 01/18/12 23:18, Nikolay Sivov wrote: > Forward SID_SContainerDispatch from a script host Please add a test. Jacek

1 0

Re: [1/2] mshtml: Respond to SID_SContainerDispatch service id
by Jacek Caban Jan. 19, 2012

Jan. 19, 2012

Hi Nikolay, On 01/18/12 23:18, Nikolay Sivov wrote: > Respond to SID_SContainerDispatch service id + if(IsEqualGUID(&SID_SContainerDispatch, guidService)) { + TRACE("SID_SContainerDispatch\n"); + return IHTMLDocument2_QueryInterface(&This->IHTMLDocument2_iface, riid, ppv); + } Your test suggests that it's a wrong object to return. It may be acceptable if native returns this object as well, with just wrapped interface, but we need test for it. Jacek

1 0

Re: [PATCH 3/3] d3d9/tests: More D3DTSS_TEXTURETRANSFORMFLAGS projection tests.
by Saulius Krasuckas Jan. 18, 2012

Jan. 18, 2012

* On Tue, 27 Dec 2011, Matteo Bruni wrote: > --- > dlls/d3d9/tests/visual.c | 388 ++++++++++++++++++++++++++++++++-------------- > 1 files changed, 269 insertions(+), 119 deletions(-) Hello Matteo, this is http://source.winehq.org/git/wine.git/commitdiff/8dee7989f242b8ea624abc3b1f… The patch removed 6 failures on XP on real hardware (nVidia FX5200): http://test.winehq.org/data/18c20964e1e22f9aa974cc774bf77da6fc013716/xp_s2-… visual.c:4057: Test failed: proj: Pixel 162/122 has color 0x00000000, expected 0x00FFFFFF visual.c:4062: Test failed: proj: Pixel 158/178 has color 0x00000000, expected 0x00FFFFFF visual.c:4069: Test failed: proj: Pixel 318/118 has color 0x00ffffff, expected 0x00000000 visual.c:4071: Test failed: proj: Pixel 322/118 has color 0x00ffffff, expected 0x00000000 visual.c:4075: Test failed: proj: Pixel 322/122 has color 0x00ffffff, expected 0x00000000 visual.c:4078: Test failed: proj: Pixel 318/178 has color 0x00000000, expected 0x00FFFFFF and introduced 14 new ones: http://test.winehq.org/data/277361d7be206e1ff7634998f0d750f7c6d66498/xp_s2-… visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (401, 361) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (401, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (481, 359) has color 00ffffff, expected 00000000 visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (481, 361) has color 00ffffff, expected 00000000 visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (479, 359) has color 00ffffff, expected 00000000 visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (479, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (401, 361) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (401, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (479, 361) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (479, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (81, 121) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (81, 179) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (159, 121) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (159, 179) has color 00000000, expected 00ffffff The same machine running Win7 didn't exhibit any changes: http://test.winehq.org/data/18c20964e1e22f9aa974cc774bf77da6fc013716/win7_s… http://test.winehq.org/data/277361d7be206e1ff7634998f0d750f7c6d66498/win7_s… This probably has something to do with older nVidia driver version being used on Win7 - v96.85 - than the version used on XP - v163.75 . But on Win7 somewhat similar change is seen on virtual machine from Francois, only the failure count increases by 28 here: http://test.winehq.org/data/18c20964e1e22f9aa974cc774bf77da6fc013716/win7_f… http://test.winehq.org/data/277361d7be206e1ff7634998f0d750f7c6d66498/win7_f… Would you mind fixing this please:)? S.

2 1

Re: Debugging Wine with Lightroom 3.5
by Joris Huizer Jan. 18, 2012

Jan. 18, 2012

Replying, also including the wine-devel list, On 12/17/2011 05:15 PM, Roland Baudin wrote: > Hi, > > thanks for the answer. > What do you mean by "a different execution path"? > RB The application might decide to execute different code given the Vista settings. It may have a preferred execution path using certain functionality only available for Vista/Windows 7, and a fallback path for XP. Pseudocode: if (system is Vista+) use_builtin_functionality(); else /* XP */ use_fallback_mechanism(); HTH, Joris

5 7

Re: winex11.drv: Strip the _XXX from X11DRV_GetKeyNameText when approperate
by Vitaliy Margolen Jan. 18, 2012

Jan. 18, 2012

On 01/17/2012 09:32 AM, Aric Stewart wrote: > > The problem is that there is no XK keycode for just Shift, Control or Menu > so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result the string > XKeysymToString returns is a string with a _L or _R at the end, even if the > "don't care" bit is set. > + char *new_name; > + INT rc = 0; > + new_name = HeapAlloc(GetProcessHeap(),0,(idx-name)+1); > + lstrcpynA(new_name,name,(idx-name)+1); > + new_name[idx-name] = 0; > + TRACE("found scan=%04x keyc=%u keysym=%04x new_string=%s\n", > + scanCode, keyc, (int)keys, new_name); > + if (lpBuffer && nSize) > + rc = MultiByteToWideChar(CP_UNIXCP, 0, new_name, -1, lpBuffer, nSize); > + HeapFree(GetProcessHeap(),0,new_name); > + return rc; I don't think you need an extra buffer. Just do something like: if (lpBuffer && nSize) { rc = MultiByteToWideChar(CP_UNIXCP, 0, new_name, idx - name, lpBuffer, nSize); if (nSize > idx - name) lpBuffer[idx - name] = 0; } Of course need to account for rc. Vitaliy

2 1

Re: comdlg32: Remove the font sample characters string.
by Frédéric Delanoy Jan. 18, 2012

Jan. 18, 2012

On Wed, Jan 18, 2012 at 10:12, Francois Gouget <fgouget(a)free.fr> wrote: > The sample text does not depend on the dialog language but on the scripts supported by the font. As such translating it in the resource file makes no sense. > - CTEXT "AaBbYyZz",stc5,103,80,109,24,SS_NOPREFIX | NOT WS_VISIBLE > + CTEXT "",stc5,103,80,109,24,SS_NOPREFIX | NOT WS_VISIBLE Actually it's used to show a sample in the font picker (e.g. with wordpad do Format > Font). I translated it in French using most common/representative French characters (including accentuated letters). I wouldn't remove it, but rather add a message context clarifying what its purpose is. If the sample text does not depend on the dialogue language, that's what should be done instead IMHO Frédéric

3 4

Re: po: French translation updates.
by Frédéric Delanoy Jan. 18, 2012

Jan. 18, 2012

On Tue, Jan 17, 2012 at 23:11, Francois Gouget <fgouget(a)free.fr> wrote: > @@ -9335,7 +9335,7 @@ msgstr "" > "[nomFichier]\n" > " [/S [/D]]\n" > "\n" >-"où\n" >+"Où :\n" > "\n" > " + Définit un attribut.\n" > " - Supprime un attribut.\n" >@@ -10234,7 +10234,7 @@ msgstr "" > " -ou-\n" > "NET commande /HELP\n" > "\n" >-"où « commande » peut être HELP, START, STOP ou USE.\n" >+"Où « commande » peut être HELP, START, STOP ou USE.\n" > > #: net.rc:28 > msgid "" >@@ -10264,7 +10264,7 @@ msgstr "" > "\n" > "NET STOP service\n" > "\n" >-"où « service » est le nom du service à arrêter.\n" >+"Où « service » est le nom du service à arrêter.\n" I'm not convinced by the capitalization of "où" where placed kind of in the middle of the "flow" of a sentence. There's hardly ever an uppercase letter in French for normal words in the middle of a sentence (unlike in English). Now, if you wanted to add a ':' as is done in English, I find this is rather a problem with the English version which shouldn't contain a colon to begin with (that's juste noise IMHO). Frédéric N.B.: review/reply would be easier if you inlined your patch instead of an attachment

2 1

Re: gdi32:Add EnhMetafile PolyBezier,PolyBezierTo support (try 2)
by Dmitry Timoshkov Jan. 18, 2012

Jan. 18, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Added tests. > > Changelog: > gdi32: Add EnhMetafile PolyBezier,PolyBezierTo support Please add an EMF test which uses compare_emf_bits() instead. -- Dmitry.

1 0

Re: ntoskrnl.exe: add a stub for IoCreateSynchronizationEvent
by Dmitry Timoshkov Jan. 18, 2012

Jan. 18, 2012

Austin English <austinenglish(a)gmail.com> wrote: > +PKEVENT WINAPI IoCreateSynchronizationEvent(PUNICODE_STRING name, PHANDLE handle) > +{ > + FIXME("(%p %p) stub\n", name, handle); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return NULL; > +} NT APIs are not supposed to set last error. -- Dmitry.

1 0