January 2012 - Wine-Devel - list.winehq.org

Re: jscript: Fixed continue inside for..in statement
by Marvin Jan. 10, 2012

Jan. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16361 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: gdi32: GetGlyphIndices doesn't substitute glyph.
by Marvin Jan. 10, 2012

Jan. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16359 Your paranoid android. === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: [PATCH] programs/explorer: Fix explorer's command line parsing (try 2)
by Vitaliy Margolen Jan. 10, 2012

Jan. 10, 2012

On 01/08/2012 08:45 PM, Jay Yang wrote: > Fixed some small formatting issues from last time. > Your patch strips spaces all over the place. For example: + LPWSTR *argv; + if(commandline[0]=='\0') Need an empty line after variable declarations. No space after "if". No space around equal operator. + for(i=0;i<argc;i++) No spaces after semi-colon. + copy_path_string(parameters->root,curr); No space after coma. Some other issues - you will parse over parameters given to the program. Ex: explorer /desktop=foo,800x600 program.exe /n /e Parsing inside parameters is incorrect: + LPWSTR end=strchrW(curr,','); + LPWSTR next; + if(end==NULL) + next=(end=strchrW(curr,'\0')); + else + next=end+1; ... + curr=next; You end up parsing something like this as a valid param: /n,/e,/select,c:\\ Vitaliy.

2 2

Re: [4/5] dinput: Device username being assigned at creation time (try 2)
by Vitaliy Margolen Jan. 10, 2012

Jan. 10, 2012

On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki<lfzawacki(a)gmail.com> You leaking FindFile handle. Need to use FindClose() to close it. This is on top of more unchecked returns from HappAlloc. Vitaliy.

1 0

Re: [3/5] dinput: SetActionMap setting username
by Vitaliy Margolen Jan. 10, 2012

Jan. 10, 2012

On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki<lfzawacki(a)gmail.com> > > + /* Set username in device */ > + HeapFree(GetProcessHeap(), 0, This->username); > + This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(username) + 1)); > + lstrcpyW(This->username, username); No error checking if allocation fails. > + > + /* Free username */ > + HeapFree(GetProcessHeap(), 0, This->username); > + Comment is kind of redundant the property already called "username". Vitaliy.

1 0

UTF-7
by Alex Henrie Jan. 10, 2012

Jan. 10, 2012

Hello, I have been thinking about implementing UTF-7 support in MultiByteToWideChar and WideCharToMultiByte. The guts of the code that needs to be added have already been posted to bug 27388. What more needs to be done? Should a libs/wine/utf7.c file be created for the new functions, similar to libs/wine/utf8.c? -Alex

1 0

Re: [1/5] dinput: Added DI_SETTINGSNOTSAVED flag
by Francois Gouget Jan. 9, 2012

Jan. 9, 2012

On Mon, 9 Jan 2012, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > --- > include/dinput.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/dinput.h b/include/dinput.h > index 353ec55..cf99ecc 100644 > --- a/include/dinput.h > +++ b/include/dinput.h > @@ -134,6 +134,7 @@ DECL_WINELIB_TYPE_AW(LPDIRECTINPUTDEVICE8) > #define DI_DOWNLOADSKIPPED ((HRESULT)0x00000003) > #define DI_EFFECTRESTARTED ((HRESULT)0x00000004) > #define DI_TRUNCATED ((HRESULT)0x00000008) > +#define DI_SETTINGSNOTSAVED ((HRESULT)0x0000000BL) > #define DI_TRUNCATEDANDRESTARTED ((HRESULT)0x0000000C) I'm not sure the 'L' modifier is needed or makes sense (although the PSDK does have it). In anycase there's clearly an inconsistency in the above patch and we normally avoid the 'L' modifier nowadays, see for instance __MSABI_LONG() in include/ddeml.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [6/6] d3drm: Implement GetParent
by Nikolay Sivov Jan. 9, 2012

Jan. 9, 2012

On 1/8/2012 20:47, André Hentschel wrote: > --- > dlls/d3drm/frame.c | 11 +++++++---- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > 2 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c > index 212f7dd..b72700c 100644 > --- a/dlls/d3drm/frame.c > +++ b/dlls/d3drm/frame.c > @@ -33,6 +33,7 @@ typedef struct { > IDirect3DRMFrame2 IDirect3DRMFrame2_iface; > IDirect3DRMFrame3 IDirect3DRMFrame3_iface; > LONG ref; > + LPVOID parent; > } IDirect3DRMFrameImpl; Parent is store as another frame interface pointer, right? Why void* here? > > static const struct IDirect3DRMFrame2Vtbl Direct3DRMFrame2_Vtbl; > @@ -336,9 +337,10 @@ static HRESULT WINAPI IDirect3DRMFrame2Impl_GetParent(IDirect3DRMFrame2* iface, > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > > - FIXME("(%p/%p)->(%p): stub\n", iface, This, frame); > + TRACE("(%p/%p)->(%p)\n", iface, This, frame); > > - return E_NOTIMPL; > + *frame = This->parent; > + return D3DRM_OK; > } What looks suspicious is reference counting handling, or absence of it in other words. I'm not familiar with d3d, but this needs tests for parent refcount - is it increased when it's stored? is it properly freed? is it increased after GetParent()?

3 5

Re: [PATCH 1/6] ieframe: Added support for SID_SHTMLWindow in WebBrowser::QueryService
by Marvin Jan. 9, 2012

Jan. 9, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16341 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3170: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2754: Test failed: expected TranslateUrl webbrowser.c:2755: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2756: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2762: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3129: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2847: Test failed: expected RequestUIActivate webbrowser.c:2939: Test failed: Got 0x80004002 webbrowser.c:3137: Test failed: doc != doc2 webbrowser.c:3034: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040CB02

1 0

Re: user32: Add GetListBoxInfo
by Nikolay Sivov Jan. 9, 2012

Jan. 9, 2012

On 1/9/2012 01:28, Louis Lenders wrote: > This should fix http://bugs.winehq.org/show_bug.cgi?id=27385 > > (See also Remarks on http://msdn.microsoft.com/en-us/library/windows/desktop/bb775208%28v=vs.85%… : This message is equivalent to GetListBoxInfo. > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > + TRACE("(%p)\n", hwnd); > + return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} > + Please add a test showing that it really sends a message.

1 0

Re: user32: Add GetListBoxInfo
by Dmitry Timoshkov Jan. 9, 2012

Jan. 9, 2012

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > + TRACE("(%p)\n", hwnd); > + return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} The spacing is not consistent. > -# @ stub GetListBoxInfo > +@ stdcall GetListBoxInfo(ptr) Please have a look at other user32 spec file entries for correct type for a window handle. -- Dmitry.

1 0

Re: [4/4] shell32: Fix SHLoadInProc() return value
by Marvin Jan. 8, 2012

Jan. 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16325 Your paranoid android. === W2KPROSP4 (32 bit shellole) === shellole.c:452: Test failed: got 0x80040111 === WVISTAADM (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W2K8SE (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W7PRO (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W7PROX64 (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === TEST64_W7SP1 (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W7PROX64 (64 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === TEST64_W7SP1 (64 bit shellole) === shellole.c:452: Test failed: got 0x80004001

1 0

Re: d3drm/tests: Add IDirect3DRM3 tests
by Marvin Jan. 6, 2012

Jan. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16297 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:145: Test failed: Cannot get IDirect3DRM3 interface (hr = 80040111) d3drm: unhandled exception c0000005 at 0040184F

1 0

Re: [1/2] d3drm: Partial implementation for [Add/Delete]Child
by Henri Verbeet Jan. 6, 2012

Jan. 6, 2012

2012/1/6 André Hentschel <nerv(a)dawncrow.de>: > @@ -212,10 +216,15 @@ static HRESULT WINAPI IDirect3DRMFrame2Impl_AddChild(IDirect3DRMFrame2* iface, > LPDIRECT3DRMFRAME child) > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > + IDirect3DRMFrameImpl *Frame = impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child); That looks pretty questionable, but some tests would probably be a good thing either way.

1 0

Re: [2/4] d3drm: Forward GetTextureCoordinates from IDirect3DRMMeshBuilder3 to IDirect3DRMMeshBuilder2
by Henri Verbeet Jan. 6, 2012

Jan. 6, 2012

2012/1/6 André Hentschel <nerv(a)dawncrow.de>: > - > - FIXME("(%p)->(%d,%p,%p): stub\n", This, index, u, v); > - > - return E_NOTIMPL; > + return IDirect3DRMMeshBuilder_GetTextureCoordinates(&This->IDirect3DRMMeshBuilder2_iface, > + index, u, v); > } I'm not going to say you can't do it like this, but it can often be pretty useful to know what version of an interface you were called from. Also, usually we implement older versions of interfaces on top of the new ones, instead of the other way around.

2 1

Re: [PATCH 4/5] ieframe: Added IHTMLWindow2 service tests
by Marvin Jan. 6, 2012

Jan. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16291 Your paranoid android. === WNT4WSSP6 (32 bit ie) === ie.c:78: Test failed: Could not create InternetExplorer instance: 80040154

2 1

Re: msvcp90: add basic_ios<wchar_t> stubs
by Piotr Caban Jan. 6, 2012

Jan. 6, 2012

On 01/05/12 22:41, Daniel Lehman wrote: +/* ?imbue@?$basic_ios(a)_WU?$char_traits(a)_W@std@@@std@@QAE?AVlocale(a)2@ABV32@@Z */ +/* ?imbue@?$basic_ios(a)_WU?$char_traits(a)_W@std@@@std@@QEAA?AVlocale(a)2@AEBV32@@Z */ +DEFINE_THISCALL_WRAPPER(basic_ios_wchar_imbue, 4) +locale __thiscall basic_ios_wchar_imbue(basic_ios_wchar *this) +{ + locale ret = { NULL }; + FIXME("(%p) stub\n", this); + return ret; +} This should look like: locale* __thiscall basic_ios_wchar_imbue(basic_ios_wchar *this, locale *ret) there's similar mistake in basic_ios_char_imbue.

1 0

Re: mshtml: Remove unused definitions
by Jacek Caban Jan. 6, 2012

Jan. 6, 2012

Hi André, On 01/05/12 19:35, André Hentschel wrote: > --- > dlls/mshtml/resource.h | 17 ----------------- > 1 files changed, 0 insertions(+), 17 deletions(-) > > diff --git a/dlls/mshtml/resource.h b/dlls/mshtml/resource.h > index 50342a2..a798760 100644 > --- a/dlls/mshtml/resource.h > +++ b/dlls/mshtml/resource.h > @@ -38,23 +38,6 @@ > > #define IDR_BROWSE_CONTEXT_MENU 24641 > > -#define IDM_TRACETAGS 6004 > -#define IDM_RESOURCEFAILURES 6005 > -#define IDM_DUMPTRACKINGINFO 6006 > -#define IDM_DEBUGBREAK 6007 > -#define IDM_DEBUGVIEW 6008 > -#define IDM_DUMPTREE 6009 > -#define IDM_DUMPLINES 6010 > - > -#define IDM_SAVEHTML 6012 > -#define IDM_MEMORYMONITOR 6013 > -#define IDM_PERFORMANCEMETERS 6014 > -#define IDM_DUMPDISPLAYTREE 6015 > -#define IDM_DUMPFORMATCACHES 6016 > -#define IDM_DUMPLAYOUTRECTS 6017 > - > -#define _IDM_REFRESH 6042 > - > #define IDD_HYPERLINK 8000 > > #define IDC_URL 9001 > These defines are for stuff that is in shdoclc and mshtml uses these resources. Although we currently don't use them currently, ideally we should implement them. It doesn't make sense to remove them now and add back in the future. Jacek

1 0

Re: [PATCH 2/2] winmm/tests: Test some inconsistent WAVEFORMAT descriptions.
by Marvin Jan. 6, 2012

Jan. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16276 Your paranoid android. === WVISTAADM (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W2K8SE (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W7PRO (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W7PROX64 (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === TEST64_W7SP1 (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W7PROX64 (64 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === TEST64_W7SP1 (64 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.)

2 1

Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/ddraw/tests/ddraw1.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw2.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw4.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw7.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 866 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. make: *** [ddraw1.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

Any bad side-effects from not building with HAL if udisks is enabled?
by Scott Ritchie Jan. 5, 2012

Jan. 5, 2012

Assuming udisks support exists on the system, anything wrong with this? Does the new udisks do everything HAL used to do? Thanks, Scott Ritchie

2 2

Re: msvcrt: make WEOF returned from swscanf signed (try 2)
by Marvin Jan. 5, 2012

Jan. 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16280 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === WVISTAADM (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === W2K8SE (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === W7PRO (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === W7PROX64 (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === TEST64_W7SP1 (32 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === W7PROX64 (64 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff === TEST64_W7SP1 (64 bit msvcr90) === msvcr90.c:1149: Test failed: swscanf returns 0 instead of ffff

1 0

D3DXHANDLE for ID3DXConstantTable
by Rico Schüller Jan. 5, 2012

Jan. 5, 2012

Hi, I'd like to get up the discussion for the D3DXHANLE in the ID3DXConstantTable again. There were several tries in the past, but there wasn't made a decision for one solution. My opinion about the handles is, that they have to allow at least the following options: 1. D3DXHANDLEs have to be global (not local to a ID3DXConstantTable), so the way the effect interface does it is not an ideal option for the ID3DXConstantTable 2. D3DXHANDLEs could also be strings and thus it is a requirement that this could be detected (at least for !D3DXCONSTTABLE_LARGEADDRESSAWARE) Ideally we may handle all D3DXHANDLEs the same way. Some possible solutions are listed in [3]. Any thoughts which way is preferred? Cheers Rico References: [1] http://www.winehq.org/pipermail/wine-devel/2010-April/082900.html [2] http://www.winehq.org/pipermail/wine-patches/2011-July/104325.html [3] http://www.winehq.org/pipermail/wine-devel/2011-July/091091.html

2 8

Re: [PATCH] msvcp60: Avoid a crash, when the ptr in basic_string_char is NULL
by Piotr Caban Jan. 5, 2012

Jan. 5, 2012

Hi, > void __thiscall basic_string_char__Eos(basic_string_char *this, MSVCP_size_t len) > { > - this->size = len; > - this->ptr[len] = 0; > + if (this->ptr) { > + this->size = len; > + this->ptr[len] = 0; > + } > } This function should not be called if this->ptr is NULL. The bug is somewhere else. I'll take a look on it. Do you have a backtrace? Piotr

1 0

Re: msvcrt: make WEOF returned from swscanf signed
by Marvin Jan. 5, 2012

Jan. 5, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16267 Your paranoid android. === WNT4WSSP6 (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === W2KPROSP4 (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === WXPPROSP3 (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === W2K3R2SESP2 (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === WVISTAADM (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === W2K8SE (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === W7PRO (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === W7PROX64 (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === TEST64_W7SP1 (32 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === W7PROX64 (64 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff === TEST64_W7SP1 (64 bit scanf) === scanf.c:257: Test failed: sscanf returns 0 instead of ffff

2 1

FYI: Pangolin script needs libfreeytype6-dev:386 but it cannot be installed
by Susan Cragin Jan. 4, 2012

Jan. 4, 2012

The configure script seems to be looking for libfreetype6-dev:386 but this cannot be installed without removing the compilers and other files Should I alert Ubuntu? Isn't this their problem? Susan

2 1

Re: po: Update Italian translation
by Matteo Bruni Jan. 4, 2012

Jan. 4, 2012

2012/1/4 Luca Bennati <lucak3(a)gmail.com>: > > > #: winmm.rc:34 > -#, fuzzy > msgid "There is no driver installed on your system!" > -msgstr "Non è stato installato nessun driver nel sistema !\n" > +msgstr "Non è presente nessun driver installato nel sistema!" Hi Luca, While your new translation is clearer than the previous one, I think in the new translation "presente" and "installato" mean more or less the same thing i.e. having both is redundant IMO. How about something like "Nessun driver è installato nel sistema!" (or "presente", or "attualmente installato"... you got it) instead?

1 0

Re: imm32: add a stub for ImmGetHotKey
by Dmitry Timoshkov Jan. 4, 2012

Jan. 4, 2012

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI ImmGetHotKey(DWORD hotkey, UINT modifiers, UINT VKey, HKL hKL) What SDK/MSDN version does this match? Also please avoid using hungarian or capitalized variable names in Wine. > +@ stdcall ImmGetHotKey(long ptr ptr long) This doesn't match the implementation. -- Dmitry.

1 0

Re: [PATCH 2/7] wined3d: Move srgb checks away from d3dfmt_get_conv.
by Diego Nieto Cid Jan. 4, 2012

Jan. 4, 2012

Hi, I beleive this patch introduced some kind of regression. While testing Fallout the following message was printed to the screen: trace:d3d_surface:surface_allocate_surface (0x1a25f0) : Creating surface (target 0xde1) level 0, d3d format WINED3DFMT_P8_UINT, internal format 0x80e5, width 1024, height 512, gl format 0x1908, gl type=0x1401 err:d3d_surface:surface_allocate_surface >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glTexImage2D @ surface.c / 2571 Internal format 0x80e5 (GL_COLOR_INDEX8_EXT) is not valid for the format 0x1908 (GL_RGBA). Initially, the surface's format is 0x1900 (GL_COLOR_INDEX) which is compatible with the internal format above. On Thu, Apr 08, 2010 at 10:49:46PM +0200, Roderick Colenbrander wrote: > [...] > @@ -1553,7 +1581,7 @@ void surface_prepare_texture(IWineD3DSurfaceImpl *surface, const struct wined3d_ > > if (surface->Flags & alloc_flag) return; > > - d3dfmt_get_conv(surface, TRUE, TRUE, &desc, &convert, srgb); > + d3dfmt_get_conv(surface, TRUE, TRUE, &desc, &convert); > if(convert != NO_CONVERSION) surface->Flags |= SFLAG_CONVERTED; > else surface->Flags &= ~SFLAG_CONVERTED; > > @@ -1569,7 +1597,7 @@ void surface_prepare_texture(IWineD3DSurfaceImpl *surface, const struct wined3d_ > } > > surface_bind_and_dirtify(surface, srgb); > - surface_allocate_surface(surface, gl_info, &desc, width, height); > + surface_allocate_surface(surface, gl_info, &desc, srgb, width, height); > surface->Flags |= alloc_flag; > } > However before surface_allocate_surface is called d3dfmt_get_conv which translates the format to GL_RGBA. But the internal format remains in an incompatible value due to a reordering of the instructions which was introduced by the patch. On Thu, Apr 08, 2010 at 10:49:46PM +0200, Roderick Colenbrander wrote: > [...] > @@ -2126,18 +2153,6 @@ HRESULT d3dfmt_get_conv(IWineD3DSurfaceImpl *This, BOOL need_alpha_ck, BOOL use_ > *desc = *This->resource.format_desc; > *convert = NO_CONVERSION; > > - /* TODO: the caller should perform this check */ > - if(srgb_mode) { > - desc->glInternal = glDesc->glGammaInternal; > - } > - else if (This->resource.usage & WINED3DUSAGE_RENDERTARGET > - && surface_is_offscreen((IWineD3DSurface *) This)) > - { > - desc->glInternal = glDesc->rtInternal; > - } else { > - desc->glInternal = glDesc->glInternal; > - } > - > /* Ok, now look if we have to do any conversion */ > switch(This->resource.format_desc->format) > { Before applying the changes the processing of srgb_mode was done inside d3dfmt_get_conv. Depending on the value of this variable one of glGammaInternal, rtInternal or glInternal was used. But those values were overriden because the conversion was applied afterwards. On Thu, Apr 08, 2010 at 10:49:46PM +0200, Roderick Colenbrander wrote: > [...] > @@ -783,11 +797,25 @@ static void surface_upload_data(IWineD3DSurfaceImpl *This, const struct wined3d_ > * the correct texture. */ > /* Context activation is done by the caller. */ > static void surface_allocate_surface(IWineD3DSurfaceImpl *This, const struct wined3d_gl_info *gl_info, > - const struct wined3d_format_desc *format_desc, GLsizei width, GLsizei height) > + const struct wined3d_format_desc *format_desc, BOOL srgb, GLsizei width, GLsizei height) > { > BOOL enable_client_storage = FALSE; > const BYTE *mem = NULL; > - GLenum internal = format_desc->glInternal; > + GLenum internal; > + > + if (srgb) > + { > + internal = format_desc->glGammaInternal; > + } > + else if (This->resource.usage & WINED3DUSAGE_RENDERTARGET > + && surface_is_offscreen((IWineD3DSurface *)This)) > + { > + internal = format_desc->rtInternal; > + } > + else > + { > + internal = format_desc->glInternal; > + } > > if (format_desc->heightscale != 1.0f && format_desc->heightscale != 0.0f) height *= format_desc->heightscale; > After the change was applied the result of the conversion done inside d3dfmt_get_conv only takes effect in the else branch of srgb processing. The following code is the conversion involved in this particular test case. format->glFormat = GL_RGBA; format->glInternal = GL_RGBA; format->glType = GL_UNSIGNED_BYTE; format->conv_byte_count = 4; It's located in d3dfmt_get_conv under the WINED3DFMT_P8_UINT case. For some reason only glInternal is updated by the conversion. In any case it didn't matter before the patch as none of the internal values were actually used in case a conversion was applied. Should the three internal values be updated by the conversion now that any of them could be used? Even if it would work I'm not sure how correct would be to do that. Could some wined3d developer review the patch with all this in mind? Thanks!

2 5

Re: [PATCH 1/6] [lib/port]: Added a unicode POSIX compliant regular expression library
by Alexandre Julliard Jan. 3, 2012

Jan. 3, 2012

Eric Pouech <eric.pouech(a)orange.fr> writes: > A+ > --- > > include/wine/regexw.h | 66 ++++++ > libs/port/Makefile.in | 1 > libs/port/regexw.c | 513 +++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 580 insertions(+), 0 deletions(-) > create mode 100644 include/wine/regexw.h > create mode 100644 libs/port/regexw.c I still think dbghelp should do its own regexp matching. It's not hard to do, and it would avoid the ugly regexp munging we have now. We don't really need a Posix compliant regexp. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH RFC 4/5] dsound: Clean up channels
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 3, 2012

Jan. 3, 2012

Alexander, You want to google the paper titled "Defining speaker locations in multi-channel streams and WDM audio drivers using the WAVEFORMATEXTENSIBLE structure" by Carsten Schulz to learn a lot about channel mapping as performed by w2k. It's a pity there's nothing like it for xp or w7! Wine's mmdevapi does not yet behave like native's 5:1 cards. People have sent me the following mmdevapi:render test data on native machines: render.c:182: chan: 6 render.c:183: rate: 48000 render.c:184: align: 24 render.c:191: Mask: 3f IOW, the system's mixer format is really 6 channels! There presumably, DSound sends stereo and 6 channel data to the mixer. I suppose MS evolved DSound's mixer into mmdevapi's one, with some lessons learned. BTW, as I'm not aware of a means to extract from ALSA the user's speaker configuration, Wine likely needs either a winecfg setting (like MS' system preferences) or a registry key to advertize the mixer's dwChannelMask (and default to 0x3f with 6 channels). Regards, Jörg Höhle

1 0

new d3d9/device.ok test always fails here, but not a regression?
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 3, 2012

Jan. 3, 2012

Hi, > Bugs in newly added code cannot be regressions. > > Similarly, if we add a dll and some app starts using it and breaks, > technically that's not a regression even though the behavior got worse, > because it has always been broken, it just wasn't exercised before. What does this distinction bring us? The old definition, "if it worked in version N and doesn't in N+1, then it is a regression" was straightforward and easy to understand. There was little to debate, no room left for confusion. Every such regression could be associated with the SHA1 of a commit. The new definition can get arbitrarily complex. Consider bug #19496. Bug resolution likely involves moving from mciwave to mciavi. As mciavi is not equally advanced, this move will likely cause bugs to appear in other apps. But we wouldn't call them regressions "because it has always been broken"?!? That makes no sense to users. What benefit does it have for developers? Having one's name appear less often in source.winehq.org/regressions when doing The Right Thing (TRT)? Regards, Jörg Höhle

5 5

Re: mscoree: Implement CLRRuntimeHost_ExecuteInDefaultAppDomain
by Vincent Povirk Jan. 3, 2012

Jan. 3, 2012

Cool! Looks good to me. On Tue, Jan 3, 2012 at 4:23 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > mscoree: Implement CLRRuntimeHost_ExecuteInDefaultAppDomain > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

new d3d9/device.ok test always fails here, but not a regression?
by Dan Kegel Jan. 3, 2012

Jan. 3, 2012

Happy New Year's Eve, everyone! 002447357c2b1feca5ef2649429fc55f70238901 added a IDirect3DDevice9::SetCursorPosition() test to d3d9. That test never worked here, I think. I filed http://bugs.winehq.org/show_bug.cgi?id=29094 for it, and marked it as a regression (since tests/device.c used to pass, but fails here after that commit). Henri removed the regression keyword and sha1sum without comment. What's the reasoning there? Is Henri saying there's something wrong with my test setup (stock ubuntu), or are new tests that cause 'make test' to fail not considered regressions? Or something else?

4 6

Re: [PATCH 3/5] d3d10/tests: Add a state groups test.
by Marvin Jan. 3, 2012

Jan. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16235 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 2/5] wined3d: Recognize some more Intel GPUs.
by Christian Inci Jan. 3, 2012

Jan. 3, 2012

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Henri, I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011), which has 256MB under 2GB of RAM. Personally, I think we need a way for detecting the correct VRAM size for IGD's, as it usually depends on the total RAM size. (If not already implemented. I'm not familiar with the directx subset of Wine. ;-) ) Kind regards, Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPAmH5AAoJEBs38cNfaEHvzBsH/2Xlg5bfOc6Cudr2dIgD2XJk +ru6bHLM51tN2aacQphRNm6y1e60DEPvEiBei8hSZ0dU+mP0C/WsuOMjHIz3+LIg kXfRgqfjExqXoCaZuDnjnFpVjkdnF+NJUJlvvqTRm2hmZIbvKIdvKUagyNx8rmnG 4Bro+00qzU7KlAuYHZZptlFcCF4efndllCKonMBt2IqxpePz84Kx7YfjTABXvZS4 +JeYVlMiZ8wcCzcE3C7MHWwXToas1vAE7BHWiCQ9sUrs0Me4e7KqurvFKm690sf+ L63eD16R9xfgS/SBWFEG74iehb8bEjZNZgpxMrjdZdU7vAVjskfhnAvAjFkkNxU= =IRzs -----END PGP SIGNATURE-----

2 1

Warning report for wine-1.3.36
by Jerome Leclanche Jan. 2, 2012

Jan. 2, 2012

No change since 1.3.35. J. Leclanche

1 0

[PATCH RFC 4/5] dsound: Clean up channels
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 2, 2012

Jan. 2, 2012

Alexander, I'm not familiar with dsound + if (ichannels > 2) + FIXME("Conversion from %u to %u channels is not implemented, falling back to stereo", ichannels, ochannels); + dsb->mix_channels = 2; Does you code support 8 channels? Look through git history, and you'll see some patches made specifically for 6 or even 8 channel audio plus some 8->2 and 2->8 conversions. Without having a 5:1 or 7:1 card, I think this gives hints as to what apps expect from conversions. Of course, there's always a risk that an old bug analysis was biased by other bugs, leading to misconceptions and misbeliefs about the actual needs and behaviour. About dsound: convert from fixed to floating point Using floats for frequencies is not bad. After all, modern mmdevapi does it too in IAudioClockAdjustment::SetSampleRate Just avoid computing byte positions from floats... BTW, AUDCLNT_STREAMFLAGS_RATEADJUST hints that the DSound mixer implements stuff that mmdevapi's mixer needs... Regards, Jörg Höhle

1 0

Re: ieframe: Improved test traces
by Marvin Jan. 2, 2012

Jan. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16234 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3166: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2750: Test failed: expected TranslateUrl webbrowser.c:2751: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2752: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2758: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3125: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2843: Test failed: expected RequestUIActivate webbrowser.c:2935: Test failed: Got 0x80004002 webbrowser.c:3133: Test failed: doc != doc2 webbrowser.c:3030: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

1 0

Re: urlmon: When detecting text/html look for HEAD or BODY tags too and only in first 256 bytes
by Jacek Caban Jan. 2, 2012

Jan. 2, 2012

On 01/02/12 14:53, Paul Chitescu wrote: > Changelog: > urlmon: When detecting text/html look for HEAD or BODY tags too and only in > first 256 bytes Please add a test case. > > This fixes bug #27115 and similar. > > Note that this is just a minor improvement. The entire implementation should > be changed to follow the IE way: > http://msdn.microsoft.com/en-us/library/ms775147(v=vs.85).aspx > It mostly is except that page is full of mistakes (as proven by our tests). Jacek

1 0

Release plans
by Alexandre Julliard Jan. 2, 2012

Jan. 2, 2012

Happy New Year to everyone! As you probably know, 2012 will be the year when we release 1.4. I know I already said this last year, but this time I mean it... The release features are in good shape now, and the plan is to enter code freeze as soon as the DIB engine can be considered done, which should be Real Soon Now. At this point it looks like there will be a 1.3.37 release (if only because that's a fun release number...), but it's likely that the release after that will be 1.4rc1. This means that if there are changes you want to get in before code freeze, they need to be done in the next 3 weeks or so. I'm thinking in particular of the audio changes that people have been discussing. Now would also be a good time to look for your name on the Regression Hall of Shame (http://source.winehq.org/regressions) and see if you can do something to bring your count down, as I expect the counts will go up again once rc1 is out and users start testing it. And if you don't have any regressions to your name, feel free to tackle some of mine ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] jscript: functions that return -1 should have signed return (Coverity)
by Jacek Caban Jan. 2, 2012

Jan. 2, 2012

Hi Marcus, On 12/31/11 15:43, Marcus Meissner wrote: > Hi, > > Side issue of CID 5504. > > Ciao, Marcus > --- > dlls/jscript/compile.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c > index 60b0c2e..96497b6 100644 > --- a/dlls/jscript/compile.c > +++ b/dlls/jscript/compile.c > @@ -146,7 +146,7 @@ static BSTR compiler_alloc_bstr(compiler_ctx_t *ctx, const WCHAR *str) > return ctx->code->bstr_pool[ctx->code->bstr_cnt++]; > } > > -static unsigned push_instr(compiler_ctx_t *ctx, jsop_t op) > +static int push_instr(compiler_ctx_t *ctx, jsop_t op) > { > assert(ctx->code_size>= ctx->code_off); > > @@ -328,7 +328,7 @@ static HRESULT compile_member_expression(compiler_ctx_t *ctx, member_expression_ > > #define LABEL_FLAG 0x80000000 > > -static unsigned alloc_label(compiler_ctx_t *ctx) > +static int alloc_label(compiler_ctx_t *ctx) > { > if(!ctx->labels_size) { > ctx->labels = heap_alloc(8 * sizeof(*ctx->labels)); This patch just moves the problem around by introducing a lot of int to unsigned int assignments. Introducing something like INVALID_HANDLE_VALUE would solve the problem here, but I've sent more widespread changes that will fix this problem as well. Thanks, Jacek

1 0

Strange comdlg32 resource string
by Francois Gouget Jan. 1, 2012

Jan. 1, 2012

André Hentschel pointed me to a strange cmdlg32 resource string: IDS_ABOUTBOX "&About FolderPicker Test" The text seems unlikely to be correct. IDS_ABOUTBOX was introduced in 87b81de0 but was not used even in that patch and as far as I can see it is still not used by Wine. Looking at the Windows comdlg32 dll I see no string resource (but that mostly make me suspicious of the tool I used). Furthermore, none of the other strings in that string table seem to be used either: IDS_DOCUMENTFOLDERS "Document Folders" IDS_PERSONAL "My Documents" IDS_FAVORITES "My Favorites" IDS_PATH "System Path" IDS_DESKTOP "#msgctxt#display name#Desktop" IDS_FONTS "Fonts" IDS_MYCOMPUTER "My Computer" -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

1 0