January 2012 - Wine-Devel - list.winehq.org

Re: richedit: v1.0 richedit uses CR and LF for enter
by Juan Lang Jan. 19, 2012

Jan. 19, 2012

Hi Jason, + ME_InsertTextFromCursor(editor, 0, &endlv10[0], 2, style); you want to use endlv10 instead, i.e.: + ME_InsertTextFromCursor(editor, 0, endlv10, 2, style); --Juan

3 6

Re: [2/2] mshtml: Forward SID_SContainerDispatch from a script host
by Jacek Caban Jan. 19, 2012

Jan. 19, 2012

Hi Nikolay, On 01/18/12 23:18, Nikolay Sivov wrote: > Forward SID_SContainerDispatch from a script host Please add a test. Jacek

1 0

Re: [1/2] mshtml: Respond to SID_SContainerDispatch service id
by Jacek Caban Jan. 19, 2012

Jan. 19, 2012

Hi Nikolay, On 01/18/12 23:18, Nikolay Sivov wrote: > Respond to SID_SContainerDispatch service id + if(IsEqualGUID(&SID_SContainerDispatch, guidService)) { + TRACE("SID_SContainerDispatch\n"); + return IHTMLDocument2_QueryInterface(&This->IHTMLDocument2_iface, riid, ppv); + } Your test suggests that it's a wrong object to return. It may be acceptable if native returns this object as well, with just wrapped interface, but we need test for it. Jacek

1 0

Re: [PATCH 3/3] d3d9/tests: More D3DTSS_TEXTURETRANSFORMFLAGS projection tests.
by Saulius Krasuckas Jan. 18, 2012

Jan. 18, 2012

* On Tue, 27 Dec 2011, Matteo Bruni wrote: > --- > dlls/d3d9/tests/visual.c | 388 ++++++++++++++++++++++++++++++++-------------- > 1 files changed, 269 insertions(+), 119 deletions(-) Hello Matteo, this is http://source.winehq.org/git/wine.git/commitdiff/8dee7989f242b8ea624abc3b1f… The patch removed 6 failures on XP on real hardware (nVidia FX5200): http://test.winehq.org/data/18c20964e1e22f9aa974cc774bf77da6fc013716/xp_s2-… visual.c:4057: Test failed: proj: Pixel 162/122 has color 0x00000000, expected 0x00FFFFFF visual.c:4062: Test failed: proj: Pixel 158/178 has color 0x00000000, expected 0x00FFFFFF visual.c:4069: Test failed: proj: Pixel 318/118 has color 0x00ffffff, expected 0x00000000 visual.c:4071: Test failed: proj: Pixel 322/118 has color 0x00ffffff, expected 0x00000000 visual.c:4075: Test failed: proj: Pixel 322/122 has color 0x00ffffff, expected 0x00000000 visual.c:4078: Test failed: proj: Pixel 318/178 has color 0x00000000, expected 0x00FFFFFF and introduced 14 new ones: http://test.winehq.org/data/277361d7be206e1ff7634998f0d750f7c6d66498/xp_s2-… visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (401, 361) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (401, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (481, 359) has color 00ffffff, expected 00000000 visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (481, 361) has color 00ffffff, expected 00000000 visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (479, 359) has color 00ffffff, expected 00000000 visual.c:3729: Test failed: D3DTTFF_COUNT3 | D3DTTFF_PROJECTED - bottom right: Pixel (479, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (401, 361) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (401, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (479, 361) has color 00000000, expected 00ffffff visual.c:3729: Test failed: D3DTTFF_PROJECTED (like COUNT3 | PROJECTED, texcoord has only 3 components) - bottom right: Pixel (479, 419) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (81, 121) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (81, 179) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (159, 121) has color 00000000, expected 00ffffff visual.c:3729: Test failed: 0xffffffff (like COUNT3 | PROJECTED, texcoord has only 3 components) - top left: Pixel (159, 179) has color 00000000, expected 00ffffff The same machine running Win7 didn't exhibit any changes: http://test.winehq.org/data/18c20964e1e22f9aa974cc774bf77da6fc013716/win7_s… http://test.winehq.org/data/277361d7be206e1ff7634998f0d750f7c6d66498/win7_s… This probably has something to do with older nVidia driver version being used on Win7 - v96.85 - than the version used on XP - v163.75 . But on Win7 somewhat similar change is seen on virtual machine from Francois, only the failure count increases by 28 here: http://test.winehq.org/data/18c20964e1e22f9aa974cc774bf77da6fc013716/win7_f… http://test.winehq.org/data/277361d7be206e1ff7634998f0d750f7c6d66498/win7_f… Would you mind fixing this please:)? S.

2 1

Re: Debugging Wine with Lightroom 3.5
by Joris Huizer Jan. 18, 2012

Jan. 18, 2012

Replying, also including the wine-devel list, On 12/17/2011 05:15 PM, Roland Baudin wrote: > Hi, > > thanks for the answer. > What do you mean by "a different execution path"? > RB The application might decide to execute different code given the Vista settings. It may have a preferred execution path using certain functionality only available for Vista/Windows 7, and a fallback path for XP. Pseudocode: if (system is Vista+) use_builtin_functionality(); else /* XP */ use_fallback_mechanism(); HTH, Joris

5 7

Re: winex11.drv: Strip the _XXX from X11DRV_GetKeyNameText when approperate
by Vitaliy Margolen Jan. 18, 2012

Jan. 18, 2012

On 01/17/2012 09:32 AM, Aric Stewart wrote: > > The problem is that there is no XK keycode for just Shift, Control or Menu > so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result the string > XKeysymToString returns is a string with a _L or _R at the end, even if the > "don't care" bit is set. > + char *new_name; > + INT rc = 0; > + new_name = HeapAlloc(GetProcessHeap(),0,(idx-name)+1); > + lstrcpynA(new_name,name,(idx-name)+1); > + new_name[idx-name] = 0; > + TRACE("found scan=%04x keyc=%u keysym=%04x new_string=%s\n", > + scanCode, keyc, (int)keys, new_name); > + if (lpBuffer && nSize) > + rc = MultiByteToWideChar(CP_UNIXCP, 0, new_name, -1, lpBuffer, nSize); > + HeapFree(GetProcessHeap(),0,new_name); > + return rc; I don't think you need an extra buffer. Just do something like: if (lpBuffer && nSize) { rc = MultiByteToWideChar(CP_UNIXCP, 0, new_name, idx - name, lpBuffer, nSize); if (nSize > idx - name) lpBuffer[idx - name] = 0; } Of course need to account for rc. Vitaliy

2 1

Re: comdlg32: Remove the font sample characters string.
by Frédéric Delanoy Jan. 18, 2012

Jan. 18, 2012

On Wed, Jan 18, 2012 at 10:12, Francois Gouget <fgouget(a)free.fr> wrote: > The sample text does not depend on the dialog language but on the scripts supported by the font. As such translating it in the resource file makes no sense. > - CTEXT "AaBbYyZz",stc5,103,80,109,24,SS_NOPREFIX | NOT WS_VISIBLE > + CTEXT "",stc5,103,80,109,24,SS_NOPREFIX | NOT WS_VISIBLE Actually it's used to show a sample in the font picker (e.g. with wordpad do Format > Font). I translated it in French using most common/representative French characters (including accentuated letters). I wouldn't remove it, but rather add a message context clarifying what its purpose is. If the sample text does not depend on the dialogue language, that's what should be done instead IMHO Frédéric

3 4

Re: po: French translation updates.
by Frédéric Delanoy Jan. 18, 2012

Jan. 18, 2012

On Tue, Jan 17, 2012 at 23:11, Francois Gouget <fgouget(a)free.fr> wrote: > @@ -9335,7 +9335,7 @@ msgstr "" > "[nomFichier]\n" > " [/S [/D]]\n" > "\n" >-"où\n" >+"Où :\n" > "\n" > " + Définit un attribut.\n" > " - Supprime un attribut.\n" >@@ -10234,7 +10234,7 @@ msgstr "" > " -ou-\n" > "NET commande /HELP\n" > "\n" >-"où « commande » peut être HELP, START, STOP ou USE.\n" >+"Où « commande » peut être HELP, START, STOP ou USE.\n" > > #: net.rc:28 > msgid "" >@@ -10264,7 +10264,7 @@ msgstr "" > "\n" > "NET STOP service\n" > "\n" >-"où « service » est le nom du service à arrêter.\n" >+"Où « service » est le nom du service à arrêter.\n" I'm not convinced by the capitalization of "où" where placed kind of in the middle of the "flow" of a sentence. There's hardly ever an uppercase letter in French for normal words in the middle of a sentence (unlike in English). Now, if you wanted to add a ':' as is done in English, I find this is rather a problem with the English version which shouldn't contain a colon to begin with (that's juste noise IMHO). Frédéric N.B.: review/reply would be easier if you inlined your patch instead of an attachment

2 1

Re: gdi32:Add EnhMetafile PolyBezier,PolyBezierTo support (try 2)
by Dmitry Timoshkov Jan. 18, 2012

Jan. 18, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Added tests. > > Changelog: > gdi32: Add EnhMetafile PolyBezier,PolyBezierTo support Please add an EMF test which uses compare_emf_bits() instead. -- Dmitry.

1 0

Re: ntoskrnl.exe: add a stub for IoCreateSynchronizationEvent
by Dmitry Timoshkov Jan. 18, 2012

Jan. 18, 2012

Austin English <austinenglish(a)gmail.com> wrote: > +PKEVENT WINAPI IoCreateSynchronizationEvent(PUNICODE_STRING name, PHANDLE handle) > +{ > + FIXME("(%p %p) stub\n", name, handle); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return NULL; > +} NT APIs are not supposed to set last error. -- Dmitry.

1 0