October 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Christian Costa <titan.costa(a)gmail.com> wrote: > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + TRACE("()\n"); > + > + /* Return current process id since PEPROCESS is opaque and drivers should not access the struct directly */ > + return (PEPROCESS)PsGetCurrentProcessId(); > } The returned pointer is supposed to be passed to various other ntoskrnl APIs, and it's needs to be a valid pointer to the kernel object. Besides many not trivial kernel drivers (if not all) really dig into internal kernel structures. Same for KeGetCurrentThread. -- Dmitry.

4 4

Re: [PATCH] reg.exe: comparing the names of registry keys
by Jacek Caban Oct. 4, 2012

Oct. 4, 2012

On 10/04/12 08:03, Mieczyslaw Nalewaj wrote: > +static BOOL strings_equal(LPWSTR lpString1, const WCHAR *lpString2) > +{ > + int cchCount; Please avoid Hungarian style variable names. Also is seems like the function not exactly compares strings, so something like is_subkey could be more appropriate function name. > + if ((!lpString1 || !*lpString1) && (!lpString2 || !*lpString2)) /* both empty */ > + return TRUE; > + if ( !lpString1 || !*lpString1 || !lpString2 || !*lpString2 ) /* one empty */ > + return FALSE; How about simplifying it to: if(!str1 || !*str1) return !str2 || !*str2; if(!str2 || !*str2) return FALSE; > + cchCount = strlenW(lpString2); > + if (strlenW(lpString1)<cchCount) /* too short */ > + return FALSE; > + > + if ( (CompareStringW(CP_ACP,NORM_IGNORECASE,lpString1,cchCount,lpString2,cchCount)==CSTR_EQUAL) > + && ((lpString1[cchCount] == 0) || (lpString1[cchCount] == (WCHAR){'\\'}))) > + return TRUE; > + else > + return FALSE; This could be simplified: len = strlenW(str2); return !strncmpiW(str1, str2, len) && (!str1[len] || str1[len] == '\\'); Cheers, Jacek

1 0

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Qian Hong <fracting(a)gmail.com> wrote: > --- > dlls/gdi32/tests/font.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) On what system do you see broken results? I'm asking because i did run this test with japanese locale at the time I touched it last time. -- Dmitry.

2 5

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.
by Dmitry Timoshkov Oct. 4, 2012

Oct. 4, 2012

Christian Costa <titan.costa(a)gmail.com> wrote: > + /* Read memory from the client process memory */ > + if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &bytes)) This kind of casts is broken. -- Dmitry.

2 1

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22000 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21999 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21998 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier Oct. 3, 2012

Oct. 3, 2012

Hello André, AH> In the meantime you could change your preferences in the appdb (Send email notifications) Than I'm in peace - that's right. But this have a side-effect: I also will not be informed by AppDB if someone add a new test or a comment in my attended applications: the mails to remain an applications maintainer to do his work are also switched off. This isn't really what I want. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 3

Overriding the check for ownership of a prefix
by Scott Ritchie Oct. 3, 2012

Oct. 3, 2012

So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the user launches the app (via desktop file) this in turn launches a script that does the following: 1) Makes a temporary folder 2) Sets up a unionfs-fuse copy-on-write mount between ~/.appname and the read-only packaged prefix in /opt, mounted in the temporary folder 3) Runs the app with WINEPREFIX= the temp folder 4) When the app is finished, unmounts the temp folder This all works quite fine: new (or modified) files within the prefix get stored in ~/.appname, to be restored the next time the user runs the app. Distinct users can run the app simultaneously, as they each have their own prefix. Excess file-copying is avoided, as only the user-modified files need to be stored in the home folders. There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Simply commenting out this part of the code makes Wine work fine, however I'd like to be able to have a proper solution. Would something like a command-line switch or environment variable be acceptable here? Thanks, Scott Ritchie * Note that there is a problem with this setup if the app modifies the registry and we then need to update the prefix-default registry, but that's a different feature request

2 3

Re: [PATCH] advapi32: avoid memory leaks (Coverity)
by Alexandre Julliard Oct. 3, 2012

Oct. 3, 2012

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -530,8 +530,10 @@ static void test_enum_providers(void) > /* alloc provider to half the size required > * cbName holds the size required */ > providerLen = cbName / 2; > - if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) > + if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) { > + LocalFree(pszProvName); > return; > + } Actually, checking for allocation failures in tests is not useful, it's not going to happen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error
by Jacek Caban Oct. 3, 2012

Oct. 3, 2012

Hi Marcus, On 10/01/12 23:00, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. > > Second reiteration with Jaceks comment applied Sorry for not catching this later, I was concentrated on your comment instead of the code, but the important thing is that true call_ret means success (and wininet doing request asynchronously is signalled as an error). It means that in this case we want to return RPC_S_OK. What is the exact problem? Jacek

2 2

Re: [PATCH 2/2] vbscript: Added Right() implementation
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21987 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

ImmIsUIMessageA/W
by Aric Stewart Oct. 3, 2012

Oct. 3, 2012

Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. These changes cause the IME to stop working for IME unaware applications. Where the changed intentional and if so based on what documentation? thanks! -aric

3 9

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier Oct. 3, 2012

Oct. 3, 2012

Hello Rosanne, sorry for misspelling your first name in my mail before. > I tried deleting the spammer's account, and the system asked me if > I really wanted to, but it didn't delete it even after I said yes. > I'm not sure that would have helped anyway, as he could easily just > create a new account. couldn't you simply reset the spammers password? So if his account is powned he will have to get a new one. > We really do need some sort of moderation for > AppDB comments similar to what's on the forum. In general this is a good idea. -- Regards Joerg Schiermeier Bielefeld/Germany

1 0

AppDB: Could someone please block this Spammer (UCE)
by newsletter [at] Schiermeier-Software Oct. 3, 2012

Oct. 3, 2012

Hello everybody, could someone of the AppDB admin team please block this UCE-Mails which comes via AppDB-notifications? I'm speaking about this: 1.) Tue, 02 Oct 2012 04:58:05 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631#Comment-8…> 2.) Tue, 02 Oct 2012 12:01:08 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992#Comment-8…> 3.) Tue, 02 Oct 2012 15:11:12 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631> 4.) Tue, 02 Oct 2012 15:35:39 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992> Please Rosane, help us...! Thanks a lot! -- Gruss von Joerg Schiermeier

3 2

Re: [1/2] vbscript: Support vb* constants for message box buttons
by Jacek Caban Oct. 3, 2012

Oct. 3, 2012

Hi Nikolay, On 10/03/12 13:34, Nikolay Sivov wrote: > Support vb* constants for message box buttons How about using MB_* constants from winuser.h instead of hardcoding them here? Other than that, the patch looks good to me. Jacek

2 1

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION
by Alexandre Julliard Oct. 3, 2012

Oct. 3, 2012

Aric Stewart <aric(a)codeweavers.com> writes: > resolves bug 31832 > --- > dlls/imm32/imm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Is there any reason why we are not simply calling DefWindowProc? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] vbscript: Support vb* constants for message box return value (try2)
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21981 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] vbscript: Support vb* constants for message box buttons (try2)
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21980 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] vbscript: Support vb* constants for message box return value
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] vbscript: Support vb* constants for message box buttons
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21978 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] oledb32: Add support for IDBInitialize interface in IDataInitialize
by Marvin Oct. 3, 2012

Oct. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21975 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

1 0

Re: wininet: Fixed failing test
by Dmitry Timoshkov Oct. 3, 2012

Oct. 3, 2012

Piotr Caban <piotr(a)codeweavers.com> wrote: > - ok(ret, "GetUrlCacheEntryInfoExW failed with error %d\n", GetLastError()); > + ok(ret || broken(!ret) /* IE6 */, "GetUrlCacheEntryInfoExW failed with error %d\n", GetLastError()); This kind of blanket test results coverage is broken from the start. -- Dmitry.

1 0

Re: [PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.
by Jacek Caban Oct. 3, 2012

Oct. 3, 2012

On 10/02/12 23:02, Erich E. Hoover wrote: > If a cleanup occurs because HTML Help window creation fails then > list_remove() causes a crash, since the window was never added to the > window list. The attached patch fixes this issue, allowing safe > reloading of files (needed for part 2). This looks like a hack. It would be better to have always valid list entry (if this really can't be added to the list earlier, you may always initialize it by list_init) or make sure to not call ReleaseHelpViewer before HHInfo is fully initialized. Jacek

1 0

Re:cmd: /r is equivalent to /c
by Ann and Jason Edmeades Oct. 3, 2012

Oct. 3, 2012

Concept of patch is fine (and we ought to support it), but I dont think this would work as coded (if (tolowerW(c)=='c'||'r') will always be true). Also, can you add a quick test for it (there's cmd.exe /c tests - just add a cmd.exe /r echo test worked). PS You might want to just hold off until the patch I submitted last night gets committed as well otherwise there will be merge conflicts ("Change command line parsing away from argv/argc")

1 0