October 2012 - Wine-Devel - list.winehq.org

Re: cmd: /r is equivalent to /c
by Dmitry Timoshkov Oct. 3, 2012

Oct. 3, 2012

Ken Sharp <kennybobs(a)o2.co.uk> wrote: > - if (tolowerW(c)=='c') { > + if (tolowerW(c)=='c'||'r') { In C it doesn't work this way. -- Dmitry.

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW().
by Marvin Oct. 2, 2012

Oct. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW().
by Marvin Oct. 2, 2012

Oct. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21949 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 7/7] mshtml: Added script 'for' and 'event' attributes tests
by Marvin Oct. 2, 2012

Oct. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21945 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wininet/tests(1/2): Test CommitUrlCacheEntry with the original URL parameter
by Piotr Caban Oct. 2, 2012

Oct. 2, 2012

On 10/02/12 03:30, Juan Lang wrote: + /* On the other hande, GetUrlCacheEntryInfoEx allows you to query the + * original URL. + */ There's a typo, should be "On the other hand". + /* Strangely, you can create a cache entry redirected to itself. */ + ret = CreateUrlCacheEntry(test_url, 0, "html", filenameA, 0); + ok(ret, "CreateUrlCacheEntry failed with error %d\n", GetLastError()); + create_and_write_file(filenameA, &zero_byte, sizeof(zero_byte)); + ret = CommitUrlCacheEntry(test_url, filenameA, filetime_zero, filetime_zero, + NORMAL_CACHE_ENTRY, NULL, 0, NULL, test_url); In this case original url is ignored. Probably it's a more appropriate comment. Your test is leaving an entry in index.dat file. Please remove test_original_url entry from cache after testing it. Cheers, Piotr

1 0

Re: [PATCH 2/3] vbscript: Added LTrim() implementation
by Marvin Oct. 2, 2012

Oct. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21943 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] vbscript: Added Trim() implementation
by Marvin Oct. 2, 2012

Oct. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21942 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wininet(2/2): Fail to commit a url cache entry when the original URL is specified and no local filename is given
by Piotr Caban Oct. 2, 2012

Oct. 2, 2012

On 10/02/12 03:31, Juan Lang wrote: @@ -3084,6 +3084,11 @@ static BOOL CommitUrlCacheEntryInternal( SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } + if (lpszOriginalUrl && !lpszLocalFileName) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } if (lpszOriginalUrl) WARN(": lpszOriginalUrl ignored\n"); The function should succeed if lpszOriginalUrl is specified and it operates on history container. Probably the check for lpszLocalFileName with STICKY_CACHE_ENTRY is also redundant. I guess that the lpszLocalFileName should be validated in following way: if(pContainer->default_entry_type==NORAML_CACHE_ENTRY && !lpszLocalFileName) { SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } I haven't check what happens for cookies containers. Cheers, Piotr

1 0

Re: [PATCH] scsiport.sys: Add stub implementaton of scsiport.sys.
by André Hentschel Oct. 2, 2012

Oct. 2, 2012

Am 02.10.2012 00:10, schrieb Christian Costa: > This is needed by prosync1.sys (StarForce protection) used in Obscure. > --- > configure | 284 +++++++++++++++++------------------ > configure.ac | 1 > dlls/scsiport.sys/Makefile.in | 9 + > dlls/scsiport.sys/scsiport.c | 39 +++++ > dlls/scsiport.sys/scsiport.sys.spec | 48 ++++++ > 5 files changed, 238 insertions(+), 143 deletions(-) > create mode 100644 dlls/scsiport.sys/Makefile.in > create mode 100644 dlls/scsiport.sys/scsiport.c > create mode 100644 dlls/scsiport.sys/scsiport.sys.spec > > diff --git a/configure b/configure > index 54675b4..801dcf8 100755 > --- a/configure > +++ b/configure > @@ -1,11 +1,13 @@ > #! /bin/sh > # Guess values for system-dependent variables and create Makefiles. > -# Generated by GNU Autoconf 2.69 for Wine 1.5.14. > +# Generated by GNU Autoconf 2.68 for Wine 1.5.14. You should not include configure changes

2 1

Wine Mono 0.0.8 Release
by Vincent Povirk Oct. 1, 2012

Oct. 1, 2012

Since I messed up the 0.0.6 release, here's another one, almost identical. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package. * Build process now fails immediately if wine or gmcs is missing, instead of waiting until they're used. (Austin English)

1 0

Re: ws2_32: Fix TRACE format in WS_getsockname (try 2)
by Dmitry Timoshkov Oct. 1, 2012

Oct. 1, 2012

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, namelen?*namelen:0); Adding some spaces to make this slightly more readable wouldn't hurt IMHO. -- Dmitry.

2 1

Re: [PATCH 6/6] wininet/tests: Remove all temporary files
by Marvin Oct. 1, 2012

Oct. 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21929 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/6] wininet: Set entry type based on container type
by Marvin Oct. 1, 2012

Oct. 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21928 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] wininet: Added support for cache entries overwritting
by Marvin Oct. 1, 2012

Oct. 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21927 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] Assorted spelling fixes.
by Julian Rüger Oct. 1, 2012

Oct. 1, 2012

Hi Francois, > - * size [I] How much percent of cache space should be free. > + * size [I] How many percents of the cache should be free. Maybe something like "Precentage of cache that should be free" would sound more natural. However I'm not sure of the intended meaning here, it could be "freed". Best regards, Julian

2 1

Re: [PATCH 1/2] vbscript: Added Left() implementation
by Marvin Oct. 1, 2012

Oct. 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21919 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: mshtml: Implement IHTMLFrameBase_put_name()
by Jacek Caban Oct. 1, 2012

Oct. 1, 2012

Hi Nikolay, On 09/30/12 20:36, Nikolay Sivov wrote: > http://bugs.winehq.org/show_bug.cgi?id=31835 The code may be simple and obvious, but I'd still like to see a test. A simple call should be enough just to make sure it's executed when I test new Gecko builds. Jacek

2 1

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error
by Jacek Caban Oct. 1, 2012

Oct. 1, 2012

Hi Marcus, On 09/29/12 11:44, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. Agreed, thanks for catching it. > Ciao, Marcus > --- > dlls/rpcrt4/rpc_transport.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 686ce68..e572b78 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -1882,7 +1882,7 @@ static RPC_STATUS wait_async_request(RpcHttpAsyncData *async_data, BOOL call_ret > > if(call_ret) { > RpcHttpAsyncData_Release(async_data); > - return RPC_S_OK; > + return call_ret; /* The Http* status codes map into the RPC_S namespace */ Not really, Http* APIs return BOOL and GetLastError() call is needed to get error code. AFAIR, when I tested this code, most HTTP-related errors were translated to RPC_S_SERVER_UNAVAILABLE by rpcrt4. That may be a better choice here as well. Jacek

1 0

Re: d3dx9_36 [patch 2/5, try 4]: Speed-up some tests.
by Rico Schüller Oct. 1, 2012

Oct. 1, 2012

On 01.10.2012 03:28, Nozomi Kodama wrote: > + for (order = 0; order <= D3DXSH_MAXORDER + 1 ; order++) Well, I'm not sure what you are doing with the spaces ... I say it again, if you got a comment, read it carefully take a look at your code and fix it. I mentioned white space issues a couple of times. And I think I mentioned the problem already ... I accidentally send it to wine-patches instead of wine-devel (sorry, this was my mistake): http://www.winehq.org/pipermail/wine-patches/2012-September/118230.html. Cheers Rico

1 0

Re: d3dx9_36 [patch 1/5, try 4]: Implement D3DXSHMultiply4
by Rico Schüller Oct. 1, 2012

Oct. 1, 2012

On 01.10.2012 03:27, Nozomi Kodama wrote: > I used FLOAT * WINAPI, though I don't like it. Yeah, that's not much of an issue... and this is not the showstopper. > + TRACE("(out %p, a %p, b %p)\n", out, a, b); What I'm a bit curious about is, why do you reinvent a new style in a new patch (see http://www.winehq.org/pipermail/wine-devel/2012-September/097133.html and http://www.winehq.org/pipermail/wine-devel/2012-September/097131.html)? I'm not sure if my wording is that hard to understand. For me the preferred option for the TRACE is: "TRACE("out %p, a %p, b %p\n", out, a, b);" And the one also used in the file is: "TRACE("(%p, %p, %p)\n", out, a, b);" Please use exactly one of those. Not mixture, no extra brackets... Sorry, I should have written an answer to the (try 3), but I wasn't fast enough. Cheers Rico

1 0

Re: ws2_32: Fix TRACE format in WS_getsockname
by Dmitry Timoshkov Oct. 1, 2012

Oct. 1, 2012

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > @@ -2444,7 +2444,7 @@ int WINAPI WS_getsockname(SOCKET s, struct WS_sockaddr *name, int *namelen) > int fd; > int res; > > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, *namelen); > > /* Check if what we've received is valid. Should we use IsBadReadPtr? */ > if( (name == NULL) || (namelen == NULL) ) Taking into account check after the trace printing the contents of namelen should be replaced by printing its pointer. -- Dmitry.

1 0

Re: [PATCH 5/5] ntoskrnl.exe: Implement IoAllocateMdl.
by Dmitry Timoshkov Oct. 1, 2012

Oct. 1, 2012

Christian Costa <titan.costa(a)gmail.com> wrote: > PMDL WINAPI IoAllocateMdl( PVOID VirtualAddress, ULONG Length, BOOLEAN SecondaryBuffer, BOOLEAN ChargeQuota, PIRP Irp ) > { > PMDL mdl; > + ULONG address = (ULONG)VirtualAddress; This won't work on 64-bit. > + mdl->StartVa = (PVOID)page_address; and this. > + mdl->ByteCount = Length; > + mdl->ByteOffset = address - page_address; Probably the type of size holding parameters/variables should be SIZE_T. -- Dmitry.

1 0