October 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] user32: Don't ignore return value of MapWindowPoints
by Nikolay Sivov Oct. 16, 2012

Oct. 16, 2012

On 10/16/2012 04:10, danielfsantos(a)att.net wrote: > ScreenToClient should return zero if the operation fails, but is always > returning TRUE. This patch corrects the problem and solves a crash bug > in Lord of the Rings Online (bug #31979) > > Credit for this patch goes to some one else, as yet unidentified, since > it originally came from a closed forum for beta testers of the LoTRO > Riders of Rohan expansion and the forum has subsequently been wiped. > --- > dlls/user32/winpos.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c > index 5a2f1f2..3855b19 100644 > --- a/dlls/user32/winpos.c > +++ b/dlls/user32/winpos.c > @@ -250,8 +250,7 @@ BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt ) > */ > BOOL WINAPI ScreenToClient( HWND hwnd, LPPOINT lppnt ) > { > - MapWindowPoints( 0, hwnd, lppnt, 1 ); > - return TRUE; > + return MapWindowPoints( 0, hwnd, lppnt, 1 ) != 0; > } > This needs a test.

1 0

Re: [3/4] comctl32: fix notifications and return value when collapsing already collapsed node (rebased)
by Nikolay Sivov Oct. 15, 2012

Oct. 15, 2012

Hi, Daniel. You forgot a patch.

2 1

Re: jscript: Move 'inline' to the beginning of the declaration.
by Francois Gouget Oct. 15, 2012

Oct. 15, 2012

On Mon, 15 Oct 2012, Michael Stefaniuc wrote: [...] > --- a/dlls/jscript/jsstr.h > +++ b/dlls/jscript/jsstr.h > @@ -28,7 +28,7 @@ struct _jsstr_t { > > #define JSSTR_FLAG_NULLBSTR 1 > > -static unsigned inline jsstr_length(jsstr_t *str) > +inline static unsigned jsstr_length(jsstr_t *str) 'static inline' is the more common format in Wine (4166 occurences versus 0 for 'inline static'). But yes, moving it before the return type makes sense. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

Re: [2/4] comctl32: do not send TVN_ITEMEXPANDING when expanding item with no children
by Alexandre Julliard Oct. 15, 2012

Oct. 15, 2012

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 4ce8e5ea93897e03e1c3bbd0be90c9179890a37a Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Thu, 27 Sep 2012 21:06:48 +0200 > Subject: comctl32/treeview: do not send TVN_ITEMEXPANDING when expanding item > with no children > > also, send it when re-expanding expanded item or re-collapsing collapsed one. > Tests in later commit (look for VK_ADD/VK_SUBSTRACT) This causes the explorerframe tests to hang. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3d9 implementation
by Luchezar Belev Oct. 15, 2012

Oct. 15, 2012

hello i have been writing some d3d9/d3d8 implementation on top of opengl as a pet project i mainly work on it under windows, but also made it run under wine. i thought you guys might find it interesting to try it out. It works fine with all the games i got - there are no major problems. they are guild wars (1), wow, league of legends, tomb raider underworld, titan quest, skyrim. it requires opengl 3.3 or higher. attached is zip archive with binaries (2 files) and a readme. (i'm not sure i want to give away the sources yet.)

2 1

Re: [PATCH] d3d9/tests: Do not crash, when CreateTexture failed
by Henri Verbeet Oct. 15, 2012

Oct. 15, 2012

On 14 October 2012 01:12, Detlef Riekenberg <wine.dev(a)web.de> wrote: > Needed to avoid a crash on an Intel integrated graphics. > http://test.winehq.org/data/ee59341721b90e58165a7bb12cbf2906fbd680d1/xp_dr-… > It should probably use CheckDeviceFormat() before even creating the device.

1 0

Re: vbscript: Added Chr implementation
by Marvin Oct. 15, 2012

Oct. 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22203 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Dan Kegel Oct. 15, 2012

Oct. 15, 2012

In general, patches to wine should have some demonstrated benefit, either by increasing the number of passing conformance tests, or by making some app work better, or both. Your current patch doesn't seem to do either of these things. Getting into a pissing match with AJ about patent and copyright law is not a good strategy for potential contributors to wine. He generally knows his stuff, and I think he's right in this case. If I were you, I'd go off and reflect for a while, then pick some other way to contribute.

3 4

Re: ole32/tests: Add tests for IRunnableObject_Run call.
by Dmitry Timoshkov Oct. 15, 2012

Oct. 15, 2012

Roman Dadkov <romand(a)etersoft.ru> wrote: > + hr = CLSIDFromProgID(WordApp, &clsid); > + if (SUCCEEDED(hr)) > + { > + hr = CoCreateInstance(&clsid, NULL, CLSCTX_ALL, &IID_IUnknown, (void **)&pUnknown); > + ok_ole_success(hr, "CoCreateInstance"); > + > + hr = IUnknown_QueryInterface(pUnknown, &IID_IRunnableObject, (void**)&pRunnableObject); > + ok_ole_success(hr, "IUnknown_QueryInterface"); > + if (FAILED(hr)) Shouldn't 'SUCCEEDED(hr)' be used here instead? > + { > + hr = IRunnableObject_Run(pRunnableObject, NULL); > + ok_ole_success(hr, "IRunnableObject_Run"); > + } > + } Probably you should add Release() calls where appropriate. -- Dmitry.

1 0

Fwd: Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Max TenEyck Woodbury Oct. 13, 2012

Oct. 13, 2012

On 10/12/2012 10:25 PM, Dan Kegel wrote: > Hi Max, > here's a little test program that shows that your patch changes how > UIntToPtr works: > > #include <stdio.h> > #include <stdint.h> > > #define UIntToPtrA(i) ((void *)(intptr_t)((unsigned int)i)) > #define UIntToPtrB(i) ((void *)(intptr_t)(i)) > > int main(int argc, char **argv) > { > short x = 65534; > printf("%d -> %p\n", x, UIntToPtrA(x)); > printf("%d -> %p\n", x, UIntToPtrB(x)); > return 0; > } > > On a 64 bit machine, this outputs > > -2 -> 0xfffffffe > -2 -> 0xfffffffffffffffe > > This could change the behavior of functions that call UIntToPtr, like > say EnumResourceTypesA(). > > I would suggest writing a conformance test to expose whether the > change brings Wine closer to native behavior, or further away, adding > that to your patch, and then verifying with winetestbot that the patch > improves wine's conformance. > > My guess is that the current behavior is right, but hey, the test will > show what's really up. > - Dan > I 'greped' the entire wine tree for uses of these macros. There was only a couple places where the argument was an expression and in those cases I did not see that the change would cause problems. Frankly, I do not think I could come up with a test where the change would make a difference. I am submitting the patch against the weird possibility that such a case does exist. The change is strictly preventative maintenance with just a hint of aesthetic improvement to make them coordinate with the 'Handle' variants of these macros. Now, if you are going to tell me that these definitions were *copied* from a Microsoft *source* rather than derived from a Microsoft specification, you would have a point, but then there would be a whole bunch of copyright issues that would need to be worked through.

2 2

Fwd: Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Max TenEyck Woodbury Oct. 13, 2012

Oct. 13, 2012

On 10/12/2012 09:49 PM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > >>>> -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) >>>> -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) >>>> -#define LongToPtr(l) ((void *)(LONG_PTR)((LONG)l)) >>>> -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) >>>> +#define IntToPtr(i) ((void *)(INT_PTR)(i)) >>>> +#define UIntToPtr(ui) ((void *)(UINT_PTR)(ui)) >>>> +#define LongToPtr(l) ((void *)(LONG_PTR)(l)) >>>> +#define ULongToPtr(ul) ((void *)(ULONG_PTR)(ul)) >>> >>> You forgot to explain what's bad with it. >>> >> >> The original applied the extra conversion to ONLY THE FIRST >> component of the expression, not to the WHOLE expression. That >> can (although it's not likely to) cause hard to diagnose problems. > > What 'the first component' are you talking about? This code is win32 only. > 'i', 'ui', 'l' and 'ul' are parameters to the macros, When the macros are used, you put in an expression as the argument to the macro. As originally written for example, the cast to LONG in ((LONG)l) is applied to only the first component of the expression substituted in place of 'l'. In order to get the cast to apply to the whole expression, you need parenthesis around the parameter. That is literally (l). Then the cast applies to the whole expression. That is (LONG_PTR)(l) casts the entire expression substituted into 'l' to a LONG_PTR value. The macros that convert to 'Handle' rather than 'Ptr' do this properly. In the vast majority of cases the expression substituted into 'l' is a simple variable and there is no problem. In almost all of the remaining cases, casting the first element of the expression coerces the rest of the expression to the proper type. In rare cases, other elements of the expression might force the expression's value to some other type. In most of those cases the cast to LONG_PTR fixes the problem. In a really odd case there might be a problem caused by the extra cast to LONG. Since that cast is buried in a macro definition, it will be difficult to spot that cast as the source of such a problem from the source code. The original definitions include three casts in sequence. The first of those casts is done improperly. Even if it were done properly, the next cast in the sequence makes it redundant. I removed the improper cast since it IS redundant. NUFF SAID?

1 0

Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Dmitry Timoshkov Oct. 13, 2012

Oct. 13, 2012

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) > -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) > -#define LongToPtr(l) ((void *)(LONG_PTR)((LONG)l)) > -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) > +#define IntToPtr(i) ((void *)(INT_PTR)(i)) > +#define UIntToPtr(ui) ((void *)(UINT_PTR)(ui)) > +#define LongToPtr(l) ((void *)(LONG_PTR)(l)) > +#define ULongToPtr(ul) ((void *)(ULONG_PTR)(ul)) You forgot to explain what's bad with it. -- Dmitry.

3 3

Re: [PATCH] regedit: err() on printing
by Dmitry Timoshkov Oct. 12, 2012

Oct. 12, 2012

Marcus Meissner <meissner(a)suse.de> wrote: > + ERR("printing is not yet implemented.\n"); Printing a FIXME seems more appropriate. -- Dmitry.

2 1

Re: TestBot job 22150 results: [2/3] dwrite: Implement GetWeight() for IDWriteFont
by Nikolay Sivov Oct. 12, 2012

Oct. 12, 2012

This is caused by previously committed patches while testbot was resting, I'll fix these failures after today series gets in if it's okay.

1 0

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)
by Dmitry Timoshkov Oct. 12, 2012

Oct. 12, 2012

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > * Renamed DUMMYUNIONNAME to u. ... > +typedef struct _FILE_ID_DESCRIPTOR { > + DWORD dwSize; > + FILE_ID_TYPE Type; > + union { > + LARGE_INTEGER FileId; > + GUID ObjectId; > + } u; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR; This change is clearly wrong. -- Dmitry.

3 5

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.
by Charles Davis Oct. 12, 2012

Oct. 12, 2012

On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: > This patch alone makes SunSpider 0.9 17x faster. Seems to me that something is really wrong with our BSTR implementation if replacing it with a home-grown implementation speeds this up by a factor of 17. Chip

2 1

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)
by Henri Verbeet Oct. 12, 2012

Oct. 12, 2012

On 9 October 2012 11:26, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > scrrun: Implement IDictionary_Add and Count > Actually, does it ever make sense to use a linked list at all to implement a dictionary? It seems to me that if you only ever have a handful of entries a simple array would be better suited, while if you have more than that you'd want some kind of search tree or a hash table.

3 2

Fwd: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)
by Per Johansson Oct. 12, 2012

Oct. 12, 2012

On Fri, Oct 12, 2012 at 8:48 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > I will have a look at some sort of hash table. > I'd use wine existing tree implementation, unless there's some specific reason to use a hash table. Hash tables are good in theory but with in practice trees are just as effective in my experience (especially AVL trees). Regards, -- Per Johansson

1 0

Re: [PATCH] amstream: Display new ref in AddRef and Release.
by Nikolay Sivov Oct. 12, 2012

Oct. 12, 2012

On 10/12/2012 00:46, Christian Costa wrote: > --- > dlls/amstream/mediastreamfilter.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c > index ee9d970..0e56a68 100644 > --- a/dlls/amstream/mediastreamfilter.c > +++ b/dlls/amstream/mediastreamfilter.c > @@ -133,17 +133,21 @@ static HRESULT WINAPI MediaStreamFilterImpl_QueryInterface(IMediaStreamFilter *i > > static ULONG WINAPI MediaStreamFilterImpl_AddRef(IMediaStreamFilter *iface) > { > - return BaseFilterImpl_AddRef((IBaseFilter*)iface); > + ULONG ref = BaseFilterImpl_AddRef((IBaseFilter*)iface); > + > + TRACE("(%p)->(): new ref = %u\n", iface, ref); > + > + return ref; > } You should get rid of casts like that. Also I don't see a reason to print anything but refcount itself life (%p)->(%u). > > static ULONG WINAPI MediaStreamFilterImpl_Release(IMediaStreamFilter *iface) > { > IMediaStreamFilterImpl *This = impl_from_IMediaStreamFilter(iface); > - ULONG refCount = BaseFilterImpl_Release((IBaseFilter*)iface); > + ULONG ref = BaseFilterImpl_Release((IBaseFilter*)iface); > > - TRACE("(%p)->() Release from %d\n", iface, refCount + 1); > + TRACE("(%p)->(): new ref = %u\n", iface, ref); > > - if (!refCount) > + if (!ref) > { > int i; > for (i = 0; i < This->nb_streams; i++) > @@ -154,7 +158,7 @@ static ULONG WINAPI MediaStreamFilterImpl_Release(IMediaStreamFilter *iface) > HeapFree(GetProcessHeap(), 0, This); > } > > - return refCount; > + return ref; > } > > /*** IPersist methods ***/ > > > >

2 1

Re: [PATCH] amstream: Check params in IAMMultiMediaStreamImpl_OpenFile.
by Nikolay Sivov Oct. 12, 2012

Oct. 12, 2012

On 10/12/2012 00:59, Christian Costa wrote: > --- > dlls/amstream/amstream.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > > - TRACE("(%p/%p)->(%s,%x)\n", This, iface, debugstr_w(pszFileName), dwFlags); > + TRACE("(%p/%p)->(%s,%x)\n", This, iface, debugstr_w(filename), flags); > + > + if (!filename) > + return E_POINTER; > + > + if (flags & ~(AMMSF_NOCLOCK | AMMSF_NORENDER | AMMSF_RENDERALLSTREAMS | AMMSF_RENDERTOEXISTING | AMMSF_RUN)) > + return E_INVALIDARG; This needs tests.

1 0

Re: [1/3] cmd/tests: Show name of current test file on standard output
by Alexandre Julliard Oct. 11, 2012

Oct. 11, 2012

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > When there are several test files, indicates which file error line numbers relate to, making > "debugging" easier. That's what trace() is for. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: use HandleToULong inline function to convert handle to index instead of casting
by Dmitry Timoshkov Oct. 11, 2012

Oct. 11, 2012

Daniel Lehman <dlehman(a)esri.com> wrote: > 0xffffffff000026a8 becomes 0xc00009aa instead of just 0x9aa It can't, the code explicitly casts handle to unsigned before the shift. -- Dmitry.

3 2

Re: [2/2] shlwapi/tests: Add more PathCreateFromUrl() tests.
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22127 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.
by Henri Verbeet Oct. 11, 2012

Oct. 11, 2012

On 11 October 2012 12:16, Jacek Caban <jacek(a)codeweavers.com> wrote: > > +struct _jsstr_t { > + unsigned length_flags; > + unsigned ref; > + WCHAR str[1]; > +}; It's probably much too late for jscript, and perhaps Wine in general, but strictly speaking the _t suffix is reserved by POSIX.

2 1

Re: [PATCH 5/6] mshtml: Added createStyleSheet and get_styleSheet tests
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22123 Your paranoid android. === WVISTAADM (32 bit dom) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0