October 2012 - Wine-Devel - list.winehq.org

Re: msvcp90: fix parsing in num_get<>::_Getifld
by Piotr Caban Oct. 11, 2012

Oct. 11, 2012

On 10/11/12 00:27, Daniel Lehman wrote: - if(!base && first->strbuf && first->val==digits[0]) { + if(first->strbuf && first->val==digits[0]) { + found_zero = TRUE; istreambuf_iterator_wchar_inc(first); if(first->strbuf && (first->val==mb_to_wc('x', &this->cvt) || first->val==mb_to_wc('x', &this->cvt))) { There's a comparision to 'x' 2 times, one of them should be 'X'. Cheers, Piotr

1 0

Re: [PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests (incl. DeleteFile)
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22026 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 4/4] mshtml: Added IHTMLDocument::get_charset implementation
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22114 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] dinput/tests: Test for DIPROP_INSTANCENAME and DIPROP_GUIDANDPATH
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22112 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: wined3d: recognize Radeon HD 6670
by Henri Verbeet Oct. 11, 2012

Oct. 11, 2012

On 5 October 2012 22:12, Austin English <austinenglish(a)gmail.com> wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=31891 > That doesn't look right (and doesn't do what you think it does anyway), did you verify this against the Windows driver? It probably just needs an entry to map "HD 6670" to CARD_AMD_RADEON_HD6600, although it's a bit curious that most of the existing entries for NI have generic strings like "HD 6600".

2 1

Re: shell32: Standardize on the ShellExecuteEx() terminology.
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22104 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: shell32/tests: Test ShellExecute()'s URL handling.
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22103 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1438: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' shlexec.c:1790: Test failed: ShellExecute(file="notaproto://foo") succeeded: rc=2 shlexec.c:1793: Test failed: ShellExecute(file="fakeproto://foo/bar") expected SE_ERR_ACCESSDENIED got rc=2 shlexec.c:152: Test failed: ShellExecute(file="shlproto://foo/bar") Got different return value with empty string: 42 2 shlexec.c:152: Test failed: ShellExecute(file="shlproto://foo/bar.lnk") Got different return value with empty string: 42 2 shlexec.c:1822: Test failed: argvA4 expected 'shlproto://C:\TEMP\wt1.tmp/bar', got 'shlproto://%TMPDIR%/bar' shlexec.c:137: Test failed: ShellExecute(file="file://shlproto://foo/bar") WaitForSingleObject returned 258 shlexec.c:152: Test failed: ShellExecute(file="file://shlproto://foo/bar") Got different return value with empty string: 42 2 shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=42 === W2KPROSP4 (32 bit shlexec) === shlexec.c:1438: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' shlexec.c:1822: Test failed: argvA4 expected 'shlproto://C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp/bar', got 'shlproto://%TMPDIR%/bar' shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=5 === WVISTAADM (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W2K8SE (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W7PRO (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W7PROX64 (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === TEST64_W7SP1 (32 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === W7PROX64 (64 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2 === TEST64_W7SP1 (64 bit shlexec) === shlexec.c:1833: Test failed: ShellExecute(file="file://shlproto://foo/bar") succeeded: rc=2

1 0

Re: vbscript: Fixed tests on some non-English configs (without '.' as decimal point)
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22091 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Undefined variables resolve as EMPTY without Option Explicit
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22090 Your paranoid android. === W2KPROSP4 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === WXPPROSP3 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W2K3R2SESP2 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W7PROX64 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === TEST64_W7SP1 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W7PROX64 (64 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === TEST64_W7SP1 (64 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5"

1 0

Re: shell32: Fix ShellExecute()'s handling of file URLs.
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22079 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: shell32/tests: Simplify shlexec's test_directory() and add some more tests.
by Marvin Oct. 11, 2012

Oct. 11, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22078 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: d3dx9_36 [patch 5/5, try 3]: Implement D3DXSHEvalSphericalLight
by Rico Schüller Oct. 10, 2012

Oct. 10, 2012

On 10.10.2012 09:49, Nozomi Kodama wrote: > math.c:2994: Test failed: Red: case 9, order 7: expected[10] = 0.000000, > received -134495294795062701298349336420239278080.000000 > math.c:2994: Test failed: Red: case 9, order 7: expected[15] = 0.000000, > received -131556728585661638158151798785793064960.000000 But the values are different each time? So no app could depend on the returned values? Does this implementation return the same values? Is everyone else ok with accessing the array out of bounds? > > + for (i = 0; i < order ; i++) > > + scale = cap[i] * coeff[i]; > > + for (order = D3DXSH_MINORDER ; order <= D3DXSH_MAXORDER; order++) Spaces. These are also in the D3DXSHEvalConeLight patch. Is there a point against using the same coeff variables in D3DXSHEvalConeLight and D3DXSHEvalSphericalLight? Maybe they should be static or the capintegral simply should integrate the multiplication if the capintegral function is only used in these two functions. I think there is no need to add the same variables twice. > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; sqrtf .... These are also in the D3DXSHEvalConeLight patch. Does the compiler optimize the function call away to a constant value? If not it may be better to use something like 1.7724538509f for sqrtf(pi)... Cheers Rico

1 0

Re: msvcp90: in codecvt<wchar_t>::do_out, copy local buffer to *to_next
by Piotr Caban Oct. 10, 2012

Oct. 10, 2012

On 10/10/12 19:42, Daniel Lehman wrote: + memcpy_s(*to_next, MB_LEN_MAX, buf, size); You may use memory after to_end in this code. to_next buffer size should be probably following: memcpy_s(*to_next, to_end-to_next, buf, size); Cheers, Piotr

1 0

Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.
by Dmitry Timoshkov Oct. 10, 2012

Oct. 10, 2012

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > + objectName.Buffer = (WCHAR *)&lpFileID->DUMMYUNIONNAME.FileId; This doesn't look right. > + if (status) > + { > + SetLastError( RtlNtStatusToDosError( status ) ); > + return INVALID_HANDLE_VALUE; > + } > + else if (!result) > + { > + return INVALID_HANDLE_VALUE; > + } > + else > + { > + return result; > + } It looks like some braces and all 'else' statements may go. -- Dmitry.

2 2

Re: [PATCH 3/3] vbscript: Added RTrim implementation
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22088 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Add more font transformation tests.
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22066 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22064 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22063 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] shell32/tests: Some more type consistency fixes for the ShellExecute() return value checks.
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22057 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22056 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] shell32/tests: Improve the shell_execute{_ex}() tracing.
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22055 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] shell32/tests: Fix test_one_cmdline() and add a few more tests.
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22054 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d10: Handle blend state in d3d10_effect_object_apply().
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22053 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: mshtml: Return dispinterface from PHEventSink::QueryInterface
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22047 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: vbscript: Added CStr implementation
by Marvin Oct. 10, 2012

Oct. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0