October 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] d3d9/tests: Do not crash, when CreateTexture failed
by Henri Verbeet Oct. 15, 2012

Oct. 15, 2012

On 14 October 2012 01:12, Detlef Riekenberg <wine.dev(a)web.de> wrote: > Needed to avoid a crash on an Intel integrated graphics. > http://test.winehq.org/data/ee59341721b90e58165a7bb12cbf2906fbd680d1/xp_dr-… > It should probably use CheckDeviceFormat() before even creating the device.

1 0

Re: vbscript: Added Chr implementation
by Marvin Oct. 15, 2012

Oct. 15, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22203 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Dan Kegel Oct. 15, 2012

Oct. 15, 2012

In general, patches to wine should have some demonstrated benefit, either by increasing the number of passing conformance tests, or by making some app work better, or both. Your current patch doesn't seem to do either of these things. Getting into a pissing match with AJ about patent and copyright law is not a good strategy for potential contributors to wine. He generally knows his stuff, and I think he's right in this case. If I were you, I'd go off and reflect for a while, then pick some other way to contribute.

3 4

Re: ole32/tests: Add tests for IRunnableObject_Run call.
by Dmitry Timoshkov Oct. 15, 2012

Oct. 15, 2012

Roman Dadkov <romand(a)etersoft.ru> wrote: > + hr = CLSIDFromProgID(WordApp, &clsid); > + if (SUCCEEDED(hr)) > + { > + hr = CoCreateInstance(&clsid, NULL, CLSCTX_ALL, &IID_IUnknown, (void **)&pUnknown); > + ok_ole_success(hr, "CoCreateInstance"); > + > + hr = IUnknown_QueryInterface(pUnknown, &IID_IRunnableObject, (void**)&pRunnableObject); > + ok_ole_success(hr, "IUnknown_QueryInterface"); > + if (FAILED(hr)) Shouldn't 'SUCCEEDED(hr)' be used here instead? > + { > + hr = IRunnableObject_Run(pRunnableObject, NULL); > + ok_ole_success(hr, "IRunnableObject_Run"); > + } > + } Probably you should add Release() calls where appropriate. -- Dmitry.

1 0

Fwd: Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Max TenEyck Woodbury Oct. 13, 2012

Oct. 13, 2012

On 10/12/2012 10:25 PM, Dan Kegel wrote: > Hi Max, > here's a little test program that shows that your patch changes how > UIntToPtr works: > > #include <stdio.h> > #include <stdint.h> > > #define UIntToPtrA(i) ((void *)(intptr_t)((unsigned int)i)) > #define UIntToPtrB(i) ((void *)(intptr_t)(i)) > > int main(int argc, char **argv) > { > short x = 65534; > printf("%d -> %p\n", x, UIntToPtrA(x)); > printf("%d -> %p\n", x, UIntToPtrB(x)); > return 0; > } > > On a 64 bit machine, this outputs > > -2 -> 0xfffffffe > -2 -> 0xfffffffffffffffe > > This could change the behavior of functions that call UIntToPtr, like > say EnumResourceTypesA(). > > I would suggest writing a conformance test to expose whether the > change brings Wine closer to native behavior, or further away, adding > that to your patch, and then verifying with winetestbot that the patch > improves wine's conformance. > > My guess is that the current behavior is right, but hey, the test will > show what's really up. > - Dan > I 'greped' the entire wine tree for uses of these macros. There was only a couple places where the argument was an expression and in those cases I did not see that the change would cause problems. Frankly, I do not think I could come up with a test where the change would make a difference. I am submitting the patch against the weird possibility that such a case does exist. The change is strictly preventative maintenance with just a hint of aesthetic improvement to make them coordinate with the 'Handle' variants of these macros. Now, if you are going to tell me that these definitions were *copied* from a Microsoft *source* rather than derived from a Microsoft specification, you would have a point, but then there would be a whole bunch of copyright issues that would need to be worked through.

2 2

Fwd: Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Max TenEyck Woodbury Oct. 13, 2012

Oct. 13, 2012

On 10/12/2012 09:49 PM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > >>>> -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) >>>> -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) >>>> -#define LongToPtr(l) ((void *)(LONG_PTR)((LONG)l)) >>>> -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) >>>> +#define IntToPtr(i) ((void *)(INT_PTR)(i)) >>>> +#define UIntToPtr(ui) ((void *)(UINT_PTR)(ui)) >>>> +#define LongToPtr(l) ((void *)(LONG_PTR)(l)) >>>> +#define ULongToPtr(ul) ((void *)(ULONG_PTR)(ul)) >>> >>> You forgot to explain what's bad with it. >>> >> >> The original applied the extra conversion to ONLY THE FIRST >> component of the expression, not to the WHOLE expression. That >> can (although it's not likely to) cause hard to diagnose problems. > > What 'the first component' are you talking about? This code is win32 only. > 'i', 'ui', 'l' and 'ul' are parameters to the macros, When the macros are used, you put in an expression as the argument to the macro. As originally written for example, the cast to LONG in ((LONG)l) is applied to only the first component of the expression substituted in place of 'l'. In order to get the cast to apply to the whole expression, you need parenthesis around the parameter. That is literally (l). Then the cast applies to the whole expression. That is (LONG_PTR)(l) casts the entire expression substituted into 'l' to a LONG_PTR value. The macros that convert to 'Handle' rather than 'Ptr' do this properly. In the vast majority of cases the expression substituted into 'l' is a simple variable and there is no problem. In almost all of the remaining cases, casting the first element of the expression coerces the rest of the expression to the proper type. In rare cases, other elements of the expression might force the expression's value to some other type. In most of those cases the cast to LONG_PTR fixes the problem. In a really odd case there might be a problem caused by the extra cast to LONG. Since that cast is buried in a macro definition, it will be difficult to spot that cast as the source of such a problem from the source code. The original definitions include three casts in sequence. The first of those casts is done improperly. Even if it were done properly, the next cast in the sequence makes it redundant. I removed the improper cast since it IS redundant. NUFF SAID?

1 0

Re: [PATCH 1/1] include/basetsd.h: fix bad casting
by Dmitry Timoshkov Oct. 13, 2012

Oct. 13, 2012

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) > -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) > -#define LongToPtr(l) ((void *)(LONG_PTR)((LONG)l)) > -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) > +#define IntToPtr(i) ((void *)(INT_PTR)(i)) > +#define UIntToPtr(ui) ((void *)(UINT_PTR)(ui)) > +#define LongToPtr(l) ((void *)(LONG_PTR)(l)) > +#define ULongToPtr(ul) ((void *)(ULONG_PTR)(ul)) You forgot to explain what's bad with it. -- Dmitry.

3 3

Re: [PATCH] regedit: err() on printing
by Dmitry Timoshkov Oct. 12, 2012

Oct. 12, 2012

Marcus Meissner <meissner(a)suse.de> wrote: > + ERR("printing is not yet implemented.\n"); Printing a FIXME seems more appropriate. -- Dmitry.

2 1

Re: TestBot job 22150 results: [2/3] dwrite: Implement GetWeight() for IDWriteFont
by Nikolay Sivov Oct. 12, 2012

Oct. 12, 2012

This is caused by previously committed patches while testbot was resting, I'll fix these failures after today series gets in if it's okay.

1 0

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)
by Dmitry Timoshkov Oct. 12, 2012

Oct. 12, 2012

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > * Renamed DUMMYUNIONNAME to u. ... > +typedef struct _FILE_ID_DESCRIPTOR { > + DWORD dwSize; > + FILE_ID_TYPE Type; > + union { > + LARGE_INTEGER FileId; > + GUID ObjectId; > + } u; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR; This change is clearly wrong. -- Dmitry.

3 5