Wine-Devel

wine-devel@list.winehq.org

October 2012

70 participants
272 discussions

Re: ws2_32: Fix TRACE format in WS_getsockname
by Dmitry Timoshkov Sept. 30, 2012

Sept. 30, 2012

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > @@ -2444,7 +2444,7 @@ int WINAPI WS_getsockname(SOCKET s, struct WS_sockaddr *name, int *namelen) > int fd; > int res; > > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, *namelen); > > /* Check if what we've received is valid. Should we use IsBadReadPtr? */ > if( (name == NULL) || (namelen == NULL) ) Taking into account check after the trace printing the contents of namelen should be replaced by printing its pointer. -- Dmitry.

1 0

Re: [PATCH 5/5] ntoskrnl.exe: Implement IoAllocateMdl.
by Dmitry Timoshkov Sept. 30, 2012

Sept. 30, 2012

Christian Costa <titan.costa(a)gmail.com> wrote: > PMDL WINAPI IoAllocateMdl( PVOID VirtualAddress, ULONG Length, BOOLEAN SecondaryBuffer, BOOLEAN ChargeQuota, PIRP Irp ) > { > PMDL mdl; > + ULONG address = (ULONG)VirtualAddress; This won't work on 64-bit. > + mdl->StartVa = (PVOID)page_address; and this. > + mdl->ByteCount = Length; > + mdl->ByteOffset = address - page_address; Probably the type of size holding parameters/variables should be SIZE_T. -- Dmitry.

1 0

Jump to page: