November 2012 - Wine-Devel - list.winehq.org

Missing dependencies on static libraries
by Francois Gouget Nov. 13, 2012

Nov. 13, 2012

strmbase is a static library which is used by amstream, qcap, quartz and others. This means functions defined in strmbase end up being included in amstream.dll.so and other places. However modifying the strmbase code does not result in a relink of the dlls that depend on it. Note that this is true even if running make from the top-level directory. That makes it very painful to work with it. Note that the same issue could happen with other static libraries like dxguid, uuid, etc, though those don't contain code and have little reason to change so that that's probably why the problem did not surface until now. How should we fix this? Having amstream recusively run make in strmbase would break parallel builds (the top-level Makefile enforces ordering by having __builddeps__ depend on dlls/strmbase). Would somthing like the patch below be acceptable? Should it be generalized to all the dependencies on uuid, dxguid, etc? commit 0a6764918f743912a1f76ca004ec6d9f0d679b2a Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Nov 9 19:45:21 2012 +0100 strmbase: Relink the dlls that depend on the strmbase static library when it changes. diff --git a/dlls/amstream/Makefile.in b/dlls/amstream/Makefile.in index 35cfae1..5e96f1a 100644 --- a/dlls/amstream/Makefile.in +++ b/dlls/amstream/Makefile.in @@ -12,4 +12,8 @@ IDL_R_SRCS = amstream_classes.idl RC_SRCS = version.rc +$(MODULE).so: $(top_builddir)/dlls/strmbase/libstrmbase.a \ + $(top_builddir)/dlls/strmiids/libstrmiids.a \ + $(top_builddir)/dlls/uuid/libuuid.a + @MAKE_DLL_RULES@ diff --git a/dlls/qcap/Makefile.in b/dlls/qcap/Makefile.in index 3abc295..5f4078d 100644 --- a/dlls/qcap/Makefile.in +++ b/dlls/qcap/Makefile.in @@ -11,4 +11,8 @@ C_SRCS = \ RC_SRCS = version.rc +$(MODULE).so: $(top_builddir)/dlls/strmbase/libstrmbase.a \ + $(top_builddir)/dlls/strmiids/libstrmiids.a \ + $(top_builddir)/dlls/uuid/libuuid.a + @MAKE_DLL_RULES@ diff --git a/dlls/quartz/Makefile.in b/dlls/quartz/Makefile.in index 24be02e..2cbcfe6 100644 --- a/dlls/quartz/Makefile.in +++ b/dlls/quartz/Makefile.in @@ -36,4 +36,9 @@ IDL_TLB_SRCS = control_tlb.idl EXTRA_OBJS = dlldata.o +$(MODULE).so: $(top_builddir)/dlls/dxguid/libdxguid.a \ + $(top_builddir)/dlls/strmbase/libstrmbase.a \ + $(top_builddir)/dlls/strmiids/libstrmiids.a \ + $(top_builddir)/dlls/uuid/libuuid.a + @MAKE_DLL_RULES@ diff --git a/dlls/winegstreamer/Makefile.in b/dlls/winegstreamer/Makefile.in index f6695be..cbf1986 100644 --- a/dlls/winegstreamer/Makefile.in +++ b/dlls/winegstreamer/Makefile.in @@ -12,4 +12,8 @@ C_SRCS = \ RC_SRCS = \ rsrc.rc +$(MODULE).so: $(top_builddir)/dlls/strmbase/libstrmbase.a \ + $(top_builddir)/dlls/strmiids/libstrmiids.a \ + $(top_builddir)/dlls/uuid/libuuid.a + @MAKE_DLL_RULES@ diff --git a/dlls/wineqtdecoder/Makefile.in b/dlls/wineqtdecoder/Makefile.in index 52ee03b..762f837 100644 --- a/dlls/wineqtdecoder/Makefile.in +++ b/dlls/wineqtdecoder/Makefile.in @@ -12,4 +12,8 @@ C_SRCS = \ RC_SRCS = \ rsrc.rc +$(MODULE).so: $(top_builddir)/dlls/strmbase/libstrmbase.a \ + $(top_builddir)/dlls/strmiids/libstrmiids.a \ + $(top_builddir)/dlls/uuid/libuuid.a + @MAKE_DLL_RULES@ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

2 3

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour (try3)
by Dmitry Timoshkov Nov. 13, 2012

Nov. 13, 2012

Piotr Caban <piotr(a)codeweavers.com> wrote: > create mode 100644 dlls/gdi32/tests/test_empty_contour.sfd > create mode 100644 dlls/gdi32/tests/test_empty_contour.ttf Is it possible to add the desired glyph to an already existing test font? -- Dmitry.

3 2

Re: [PATCH 3/6] dsound: create a primary_pwfx separately from pwfx
by Andrew Eikum Nov. 13, 2012

Nov. 13, 2012

Patches 1 and 2 in this series look fine. I have a series of patches similar to this one in my dsound multichannel branch. This patch seems to do too much at once. When I did this cleanup, I split it up into four patches: 1) Allocate the device format in the Device struct 2) Load the default format from the IAC, not hard-coded in dsound 3) Put SetFormat() calls into their own WFX that we don't really care about 4) Always use WAVE_FORMAT_EXTENSIBLE for the device format Much more bisect-able that way. I've attached a tarball here. It's not submission-quality yet (I haven't reviewed it lately; it might not even work), but it should show you what I had in mind for this kind of cleanup. I can bump those up in priority, but I don't think this blocks patches 4-6 in this series anyway. Andrew

3 3

Any advice please... Console input issue
by Ann and Jason Edmeades Nov. 13, 2012

Nov. 13, 2012

Hello, I've been looking at a patch which sorts out NUL and CON handling in a part of the command shell, and have stumbled upon a problem I am not sure how to fix because I really dont understand the underlying console handling, and would appreciate someone pointing me in a direction. For simplicity sake I've cut this down to a tiny test program, which works on windows and fails on wine which does the following: Opens the device ("\\.\CON") with CreateFile with GENERIC_READ rights (which internally opens a CONIN$ device with the same access rights) Reads from the device with ReadFile - Because its a console device, this drops through to ReadConsoleW, which creates a CONOUT$ and then waits on a keystroke - Once the key is pressed (WCEL_Get) the key is 'inserted' into the input buffer by calling WriteConsoleInputW The issue is that WriteConsoleInputW requires GENERIC_WRITE access, but the CON device (\\.\CON) was opened as GENERIC_READ (and in fact fails if I try to open it with GENERIC_WRITE). CreateFile("CONIN$"...) will let me open in GENERIC_READ/GENERIC_WRITE mode and the program works on both windows and wine, but if you open CONIN$ GENERIC_READ only then it fails on wine and works on windows, with the same issue. Now on windows, this works... the question is how to make it work on wine... My gut feeling, with nothing backing this at all, is that WCEL_Get should not use WriteConsoleInputW to inject the values into the input buffer, instead making the server call directly, but passing through to the server call something to indicate that it is ok to add the data to the buffer, but I'm fast getting out of my depth! Thanks for any help! I'll file a bug with my analysis and testcase, but would rather fix the thing! Jason

2 3

Re: [PATCH] wininet: handle failing create_netconn_socket (Coverity)
by Alexandre Julliard Nov. 13, 2012

Nov. 13, 2012

Marcus Meissner <marcus(a)jet.franken.de> writes: > A failing here will free the netconn structure and we should > not use it afterwards. It probably shouldn't free it, this can break in other places too. -- Alexandre Julliard julliard(a)winehq.org

1 0

gdiplus image blitting performance status
by Dmitry Timoshkov Nov. 13, 2012

Nov. 13, 2012

Hi all, I've written a simple test application to measure gdiplus performace. Although currently it tests only GdipDrawImage() it could be easily extended to test anything else if desired. I'm attaching the test source with results running 32-bit test binary with gdiplus=b and gdiplus=n (taken from win7). As could be observed, currently built-in gdiplus performs up to 17 times worse even in identity case in comparison with native gdiplus. With a scale/rotate graphics transform the results are up to 20 times slower. Considerig that built-n gdiplus status regarding support for various complex things is pretty good, perhaps it's time to spend some time optimizing its performans. -- Dmitry.

2 3

Re: [PATCH 7/9] ieframe: Forward more DocHost::Exec calls to embedders
by Marvin Nov. 12, 2012

Nov. 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22897 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3289: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3289: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3289: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3428: Test failed: Creating WebBrowser object failed: 80040154 webbrowser: unhandled exception c0000005 at 0040810F === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2596: Test failed: expected GetOverridesKeyPath webbrowser.c:2601: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2602: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3015: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

4 3

Re: wine.inf: Set the FontSmoothingGamma value.
by Alexandre Julliard Nov. 12, 2012

Nov. 12, 2012

Hans Leidekker <hans(a)codeweavers.com> writes: > Fixes a crash in the .NET 4 runtime which queries this value via > SystemParametersInfo(SPI_GETFONTSMOOTHINGCONTRAST). It shouldn't need the registry key to behave sanely. Does b5d96da32f help? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [advapi32/tests] fix possible NULL pointer dereference
by Alexandre Julliard Nov. 12, 2012

Nov. 12, 2012

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > fixes the crash > http://test.winehq.org/data/1262f07609e6722a841f511445f145d941848800/linux_… > sle85276/advapi32:cred.html That's not supposed to happen, please fix the code instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour (try2)
by Alexandre Julliard Nov. 12, 2012

Nov. 12, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -23,6 +23,8 @@ > /* @makedep: wine_test.ttf */ > wine_test.ttf RCDATA wine_test.ttf > > - > /* @makedep: vertical.ttf */ > vertical.ttf RCDATA vertical.ttf > + > +/* @makedep: test_ttf.ttf */ > +test_ttf.ttf RCDATA test_ttf.ttf Please choose a more meaningful name for that file, particularly since there's already a wine_test.ttf. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mciavi: Fix player deadlock when starting to play.
by Andrew Eikum Nov. 12, 2012

Nov. 12, 2012

Seems reasonable to me. Thanks for working on this old code. On Thu, Nov 08, 2012 at 10:51:08AM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: >

1 0

Re: [PATCH 9/9] ieframe: Added IWebBrowser2::Refresh tests
by Marvin Nov. 12, 2012

Nov. 12, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22898 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3314: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3314: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3314: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3455: Test failed: Creating WebBrowser object failed: 80040154 webbrowser: unhandled exception c0000005 at 0040816F === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2602: Test failed: expected GetOverridesKeyPath webbrowser.c:2607: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2608: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3040: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === TEST64_W7SP1 (64 bit webbrowser) === Timeout

1 0

Re: user32: Initialize string buffer
by Nikolay Sivov Nov. 12, 2012

Nov. 12, 2012

On 11/12/2012 11:33, Alistair Leslie-Hughes wrote: > Hi, > > Should fix http://bugs.winehq.org/show_bug.cgi?id=28797 > > > Changelog: > user32: Initialize string buffer I think it could be GetWindowText problem actually, if it succeeded and left buffer uninitialized that could be a real bug here, so needs tests. > > > Best Regards > Alistair Leslie-Hughes > >

2 1

Re: [PATCH] includes: always add __force_align_arg_pointer__ for i386
by Dmitry Timoshkov Nov. 12, 2012

Nov. 12, 2012

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Fixes flstudio installer on my system, which breaks otherwise in strcasestr_sse42_nonascii > due to stack being misaligned. That's a compiler bug: http://bugs.winehq.org/show_bug.cgi?id=22316 -- Dmitry.

2 1

Question on debugging wineboot..
by Roger Cruz Nov. 12, 2012

Nov. 12, 2012

What is the proper way to debug wineboot and services.exe in order to find out what is causing the error outputted by wineserver below? err:wineboot:start_services_process Couldn't start services.exe: error 1359 wine: failed to update /winearm/winehome with /winearm/bin/../share/wine/wine.inf: No such file or directory My problem is that doing: gdb /winearm/bin/wine C:\\windows\\system32\\wineboot.exe --init will yield the code flow to start_wineboot() again because peb->ProcessParameters->ImagePathName.Buffer is NULL if (peb->ProcessParameters->ImagePathName.Buffer) { strcpyW( main_exe_name, peb->ProcessParameters->ImagePathName.Buffer ); } else { <deleted code> start_wineboot( boot_events ); } So it looks like running GDB on wineboot by itself is not good enough because something from the original process is missing, causing it to think it needs to start wineboot again. The reason I had to start it under its own GDB process is because the original GDB process will not follow the fork() in start_wineboot. How do you guys debug all the processes being fork'ed off when GDB can't follow to the child process? Thanks in advance Roger R. Cruz

1 0

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.
by Michael Stefaniuc Nov. 12, 2012

Nov. 12, 2012

You can't do that as the COM standard specifies also the ABI. A COM interface is a pointer to a virtual table; it is *not* a struct. That's just an implementation detail in C. On 11/10/2012 08:48 PM, max(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max+git(a)mtew.isa-geek.net> > > --- > tools/widl/header.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/tools/widl/header.c b/tools/widl/header.c > index 2f275c7..965dcbc 100644 > --- a/tools/widl/header.c > +++ b/tools/widl/header.c > @@ -1159,6 +1159,17 @@ static void write_com_interface_start(FILE *header, const type_t *iface) > fprintf(header,"#define __%s_%sINTERFACE_DEFINED__\n\n", iface->name, dispinterface ? "DISP" : ""); > } > > +static void write_interface_data_macro(FILE *header, const type_t *iface) > +{ > + > + if (type_iface_get_inherit(iface)) > + write_interface_data_macro(header, type_iface_get_inherit(iface)); > + > + fprintf(header, "#ifdef %s_IFACE_DATA\n", iface->name); > + fprintf(header, " %s_IFACE_DATA\n", iface->name); > + fprintf(header, "#endif /* defined %s */\n", iface->name); > +} > + > static void write_com_interface_end(FILE *header, type_t *iface) > { > int dispinterface = is_attr(iface->attrs, ATTR_DISPINTERFACE); > @@ -1214,6 +1225,9 @@ static void write_com_interface_end(FILE *header, type_t *iface) > fprintf(header, "} %sVtbl;\n", iface->name); > fprintf(header, "interface %s {\n", iface->name); > fprintf(header, " CONST_VTBL %sVtbl* lpVtbl;\n", iface->name); > + > + write_interface_data_macro(header, iface); > + > fprintf(header, "};\n"); > fprintf(header, "\n"); > fprintf(header, "#ifdef COBJMACROS\n"); bye michael

3 6

How to tell Mac from Linux wine within a Wine app? (steam hardware survey)
by Scott Ritchie Nov. 10, 2012

Nov. 10, 2012

Is there an easy way for the steam hardware survey to tell whether it's running under Mac or Linux Wine? I remember discussing this issue with an engineer from Valve after asking they make the % of Wine users public again.

3 3

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.
by Nikolay Sivov Nov. 10, 2012

Nov. 10, 2012

On 11/10/2012 22:48, max(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max+git(a)mtew.isa-geek.net> > > --- > tools/widl/header.c | 14 ++++++++++++++ > 1 files changed, 14 insertions(+), 0 deletions(-) > > diff --git a/tools/widl/header.c b/tools/widl/header.c > index 2f275c7..965dcbc 100644 > --- a/tools/widl/header.c > +++ b/tools/widl/header.c > @@ -1159,6 +1159,17 @@ static void write_com_interface_start(FILE *header, const type_t *iface) > fprintf(header,"#define __%s_%sINTERFACE_DEFINED__\n\n", iface->name, dispinterface ? "DISP" : ""); > } > > +static void write_interface_data_macro(FILE *header, const type_t *iface) > +{ > + > + if (type_iface_get_inherit(iface)) > + write_interface_data_macro(header, type_iface_get_inherit(iface)); > + > + fprintf(header, "#ifdef %s_IFACE_DATA\n", iface->name); > + fprintf(header, " %s_IFACE_DATA\n", iface->name); > + fprintf(header, "#endif /* defined %s */\n", iface->name); > +} > + > static void write_com_interface_end(FILE *header, type_t *iface) > { > int dispinterface = is_attr(iface->attrs, ATTR_DISPINTERFACE); > @@ -1214,6 +1225,9 @@ static void write_com_interface_end(FILE *header, type_t *iface) > fprintf(header, "} %sVtbl;\n", iface->name); > fprintf(header, "interface %s {\n", iface->name); > fprintf(header, " CONST_VTBL %sVtbl* lpVtbl;\n", iface->name); > + > + write_interface_data_macro(header, iface); > + > fprintf(header, "};\n"); > fprintf(header, "\n"); > fprintf(header, "#ifdef COBJMACROS\n"); What is this?

1 0

Re: ole32: Fix outstanding memory leak (coverity)
by Frédéric Delanoy Nov. 10, 2012

Nov. 10, 2012

On Sat, Nov 10, 2012 at 3:57 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > dlls/ole32/storage32.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c > index 8498eaf..4099df6 100644 > --- a/dlls/ole32/storage32.c > +++ b/dlls/ole32/storage32.c > @@ -9067,17 +9067,16 @@ static HRESULT OLECONVERT_GetOLE10ProgID(LPSTORAGE pStorage, char *strProgID, DW > else > { > STATSTG stat; > - LPOLESTR wstrProgID; > + LPOLESTR wstrProgID = NULL; > > /* Get the OleType from the registry */ > REFCLSID clsid = &(stat.clsid); > IStorage_Stat(pStorage, &stat, STATFLAG_NONAME); > hRes = ProgIDFromCLSID(clsid, &wstrProgID); > if(hRes == S_OK) > - { > *dwSize = WideCharToMultiByte(CP_ACP, 0, wstrProgID, -1, strProgID, *dwSize, NULL, FALSE); > + if(wstrProgID) > CoTaskMemFree(wstrProgID); > - } CoTaskMemFree is no-op when given NULL argument so "if(wstrProgID)" is not necessary (since you initialize it to NULL) Frédéric

1 0

Re: [PATCH 1/2] msvcp90: Free memory allocated by _get_current_locale function
by Marvin Nov. 9, 2012

Nov. 9, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22858 Your paranoid android. === WVISTAADM (32 bit misc) === misc: unhandled exception c0000005 at 77496739 === W2K8SE (32 bit misc) === misc: unhandled exception c0000005 at 778A59C3 === W7PRO (32 bit misc) === misc: unhandled exception c0000005 at 772D1FFE === W7PROX64 (32 bit misc) === misc: unhandled exception c0000005 at 77DFE23E === TEST64_W7SP1 (32 bit misc) === misc: unhandled exception c0000005 at 7758E39E === W7PROX64 (64 bit misc) === Timeout === TEST64_W7SP1 (64 bit misc) === Timeout

1 0

The EFF is asking for our help explaining why APIs should not be copyrightable
by Scott Ritchie Nov. 9, 2012

Nov. 9, 2012

https://www.eff.org/deeplinks/2012/11/no-copyrights-apis-help-us-make-case There are court cases pending that are very, very relevant to what we do here. It would help the EFF very much if a few engineers could send them a short email statement explaining how Wine's reimplementation of the API is good for interoperability and competition. Thanks, Scott Ritchie

2 1

[PATCH 1/2] winmm/tests: Add more mmioSeek tests.
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 9, 2012

Nov. 9, 2012

Sagawa San, it's nice to see somebody contribute to winmm! + return; +} That return is line noise. + hmmio = mmioOpen(NULL, &mmio, MMIO_READ); + if (hmmio == NULL) { + win_skip("mmioOpen error %u\n", mmio.wErrorRet); + return; + } AFAIK mmioOpen has always been present, so there's no reason for a win_skip. An error should be flagged in all cases, Wine or native. Furthermore, the early return prevents execution of the other groups of tests. Hence I suggest: + hmmio = mmioOpen(NULL, &mmio, MMIO_READ); + ok(hmmio != NULL, "mmioOpen error %u\n", mmio.wErrorRet); + if (hmmio) { mmioSeek ... mmioClose } However, the 2nd and 3rd mmioOpen may fail if the test file could not be created, so you may want a different treatment there. Perhaps add a boolean result to create_test_file? >[PATCH 2/2] winmm: Fix SEEK_END direction of mmio files without buffering. It's always good in a patch submission to mention what bug it fixes. Does yours fix bug 19566? I seem to remember that there was an entry in bugzilla about MMIO and seeking... Oh yes, you may look at bug 28982, perhaps your patch fixes that too. Regards, Jörg Höhle

2 2

Re: [PATCH 1/2] gdi32: Ignore contours containing one point in get_glyph_outline function
by Piotr Caban Nov. 9, 2012

Nov. 9, 2012

Please ignore this patches for now, the tests are broken.

1 0

Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient.
by Alexandre Julliard Nov. 9, 2012

Nov. 9, 2012

Christian Costa <titan.costa(a)gmail.com> writes: > + SetLastError(0xdeadbeef); > + n = MapWindowPoints(wnd, NULL, NULL, 0); > + err = GetLastError(); > + ok(n == ((window_rect.top << 16) | window_rect.left), "Got %x (%d, %d), expected %x (%d, %d)\n", > + n, (n << 16) >> 16, n >> 16, window_rect.left, window_rect.top, (window_rect.top << 16) | window_rect.left); > + ok(err == 0xdeadbeef, "Got %x, expected %x\n", err, 0xdeadbeef); > + > + SetLastError(0xdeadbeef); > + n = MapWindowPoints(NULL, wnd, NULL, 0); > + err = GetLastError(); > + ok(n == ((-window_rect.top << 16) | (-window_rect.left & 0xffff)), "Got %x (%d, %d), expected %x (%d, %d)\n", > + n, (n << 16) >> 16, n >> 16, (-window_rect.top << 16) | (-window_rect.left & 0xffff), -window_rect.left, -window_rect.top); > + ok(err == 0xdeadbeef, "Got %x, expected %x\n", err, 0xdeadbeef); Testing last error on success is not useful. Also please use MAKELONG and related macros instead of doing it by hand. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour
by Marvin Nov. 9, 2012

Nov. 9, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22852 Your paranoid android. === WVISTAADM (32 bit font) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0