November 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] msvcp90: Use critical sections in mutex object (try2)
by Alexandre Julliard Nov. 2, 2012

Nov. 2, 2012

Piotr Caban <piotr(a)codeweavers.com> writes: > try2: > - free allocated memory in mutex_dtor > --- > dlls/msvcp100/misc.c | 18 ++++++++++++++---- > dlls/msvcp100/msvcp.h | 2 +- > dlls/msvcp60/misc.c | 16 ++++++++++++---- > dlls/msvcp71/misc.c | 18 ++++++++++++++---- > dlls/msvcp71/msvcp.h | 2 +- > dlls/msvcp90/misc.c | 18 ++++++++++++++---- > dlls/msvcp90/msvcp90.h | 2 +- > 7 files changed, 57 insertions(+), 19 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msvcp90.dll -T ../../.. -p msvcp90_test.exe.so ios.c && touch ios.ok err:ntdll:RtlpWaitForCriticalSection section 0x111448 "misc.c: _Mutex critical section" wait timed out in thread 0025, blocked by 0000, retrying (60 sec) wine: Critical section 00111448 wait failed at address 0x7bc373e2 (thread 0025), starting debugger... Unhandled exception: wait failed on critical section 0x00111448 in 32-bit code (0x7bc373e2). -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Call for papers - FOSDEM 2013
by Dan Kegel Nov. 2, 2012

Nov. 2, 2012

Francois wrote: > (*) A particularly interesting one to me is testing untrusted code on > real hardware (with possible approaches being direct access to a > graphics card from within a VM I had some fun googling your wishlist. Presumably you've seen some of these links already: http://wiki.xen.org/wiki/Xen_VGA_Passthrough http://arstechnica.com/information-technology/2012/10/nvidias-vgx-cards-bri… > or network booting (plus remote > controlled power switch?), Grub tricks). http://www.amd64.org/support/automated-test-infrastructure.html looks like it does all of the above? http://developer.amd.com/tools/opensource/AMDTapper/Pages/default.aspx A few other possibly interesting links: http://wiki.debian.org/GrubReboot http://www.passmark.com/products/rebooter.htm http://people.redhat.com/mrodrigu/slides/linuxcon-2011-autotest-lmr There are many similar pages, all somewhat buried, stale, and possibly too specific. > Another may be testing on non-VM friendly OSes, specifically Mac OS X, > though that may just be a matter of doing a more in-depth Google search > to find a legal and libvirt-compatible solution. vmware seems to work, though I haven't tried it myself yet: http://lsimons.wordpress.com/2011/06/02/libvirt-vmware-fusion-mac-os-x/ - Dan

1 0

Re: scrrun: Implement IDictionary get_HashVal (try 2)
by Piotr Caban Nov. 2, 2012

Nov. 2, 2012

On 11/02/12 10:49, Alistair Leslie-Hughes wrote: +static LONG create_hash_val(BSTR name) +{ + LONG hash = 0; + int len = SysStringLen(name); The hash should be unsigned. + if(V_VT(Key) != VT_R8) + hr = VariantChangeType(&real, Key, 0, VT_R8); I'm not sure if you want to use VariantChangeType here. I guess it's better to support few basic types and print a fixme message if type is not supported. + if(!isinf(fval)) Probably NaN is handled differently as well. port.h header is missing. + V_VT(&key) = VT_R8; + V_R8(&key) = INFINITE; You can't use INFINITE here.

1 0

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.
by Andrew Eikum Nov. 1, 2012

Nov. 1, 2012

That's a lot of patches! In the future, please try to send no more than about 5 at a time, until each batch is committed. That's much easier to review. I reviewed the first 12, and will do the rest after those are committed. Just reading the patches, I didn't notice any show-stoppers. Overall looks good to me. A couple of thoughts below. On Thu, Oct 04, 2012 at 01:49:13PM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: >+ switch (wmm->dwStatus) { >+ case MCI_MODE_PLAY: >+ case MCI_MODE_PAUSE: >+ wmm->dwStatus = MCI_MODE_STOP; >+ } This is weird. You're "missing" a break, and it seems like an if statement would be more appropriate here, anyway. Aside from that, you introduce a scary magic number, 0x78B0. I guess that's the MIDI sound off + control message. It would be nice if it was a proper symbol, but native's headers don't give us MIDI symbols, and there are a lot to define. So maybe it's not worth it. Anyway, something to think about cleaning up in the future. Thanks for improving this code! Andrew

5 16

Re: [PATCH 1/3] advapi: Return the current user as the owner of files (resend 4).
by Alexandre Julliard Nov. 1, 2012

Nov. 1, 2012

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > This particular patch changes the ACL-reported owner of files from the > "world" (S-1-1-0) to the current user (usually S-1-5-21-0-0-0-1000). I'm not sure that's much better. We should try to determine the actual ownership. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winhttp: Fix the error returned from WinHttpGetProxyForUrl when autodetection fails.
by Marvin Nov. 1, 2012

Nov. 1, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22654 Your paranoid android. === WXPPROSP3 (32 bit winhttp) === winhttp.c:2405: Test failed: got 80072ee2 winhttp.c:2411: Test failed: got 8000000a

2 1