December 2012 - Wine-Devel - list.winehq.org

Re: oleaut32: Indentation Fix
by Alexandre Julliard Dec. 20, 2012

Dec. 20, 2012

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > Changelog: > oleaut32: Indentation Fix. Please avoid reformatting hundreds of lines for no reason. Only fix the parts where the indentation is actually incorrect. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: windowscodecs: Adjust a type in PngDecoder_Frame_GetColorContexts.
by Alexandre Julliard Dec. 19, 2012

Dec. 19, 2012

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Current snapshots of GCC 4.8.0 issue a warning about some of the > new code in windowscodecs/pngformat.c: > > pngformat.c: In function 'PngDecoder_Frame_GetColorContexts': > pngformat.c:882:5: warning: passing argument 5 of 'ppng_get_iCCP' from > incompatible pointer type [enabled by default] > if (ppng_get_iCCP(This->png_ptr, This->info_ptr, &name, &compression_type,&profile, &len)) > pngformat.c:882:5: note: expected 'png_bytepp' but argument is of type 'char **' > > The patch below addresses this. That will break on older libpng. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)
by Alexandre Julliard Dec. 19, 2012

Dec. 19, 2012

Eric Pouech <eric.pouech(a)orange.fr> writes: > The following series implements a new scheme for managing 'bare' consoles. > We now force every program started without a wine parent to be run under > wineconsole (transparently for the user). > This is done using a new backend in wineconsole called 'line'. This backend > only takes care of input; output is kept as a client side operation. > All terminal related code is moved from dlls/kernel32 to programs/wineconsole. > > This basically ensures that: > - Only wineconsole reads from standard input (and writes into input queue). > This fixes bug reported by Jason when $CONIN is opened with read access only. > - It also enforces that wineconsole always has control of the unix terminal, > hence ensuring that we properly reset the terminal settings upon exit. > > Code looks way cleaner now. > > Try #2 (changes from previous patch) > - fix changelog of first patch (was WineHelp...) > - fix date in header for new file > - remove setting title code (will be fixed in later patch) Actually the problem is not only the title. For instance it's still sending escape sequences when stdout is redirected. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: wininet: Map socket errors to ERROR_INTERNET_CANNOT_CONNECT in create_netconn_socket.
by Marvin Dec. 19, 2012

Dec. 19, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23542 Your paranoid android. === W7PRO (32 bit http) === http.c:3337: Test failed: HttpSendRequest failed: 12002

2 1

Re: dsound: change mix rate of primary buffer
by Andrew Eikum Dec. 18, 2012

Dec. 18, 2012

On Tue, Dec 18, 2012 at 08:08:03PM +0100, sebastien chev wrote: > Thank you for the tips. I will look at these. > I guess you're probably also thinking about the mix buffer in dsound itself. That does always mix to float, and there isn't a way to change it right now. What are you planning to use this for? We could support different mix buffer formats, but I'm not sure this use case is worth the effort. Andrew

1 0

Clang static analyzer results / wine-1.5.19-186-g1cd0c4a
by Austin English Dec. 18, 2012

Dec. 18, 2012

Now that http://source.winehq.org/git/wine.git/commitdiff/4adfb787f4e8c36a37ce1d53a7… is in (and clang has improved), several wine/clang bugs are fixed. For those curious, there is one remaining test failure on my machine, with clang instead of gcc: http://bugs.winehq.org/show_bug.cgi?id=25828 The static analyzer results were made with: llvm: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk(a)170295 91177308-0d34-0410-b5e6-96231b3b80d8 clang: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk(a)170294 91177308-0d34-0410-b5e6-96231b3b80d8 wine: wine-1.5.19-186-g1cd0c4a ./configure --disable-tests was used to reduce noise austin(a)debian-home:~$ du -h wine-1.5.19-186-g1cd0c4a.tar.bz2 39M wine-1.5.19-186-g1cd0c4a.tar.bz2 austin(a)debian-home:~$ sha1sum wine-1.5.19-186-g1cd0c4a.tar.bz2 bf86469ab3929faf996b76d4a8e533edcf24fd29 wine-1.5.19-186-g1cd0c4a.tar.bz2 Available at http://www.mediafire.com/?0gioifbgw363az3 -- -Austin

1 0

winealsa: Separate read and write pointers.
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 18, 2012

Dec. 18, 2012

Andrew Eikum wrote: >This [lock-less] seems to be the main goal of the patch. It'll not be bad to fix the capture bug independently. >and maybe we can get that into Wine after the next release? That requires agreement on the lock-less protocol. Basis: atomic 32bit updates. Do we want distinguished alignment declarations for e.g. This->held_frames? Write: InterlockedExchange/Increment/etc. is clear Read: Open for discussion Basically, all I need is a snapshot of a 32bit entity, i.e. an atomic read. The code doesn't bother whether that value is stale or not. It works in either case. All that is required is that it's updated some time eventually (i.e. not running off local cache for hours). Back in the old days, people used foo = (volatile X) bar; or even volatile X bar; ... foo=bar; Such code has been present e.g. in mciseq for the last 10 years. Currently, this has my preference for Intel: foo = bar; // e.g. held = This->held_frames; __asm__ __volatile__("":::"memory"); /* compiler barrier is enough for x86 */ I wouldn't be opposed to held = (volatile DWORD) This->held_frames; Purists spit at volatile for threading, but that's what has been used for decades and continues to be used (just google some random threading app...) I've also suggested InterlockedExchange(&held, This->held_frames) but that's just wasting a read of the obsolete value of held. So why use that form? Do we need to care for anything else than Intel? One may envision other approaches, e.g. a second critical section for the callback and Start/Stop only. But This->held_frames is updated within IAC_Get/ReleaseBuffer, so that doesn't solve the issue. POSIX purists would say that a protocol is needed between the two communicating threads (the Get/Release one and the cb, not the Start/Stop thread). But I don't care about POSIX requirements imposed by weird 8/16/24/32/40/64 bit HW and strange non-UNIX systems when the target is Wine-Is-Not-an-Emulator. Regards, Jörg Höhle

1 0

Re: winealsa: Separate read and write pointers.
by Andrew Eikum Dec. 18, 2012

Dec. 18, 2012

On Mon, Dec 17, 2012 at 05:01:29PM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Furthermore, this patch eases integration of my lock-less code, which > I'll not release for now, by cleanly separating read and write > pointers during playback and capture. No more adding of two volatile > entities moving in opposite directions! > This seems to be the main goal of the patch. I tested it against my usual set of applications both with and without PulseAudio. This patch seems fine to me. I'll take a look at your lockless patch on bug 29531, and maybe we can get that into Wine after the next release? Andrew

1 0

dsound: change mix rate of primary buffer
by sebastien chev Dec. 18, 2012

Dec. 18, 2012

It seems that no matter what the Windows side program choose for DirectSoundCreate, the DSound subsystem initialize itself with the higher spec sound available (for example 48Khz Float32, or 48kHz Int16 if no Float32 available). While not a big deal on current linux PC, using this on ARM device kill performance. A DirectSound subsystem for ARM, with Integer only for the mixbuffer (as most ARM still use softfloat) and 22kHz should be less taxing for performances.

2 1

Re: mmdevapi: Prevent race condition upon Start.
by Alexandre Julliard Dec. 18, 2012

Dec. 18, 2012

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > What happened every so often, even on a single-core machine(!), is > that CreateTimerQueue(dueTime=0=immediate) would see the timer thread > created and the callback invoked before the function returns. Since > This->started was not set yet, our callback would return immediately, > in effect causing sound to start only one 10ms period later. > That's obviously was not intended by the author. > So let's set This->started before CTQ. This doesn't make sense, there's a critical section. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: oleaut32: Dont output an error when the typelib cannot be found
by Alexandre Julliard Dec. 18, 2012

Dec. 18, 2012

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index fa9b050..04914e0 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -2544,9 +2544,11 @@ static HRESULT TLB_PEFile_Open(LPCWSTR path, INT index, LPVOID *ppBase, DWORD *p > return S_OK; > } > } > - > - hr = E_FAIL; > } > + > + TRACE("No TYPELIB resource found\n"); > + hr = E_FAIL; > + SetLastError(0); Setting last error to 0 is almost always wrong. In this case it's most likely just a side effect of CreateFile, and shouldn't need to be done explicitly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Does Wine benefit from libtiff5 over libtiff4?
by Scott Ritchie Dec. 18, 2012

Dec. 18, 2012

I'm trying to manage building for 3 different Ubuntu releases now for our 1.5 releases, and the main delta between them is libtiff 12.04: libtiff4 available 12.10: libtiff4 and libtiff 5 available 13.04: libtiff4 and libtiff 5 available It's much simpler if I can build on 12.04 and copy the binary packages, however this means I can't use libtiff5 if I do so. Is there any benefit in doing a separate build just for this? *note that in 12.10/13.04 official archive we build seperately and just use libtiff5. Thanks, Scott Ritchie

3 3

Call for papers - FOSDEM 2013
by Jeremy White Dec. 17, 2012

Dec. 17, 2012

Alright folks, We need to put together a schedule for our room at FOSDEM. So I would like to formally 'call for papers' for FOSDEM. Please email suggested topics to wineconf(a)winehq.org, where I'll collate them and piece them into a schedule. A 'paper' can be a talk you wish to give, or a topic you think we should discuss. As always, they should be relatively brief, and should emphasize discussion and collaboration. This year it probably makes sense to imagine a few talks aimed at developers outside the Wine community. After all, the hope is that a few bored non Wine developers may wander by from time to time. Perhaps we can suck them in <grin>. Cheers, Jeremy

5 7

Re: [PATCH 3/8] winemac: Implement GetDeviceCaps().
by Alexandre Julliard Dec. 17, 2012

Dec. 17, 2012

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/winemac.drv/Makefile.in | 1 + > dlls/winemac.drv/gdi.c | 321 ++++++++++++++++++++++++++++++++++++++++- > dlls/winemac.drv/macdrv.h | 101 +++++++++++++ > 3 files changed, 415 insertions(+), 8 deletions(-) > create mode 100644 dlls/winemac.drv/macdrv.h It doesn't build here on OS X 10.5.8: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -gstabs+ -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o gdi.o gdi.c gdi.c: In function 'device_init': gdi.c:143: error: 'CGDisplayModeRef' undeclared (first use in this function) gdi.c:143: error: (Each undeclared identifier is reported only once gdi.c:143: error: for each function it appears in.) gdi.c:143: error: syntax error before 'mode' gdi.c:160: error: 'mode' undeclared (first use in this function) gdi.c:162: warning: implicit declaration of function 'CGDisplayModeCopyPixelEncoding' gdi.c:162: warning: initialization makes pointer from integer without a cast gdi.c:164: warning: implicit declaration of function 'CGDisplayModeGetWidth' gdi.c:165: warning: implicit declaration of function 'CGDisplayModeGetHeight' gdi.c:178: warning: implicit declaration of function 'CGDisplayModeRelease' make[1]: *** [gdi.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 6

[PATCH 0/3] Add O_DENY* flags to fcntl and cifs
by Pavel Shilovsky Dec. 17, 2012

Dec. 17, 2012

Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this change can benefit cifs and nfs modules. While this change is ok for network filesystems, itsn't not targeted for local filesystems due security problems (e.g. when a user process can deny root to delete a file). Share flags are used by Windows applications and WINE have to deal with them too. While WINE can process open share flags itself on local filesystems, it can't do it if a file stored on a network share and is used by several clients. This patchset makes it possible for CIFS/SMB2.0/SMB3.0. Pavel Shilovsky (3): fcntl: Introduce new O_DENY* open flags for network filesystems CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts fs/cifs/cifsacl.c | 10 ++++---- fs/cifs/cifsglob.h | 11 ++++++++- fs/cifs/cifsproto.h | 9 ++++---- fs/cifs/cifssmb.c | 47 ++++++++++++++++++++------------------ fs/cifs/dir.c | 14 ++++++++---- fs/cifs/file.c | 18 ++++++++++----- fs/cifs/inode.c | 11 +++++---- fs/cifs/link.c | 10 ++++---- fs/cifs/readdir.c | 2 +- fs/cifs/smb1ops.c | 15 ++++++------ fs/cifs/smb2file.c | 10 ++++---- fs/cifs/smb2inode.c | 4 ++-- fs/cifs/smb2ops.c | 10 ++++---- fs/cifs/smb2pdu.c | 6 ++--- fs/cifs/smb2proto.h | 14 +++++++----- fs/fcntl.c | 5 ++-- include/uapi/asm-generic/fcntl.h | 11 +++++++++ 17 files changed, 125 insertions(+), 82 deletions(-) -- 1.7.10.4

11 28

Re: [PATCH 3/6] jscript: Fixed deleting nonexistent identifiers
by Marvin Dec. 17, 2012

Dec. 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23454 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] jscript: Fixed deleting nonexisting properties from member expression
by Marvin Dec. 17, 2012

Dec. 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23453 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Fixed Number.toFixed for value 0 with 0 precision
by Marvin Dec. 17, 2012

Dec. 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23452 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: msvcrt: implement _strxfrm_l
by Piotr Caban Dec. 17, 2012

Dec. 17, 2012

On 12/14/12 10:28, Jérôme Gardou wrote: > --- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/string.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 3 deletions(-) > Please add parameters validation. The function also behaves differently with native msvcrt when output buffer is to small. This function should return data that keeps sorting order. It should use LCMAP_SORTKEY flag. Cheers, Piotr

1 0

Re: winex11.drv: give a better warning for broken drivers on 64-bit OS's
by Austin English Dec. 17, 2012

Dec. 17, 2012

On Sun, Dec 16, 2012 at 2:31 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin Wrong macro, please ignore. -- -Austin

1 0

Re: [PATCH 2/3] [resend] [cmd] Add more tests for set /a
by Marvin Dec. 17, 2012

Dec. 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23440 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') === W2KPROSP4 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === WXPPROSP3 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === W2K3R2SESP2 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === WVISTAADM (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === W2K8SE (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === W7PRO (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === W7PROX64 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === TEST64_W7SP1 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === W7PROX64 (64 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]') === TEST64_W7SP1 (64 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 816 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 819 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 822 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 825 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 828 (got 'WINE_baz correctly 3', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 832 (got 'WINE_baz correctly 2', wanted 'WINE_baz correctly 1') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 860 (got 'WINE_baz correctly 7', wanted 'WINE_baz correctly 6(a)or_broken@ERROR: WINE_baz incorrectly [7]')

1 0

cmd patches - please ignore them
by Ann and Jason Edmeades Dec. 17, 2012

Dec. 17, 2012

Dont know what's happened, need to investigate further - Had 100% pass rate in job 23438 only to fail on submission... Needs some investigation so will work on it later in the week Jason

1 0

Re: [PATCH 1/3] [try2] [cmd] Convert the set /a tests to validate better
by Marvin Dec. 17, 2012

Dec. 17, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23439 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === W2KPROSP4 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === WXPPROSP3 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === W2K3R2SESP2 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === WVISTAADM (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === W2K8SE (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === W7PRO (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === W7PROX64 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === TEST64_W7SP1 (32 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === W7PROX64 (64 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19') === TEST64_W7SP1 (64 bit) === batch.c:312: Test failed: unexpected char 0x57 position 0 in line 778 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 3(a)or_broken@ERROR: WINE_baz incorrectly [4]') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 802 (got 'WINE_baz correctly 4', wanted 'WINE_baz correctly 19')

1 0

Re: wined3d: Recognize Nvidia GTX660 cards.
by Bruno Jesus Dec. 16, 2012

Dec. 16, 2012

On Fri, Dec 14, 2012 at 2:01 PM, Caron Jensen <caron(a)codeweavers.com> wrote: > CARD_NVIDIA_GEFORCE_GT630M = 0x0de9, > CARD_NVIDIA_GEFORCE_GT640M = 0x0fd2, > CARD_NVIDIA_GEFORCE_GT650M = 0x0fd1, > + CARD_NVIDIA_GEFORCE_GTX660 = 0X1183, > CARD_NVIDIA_GEFORCE_GTX670 = 0x1189, > CARD_NVIDIA_GEFORCE_GTX680 = 0x1180, Accoding to the similar patch from Jiang Yike "GTX660 Ti" is 0x1183, I looked for GTX660 and found different PCI ID's like 0x1185 or 0x110C but I could not find this information in NVIDIA site, only in other sites: https://fah-web.stanford.edu/file-releases/public/GPUs.txt http://pciids.sourceforge.net/pci.ids http://www.techpowerup.com/vgabios/126661/Asus.GTX660.2048.120810.html http://foldingforum.org/viewtopic.php?f=83&t=22477 Best wishes, Bruno

1 0

Re: wined3d: Recognize Nvidia GTX660 cards.
by futureway＠asia.com Dec. 16, 2012

Dec. 16, 2012

Hello, Caron! GTX 660 and GTX 660 Ti are different cards, and 0x1183 is the device code of GTX 660 Ti. You may view my patch: http://source.winehq.org/patches/data/92545 . Best regards! Jiang Yike > ----- Original Message ----- > From: Caron Jensen > Sent: 12/15/12 12:01 AM > To: wine-patches > Subject: wined3d: Recognize Nvidia GTX660 cards. > > --- > dlls/wined3d/directx.c | 3 +++ > dlls/wined3d/wined3d_private.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 15ac2ea..386c87a 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1095,6 +1095,7 @@ static const struct gpu_description gpu_description_table[] = > {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GT630M, "NVIDIA GeForce GT 630M", DRIVER_NVIDIA_GEFORCE6, 1024}, > {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GT640M, "NVIDIA GeForce GT 640M", DRIVER_NVIDIA_GEFORCE6, 1024}, > {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GT650M, "NVIDIA GeForce GT 650M", DRIVER_NVIDIA_GEFORCE6, 2048}, > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX660, "NVIDIA GeForce GTX 660", DRIVER_NVIDIA_GEFORCE6, 2048}, > {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX670, "NVIDIA GeForce GTX 670", DRIVER_NVIDIA_GEFORCE6, 2048}, > {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX680, "NVIDIA GeForce GTX 680", DRIVER_NVIDIA_GEFORCE6, 2048}, > > @@ -1495,6 +1496,7 @@ static enum wined3d_pci_device select_card_nvidia_binary(const struct wined3d_gl > { > {"GTX 680", CARD_NVIDIA_GEFORCE_GTX680}, /* Geforce 600 - highend */ > {"GTX 670", CARD_NVIDIA_GEFORCE_GTX670}, /* Geforce 600 - midend high */ > + {"GTX 660", CARD_NVIDIA_GEFORCE_GTX660}, /* Geforce 600 - midend */ > {"GT 650M", CARD_NVIDIA_GEFORCE_GT650M}, /* Geforce 600 - midend mobile */ > {"GT 640M", CARD_NVIDIA_GEFORCE_GT640M}, /* Geforce 600 - midend mobile */ > {"GT 630M", CARD_NVIDIA_GEFORCE_GT630M}, /* Geforce 600 - midend mobile */ > @@ -2018,6 +2020,7 @@ static enum wined3d_pci_device select_card_nvidia_mesa(const struct wined3d_gl_i > { > /* Kepler */ > {"NVE4", CARD_NVIDIA_GEFORCE_GTX680}, > + {"NVE7", CARD_NVIDIA_GEFORCE_GTX660}, > /* Fermi */ > {"NVCF", CARD_NVIDIA_GEFORCE_GTX550}, > {"NVCE", CARD_NVIDIA_GEFORCE_GTX560}, > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 0bb3f27..13f9285 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1425,6 +1425,7 @@ enum wined3d_pci_device > CARD_NVIDIA_GEFORCE_GT630M = 0x0de9, > CARD_NVIDIA_GEFORCE_GT640M = 0x0fd2, > CARD_NVIDIA_GEFORCE_GT650M = 0x0fd1, > + CARD_NVIDIA_GEFORCE_GTX660 = 0X1183, > CARD_NVIDIA_GEFORCE_GTX670 = 0x1189, > CARD_NVIDIA_GEFORCE_GTX680 = 0x1180, > > -- > 1.7.9.5 >

1 0