December 2012 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Web based translation tool
by Michal Čihař June 17, 2013

June 17, 2013

Hi Dne Mon, 12 Mar 2012 12:02:49 +0200 Yaron Shahrabani <sh.yaron(a)gmail.com> napsal(a): > The Wine project is thinking about using Weblate in order to translate > Wine, you can look at the following discussion and see for yourself. That sounds great! > Looking good although a litle immature, not sure about authentication as > wel... For authentication you can basically use anything what can be used in Django. Any specific concerns on this topic? > I'll talk to Michal Cihar and ask him for a roadmap for this project. Well I don't have any real roadmap right now. I urgently needed replacement for Pootle because we got hit by too many bugs there and did not manage to understand the code there to be able to fix them myself. So far I think it is in pretty good shape for day to day work (with today's 0.5 release fixing few annoying bugs). Of course there are some features missing, you can check what I plan for 1.0 release here: https://github.com/nijel/weblate/issues?state=open&milestone=1 I currently hope to have 1.0 in a month or so, but I really don't want to commit to any specific date. PS: I'm not subscribed to mailing list so please CC me on reply. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

7 16

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)
by Dmitry Timoshkov Jan. 5, 2013

Jan. 5, 2013

Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > + BYTE buffer[MAX_PATH]; This should be WCHAR if you decided to test unicode version of the API (although testing ANSI variant would be much easier), that will help to avoid all those casts, and protect from insufficient buffer size. Also please use a font that exists in Wine, such as sserife.fon, but be prepared that it could be not found since font file name is locale dependent. -- Dmitry.

2 4

wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole
by Alan W. Irwin Jan. 2, 2013

Jan. 2, 2013

The subject line pretty much says it all. Running MinGW/gcc under wineconsole for any simple test programme should demonstrate the issue for wine-1.5.20 which is not present in wine-1.5.19 and a fairly large selection of 1.5.x and MinGW versions I have tried over the last year or so. I would be happy to supply more details if there is any difficulty replicating this reversion. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

3 7

Re: xbox 360 emulation with logitech cordless and dinput joy disable
by Stefan Dösinger Jan. 1, 2013

Jan. 1, 2013

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

3 2

Re: [PATCH] dsound: rework ugly mixer logic
by Andrew Eikum Jan. 1, 2013

Jan. 1, 2013

On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote: > + if(!maxq){ > + /* nothing to do! */ > + LeaveCriticalSection(&device->mixlock); > + return; > } This was removed in 8ba4090fc304993. It breaks starting the device in some situations (write primary mode iirc). > + if (native) { > + void *buffer = NULL; > + > + hr = IAudioRenderClient_GetBuffer(device->render, maxq / block, (void*)&buffer); > + if(FAILED(hr)){ > + WARN("GetBuffer failed: %08x\n", hr); > + LeaveCriticalSection(&device->mixlock); > + return; > + } I think this (mixing directly to RenderClient and skipping WaveQueue) could be split into a separate patch. > hres = IAudioClient_Initialize(device->client, > AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | > - AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); > + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 800000, 0, device->pwfx, NULL); ... > + frames = (UINT64)device->pwfx->nSamplesPerSec * 800000 / 10000000; Could you #define the 800000? Anyway, I gave it a test on ALSA+Pulse and didn't find any issues. I'll test the other backends when you resubmit. Andrew

2 3

Mail problems for wine-patches
by Detlef Riekenberg Dec. 31, 2012

Dec. 31, 2012

I send several patches the last days with git and with the webmail interface from web.de, but nothing arrived at the wine-patches archive or the patches queue page. I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? -- By by ... Detlef

2 1

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper
by Marvin Dec. 31, 2012

Dec. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

1 0

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper
by Marvin Dec. 31, 2012

Dec. 31, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

1 0

Help Splitting Patches
by Adam Martinson Dec. 31, 2012

Dec. 31, 2012

Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. ~Adam

2 1

[AppDB] Cannot submit rejected Test results after change
by Joerg Schiermeier Dec. 30, 2012

Dec. 30, 2012

¡Hola! In AppDB I got a problem, exactly with one of my maintained applications: some days ago someone filed a test about the mail program 'The Bat!'. This test has this URL: <http://appdb.winehq.org/objectManager.php?sClass=version&iId=23662&iTesting…> So AppDB sent me an email about this test and I went to its web interface. There I rejected this test result because of some incorrect version numberings. Than I got some days later a mail about a new submitted test. I logged into AppDB again to my control panel but I didn't saw this new submitted test there. So I had and have no change to commit this test results. If you follow the link above you will see: the test results are still there. So my conclusion: 1.) Someone, maybe you will have to commit this test. 2.) Something went wrong with the AppDB. Thanks for your attention and your help! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: d3dx9: Implement D3DXSHEvalConeLight [try 4]
by Marvin Dec. 30, 2012

Dec. 30, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23666 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K3R2SESP2 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === WVISTAADM (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K8SE (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PRO (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === TEST64_W7SP1 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351 === TEST64_W7SP1 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351

1 0

Re: [PATCH 2/2] kernel32: conditional variable support
by Nikolay Sivov Dec. 29, 2012

Dec. 29, 2012

On 12/29/2012 23:04, Marcus Meissner wrote: > From: Marcus Meissner <marcus(a)jet.(none)> > > Modeled pretty much after the implementation described > in glibc/nptl/DESIGN-condvar.txt with its futex usage > sofar replaced by regular Win32 Semaphores. > > An additional futex implementation is possible. > > I *think* I have the semantics correct, there is 1 small > place where it might have unnecessary CPU usage though. > > Ciao, Marcus > +/********************************************************************** > + * InitializeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI InitializeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condition_var_intern *var; > + variable->Ptr = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(struct _condition_var_intern)); > + var = variable->Ptr; > + if (!var) return; > + InitializeCriticalSection (&var->crit); > + var->crit.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": ConditionVariable.cs"); > +} I don't think it allocates anything at all, what makes me believe that is that stuff like CONDITION_VARIABLE_INIT exists. After googling a bit for it I see that gallium from mesa has some platform dependent stuff in code that uses this API like that: --- +#define pipe_static_condvar(cond) \ + /*static*/ pipe_condvar cond = CONDITION_VARIABLE_INIT --- So this structure has nothing more than a single pointer value, value 0 of it means it's initialized. I think you could just add some tests to see if it's really reset to 0 from initial value. Also regarding tests I don't think randomizing timeouts is a good idea cause it adds some unpredictable behaviour and it's not really clear if we could rely on such tests results.

2 2

Re: [PATCH 1/2] kernel32: refine conditional variable test
by Marvin Dec. 29, 2012

Dec. 29, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23659 Your paranoid android. === WXPPROSP3 (32 bit sync) === sync.c:948: Test failed: ChangeTimerQueueTimer

1 0

Re: [PATCH] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character.
by Alexandre Julliard Dec. 28, 2012

Dec. 28, 2012

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/gdi32/freetype.c | 20 +++++++++-- > dlls/gdi32/tests/font.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 102 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:3755: Test failed: expected 19, got 0 (charset 128) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/9] server: Use the same object type for both ends of a named pipe. (try 2)
by Alexandre Julliard Dec. 28, 2012

Dec. 28, 2012

Adam Martinson <adam.r.martinson(a)gmail.com> writes: > From 8eb230b505ddd986b689caf96510fbe016d721a7 Mon Sep 17 00:00:00 2001 > From: Adam Martinson <adam.r.martinson(a)gmail.com> > Date: Thu, 20 Dec 2012 19:55:13 -0600 > Subject: [PATCH 3/9] server: Use the same object type for both ends of a named pipe. > > Makes either end of a named pipe is readable after the other has been closed. > (If the pipe has not been disconnected) This is still changing way too many things at once. Also, using an array for pipe ends doesn't make much sense, just use two variables. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] advapi32: do not use invalid pSD value (Coverity)
by Marvin Dec. 28, 2012

Dec. 28, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23641 Your paranoid android. === WNT4WSSP6 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 87 === W2KPROSP4 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === WXPPROSP3 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K3R2SESP2 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0

1 0

Re: [9/9] server: Add support for named pipe message mode.
by Daniel Jelinski Dec. 27, 2012

Dec. 27, 2012

Hello, FWIW, Adam Martinson's named pipe series looks good to me. I tested it with MS SQL Server, which uses message mode pipes, and did not run into any problems. In current git I can't connect to server using named pipes, because as soon as SetNamedPipeHandleState returns false, client application aborts. (However, just changing SNPHS to return true is enough to get it working). I don't think patches 3 and 9 of this series can be split much more, except maybe for moving asserts into a separate file. Yes, reviewing them may cause headaches. The series is supposed to fix bugs 17273 (patch 8/9) and 17195 (patch 9/9). AFAICT the author is willing to make any adjustments necessary to get the patches merged. Patches 1-5 should not cause any problems if applied without the following. Patches 6-8 may cause regressions if applied without patch 9. Regards, Daniel

1 0

Re: netstat: Initial implementation
by Alexandre Julliard Dec. 27, 2012

Dec. 27, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > + __ms_va_start(parms, format); > + len = vsprintfW(output_bufW, format, parms); > + __ms_va_end(parms); You can't mix vsprintfW and ms_va_list. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.
by Vincent Povirk Dec. 27, 2012

Dec. 27, 2012

I'm pretty sure CreateBitmapFromMemory copies the data rather than referencing existing data. On Thu, Dec 27, 2012 at 3:29 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/bitmap.c | 31 +++++++++++++++++++++---------- > dlls/windowscodecs/imgfactory.c | 18 +++++++++++------- > dlls/windowscodecs/tests/bitmap.c | 5 ----- > dlls/windowscodecs/wincodecs_private.h | 1 + > 4 files changed, 33 insertions(+), 22 deletions(-) > > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index 520fdef..4d48651 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -40,6 +40,7 @@ typedef struct BitmapImpl { > int palette_set; > LONG lock; /* 0 if not locked, -1 if locked for writing, count if locked for reading */ > BYTE *data; > + BOOL owndata; > UINT width, height; > UINT stride; > UINT bpp; > @@ -260,7 +261,8 @@ static ULONG WINAPI BitmapImpl_Release(IWICBitmap *iface) > if (This->palette) IWICPalette_Release(This->palette); > This->cs.DebugInfo->Spare[0] = 0; > DeleteCriticalSection(&This->cs); > - HeapFree(GetProcessHeap(), 0, This->data); > + if (This->owndata) > + HeapFree(GetProcessHeap(), 0, This->data); > HeapFree(GetProcessHeap(), 0, This); > } > > @@ -447,28 +449,37 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl = { > }; > > HRESULT BitmapImpl_Create(UINT uiWidth, UINT uiHeight, > + UINT stride, UINT datasize, BYTE *data, > REFWICPixelFormatGUID pixelFormat, WICBitmapCreateCacheOption option, > IWICBitmap **ppIBitmap) > { > HRESULT hr; > BitmapImpl *This; > - UINT bpp, stride, datasize; > - BYTE *data; > + UINT bpp; > > hr = get_pixelformat_bpp(pixelFormat, &bpp); > if (FAILED(hr)) return hr; > > - stride = (((bpp*uiWidth)+31)/32)*4; > - datasize = stride * uiHeight; > + if (!stride) stride = (((bpp*uiWidth)+31)/32)*4; > + if (!datasize) datasize = stride * uiHeight; > + > + if (datasize < stride * uiHeight) return WINCODEC_ERR_INSUFFICIENTBUFFER; > + if (stride < (((bpp*uiWidth)+31)/32)*4) return E_INVALIDARG; > > This = HeapAlloc(GetProcessHeap(), 0, sizeof(BitmapImpl)); > - data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, datasize); > - if (!This || !data) > + if (!This) return E_OUTOFMEMORY; > + if (!data) > { > - HeapFree(GetProcessHeap(), 0, This); > - HeapFree(GetProcessHeap(), 0, data); > - return E_OUTOFMEMORY; > + data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, datasize); > + if (!data) > + { > + HeapFree(GetProcessHeap(), 0, This); > + return E_OUTOFMEMORY; > + } > + This->owndata = TRUE; > } > + else > + This->owndata = FALSE; > > This->IWICBitmap_iface.lpVtbl = &BitmapImpl_Vtbl; > This->ref = 1; > diff --git a/dlls/windowscodecs/imgfactory.c b/dlls/windowscodecs/imgfactory.c > index 54b390b..1d05ef5 100644 > --- a/dlls/windowscodecs/imgfactory.c > +++ b/dlls/windowscodecs/imgfactory.c > @@ -1,5 +1,6 @@ > /* > * Copyright 2009 Vincent Povirk for CodeWeavers > + * Copyright 2012 Dmitry Timoshkov > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -459,7 +460,7 @@ static HRESULT WINAPI ComponentFactory_CreateBitmap(IWICComponentFactory *iface, > { > TRACE("(%p,%u,%u,%s,%u,%p)\n", iface, uiWidth, uiHeight, > debugstr_guid(pixelFormat), option, ppIBitmap); > - return BitmapImpl_Create(uiWidth, uiHeight, pixelFormat, option, ppIBitmap); > + return BitmapImpl_Create(uiWidth, uiHeight, 0, 0, NULL, pixelFormat, option, ppIBitmap); > } > > static HRESULT WINAPI ComponentFactory_CreateBitmapFromSource(IWICComponentFactory *iface, > @@ -506,7 +507,7 @@ static HRESULT WINAPI ComponentFactory_CreateBitmapFromSource(IWICComponentFacto > } > > if (SUCCEEDED(hr)) > - hr = BitmapImpl_Create(width, height, &pixelformat, option, &result); > + hr = BitmapImpl_Create(width, height, 0, 0, NULL, &pixelformat, option, &result); > > if (SUCCEEDED(hr)) > { > @@ -576,12 +577,15 @@ static HRESULT WINAPI ComponentFactory_CreateBitmapFromSourceRect(IWICComponentF > } > > static HRESULT WINAPI ComponentFactory_CreateBitmapFromMemory(IWICComponentFactory *iface, > - UINT uiWidth, UINT uiHeight, REFWICPixelFormatGUID pixelFormat, UINT cbStride, > - UINT cbBufferSize, BYTE *pbBuffer, IWICBitmap **ppIBitmap) > + UINT width, UINT height, REFWICPixelFormatGUID format, UINT stride, > + UINT size, BYTE *buffer, IWICBitmap **bitmap) > { > - FIXME("(%p,%u,%u,%s,%u,%u,%p,%p): stub\n", iface, uiWidth, uiHeight, > - debugstr_guid(pixelFormat), cbStride, cbBufferSize, pbBuffer, ppIBitmap); > - return E_NOTIMPL; > + TRACE("(%p,%u,%u,%s,%u,%u,%p,%p\n", iface, width, height, > + debugstr_guid(format), stride, size, buffer, bitmap); > + > + if (!stride || !size || !buffer || !bitmap) return E_INVALIDARG; > + > + return BitmapImpl_Create(width, height, stride, size, buffer, format, WICBitmapCacheOnLoad, bitmap); > } > > static HRESULT WINAPI ComponentFactory_CreateBitmapFromHBITMAP(IWICComponentFactory *iface, > diff --git a/dlls/windowscodecs/tests/bitmap.c b/dlls/windowscodecs/tests/bitmap.c > index cec714b..3cdbffd 100644 > --- a/dlls/windowscodecs/tests/bitmap.c > +++ b/dlls/windowscodecs/tests/bitmap.c > @@ -436,27 +436,22 @@ static void test_CreateBitmapFromMemory(void) > > hr = IWICImagingFactory_CreateBitmapFromMemory(factory, 3, 3, &GUID_WICPixelFormat24bppBGR, > 0, 0, NULL, &bitmap); > -todo_wine > ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr); > > hr = IWICImagingFactory_CreateBitmapFromMemory(factory, 3, 3, &GUID_WICPixelFormat24bppBGR, > 0, sizeof(data3x3), data3x3, &bitmap); > -todo_wine > ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr); > > hr = IWICImagingFactory_CreateBitmapFromMemory(factory, 3, 3, &GUID_WICPixelFormat24bppBGR, > 6, sizeof(data3x3), data3x3, &bitmap); > -todo_wine > ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr); > > hr = IWICImagingFactory_CreateBitmapFromMemory(factory, 3, 3, &GUID_WICPixelFormat24bppBGR, > 12, sizeof(data3x3), data3x3, &bitmap); > -todo_wine > ok(hr == WINCODEC_ERR_INSUFFICIENTBUFFER, "expected WINCODEC_ERR_INSUFFICIENTBUFFER, got %#x\n", hr); > > hr = IWICImagingFactory_CreateBitmapFromMemory(factory, 3, 3, &GUID_WICPixelFormat24bppBGR, > 9, sizeof(data3x3) - 1, data3x3, &bitmap); > -todo_wine > ok(hr == WINCODEC_ERR_INSUFFICIENTBUFFER, "expected WINCODEC_ERR_INSUFFICIENTBUFFER, got %#x\n", hr); > > hr = IWICImagingFactory_CreateBitmapFromMemory(factory, 3, 3, &GUID_WICPixelFormat24bppBGR, > diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h > index 6857176..508bb2c 100644 > --- a/dlls/windowscodecs/wincodecs_private.h > +++ b/dlls/windowscodecs/wincodecs_private.h > @@ -45,6 +45,7 @@ extern HRESULT IcnsEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void* > extern HRESULT TgaDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; > > extern HRESULT BitmapImpl_Create(UINT uiWidth, UINT uiHeight, > + UINT stride, UINT datasize, BYTE *data, > REFWICPixelFormatGUID pixelFormat, WICBitmapCreateCacheOption option, > IWICBitmap **ppIBitmap) DECLSPEC_HIDDEN; > extern HRESULT BitmapScaler_Create(IWICBitmapScaler **scaler) DECLSPEC_HIDDEN; > -- > 1.8.0.2 > > >

2 3

Re: netstat: Initial implementation
by Alexandre Julliard Dec. 27, 2012

Dec. 27, 2012

André Hentschel <nerv(a)dawncrow.de> writes: > +STRINGTABLE > +{ > + IDS_TCP_UNKNOWN, "???" > + IDS_TCP_CLOSED, "CLOSED" > + IDS_TCP_LISTENING, "LISTENING" > + IDS_TCP_SYN_SENT, "SYN_SENT" > + IDS_TCP_SYN_RCVD, "SYN_RCVD" > + IDS_TCP_ESTABLISHED, "ESTABLISHED" > + IDS_TCP_FIN_WAIT1, "FIN_WAIT1" > + IDS_TCP_FIN_WAIT2, "FIN_WAIT2" > + IDS_TCP_CLOSE_WAIT, "CLOSE_WAIT" > + IDS_TCP_CLOSING, "CLOSING" > + IDS_TCP_LAST_ACK, "LAST_ACK" > + IDS_TCP_TIME_WAIT, "TIME_WAIT" > + IDS_TCP_DELETE_TCB, "DELETE_TCB" It's not useful to put these in resources, we don't want to have to translate them. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msvcrt: Return error in stat function when path is specified with trailing slash character
by Marvin Dec. 27, 2012

Dec. 27, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23632 Your paranoid android. === WNT4WSSP6 (32 bit file) === file.c:1449: Test failed: stat returned 0 file.c:1450: Test failed: errno = -559038737 file.c:1514: Test failed: stat returned 0 file.c:1515: Test failed: errno = -559038737

1 0

Re: [PATCH] loader: Build with -fno-builtin.
by Austin English Dec. 26, 2012

Dec. 26, 2012

On Mon, Dec 24, 2012 at 10:38 AM, Charles Davis <cdavis5x(a)gmail.com> wrote: > This prevents Clang from optimizing wld_memset() into a memset(3) call. > --- > loader/Makefile.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/loader/Makefile.in b/loader/Makefile.in > index 41d69c7..ece07c3 100644 > --- a/loader/Makefile.in > +++ b/loader/Makefile.in > @@ -1,4 +1,5 @@ > DEFS = -D__WINESRC__ $(EXTRADEFS) > +MODCFLAGS = -fno-builtin > > C_SRCS = \ > main.c \ > -- > 1.7.12.4 I can confirm it works. -- -Austin

1 0

Re: Aw: Re: [PATCH] comdlg32/tests: Accept win8 failure-code
by Dmitry Timoshkov Dec. 25, 2012

Dec. 25, 2012

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > >> + /* win8: E_NOTIMPL */ > >> + ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr); > > >A usual form for such comparisons is > >ok(hr == E_FAIL || hr == E_NOTIMPL /* win8 */, "got 0x%08x.\n", hr); > I disagree! > > Comments at the end of a line are ok, > but a comment in the middle /* broken */ of a line decrease /* ugly by design */ the readability > of the code /* not compiler related */ for humans/developers a lot and should be allowed > only for backwards compatibility. You are confusing a sentence and a set of statements. -- Dmitry.

1 0

Re: oledb32: Partial implementation of GetDataSource()
by Marvin Dec. 24, 2012

Dec. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23600 Your paranoid android. === WVISTAADM (32 bit database) === database: unhandled exception c000001d at 0075006C === W2K8SE (32 bit database) === database: unhandled exception c0000005 at 00750064 === W7PRO (32 bit database) === database: unhandled exception c0000005 at 007500A7 === W7PROX64 (32 bit database) === database: unhandled exception c0000005 at 00750064 === TEST64_W7SP1 (32 bit database) === database: unhandled exception c0000005 at 00750064 === W7PROX64 (64 bit database) === Timeout === TEST64_W7SP1 (64 bit database) === Timeout

1 0

Re: msvcrt: Added _stricmp_l implementation
by Marvin Dec. 24, 2012

Dec. 24, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23596 Your paranoid android. === WNT4WSSP6 (32 bit string) === string.c:2462: Test failed: _stricmp returned -1 string.c:2464: Test failed: _stricmp returned 1 === W7PROX64 (64 bit string) === string.c:2448: Test failed: _stricmp returned -25 string.c:2450: Test failed: _stricmp returned 25 string.c:2452: Test failed: _stricmp returned -20 === TEST64_W7SP1 (64 bit string) === string.c:2448: Test failed: _stricmp returned -25 string.c:2450: Test failed: _stricmp returned 25 string.c:2452: Test failed: _stricmp returned -20

1 0

re: Clang static analyzer results / wine-1.5.19-186-g1cd0c4a
by Dan Kegel Dec. 21, 2012

Dec. 21, 2012

I had a look at a couple warnings, e.g. file:///home/dank/Downloads/scan-build-2012-12-18-1/report-z07lcL.html#EndPath file:///home/dank/Downloads/scan-build-2012-12-18-1/report-9D2p5I.html#EndPath They're hard to follow, but mostly look like garbage :-( Too bad there's no web interface for marking them as checked. This one's real, but only affects a trace, and only if send fails: file:///home/dank/Downloads/scan-build-2012-12-18-1/report-RBGMAQ.html#EndPath

1 0

dsound: use event based threads, v2
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 21, 2012

Dec. 21, 2012

Maarten, > + hres = IAudioClient_GetStreamLatency(device->client, &period); > + device->sleeptime = period_ms * 5 / 2; > + ret = WaitForSingleObject(dev->sleepev, dev->sleeptime); Although it's a minor point, as we're solely discussing the case of the timeout when mmdevapi doesn't call SetEvent, I wonder why you insist on using GetStreamLatency as the basis of your timeout computations instead of GetDevicePeriod. You know that wineXYZ.drv use the device period as the basis for their SetEvent, thus IMHO the timeout too should be based on it, instead of a GetStreamLatency we know next to nothing about. If you visit testbot jobs 23521 and 23514, you'll see that I've measured the event rates. Sadly, all testbot VMs report a GetStreamLatency of 10.6666ms too close to the DefaultPeriod of 10.0000ms to tell for sure which is used as the average period. W7 and w2k8 machines seem to use DefaultPeriod: render.c:185: Returned periods: 10.0000 ms 3.0000 ms render.c:333: Returned latency: 10.6666 ms render.c:626: event after Start average 10.004ms render.c:2206: event average 9.992ms sigma 0.447 Vista may use its reported StreamLatency as period: render.c:185: Returned periods: 10.0000 ms 3.0000 ms render.c:333: Returned latency: 10.6666 ms render.c:626: event after Start average 10.697ms render.c:2206: event average 10.736ms sigma 0.834 The one w2k8 machine is peculiar as it appears to use the 15.600ms (or 15.625ms?) timers well known from pre-Vista times: render.c:185: Returned periods: 10.0000 ms 3.0000 ms render.c:333: Returned latency: 10.6666 ms render.c:626: event after Start average 15.547ms render.c:2206: event average 15.625ms sigma 5.625 However, the rate is certainly not the 20-30ms StreamLatency that e.g. winealsa returns. Regards, Jörg Höhle

2 3

Need help to install Xlib/xfree86 devlopnemt packeg in ubuntu 10 LTS
by Hamid Lohar Dec. 21, 2012

Dec. 21, 2012

Dear sir, I am installing wine 1.3 from source file but i getting fail to install beacose of Xlib/xfree86 devlopnemt packeg so i neet that packege please help me.

2 3

Re: msvcrt: fix prototypes ov _execvp, _wexecvp, _execvpe and _wexecvpe
by Alexandre Julliard Dec. 21, 2012

Dec. 21, 2012

Jérôme Gardou <jerome.gardou(a)reactos.org> writes: > --- > dlls/msvcrt/process.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) You should also fix the corresponding headers and remove the typecasts. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Added null and undefined values support to to_object
by Marvin Dec. 21, 2012

Dec. 21, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23578 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] msvcr100: Added _aligned_msize implementation
by Marvin Dec. 21, 2012

Dec. 21, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23573 Your paranoid android. === W7PROX64 (64 bit msvcr100) === msvcr100.c:344: Test failed: _aligned_msize returned 23 msvcr100.c:346: Test failed: _aligned_msize returned 23 msvcr100.c:348: Test failed: _aligned_msize returned 23 msvcr100.c:350: Test failed: _aligned_msize returned 24 msvcr100.c:357: Test failed: _aligned_msize returned 3 === TEST64_W7SP1 (64 bit msvcr100) === msvcr100.c:344: Test failed: _aligned_msize returned 23 msvcr100.c:346: Test failed: _aligned_msize returned 23 msvcr100.c:348: Test failed: _aligned_msize returned 23 msvcr100.c:350: Test failed: _aligned_msize returned 24 msvcr100.c:357: Test failed: _aligned_msize returned 3

1 0

Re: [1/2] wineps.drv: Add an ability to select device resolution from UI.
by Alexandre Julliard Dec. 21, 2012

Dec. 21, 2012

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -224,10 +229,13 @@ typedef struct > static INT_PTR CALLBACK PSDRV_PaperDlgProc(HWND hwnd, UINT msg, > WPARAM wParam, LPARAM lParam) > { > + static const WCHAR resW[] = {'%','d',' ','d','p','i',0}; > + static const WCHAR resxyW[] = {'%','d','x','%','d',' ','d','p','i',0}; The "dpi" string needs to be loaded from resources. > @@ -267,6 +275,59 @@ static INT_PTR CALLBACK PSDRV_PaperDlgProc(HWND hwnd, UINT msg, > } > SendDlgItemMessageA(hwnd, IDD_DUPLEX, CB_SETCURSEL, Cursel, 0); > } > + > + if (list_empty( &di->pi->ppd->Resolutions )) > + { > + WCHAR buf[64]; > + struct item_res_data *data; > + > + sprintfW(buf, resW, di->pi->ppd->DefaultResolution); > + SendDlgItemMessageW(hwnd, IDD_QUALITY, CB_ADDSTRING, 0, (LPARAM)buf); > + > + data = HeapAlloc(GetProcessHeap(), 0, sizeof(*data)); > + data->resx = data->resy = di->pi->ppd->DefaultResolution; > + SendDlgItemMessageW(hwnd, IDD_QUALITY, CB_SETITEMDATA, 0, (LPARAM)data); > + Cursel = 0; You don't need a data structure, you can store the values directly with something like MAKELONG. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] loader: Use a volatile pointer in wld_memset().
by Alexandre Julliard Dec. 21, 2012

Dec. 21, 2012

Charles Davis <cdavis5x(a)gmail.com> writes: > This prevents Clang from optimizing the loop into a memset(3) call. Something like -fno-builtin would be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

mmdevapi: Avoid lock contention after SetEvent.
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 21, 2012

Dec. 21, 2012

Hi, what's up with this patch? I wrote: >SetEvent is one of those calls with a high probability that the >Linux scheduler will switch to another thread, e.g. the one receiving >the event. As the critical section is still hold, it'll prevent the >receiver from invoking mmdevapi, e.g. GetCurrentPadding, without two >more thread switches (forth and back). We don't need that. Now that This->event is constant between IAC_Start and IAC_Release, thanks to my "SetEventHandle is allowed once only" patch, it's safe to move SetEvent(This->event) outside of the CS. Unlike the rejected patch about a CreateTimerQueue race condition internal to Wine (and only relevant in lock-less mode), this one is between the driver and the client app that blocks when calling e.g. GetCurrentPadding, what almost all apps will do, including our DSound http://source.winehq.org/source/dlls/dsound/mixer.c#L679 Regards, Jörg Höhle

2 2

Re: oleaut32: Indentation fix (Try 2)
by Andrew Talbot Dec. 20, 2012

Dec. 20, 2012

Sorry, I should have labelled this patch as "Try 2". -- Andy.

1 0

Fwd: [PATCH 3/8] winemac: Implement GetDeviceCaps().
by Per Johansson Dec. 20, 2012

Dec. 20, 2012

Forgot to include list somehow... On Mon, Dec 17, 2012 at 9:16 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > My main reason for using it is to test the Mac builds before pushing > commits, so not being able to build the Mac driver on it is a serious > problem (and no, it can't be upgraded apparently). I'll let you guys decide on 10.5 or 10.6, but I'd like to note that all intel Mac should be able to run 10.6, as per Apple's website <http://support.apple.com/kb/SP575>. Regards, -- Per Johansson

1 0

Re: [PATCH 2/2] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character.
by Alexandre Julliard Dec. 20, 2012

Dec. 20, 2012

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -5866,10 +5867,22 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, > return GDI_ERROR; > } > > + if (!font->orientation) { > + TEXTMETRICW tm; > + double advance = (ft_face->glyph->metrics.horiAdvance + 63) >> 6; > + get_text_metrics(incoming_font, &tm); > + if (!(tm.tmPitchAndFamily & TMPF_FIXED_PITCH) && > + (tm.tmAveCharWidth * 2) != (INT)(advance * widthRatio) && > + (tm.tmAveCharWidth * 2) == (INT)((advance + 1.0) * widthRatio)) { > + TRACE("add fullwidth character padding\n"); > + padding = 1 << 6; > + } > + } Is it really limited to orientation==0? A test case with a different orientation would be useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dsound: use event based threads, v2
by Andrew Eikum Dec. 20, 2012

Dec. 20, 2012

Looks good to me, no problems with any of the drivers. I think it'd be good to get it in on Monday, as release day is tomorrow, but that's not my call. Andrew On Wed, Dec 19, 2012 at 10:30:04AM +0100, Maarten Lankhorst wrote: > Use a thread instead of a timer for greater precision. > > Changes since v1: > - Add WARN on failure of Start or GetStreamLatency > - Set lower bound of sleep time to 5 ms > - Change upper bound of sleep time to 2.5x period > - Fixup comment > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)ubuntu.com> > --- > I like how the most useful part of the changelog always gets stripped out. > What's the point of even adding this info here? > > Obligatory "Yes I know the error handling I added isn't perfect, and I did fix that in my failure rework patch" here.. > > --- > dlls/dsound/dsound.c | 21 +++++++++++---------- > dlls/dsound/dsound_private.h | 7 ++++--- > dlls/dsound/mixer.c | 39 +++++++++++++++++++++++---------------- > dlls/dsound/primary.c | 27 ++++++++++++++++++++++++--- > 4 files changed, 62 insertions(+), 32 deletions(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index ac85ba2..381d0e1 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -670,14 +670,13 @@ ULONG DirectSoundDevice_Release(DirectSoundDevice * device) > TRACE("(%p) ref was %u\n", device, ref + 1); > if (!ref) { > int i; > - timeKillEvent(device->timerID); > - timeEndPeriod(DS_TIME_RES); > > - /* The kill event should have allowed the timer process to expire > - * but try to grab the lock just in case. Can't hold lock because > - * secondarybuffer_destroy also grabs the lock */ > - RtlAcquireResourceShared(&(device->buffer_list_lock), TRUE); > - RtlReleaseResource(&(device->buffer_list_lock)); > + SetEvent(device->sleepev); > + if (device->thread) { > + WaitForSingleObject(device->thread, INFINITE); > + CloseHandle(device->thread); > + } > + CloseHandle(device->sleepev); > > EnterCriticalSection(&DSOUND_renderers_lock); > list_remove(&device->entry); > @@ -813,6 +812,7 @@ HRESULT DirectSoundDevice_Initialize(DirectSoundDevice ** ppDevice, LPCGUID lpcG > > device->mmdevice = mmdevice; > device->guid = devGUID; > + device->sleepev = CreateEventW(0, 0, 0, 0); > > hr = DSOUND_ReopenDevice(device, FALSE); > if (FAILED(hr)) > @@ -869,9 +869,10 @@ HRESULT DirectSoundDevice_Initialize(DirectSoundDevice ** ppDevice, LPCGUID lpcG > ZeroMemory(&device->volpan, sizeof(device->volpan)); > > hr = DSOUND_PrimaryCreate(device); > - if (hr == DS_OK) > - device->timerID = DSOUND_create_timer(DSOUND_timer, (DWORD_PTR)device); > - else > + if (hr == DS_OK) { > + device->thread = CreateThread(0, 0, DSOUND_mixthread, device, 0, 0); > + SetThreadPriority(device->thread, THREAD_PRIORITY_TIME_CRITICAL); > + } else > WARN("DSOUND_PrimaryCreate failed: %08x\n", hr); > > *ppDevice = device; > diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h > index 62656a5..1a3900c 100644 > --- a/dlls/dsound/dsound_private.h > +++ b/dlls/dsound/dsound_private.h > @@ -68,9 +68,9 @@ struct DirectSoundDevice > > GUID guid; > DSCAPS drvcaps; > - DWORD priolevel; > + DWORD priolevel, sleeptime; > PWAVEFORMATEX pwfx, primary_pwfx; > - UINT timerID, playing_offs_bytes, in_mmdev_bytes, prebuf; > + UINT playing_offs_bytes, in_mmdev_bytes, prebuf; > DWORD fraglen; > LPBYTE buffer; > DWORD writelead, buflen, state, playpos, mixpos; > @@ -97,6 +97,7 @@ struct DirectSoundDevice > IAudioStreamVolume *volume; > IAudioRenderClient *render; > > + HANDLE sleepev, thread; > struct list entry; > }; > > @@ -226,7 +227,7 @@ void DSOUND_AmpFactorToVolPan(PDSVOLUMEPAN volpan) DECLSPEC_HIDDEN; > void DSOUND_RecalcFormat(IDirectSoundBufferImpl *dsb) DECLSPEC_HIDDEN; > DWORD DSOUND_secpos_to_bufpos(const IDirectSoundBufferImpl *dsb, DWORD secpos, DWORD secmixpos, float *overshot) DECLSPEC_HIDDEN; > > -void CALLBACK DSOUND_timer(UINT timerID, UINT msg, DWORD_PTR dwUser, DWORD_PTR dw1, DWORD_PTR dw2) DECLSPEC_HIDDEN; > +DWORD CALLBACK DSOUND_mixthread(void *ptr) DECLSPEC_HIDDEN; > > /* sound3d.c */ > > diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c > index 84e029b..282808e 100644 > --- a/dlls/dsound/mixer.c > +++ b/dlls/dsound/mixer.c > @@ -820,7 +820,7 @@ static void DSOUND_PerformMix(DirectSoundDevice *device) > DSOUND_PrimaryStop(device); > } > > - } else { > + } else if (device->state != STATE_STOPPED) { > > DSOUND_WaveQueue(device, TRUE); > > @@ -843,22 +843,29 @@ static void DSOUND_PerformMix(DirectSoundDevice *device) > /* **** */ > } > > -void CALLBACK DSOUND_timer(UINT timerID, UINT msg, DWORD_PTR dwUser, > - DWORD_PTR dw1, DWORD_PTR dw2) > +DWORD CALLBACK DSOUND_mixthread(void *p) > { > - DirectSoundDevice * device = (DirectSoundDevice*)dwUser; > - DWORD start_time = GetTickCount(); > - DWORD end_time; > - TRACE("(%d,%d,0x%lx,0x%lx,0x%lx)\n",timerID,msg,dwUser,dw1,dw2); > - TRACE("entering at %d\n", start_time); > - > - RtlAcquireResourceShared(&(device->buffer_list_lock), TRUE); > - > - if (device->ref) > - DSOUND_PerformMix(device); > + DirectSoundDevice *dev = p; > + TRACE("(%p)\n", dev); > > - RtlReleaseResource(&(device->buffer_list_lock)); > + while (dev->ref) { > + DWORD ret; > > - end_time = GetTickCount(); > - TRACE("completed processing at %d, duration = %d\n", end_time, end_time - start_time); > + /* > + * Some audio drivers are retarded and won't fire after being > + * stopped, add a timeout to handle this. > + */ > + ret = WaitForSingleObject(dev->sleepev, dev->sleeptime); > + if (ret == WAIT_FAILED) > + WARN("wait returned error %u %08x!\n", GetLastError(), GetLastError()); > + else if (ret != WAIT_OBJECT_0) > + WARN("wait returned %08x!\n", ret); > + if (!dev->ref) > + break; > + > + RtlAcquireResourceShared(&(dev->buffer_list_lock), TRUE); > + DSOUND_PerformMix(dev); > + RtlReleaseResource(&(dev->buffer_list_lock)); > + } > + return 0; > } > diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c > index 3ac928b..dd810fd 100644 > --- a/dlls/dsound/primary.c > +++ b/dlls/dsound/primary.c > @@ -152,6 +152,8 @@ HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) > REFERENCE_TIME prebuf_rt; > WAVEFORMATEX *wfx = NULL; > HRESULT hres; > + REFERENCE_TIME period; > + DWORD period_ms; > > TRACE("(%p, %d)\n", device, forcewave); > > @@ -192,14 +194,15 @@ HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) > prebuf_rt = (10000000 * (UINT64)prebuf_frames) / device->pwfx->nSamplesPerSec; > > hres = IAudioClient_Initialize(device->client, > - AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST, > - prebuf_rt, 0, device->pwfx, NULL); > + AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | > + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); > if(FAILED(hres)){ > IAudioClient_Release(device->client); > device->client = NULL; > WARN("Initialize failed: %08x\n", hres); > return hres; > } > + IAudioClient_SetEventHandle(device->client, device->sleepev); > > hres = IAudioClient_GetService(device->client, &IID_IAudioRenderClient, > (void**)&device->render); > @@ -234,6 +237,24 @@ HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) > return hres; > } > > + /* Now kick off the timer so the event fires periodically */ > + hres = IAudioClient_Start(device->client); > + if (FAILED(hres)) > + WARN("starting failed with %08x\n", hres); > + > + hres = IAudioClient_GetStreamLatency(device->client, &period); > + if (FAILED(hres)) { > + WARN("GetStreamLatency failed with %08x\n", hres); > + period_ms = 10; > + } else > + period_ms = (period + 9999) / 10000; > + TRACE("period %u ms fraglen %u prebuf %u\n", period_ms, device->fraglen, device->prebuf); > + > + if (period_ms < 3) > + device->sleeptime = 5; > + else > + device->sleeptime = period_ms * 5 / 2; > + > return S_OK; > } > > @@ -379,7 +400,7 @@ HRESULT DSOUND_PrimaryPlay(DirectSoundDevice *device) > TRACE("(%p)\n", device); > > hr = IAudioClient_Start(device->client); > - if(FAILED(hr)){ > + if(FAILED(hr) && hr != AUDCLNT_E_NOT_STOPPED){ > WARN("Start failed: %08x\n", hr); > return hr; > } > -- > 1.8.0 > > > >

1 0

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.
by Dmitry Timoshkov Dec. 20, 2012

Dec. 20, 2012

Huw Davies <huw(a)codeweavers.com> wrote: > typedef struct { > + WORD PosFormat; > + WORD Coverage; > + WORD ValueFormat1; > + WORD ValueFormat2; > + WORD ClassDef1; > + WORD ClassDef2; > + WORD Class1Count; > + WORD Class2Count; > + WORD Class1Record[1]; > +} GPOS_PairPosFormat2; Shouldn't this structure be 2 bytes aligned? -- Dmitry.

3 6

winepulse test data review
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 20, 2012

Dec. 20, 2012

Hi, Maarten Lankhorst wrote: >Actually in winepulse, sleep / 12000 (8 ms I guess?) ms would work, no sleep at all works too, Yes, I wanted to go no further than 8ms below the 10ms period limit. > it was just the mixing of various levels of sleep that was failing. Not sure why though, > might be something about the scheduling throwing it off. There's a perfectly simple explanation of this that applies to both winepulse and winecoreaudio. It goes as follows. IOW, there's a bug in winecoreaudio. It may explain why the test stutters on my MacOS 10.5.8 machine, regardless of how accurate or "improved" GetPosition is. winecoreaudio's IAC_ReleaseBuffer sends packets off as soon as it receives data, unlike winealsa/wineoss. Consider the sleep sequence 0 5 8 0 5 ms... + The transition 8 -> 0ms sleep is fine, as data is sent 2ms after the prior packet - The transition 0 -> 5 is most problematic, as it means that 2 ReleaseBuffer will be 15ms apart, even though only 10ms of data was sent. I believe winepulse is affected by this too, like winecoreaudio. The stable sequences "always 0" or "always 8ms sleep" are paced regularly, so underruns are avoided as long as the OS schedules the threads soon enough. Winealsa and wineOSS are not affected, as they write data on the 10ms period boundaries, -- like native presumably does. winecoreaudio solution paths: - write packets on period tick, not at release time - or add silence lead-in - or delay first packet until period tick only (if small) - or ... I think it should be possible to produce reliable continuous sound in winepulse and winecoreaudio yet maintain their current "send packet" codebase instead of transitioning to a separate buffer that winealsa and wineoss use. Regards, Jörg Höhle

3 2

Re: msxml3: Add custom handling for DISPID_VALUE for node map
by Jacek Caban Dec. 20, 2012

Dec. 20, 2012

On 12/19/12 08:24, Nikolay Sivov wrote: > Add custom handling for DISPID_VALUE for node map If this has to be done for all IDispatchEx objects with DISPID_VALUE, it may be worth considering changing dispex.c. Something like: if(id == DISPID_VALUE && wFlags == DISPATCH_METHOD) wFlags |= DISPATCH_PROPERTYGET; before ITypeInfo::Invoke call should do the trick and replace both this patch and already committed node list patch. Cheers, Jacek

2 3

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib (Try 3, resend)
by Nikolay Sivov Dec. 20, 2012

Dec. 20, 2012

On 12/20/2012 14:50, Tatyana Fokina wrote: Hi, Tatyana. Main problem is that your test will crash if run without patch 2/2, that's not how it should be done. You need to merge these patches together to keep tests working or send implementation fix first, so next test patch will work. > + hr = ITypeInfo2_GetContainingTypeLib(ti2, (ITypeLib **)&tl, &Index); > + ok(hr == S_OK, " ITypeInfo2_GetContainingTypeLib failed on Index\n"); > + if(tl) ITypeLib_Release(tl); You don't need a cast here. > + hr = ITypeInfo2_GetContainingTypeLib(ti2, NULL, &Index); > + ok(hr == S_OK, " ITypeInfo2_GetContainingTypeLib failed on ITypeLib = NULL\n"); Please test index value here and above to make sure it really returns something.

1 0